metze/wireshark/wip.git
19 years agoExplicitly print gratuitous arp requests as such
Jörg Mayer [Thu, 17 Jun 2004 08:32:59 +0000 (08:32 -0000)]
Explicitly print gratuitous arp requests as such

svn path=/trunk/; revision=11163

19 years agoFrom Dave Sclarsky: add support for "multiple instances", and add
Guy Harris [Thu, 17 Jun 2004 07:10:33 +0000 (07:10 -0000)]
From Dave Sclarsky: add support for "multiple instances", and add
additional hidden fields for use as filters.

svn path=/trunk/; revision=11162

19 years agoThe short name for AAL 3/4 should be "AAL3/4", not "AAL3_4" (even though
Guy Harris [Wed, 16 Jun 2004 23:36:57 +0000 (23:36 -0000)]
The short name for AAL 3/4 should be "AAL3/4", not "AAL3_4" (even though
the *filter* name is "aal3_4").

svn path=/trunk/; revision=11161

19 years agoAs long as any text has been put into a time interval string, the next
Guy Harris [Wed, 16 Jun 2004 23:09:43 +0000 (23:09 -0000)]
As long as any text has been put into a time interval string, the next
clause we add will have to have ", " separating it from the text before
it.

svn path=/trunk/; revision=11160

19 years agoCompletly change parsing of "From" and "To" lines to fix a problem with finding ...
Anders Broman [Wed, 16 Jun 2004 18:20:49 +0000 (18:20 -0000)]
Completly change parsing of "From" and "To" lines to fix a problem with finding "tag"
add and export "dfilter_store_sip_from_addr" to make it possible to filter on
SIP url:s in multiple dissectors and some wite space changes.

svn path=/trunk/; revision=11159

19 years agoTo return an EOF indication, return FALSE from the read routine *AND*
Guy Harris [Wed, 16 Jun 2004 08:11:59 +0000 (08:11 -0000)]
To return an EOF indication, return FALSE from the read routine *AND*
set "*err" to 0, rather than leaving what random value happened to be in
"*err" there.

svn path=/trunk/; revision=11158

19 years agoUse "format_text()" on strings, so we handle non-printable characters.
Guy Harris [Wed, 16 Jun 2004 07:51:21 +0000 (07:51 -0000)]
Use "format_text()" on strings, so we handle non-printable characters.

Clean up white space a bit.

svn path=/trunk/; revision=11157

19 years agoNote that the reason why there's parser state that stays around after
Guy Harris [Wed, 16 Jun 2004 07:33:46 +0000 (07:33 -0000)]
Note that the reason why there's parser state that stays around after
the parse finishes (forcing us to feed the parser an end-of-input even
after an error) is that we don't create a new parser object when we
start a new parse and don't destroy it when the parse finishes.

svn path=/trunk/; revision=11156

19 years agoFrom Yaniv Kaul: Switch from the DPD draft to RFC 3706.
Gerald Combs [Tue, 15 Jun 2004 18:47:24 +0000 (18:47 -0000)]
From Yaniv Kaul: Switch from the DPD draft to RFC 3706.

svn path=/trunk/; revision=11155

19 years agoFrom Thomas Anders: Navigating from RTP/RTCP packets to setup where it was set up
Anders Broman [Tue, 15 Jun 2004 18:26:08 +0000 (18:26 -0000)]
From Thomas Anders:  Navigating from RTP/RTCP packets to setup where it was set up

svn path=/trunk/; revision=11154

19 years agoAdd and entry for 03-00-C7-00-00-EE (HP/Compaq ProLiant NIC teaming).
Gerald Combs [Tue, 15 Jun 2004 18:25:04 +0000 (18:25 -0000)]
Add and entry for 03-00-C7-00-00-EE (HP/Compaq ProLiant NIC teaming).
The protocol is documented at http://www.hp.com/sbso/bus_protect/teaming.pdf
if anyone wants to write a dissector.

svn path=/trunk/; revision=11153

19 years agoFrom Graeme Hewson:
Guy Harris [Tue, 15 Jun 2004 10:38:14 +0000 (10:38 -0000)]
From Graeme Hewson:

Add a #define to enable parser tracing.

Clean up parser state when finished parsing, even if we stopped
parsing due to a syntax error, so that there's nothing left
around to screw up the next parse.

svn path=/trunk/; revision=11152

19 years agoFrom Graeme Hewson: fix a debug message.
Guy Harris [Tue, 15 Jun 2004 10:16:10 +0000 (10:16 -0000)]
From Graeme Hewson: fix a debug message.

svn path=/trunk/; revision=11151

19 years agoFrom Jean-Baptiste Marchand: fix up a couple of #defines that collided
Guy Harris [Tue, 15 Jun 2004 09:50:57 +0000 (09:50 -0000)]
From Jean-Baptiste Marchand: fix up a couple of #defines that collided
with existing defines.

svn path=/trunk/; revision=11150

19 years agoFrom Philippe Mazeau: T.35 codes for Swissvoice.
Guy Harris [Tue, 15 Jun 2004 09:43:19 +0000 (09:43 -0000)]
From Philippe Mazeau: T.35 codes for Swissvoice.

svn path=/trunk/; revision=11149

19 years agoFrom Greg Morris: dissect the first packet in a packet burst connection
Guy Harris [Tue, 15 Jun 2004 09:30:54 +0000 (09:30 -0000)]
From Greg Morris: dissect the first packet in a packet burst connection
(NCP type 7777).

svn path=/trunk/; revision=11148

19 years agoFrom Greg Morris:
Guy Harris [Tue, 15 Jun 2004 09:23:59 +0000 (09:23 -0000)]
From Greg Morris:

Fix a bug in the dissection of multiple NDS messages being sent
at the same time that the dissector was attempting to desegment
data spanning multiple packets.  When a message was encountered
during the desegmentation code the dissector would
misinterpret the new message as an element in the data stream.
Code was added to validate the desegmentation handle and
validate which messages actually contain segmented data.

svn path=/trunk/; revision=11147

19 years agoFrom Greg Morris:
Guy Harris [Tue, 15 Jun 2004 09:14:14 +0000 (09:14 -0000)]
From Greg Morris:

a few updates to ncp2222.py to include more detail to summary
window for NCP's 26, 28, 30;

fixed NCP 87/31 to not show as malformed when HandleInfoLevel
contains value 0x00.

svn path=/trunk/; revision=11146

19 years agoadded a section describing the problems with MSVC 7 compiler
Ulf Lamping [Mon, 14 Jun 2004 22:38:57 +0000 (22:38 -0000)]
added a section describing the problems with MSVC 7 compiler
(as I don't use it myself, please correct me if anything is wrong)

svn path=/trunk/; revision=11145

19 years agoFrom Ainsley Pereira: add a text description PT_CN_OLD.
Guy Harris [Sat, 12 Jun 2004 08:56:05 +0000 (08:56 -0000)]
From Ainsley Pereira: add a text description PT_CN_OLD.

svn path=/trunk/; revision=11144

19 years agoOn Windows, if "get_interface_list()" returns CANT_GET_INTERFACE_LIST
Guy Harris [Sat, 12 Jun 2004 07:47:14 +0000 (07:47 -0000)]
On Windows, if "get_interface_list()" returns CANT_GET_INTERFACE_LIST
and the error message includes "Not enough storage is available
to process this command" or "The operation completed successfully",
suggest that the user install a WinPcap version later than 3.0 - this is
definitely a Frequently Asked Question on the Ethereal list.

svn path=/trunk/; revision=11143

19 years agoFrom Jean-Baptiste Marchand:
Guy Harris [Sat, 12 Jun 2004 04:12:07 +0000 (04:12 -0000)]
From Jean-Baptiste Marchand:

 - NetrJoinDomain2 and NetrUnJoinDomain2 (can be used to remotely join a
   machine to an Active Directory domain, typically with the JOIN and
   UNJOIN of the netdom utility)

 - NetrRenameMachineInDomain2

 - NetrAddAlternateComputerName and NetrRemoveAlternateComputerName
   (operations added in Windows XP)

All these operations carry a blob (524 bytes) containing an encrypted
version of the password of the account with domain administration
credentials, currently displayed as hex data because the format of this
blob is currently unknown (at least, for me).

svn path=/trunk/; revision=11142

19 years agoupdate asn1 compiler to (hopefully) handle BER SET OF constructs
Ronnie Sahlberg [Sat, 12 Jun 2004 02:08:34 +0000 (02:08 -0000)]
update asn1 compiler to (hopefully) handle BER SET OF constructs

svn path=/trunk/; revision=11141

19 years agoParameter 8 to dissect_ber_bistring() is the ett_ variable (or -1) and not
Ronnie Sahlberg [Sat, 12 Jun 2004 01:34:29 +0000 (01:34 -0000)]
Parameter 8 to dissect_ber_bistring() is the ett_ variable (or -1) and not
a NULL **proto_tree pointer.

Set the ett variable to always be -1 for the time being

svn path=/trunk/; revision=11140

19 years agoFrom Tomas Kukosa updates to the ASN1 compiler
Ronnie Sahlberg [Sat, 12 Jun 2004 01:21:02 +0000 (01:21 -0000)]
From Tomas Kukosa   updates to the ASN1 compiler

Change doc string to not specificly state it is for PER
Temporary/Partial fix for the tag of impoerted types.

svn path=/trunk/; revision=11139

19 years agoHack to remove epan/config.h
Jörg Mayer [Fri, 11 Jun 2004 15:23:42 +0000 (15:23 -0000)]
Hack to remove epan/config.h

svn path=/trunk/; revision=11138

19 years agofix the presentation of readcapacity to show the real number of MB or GB instead...
Ronnie Sahlberg [Fri, 11 Jun 2004 08:33:58 +0000 (08:33 -0000)]
fix the presentation of readcapacity to show the real number of MB or GB instead of just a random fake value.

svn path=/trunk/; revision=11137

19 years agoMove "dfilter_expr_dlg_delete_event_cb()" after
Guy Harris [Thu, 10 Jun 2004 20:16:50 +0000 (20:16 -0000)]
Move "dfilter_expr_dlg_delete_event_cb()" after
"dfilter_expr_dlg_cancel_cb()" to avoid use-before-declaration warnings.

svn path=/trunk/; revision=11136

19 years agosome more encryption types and checksum types
Ronnie Sahlberg [Thu, 10 Jun 2004 13:33:50 +0000 (13:33 -0000)]
some more encryption types and checksum types

svn path=/trunk/; revision=11135

19 years agoFrom Laurent Rabret:
Guy Harris [Thu, 10 Jun 2004 10:12:30 +0000 (10:12 -0000)]
From Laurent Rabret:

- associate standard trace file extensions to ethereal *only*
  if such extensions are not already known in the system;

- suppress the linking while Ethereal is uninstalling *only*
  for extensions associated to Ethereal.

svn path=/trunk/; revision=11134

19 years ago"delete_event" is an event, so its handler takes three arguments, not
Guy Harris [Thu, 10 Jun 2004 10:09:58 +0000 (10:09 -0000)]
"delete_event" is an event, so its handler takes three arguments, not
two, and it returns a gboolean.

svn path=/trunk/; revision=11133

19 years agoFrom Stas Grabois: don't show disabled protocols in the "Add Expression"
Guy Harris [Thu, 10 Jun 2004 09:47:25 +0000 (09:47 -0000)]
From Stas Grabois: don't show disabled protocols in the "Add Expression"
and "Decode As" dialogs (so that you can cut down the size of the
protocol lists in those dialogs by disabling "uninteresting" protocols).

svn path=/trunk/; revision=11132

19 years agoMove the ring-buffer tests from "process_packet()" to
Guy Harris [Thu, 10 Jun 2004 08:01:51 +0000 (08:01 -0000)]
Move the ring-buffer tests from "process_packet()" to
"capture_pcap_cb()"; they're only done in live captures, and that
arranges that "process_packet()" gets called with the correct
wtap_dumper for the current file even if we switch to a new file.

Move the packet-count reporting out of "write_packet()" to
"capture_pcap_cb()" as well, as that's also only done in live captures.
That pretty much guts "write_packet()", so just move what's left up to
"process_packet()".

svn path=/trunk/; revision=11131

20 years agoRemove config.nmake dependencies from epan/Makefile.am and gtk/Makefile.am.
Gerald Combs [Wed, 9 Jun 2004 19:20:46 +0000 (19:20 -0000)]
Remove config.nmake dependencies from epan/Makefile.am and gtk/Makefile.am.

svn path=/trunk/; revision=11130

20 years agoDCERPC problem reported by JBM and identified by Todd Sabin
Ronnie Sahlberg [Wed, 9 Jun 2004 09:24:07 +0000 (09:24 -0000)]
DCERPC problem reported by JBM and identified by Todd Sabin

Other protocol, not only SMB will populate pinfo->private_data
thus   checking for existence of non-NULL pinfo->private_data is not sufficient
to determine   we have SMB data and this is what it is.

Refactor the adding of salt/FID from lower layer protocols and generalize it.
Create a new dissector_handle specific for SMB so that we know that IFF we came in through that handle, then whatever pinfo->private_data is what we expect it to be.

svn path=/trunk/; revision=11129

20 years agoAdd Automake/Autoconf Doxygen targets.
Gerald Combs [Wed, 9 Jun 2004 03:08:13 +0000 (03:08 -0000)]
Add Automake/Autoconf Doxygen targets.

svn path=/trunk/; revision=11128

20 years agoadd details for doxygen
Ulf Lamping [Tue, 8 Jun 2004 05:42:57 +0000 (05:42 -0000)]
add details for doxygen

svn path=/trunk/; revision=11127

20 years agoAdd an encapsulation type for BACnet MS/TP, and map the newly-assigned
Guy Harris [Mon, 7 Jun 2004 20:28:51 +0000 (20:28 -0000)]
Add an encapsulation type for BACnet MS/TP, and map the newly-assigned
libpcap DLT_ value for BACnet MS/TP to it.

svn path=/trunk/; revision=11126

20 years agoDon't define or set "txt" in "text_page_redraw()" for GTK+ 2.x, as we
Guy Harris [Mon, 7 Jun 2004 19:49:37 +0000 (19:49 -0000)]
Don't define or set "txt" in "text_page_redraw()" for GTK+ 2.x, as we
don't use it in that case.

svn path=/trunk/; revision=11125

20 years agoupdate to the asn1 compiler.
Ronnie Sahlberg [Mon, 7 Jun 2004 07:44:36 +0000 (07:44 -0000)]
update to the asn1 compiler.

Do not output the value definitions for enumerated integers twice.
the c compiler doesnt like when the same symbol is declared twice.

svn path=/trunk/; revision=11124

20 years agoAdd a "force_separators" parameter to hex_str_to_bytes so that it's
Gerald Combs [Sun, 6 Jun 2004 14:29:07 +0000 (14:29 -0000)]
Add a "force_separators" parameter to hex_str_to_bytes so that it's
possible to paste in WEP keys without any separators.

Add doxygen comments to strutil.h.

svn path=/trunk/; revision=11123

20 years agoadd more details for doxygen
Ulf Lamping [Sat, 5 Jun 2004 13:28:13 +0000 (13:28 -0000)]
add more details for doxygen

svn path=/trunk/; revision=11122

20 years agoadd more details for doxygen
Ulf Lamping [Sat, 5 Jun 2004 12:12:13 +0000 (12:12 -0000)]
add more details for doxygen

svn path=/trunk/; revision=11121

20 years agoYaniv Kaul: Add some more UUID decoding on Windows
Jörg Mayer [Sat, 5 Jun 2004 11:44:14 +0000 (11:44 -0000)]
Yaniv Kaul: Add some more UUID decoding on Windows

svn path=/trunk/; revision=11120

20 years agoadd more details for doxygen
Ulf Lamping [Sat, 5 Jun 2004 11:03:14 +0000 (11:03 -0000)]
add more details for doxygen

svn path=/trunk/; revision=11119

20 years agoalyways use SIGNAL_EMIT_BY_NAME with one user parameter,
Ulf Lamping [Sat, 5 Jun 2004 10:27:38 +0000 (10:27 -0000)]
alyways use SIGNAL_EMIT_BY_NAME with one user parameter,
remove SIGNAL_EMIT_BY_NAME1 completely

svn path=/trunk/; revision=11118

20 years agoremove gtk_widget_ref / OBJECT_SET_DATA_FULL,
Ulf Lamping [Sat, 5 Jun 2004 10:13:37 +0000 (10:13 -0000)]
remove gtk_widget_ref / OBJECT_SET_DATA_FULL,
as reference handling is done by GTK, so doing it is pretty useless

svn path=/trunk/; revision=11117

20 years agoRename the type UCTTime to UTCTime as per X.680
Ronnie Sahlberg [Sat, 5 Jun 2004 09:59:45 +0000 (09:59 -0000)]
Rename the type UCTTime to UTCTime as per X.680

get rid of a compiler warning.

svn path=/trunk/; revision=11116

20 years agocut text_page related things from help_page.c and
Ulf Lamping [Sat, 5 Jun 2004 09:57:11 +0000 (09:57 -0000)]
cut text_page related things from help_page.c and
move into new file text_page.c

svn path=/trunk/; revision=11115

20 years agofrom tomas anders more packetcable stuff
Ronnie Sahlberg [Sat, 5 Jun 2004 02:57:48 +0000 (02:57 -0000)]
from tomas anders   more packetcable stuff
new protocol :   PacketCable MTA FQDN

svn path=/trunk/; revision=11114

20 years agofrom JBM: updates to SAMR and LSA
Ronnie Sahlberg [Sat, 5 Jun 2004 02:40:23 +0000 (02:40 -0000)]
from JBM:   updates to SAMR and LSA

svn path=/trunk/; revision=11113

20 years agoMake the definition of "simple_dialog()" match its declaration.
Guy Harris [Fri, 4 Jun 2004 21:12:01 +0000 (21:12 -0000)]
Make the definition of "simple_dialog()" match its declaration.

Make the "type" argument to "vsimple_dialog()" also be an ESD_TYPE_E.

svn path=/trunk/; revision=11112

20 years agobugfix: when saving connectionless DCERPC fragments,
Ulf Lamping [Fri, 4 Jun 2004 20:15:30 +0000 (20:15 -0000)]
bugfix: when saving connectionless DCERPC fragments,
add a hashed activity_id to the sequence number. This will prevent
missdissected fragments.

svn path=/trunk/; revision=11111

20 years agoadd more details for doxygen
Ulf Lamping [Fri, 4 Jun 2004 20:05:31 +0000 (20:05 -0000)]
add more details for doxygen

svn path=/trunk/; revision=11110

20 years agoadd details for doxygen
Ulf Lamping [Fri, 4 Jun 2004 20:04:34 +0000 (20:04 -0000)]
add details for doxygen

svn path=/trunk/; revision=11109

20 years agoupdate DOXYGEN setting and add new HHC (MS html help compiler) setting
Ulf Lamping [Fri, 4 Jun 2004 17:31:11 +0000 (17:31 -0000)]
update DOXYGEN setting and add new HHC (MS html help compiler) setting

svn path=/trunk/; revision=11108

20 years agoadd more details for doxygen
Ulf Lamping [Fri, 4 Jun 2004 17:19:01 +0000 (17:19 -0000)]
add more details for doxygen

svn path=/trunk/; revision=11107

20 years agouse the dot tool
Ulf Lamping [Fri, 4 Jun 2004 17:18:39 +0000 (17:18 -0000)]
use the dot tool

svn path=/trunk/; revision=11106

20 years agoget rid of a compiler warning
Ronnie Sahlberg [Fri, 4 Jun 2004 11:35:14 +0000 (11:35 -0000)]
get rid of a compiler warning

svn path=/trunk/; revision=11105

20 years agoTomas updates to H235 and the ASN2ETH compiler
Ronnie Sahlberg [Fri, 4 Jun 2004 11:28:04 +0000 (11:28 -0000)]
Tomas updates to H235 and the ASN2ETH compiler

svn path=/trunk/; revision=11104

20 years agoFrom Devin Heitmueller: Fix some compilation warnings.
Gerald Combs [Fri, 4 Jun 2004 03:58:25 +0000 (03:58 -0000)]
From Devin Heitmueller: Fix some compilation warnings.

svn path=/trunk/; revision=11103

20 years agoAs Mark Corley pointed out, win32-setup.sh should be part of the distribution.
Gerald Combs [Fri, 4 Jun 2004 03:25:35 +0000 (03:25 -0000)]
As Mark Corley pointed out, win32-setup.sh should be part of the distribution.

svn path=/trunk/; revision=11102

20 years agoAdd a mechanism where one can provide callbacks to the kerbgeros dissector
Ronnie Sahlberg [Fri, 4 Jun 2004 01:56:25 +0000 (01:56 -0000)]
Add a mechanism where one can provide callbacks to the kerbgeros dissector
to pass back dissection of application specific fields (octet strings)

This can later be used to pick up session keys by dcerpc and similar.
Currently it will initially be used by packetcable.

PacketCable additions by Thomas Anders

svn path=/trunk/; revision=11101

20 years agoFix crash bug in sid snooping if we don't have a policy name for a
Tim Potter [Fri, 4 Jun 2004 00:15:55 +0000 (00:15 -0000)]
Fix crash bug in sid snooping if we don't have a policy name for a
handle in a samr_query_dispinfo.

svn path=/trunk/; revision=11100

20 years agoNew protocol : DNP
Ronnie Sahlberg [Fri, 4 Jun 2004 00:12:12 +0000 (00:12 -0000)]
New protocol : DNP
From Graham Bloice

svn path=/trunk/; revision=11099

20 years agoFix bug to do with renaming lsa.domain_sid to nt.domain_sid to get
Tim Potter [Fri, 4 Jun 2004 00:05:56 +0000 (00:05 -0000)]
Fix bug to do with renaming lsa.domain_sid to nt.domain_sid to get
sid snooping working again.

svn path=/trunk/; revision=11098

20 years agoadd dissection of the ms rap netserverenum3 function
Ronnie Sahlberg [Thu, 3 Jun 2004 23:55:57 +0000 (23:55 -0000)]
add dissection of the ms rap netserverenum3 function

svn path=/trunk/; revision=11097

20 years agoMake static some routines and variables not used outside the source file
Guy Harris [Thu, 3 Jun 2004 21:46:27 +0000 (21:46 -0000)]
Make static some routines and variables not used outside the source file
defining them.

Move declarations of some callbacks outside the source files using them
into the appropriate header, and arrange that the appropriate header is
included by those source files.

Move the SAT_E definition into a "sat.h" file, included both by
"endpoint_talkers_table.h" and "hostlist_table.h", so that both of the
latter headers can be included by the same file ("menu.c" has to include
both, as per the change in the previous paragraph).

svn path=/trunk/; revision=11096

20 years ago"gtk_file_selection_set_filename()" doesn't work with a GtkFileChooser,
Guy Harris [Thu, 3 Jun 2004 21:17:06 +0000 (21:17 -0000)]
"gtk_file_selection_set_filename()" doesn't work with a GtkFileChooser,
and "gtk_file_chooser_set_filename()" requires an absolute path, so ""
isn't valid.  Get rid of the "gtk_file_selection_set_filename()" call in
"file_selection_new()".

Put in a comment asking why we're using
"gtk_file_selection_set_filename()" at all.

svn path=/trunk/; revision=11095

20 years agoRe-generate from the updated asn2eth script and h235.cnf files.
Guy Harris [Thu, 3 Jun 2004 19:07:05 +0000 (19:07 -0000)]
Re-generate from the updated asn2eth script and h235.cnf files.

svn path=/trunk/; revision=11094

20 years agomonthly update
Jörg Mayer [Thu, 3 Jun 2004 16:35:57 +0000 (16:35 -0000)]
monthly update

svn path=/trunk/; revision=11093

20 years agoFrom Lars Roland: Add have_tap_listeners() and rtp_payload_type_vals
Gerald Combs [Thu, 3 Jun 2004 16:29:39 +0000 (16:29 -0000)]
From Lars Roland: Add have_tap_listeners() and rtp_payload_type_vals
to libethereal.def.

svn path=/trunk/; revision=11092

20 years agoenable chm file generation for doxygen,
Ulf Lamping [Thu, 3 Jun 2004 14:57:23 +0000 (14:57 -0000)]
enable chm file generation for doxygen,
move chm filename setting to module specific config file

svn path=/trunk/; revision=11091

20 years agoadd details for doxygen
Ulf Lamping [Thu, 3 Jun 2004 14:54:26 +0000 (14:54 -0000)]
add details for doxygen

svn path=/trunk/; revision=11090

20 years agoFrom Tomas Kukosa: unnecessary types are excluded with NO_EMIT
Guy Harris [Thu, 3 Jun 2004 08:35:44 +0000 (08:35 -0000)]
From Tomas Kukosa: unnecessary types are excluded with NO_EMIT
directive.

svn path=/trunk/; revision=11089

20 years agoFrom Tomas Kukosa:
Guy Harris [Thu, 3 Jun 2004 08:33:29 +0000 (08:33 -0000)]
From Tomas Kukosa:

  - limits for dissect_per_constrained_integer() are passed as unsigned
    if possible
  - new directive NO_EMIT in conformation file - avoids emitting
    function body (or vals or both) into packet-xxxx-fn.c file
  - new directive USER_DEFINED in conformation file - emitting of
    function body (or vals or both) in the packet-xxxx-fn.c file is
    replaced with external declaration
  - support for SET OF type for BER
  - flag WITH_VALS is default for EXPORTS, USER_DEFINED, NO_EMIT
    directives
  - the _U_ attribute is used for pinfo parameters
  - the offset parameters and return codes are changed from guint32 to
    int

svn path=/trunk/; revision=11088

20 years agoFrom Yaniv Kaul: add SOCKS v4a support.
Guy Harris [Thu, 3 Jun 2004 08:04:07 +0000 (08:04 -0000)]
From Yaniv Kaul: add SOCKS v4a support.

Clean up handling of null-terminated strings.

svn path=/trunk/; revision=11087

20 years agoFrom Graeme Hewson:
Guy Harris [Thu, 3 Jun 2004 07:37:49 +0000 (07:37 -0000)]
From Graeme Hewson:

     Remove reference to negative slice lengths.

     Clean and polish.

svn path=/trunk/; revision=11086

20 years agoFrom Graeme Hewson:
Guy Harris [Thu, 3 Jun 2004 07:36:25 +0000 (07:36 -0000)]
From Graeme Hewson:

     Use gint32 instead of guint32 for node data.

Fix up some other signed-vs-unsigned issues in the display filter
parser and lexical analyzer.

svn path=/trunk/; revision=11085

20 years agoFrom Graeme Hewson:
Guy Harris [Thu, 3 Jun 2004 07:34:49 +0000 (07:34 -0000)]
From Graeme Hewson:

     Fix assertion failure when absolute value of negative slice
     offset > field length.

     Remove code for handling negative slice lengths.

svn path=/trunk/; revision=11084

20 years agoFrom Graeme Hewson:
Guy Harris [Thu, 3 Jun 2004 07:33:46 +0000 (07:33 -0000)]
From Graeme Hewson:

     Check slice lengths as well as offsets.  Disallow negative/zero
     lengths.

     Range on RHS of display filter expression wasn't being checked in
     every case.

svn path=/trunk/; revision=11083

20 years agoFrom Graeme Hewson:
Guy Harris [Thu, 3 Jun 2004 07:17:24 +0000 (07:17 -0000)]
From Graeme Hewson:

     Use gint32 instead of guint32 and strtol() instead of strtoul()
     for signed integers.

     Pathological slice specifications could cause Flex default rule
     to be invoked, echoing characters to stdout.
     Example: frame[0foo]==1

svn path=/trunk/; revision=11082

20 years agoFrom Devin Heitmueller: improve decoding of outgoing and incoming
Guy Harris [Thu, 3 Jun 2004 04:19:38 +0000 (04:19 -0000)]
From Devin Heitmueller: improve decoding of outgoing and incoming
message blocks.

svn path=/trunk/; revision=11081

20 years agoFrom Mike Frisch:
Guy Harris [Thu, 3 Jun 2004 04:13:24 +0000 (04:13 -0000)]
From Mike Frisch:

- fixed tree display of NFSv4 change_info type;
- add OPEN4_RESULT_LOCKTYPE_POSIX to OPEN result (reply) flags;
- fixed open_delegation4 dissector;

svn path=/trunk/; revision=11080

20 years agoMake the definition of "register_tap_menu_item()" match its declaration.
Guy Harris [Thu, 3 Jun 2004 02:14:50 +0000 (02:14 -0000)]
Make the definition of "register_tap_menu_item()" match its declaration.

svn path=/trunk/; revision=11079

20 years agoFix a typo.
Guy Harris [Thu, 3 Jun 2004 02:14:14 +0000 (02:14 -0000)]
Fix a typo.

svn path=/trunk/; revision=11078

20 years agoadd details for doxygen
Ulf Lamping [Wed, 2 Jun 2004 22:13:04 +0000 (22:13 -0000)]
add details for doxygen

svn path=/trunk/; revision=11077

20 years agoadd details for doxygen
Ulf Lamping [Wed, 2 Jun 2004 20:14:51 +0000 (20:14 -0000)]
add details for doxygen

svn path=/trunk/; revision=11076

20 years agoIf, when rotating capture files, the attempt to close the current file
Guy Harris [Wed, 2 Jun 2004 18:49:40 +0000 (18:49 -0000)]
If, when rotating capture files, the attempt to close the current file
fails, set "rb_data.pdh" to NULL, so we know it's not open (if
"wtap_dump_close()" fails, the wtap_dumper_t is still closed - and the
file descriptor for it is probably closed, too, as, if "close()" fails,
the FD is probably closed; the Single UNIX Specification Version 3 says
the state of the FD is unspecified, but in practice most OSes probably
still close it).

If we try to close the current file, first check to make sure it's open,
i.e. that "rb_data.pdh" is non-null.  (Or perhaps we should avoid trying
to close it if the open *or* the most recent attempt to rotate the
capture files failed.)

Note that if "wtap_dump_close()" fails we might not need to close the
underlying file descriptor (and, even if we do, there's no guarantee
that attempt won't also fail and leave the FD still open - which is why
I suspect that a failed "close()" leaves the FD closed on most OSes).

svn path=/trunk/; revision=11075

20 years agoadd details for doxygen
Ulf Lamping [Wed, 2 Jun 2004 18:44:10 +0000 (18:44 -0000)]
add details for doxygen

svn path=/trunk/; revision=11074

20 years agomove "extern GtkWidget *main_display_filter_widget" from
Ulf Lamping [Wed, 2 Jun 2004 07:12:11 +0000 (07:12 -0000)]
move "extern GtkWidget *main_display_filter_widget" from
various stats files to gtkglobals.h

svn path=/trunk/; revision=11073

20 years agoGet rid of the #if 0'ed out "rtp_payload_type_vals[]" table - we should
Guy Harris [Wed, 2 Jun 2004 07:01:04 +0000 (07:01 -0000)]
Get rid of the #if 0'ed out "rtp_payload_type_vals[]" table - we should
be using the one from libethereal.

svn path=/trunk/; revision=11072

20 years agoFrom Mike Frisch:
Guy Harris [Wed, 2 Jun 2004 06:50:28 +0000 (06:50 -0000)]
From Mike Frisch:

add support for NFSv4 RELEASE_LOCKOWNER and ILLEGAL operations;

minor modification to the NFSv4 NULLPROC dissection.

svn path=/trunk/; revision=11071

20 years agofix a doxygen comment
Ulf Lamping [Wed, 2 Jun 2004 06:44:40 +0000 (06:44 -0000)]
fix a doxygen comment

svn path=/trunk/; revision=11070

20 years agoFrom Yaniv Kaul: HKP is HTTP-based and runs on port 11371.
Guy Harris [Wed, 2 Jun 2004 06:35:57 +0000 (06:35 -0000)]
From Yaniv Kaul: HKP is HTTP-based and runs on port 11371.

svn path=/trunk/; revision=11069

20 years agoFrom Magnus Hansson: add more information to the Info column.
Guy Harris [Wed, 2 Jun 2004 06:30:15 +0000 (06:30 -0000)]
From Magnus Hansson: add more information to the Info column.

Use "tvb_format_stringzpad()" to put a zero-padded string into the
protocol tree and Info column, so that we 1) don't use a fixed-length
buffer that we might overflow and 2) we handle non-printable bytes in
the string.

svn path=/trunk/; revision=11068

20 years agoDon't define data variables in header files included by more than one
Guy Harris [Tue, 1 Jun 2004 23:08:00 +0000 (23:08 -0000)]
Don't define data variables in header files included by more than one
file - that keeps the variable from being shared, and also produces
compiler warnings if the variable isn't used by all the files that
include the header in question.

svn path=/trunk/; revision=11067

20 years agoMake the definition of "add_hostlist_table_data()" match its
Guy Harris [Tue, 1 Jun 2004 23:00:24 +0000 (23:00 -0000)]
Make the definition of "add_hostlist_table_data()" match its
declaration.

Give the address and port arguments to "add_hostlist_table_data()"
appropriate names and Doxygen comments (they're not a source address and
port, they're just an address and port), and do the same for the address
and port members of a "hostlist_talker_t".

Get rid of extra unnecessary variables in "add_hostlist_table_data()".

Clean up indentation.

svn path=/trunk/; revision=11066

20 years agobugfix: don't double define rtp_payload_type_vals
Ulf Lamping [Tue, 1 Jun 2004 22:12:37 +0000 (22:12 -0000)]
bugfix: don't double define rtp_payload_type_vals

svn path=/trunk/; revision=11065

20 years agominor bugfix from previous check in
Ulf Lamping [Tue, 1 Jun 2004 22:00:22 +0000 (22:00 -0000)]
minor bugfix from previous check in

svn path=/trunk/; revision=11064