Revert "TODO: smb_request_done() aio..."

This reverts commit 267d79bb8a9d448bb4e5df9054d7698fdbba9e61.

Revert "TODO: reply_outbuf_ex"

This reverts commit 143f542cd2d2f2a6467f7632d68c5eae4663e27c.

TODO: reply_outbuf_ex

TODO: smb_request_done() aio...

DEBUG smbXsrc_session

STEP92? TODO/HACK; SMB2_OP_NEGPROT allowed_flags ...

Revert "STEPXX: tcp ack... doesn't work for unix..."

This reverts commit 6b24b57d6a2db5948dd906f642ea5bdceee1d994.

STEPXX: tcp ack... doesn't work for unix...

STEPXX: TODO: oplock break tcp ack...

STEPXX: STEP95? exit_common no panic

STEPXX: HACK:TMP: smb2_negprot: enable multi-channel by default

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Michael Adam <obnox@samba.org>

--- 00-STEPS-multi-channel: STEP20 - capabilites announcement ---

STEP20 - TODO: LATER - s3:smb2_tcon: Add branch cache flags

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Pair-Programmed-With: Michael Adam <obnox@samba.org>

STEP20 - TODO smb2_tcon: report share as scale out if 'scale out share = yes'

TODO: behavioural changes

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Pair-Programmed-With: Michael Adam <obnox@samba.org>

STEP20 - TODO smb2_tcon: report share as CA if 'continuously available share = yes'

TODO: Need to add change in behaviour

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Pair-Programmed-With: Michael Adam <obnox@samba.org>

STEP20 - TODO smb2_tcon: report share as cluster share if "cluster share = true"

TODO: No further behaviour change yet...

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Pair-Programmed-With: Michael Adam <obnox@samba.org>

STEP20 - param: add share parameter "scale out share"

Signed-off-by: Michael Adam <obnox@samba.org>

STEP20 - param: add share parameter "cluster share"

Signed-off-by: Michael Adam <obnox@samba.org>

STEP20 - param: add share parameter "continuously available share"

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>

STEP20 - TODO: s3:smb2_negprot: announce persistent handle support

if 'persistent handles' is set to yes

TODO: interactions with other options
(smb3, durable handles, kernel share modes, kernel oplocks, posix locking)

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Pair-Programmed-With: Michael Adam <obnox@samba.org>

STEP20 - param: add parameter "persistent handles", defaults to off.

Guenther

Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>

--- 00-STEPS-multi-channel: STEP12 - channel sequence/replay ---

STEP12? Revert "HACK debug replay/channel_sequence"

This reverts commit 46ce191a9bf9321251ea601a9b3ba7b48c5d5ccb.

STEP12? Revert "HACK disconnect after 2 writes"

This reverts commit eaa7023f865be73483a99ff203d1dbfb3e180ef9.

STEP12? HACK disconnect after 2 writes

STEP12? HACK debug replay/channel_sequence

--- 00-STEPS-multi-channel: STEP11 - lock sequence/replay detection ---

--- 00-STEPS-multi-channel: STEP05 - session lookup [DEBUG] ---

STEP05b debug session lookup

--- 00-STEPS-multi-channel: STEP00 : misc stuff ---

STEP02? use smbXsrv_client_update for >= smb2.1

selftest: mark samba3.base.delaywrite as flakey

We're getting failures like this, but also others

    [353/1594 in 23m14s] samba3.base.delaywrite(plugin_s4_dc)

    Running test_delayed_write_update1b
    Initial write time Wed May 21 03:27:02 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    write time Wed May 21 03:27:03 2014 CEST
    Server updated write time on close (correct)
    UNEXPECTED(failure): samba3.base.delaywrite.update of write time using
    SET_END_OF_FILE(plugin_s4_dc)
    REASON: _StringException: _StringException: After SET_END_OF_FILE truncate
    server updated write_time after 0.11 seconds(1 sec == 0.25)(wrong!)

    FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

Signed-off-by: Stefan Metzmacher <metze@samba.org>

selftest: mark samba3.raw.oplock.batch1* as flakey

I saw this a few times:

    [432/1598 in 30m19s] samba3.raw.oplock(plugin_s4_dc)
    BATCH10: Open with oplock after a non-oplock open should grant level2
    write should trigger a break to none
    WARNING!: (../source4/torture/raw/oplock.c:1968): wrong value for break_info.count got 0x0 - should be 0x1

    Acking to none [0x00] in oplock handler
    UNEXPECTED(failure): samba3.raw.oplock.batch10(plugin_s4_dc)
    REASON: _StringException: _StringException: (../source4/torture/raw/oplock.c:1969): wrong value for break_info.fnum got 0x0 - should be 0x6490

    FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

or:

    [433/1594 in 38m13s] samba3.raw.oplock(plugin_s4_dc)
    BATCH11: Test if setpathinfo set EOF breaks oplocks.
    Acking to level II [0x01] in oplock handler
    WARNING!: (../source4/torture/raw/oplock.c:2046): wrong value for break_info.count got 0x1 - should be 0x2

    Acking to none [0x00] in oplock handler
    UNEXPECTED(failure): samba3.raw.oplock.batch11(plugin_s4_dc)
    REASON: _StringException: _StringException: (../source4/torture/raw/oplock.c:2048): wrong value for break_info.level got 0x1 - should be 0x0

    FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Revert "HACK smb2 session setup STATUS_PENDING after 10 secs"

This reverts commit d3304e9ddce504d6398d3a37dca4e1ccba411e4f.

HACK smb2 session setup STATUS_PENDING after 10 secs

Revert "TMP: torture:smb2.session: only run bind1 test"

This reverts commit 75db98a26be2b11f35c29459f7ce9d4701e4b051.

Revert "HACK only test_session_reconnect1"

This reverts commit 3dbd1092c912f9436e0376250b9c33407672aff9.

HACK only test_session_reconnect1

TMP: torture:smb2.session: only run bind1 test

Revert "TMP DEBUG smb2 server"

This reverts commit 60ae322fb176cc32c888262f6eefa744e94445ae.

TMP DEBUG smb2 server

was commit 4153765d4c741f6b5fe8285313422f169156af75

Revert "TMP: DEBUG libcli/smb/smbXcli_base.c"

This reverts commit 938a99a2e327db1bf3d8fb110449d3b55c8b8f93.

TMP: DEBUG libcli/smb/smbXcli_base.c

Revert "TODO make it possible to run smb2.session.bind1 test with -U% against IPC$ (windows)"

This reverts commit f5eaec43d48bb939723500536012951f1730717b.

TODO make it possible to run smb2.session.bind1 test with -U% against IPC$ (windows)

STATUS_INVALID_PARAMETER is returned

--- 00-STEPS-multi-channel: STEP07b - session bind [DEBUG] ---

STEP07 - TMP/DEBUG security >= user

STEP07 - TMP/DEBUG debug binding

STEP07 - DEBUG - smb2:session bind

STEP07 - TMP/DEBUG BIND

--- 00-STEPS-multi-channel: STEP02c - SMB connection passing [tests] ---

Revert "msgtest fd-passing"

This reverts commit b3acb9b155309f5459cd74c884a03e8b0a9b97f5.

msgtest fd-passing

-- 00-STEPS-multi-channel: STEP02b - SMB connection passing [DEBUG] ---

STEP02: smbXsrv_client: debug filter_pass

--- 00-STEPS-multi-channel: STEP02x - SMB connection passing - extra ---

STEP02: TODO smbXsrv_client: add commented out stuff for future purposes..

STEP02: smbXsrv_client: add commented out code related to local db_rec

STEP02: smbXsrv_client: add commented out code in ..pass_filter"

(prep for verifying client guid..)

STEP02: smbXsrv_client: add commented out store op in smbXsrv_client_create

STEP02: smbXsrv_client: add commented out table var to smbXsrv_client_connection_pass_loop"

--- 00-STEPS-multi-channel: STEP02a - SMB connection passing HACK ---

--- 00-STEPS-multi-channel: STEP07a enable multi channel ---

--- 00-STEPS-multi-channel: START, STEPs 01,05,06,07,10,02: [UPSTREAM] ---

update TODO.multi-channel

selftest: samba3.smb2.replay.replay8 fails (incomplete test)

selftest: samba3.smb2.replay.replay3 succeeds now

selftest: samba3.smb2.replay.replay4 succeeds now (channel sequence)

Signed-off-by: Michael Adam <obnox@samba.org>

TODO selftest: enable multi channel in the nt4_dc env

Signed-off-by: Michael Adam <obnox@samba.org>

TMP/DEBUG: debugging in smb2 dispatcher

SQ: torture:smb2: replay8 needs multi-channel

LATER? HACK add smb2.replay.replay8 test

SQ: torture:smb2: replay7 needs multi-channel

LATER? s4:torture: Add smb2.replay.replay7 test to examine server behaviour when Multiple Channels are utilized.

Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
LATER? sq replay7 doesn't work (on a single CPU server?)

LATER? bla replay7...

s4-torture: add CHECK_CREATE_OUT_WITHOUT_HANDLE macro for checking two smb2_creates w/o file handle.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>

s3:smbXsrv.idl: add 8 byte channel_sequence number and request counters to IDL.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>

selftest:knownfail: smb2.lock.*replay succeed now

Signed-off-by: Michael Adam <obnox@samba.org>

s3-smbd: enable SMB2 lock sequence checking when SMB3 is enabled.

While windows enables it only for resilient and persistent handles a SMB server
SHOULD (according to MS-SMB2 section 3.3.5.14 ) activate processing of lock
sequence numbers for EITHER
- protocol dialect 2.1 and resilient handles OR
- protocol dialect 3.x.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>

s4-torture: in smb2.lock.replay try testing lock sequence checking against SMB3 samba servers.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>

s4-torture: make smb2.lock.replay test work against Windows 2012 R2.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>

s4-torture: make test_session_reauth5 work against Windows 2012R2.

The unlink of the file as anonymous is expected to fail.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>

s3:smb2_lock: implement lock_sequence replay detection

Pair-Programmed-With: Michael Adam <obnox@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

s3:smb2_lock: pass in_lock_sequence to smbd_smb2_lock_send()

Take the value from the client if the dialect is SMB2_10 or higher,
otherwise default to 0.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

s3:smbXsrv_open: initialize smbXsrv_open_global->lock_sequence_array with 0xFF

This does not match the current documentation, but is very likely the
right thing to do.

If we would match the documentation and initialize with 0x00,
we would return STATUS_SUCCESS without doing any locks.
If the client also follows the documentation and starts
with a lock_sequence of 0 for the first operation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

s3:smbXsrv.idl: add lock_sequence_array to smbXsrv_open_global0

This is needed for lock replay detection.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

TODO.multi-channel: update plans for oplock breaks

Update TODO.multi-channel

TODO.multi-channel

STEP02a - HACK (avoid swrap fdpass..) accept unix sockets... source3/lib/util_sock.c

This lets selftest work without socket-wrapper supporting fd-passing...

ctdb-daemon: Log a message when vfork() takes long time

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Sep 19 12:18:15 CEST 2016 on sn-devel-144

ctdb-daemon: Log a message when fork() takes long time

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

ctdb-daemon: Avoid extra condition in tevent trace callback

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

ctdb-recovery-helper: Add missing initialisation of ban_credits

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12275

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

lib: poll_funcs : poll_funcs_context_slot_find can select the wrong slot to replace.

Look for an exact match first, before a free slot.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12272

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Sep 19 07:12:00 CEST 2016 on sn-devel-144

s4/messaging: let the imessaging ctx destructor free msg_dgm_ref

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12272

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

lib/poll_funcs: free contexts in poll_funcs_state_destructor()

This ensures the destructors get called in the proper order.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12272

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

lib/poll_funcs: free timers in poll_funcs_state_destructor()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12272

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

s3/smbd: remove a misleading error message

It can happen that we get 0 cleanup events, so remove this error
message.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Sep 16 16:43:16 CEST 2016 on sn-devel-144

tevent_tutorial: Fix tevent_thread referencing

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Sep 16 05:16:02 CEST 2016 on sn-devel-144

tevent_tutorial: Fix typos

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>