Guy Harris [Wed, 31 Oct 2001 05:59:20 +0000 (05:59 -0000)]
Get rid of a bunch of stuff that was there to support non-tvbuffified
dissectors and that's no longer needed.
svn path=/trunk/; revision=4112
Guy Harris [Tue, 30 Oct 2001 22:22:26 +0000 (22:22 -0000)]
Fix to desegmentation crash, from Ronnie Sahlberg.
svn path=/trunk/; revision=4111
Guy Harris [Tue, 30 Oct 2001 21:35:09 +0000 (21:35 -0000)]
Put in a note telling people NOT to use "tvb_get_ntohl()" or
"tvb_get_letohl()" to fetch IPv4 addresses.
svn path=/trunk/; revision=4110
Guy Harris [Tue, 30 Oct 2001 21:31:15 +0000 (21:31 -0000)]
Fix a bunch of places where "tvb_get_letohl()" was being used to fetch
IP addresses - either use "tvb_memcpy()", or just use
"proto_tree_add_item()" and leave the fetching up to the core Ethereal
code.
In the DVMRP dissector, replace a bunch of other "proto_tree_add_XXX()"
calls with "proto_tree_add_item()", and use
"tvb_reported_length_remaining()" rather than "tvb_length_remaining()"
(if we didn't capture enough data because the snapshot length was too
low, we *want* an exception to be thrown, so that the frame is marked as
a "Short Frame").
svn path=/trunk/; revision=4109
Guy Harris [Tue, 30 Oct 2001 10:40:38 +0000 (10:40 -0000)]
IPv4 addresses should be entered in host byte order, not forced
little-endian byte order.
Use "proto_tree_add_item()" wherever possible.
Get rid of line commented out with a C++ comment, as not all C compilers
accept C++ comments.
Don't put the user name into the protocol tree if it's not there (we
really should do TCP segment reassembly for this, but this is at least a
good first cut).
When checking whether data exists in the packet, use
"tvb_offset_exists()", don't compare the offset in the tvbuf with
"pinfo->len" - "pinfo->len" is the length of the entire packet, not of
the tvbuff.
Fix some references to "pi" to refer to "*pinfo" instead.
svn path=/trunk/; revision=4108
Guy Harris [Tue, 30 Oct 2001 10:18:47 +0000 (10:18 -0000)]
IPv4 addresses should be entered in host byte order, not forced
little-endian byte order.
svn path=/trunk/; revision=4107
Guy Harris [Tue, 30 Oct 2001 10:16:51 +0000 (10:16 -0000)]
Small fix to previous patch, from Motonori Shindo.
svn path=/trunk/; revision=4106
Guy Harris [Tue, 30 Oct 2001 10:15:53 +0000 (10:15 -0000)]
Squelch a GCC complaint.
svn path=/trunk/; revision=4105
Guy Harris [Tue, 30 Oct 2001 10:11:00 +0000 (10:11 -0000)]
From Shinsuke Suzuki: fix IPv6 PIM checksum computation code to match
draft-ietf-pim-sm-v2-new-03.
svn path=/trunk/; revision=4104
Guy Harris [Tue, 30 Oct 2001 08:39:02 +0000 (08:39 -0000)]
In "u64toa()":
If the byte being investigated is 0, don't just do a "continue";
this might be one of the passes on which we have to propagate
carries, so skip the processing of that byte's bits, but fall
through to the carry processing.
In the carry processing loop, don't use "i" as the loop index,
as we're already using it as the outer loop index.
In "u64toh()", use lower-case letters rather than upper-case letters, as
we use "%x" rather than "%X" to print 8, 16, 24, and 32-bit integral
values in the "proto.c" code.
svn path=/trunk/; revision=4103
Guy Harris [Mon, 29 Oct 2001 21:56:50 +0000 (21:56 -0000)]
Stop using "tvb_get_ntohll()" and "%llX" in the BOOTP dissector, as the
former depends on having "guint64" and the latter depends on
"%ll[douxX]" being what's used to print 64-bit integers, and there are
platforms on which Etheeal runs that don't have "guint64" or that don't
use "%ll[douxX]" to print 64-bit integers.
Get rid of the routines to extract 64-bit integers into "gint64"s and
"guint64"s, as per Ronnie Sahlberg's suggestion, to discourage people
from writing code that won't work on all platforms; they should be using
FT_UINT64, or the routines in "int-64bit.c", instead.
svn path=/trunk/; revision=4102
Guy Harris [Mon, 29 Oct 2001 21:53:58 +0000 (21:53 -0000)]
Constify arguments and variables.
svn path=/trunk/; revision=4101
Jeff Foster [Mon, 29 Oct 2001 21:45:12 +0000 (21:45 -0000)]
Dissector converted to TVBuffers. The changes are originally from
Pia Sahlberg <piabar@hotmail.com.
svn path=/trunk/; revision=4100
Guy Harris [Mon, 29 Oct 2001 21:13:13 +0000 (21:13 -0000)]
From Ronnie Sahlberg: FT_UINT64 support, code to handle 64-bit integers
without requiring compiler support for them, and updates to the
Diameter, L2TP, NFS, and NLM dissectors to use it and to the ONC RPC
dissector to allow ONC RPC subdissectors to use it.
svn path=/trunk/; revision=4099
Guy Harris [Mon, 29 Oct 2001 20:49:28 +0000 (20:49 -0000)]
Updates from Mike Frisch to reflect NFSv4 protocol changes.
svn path=/trunk/; revision=4098
Guy Harris [Mon, 29 Oct 2001 19:50:53 +0000 (19:50 -0000)]
The previous checkin also added PPP compressed datagram support.
svn path=/trunk/; revision=4097
Guy Harris [Mon, 29 Oct 2001 19:48:45 +0000 (19:48 -0000)]
PPP CCP support, from Motonori Shindo.
svn path=/trunk/; revision=4096
Guy Harris [Sun, 28 Oct 2001 01:55:10 +0000 (01:55 -0000)]
Clean up another signed vs. unsigned comparison warning - if
"snprintf()" returns a negative number, that's an error, and we assume
"errno" was set and return NULL, otherwise we cast its return value to
"size_t" and compare it with the size of the buffer we were given, and,
if it was bigger, we know that "snprintf()" didn't generate all the
characters it could be cause they wouldn't have fit, so we set "errno"
to ENOSPC and return NULL.
svn path=/trunk/; revision=4095
Guy Harris [Sun, 28 Oct 2001 01:51:46 +0000 (01:51 -0000)]
Include <unistd.h>, if we have it, to declare "unlink()".
svn path=/trunk/; revision=4094
Guy Harris [Sun, 28 Oct 2001 01:27:59 +0000 (01:27 -0000)]
Check, in the configure script in the epan directory, whether we have
"strptime()" and, if not, define NEED_STRPTIME_H.
svn path=/trunk/; revision=4093
Guy Harris [Sun, 28 Oct 2001 00:57:15 +0000 (00:57 -0000)]
From Mike Frisch: Win32 systems don't have "strptime()", so we need to
use a replacement "strptime()" on those systems, and thus need to
include "strptime.h" to declare "strptime()".
svn path=/trunk/; revision=4092
Guy Harris [Sun, 28 Oct 2001 00:52:28 +0000 (00:52 -0000)]
"ftypes" and "dfilter" should depend on "config.h", so that if it
doesn't exist, or is out of date with respect to "config.h.win32", it's
remade - stuff in "ftypes" and "dfilter" includes "config.h", and it
should get the "config.h" in "epan".
svn path=/trunk/; revision=4091
Guy Harris [Sat, 27 Oct 2001 00:47:26 +0000 (00:47 -0000)]
Section D.4.3 "Generating Cryptographic authentication" of RFC 2328 says
that, when using cryptographic authentication, "The checksum field in
the standard OSPF header is not calculated, but is instead set to 0";
treat a packet checksum value of 0 as meaning "no checksum present".
svn path=/trunk/; revision=4090
Guy Harris [Fri, 26 Oct 2001 19:14:51 +0000 (19:14 -0000)]
Handle the 1.3 and 1.4 Content-Type values in WSP, from Tom Uijldert.
svn path=/trunk/; revision=4089
Gilbert Ramirez [Fri, 26 Oct 2001 18:28:17 +0000 (18:28 -0000)]
Fix the rest of the signed/unsigned comparison warnings.
svn path=/trunk/; revision=4088
Gilbert Ramirez [Fri, 26 Oct 2001 17:29:12 +0000 (17:29 -0000)]
Fix some signed/unsigned comparison warnings. In the case of tvbuff.h,
there were 2 functions which accepted 'maxlength' == -1, but the function
prototypes had maxlength as a guint --- fixed.
svn path=/trunk/; revision=4087
Guy Harris [Fri, 26 Oct 2001 10:30:16 +0000 (10:30 -0000)]
Make the protocol ID argument to "dissect_transform()" an "int", and
pass -1 in the cases where it's not called from "dissect_proposal()",
i.e. where there *is* no protocol ID to pass it, and have it dissect
the transform ID only as a number if the protocol ID isn't one of the
ones we know about.
Give the payload dissectors other than "dissect_transform()" an extra
"int" argument, so that their signature is the same as that of
"dissect_transform()", put "dissect_transform()" back in the
"strfuncs[]" table, and get rid of the special-casing of
"dissect_transform()" in "dissect_payloads()".
svn path=/trunk/; revision=4086
Guy Harris [Fri, 26 Oct 2001 10:14:43 +0000 (10:14 -0000)]
In "get_pointer_value()", don't include the terminating '\0' when
formatting the string as text.
In "add_pointer_param()", make the offset in the text item for the
string the offset in the string area, not the offset of the pointer
itself.
Fix some items in item lists to have "lm_null" rather than a null
pointer, so that if we don't find an entry for the detail level, we
don't blow up dereferencing a null pointer, we just dissect all the
items based on the type in the descriptor string.
If we don't have a data descriptor for response data, just put in an
entry for the data; that may happen if we only dissected part of the
request to which the stuff we're dissecting is a reply, e.g. because the
snapshot length didn't let us capture all of the request.
svn path=/trunk/; revision=4085
Gilbert Ramirez [Fri, 26 Oct 2001 02:55:20 +0000 (02:55 -0000)]
Guard against erroneously calculating a negative length during the
processing of sub-options.
svn path=/trunk/; revision=4084
Gilbert Ramirez [Fri, 26 Oct 2001 02:09:01 +0000 (02:09 -0000)]
Fix improper uses of proto_tree_add_item(). When possible, switch to
using proto_tree_add_item().
svn path=/trunk/; revision=4083
Guy Harris [Thu, 25 Oct 2001 23:51:26 +0000 (23:51 -0000)]
We no longer try to dissect payloads of type "None", so get rid of
"dissect_none()".
svn path=/trunk/; revision=4082
Guy Harris [Thu, 25 Oct 2001 23:40:28 +0000 (23:40 -0000)]
Loop over all the sub-payloads of a Security Association payload; make a
common routine that loops over payloads.
Have that routine check for a payload of type "None", which means that
there's extra data after a payload that claimed to be the last one (by
virtue of having a next payload type of "None").
When dissecting a Security Association payload, make sure we have enough
data for the Domain of Interpretation field before putting it into the
tree, dissect the situation as a 4-byte quantity followed by a set of
sub-payloads only of the DOI is "IPSEC" (otherwise dissect it as raw
data), and make sure we have enough data for the 4-byte situation field
before putting it into the tree.
When dissecting a Proposal payload, show the raw bytes of the SPI.
svn path=/trunk/; revision=4081
Gilbert Ramirez [Thu, 25 Oct 2001 21:25:51 +0000 (21:25 -0000)]
Don't try to dissect a gnutella sub-header if the length of the sub-header
is 0.
svn path=/trunk/; revision=4080
Gilbert Ramirez [Thu, 25 Oct 2001 21:00:34 +0000 (21:00 -0000)]
Guard against 'size' being too small; the value comes from the packet,
so it can be corrupt.
svn path=/trunk/; revision=4079
Gilbert Ramirez [Thu, 25 Oct 2001 20:36:26 +0000 (20:36 -0000)]
Interface type 0x07 is Ethernet.
svn path=/trunk/; revision=4078
Gilbert Ramirez [Thu, 25 Oct 2001 20:29:24 +0000 (20:29 -0000)]
Get rid of signed/unsigned comparison warnings in wiretap.
svn path=/trunk/; revision=4077
Guy Harris [Thu, 25 Oct 2001 19:57:06 +0000 (19:57 -0000)]
Update from Frank Singleton:
- Handle "short" as a union discriminant type
- Handle case where union discriminant may be a typedef
- Change integer template to long template
- Initial code for \n and \t as union case labels.
svn path=/trunk/; revision=4076
Guy Harris [Thu, 25 Oct 2001 08:06:15 +0000 (08:06 -0000)]
Use "g_warning" to print warning messages from "pcap_open_live()", as
that should cause it to show up in a console window if run from Ethereal
on Windows.
svn path=/trunk/; revision=4075
Guy Harris [Thu, 25 Oct 2001 06:41:48 +0000 (06:41 -0000)]
Handle "pcap_open_live()" succeeding but returning a warning; print the
warning before the capture starts.
svn path=/trunk/; revision=4074
Guy Harris [Wed, 24 Oct 2001 09:22:23 +0000 (09:22 -0000)]
Fix compile errors and code errors in the Win32 code.
svn path=/trunk/; revision=4073
Guy Harris [Wed, 24 Oct 2001 07:18:39 +0000 (07:18 -0000)]
Have a routine that takes a file name for a personal configuration file
and generates the path name; have it, if the file is to be opened for
reading on Win32, check whether it exists and, if not, check for it in
the old home directory-based configuration directory and, if so, return
that path instead, so that files saved with earlier versions of Ethereal
will be seen.
svn path=/trunk/; revision=4072
Guy Harris [Wed, 24 Oct 2001 06:13:07 +0000 (06:13 -0000)]
On Windows, put Ethereal configuration files under the "Application
Data\Ethereal" directory under the user's profile, as that appears to be
the Windows 2000 standard.
svn path=/trunk/; revision=4071
Guy Harris [Tue, 23 Oct 2001 20:14:20 +0000 (20:14 -0000)]
Show parameter types in hex.
Make enumerated types be fields with a value_string table, so that you
can filter on them by name.
svn path=/trunk/; revision=4070
Guy Harris [Tue, 23 Oct 2001 19:02:59 +0000 (19:02 -0000)]
In some versions of GRE, you can have ACK-only packets; if a packet
doesn't have the S bit set, check whether it has any payload before
attempting to hand off the payload to the next dissector.
svn path=/trunk/; revision=4069
Guy Harris [Tue, 23 Oct 2001 08:15:11 +0000 (08:15 -0000)]
Include <direct.h> on Windows systems, to declare "mkdir()".
On Windows, put the ".ethereal" directory under the user profile
directory rather than the home directory.
Update the documentation to reflect that, and to fix other out-of-date
information, as well as some typos.
svn path=/trunk/; revision=4068
Guy Harris [Tue, 23 Oct 2001 05:40:36 +0000 (05:40 -0000)]
When putting protocols into the list of protocols, do a case-insensitive
sort.
Give iSCSI the short name "iSCSI" rather than "ISCSI".
svn path=/trunk/; revision=4067
Guy Harris [Tue, 23 Oct 2001 05:23:58 +0000 (05:23 -0000)]
Fix some field names to begin with "iua", not "hf".
svn path=/trunk/; revision=4066
Guy Harris [Tue, 23 Oct 2001 05:01:02 +0000 (05:01 -0000)]
Add a new routine to create the ".ethereal" directory for a user.
Use that routine rather than duplicating that code in the routines to
write out the preference file and filter files.
Use it in the code for the color filter dialog, so that the directory in
question is created if necessary.
As that routine returns an error indication, have the code that calls
that routine put up a message box if the attempt fails.
svn path=/trunk/; revision=4065
Guy Harris [Tue, 23 Oct 2001 04:11:58 +0000 (04:11 -0000)]
Additional items for RADIUS tunnels, from Pavel Novotny.
svn path=/trunk/; revision=4064
Guy Harris [Tue, 23 Oct 2001 03:40:39 +0000 (03:40 -0000)]
Include <stdio.h> to declare "sprintf()".
svn path=/trunk/; revision=4063
Guy Harris [Mon, 22 Oct 2001 23:16:01 +0000 (23:16 -0000)]
The only reason we care about the user's home directory is that their
".ethereal" directory is under it; get rid of "get_home_dir()", and put
its code inside "get_persconffile_dir()". (The personal configuration
file directory may move, on Windows, to the user's profile directory.)
svn path=/trunk/; revision=4062
Guy Harris [Mon, 22 Oct 2001 22:59:26 +0000 (22:59 -0000)]
Add a routine to get the directory in which personal configuration files
reside. Use it, rather than concatenating the user's home directory and
".ethereal" in a number of files.
Fix up some additional places to use G_DIR_SEPARATOR_S as the pathname
separator.
svn path=/trunk/; revision=4061
Guy Harris [Mon, 22 Oct 2001 21:05:15 +0000 (21:05 -0000)]
Fix Martti Kuparinen's e-mail address, as per his request.
svn path=/trunk/; revision=4060
Guy Harris [Mon, 22 Oct 2001 20:45:58 +0000 (20:45 -0000)]
From Yaniv Kaul - handle UDP-encapsulated IPSec NAT Keepalive packets.
svn path=/trunk/; revision=4059
Guy Harris [Mon, 22 Oct 2001 20:37:51 +0000 (20:37 -0000)]
From Georg von Zezschwitz: fix an uninitialized variable, dissect the
S-max-age value in Cache-Control headers, and handle the 1.1, 1.3, and
1.4 encoding of Cache-Control headers.
svn path=/trunk/; revision=4058
Guy Harris [Sun, 21 Oct 2001 21:56:05 +0000 (21:56 -0000)]
Use G_DIR_SEPARATOR_S rather than "/" as a pathname separator in format
strings used to generate pathnames.
svn path=/trunk/; revision=4057
Guy Harris [Sun, 21 Oct 2001 21:48:00 +0000 (21:48 -0000)]
Use G_DIR_SEPARATOR_S rather than "/" as a pathname separator in format
strings used to generate pathnames.
Move the definition of PF_DIR from <epan/epan.h> to <epan/filesystem.h>,
so that files requiring only the definition of PF_DIR don't have to
include <epan/epan.h>, and get rid of no-longer-necessary includes of
<epan/epan.h>.
Add a routine to get the directory for "system files" such as
"/etc/ethers" - it's "/etc" on UNIX, and the datafile directory on
Windows (as there's no "/etc" on Windows). Use that to construct the
pathname of the ethers and ipxnet files.
svn path=/trunk/; revision=4056
Guy Harris [Sun, 21 Oct 2001 19:54:49 +0000 (19:54 -0000)]
On Windows, get the "ethers" and "ipxnets" file from the directory in
which the Ethereal binary is found; there's no notion of "/etc" or of
"/etc/ethers" or "/etc/ipxnets" files on Windows.
Update the documentation to reflect that, and fix a typo in the Ethereal
and Tethereal man pages.
svn path=/trunk/; revision=4055
Guy Harris [Sun, 21 Oct 2001 19:04:20 +0000 (19:04 -0000)]
Give the "iscsi_desegment" and "iscsi_port" the right types, matching
the declarations of the functions to which a pointer to them is passed;
this also fixes it so it compiles with MSVC++, as there's no "uint" type
declared by MSVC++ by default.
svn path=/trunk/; revision=4054
Guy Harris [Sun, 21 Oct 2001 17:38:43 +0000 (17:38 -0000)]
Enhanced Ethereal icon from Gordon McKinney:
I have enhanced the standard Ethereal Icon and added the following
renderings:
* 32x32 - 256 Colour with transparency
* 16x16 - 256 Colour with transparency
* 16x16 - 16 Colour
Add to the list of authors in the man page the names of people who've
contributed to Wiretap but not to the rest of Ethereal - there's
currently no Wiretap man page, so we might as well give them credit in
the Ethereal man page.
svn path=/trunk/; revision=4053
Guy Harris [Sun, 21 Oct 2001 17:30:50 +0000 (17:30 -0000)]
Keep the list of modules with preferences sorted by the module name, in
dictionary order (case-insensitive), so that they show up in order in
the "Preferences" dialog box.
svn path=/trunk/; revision=4052
Guy Harris [Sun, 21 Oct 2001 17:20:10 +0000 (17:20 -0000)]
Updates from Mark Burton:
The enclosed code contains the following improvements:
1 - Compatible with 08 version of the protocol
2 - Handles both header and data digests
3 - Supports desegmentation
4 - Dissects multiple PDUs per packet
5 - Stronger heuristics to avoid dissecting non-iSCSI packets
6 - General rationalisation and de-crufting!
The old code that attempted to automatically detect the presence
of a header digest has been removed. You now have to specify in
the iSCSI preferences whether digests are enabled and if they
are, whether they are CRC32 or not. If not CRC32, you also need
to specify the size of the digests (in bytes).
Another new option specifies the iSCSI port number. This is
used in the heuristics to filter out packets with silly port
numbers, set to 0 to disable the port filter.
One problem that I haven't been able to track down is that if
desegmentation is enabled and you turn digests on or off
ethereal throws a SEGV.
svn path=/trunk/; revision=4051
Gerald Combs [Sun, 21 Oct 2001 16:15:21 +0000 (16:15 -0000)]
Add little arrows to the column titles to indicate which column we're
using to sort as well as the sort direction.
svn path=/trunk/; revision=4050
Guy Harris [Sat, 20 Oct 2001 19:29:21 +0000 (19:29 -0000)]
Properly handle the andX command in a LockingAndX message.
Fix up some closing braces.
svn path=/trunk/; revision=4049
Guy Harris [Sat, 20 Oct 2001 18:42:01 +0000 (18:42 -0000)]
If we decide that a packet to or from port 2000 isn't really a Skinny
Client Control Protocol packet, at least dissect its payload as data.
svn path=/trunk/; revision=4048
Guy Harris [Sat, 20 Oct 2001 18:30:50 +0000 (18:30 -0000)]
FT_UINTn values must always have a base, even if they're bitfields - the
width of the item containing the bitfield is "n", so you don't have to
specify it explicitly, as you have to do with FT_BOOLEAN bitfields.
svn path=/trunk/; revision=4047
Guy Harris [Sat, 20 Oct 2001 18:10:39 +0000 (18:10 -0000)]
Use "val_to_str()", rather than "match_strval()", in "socket_text()".
Make the source and destination socket fields enumerated types, so we
don't have to use "proto_tree_add_uint_format()" on them, and so that
you can match on them by service name.
Use lower-case letters when formatting the hex value of sockets; that's
what's done with fields not added with "proto_tree_add_XXX_format".
svn path=/trunk/; revision=4046
Guy Harris [Fri, 19 Oct 2001 21:40:48 +0000 (21:40 -0000)]
From Tom Uijldert: fix to the date decoding, fix a field's name, and
protocol-name cosmetic changes.
svn path=/trunk/; revision=4045
Guy Harris [Fri, 19 Oct 2001 21:34:28 +0000 (21:34 -0000)]
From Tom Uijldert: fix the port number for Push-traffic dissecting for
WSP/WTLS.
svn path=/trunk/; revision=4044
Guy Harris [Fri, 19 Oct 2001 20:53:14 +0000 (20:53 -0000)]
From Mark Burton: update to the -08 draft.
svn path=/trunk/; revision=4043
Guy Harris [Fri, 19 Oct 2001 20:18:48 +0000 (20:18 -0000)]
DBS Etherwatch wiretap module, from Marc Milgram.
svn path=/trunk/; revision=4042
Guy Harris [Fri, 19 Oct 2001 09:12:53 +0000 (09:12 -0000)]
L2TP Dissconnect Cause Information AVP support, from Motonori Shindo.
svn path=/trunk/; revision=4041
Guy Harris [Thu, 18 Oct 2001 21:49:58 +0000 (21:49 -0000)]
From Frank Singleton: catch attempts to use recursive unions or
structures.
svn path=/trunk/; revision=4040
Guy Harris [Thu, 18 Oct 2001 20:29:56 +0000 (20:29 -0000)]
VMS TCPIPtrace wiretap module, from Marc Milgram.
Update the lists of known capture file formats in the Tethereal,
editcap, and mergecap man pages to match the current list (as found in
the Ethereal man page).
svn path=/trunk/; revision=4039
Gerald Combs [Thu, 18 Oct 2001 15:44:36 +0000 (15:44 -0000)]
Add link to local mirror.
svn path=/trunk/; revision=4038
Guy Harris [Thu, 18 Oct 2001 08:23:24 +0000 (08:23 -0000)]
From Georg von Zezschwitz:
Fix a bug with WSP Connect requests with headers > 256 bytes
Implement attributes of WSP Suspend/Resume
svn path=/trunk/; revision=4037
Jeff Foster [Wed, 17 Oct 2001 21:24:28 +0000 (21:24 -0000)]
fixed bug in packet-smb-pipe.c dissect_transact_data routine. If the
aux_count_p value was NULL the program would SIGSEGV when *aux_count_p
was initially set to 0. Added NULL pointer test.
svn path=/trunk/; revision=4036
Gilbert Ramirez [Wed, 17 Oct 2001 19:27:43 +0000 (19:27 -0000)]
Enable building of the coseventcomm plugin on Win32.
Some of these changs are from Frank Singleton, some are mine.
svn path=/trunk/; revision=4035
Guy Harris [Tue, 16 Oct 2001 07:35:11 +0000 (07:35 -0000)]
The Quake3 dissector wasn't in the previous release, only users running
CVS versions would've had "quake3.udp.port" in the preferences file;
therefore, we can remove the code to map them to "quake3.udp.arena_port"
and "quake3.udp.master_port".
svn path=/trunk/; revision=4034
Guy Harris [Tue, 16 Oct 2001 07:13:01 +0000 (07:13 -0000)]
Update from Scott Renfro: a simple patch that adds support for FIPS
Cipher Suite identifiers.
svn path=/trunk/; revision=4033
Guy Harris [Tue, 16 Oct 2001 04:58:24 +0000 (04:58 -0000)]
Don't create a Wiretap dump file unless we're at least sure we support
the specified encapsulation with the specified capture file type, and
that we can allocate a "wtap_dumper *".
If we could do all that, and could create the dump file, but the
file-type-specific create routine fails (e.g., because there's not
enough disk space to write out the header), remove the dump file.
svn path=/trunk/; revision=4032
Gerald Combs [Tue, 16 Oct 2001 01:57:12 +0000 (01:57 -0000)]
Fix conversation_new description. Add descriptions for
conversation_add_proto_data, conversation_get_proto_data, and
conversation_delete_proto_data.
svn path=/trunk/; revision=4031
Guy Harris [Mon, 15 Oct 2001 03:54:05 +0000 (03:54 -0000)]
Fixes from Steffen Weinreich:
fix the processing of the month and year fields in the SCTC
Timestamp (the month is 1-origin, so subtract 1 from it before
putting it in "tm_mon", which is 0-origin; the year is a 2-digit
field that is, at least, Y2K-safe (but Y2.1K-unsafe), so if it's
less than 90, assume it's in the 21st century);
UCP OT 50-57 messages have a fixed number of fields and a
special handling of the MT is not necessary, so get rid of that.
Also, fix a typo in a comment.
svn path=/trunk/; revision=4030
Guy Harris [Mon, 15 Oct 2001 03:27:38 +0000 (03:27 -0000)]
Fixes to take the Vendor-Specific attribute into consideration when
dissecting L2TP, from Motonori Shindo.
svn path=/trunk/; revision=4029
Gerald Combs [Sat, 13 Oct 2001 19:31:47 +0000 (19:31 -0000)]
Make NEWS current to today (October 13).
svn path=/trunk/; revision=4027
Richard Sharpe [Sat, 13 Oct 2001 12:05:32 +0000 (12:05 -0000)]
A small patch from Moronori Shindo to fix compiles under MSVC etc ...
svn path=/trunk/; revision=4026
Guy Harris [Sat, 13 Oct 2001 07:56:27 +0000 (07:56 -0000)]
Put the scrollbar for the scrolled window containing the CList in the
preferences dialog where the user specified, and register that scrolled
window so that if the preference is changed the scrollbar moves.
svn path=/trunk/; revision=4025
Guy Harris [Sat, 13 Oct 2001 07:47:30 +0000 (07:47 -0000)]
Set the data for E_{PRINT,COLUMN,STREAM,GUI}_PAGE_KEY to the notebook
page for the preferences item rather than to the frame for the
preferences item, as that's what the code in "gtk/gui_prefs.c" expects
(otherwise you get errors).
svn path=/trunk/; revision=4024
Guy Harris [Sat, 13 Oct 2001 07:43:25 +0000 (07:43 -0000)]
The Quake III dissector called both the arena server port preference and
the master server port preference "quake3.udp.port"; rename them to
"quake3.udp.arena_port" and "quake3.udp.master_port".
svn path=/trunk/; revision=4023
Gerald Combs [Fri, 12 Oct 2001 21:20:40 +0000 (21:20 -0000)]
Make current up to August 31.
svn path=/trunk/; revision=4022
Gerald Combs [Fri, 12 Oct 2001 17:17:05 +0000 (17:17 -0000)]
Get NEWS current up to July 31, update version to 0.8.20.
svn path=/trunk/; revision=4021
Guy Harris [Fri, 12 Oct 2001 17:14:41 +0000 (17:14 -0000)]
From Frank Singleton:
Added some functionality to idl2eth to allow C code generation
and display of CORBA IDL Enum's as symbolic values, along side
the numerical value currently being displayed.
svn path=/trunk/; revision=4020
Guy Harris [Fri, 12 Oct 2001 01:41:03 +0000 (01:41 -0000)]
Sigh. A MacOS X 10.1 appeared to have put out a malformed NetBIOS
session request with a length greater than 128 bytes; crank the length
limitation up to 256. (Perhaps I've misread the DNS spec or the
NetBIOS-over-TCP spec, but the request sure *looked* as if it had a
bogus second-level-encoding in the calling machine name.)
svn path=/trunk/; revision=4019
Guy Harris [Thu, 11 Oct 2001 16:04:36 +0000 (16:04 -0000)]
For the SCCP message ID field, use the formerly commented-out version
with the value_string table, as per mail from Joerg.
svn path=/trunk/; revision=4018
Guy Harris [Thu, 11 Oct 2001 16:01:53 +0000 (16:01 -0000)]
Get rid of C++ comment.
svn path=/trunk/; revision=4017
Guy Harris [Thu, 11 Oct 2001 16:01:10 +0000 (16:01 -0000)]
Initial Skinny Client Control Protocol support, from Joerg Mayer.
svn path=/trunk/; revision=4016
Gerald Combs [Thu, 11 Oct 2001 02:17:29 +0000 (02:17 -0000)]
Reduce the CinemaScope-like proportions of the preferences dialog by
getting rid of the notebook tabs and using a CTree to select pages.
svn path=/trunk/; revision=4015
Guy Harris [Thu, 11 Oct 2001 01:21:50 +0000 (01:21 -0000)]
Instead of saying the "manuf" file is in "/usr/local/etc/manuf", say
it's in the "etc" subdirectory of the installation directory on UNIX and
in the installation directory on Windows, and give the typical pathnames
of both of those directories.
svn path=/trunk/; revision=4014
Guy Harris [Thu, 11 Oct 2001 01:04:19 +0000 (01:04 -0000)]
Install the "manuf" file.
svn path=/trunk/; revision=4013
Nathan Neulinger [Mon, 8 Oct 2001 18:20:01 +0000 (18:20 -0000)]
add a couple of socket numbers that seem to be consistently allocated for these services
svn path=/trunk/; revision=4012