Andreas Schneider [Mon, 21 Nov 2011 17:19:43 +0000 (18:19 +0100)]
s3-libsmb: Don't duplicate kerberos service tickets.
This fixes bug #8628.
Each time we do a client connection. Each time we call to function to
get the service ticket from the cache we duplicate it. So with each
connection we end up with one or three duplicated tickets.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Dec 15 19:30:42 CET 2011 on sn-devel-104
Volker Lendecke [Fri, 9 Dec 2011 10:22:50 +0000 (11:22 +0100)]
s3-dbwrap: All relevant backends provide parse_record(). Remove the fallback.
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Dec 15 17:41:53 CET 2011 on sn-devel-104
Volker Lendecke [Thu, 8 Dec 2011 15:46:09 +0000 (16:46 +0100)]
s3-dbwrap: Remove the "fetch" db_context callback
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Dec 2011 15:43:40 +0000 (16:43 +0100)]
s3-dbwrap: Rewrite dbwrap_fetch in terms of dbwrap_parse_record
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Dec 2011 15:37:40 +0000 (16:37 +0100)]
s3-dbwrap: Rewrite dbwrap_fallback_parse_record based on dbwrap_fetch_locked
This is in preparation to remove the db_context->fetch function pointer
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Dec 2011 15:05:08 +0000 (16:05 +0100)]
s3-dbwrap: For nostalgic reasons, make dbwrap_file.c compile at least
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Dec 2011 15:04:19 +0000 (16:04 +0100)]
s3-dbwrap: Fix some blank line endings
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Dec 2011 14:56:35 +0000 (15:56 +0100)]
s3-dbwrap: Implement db_ctdb_parse_record in terms of db_ctdb_fetch
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Dec 2011 14:50:33 +0000 (15:50 +0100)]
s3-dbwrap: Make dbwrap_parse_record return NTSTATUS
Also, the parser now returns void. The parser is called if and only if
dbwrap_parse_record returns NT_STATUS_OK.
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 14 Dec 2011 12:26:36 +0000 (13:26 +0100)]
s3:smbd/globals: remove unused msg_ctx_to_sconn()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Dec 15 14:24:59 CET 2011 on sn-devel-104
Stefan Metzmacher [Wed, 14 Dec 2011 12:25:20 +0000 (13:25 +0100)]
s3:smbd: pass smbd_server_connection and a snumused function pointer to reload_services()
metze
Stefan Metzmacher [Wed, 14 Dec 2011 10:12:49 +0000 (11:12 +0100)]
s3:printing/spoolssd: pass event and messaging context to check_updater_child()
metze
Stefan Metzmacher [Thu, 15 Dec 2011 10:03:29 +0000 (11:03 +0100)]
s3:rpc_server/spoolss: remove reload_services check from delete_printer_hook()
As the spoolss code can run embedded or external relative to the
smbd file server process, it's very tricky to verify if a share
is still in use.
Checking the result of the "deleteprinter command" command should
be enough to check for success. We should not return WERR_ACCESS_DENIED
if the share is still in use, by the current client, as the primary
printer definition is already deleted.
metze
Stefan Metzmacher [Wed, 14 Dec 2011 11:39:36 +0000 (12:39 +0100)]
s3:smbd: split smb_conf_updated into parent and child versions
metze
Stefan Metzmacher [Wed, 14 Dec 2011 09:23:30 +0000 (10:23 +0100)]
s3:smbd: split ID_CACHE_* message handling into parent and child parts
metze
Martin Schwenke [Thu, 15 Dec 2011 04:31:47 +0000 (15:31 +1100)]
lib/ccan: Fix some typos in libccan.m4
Signed-off-by: Martin Schwenke <martin@meltin.net>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Thu Dec 15 07:40:33 CET 2011 on sn-devel-104
Rusty Russell [Thu, 15 Dec 2011 05:04:55 +0000 (15:34 +1030)]
lib/ccan: fix m4 tests for builtin_expect and compound literals.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Günther Deschner [Wed, 14 Dec 2011 18:36:52 +0000 (19:36 +0100)]
s3-includes: remove PRIMARY_* SID_INDEX defines defined elsewhere already.
They really do not belong to smb.h.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Dec 14 21:15:39 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 14 Dec 2011 15:54:07 +0000 (16:54 +0100)]
s3: Fix raw.mux after UNUSED_SHARE_MODE_ENTRY was removed
See the large comment in notify_deferred_opens for an explanation
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Dec 14 19:08:30 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 14 Dec 2011 09:43:36 +0000 (10:43 +0100)]
s3: Slightly simplify the logic in defer_open
Doing 3 &&ed conditions in a single if-statement is easier to understand to me
than continuing out separately.
Volker Lendecke [Wed, 14 Dec 2011 09:35:56 +0000 (10:35 +0100)]
s3: Remove UNUSED_SHARE_MODE_ENTRY
Volker Lendecke [Tue, 13 Dec 2011 16:11:02 +0000 (17:11 +0100)]
s3: Remove a call to procid_self()
Volker Lendecke [Tue, 13 Dec 2011 16:10:33 +0000 (17:10 +0100)]
s3: Remove nmbd_messaging_context()
Volker Lendecke [Tue, 13 Dec 2011 16:07:39 +0000 (17:07 +0100)]
s3: Fix some pointless statics
Volker Lendecke [Tue, 13 Dec 2011 16:03:21 +0000 (17:03 +0100)]
s3: Remove a call to procid_self()
Pass messaging_context through the SIGHUP handler
Volker Lendecke [Tue, 13 Dec 2011 16:03:21 +0000 (17:03 +0100)]
s3: Remove a call to procid_self()
Pass messaging_context through the SIGTERM handler
Volker Lendecke [Tue, 13 Dec 2011 15:59:55 +0000 (16:59 +0100)]
s3: Pass messaging_context to nmbd/process()
Volker Lendecke [Tue, 13 Dec 2011 15:51:53 +0000 (16:51 +0100)]
s3: Make nmbd_messaging_context static
Volker Lendecke [Tue, 13 Dec 2011 15:48:11 +0000 (16:48 +0100)]
s3: Centralize nmbd_messaging_context in nmbd.c
Volker Lendecke [Tue, 13 Dec 2011 15:21:37 +0000 (16:21 +0100)]
s3: Fix some nonempty blank lines
Günther Deschner [Wed, 14 Dec 2011 10:07:11 +0000 (11:07 +0100)]
s4-smbtorture: make sure we can successfully run the schannel test against windows.
lsa lookupsids3/lookupnames4 is only available over schannel sealed
ncacn_ip_tcp.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Dec 14 17:28:29 CET 2011 on sn-devel-104
Andreas Schneider [Tue, 13 Dec 2011 13:49:27 +0000 (14:49 +0100)]
s4-torture: LookupSids3 is only available over NCACN_IP_TCP.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Dec 14 15:39:58 CET 2011 on sn-devel-104
Andreas Schneider [Tue, 13 Dec 2011 14:20:53 +0000 (15:20 +0100)]
s4-torture: Fix schannel test against win2k8.
Andreas Schneider [Mon, 12 Dec 2011 18:28:49 +0000 (19:28 +0100)]
s4-librpc: Fix NETLOGON credential chain with Windows 2008.
Windows Server 2008 returns NT_STATUS_DOWNGRADE_DETECTED if you call
netrServerAuthenticate2 during a domain join without setting the strong
keys flag (128bit crypto).
Only for NT4 we need to do a downgrade to the returned negotiate flags.
See also
0970369ca0cb9ae465cff40e5c75739824daf1d0.
Stefan Metzmacher [Wed, 14 Dec 2011 08:50:24 +0000 (09:50 +0100)]
s3:smb2_lock: use talloc_get_type_abort() as private_data can't be NULL
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Dec 14 13:34:25 CET 2011 on sn-devel-104
Stefan Metzmacher [Wed, 14 Dec 2011 08:54:42 +0000 (09:54 +0100)]
s3:smbd/oplock: make process_oplock_async_level2_break_message() static
metze
Stefan Metzmacher [Wed, 14 Dec 2011 08:50:24 +0000 (09:50 +0100)]
s3:smbd/oplock: use talloc_get_type_abort() as private_data can't be NULL
metze
Stefan Metzmacher [Wed, 14 Dec 2011 08:50:24 +0000 (09:50 +0100)]
s3:smbd/open: use talloc_get_type_abort() as private_data can't be NULL
metze
Stefan Metzmacher [Wed, 14 Dec 2011 08:50:24 +0000 (09:50 +0100)]
s3:smbd/conn_msg: use talloc_get_type_abort() as private_data can't be NULL
metze
Stefan Metzmacher [Wed, 14 Dec 2011 08:50:24 +0000 (09:50 +0100)]
s3:smbd/close: use talloc_get_type_abort() as private_data can't be NULL
metze
Stefan Metzmacher [Wed, 14 Dec 2011 08:50:24 +0000 (09:50 +0100)]
s3:smbd/blocking: use talloc_get_type_abort() as private_data can't be NULL
metze
Stefan Metzmacher [Wed, 14 Dec 2011 08:11:44 +0000 (09:11 +0100)]
s3:web/swat: use short term event and message contexts
swat doesn't have a central event loop.
metze
Stefan Metzmacher [Tue, 13 Dec 2011 08:24:31 +0000 (09:24 +0100)]
s3:smbd: remove brl_register_msgs()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 14:26:34 +0000 (15:26 +0100)]
s3:smbd/server: avoid msg_ctx_to_sconn() in smbd_accept_connection()
This is the place where we should create smbd_server_connection,
when we're ready to remove the global variable.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Dec 14 11:23:42 CET 2011 on sn-devel-104
Stefan Metzmacher [Tue, 13 Dec 2011 14:24:24 +0000 (15:24 +0100)]
s3:smbd: remove unused smbd_messaging_context()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 14:23:08 +0000 (15:23 +0100)]
s3:smbd/server: maintain the list of child processes under smbd_parent_context
metze
Stefan Metzmacher [Tue, 13 Dec 2011 14:21:12 +0000 (15:21 +0100)]
s3:smbd/server: pass smbd_parent_context to smbd_setup_sig_chld_handler()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 13:58:50 +0000 (14:58 +0100)]
s3:smbd/globals: change 'int am_parent' into 'struct smbd_parent_context *am_parent'
This is a short term solution on the way to get rid of 'am_parent' completely.
metze
Amitay Isaacs [Tue, 13 Dec 2011 23:07:17 +0000 (10:07 +1100)]
s4-netlogon: Revert patch
f02e4ebfafa6e5911e3fe744b1780527ab12c970
DS_DNS_CONTROLLER bit is set if DC's domain name is dns name.
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Dec 14 07:31:05 CET 2011 on sn-devel-104
Amitay Isaacs [Tue, 13 Dec 2011 22:45:15 +0000 (09:45 +1100)]
tdb2: Fix python documentation for tdb.Tdb object
Amitay Isaacs [Thu, 8 Dec 2011 04:41:55 +0000 (15:41 +1100)]
samba-tool: Fix DN for GPO entries
Amitay Isaacs [Wed, 7 Dec 2011 06:14:58 +0000 (17:14 +1100)]
samba-tool: gpo: fix a typo
Amitay Isaacs [Wed, 7 Dec 2011 02:10:10 +0000 (13:10 +1100)]
samba-tool: Remove duplicate code of dsacl to fsacl conversion
Use samba.ntacls.dsacl2fsacl() instead.
Amitay Isaacs [Wed, 7 Dec 2011 01:26:46 +0000 (12:26 +1100)]
setup: Fix phpldapadmin configuration for version 1.2.x
Günther Deschner [Tue, 13 Dec 2011 23:06:53 +0000 (00:06 +0100)]
s4-smbtorture: fix some typos in schannel test.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Dec 14 02:52:54 CET 2011 on sn-devel-104
Günther Deschner [Tue, 13 Dec 2011 22:38:46 +0000 (23:38 +0100)]
s4-smbtorture: avoid printf(); in schannel test.
Guenther
Günther Deschner [Tue, 13 Dec 2011 22:30:21 +0000 (23:30 +0100)]
s4-smbtorture: remove trailing whitespace from schannel test.
Guenther
Andrew Bartlett [Tue, 13 Dec 2011 06:22:34 +0000 (17:22 +1100)]
s4-resolv: fix dns_ex so as to fail correctly when a name does not exist
Without this, netbios name lookups do not work, as we never fall back to them.
This caused segfaults from
e38d97e0424f7e5b21c8b7ac0b1f1bac33f19d69 to
251209bd6f6e66ca9bcf28cd652d85d1cd729fdc and then name lookup failure
or timeouts until this patch.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Dec 14 01:16:37 CET 2011 on sn-devel-104
Andrew Bartlett [Tue, 13 Dec 2011 04:43:35 +0000 (15:43 +1100)]
s4-selftest: Add test of RPC to a netbios alias
This tries to ensure our netbios lookup code is still run.
Andrew Bartlett
Andrew Bartlett [Tue, 13 Dec 2011 19:55:53 +0000 (06:55 +1100)]
s4-selftest Give local.resolve a real name to look up
Volker Lendecke [Tue, 13 Dec 2011 20:26:21 +0000 (21:26 +0100)]
s3: Fix examples/VFS build
With other builds in the include path, examples get the includes.h wrong
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Dec 13 23:40:37 CET 2011 on sn-devel-104
Stefan Metzmacher [Tue, 13 Dec 2011 13:48:04 +0000 (14:48 +0100)]
s3:smbd/globals: remove unused extern declarations
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Dec 13 22:06:02 CET 2011 on sn-devel-104
Stefan Metzmacher [Tue, 13 Dec 2011 13:38:55 +0000 (14:38 +0100)]
s3:smbd/server: move smbd_open_socket and smbd_parent_context to the top
metze
Stefan Metzmacher [Tue, 13 Dec 2011 13:24:58 +0000 (14:24 +0100)]
s3:smbd/oplock_onefs: avoid using smbd_messaging_context()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 13:24:58 +0000 (14:24 +0100)]
s3:smbd/oplock_onefs: pass smbd_server_connection to onefs_oplock_wait_record()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 13:16:21 +0000 (14:16 +0100)]
s3:vfstest: reload_services() doesn't need a messaging_context
It's only used to get the global smbd_server_connection,
which is used in conn_snum_used() via lp_killunused().
But there we don't need it, as we don't have any tree connects
at startup time.
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:55:02 +0000 (13:55 +0100)]
s3:smbd: pass smbd_server_connection to smbd_setup_sig_hup_handler()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:55:02 +0000 (13:55 +0100)]
s3:smbd: pass smbd_server_connection to smbd_setup_sig_term_handler()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:38:41 +0000 (13:38 +0100)]
s3:smbd/oplock: pass smbd_server_connection to onefs_init_kernel_oplocks()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:38:41 +0000 (13:38 +0100)]
s3:smbd/oplock: pass smbd_server_connection to linux_init_kernel_oplocks()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:38:41 +0000 (13:38 +0100)]
s3:smbd/oplock: pass smbd_server_connection to irix_init_kernel_oplocks()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:18:47 +0000 (13:18 +0100)]
s3:smbd/oplock: pass sconn as private_data to process_open_retry_message()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:18:47 +0000 (13:18 +0100)]
s3:smbd/oplock: pass sconn as private_data to process_kernel_oplock_break()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:18:47 +0000 (13:18 +0100)]
s3:smbd/oplock: pass sconn as private_data to process_oplock_break_response()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:18:47 +0000 (13:18 +0100)]
s3:smbd/oplock: pass sconn as private_data to process_oplock_async_level2_break_message()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:18:47 +0000 (13:18 +0100)]
s3:smbd/oplock: pass sconn as private_data to process_oplock_break_message()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 12:13:53 +0000 (13:13 +0100)]
s3:smbd/oplock: pass smbd_server_connection to init_oplocks()
metze
Volker Lendecke [Tue, 13 Dec 2011 15:07:18 +0000 (16:07 +0100)]
s3: Move can_delete_directory to smbd/, remove shim
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Dec 13 19:00:37 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 13 Dec 2011 15:01:59 +0000 (16:01 +0100)]
s3: Move can_set_delete_on_close to smbd/
Volker Lendecke [Tue, 13 Dec 2011 12:56:49 +0000 (13:56 +0100)]
s3: Remove an else{} in remove_deferred_open_entry
Volker Lendecke [Fri, 9 Dec 2011 15:39:09 +0000 (16:39 +0100)]
s3-dbwrap: Simplify db_tdb_fetchlock_parse a bit
Introduce a local variable for the result, replace "state->result" by "result"
Stefan Metzmacher [Tue, 13 Dec 2011 11:29:54 +0000 (12:29 +0100)]
s3:smbd/msdfs: enum_msdfs_links() doesn't need a smbd_server_connection anymore
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Dec 13 17:26:20 CET 2011 on sn-devel-104
Stefan Metzmacher [Tue, 13 Dec 2011 11:24:03 +0000 (12:24 +0100)]
s3:smbd: use connections_snum_used() instead of conn_snum_used() for load_usershare_shares()
Before removing the share security descriptor, we should make sure there're
really no active users anymore.
metze
Stefan Metzmacher [Tue, 13 Dec 2011 11:18:01 +0000 (12:18 +0100)]
s3:smbd: add connections_snum_used()
This works similar to conn_snum_used(), but instead of
looking at the current connection only, it looks at
all active connections in "connections.tdb".
metze
Stefan Metzmacher [Tue, 13 Dec 2011 10:53:10 +0000 (11:53 +0100)]
s3:lib/dummyparam: remove unused conn_snum_used() dummy
metze
Stefan Metzmacher [Tue, 13 Dec 2011 10:50:04 +0000 (11:50 +0100)]
s3:param: don't reference conn_snum_used directly in load_usershare_shares()
This uses the same logic as lp_killunused().
metze
Volker Lendecke [Tue, 13 Dec 2011 13:11:38 +0000 (14:11 +0100)]
s3: Use talloc_tos() in set_write_time()
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Dec 13 15:44:58 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 13 Dec 2011 13:11:28 +0000 (14:11 +0100)]
s3: Use talloc_tos() in set_sticky_write_time()
Volker Lendecke [Tue, 13 Dec 2011 11:45:11 +0000 (12:45 +0100)]
s3: Convert open_files.idl to tab indents
Stefan Metzmacher [Tue, 13 Dec 2011 08:23:31 +0000 (09:23 +0100)]
s3:messaging.idl: obsolete unused MSG_SMB_SAM_*
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Dec 13 14:13:38 CET 2011 on sn-devel-104
Stefan Metzmacher [Tue, 13 Dec 2011 08:21:58 +0000 (09:21 +0100)]
s3:smbd/server: remove unused msg_sam_sync()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 09:34:19 +0000 (10:34 +0100)]
s3:rpc_server/netlogon: remove unused send_sync_message()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 08:20:20 +0000 (09:20 +0100)]
s3:smbcontrol: remove unused "samsync" and "samrepl" commands
metze
Stefan Metzmacher [Tue, 13 Dec 2011 08:04:20 +0000 (09:04 +0100)]
s3:smbd/server: add parent specific SIGTERM and SIGHUP handlers
metze
Stefan Metzmacher [Tue, 13 Dec 2011 07:54:49 +0000 (08:54 +0100)]
s3:smbd/server: create smbd_parent_context earlier
metze
Stefan Metzmacher [Tue, 13 Dec 2011 07:31:09 +0000 (08:31 +0100)]
s3:smbd/server: remember the ev_ctx on the smbd_parent_context
metze
Stefan Metzmacher [Tue, 13 Dec 2011 07:30:39 +0000 (08:30 +0100)]
s3:smbd/server: remember the msg_ctx on the smbd_parent_context
metze
Stefan Metzmacher [Tue, 13 Dec 2011 07:11:58 +0000 (08:11 +0100)]
s3:smbd/open: pass smbd_server_connection as private_data to msg_file_was_renamed()
metze
Stefan Metzmacher [Tue, 13 Dec 2011 07:19:06 +0000 (08:19 +0100)]
s3:smbd: register MSG_SMB_FILE_RENAME after the fork
The parent smbd doesn't need to handle this, as it doesn't
have any file handles open.
metze
Stefan Metzmacher [Tue, 13 Dec 2011 07:11:58 +0000 (08:11 +0100)]
s3:smbd/conn_msg: pass smbd_server_connection as private_data to msg_force_tdis()
metze