Stig Bjørlykke [Mon, 23 Jun 2008 20:06:20 +0000 (20:06 -0000)]
Fixed some "shadowed variables", as pointed out by John Smith.
svn path=/trunk/; revision=25539
Stig Bjørlykke [Mon, 23 Jun 2008 20:04:31 +0000 (20:04 -0000)]
Don't call an argument "time", as this is a function.
svn path=/trunk/; revision=25538
Guy Harris [Mon, 23 Jun 2008 19:56:47 +0000 (19:56 -0000)]
Add -Wshadow, so we catch cases where somebody might not be using the
variable they think they are.
svn path=/trunk/; revision=25537
Guy Harris [Mon, 23 Jun 2008 18:46:29 +0000 (18:46 -0000)]
Give more details on the stuff Beast does, and suggest a possible scheme
for getting things as right as possible.
gnome_url_show() is run by gnome-open, so just running gnome-open - or
xdg-open, which runs gnome-open on GNOME - will suffice.
svn path=/trunk/; revision=25533
Martin Mathieson [Mon, 23 Jun 2008 17:04:52 +0000 (17:04 -0000)]
Save timestamp when updating entry for new request frames in existing call.
svn path=/trunk/; revision=25532
Martin Mathieson [Mon, 23 Jun 2008 14:58:17 +0000 (14:58 -0000)]
Show short version of Content-Length header.
Fixes but 2635.
svn path=/trunk/; revision=25531
Martin Mathieson [Mon, 23 Jun 2008 13:02:50 +0000 (13:02 -0000)]
Make sure info column is set correctly when tree == NULL.
Fixes but 2561.
svn path=/trunk/; revision=25530
Martin Mathieson [Mon, 23 Jun 2008 10:08:13 +0000 (10:08 -0000)]
Try again to get labels matching function names.
svn path=/trunk/; revision=25529
Martin Mathieson [Mon, 23 Jun 2008 09:24:32 +0000 (09:24 -0000)]
Fix wimax UL-MAP ext IE decode error.
From Frank Wang (bug 2548).
svn path=/trunk/; revision=25528
Stig Bjørlykke [Sun, 22 Jun 2008 22:50:27 +0000 (22:50 -0000)]
Updated the Configuration Profiles chapter in the User Guide.
svn path=/trunk/; revision=25527
Stig Bjørlykke [Sun, 22 Jun 2008 18:42:37 +0000 (18:42 -0000)]
Make the ACTRACE dissector give away the package if it knows its not a ACTRACE.
svn path=/trunk/; revision=25526
Stig Bjørlykke [Sun, 22 Jun 2008 18:36:33 +0000 (18:36 -0000)]
Make the MGCP dissector give away the package if it knows its not a MGCP.
svn path=/trunk/; revision=25525
Bill Meier [Sun, 22 Jun 2008 15:13:08 +0000 (15:13 -0000)]
Use editcap_SOURCES and capinfos_SOURCES in Windows Makefile
svn path=/trunk/; revision=25524
Stig Bjørlykke [Sun, 22 Jun 2008 13:25:57 +0000 (13:25 -0000)]
Updated some chapters in the User Guide.
svn path=/trunk/; revision=25523
Stig Bjørlykke [Sun, 22 Jun 2008 10:59:08 +0000 (10:59 -0000)]
Changes in B.A.T.M.A.N. dissector:
- Fixed last element in value_string arrays
- Fixed a possible bug in a loop making a currently unused string
- Changed preferences prefix to "batman"
- Added udp port preference in batman to be uniform
- Fixed some indents
- Added break in some switches
- Make it compile on win32
svn path=/trunk/; revision=25522
Stig Bjørlykke [Sun, 22 Jun 2008 00:50:29 +0000 (00:50 -0000)]
Removed an unused static entry.
svn path=/trunk/; revision=25521
Stig Bjørlykke [Sun, 22 Jun 2008 00:14:33 +0000 (00:14 -0000)]
From Sven Eckelmann (bug 2632):
Added B.A.T.M.A.N. dissector
svn path=/trunk/; revision=25520
Guy Harris [Sat, 21 Jun 2008 23:53:15 +0000 (23:53 -0000)]
Add stuff to a comment, and move stuff to that comment from elsewhere,
discussing the fun of launching on UNIX+X11.
svn path=/trunk/; revision=25519
Stig Bjørlykke [Sat, 21 Jun 2008 23:40:17 +0000 (23:40 -0000)]
From Peter Hertting (bug 2633):
Added support for IUA carrying X.25.
svn path=/trunk/; revision=25518
Stig Bjørlykke [Sat, 21 Jun 2008 23:07:33 +0000 (23:07 -0000)]
Update manuf
svn path=/trunk/; revision=25517
Stig Bjørlykke [Sat, 21 Jun 2008 23:02:01 +0000 (23:02 -0000)]
Update the services file from IANA's port-numbers.
svn path=/trunk/; revision=25516
Guy Harris [Sat, 21 Jun 2008 18:50:52 +0000 (18:50 -0000)]
We have to define HTML_VIEWER for the prefs.c code that sets the default
value of the Web browser preference, even though that preference won't
be offered.
svn path=/trunk/; revision=25515
Guy Harris [Sat, 21 Jun 2008 18:09:17 +0000 (18:09 -0000)]
If we have xdg-open, always run that to launch a Web browser, and ignore
the Web browser setting; that should honor the user's *real* preferred
Web browser setting (i.e., the one they've selected in their desktop
environment).
Don't bother defining HTML_VIEWER as "xdg-open" if we have xdg-open - we
don't need it.
svn path=/trunk/; revision=25514
Stig Bjørlykke [Sat, 21 Jun 2008 17:30:44 +0000 (17:30 -0000)]
Updated the statusbar documentation:
- Added description of the expert info bullet
- Added description of the configuration profile with menu
- Show the correct Packets/Displayed/Marked(/Dropped) names
- Describe the display filter message when using the != operator
svn path=/trunk/; revision=25513
Anders Broman [Sat, 21 Jun 2008 15:39:01 +0000 (15:39 -0000)]
From Alex Turbov :
Decode buddy name and reason message from 'Grant Future Authorization'
SNAC(13,14) and 'Future Authorization Granted' SNAC(13,15) packets.
svn path=/trunk/; revision=25512
Anders Broman [Sat, 21 Jun 2008 15:29:41 +0000 (15:29 -0000)]
From Thomas Dreibholz:
- Made parameter naming consistent. Example: A Pool Handle Parameter is now
also named "Pool Handle Parameter" instead of "Pool handle" only, because it
contains a field "Pool Handle" which actually contains the PH byte vector. All
parameters are now named "<name> Parameter".
- Made other strings consistent, as in the Internet Drafts. Example: "Pool
element identifier" -> "Pool Element Identifier". Each word begins with
capitalized letter now.
svn path=/trunk/; revision=25511
Anders Broman [Sat, 21 Jun 2008 15:26:57 +0000 (15:26 -0000)]
From Thomas Dreibholz:
Improvements for the ASAP dissector:
- Support for the "Handle Resolution Option" defined in
draft-dreibholz-rserpool-asap-hropt-01.txt has been added. This option is used
in all ASAP Handle Resolution messages of the RSPLIB Open Source RSerPool
implementation (http://tdrwww.exp-math.uni-essen.de/dreibholz/rserpool/).
- Made parameter naming consistent. Example: A Pool Handle Parameter is now
also named "Pool Handle Parameter" instead of "Pool handle" only, because it
contains a field "Pool Handle" which actually contains the PH byte vector. All
parameters are now named "<name> Parameter".
- Made other strings consistent, as in the Internet Drafts. Example: "Pool
element identifier" -> "Pool Element Identifier". Each word begins with
capitalized letter now.
svn path=/trunk/; revision=25510
Stig Bjørlykke [Sat, 21 Jun 2008 15:15:07 +0000 (15:15 -0000)]
Added a brief introduction to the "Interface Details" dialog box.
svn path=/trunk/; revision=25509
Stig Bjørlykke [Sat, 21 Jun 2008 15:13:53 +0000 (15:13 -0000)]
Added a reference to the link-layer chapter.
svn path=/trunk/; revision=25508
Stig Bjørlykke [Sat, 21 Jun 2008 14:06:08 +0000 (14:06 -0000)]
And use correct help topic...
svn path=/trunk/; revision=25507
Stig Bjørlykke [Sat, 21 Jun 2008 13:59:52 +0000 (13:59 -0000)]
Added help topic item previous reused for another topic.
Todo: add documentation text.
svn path=/trunk/; revision=25506
Stig Bjørlykke [Sat, 21 Jun 2008 13:36:31 +0000 (13:36 -0000)]
Removed the usage of topic_available() as we now have all topics.
svn path=/trunk/; revision=25505
Bill Meier [Sat, 21 Jun 2008 13:31:24 +0000 (13:31 -0000)]
Revert incorrect change which killed *nix buuilds...
svn path=/trunk/; revision=25504
Anders Broman [Sat, 21 Jun 2008 13:12:19 +0000 (13:12 -0000)]
From Peter Fuller:
libsmi.m4 had a typo in ldflags that broke LDFLAG settings when --with-libsmi was used
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2555
svn path=/trunk/; revision=25503
Stig Bjørlykke [Sat, 21 Jun 2008 13:08:02 +0000 (13:08 -0000)]
Added a help button in the Interface Options dialog.
Added the Interface Options docbook chapter.
svn path=/trunk/; revision=25502
Bill Meier [Sat, 21 Jun 2008 13:03:18 +0000 (13:03 -0000)]
Fix editcap Windows build problem.....
svn path=/trunk/; revision=25501
Sake Blok [Sat, 21 Jun 2008 10:04:27 +0000 (10:04 -0000)]
From David Moreau (bug 2621):
add support for MSDP protocol based on TFTP
svn path=/trunk/; revision=25500
Sake Blok [Sat, 21 Jun 2008 09:45:21 +0000 (09:45 -0000)]
From Ken Smith (bug 2574): Allow editcap to parse files into even time intervals
A few changes from me:
- make use of nstime_set_unset and nstime_is_unset i.s.o. extra variable first_pass
- change 'if' to 'while' to allow intervals with no packets
- remove 'unused' variable current_pkt_ts
svn path=/trunk/; revision=25499
Gerald Combs [Fri, 20 Jun 2008 20:33:38 +0000 (20:33 -0000)]
Port over the composite tvbuff fixes from /trunk-1.0.
svn path=/trunk/; revision=25498
Anders Broman [Fri, 20 Jun 2008 16:20:10 +0000 (16:20 -0000)]
Add a preference for SCTP port.
svn path=/trunk/; revision=25496
Martin Mathieson [Fri, 20 Jun 2008 15:55:32 +0000 (15:55 -0000)]
Wimax: support TLV type 48 in REG-REQ/REG-RSP.
From cfreeer, fixes bug 2571.
svn path=/trunk/; revision=25495
Martin Mathieson [Fri, 20 Jun 2008 10:26:18 +0000 (10:26 -0000)]
Fix wimax encoding err when packing subheader present.
From Frank Wang, fixes bug 2570.
svn path=/trunk/; revision=25494
Martin Mathieson [Fri, 20 Jun 2008 10:17:13 +0000 (10:17 -0000)]
Support TLV type 36 in wimax plugin.
From cfreeer (fix for bug 2569).
svn path=/trunk/; revision=25493
Guy Harris [Fri, 20 Jun 2008 00:09:47 +0000 (00:09 -0000)]
capture_opts_print_statistics() has nothing to do with capture options
setting, and is used only in dumpcap.c, and needs to get at information
set by dumpcap's signal handlers so it can respond to ^C; move it to
dumpcap.c, rename it print_statistics_loop(), and make it set ld.go to
TRUE before looping and loop only as long as ld.go is TRUE.
That fixes bug 2592 (at least on Mac OS X, and probably on other UN*Xes;
it should fix it on Windows as well).
svn path=/trunk/; revision=25492
Stig Bjørlykke [Thu, 19 Jun 2008 21:56:25 +0000 (21:56 -0000)]
Update the statusbar expert info icon when changing profile.
svn path=/trunk/; revision=25491
Ulf Lamping [Thu, 19 Jun 2008 18:44:23 +0000 (18:44 -0000)]
fix BlockError strings
svn path=/trunk/; revision=25490
Stig Bjørlykke [Thu, 19 Jun 2008 17:25:34 +0000 (17:25 -0000)]
Make storage-based and time-based "Next file every" checkboxes behave equal
in "Use multiple files". Also default to storage-based if not time-based.
This fixes the initial problem in bug #2599.
svn path=/trunk/; revision=25489
Anders Broman [Thu, 19 Jun 2008 16:03:15 +0000 (16:03 -0000)]
If ENBname is a string append that string.
svn path=/trunk/; revision=25488
Anders Broman [Thu, 19 Jun 2008 14:39:43 +0000 (14:39 -0000)]
Export the tvb_get_bits functions.
svn path=/trunk/; revision=25487
Anders Broman [Thu, 19 Jun 2008 14:19:13 +0000 (14:19 -0000)]
Add an expert item warning if a full sequence isn't decoded. ( take 2)
svn path=/trunk/; revision=25486
Stig Bjørlykke [Thu, 19 Jun 2008 12:36:30 +0000 (12:36 -0000)]
Initialize new_offset.
svn path=/trunk/; revision=25485
Anders Broman [Thu, 19 Jun 2008 12:16:26 +0000 (12:16 -0000)]
Add an expert item warning if a full sequence isn't decoded.
svn path=/trunk/; revision=25484
Stig Bjørlykke [Wed, 18 Jun 2008 22:47:58 +0000 (22:47 -0000)]
Do not overwrite existing files when copying dependencies, as this will
overwrite the wireshark libs with libs installed in /opt/local, which is
probably not the ones we want.
svn path=/trunk/; revision=25483
Guy Harris [Wed, 18 Jun 2008 21:23:52 +0000 (21:23 -0000)]
Encase another variable used only if we support capture in #ifdef
HAVE_LIBPCAP/#endif.
svn path=/trunk/; revision=25482
Stig Bjørlykke [Wed, 18 Jun 2008 20:59:57 +0000 (20:59 -0000)]
Put a variable inside a ifdef HAVE_LIBPCAP
svn path=/trunk/; revision=25481
Jaap Keuter [Wed, 18 Jun 2008 20:23:42 +0000 (20:23 -0000)]
Fix for bug 2613:
Add explanation of built-in vs plugin dissectors.
svn path=/trunk/; revision=25480
Stig Bjørlykke [Wed, 18 Jun 2008 20:14:28 +0000 (20:14 -0000)]
Reload the interface list on the welcome page when changing profile and
after editing the interface options.
svn path=/trunk/; revision=25479
Jaap Keuter [Wed, 18 Jun 2008 19:59:24 +0000 (19:59 -0000)]
Fix for bug 2618:
Add MS Time Zone interpretation.
svn path=/trunk/; revision=25478
Guy Harris [Wed, 18 Jun 2008 17:50:01 +0000 (17:50 -0000)]
Comment out the "shilp" entry in the services file, so that port 2049
gets reported as NFS rather than "shilp", whatever *that* is.
svn path=/trunk/; revision=25476
Jaap Keuter [Wed, 18 Jun 2008 17:32:35 +0000 (17:32 -0000)]
Fix for bug 2619:
Current OUI registery has changed location (again). Adjusting script to fetch current file.
Generated dataset based on this current file.
svn path=/trunk/; revision=25475
Martin Mathieson [Wed, 18 Jun 2008 16:06:12 +0000 (16:06 -0000)]
Show enhanced high speed channels more clearly.
svn path=/trunk/; revision=25472
Stig Bjørlykke [Wed, 18 Jun 2008 15:57:12 +0000 (15:57 -0000)]
Draw menu items with radio buttons.
svn path=/trunk/; revision=25471
Jaap Keuter [Wed, 18 Jun 2008 06:27:02 +0000 (06:27 -0000)]
Fix for bug 2616:
According to RFC 3720 the login command doesn't require either T or C, just (C => !T)
svn path=/trunk/; revision=25470
Stig Bjørlykke [Tue, 17 Jun 2008 20:37:34 +0000 (20:37 -0000)]
The recent.gui_time_precision fix introduced a worse bug when changing
profiles, so I revert this and will investigate some more...
svn path=/trunk/; revision=25469
Stig Bjørlykke [Tue, 17 Jun 2008 19:50:22 +0000 (19:50 -0000)]
Popup a menu with configuration profiles instead of the profile dlg
when clicking the profile in the statusbar. Much easier to use.
svn path=/trunk/; revision=25468
Gerald Combs [Tue, 17 Jun 2008 19:05:48 +0000 (19:05 -0000)]
Fully implement Guy's suggested fix. Rename ADDRBUF_MAX_MESSAGE_SIZE to
MAX_ADDR_SIZE, to be more in line with a suggestion by Abhik Sarkar.
svn path=/trunk/; revision=25466
Gerald Combs [Mon, 16 Jun 2008 21:55:37 +0000 (21:55 -0000)]
Fix an off-by-one bug reported by David Ceccanti, as suggested by Guy at
http://www.wireshark.org/lists/wireshark-users/200806/msg00077.html.
Add a comment about the usage of gsm_sms_char_7bit_unpack().
svn path=/trunk/; revision=25462
Jaap Keuter [Mon, 16 Jun 2008 20:49:02 +0000 (20:49 -0000)]
Update Debian packaging files for development version
svn path=/trunk/; revision=25461
Jaap Keuter [Mon, 16 Jun 2008 20:38:26 +0000 (20:38 -0000)]
From Michael Adam:
This patch adds knowledge of the DFS server type to the SMB-BROWSE dissector.
svn path=/trunk/; revision=25460
Jaap Keuter [Mon, 16 Jun 2008 05:33:08 +0000 (05:33 -0000)]
Fix for bug 2612:
cleaned up FT_UINT_STRING type description.
svn path=/trunk/; revision=25459
Jaap Keuter [Mon, 16 Jun 2008 05:32:19 +0000 (05:32 -0000)]
Fix for bug 2611:
Add -v option to example "od" command line.
svn path=/trunk/; revision=25458
Stig Bjørlykke [Sun, 15 Jun 2008 20:53:06 +0000 (20:53 -0000)]
Initialize recent.gui_time_precision when changing profile to avoid a crash
in some rare cases.
svn path=/trunk/; revision=25457
Stig Bjørlykke [Sun, 15 Jun 2008 20:50:10 +0000 (20:50 -0000)]
Cleanup return values from info_bar_new() and packets_bar_new().
svn path=/trunk/; revision=25456
Stig Bjørlykke [Sun, 15 Jun 2008 20:47:06 +0000 (20:47 -0000)]
Click on the profile in the statusbar will open Configuration Profiles dialog.
svn path=/trunk/; revision=25455
Stig Bjørlykke [Sun, 15 Jun 2008 18:29:22 +0000 (18:29 -0000)]
Moved setting of E_MPACKET_LIST_KEY object data to the function creating
packet_list to ensure it's created before we set it.
Applying filter from the packet list still doesn't work correctly.
svn path=/trunk/; revision=25454
Anders Broman [Sat, 14 Jun 2008 21:36:11 +0000 (21:36 -0000)]
Add missing IE id
svn path=/trunk/; revision=25453
Stig Bjørlykke [Sat, 14 Jun 2008 16:51:11 +0000 (16:51 -0000)]
Update all time columns when changing the time precision.
Not implemented for conversation relative and delta time yet, because this
will need a reload as they are set by the dissectors and does not exist in
the frame data.
svn path=/trunk/; revision=25452
Stig Bjørlykke [Sat, 14 Jun 2008 16:45:06 +0000 (16:45 -0000)]
Save the column width in the recent list on every change so we can
pick the correct width when changing the time precision.
svn path=/trunk/; revision=25451
Guy Harris [Fri, 13 Jun 2008 16:52:45 +0000 (16:52 -0000)]
We half-enabled the Mac OS X packaging stuff, which meant that we
weren't including in the tarball stuff the packaging/macosx/Makefile.in
file that that the configure script from the tarball was trying to
expand. Add macosx to the list of directories in packaging/Makefile.am,
and update the comment in packaging/macosx/Makefile.am to reflect the
enabling of the OS X packaging stuff.
svn path=/trunk/; revision=25449
Guy Harris [Fri, 13 Jun 2008 05:54:22 +0000 (05:54 -0000)]
Fix list of files in the debian directory.
svn path=/trunk/; revision=25448
Anders Broman [Thu, 12 Jun 2008 19:18:06 +0000 (19:18 -0000)]
Update to 3GPP TS 36.413 V8.2.0 (2008-06)
svn path=/trunk/; revision=25447
Martin Mathieson [Thu, 12 Jun 2008 16:50:23 +0000 (16:50 -0000)]
Show correct seqno in info column.
svn path=/trunk/; revision=25446
Martin Mathieson [Thu, 12 Jun 2008 16:11:16 +0000 (16:11 -0000)]
Dissect BCH channels (expect control messages only).
svn path=/trunk/; revision=25445
Jeff Morriss [Thu, 12 Jun 2008 13:39:55 +0000 (13:39 -0000)]
From yami via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2603 : register the SMB dissector by name.
svn path=/trunk/; revision=25444
Stig Bjørlykke [Wed, 11 Jun 2008 20:10:19 +0000 (20:10 -0000)]
Return 0 if we don't dissect any bytes.
Set desegment_len = DESEGMENT_ONE_MORE_SEGMENT.
svn path=/trunk/; revision=25443
Jaap Keuter [Wed, 11 Jun 2008 18:20:02 +0000 (18:20 -0000)]
Fix for bug 2396:
Wireshark expects 802.1ah Instance tags to have ethernet type 0x88f0, but latest
802.1ah draft 4.1 defines the 802.1ah Instance tag ethernet type to 0x88e7.
svn path=/trunk/; revision=25442
Jaap Keuter [Wed, 11 Jun 2008 18:16:04 +0000 (18:16 -0000)]
ptvcursor_subtree_set_item() does not need to be exported.
svn path=/trunk/; revision=25441
Guy Harris [Tue, 10 Jun 2008 17:23:36 +0000 (17:23 -0000)]
The change to "Use GTK+ 2.12.10" switched from "libpng13.dll" to
"libpng12-0.dll"; fix a reference to the former.
svn path=/trunk/; revision=25440
Jaap Keuter [Tue, 10 Jun 2008 05:41:29 +0000 (05:41 -0000)]
From Joe Eykholt:
The Fibre-channel FCP dissector shows the wrong byte as the response info
response code byte. The byte with offset 2 in the FCP frame is shown
instead of byte 3 inside the response info.
svn path=/trunk/; revision=25439
Anders Broman [Tue, 10 Jun 2008 05:39:58 +0000 (05:39 -0000)]
From Alex Badea:
Migrate ISAKMP packet decryption from libnettle to libgcrypt
svn path=/trunk/; revision=25438
Anders Broman [Tue, 10 Jun 2008 05:35:38 +0000 (05:35 -0000)]
Use GTK+ 2.12.10
svn path=/trunk/; revision=25437
Martin Mathieson [Fri, 6 Jun 2008 17:54:59 +0000 (17:54 -0000)]
Set release year and month for F7 FP (needed for correct EDCH no-of-subframes field).
svn path=/trunk/; revision=25436
Martin Mathieson [Fri, 6 Jun 2008 09:09:00 +0000 (09:09 -0000)]
Fix RACH extended IE handling.
Flags have different meanings depending upon radio mode...
svn path=/trunk/; revision=25435
Martin Mathieson [Thu, 5 Jun 2008 21:39:06 +0000 (21:39 -0000)]
Squash uninitialised use warning.
svn path=/trunk/; revision=25434
Jaap Keuter [Thu, 5 Jun 2008 20:00:36 +0000 (20:00 -0000)]
From SUZUKI, Shinsuke:
There are some non-ASCII characters in the following file.
svn path=/trunk/; revision=25433
Jaap Keuter [Thu, 5 Jun 2008 13:25:48 +0000 (13:25 -0000)]
Replaced net-SNMP section with libSMI.
svn path=/trunk/; revision=25432
Graham Bloice [Thu, 5 Jun 2008 10:32:51 +0000 (10:32 -0000)]
Added decoding of object 110 (Octet string), fixed reassembly if transport frame doesn't start with 0.
svn path=/trunk/; revision=25431
Martin Mathieson [Thu, 5 Jun 2008 09:15:42 +0000 (09:15 -0000)]
Fix operator precedence problem.
svn path=/trunk/; revision=25430
Jeff Morriss [Thu, 5 Jun 2008 01:29:58 +0000 (01:29 -0000)]
Correct math for counting how many TSNs were GAP acknowledged
svn path=/trunk/; revision=25429
Guy Harris [Wed, 4 Jun 2008 20:53:06 +0000 (20:53 -0000)]
Get rid of unused variable.
svn path=/trunk/; revision=25428