Jeremy Allison [Fri, 23 Jan 2009 00:22:04 +0000 (16:22 -0800)]
Apply same logic fix for #4308 Excel save operation corrupts file ACLs
to NFSv4 ACL code as this uses the same flawed logic as posix_acls.c.
Jeremy.
(cherry picked from commit
cad872fc385ba30fb72baab25ee6341a41396e39)
Jeremy Allison [Fri, 23 Jan 2009 00:09:26 +0000 (16:09 -0800)]
Fix logic error in try_chown - we shouldn't arbitrarily chown
to ourselves unless that was passed in.
Jeremy.
(cherry picked from commit
db2d56484e21daeb91df4b5e2286d242910336e8)
Jeremy Allison [Thu, 22 Jan 2009 22:32:32 +0000 (14:32 -0800)]
Second part of the attemt to fix #4308 - Excel save operation corrupts file ACLs.
If the chown succeeds then the ACL set should also. Ensure this is the case
(refactor some of this code to make it simpler to read also).
Jeremy.
(cherry picked from commit
90b660e2382711d005e8c4c4ae1c6adbd5e5b687)
Jeremy Allison [Thu, 22 Jan 2009 18:59:14 +0000 (10:59 -0800)]
Another attempt to fix bug #4308 - Excel save operation corrupts file ACLs.
Simo is completely correct. We should be doing the chown *first*, and fail the
ACL set if this fails. The long standing assumption I made when writing the
initial POSIX ACL code was that Windows didn't control who could chown a file
in the same was as POSIX. In POSIX only root can do this whereas I wasn't sure
who could do this in Windows at the time (I didn't understand the privilege
model). So the assumption was that setting the ACL was more important (early
tests showed many failed ACL set's due to inability to chown). But now we have
privileges in smbd, and we must always fail an ACL set when we can't chown
first. The key that Simo noticed is that the CREATOR_OWNER bits in the ACL
incoming are relative to the *new* owner, not the old one. This is why the old
user owner disappears on ACL set - their access was set via the USER_OBJ in the
creator POSIX ACL and when the ownership changes they lose their access.
Patch is simple - just ensure we do the chown first before evaluating the
incoming ACL re-read the owners. We already have code to do this it just wasn't
rigorously being applied.
Jeremy.
(cherry picked from commit
96b819e04cd71a6c899801ae68031bf55b54ea46)
todd stecher [Thu, 22 Jan 2009 18:17:37 +0000 (10:17 -0800)]
Memory leaks and other fixes found by Coverity
(cherry picked from commit
ba576efa8f884f3dd37bb5035fbb47ae0305c0b0)
Michael Adam [Wed, 21 Jan 2009 14:10:10 +0000 (15:10 +0100)]
build-docs: cleanup exit of the script
exit in the directory where it was called using pushd/popd.
Michael
(cherry picked from commit
b319549f129b1c79afc9bfd4a84f2730b96d69a3)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
b7d6536b323df9c5503b6a225e03a47ae2112e5c)
Michael Adam [Wed, 21 Jan 2009 14:09:46 +0000 (15:09 +0100)]
s3:docs: clean build/catalog.xml in "make clean"
Michael
(cherry picked from commit
5e21fc3506f2ba7b1135b1acad2697dfb86b5df0)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
a33ec84ef7c64bf94526383340fb446e86d919e0)
Michael Adam [Wed, 21 Jan 2009 14:09:12 +0000 (15:09 +0100)]
s3:docs: clean generated .png images in "make clean"
Michael
(cherry picked from commit
9b32e839bec8611c30745607a3a6b124d5b34c01)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
6a9346f0c2f900d95d0ba3ae0bdb22a6e88a7916)
Michael Adam [Wed, 21 Jan 2009 09:56:34 +0000 (10:56 +0100)]
s3:docs: clarify explanation of the allocator in the idmap_ldap manpage
Michael
(cherry picked from commit
816934faa8bbe53dd299bc5e39f471eafdddefa8)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
0b1036d5d6e06e2fa14dab163d51a902ca63fc0a)
Michael Adam [Wed, 21 Jan 2009 09:55:19 +0000 (10:55 +0100)]
s3:docs: clarify explanation of the allocator in the idmap_tdb manpage
Michael
(cherry picked from commit
665b5dc70333ca36129a6fe06645bd9faa4f2350)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
83a03a3ced255f0a64935fe788ac3b0ddf669ca5)
Michael Adam [Wed, 21 Jan 2009 09:49:48 +0000 (10:49 +0100)]
s3:docs: clarify explanation of allocator in the idmap_tdb2 manpage
Michael
(cherry picked from commit
65b79200e46751278c125ad260d899d10d6466a2)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
73a835335e329f0aaa0b72ebfd538b8c2b813812)
Michael Adam [Wed, 21 Jan 2009 09:38:49 +0000 (10:38 +0100)]
s3:docs: fix copy and paste error in the idmap_tdb2 manpage
Michael
(cherry picked from commit
bd252ad665547d2ad012725ccb18720e160d221f)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
ea5be10d0656d4f7edec43a4cb926573050823aa)
Michael Adam [Tue, 20 Jan 2009 23:56:03 +0000 (00:56 +0100)]
s3:docs: add a manpage for idmap_tdb2
Michael
(cherry picked from commit
84f2b2d731fb7d97c98414196bf96ee94ea88bb3)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
c52948a2b019bb1620ffa69605673d88bfa34bb4)
Michael Adam [Tue, 20 Jan 2009 23:13:29 +0000 (00:13 +0100)]
s3:docs: update the idmap_ldap manpage to reflect current facts.
Michael
(cherry picked from commit
7c5621b6e09d9ae3fe936a86e46d1b0f35906e6d)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
1bbc5f228b8b73a623f7afc5eb79c08757366029)
Michael Adam [Tue, 20 Jan 2009 23:06:10 +0000 (00:06 +0100)]
s3:docs: update the idmap_tdb manpage to reflect current facts.
Michael
(cherry picked from commit
32be66b19da07983670002d1b2b5bc80cf0c8d16)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
4145a1de91a18ea9a09b3088f0e5cd054875760b)
Michael Adam [Wed, 21 Jan 2009 10:47:46 +0000 (11:47 +0100)]
s3:docs: fix ommission in fix of (real)distclean targets
Michael
(cherry picked from commit
37412017c5dd2f05a7f4bbe0410a6e00ce4805e5)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
ba941074ce20617856c138eff5762646384d37de)
Michael Adam [Wed, 21 Jan 2009 10:45:23 +0000 (11:45 +0100)]
s3:create-tarball: also include the VENDOR_PATCH in the version
Michael
(cherry picked from commit
ce3e34d37ce5592e0268be5d16240387d971585a)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
05b83098ed49cee906a5b16d15dce9e6baf62b07)
Michael Adam [Wed, 21 Jan 2009 10:41:14 +0000 (11:41 +0100)]
s3:docs: fix distclean target and add realdistclean target
- remove stuff created by configure in distclean
- remove stuff created by autoconf in realdistclean
Michael
(cherry picked from commit
65c92fea3d18c3520ff2a1e53a0c5c8825c9788f)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
58db911a3845c4a8475c413e5fd8d755498dd447)
Karolin Seeger [Wed, 21 Jan 2009 10:37:30 +0000 (11:37 +0100)]
build_docs: Use 'make distclean' instead of 'make clean'.
This fixes bug #6058.
Thanks to Christian Perrier for reporting!
Karolin
(cherry picked from commit
162e4b66601b41dd5adb24e192f3b5a91dfb41cc)
Karolin Seeger [Tue, 20 Jan 2009 10:35:55 +0000 (11:35 +0100)]
WHATSNEW: Update changes.
Karolin
(cherry picked from commit
28a80ea826aa53337817f9d0ce545b6ac3fd54f2)
Stefan Metzmacher [Tue, 20 Jan 2009 00:37:53 +0000 (16:37 -0800)]
socket_wrapper: fix PCAP support broken by
aaea68791cfea45c6fa69abc93ad6d0e832d0283
We should not close the fd after writing the first packet.
metze
(cherry picked from commit
53e8f92678428a0c3cbeefa83219609661d28831)
Stefan Metzmacher [Tue, 20 Jan 2009 00:26:00 +0000 (16:26 -0800)]
s3: reinit_after_fork() should reinit the event context before the
messaging context
Because messaging_reinit() may add events to the event context, which will
removed by event_context_reinit().
metze
(cherry picked from commit
56af6112d67aa9dd3757297fbe29ce1a3eabf00d)
Andreas Schneider [Mon, 19 Jan 2009 15:26:07 +0000 (16:26 +0100)]
Avoid flooding of syslog with failing pam_putenv messages.
Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
acb1debf257c6c3df325267b2a4c8e2d40c1f850)
Karolin Seeger [Mon, 19 Jan 2009 09:22:46 +0000 (10:22 +0100)]
S3-ByExample: Use 'winbindd -D' instead of 'winbindd -B'.
The option '-B' does not exist at all.
Thanks to Jason Ellison for reporting!
Karolin
(cherry picked from commit
4b26c7bbf4fe93f5ffb92d3f04012be290be25be)
(cherry picked from commit
05c7d97e6cf25c05ba6a661c0a31c88946ffd5cd)
Karolin Seeger [Mon, 19 Jan 2009 07:55:30 +0000 (08:55 +0100)]
S3-HowTo: Change 'winbindd -B' to 'winbindd -D'.
There is no option '-B' at all.
Thanks to Jason Ellison for reporting!
Karolin
(cherry picked from commit
7c1e08518bfbe054db270e72476c642d5db93c0a)
(cherry picked from commit
3b5d2fd4cc5f7cbe22be1dfc593ca4ba29197b66)
Derrell Lipman [Sat, 17 Jan 2009 18:21:54 +0000 (13:21 -0500)]
Determine case sensitivity based on file system attributes.
- Most of the time, we can determine from the file system we're connecting to
whether it supports case sensitivity. In those cases, we now set the
internal case sensitivity flag automatically. For those cases where the
request to retrieve file system attributes fails, we'll use the
user-specified option value.
Derrell
(cherry picked from commit
005bd7eee44160e4531e46be85c67650821a8328)
Stefan Metzmacher [Wed, 14 Jan 2009 11:09:46 +0000 (12:09 +0100)]
s3:cluster: fix ctdb ipv6 support
We need to use CTDB_CONTROL_TCP_CLIENT instead of CTDB_CONTROL_TCP_ADD.
CTDB_CONTROL_TCP_CLIENT has support for 2 modes in newer ctdb versions:
- with struct ctdb_control_tcp it only supports ipv4.
- with struct ctdb_control_tcp_addr it supports ipv4 and ipv6.
You need new header files which defines struct ctdb_control_tcp_addr,
but at runtime it should be fine to work against older
ctdb versions (<= 1.0.68).
metze
(cherry picked from commit
dc6edf1ab4ae8e3fb3ef40b93135ff0ef5407e12)
(cherry picked from commit
c07bcd6efd3383fc3a46fce35fd34df85ab221c9)
Stefan Metzmacher [Wed, 14 Jan 2009 10:52:01 +0000 (11:52 +0100)]
s3:docs: vfs_fileid manpage
metze
(cherry picked from commit
6a94b7b9270f3d69595b93e2632051c9842645c9)
(cherry picked from commit
8e13be1db5c51002ae72c42c505a79406b2f4f63)
Stefan Metzmacher [Wed, 14 Jan 2009 12:59:09 +0000 (13:59 +0100)]
s3:vfs_fileid: readd "fileid:algorithm" as option.
"fileid:mapping" is still supported as fallback.
metze
(cherry picked from commit
554a89df0cf6d9832778e2913f9fe50b78baeedc)
(cherry picked from commit
fe9ad21b8cb5286845350fe2280da2cbe2647bb7)
Derrell Lipman [Sat, 17 Jan 2009 01:30:11 +0000 (20:30 -0500)]
[Bug 6022] smbc_urlencode and smbc_urldecode were not exported
- Since the revamp of libsmbclient, there has still been an external
declaration for smbc_urlencode and smbc_urldecode in libsmbclient.h, yet
those functions were renamed and made private. The two choices were to
remove the function names from libsmbclient.h or to make them public
again. The reported requested that they be public. This commit makes it so.
Derrell
(cherry picked from commit
bf7eb0164b0c69d5d0f3019f3aa524846f6a4394)
Derrell Lipman [Fri, 16 Jan 2009 20:55:08 +0000 (15:55 -0500)]
Treat file names in POSIX-like case-sensitive fashion by default
*** THIS COMMIT CAUSES A CHANGE OF DEFAULT BEHAVIOR IN libsmbclient!!! ***
- libsmbclient now calls cli_set_case_sensitive() for a new CLI. By default,
it requests case-sensitive, but the old behavior of case-insensitive can be
requested with smbc_setOptionCaseSensitive(context, False);
The change of behavior is considered a bug fix, as it was previously
possible to accidentally overwrite a file that had the same case-insensitive
name but a different case-sensitive name as a previously-existing file,
while creating a new file.
Derrell
(cherry picked from commit
20b765f0a20fe7329559e4bf2a9dac4fe8e13c18)
Andreas Schneider [Fri, 16 Jan 2009 20:24:58 +0000 (12:24 -0800)]
Fix a segfault if ? is there but the options are NULL. This is the case if SMBC_parse_path is called by SMBC_stat_ctx.
(cherry picked from commit
889d0dff4e4cfd4d4b4ed16ad64de303c795f879)
Jeremy Allison [Fri, 16 Jan 2009 19:55:57 +0000 (11:55 -0800)]
"First thing, kill all the language lawyers" :-). Ensure possible insane compilers
can't kill us later.
Jeremy.
(cherry picked from commit
54913913be90323889b2f4dbd6a3ab75f4fa7ccd)
Gerald (Jerry) Carter [Fri, 16 Jan 2009 18:06:49 +0000 (12:06 -0600)]
ads_connect: Return immediately on a failed GC connection.
ads_connect_gc() feeds an explicit server to ads_connect(). However, if the
resulting connection fails, the latter function was attempting to find a DC
on its own and continuing the connection. This resulting in GC searches being
sent over a connection using port 389 which would fail when using the base
search suffix outside of the domain naming context.
The fix is to fail immediately in ads_connect() since the GC lookup ordering
is handled already in ads_connect_gc().
(was commit
073e9f42f0c5f5de5d736ec7843d80a274c891ce in master)
(cherry picked from commit
2d0fd7543d0543ce59cb84db64afb99aa1f304b4)
Jeremy Allison [Thu, 15 Jan 2009 23:55:29 +0000 (15:55 -0800)]
Fix bug #6040 - Missing <th> header in Status page.
Based on a patch from pkg-samba-maint@lists.alioth.debian.org.
Jeremy.
(cherry picked from commit
3764e6ed2a683a69706d7654e46b998de9294883)
Jeremy Allison [Thu, 15 Jan 2009 23:50:50 +0000 (15:50 -0800)]
Allow reinit_after_fork to be called safely from within swat and other binaries that don't have
an event context or a msg context. Fixes crash bug in swat.
Jeremy.
(cherry picked from commit
45e6f9c5a4b5d9cdb89f398f1238872251ccbe54)
Stefan Metzmacher [Thu, 15 Jan 2009 12:46:38 +0000 (13:46 +0100)]
packaging(RHEL-CTDB): export CC - really use ccache...
metze
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
51e34b38959115e8a04795837b5c5983dc8d824c)
Jeremy Allison [Thu, 15 Jan 2009 18:41:01 +0000 (10:41 -0800)]
Fix bug #6040 - Calling Samba print server with an aliased DNS-name fails.
Jeremy.
(cherry picked from commit
d6f1bb7677997c4eaa0e474de590c0b36f2dcb3f)
Jeremy Allison [Wed, 14 Jan 2009 21:15:59 +0000 (13:15 -0800)]
Fix bug #6035 - Possible race between fcntl F_SETLKW and alarm delivery.
Jeremy.
(cherry picked from commit
6a8496adce6fa54d5cb86592dd977168319d5da3)
Bo Yang [Wed, 14 Jan 2009 19:48:16 +0000 (11:48 -0800)]
Fix bug in get_dc_name_via_netlogon(), null pointer refrence.
(cherry picked from commit
43d6aabfa58cda95f362e86c324c7f2ae21aec53)
Bo Yang [Wed, 14 Jan 2009 19:16:00 +0000 (11:16 -0800)]
Don't send message to any other child in child process.
(cherry picked from commit
d521529b3fcbcd7b183eb466bc06497998fd7e28)
Jeremy Allison [Tue, 13 Jan 2009 23:42:29 +0000 (15:42 -0800)]
From boyang - ensure we never "return" from a forked child, always _exit().
Jeremy.
(cherry picked from commit
c2515026807e08c7836ef1bd6220bd7eab3a1a5b)
Jeremy Allison [Tue, 13 Jan 2009 19:15:00 +0000 (11:15 -0800)]
Fix bug #6019 File corruption in Clustered SMB/NFS environment managed via CTDB
Jeremy.
(cherry picked from commit
0e4182d6fd49afe5b2629552e0b53c6e177275a9)
Jeremy Allison [Tue, 13 Jan 2009 00:27:31 +0000 (16:27 -0800)]
Deprecate the "share modes" parameter to address bug #6024, swat disagrees with smbstatus as to share mode with share modes = No set in samba.
Jeremy.
(cherry picked from commit
d727c40eabc72f9351dcf5cd17a079c83f349c65)
Stefan Metzmacher [Mon, 12 Jan 2009 11:32:46 +0000 (12:32 +0100)]
s3:libsmb: handle the smb signing states the same in the krb5 and ntlmssp cases
SMB signing works the same regardless of the used auth mech.
We need to start with the temp signing ("BSRSPYL ")
and the session setup response with NT_STATUS_OK
is the first signed packet.
Now we set the krb5 session key if we got the NT_STATUS_OK
from the server and then recheck the packet.
All this is needed to make the fallback from krb5 to
ntlmssp possible. This commit also resets the cli->vuid
value to 0, if the krb5 auth didn't succeed. Otherwise
the server handles NTLMSSP packets as krb5 packets.
The restructuring of the SMB signing code is needed to
make sure the krb5 code only starts the signing engine
on success. Otherwise the NTLMSSP fallback could not initialize
the signing engine (again).
metze
(cherry picked from commit
7d9fd64f38aa5821b38c1223cf87979fc87bfb71)
(cherry picked from commit
8e29070ccd0b5103af2e6da75644169f46700313)
Volker Lendecke [Sat, 10 Jan 2009 16:59:43 +0000 (17:59 +0100)]
Even for srclen == 0 we have to return something
This fixes a regression reported by Corinna Vinschen <corinna@vinschen.de>
Thanks,
Volker
(cherry picked from commit
eb980cd213c9e2b0dc72ffd3c80efd54bef73c82)
Bo Yang [Sat, 10 Jan 2009 22:09:48 +0000 (14:09 -0800)]
Don't set child->requests to NULL in parent after fork
(cherry picked from commit
e4505156522560fb0c7ee3aadd75d4fc9d446609)
Karolin Seeger [Sat, 10 Jan 2009 03:39:46 +0000 (19:39 -0800)]
s3/smbpasswd: Check if Unix account exists before asking for the password.
Admins shouldn't have to type in the password twice when the passdb account
cannot be created because the Unix account is missing.
Karolin
(cherry picked from commit
af0ceb784af1ea8d591f5c35fb010d60b178a8d2)
Karolin Seeger [Fri, 9 Jan 2009 10:22:00 +0000 (11:22 +0100)]
docs: Improve man mount.cifs.
Add hint about specifying the workgroup in the credentials file.
Whitespace cleanup.
This fixes bug #4541.
Patch based on proposed patch from Christian Perrier <bubulle@debian.org>.
Thanks for reporting and providing a patch!
Karolin
(cherry picked from commit
1f7e09ea542df3a2f5f553c0cb11a39c74712950)
(cherry picked from commit
b99d98ff2ef5491979301656e7f516d3c8829f6e)
Tim Prouty [Fri, 9 Jan 2009 01:21:08 +0000 (17:21 -0800)]
s3: Remove a few unnecessary checks from the streams depot module and fix to work with NTRENAME
Handling of error codes when renaming a file to a stream and a stream
to a file is now done in rename_internals_fsp.
The NTRENAME stream path only passes in the stream name, so the new
base can now be different from the old base.
(cherry picked from commit
98eb11ef99418e690ae43116432c0566a28da8a0)
Tim Prouty [Fri, 9 Jan 2009 01:20:14 +0000 (17:20 -0800)]
s3: Remove a few unnecessary checks from the streams xattr module
Handling of error codes when renaming a file to a stream and a stream
to a file is now done in rename_internals_fsp.
The NTRENAME stream path only passes in the stream name, so the new
base can now be different from the old base.
(cherry picked from commit
b377bce1371553e4a9545092cfc8527925b57b67)
Tim Prouty [Fri, 9 Jan 2009 01:19:24 +0000 (17:19 -0800)]
s3: Allow renames of streams via NTRENAME and fix stream error codes on rename
The test_streams_rename2 test in RAW-STREAMS verifies these changes
(cherry picked from commit
fb888dd4f10b00edb258e965ea06e29fa76827d6)
Jeremy Allison [Thu, 8 Jan 2009 23:42:38 +0000 (15:42 -0800)]
Fix bug #6021 - smbclient du command does not recuse properly
Jeremy.
(cherry picked from commit
935173a514bf54ebdf6269e872adfb86a9625f27)
Jeremy Allison [Thu, 8 Jan 2009 18:34:23 +0000 (10:34 -0800)]
Fix race condition in alarm lock processing noticed by Richard Sharpe <realrichardsharpe@gmail.com>.
"It seems to me that if the lock is already held by another process when we
enter this code, there is a race between the timeout and the granting. If
the lock is subsequently granted, the process releasing the lock will signal
the wait variable (or whatever) and our process will be scheduled. However,
if the timeout occurs before we are scheduled, the timeout will be delivered
first.
We will have the lock but will forget we have the lock, and never release
it."
Jeremy.
(cherry picked from commit
92c251ace583391ea1540f0ae455399f8a75cecf)
Jeremy Allison [Wed, 7 Jan 2009 22:55:13 +0000 (14:55 -0800)]
Fix bug #6016 - Alternate Data Streams / Extended Attributes seem to conflict.
Jeremy.
(cherry picked from commit
c5a8337657ebe63e1c12279fcec20a6a1abd8638)
boyang [Wed, 7 Jan 2009 19:01:48 +0000 (11:01 -0800)]
refresh sequence number as soon as possible when domain->sequence_number == -1 or domain->last_status is not ok.
(cherry picked from commit
0e058da2ee3f70e66cdf5d27f7deb479fb4ccae0)
Jeremy Allison [Wed, 7 Jan 2009 01:35:34 +0000 (17:35 -0800)]
Make winbindd_cm.c use winbindd_reinit_after_fork().
Jeremy.
(cherry picked from commit
77a4a3976af353f517b5193bae9cfbe0f3ad6f4c)
Jeremy Allison [Wed, 7 Jan 2009 00:06:22 +0000 (16:06 -0800)]
Fix bug #6017, - magic script does not work. based on a patch from monyo@samba.gr.jp.
Jeremy.
(cherry picked from commit
8bd7b19aaafe96ec6ac0bf700ec9dd337b598c03)
Jeremy Allison [Tue, 6 Jan 2009 23:15:30 +0000 (15:15 -0800)]
Add winbindd_reinit_after_fork(), cleaning out all possible events
in a forked child.
Jeremy.
(cherry picked from commit
e7433112f4f05aeaf9a3c03ec58962c4d9e16c7d)
Jeremy Allison [Tue, 6 Jan 2009 21:16:25 +0000 (13:16 -0800)]
Factor out lots of common code into a function.
Jeremy.
(cherry picked from commit
995fb1dc9c0aaa909dc5928bdffa756ea9402f2d)
Stefan Metzmacher [Tue, 6 Jan 2009 19:22:08 +0000 (11:22 -0800)]
s3:events: change event_add_timed() prototype to match samba4
metze
(cherry picked from commit
a632a1bcd694cff03de3456dac582800e94c451e)
Volker Lendecke [Tue, 6 Jan 2009 14:13:43 +0000 (15:13 +0100)]
s3/swat: Fix creation of the first share using SWAT.
This fixes bug #5965.
(cherry picked from commit
f76614169f1e0a932cf2895702cfa9e8a5735875)
Karolin Seeger [Tue, 6 Jan 2009 11:26:23 +0000 (12:26 +0100)]
docs: Improve description of the share commands in man smb.conf.
-Correct the parameter names.
-Fix typos.
-Fix related parameters.
This fixes bug #6008.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!
Karolin
(cherry picked from commit
8b7f66c548ed170d2dab0c91ccff4aca00f4b52d)
(cherry picked from commit
6f38786aa878bd1a7fc10069773c19b28437fbbb)
Karolin Seeger [Tue, 6 Jan 2009 09:26:37 +0000 (10:26 +0100)]
docs: Fix example in man vfs_recycle.
This fixes bug #6001.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!
Karolin
(cherry picked from commit
9f44a17c3bf36067d04cec036c3e529798932cd7)
(cherry picked from commit
5e073807f7c4679dd299a2b8f3e2643dc1c82405)
Bo Yang [Tue, 6 Jan 2009 05:12:03 +0000 (21:12 -0800)]
set entry->refresh_time to make ccache_regain_all_now() work correctly.
(cherry picked from commit
35c761988df970011722e1cc8dd5ff11dd6d5527)
Stefan Metzmacher [Tue, 6 Jan 2009 05:06:25 +0000 (21:06 -0800)]
s3:events: get rid of the stupid set_event_dispatch_time() function
metze
(cherry picked from commit
ff8ff5379455eafdd11fbd45d31602cf2a5fb57d)
Stefan Metzmacher [Tue, 6 Jan 2009 05:05:48 +0000 (21:05 -0800)]
s3:events: get rid of the stupid cancel_named_event() function
metze
(cherry picked from commit
57b419fac63baa6a2b14e8800e04af75b0a6b7cc)
Stefan Metzmacher [Tue, 6 Jan 2009 05:05:20 +0000 (21:05 -0800)]
s3:events: move prototypes to event.h
metze
(cherry picked from commit
0add7303ea7cb71c070814306c7d6fc97c7c04c2)
Stefan Metzmacher [Tue, 6 Jan 2009 04:55:24 +0000 (20:55 -0800)]
s3:events: remove unused stuff
metze
(cherry picked from commit
550e0e499a44218694e56243a4898ba7d460314d)
Stefan Metzmacher [Tue, 6 Jan 2009 04:54:03 +0000 (20:54 -0800)]
s3:winbindd: regain tickets for all ccache entries, when we go online
set_event_dispatch_time() is stupid by design and only handles
the first event with a given name.
metze
(cherry picked from commit
e1f794a246feab1f100abd961e0e576f0b85453a)
Stefan Metzmacher [Tue, 6 Jan 2009 04:40:19 +0000 (20:40 -0800)]
s3:winbindd: cancel all ccache entry events and not just one
cancel_named_event() is stupid by design and also only cancels
one single event.
metze
(cherry picked from commit
d605077effaf265ea4df66fcaf9007004db61acc)
Stefan Metzmacher [Tue, 6 Jan 2009 04:35:03 +0000 (20:35 -0800)]
s3:winbindd: recreate the per domain check_online_event without relying on global state
set_event_dispatch_time() is stupid by design and just picks the first
event with the given name.
metze
(cherry picked from commit
bd1f723a14578792f4b8fda214096d66d57da208)
Stefan Metzmacher [Tue, 6 Jan 2009 04:20:31 +0000 (20:20 -0800)]
s3:winbindd: rename fd_event => winbindd_fd_event
It's really confusing to have two versions of 'fd_event'
metze
(cherry picked from commit
edac3f78c27a59a6c493f718b6b65ed7ef2a675d)
Stefan Metzmacher [Tue, 6 Jan 2009 04:12:30 +0000 (20:12 -0800)]
s3:winbindd: move WINBINDD_CCACHE_ENTRY and WINBINDD_MEMORY_CREDS to winbindd.h
metze
(cherry picked from commit
5605f478f2a5682f3410d109c0be233e7527335f)
Bo Yang [Tue, 6 Jan 2009 04:05:53 +0000 (20:05 -0800)]
Fix broken krb5 refresh chain
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
d6eb7f1af2f4097085a4a14e9e88327f039bdf29)
Bo Yang [Tue, 6 Jan 2009 00:19:48 +0000 (16:19 -0800)]
clean event context after child is forked.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
ada3145ffe40dfbe89f968e844bfb139a58eab5d)
Jeremy Allison [Mon, 5 Jan 2009 19:42:52 +0000 (11:42 -0800)]
Attempt to fix crash seen with new CUPS async printcap loading code.
Karolin please pull for 3.3.0.
Jeremy.
(cherry picked from commit
9f5c7f55abae9278d4e7ca2f359da1b52d0409a2)
Karolin Seeger [Mon, 5 Jan 2009 15:33:00 +0000 (16:33 +0100)]
examples: Avoid bashism in perfcount.init.
This fixes bug #6000.
Thanks to the Debian Samba package maintainers for providing the patch!
Remove trailing whitespaces.
Karolin
(cherry picked from commit
2e09746a4db4186c9d648370b9004971bc18e5c9)
Karolin Seeger [Mon, 5 Jan 2009 15:35:50 +0000 (16:35 +0100)]
Revert "examples: Avoid bashism in perfcount.init."
This reverts commit
a1bf1f1819ab184682327583d05b0258db8856ef.
Karolin Seeger [Mon, 5 Jan 2009 15:16:18 +0000 (16:16 +0100)]
WHATSNEW: Update changes since 3.3.0rc2.
Karolin
(cherry picked from commit
39f3af99add8aa1f32bc537fbcb85377d0c41111)
Volker Lendecke [Mon, 5 Jan 2009 14:47:19 +0000 (15:47 +0100)]
Fix bug 6014 -- mget shouldn't segfault without arguments
Thanks to kevin.paulus@mtm.kuleuven.be for the bug report
Volker
(cherry picked from commit
9c80ce9b4f3d2b130cf58610f36ed46a7e17baf4)
Karolin Seeger [Mon, 5 Jan 2009 13:54:28 +0000 (14:54 +0100)]
examples: Avoid bashism in perfcount.init.
This fixes bug #6000.
Thanks to the Debian Samba package maintainers for providing the patch!
Remove trailing whitespaces.
Karolin
(cherry picked from commit
73875cd344608b591fa884ab99b5f3a10550c149)
(cherry picked from commit
e273c07e94ee607bbf05b6fa66cf3cea13fe4502)
Karolin Seeger [Mon, 5 Jan 2009 13:39:59 +0000 (14:39 +0100)]
docs: Document the -g option of smbclient.
This fixes bug #6013.
Thanks to the Debian Samba packages maintainers for reporting!
Karolin
(cherry picked from commit
6752d78e946b2c4278e2deba325c76fb7ffbc06a)
(cherry picked from commit
e6abdbde9b67801d46c9d331045d155717e8b241)
Volker Lendecke [Mon, 5 Jan 2009 12:41:39 +0000 (13:41 +0100)]
Fix a bad memleak in vfs_full_audit
(cherry picked from commit
5abbfc9c41d197a57cad6d0272c9c2dfef377f93)
Volker Lendecke [Mon, 5 Jan 2009 11:58:23 +0000 (12:58 +0100)]
Fix bug 6012: Add "get_real_filename" to full_audit
Thanks to Hodur <coil93@gmail.com> for testing!
Volker
(cherry picked from commit
83f6ef1f5d1d0d86032d00d3337c415be746dda4)
Michael Adam [Thu, 18 Dec 2008 17:01:55 +0000 (18:01 +0100)]
smbd: prevent access to root filesystem when connecting with empty service name
This only applies to a setup with "registry shares = yes"
Michael
(cherry picked from commit
288fa94ac7cfdf7457b5098c33fc840bed3d5410)
(cherry picked from commit
e85526b184e66f86b7faa9d0a37288a09c12c19e)
(cherry picked from commit
5dfa403498c4f4a0eb05a5331b81326832ddd63f)
Jeremy Allison [Sun, 4 Jan 2009 19:46:28 +0000 (11:46 -0800)]
Fix bug #6009 - Setting "min receivefile size = 1" breaks writes.
Karolin please pull for 3.3.0. Thanks !
Jeremy.
(cherry picked from commit
b8fef4ce2ed627387a22dfb5be1fa59c2e486aff)
Volker Lendecke [Fri, 2 Jan 2009 13:53:26 +0000 (14:53 +0100)]
Alternative fix for
45db33e73 and
0d443ae7931
Simo is right, we need to ask passdb first. At least this fixes a nasty to find
NT_STATUS_ACCESS_DENIED problem in the build farm for the test run I just did
on host "opi".
Michael, can you re-check if this also fixes the error you found, leading to
the two fixes?
Thanks,
Volker
(cherry picked from commit
f2535d7b94cfc6bec05127576186d93531304005)
Volker Lendecke [Fri, 2 Jan 2009 14:02:03 +0000 (15:02 +0100)]
Revert "Fix uid_to_sid mapping when the idmap cache is empty."
This reverts commit
d4bc1f8d79929dc1a1d06e92eaf85923a1848e6f.
(cherry picked from commit
605f5911febc25f40c697d4fc1097584ba49021e)
Volker Lendecke [Fri, 2 Jan 2009 14:01:47 +0000 (15:01 +0100)]
Revert "idmap: Remove passd check from idmap_backends_unixid_to_sid()."
This reverts commit
3d22b77f1ac5e8f83d1063d87c68e60655a3ed6b.
(cherry picked from commit
860da910633415d1a3c850ed977a6635d28a7bf2)
Michael Adam [Wed, 17 Dec 2008 21:27:39 +0000 (22:27 +0100)]
packaging(RHEL): fix typo in [u]mount.cifs installation
Michael
(cherry picked from commit
835108bcf84a5f47f46d237c7a93c572348125a1)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
71c74725bce403e36e4dc38287802c95b8d4de66)
(cherry picked from commit
cfc140d3924dd6be893d242ce5df22e2128f09f8)
Michael Adam [Wed, 17 Dec 2008 17:56:34 +0000 (18:56 +0100)]
packaging(RHEL): fix build of [u]mount.cifs
mount.cifs is now built by make everything.
And it needs extra objects anyways (mtab.o),
which is why the build of mount.cifs failed.
Michael
(cherry picked from commit
96c811cf222be5463a6705feae73d6215685c5f1)
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
308dbca653ce1d689b75f9b781237c67df4233a8)
(cherry picked from commit
9745e36c011a76669aad7a0a861ba1520ef8cec3)
Karolin Seeger [Fri, 2 Jan 2009 12:48:48 +0000 (13:48 +0100)]
WHATSNEW: Update changes since 3.3.0rc2.
Karolin
(cherry picked from commit
16b71af7699836ce834a12918a8dd7ca61c2a86a)
Karolin Seeger [Fri, 2 Jan 2009 12:45:02 +0000 (13:45 +0100)]
VERSION: Raise version number.
Karolin
Stefan Metzmacher [Fri, 2 Jan 2009 08:46:17 +0000 (09:46 +0100)]
Happy New Year!
metze
(cherry picked from commit
e385b4175d9accc6b78f0f506d1c1f696a1dcad1)
Volker Lendecke [Thu, 1 Jan 2009 21:05:03 +0000 (22:05 +0100)]
Fix bug 5913.
Never seen this to be a problem, but it doesn't hurt either :-)
(cherry picked from commit
8f2d5137852fd3f2a376a7fa71f1a5c8b947bd37)
Jeremy Allison [Thu, 1 Jan 2009 03:06:00 +0000 (19:06 -0800)]
Fix warnings in make test code.
Jeremy.
(cherry picked from commit
675c4d836ec328320994bc1632a14ac5597bbdf8)
Jeremy Allison [Thu, 1 Jan 2009 01:27:52 +0000 (17:27 -0800)]
Fix all warnings with gcc4.3.
Jeremy.
(cherry picked from commit
0994b094569474d47e7b98e39438829e962a27e1)
Jeremy Allison [Thu, 1 Jan 2009 00:16:52 +0000 (16:16 -0800)]
Fix more asprintf and "ignoring return code" warnings from gcc 4.3.
Jeremy.
(cherry picked from commit
cfee202547a536a54284a14732df2e48eef99952)
Volker Lendecke [Wed, 31 Dec 2008 17:37:39 +0000 (18:37 +0100)]
recvfile can't be used for printing so far
(cherry picked from commit
3367acd7fac7758ef5eb027bcd8bcbfbb3f3c0fd)