Anders Broman [Sun, 11 Mar 2012 22:31:18 +0000 (22:31 -0000)]
From Steve Magnani: knock URB Setup out from under USB URB https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6934
svn path=/trunk/; revision=41492
Guy Harris [Sun, 11 Mar 2012 20:08:54 +0000 (20:08 -0000)]
Don't close the currently loaded capture file in capture_start(), do so
in its callers; when starting a capture with "wireshark -k", there's no
capture file to close, and closing it might be provoking some UI actions
that cause crashes on Windows.
Don't copy the list of selected interfaces to the list of capture
interfaces in capture_start(), either, do that in the callers; we were
already doing that in one place and, in one of the remaining cases,
namely "wireshark -k", we should do so only if no capture interfaces
were supplied on the command line. (I.e., the set of interfaces on
which we want to capture depends on where in the UI the capture is being
started.)
svn path=/trunk/; revision=41491
Guy Harris [Sun, 11 Mar 2012 20:01:11 +0000 (20:01 -0000)]
Add a comment to indicate what collect_ifaces() does.
svn path=/trunk/; revision=41490
Guy Harris [Sun, 11 Mar 2012 20:00:39 +0000 (20:00 -0000)]
If the length is bogus in a message received from the sync pipe, dump
out all 4 bytes we read, to provide more information about the message
that was sent so it's easier to see if something was spewing extra
output to the standard output or error in the child.
svn path=/trunk/; revision=41489
Guy Harris [Sun, 11 Mar 2012 19:59:08 +0000 (19:59 -0000)]
Fix function name in debugging message.
svn path=/trunk/; revision=41488
Anders Broman [Sun, 11 Mar 2012 19:31:10 +0000 (19:31 -0000)]
Add a comments LED
svn path=/trunk/; revision=41487
Alexis La Goutte [Sun, 11 Mar 2012 19:05:32 +0000 (19:05 -0000)]
From Francesco Fondelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6787
Move Y.1711 out of MPLS dissector
ITU-T Y.1711 code was "embedded" into the MPLS dissector in 2006.
This patch moves it into its own dissector.
From me :
Fix a Clang warning
svn path=/trunk/; revision=41486
Gerald Combs [Sun, 11 Mar 2012 14:03:34 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-03-11]
svn path=/trunk/; revision=41483
Stig Bjørlykke [Sun, 11 Mar 2012 14:03:13 +0000 (14:03 -0000)]
Do not assign a value to itself.
svn path=/trunk/; revision=41482
Stig Bjørlykke [Sun, 11 Mar 2012 14:02:59 +0000 (14:02 -0000)]
Return a valid offset from process_app0_segment().
The return value is not used, but this removes a warning.
svn path=/trunk/; revision=41481
Stig Bjørlykke [Sun, 11 Mar 2012 12:00:27 +0000 (12:00 -0000)]
Remove extraneous parentheses around some comparisons to silence a warning.
svn path=/trunk/; revision=41480
Stig Bjørlykke [Sun, 11 Mar 2012 12:00:13 +0000 (12:00 -0000)]
Free name string only when used.
svn path=/trunk/; revision=41479
Stig Bjørlykke [Sun, 11 Mar 2012 12:00:00 +0000 (12:00 -0000)]
Use _U_ for unused arguments.
svn path=/trunk/; revision=41478
Guy Harris [Sun, 11 Mar 2012 07:10:48 +0000 (07:10 -0000)]
capture_opts_add_opt() does just fine at adding an interface to the
capture options, so don't special-case the -i option.
svn path=/trunk/; revision=41477
Guy Harris [Sat, 10 Mar 2012 19:05:46 +0000 (19:05 -0000)]
Reflect the rename of the Xylan RADIUS dictionary.
svn path=/trunk/; revision=41476
Alexis La Goutte [Sat, 10 Mar 2012 19:00:34 +0000 (19:00 -0000)]
Fix QtShark build after the move of alert_box.c in ui folder
svn path=/trunk/; revision=41475
Alexis La Goutte [Sat, 10 Mar 2012 18:30:20 +0000 (18:30 -0000)]
Rename the Xylan dictionnary to Alcatel-Lucent Xylan dictionnary
Alcatel (now Alcatel-Lucent) buy Xylan in 1999...
And now Attributs RADIUS is used in Alcatel-Lucent Omniswitch Product.
svn path=/trunk/; revision=41474
Alexis La Goutte [Sat, 10 Mar 2012 17:51:47 +0000 (17:51 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41473
Alexis La Goutte [Sat, 10 Mar 2012 17:51:32 +0000 (17:51 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41472
Alexis La Goutte [Sat, 10 Mar 2012 17:51:18 +0000 (17:51 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41471
Alexis La Goutte [Sat, 10 Mar 2012 17:50:28 +0000 (17:50 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41470
Alexis La Goutte [Sat, 10 Mar 2012 17:49:33 +0000 (17:49 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41469
Alexis La Goutte [Sat, 10 Mar 2012 17:49:17 +0000 (17:49 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41468
Alexis La Goutte [Sat, 10 Mar 2012 17:49:00 +0000 (17:49 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41467
Alexis La Goutte [Sat, 10 Mar 2012 17:48:33 +0000 (17:48 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41466
Alexis La Goutte [Sat, 10 Mar 2012 17:48:17 +0000 (17:48 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41465
Alexis La Goutte [Sat, 10 Mar 2012 17:47:28 +0000 (17:47 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41464
Alexis La Goutte [Sat, 10 Mar 2012 17:47:07 +0000 (17:47 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41463
Alexis La Goutte [Sat, 10 Mar 2012 17:46:18 +0000 (17:46 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41462
Alexis La Goutte [Sat, 10 Mar 2012 17:45:17 +0000 (17:45 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41461
Anders Broman [Sat, 10 Mar 2012 17:00:30 +0000 (17:00 -0000)]
Don't register the payload type unless it's in the dynamic range
svn path=/trunk/; revision=41460
Anders Broman [Sat, 10 Mar 2012 16:16:07 +0000 (16:16 -0000)]
From martijn: subdissectors for URB_INTERRUPT. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6929
svn path=/trunk/; revision=41459
Anders Broman [Sat, 10 Mar 2012 16:09:28 +0000 (16:09 -0000)]
From Steve Magnani: USB: centralize some common dissection code for class reuse. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6930
svn path=/trunk/; revision=41458
Guy Harris [Sat, 10 Mar 2012 09:08:03 +0000 (09:08 -0000)]
Replace 4-space tabs (and one 8-space tab, the only remaining tab in the
file after replacing the 4-space tabs) with spaces.
svn path=/trunk/; revision=41457
Guy Harris [Sat, 10 Mar 2012 09:01:48 +0000 (09:01 -0000)]
Replace inconsistent tabs with spaces.
svn path=/trunk/; revision=41456
Gerald Combs [Sat, 10 Mar 2012 00:24:42 +0000 (00:24 -0000)]
In pcapng.c use the units per second value from the interface instead of
the default.
Add support for reading nseclibpcap files to dumpcap.
svn path=/trunk/; revision=41455
Anders Broman [Fri, 9 Mar 2012 15:29:35 +0000 (15:29 -0000)]
Forward interface_opts.descr (currently empty) when writing IDB:s
svn path=/trunk/; revision=41454
Jeff Morriss [Fri, 9 Mar 2012 14:25:30 +0000 (14:25 -0000)]
Fix up indentation (get rid of 4-space tabs).
svn path=/trunk/; revision=41453
Anders Broman [Fri, 9 Mar 2012 14:20:53 +0000 (14:20 -0000)]
Mark an unused parameter as such.
svn path=/trunk/; revision=41452
Anders Broman [Fri, 9 Mar 2012 13:36:29 +0000 (13:36 -0000)]
Make packet comments editable from the expert info tab.
svn path=/trunk/; revision=41451
Anders Broman [Fri, 9 Mar 2012 12:45:19 +0000 (12:45 -0000)]
From Sylvain Munaut:
packet-gmr1_dtap: Add dissector for GMR1 DTAP messages (Step 4(4)).
Added to Cmalelists.txt and #if 0 zero lenght hf array which windows
build did not like.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921
svn path=/trunk/; revision=41450
Anders Broman [Fri, 9 Mar 2012 12:33:16 +0000 (12:33 -0000)]
From Sylvain Munaut:
packet-gsmtap: Call the GMR-1 CCCH dissector when appropriate (Step 3).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921
svn path=/trunk/; revision=41449
Anders Broman [Fri, 9 Mar 2012 12:15:08 +0000 (12:15 -0000)]
From Sylvain Munaut:
packet-gmr1_rr: Add dissector for GMR-1 RR elements and CCCH messages (Step 2).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921
svn path=/trunk/; revision=41448
Anders Broman [Fri, 9 Mar 2012 11:47:55 +0000 (11:47 -0000)]
From Jose Pedro Oliveira:
pcapio.c: write IDB options in numeric order and corrects the IDB block_total_length.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6718
svn path=/trunk/; revision=41447
Anders Broman [Fri, 9 Mar 2012 09:38:21 +0000 (09:38 -0000)]
From Sylvain Munaut:
GMR-1: Add dissections for various GMR 04.08 elements (Step1).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921
svn path=/trunk/; revision=41446
Anders Broman [Fri, 9 Mar 2012 05:08:30 +0000 (05:08 -0000)]
From Sylvain Munaut: gsm_a_common: ELEM_MAND_VV_SHORT doesn't support IEs of different types. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6924
svn path=/trunk/; revision=41445
Anders Broman [Fri, 9 Mar 2012 05:02:27 +0000 (05:02 -0000)]
From Jose Pedro Oliveira: Make dumpcap write the if_tsresol option (using the default value) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6718
svn path=/trunk/; revision=41444
Anders Broman [Fri, 9 Mar 2012 04:50:43 +0000 (04:50 -0000)]
From Jose Pedro Oliveira: Corrects several 'wdh->bytes_dumped += ...' lines. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6718
svn path=/trunk/; revision=41443
Guy Harris [Thu, 8 Mar 2012 20:02:10 +0000 (20:02 -0000)]
Convert 4-space tabs to spaces.
svn path=/trunk/; revision=41442
Guy Harris [Thu, 8 Mar 2012 20:00:49 +0000 (20:00 -0000)]
Convert 4-space tabs to spaces.
svn path=/trunk/; revision=41441
Gerald Combs [Thu, 8 Mar 2012 19:07:02 +0000 (19:07 -0000)]
Update the comment icons and tooltips.
svn path=/trunk/; revision=41440
Bill Meier [Thu, 8 Mar 2012 18:11:35 +0000 (18:11 -0000)]
Set svn:keywords & svn:eol-style properties
svn path=/trunk/; revision=41439
Bill Meier [Thu, 8 Mar 2012 17:48:46 +0000 (17:48 -0000)]
Remove duplicate copy of contents appended to the end of the file;
Fix $Id so it works: '$ID: $' ==> '$ID$';
Convert '4-space' tabs to spaces.
svn path=/trunk/; revision=41438
Guy Harris [Thu, 8 Mar 2012 17:43:34 +0000 (17:43 -0000)]
Reflect the move of alert_box.c to the ui directory.
svn path=/trunk/; revision=41437
Guy Harris [Thu, 8 Mar 2012 17:30:02 +0000 (17:30 -0000)]
Move alert_box.c to the ui directory.
svn path=/trunk/; revision=41436
Martin Mathieson [Thu, 8 Mar 2012 16:30:39 +0000 (16:30 -0000)]
Want to write RRC info column info always. Also save and restore writable
flag.
svn path=/trunk/; revision=41435
Martin Mathieson [Thu, 8 Mar 2012 13:20:33 +0000 (13:20 -0000)]
Change the way the count of subheaders is displayed in the header.
svn path=/trunk/; revision=41434
Martin Mathieson [Thu, 8 Mar 2012 13:19:41 +0000 (13:19 -0000)]
Add a preference to show in the info column RLC, PDCP or traffic
details.
svn path=/trunk/; revision=41433
Anders Broman [Thu, 8 Mar 2012 11:09:39 +0000 (11:09 -0000)]
From Sylvain Munaut: gsm_a_common: elem_v_short doesn't create subtree for the IE https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6923
svn path=/trunk/; revision=41432
Martin Mathieson [Thu, 8 Mar 2012 11:08:17 +0000 (11:08 -0000)]
Put UM and AM extension headers inside the header tree.
svn path=/trunk/; revision=41431
Martin Mathieson [Thu, 8 Mar 2012 10:59:49 +0000 (10:59 -0000)]
Write UEID to info column using left-justified, fixed width.
svn path=/trunk/; revision=41430
Anders Broman [Thu, 8 Mar 2012 10:23:04 +0000 (10:23 -0000)]
Fix dissecton of speech codec list
svn path=/trunk/; revision=41429
Anders Broman [Thu, 8 Mar 2012 10:16:30 +0000 (10:16 -0000)]
Add capture_comment_icons.h
svn path=/trunk/; revision=41428
Michael Tüxen [Thu, 8 Mar 2012 09:25:13 +0000 (09:25 -0000)]
From Robin Seggelmann: Add support for the New Session Ticket
message according to RFC 5077.
svn path=/trunk/; revision=41427
Guy Harris [Thu, 8 Mar 2012 08:46:52 +0000 (08:46 -0000)]
And fix some other ../../image/...s for out-of-tree builds.
svn path=/trunk/; revision=41426
Guy Harris [Thu, 8 Mar 2012 08:45:20 +0000 (08:45 -0000)]
Fix to handle out-of-tree builds - use $(top_srcdir) rather than a
string of ../ items to get to another directory in the source tree, as,
when doing an out-of-tree build, the source tree is a separate tree from
the build tree.
svn path=/trunk/; revision=41425
Anders Broman [Thu, 8 Mar 2012 08:07:21 +0000 (08:07 -0000)]
summary_dlg.c:419: error: 'dl_description' undeclared (first use in this function)
svn path=/trunk/; revision=41424
Anders Broman [Thu, 8 Mar 2012 08:04:39 +0000 (08:04 -0000)]
Don't show expert info or comments icons unless we have a file loaded
svn path=/trunk/; revision=41423
Anders Broman [Thu, 8 Mar 2012 07:28:26 +0000 (07:28 -0000)]
Put a frame around capture comments, don't depend on LIBPCAP to print dl_description or capture filter info
svn path=/trunk/; revision=41422
Anders Broman [Thu, 8 Mar 2012 06:59:38 +0000 (06:59 -0000)]
Use an OK button rather than save for consistency, wouldapply be more apropriate?
svn path=/trunk/; revision=41421
Guy Harris [Thu, 8 Mar 2012 06:19:09 +0000 (06:19 -0000)]
Put more stuff from images into the release tarball.
svn path=/trunk/; revision=41420
Anders Broman [Thu, 8 Mar 2012 06:11:20 +0000 (06:11 -0000)]
From Sylvain Munaut: proto_tree_add_split_bits_item_ret_val doesn't handle signed value properly https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6920
svn path=/trunk/; revision=41419
Martin Mathieson [Thu, 8 Mar 2012 04:49:59 +0000 (04:49 -0000)]
Include direction in some malformed expert info strings.
svn path=/trunk/; revision=41418
Jeff Morriss [Thu, 8 Mar 2012 03:57:48 +0000 (03:57 -0000)]
From Weston Andros Adamson via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6919 :
Both deviceid4 and sessionid4 are currently decoded as rpc_opaque_data - this
means their values are never displayed in the "Packet Detail" section and to
see them you have to select the name in the "Packet Detail" section and look at
the byte range in the "Packet Bytes" section.
The attached patch (against today's SVN) adds dissectors for both so these
values are displayed in the "Packet Detail" section.
svn path=/trunk/; revision=41417
Jeff Morriss [Thu, 8 Mar 2012 02:33:14 +0000 (02:33 -0000)]
Followup to r41415: don't enable *any* of the file operations during a live
capture.
svn path=/trunk/; revision=41416
Jeff Morriss [Thu, 8 Mar 2012 02:18:12 +0000 (02:18 -0000)]
As reported by Joerg on -dev: don't enable File->Save if we're still reading
the file (as is the case during a live capture).
Replace tabs with spaces (for consistency with the rest of the file).
svn path=/trunk/; revision=41415
Jeff Morriss [Thu, 8 Mar 2012 02:06:44 +0000 (02:06 -0000)]
Rewrite this shell script so that it sets the appropriate SVN properties based
on the file name that is being added.
Add a copyright notice.
svn path=/trunk/; revision=41414
Jeff Morriss [Thu, 8 Mar 2012 01:33:47 +0000 (01:33 -0000)]
Fix up SVN properties
svn path=/trunk/; revision=41413
Gerald Combs [Thu, 8 Mar 2012 01:24:31 +0000 (01:24 -0000)]
Create some standard definitions for dialog control spacing. Use them in
the comment dialog.
svn path=/trunk/; revision=41412
Jeff Morriss [Wed, 7 Mar 2012 23:04:15 +0000 (23:04 -0000)]
Rename the functions and variables to go along with r41410.
svn path=/trunk/; revision=41411
Jeff Morriss [Wed, 7 Mar 2012 22:38:02 +0000 (22:38 -0000)]
Use OK, Clear, and Cancel in the comment dialogs (instead of Save, Clear, and Close). This makes the UI similar to our Preferences dialog. And it avoids confusion about whether Save will save the file or not.
svn path=/trunk/; revision=41410
Jeff Morriss [Wed, 7 Mar 2012 22:19:06 +0000 (22:19 -0000)]
Set File->Save sensitivity after file or packet comments are changed.
svn path=/trunk/; revision=41409
Guy Harris [Wed, 7 Mar 2012 21:48:08 +0000 (21:48 -0000)]
And one more image file.
svn path=/trunk/; revision=41408
Guy Harris [Wed, 7 Mar 2012 21:46:58 +0000 (21:46 -0000)]
Include the new images in the release tarball.
svn path=/trunk/; revision=41407
Gerald Combs [Wed, 7 Mar 2012 20:56:01 +0000 (20:56 -0000)]
Update and add icons for capture comments / annotations.
svn path=/trunk/; revision=41406
Anders Broman [Wed, 7 Mar 2012 20:09:48 +0000 (20:09 -0000)]
From Sylvain Munaut: Call the new dissector from the GSMTap dissector for GMR-1 channels using LAPSat
svn path=/trunk/; revision=41405
Anders Broman [Wed, 7 Mar 2012 19:53:03 +0000 (19:53 -0000)]
From Sylvain Munaut: Add support LAPSat : GMR-1 Datalink layer https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6918
svn path=/trunk/; revision=41404
Anders Broman [Wed, 7 Mar 2012 18:17:07 +0000 (18:17 -0000)]
IEEE1588 PTPv2 over IPv6 -> Padding issue. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6836
svn path=/trunk/; revision=41403
Anders Broman [Wed, 7 Mar 2012 17:02:27 +0000 (17:02 -0000)]
The User & Network direction is reversed https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6656
svn path=/trunk/; revision=41402
Bill Meier [Wed, 7 Mar 2012 16:54:12 +0000 (16:54 -0000)]
Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
(Use a valid 'parent field width' in the hf[] 'display' field.
svn path=/trunk/; revision=41401
Bill Meier [Wed, 7 Mar 2012 16:38:08 +0000 (16:38 -0000)]
Update descriptions of hf[] FIELDDISPLAY and BITMASK fields.
svn path=/trunk/; revision=41400
Bill Meier [Wed, 7 Mar 2012 16:19:24 +0000 (16:19 -0000)]
Revise and enable test for hf[] FT_BOOLEAN fields with a non-zero bit mask and with BASE_... in the 'display' field.
svn path=/trunk/; revision=41399
Bill Meier [Wed, 7 Mar 2012 16:02:48 +0000 (16:02 -0000)]
Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
(Use a valid 'parent field width' in the hf[] 'display' field.
svn path=/trunk/; revision=41398
Bill Meier [Wed, 7 Mar 2012 16:01:31 +0000 (16:01 -0000)]
Add editor modelines; Fix some indentation.
svn path=/trunk/; revision=41397
Bill Meier [Wed, 7 Mar 2012 15:39:39 +0000 (15:39 -0000)]
Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
(Use a valid 'parent field width' in the hf[] 'display' field.
svn path=/trunk/; revision=41396
Anders Broman [Wed, 7 Mar 2012 15:18:22 +0000 (15:18 -0000)]
ISO SSAP: ActivityStart: Invalid decoding the activity parameter as a BER Integer - decode as bytes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2873
svn path=/trunk/; revision=41395
Anders Broman [Wed, 7 Mar 2012 14:28:29 +0000 (14:28 -0000)]
From Yegor Yefremov: Add dissector for CANopen protocol https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6651 with some modifications
svn path=/trunk/; revision=41394
Anders Broman [Wed, 7 Mar 2012 12:06:16 +0000 (12:06 -0000)]
Location Number not decoded as per Q.763 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6781
svn path=/trunk/; revision=41393
Jörg Mayer [Wed, 7 Mar 2012 11:58:05 +0000 (11:58 -0000)]
Comment fix: i10n -> i18n
svn path=/trunk/; revision=41392
Alexis La Goutte [Wed, 7 Mar 2012 10:41:15 +0000 (10:41 -0000)]
Update Qt Documentation about translation/i18n
svn path=/trunk/; revision=41391