Andreas Schneider [Thu, 27 Oct 2011 09:21:08 +0000 (11:21 +0200)]
s3-netlogon: Fix setting the machinge account password.
This bug has been found with uid wrapper.
Jeremy Allison [Wed, 26 Oct 2011 19:41:18 +0000 (12:41 -0700)]
Factor out the code checking if a parent should override DELETE_ACCESS into a function.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 26 23:15:05 CEST 2011 on sn-devel-104
Jeremy Allison [Wed, 26 Oct 2011 18:00:11 +0000 (11:00 -0700)]
Remove another level of indentation - deal with !NT_STATUS_OK individually.
Jeremy Allison [Wed, 26 Oct 2011 19:08:51 +0000 (12:08 -0700)]
Add early return on stat open without O_CREAT if file doesn't exist.
Reduces one level of indentation.
Stefan Metzmacher [Wed, 26 Oct 2011 13:47:21 +0000 (15:47 +0200)]
s3:libsmb: make use of map_nt_error_from_unix_common() in clitrans.c
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 26 17:53:15 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 26 Oct 2011 13:46:33 +0000 (15:46 +0200)]
s3:libsmb: avoid using smb_flg2 in cli_trans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:44:52 +0000 (15:44 +0200)]
s3:libsmb: replace smb_size - 4 with MIN_SMB_SIZE in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:43:08 +0000 (15:43 +0200)]
s3:libsmb: use 'tevent_' instead of 'event_' in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:41:34 +0000 (15:41 +0200)]
s3:libsmb: make use of smb_buffer_oob() in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:41:02 +0000 (15:41 +0200)]
s3:libsmb: use smb_len_nbt() in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 12:23:48 +0000 (14:23 +0200)]
s3:include: implement trans_oob() as wrapper to smb_buffer_oob()
metze
Stefan Metzmacher [Wed, 26 Oct 2011 12:20:53 +0000 (14:20 +0200)]
libcli/smb: add smb_buffer_oob() helper
A copy of trans_oob().
metze
Günther Deschner [Wed, 26 Oct 2011 09:46:36 +0000 (11:46 +0200)]
s3-netapi: remove pointless use_memory_krb5_ccache.
This breaks the ABI.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 26 13:23:58 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 26 Oct 2011 07:28:10 +0000 (09:28 +0200)]
libcli/smb: merge NEGOTIATE_SECURITY_* flags to smb_constants.h
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 26 11:27:12 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date3() is the same as pull_dos_date3()
Except for a 'void *' vs. 'uint8_t *'.
As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.
metze
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date2() is the same as pull_dos_date2()
Except for a 'void *' vs. 'uint8_t *'.
As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.
metze
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date() is the same as pull_dos_date()
Except for a 'void *' vs. 'uint8_t *'.
As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.
metze
Björn Baumbach [Wed, 19 Oct 2011 08:54:53 +0000 (10:54 +0200)]
s3-util: dbwrap_tool: fix fetch_string function
We do not want truncated strings.
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Oct 26 04:17:05 CEST 2011 on sn-devel-104
Gregor Beck [Thu, 20 Oct 2011 15:38:06 +0000 (17:38 +0200)]
s3:net registry check: fix a case where automatic and read only mode take the wrong action
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Thu, 20 Oct 2011 15:36:10 +0000 (17:36 +0200)]
s3:net registry check: do not silently replace separators
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Sun, 23 Oct 2011 20:17:03 +0000 (22:17 +0200)]
s4:torture:smb2: fix broken indentation/formatting in torture_smb2_connection()
this was not readable well
Michael Adam [Sun, 23 Oct 2011 14:57:07 +0000 (16:57 +0200)]
talloc: fix a comment typo
Jeremy Allison [Tue, 25 Oct 2011 22:31:48 +0000 (15:31 -0700)]
Second attempt to fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.
Don't just use the first entry in back_channels as a talloc context
to allocate a long-lived chan entry on - must be NULL. It's already
correctly deleted when the last reference goes away.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 26 02:42:35 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 25 Oct 2011 13:47:10 +0000 (15:47 +0200)]
s3:smb2cli_base: make use of [_]smb_[set]len_tcp()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Oct 25 19:30:43 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 25 Oct 2011 12:56:38 +0000 (14:56 +0200)]
s3:smb2cli_base: make use of map_nt_error_from_unix_common()
metze
Stefan Metzmacher [Tue, 25 Oct 2011 13:12:05 +0000 (15:12 +0200)]
s3:lib/errmap_unix: map EPIPE to NT_STATUS_CONNECTION_DISCONNECTED
This lets map_nt_error_from_unix() return the same value as
map_nt_error_from_unix_common().
There are no callers relying on NT_STATUS_PIPE_BROKEN.
metze
Stefan Metzmacher [Tue, 25 Oct 2011 12:26:17 +0000 (14:26 +0200)]
s3:libsmb: s/event_context/tevent_context/ in async_smb.[ch]
metze
Stefan Metzmacher [Tue, 25 Oct 2011 13:53:41 +0000 (15:53 +0200)]
s3:lib/addrchange.h: include libreplace headers before others
Also we typically don't use an explicit "lib/replace/" prefix.
metze
Andrew Bartlett [Tue, 25 Oct 2011 00:26:52 +0000 (11:26 +1100)]
build: always include tevent with <tevent.h>
This ensures we do the right thing if we are built against the system
tevent.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 25 Oct 2011 00:23:54 +0000 (11:23 +1100)]
build: always include talloc with <talloc.h>
This ensures we do the right thing if we are built against the system
talloc.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sun, 23 Oct 2011 23:05:19 +0000 (10:05 +1100)]
torture: Remove unused smbiconv
smbiconv is not used in any test script, and has only had changes
since being introduced by Jelmer to keep it building.
It is also not installed on the system. I have also checked with
Jelmer, who approved the removal.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Tue, 25 Oct 2011 10:38:41 +0000 (12:38 +0200)]
s3-libsmbclient: make some functions static in testsuite code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct 25 17:57:25 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 22:49:08 +0000 (00:49 +0200)]
s3:libsmb: make use of map_nt_error_from_unix_common() in async_smb.c
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Oct 25 03:21:06 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 16:13:09 +0000 (18:13 +0200)]
s3:libsmb: use HDR_* defines in cli_state_dispatch_smb1()
metze
Stefan Metzmacher [Mon, 24 Oct 2011 15:51:17 +0000 (17:51 +0200)]
s3:libsmb: make use of smb_[set]len_nbt() in async_smb.c
metze
Stefan Metzmacher [Mon, 24 Oct 2011 15:47:50 +0000 (17:47 +0200)]
s3:libsmb: use HDR_* defines in cli_pull_raw_error()
metze
Stefan Metzmacher [Mon, 24 Oct 2011 14:50:19 +0000 (16:50 +0200)]
libcli/smb: move smb_signing.[ch] to the toplevel
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:39:16 +0000 (09:39 +0200)]
s3:libsmb/smb_signing: make use of HDR_* defines
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:39:16 +0000 (09:39 +0200)]
s3:libsmb/smb_signing: make use of smb_len_nbt()
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:30:47 +0000 (09:30 +0200)]
s3:libsmb/smb_signing: avoid usage of smb_ss_field
metze
Stefan Metzmacher [Mon, 24 Oct 2011 15:12:51 +0000 (17:12 +0200)]
s4:libcli: rename smb_signing.h to smb_raw_signing.h in the install directory
metze
Stefan Metzmacher [Mon, 24 Oct 2011 22:22:50 +0000 (00:22 +0200)]
libcli/smb: remove unused includes from read_smb.h
metze
Jeremy Allison [Mon, 24 Oct 2011 19:20:46 +0000 (12:20 -0700)]
Try and fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.
Remove the copy of the binding handle from struct notify_back_channel, use
the direct pointer in struct rpc_pipe_client instead. Ensure we can't call
the functions with a NULL binding handle.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Oct 24 22:56:40 CEST 2011 on sn-devel-104
Günther Deschner [Mon, 24 Oct 2011 15:38:16 +0000 (17:38 +0200)]
s3-docs: Remove -Y option from winbind manpage.
This option no longer exists.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Oct 24 20:59:22 CEST 2011 on sn-devel-104
Simo Sorce [Fri, 21 Oct 2011 20:10:43 +0000 (16:10 -0400)]
idl: Improve MS-PAC IDL
Change some misleading variable names to reflect the actual function.
Add missing field name/types previously marked as unkown.
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Oct 24 19:19:28 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 09:39:28 +0000 (11:39 +0200)]
libcli/smb: merge LOCKING_ANDX_* and OPLOCK_* defines to smb_constants.h
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 17:46:47 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 09:19:06 +0000 (11:19 +0200)]
s4:libcli/raw: remove unuded CMD_REPLY define
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:55:57 +0000 (09:55 +0200)]
libcli/smb: move more defines to smb_constants.h
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:35:48 +0000 (09:35 +0200)]
libcli/smb: move CAP_* defines to smb_constants.h
metze
Stefan Metzmacher [Mon, 24 Oct 2011 09:07:32 +0000 (11:07 +0200)]
auth/gensec: fix missleading comment
We don't talloc_reference for tsocket_addresses.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 15:29:47 CEST 2011 on sn-devel-104
Andrew Bartlett [Mon, 24 Oct 2011 06:33:59 +0000 (17:33 +1100)]
libcli/smb Move smb_seal.h include to files that use it.
This is required because at the moment, smb_seal.h includes references to gssapi structures
and this causes issues with header dependencies on subsystems that otherwise do not need
a gssapi dependency.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 24 Oct 2011 05:57:29 +0000 (16:57 +1100)]
lib/util/charset Remove unused header smb_common.h
This should fix a compile issue on hosts without gssapi/gssapi.h.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 24 Oct 2011 06:42:10 +0000 (08:42 +0200)]
libcli/smb: move source3/libsmb/read_smb.* to the toplevel
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 10:18:06 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 06:41:15 +0000 (08:41 +0200)]
s3:libsmb/read_smb: make use of smb_len_tcp()
metze
Stefan Metzmacher [Tue, 20 Sep 2011 02:47:21 +0000 (04:47 +0200)]
s3:libsmb: remove unused sync read_smb()
metze
Stefan Metzmacher [Tue, 20 Sep 2011 02:43:05 +0000 (04:43 +0200)]
s3:torture: avoid using read_smb()
metze
Stefan Metzmacher [Sat, 22 Oct 2011 07:38:22 +0000 (09:38 +0200)]
talloc: simplifiy the logic to build talloc_testsuite in the standalone build
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Oct 22 13:15:52 CEST 2011 on sn-devel-104
Stefan Metzmacher [Fri, 21 Oct 2011 11:42:34 +0000 (13:42 +0200)]
lib/util: remove the "includes.h" dependeny from xfile.c
metze
Stefan Metzmacher [Fri, 21 Oct 2011 11:42:34 +0000 (13:42 +0200)]
lib/util: remove the "includes.h" dependeny from util_file.c
metze
Stefan Metzmacher [Fri, 21 Oct 2011 11:18:25 +0000 (13:18 +0200)]
dynconfig: replace #if (_SAMBA_BUILD_ >= 4) by feature tests
metze
Stefan Metzmacher [Fri, 21 Oct 2011 11:17:22 +0000 (13:17 +0200)]
talloc/testsuite: remove #if _SAMBA_BUILD_==3
We don't include "includes.h" anymore...
metze
Stefan Metzmacher [Fri, 21 Oct 2011 11:16:44 +0000 (13:16 +0200)]
auth/gensec: replace #if _SAMBA_BUILD_ == 4 by a feature test
metze
Jeremy Allison [Sat, 22 Oct 2011 01:35:15 +0000 (18:35 -0700)]
Third part of fix for bug #8541 - readlink() on Linux clients fails if the symlink target is outside of the share.
Missed passing ucf_flags instead of hard coded flags in findfirst call.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 22 06:30:16 CEST 2011 on sn-devel-104
Jeremy Allison [Sat, 22 Oct 2011 00:46:12 +0000 (17:46 -0700)]
Second part of fix for bug #8541 - readlink() on Linux clients fails if the symlink target is outside of the share.
The statcache has to do lstat instead of stat when returning cached
posix pathnames.
Stefan Metzmacher [Sat, 22 Oct 2011 01:09:59 +0000 (03:09 +0200)]
s4:finddcs_cldap: talloc free old memory before allocating a new netlogon struct
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Oct 22 04:55:54 CEST 2011 on sn-devel-104
Stefan Metzmacher [Sat, 22 Oct 2011 01:09:59 +0000 (03:09 +0200)]
s4:finddcs_cldap: close the socket when it's not used anymore
The amount of possible fd's might be restricted, so close them early.
metze
Stefan Metzmacher [Sat, 22 Oct 2011 01:09:59 +0000 (03:09 +0200)]
s4:finddcs_cldap: finddcs_cldap_recv() returns NTSTATUS
We need to convert the errno based error to NTSTATUS
before calling tevent_req_error (via tevent_req_nterror).
metze
Jeremy Allison [Fri, 21 Oct 2011 21:12:41 +0000 (14:12 -0700)]
Fix bug #8541 - readlink() on Linux clients fails if the symlink target is outside of the share.
The key is to only allow the lookup to succeed if it's a UNIX level lookup or readlink,
but disallow all other operations.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 22 01:37:41 CEST 2011 on sn-devel-104
Matthieu Patou [Fri, 21 Oct 2011 18:09:37 +0000 (20:09 +0200)]
s4-cldap: fix cldap_socket_init to always specify the dest if local is NULL
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat Oct 22 00:02:00 CEST 2011 on sn-devel-104
Matthieu Patou [Fri, 21 Oct 2011 14:11:41 +0000 (16:11 +0200)]
libcli-cldap: avoid the case local == remote == NULL
Stefan Metzmacher [Fri, 21 Oct 2011 07:49:30 +0000 (09:49 +0200)]
libcli/cldap: make sure the local and remote address family matches
metze
Signed-off-by: Matthieu Patou <mat@matws.net>
Matthieu Patou [Fri, 21 Oct 2011 14:05:53 +0000 (16:05 +0200)]
s4-resolv: fix resolution of SRV records pointing to A and AAAA records
Jeremy Allison [Fri, 21 Oct 2011 18:19:39 +0000 (11:19 -0700)]
Deprecate "acl check permissions".
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 21 21:51:18 CEST 2011 on sn-devel-104
Christian Ambach [Thu, 20 Oct 2011 16:53:02 +0000 (18:53 +0200)]
s3:idmap_autorid: document allocation pool
document the need that excessive use of local users/group might
require increasing the rangesize
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Oct 21 18:04:50 CEST 2011 on sn-devel-104
Christian Ambach [Thu, 20 Oct 2011 16:44:48 +0000 (18:44 +0200)]
s3:idmap_autorid: add an allocation range to autorid
this is needed to allocate gids for BUILTIN\Users and
BUILTIN\Administrators and for local users/group that
admins might want to create
autorid will now allocate one range for this purpose
and can so give out as many uids and gids as the
configured rangesize allows
Christian Ambach [Thu, 20 Oct 2011 16:39:30 +0000 (18:39 +0200)]
s3:idmap_autorid: move HWM initialization into a function
we will need some more HWM soon, so move out initialization and
optimize the logic using the new interface of dbwrap_fetch_uint32
Christian Ambach [Thu, 20 Oct 2011 16:22:19 +0000 (18:22 +0200)]
s3:idmap_autorid: use strings as parameter for range allocator
this prepares for allocation of non-domain ranges that cannot be
expressed by a SID (e.g. an allocation pool)
Christian Ambach [Thu, 20 Oct 2011 15:59:32 +0000 (17:59 +0200)]
s3:winbindd/idmap make idmap modules loadable again
commit
355b5e3a831415d9bef97 changed the module system to
expect 'samba_init_module' as fixed initializer function
Christian Ambach [Wed, 19 Oct 2011 14:14:06 +0000 (16:14 +0200)]
Revert "s3:idmap/autorid add a small alloc pool to autorid"
This reverts commit
0aa558718ad7427ee8b02046da73eea1838a5a32.
just having 500 uid/gids values is not good enough for
users using local users and groups in the order of thousands
better solution which will use a complete range for allocated
uids/gids will come next.
Günther Deschner [Fri, 21 Oct 2011 12:15:54 +0000 (14:15 +0200)]
libcli: remove unneeded com_err.h and fix the build here.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct 21 15:52:36 CEST 2011 on sn-devel-104
Günther Deschner [Fri, 21 Oct 2011 09:31:57 +0000 (11:31 +0200)]
s3-waf: only compile common.c in netapi examples code once.
Guenther
Günther Deschner [Fri, 21 Oct 2011 09:06:14 +0000 (11:06 +0200)]
s3-netapi: use NetApiBufferAllocate() for returned buffer in getdc calls.
Guenther
Günther Deschner [Fri, 21 Oct 2011 09:05:37 +0000 (11:05 +0200)]
s3-netapi: fix missing include in examples code.
Guenther
Stefan Metzmacher [Wed, 19 Oct 2011 11:47:39 +0000 (13:47 +0200)]
libcli/smb: move smb_seal.c to the toplevel
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Oct 21 10:22:39 CEST 2011 on sn-devel-104
Andrew Bartlett [Wed, 19 Oct 2011 07:39:27 +0000 (18:39 +1100)]
s3-ntlmssp Remove references to auth_ntlmssp_context from the rpc code
We always dereferenced auth_ntlmssp_state->gensec_security, so now we
do not bother passing around the whole auth_ntlmssp_state.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 19 Oct 2011 05:33:04 +0000 (16:33 +1100)]
s3-seal Remove struct smb_srv_trans_enc_ctx
This structure added no value, particularly after the move to gensec.
It was added at a time when auth_ntlmssp_state was not available in
the client. This changed a while back (the wrapper was extended with
client calls), and the move to gensec again reinforced that we do not
need the extra complexity.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 19 Oct 2011 04:57:18 +0000 (15:57 +1100)]
s3-ntlmssp Remove references to auth_ntlmssp_context from the smb sealing code
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 18 Oct 2011 10:55:24 +0000 (21:55 +1100)]
s3-ntlmssp Remove auth_ntlmssp_session_key()
We now just call the gensec_session_key() directly.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 18 Oct 2011 10:43:40 +0000 (21:43 +1100)]
s3-ntlmssp Remove auth_ntlmssp_want_feature()
We now just call the gensec_want_feature() directly.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 20 Oct 2011 09:53:40 +0000 (11:53 +0200)]
s3-seal use gensec_[un]wrap() instead of gensec_[un]seal_packet()
This should not make a difference for NTLMSSP as it still calls the
low level ntlmssp_[un]seal_packet() functions with the same input parameters.
If we convert the gss-api/krb5 based code to gensec we have to use
gensec_[un]wrap() as the wire format is different compared to
gensec_[un]seal_packet() there.
Andrew Bartlett
Split from another commit by Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 18 Oct 2011 10:27:39 +0000 (21:27 +1100)]
s3-ntlmssp use gensec_{seal,unseal,sign,check}_packet
This avoids the indirection via the auth_ntlmsssp wrapper functions.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 18 Oct 2011 10:20:01 +0000 (21:20 +1100)]
s3-ntlmssp Remove auth_ntlmssp_negotiated_sign() and auth_ntlmssp_negotiated_seal()
We now just call the gensec_have_feature() directly.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 18 Oct 2011 10:13:16 +0000 (21:13 +1100)]
s3-ntlmssp Remove auth_ntlmssp_update wrapper
We now just call gensec_update directly.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 18 Oct 2011 09:58:47 +0000 (20:58 +1100)]
s3-auth remove auth_ntlmssp_session_info()
Instead, call gensec_session_info() directly.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 20 Oct 2011 14:40:14 +0000 (16:40 +0200)]
s3:smbd/seal: pass talloc_tos() auth_ntlmssp_update(), because we free a few lines later
metze
Stefan Metzmacher [Thu, 20 Oct 2011 11:46:05 +0000 (13:46 +0200)]
s3:libsmb/smb_seal: always use SAFE_FREE(buf) in common_free_enc_buffer()
There's no need to do gss-api specific stuff, the buffer is always
malloc'ed.
metze
Stefan Metzmacher [Thu, 20 Oct 2011 11:44:14 +0000 (13:44 +0200)]
s3:libsmb/smb_seal: use plain malloc() in common_ntlm_encrypt_buffer()
metze
Stefan Metzmacher [Thu, 20 Oct 2011 11:23:27 +0000 (13:23 +0200)]
s3:libsmb/smb_seal: avoid ads_errstr() dependency and use gssapi_error_string()
metze
Stefan Metzmacher [Thu, 20 Oct 2011 07:47:53 +0000 (09:47 +0200)]
s3:libsmb/smb_seal: make use of common [_]smb_[set]len_nbt() macros
metze
Stefan Metzmacher [Thu, 20 Oct 2011 07:44:02 +0000 (09:44 +0200)]
s3:include: make smb_setlen() a macro
metze