Michael Adam [Wed, 22 Jul 2015 17:08:15 +0000 (19:08 +0200)]
param: rename szCopy -> copy
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Wed, 22 Jul 2015 17:06:39 +0000 (19:06 +0200)]
param: rename bAvailable -> available
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 12 May 2015 11:41:44 +0000 (13:41 +0200)]
param: make 'realm' use the standard 'realm' variable.
This way, the generated lp_realm() function matches the param_table.
realm_original is only treated in the special handler now.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Wed, 22 Jul 2015 14:22:40 +0000 (16:22 +0200)]
param: turn 'cups encrypt' into a generated function
Move the special stuff of the hand-written lp_cups_encrypt()
function into a handler that is called once at load time.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Wed, 22 Jul 2015 14:21:35 +0000 (16:21 +0200)]
param: rename CupsEncrypt -> cups_encrypt
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 21:49:45 +0000 (23:49 +0200)]
param: make 'winbind max domain connections' a generated function.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 21:42:09 +0000 (23:42 +0200)]
param: rename winbindMaxDomainConnections -> _winbind_max_domain_connections
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 13:28:33 +0000 (15:28 +0200)]
param: turn 'wide links' into a generated funcion
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 13:22:30 +0000 (15:22 +0200)]
param: rename bWidelinks -> wide_links
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 13:18:01 +0000 (15:18 +0200)]
param: turn 'smb2 max credits' into generated option
This is achieved by moving the special treatment from
the lp_smb2_max_credits() function in the the special
handler that is called only once upon lp_load().
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 12:49:16 +0000 (14:49 +0200)]
param: treat negative values of 'smb2 max credits' as default.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 12:34:11 +0000 (14:34 +0200)]
param: turn 'printcap name' into a generated function
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 12:31:43 +0000 (14:31 +0200)]
param: rename szPrintcapName -> printcap_name
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 12:23:47 +0000 (14:23 +0200)]
param: turn 'min receivefile size' into a generated function
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 12:21:26 +0000 (14:21 +0200)]
param: rename iminreceivefile -> min_receivefile_size
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 12:09:35 +0000 (14:09 +0200)]
param: turn 'preferred master' into a generated function
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 12:07:25 +0000 (14:07 +0200)]
param: rename iPreferredMaster -> _preferred_master
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 10:29:54 +0000 (12:29 +0200)]
param: use lp[cfg]_max_print_jobs() in lp[cfg]_maxprintjobs()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 10:22:02 +0000 (12:22 +0200)]
param: generate lp[cfg]_max_print_jobs()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 10:00:18 +0000 (12:00 +0200)]
param: rename variable of 'max print jobs' to default.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 15 Jun 2015 22:15:23 +0000 (00:15 +0200)]
param: turn ldap idmap suffix into a generated function
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 15 Jun 2015 22:12:51 +0000 (00:12 +0200)]
param: rename szLdapMachineSuffix -> _ldap_machine_suffix
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 15 Jun 2015 22:06:59 +0000 (00:06 +0200)]
param: turn ldap idmap suffix into a generated function
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 15 Jun 2015 22:04:53 +0000 (00:04 +0200)]
param: rename szLdapIdmapSuffix -> _ldap_sz_idmap_suffix
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 15 Jun 2015 22:00:44 +0000 (00:00 +0200)]
param: turn ldap user suffix into a generated function
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 15 Jun 2015 21:58:35 +0000 (23:58 +0200)]
param: rename szLdapUserSuffix -> _ldap_user_suffix
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 15 Jun 2015 21:47:37 +0000 (23:47 +0200)]
param: turn ldap group suffix into a generated function
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 15 Jun 2015 21:45:45 +0000 (23:45 +0200)]
param: rename szLdapGroupSuffix -> _ldap_group_suffix
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 28 Apr 2015 09:46:21 +0000 (11:46 +0200)]
docs:smbdotconf: add enumlist property to parameters where missing
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 07:43:23 +0000 (09:43 +0200)]
docs:smbdotconf: add param flag 'enumlist' to the DTD
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 12 May 2015 08:07:10 +0000 (10:07 +0200)]
docs:smbdotconf: add handler info to smbdotconf docs where missing
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 12 May 2015 10:24:46 +0000 (12:24 +0200)]
docs:smbdotconf: add param flags 'handler' and 'deprecated' to the DTD
These are already used in the docs.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 28 Apr 2015 23:33:03 +0000 (01:33 +0200)]
docs:smbdotconf: add param flag 'synonym' to the DTD
It is already used in the param_table.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Wed, 20 May 2015 08:44:17 +0000 (10:44 +0200)]
docs:smbdotconf: fix type to bool-rev for reverse synonyms.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Wed, 22 Jul 2015 08:31:46 +0000 (10:31 +0200)]
tests: teach the docs test about boolean-rev
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Thu, 14 May 2015 14:31:52 +0000 (16:31 +0200)]
docs:smbdotconf: fix context of 'include' in doc
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Wed, 13 May 2015 09:49:39 +0000 (11:49 +0200)]
docs:smbdotconf: fix type of "preferred master" parameter.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Thu, 30 Apr 2015 21:32:45 +0000 (23:32 +0200)]
docs:smbdotconf: make formatting of headers uniform.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 07:10:34 +0000 (09:10 +0200)]
s3:lib: remove unused dummyparam.c
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Wed, 8 Jul 2015 16:23:28 +0000 (18:23 +0200)]
param: accompany FN_LOCAL_PARM_CHAR with FN_LOCAL_CHAR
just like with the other FN_LOCAL_PARM macros.
FN_LOCAL_CHAR is the main definition.
This is also in preparation of a possible future
removal of the _PARM variants (when snum is no
longer used...).
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Tue, 21 Jul 2015 06:23:21 +0000 (08:23 +0200)]
param: make set_variable() static.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 22:17:51 +0000 (00:17 +0200)]
lib/dcom: use HRESULT in dcom_create_object.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 21:37:07 +0000 (23:37 +0200)]
s4-torture: fix ResolveOxid2 test, filling in missing ref,out pointers.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 21:36:26 +0000 (23:36 +0200)]
s4-torture: fix ResolveOxid test, filling in missing ref,out pointers.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 20:28:32 +0000 (22:28 +0200)]
remact: use imp_levels enum in RemoteActivation IDL.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 20:23:22 +0000 (22:23 +0200)]
remact: use HRESULT in RemoteActivation IDL and tests.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 20:21:46 +0000 (22:21 +0200)]
lib/torture: add torture_assert_hresult_{equal,ok} macros.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 19:32:53 +0000 (21:32 +0200)]
s4-torture: fix remact test from crashing.
RemoteActivation was missing all out,ref pointers.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 20:38:25 +0000 (22:38 +0200)]
s4-torture: fix test for RemoteActivation.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 20:37:34 +0000 (22:37 +0200)]
remact: fix IDL for RemoteActivation.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:35:14 +0000 (20:35 +0200)]
s4-torture: use torture_assert macros for RemoteActivation test.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:23:11 +0000 (20:23 +0200)]
oxidresolver: fix ServerAlive2 IDL and test.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 22:07:22 +0000 (00:07 +0200)]
rot: fix indent in rot.idl
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 22:06:00 +0000 (00:06 +0200)]
rot: remove trailing whitespace from rot.idl
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 19:07:25 +0000 (21:07 +0200)]
s4-torture: fix indent of remact test.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:54:17 +0000 (20:54 +0200)]
remact: fix indent of remact.idl
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:53:24 +0000 (20:53 +0200)]
oxidresolver: fix indent in oxidresolver.idl
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:49:22 +0000 (20:49 +0200)]
dcom: fix ident in dcom.idl.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:34:40 +0000 (20:34 +0200)]
oxidresolver: fix indent of ResolveOxid2 in IDL.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:41:34 +0000 (20:41 +0200)]
s4-torture: remove trailing whitespace from remact test.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:41:12 +0000 (20:41 +0200)]
s4-torture: remove trailing whitespace from oxidresolve test.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:40:30 +0000 (20:40 +0200)]
remact: remove trailing whitespace from remact.idl
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:40:07 +0000 (20:40 +0200)]
oxidresolver: remove trailing whitespace from oxidresolver.idl
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:39:40 +0000 (20:39 +0200)]
orpc: remove trailing whitespace from orpc.idl
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Tue, 21 Jul 2015 18:39:15 +0000 (20:39 +0200)]
dcom: remove trailing whitespace from dcom.idl
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Douglas Bagnall [Thu, 9 Jul 2015 02:17:50 +0000 (14:17 +1200)]
source3 torture: don't segfault if filename query fails
If the query return status is not OK, the query answer pointer could
be uninitialised.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Michael Adam [Wed, 29 Jul 2015 14:16:29 +0000 (16:16 +0200)]
smbXsrv_session:idl: remove the preauth and gensec members
They are now taken from the pending_auth member (smbXsrv_session_auth0).
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Jul 31 01:03:13 CEST 2015 on sn-devel-104
Michael Adam [Thu, 30 Jul 2015 11:23:45 +0000 (13:23 +0200)]
s3:sesssetup: use session->pending_auth in smb1 session setup
(instead of session->gensec)
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 29 Jul 2015 14:48:55 +0000 (16:48 +0200)]
s3:smb2_sesssetup: use session->pending_auth
Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 29 Jul 2015 13:48:05 +0000 (15:48 +0200)]
smbXsrv_session: add smbXsrv_session_create_auth()
Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 29 Jul 2015 13:47:09 +0000 (15:47 +0200)]
smbXsrv_session: add smbXsrv_session_find_auth()
Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 25 Jun 2014 11:30:59 +0000 (13:30 +0200)]
smbXsrv_session:idl: add smbXsrv_session_auth0
This contains various auth related items for a session,
in particular preauth. This is in preparation to take
the direct member preauth from smbXsrv_session and have
all session auth code operate on session->pending_auth
instead of session->preauth and friends.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Brad Hards [Thu, 30 Jul 2015 01:34:33 +0000 (11:34 +1000)]
lib/param: move function typedef to after forward declaration of struct loadparm_context
Avoids a warning about the structure being declared inside the parameter list.
Signed-off-by: Brad Hards <bradh@frogmouth.net>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Jul 30 19:25:12 CEST 2015 on sn-devel-104
Michael Adam [Wed, 29 Jul 2015 16:23:31 +0000 (18:23 +0200)]
s3:smb2_sesssetup: remove now unneeded declaration of smb2srv_session_lookup_raw
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Thu, 8 May 2014 15:13:04 +0000 (17:13 +0200)]
s4-kdc: Use sdb in db-glue and hdb-samba4
Guenther
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jul 30 13:29:27 CEST 2015 on sn-devel-104
Günther Deschner [Thu, 8 May 2014 15:09:08 +0000 (17:09 +0200)]
s4-kdc: Introduce a simple sdb_hdb shim layer
Guenther
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Günther Deschner [Wed, 7 May 2014 14:52:42 +0000 (16:52 +0200)]
s4-kdc: Introduce sdb a KDC backend abstraction
Guenther
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Günther Deschner [Mon, 12 May 2014 08:40:24 +0000 (10:40 +0200)]
s4-kdc: PAC_GLUE does not depend on hdb anymore.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Andreas Schneider [Tue, 3 Feb 2015 12:00:34 +0000 (13:00 +0100)]
krb5-wrap: Use the principal returned by the KDC to create the ccache
We request a TGT in uppercase from the KDC. We turned on
canonicalization for that so the KDC returns the principal in lowercase
cause of this. As we use the uppercase prinicpal to create the ccache we
fail to find the tickets we need later because it is stored in the
incorrect case. You have to use the princial returned by the KDC here.
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Günther Deschner [Fri, 1 Aug 2014 11:11:41 +0000 (13:11 +0200)]
s4-auth: Call krb5_get_init_creds_opt_set_canonicalize() in MIT case.
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Andreas Schneider [Tue, 5 May 2015 14:53:24 +0000 (16:53 +0200)]
s3-auth: Add MIT return code for KDC not reachable
This fixes authentication with local credentials against its own server
using netbios domain name.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Andreas Schneider [Fri, 24 Jul 2015 15:48:08 +0000 (17:48 +0200)]
s4-kdc: Use smb_krb5_principal_get_(type|realm) in db-glue
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Jeremy Allison [Tue, 28 Jul 2015 18:28:20 +0000 (11:28 -0700)]
tests: Add regression test for s3-passdb: Respect LOOKUP_NAME_GROUP flag in sid lookup.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11320
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jul 30 00:36:14 CEST 2015 on sn-devel-104
Michael Adam [Mon, 27 Jul 2015 07:01:55 +0000 (09:01 +0200)]
s3:smb2_server: defer channel/session validation to the session setup code.
For session bind, and the channel is only to be bound to the given
session just now, so it is not valid. The early request validation
code can hence not check it, and hence validation is defered to the
actual session setup code, which can look at the session binding flags.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Jul 29 21:31:09 CEST 2015 on sn-devel-104
Michael Adam [Wed, 29 Jul 2015 09:19:55 +0000 (11:19 +0200)]
s3:smb2_sesssetup: check that the connection belongs to the session in sess.setup
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 29 Jul 2015 08:35:08 +0000 (10:35 +0200)]
smbXsrv: use smb2srv_session_lookup_client in smbXsrv_session_close_loop
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Mon, 27 Jul 2015 06:59:57 +0000 (08:59 +0200)]
smbXsrv: add smb2srv_session_lookup_client().
This is a variant of smb2srv_session_lookup_conn() that does
not verify the session on the channel.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 29 Jul 2015 08:23:14 +0000 (10:23 +0200)]
smbXsrv: rename smb2srv_session_lookup -> smb2srv_session_lookup_conn
This is in preparation of adding a variant that operates
on the client and does in particular not verify that the
connection belongs to a session as a channel.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Fri, 8 May 2015 21:15:51 +0000 (23:15 +0200)]
smbXsrv: add a smbXsrv_connection argument to smb2srv_session_lookup_raw
This way, we can verify that the session is valid on a channel.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Fri, 8 May 2015 21:12:19 +0000 (23:12 +0200)]
smbXsrv: add a smbXsrv_connection argument to smbXsrv_session_local_lookup()
This way, we can verify that a session is valid on the channel.
Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Baumbach [Mon, 27 Jul 2015 13:15:07 +0000 (15:15 +0200)]
build: fix build with gpfs support - add missing dependency to samba-debug
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Jul 29 13:38:59 CEST 2015 on sn-devel-104
Björn Baumbach [Mon, 27 Jul 2015 10:14:37 +0000 (12:14 +0200)]
configure: add --with-gpfs option for selecting directory with gpfs headers
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Björn Baumbach [Mon, 27 Jul 2015 11:20:43 +0000 (13:20 +0200)]
s3:wscript: fix indentation
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Martin Schwenke [Fri, 24 Jul 2015 05:32:42 +0000 (15:32 +1000)]
ctdb-daemon: Check if updates are in flight when releasing all IPs
Some code involved in releasing IPs is not re-entrant. Memory
corruption can occur if, for example, overlapping attempts are made to
ban a node. We haven't been able to recreate the corruption but this
should protect against it.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Amitay Isaacs [Mon, 27 Jul 2015 06:51:08 +0000 (16:51 +1000)]
ctdb-banning: If node is already banned, do not run ctdb_local_node_got_banned()
This calls release_all_ips() only once on the first ban. If the node gets
banned again due to event script timeout while running release_all_ips(),
then avoid calling release_all_ips() in re-entrant fashion.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Amitay Isaacs [Thu, 23 Jul 2015 21:39:26 +0000 (07:39 +1000)]
ctdb-client: Return the correct status sent from the daemon
If a control fails and error message is set, the returned status of the
control is always set to -1 ignoring the status passed by the daemon.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Jeremy Allison [Wed, 15 Jul 2015 17:43:56 +0000 (10:43 -0700)]
lib: replace: Add strsep function (missing on Solaris).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11359
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@wakeful.net>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 29 02:24:55 CEST 2015 on sn-devel-104
Justin Maggard [Tue, 21 Jul 2015 22:17:30 +0000 (15:17 -0700)]
s3-passdb: Respect LOOKUP_NAME_GROUP flag in sid lookup.
Somewhere along the line, a config line like "valid users = @foo"
broke when "foo" also exists as a user.
user_ok_token() already does the right thing by adding the LOOKUP_NAME_GROUP
flag; but lookup_name() was not respecting that flag, and went ahead and looked
for users anyway.
Regression test to follow.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11320
Signed-off-by: Justin Maggard <jmaggard@netgear.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Marc Muehlfeld <mmuehlfeld@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jul 28 21:35:58 CEST 2015 on sn-devel-104
Günther Deschner [Wed, 22 Jul 2015 16:57:57 +0000 (18:57 +0200)]
pidl: merge multiple 'genpad' implementations into one.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Jul 24 16:44:16 CEST 2015 on sn-devel-104
Günther Deschner [Wed, 22 Jul 2015 12:52:06 +0000 (14:52 +0200)]
vfs: fix build warning in smb traffic analyzer.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>