mat/samba.git
13 years agos3:libsmb: the smb2 server capabilities from the session setup are 32-bit
Stefan Metzmacher [Tue, 13 Sep 2011 11:48:03 +0000 (13:48 +0200)]
s3:libsmb: the smb2 server capabilities from the session setup are 32-bit

metze

13 years agoldb:pyldb.c - "py_ldb_rename" remove superflous "ldb" pointer
Matthias Dieter Wallnöfer [Tue, 13 Sep 2011 13:01:51 +0000 (15:01 +0200)]
ldb:pyldb.c - "py_ldb_rename" remove superflous "ldb" pointer

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Sep 13 18:11:18 CEST 2011 on sn-devel-104

13 years agos4-s3-upgrade Improve samba-tool domain samba3upgrade behaviour
Andrew Bartlett [Tue, 13 Sep 2011 11:02:43 +0000 (21:02 +1000)]
s4-s3-upgrade Improve samba-tool domain samba3upgrade behaviour

The --realm argument is again optional (the previous code would take the default
from the default smb.conf, not the one specified) and --targetdir is now a
named argument much like it is to provision.

We now test the --testparm option to ensure it behaves the way we expect.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Sep 13 16:30:31 CEST 2011 on sn-devel-104

13 years agos4:upgrade_from_s3 - restore "get_testparm_var" method
Matthias Dieter Wallnöfer [Mon, 12 Sep 2011 18:57:10 +0000 (20:57 +0200)]
s4:upgrade_from_s3 - restore "get_testparm_var" method

This has accidentally been removed by commit 8268c2d4e231b05b439bc70331b75342b35daa4e.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos3:torture: use CLI_BUFFER_SIZE instead of cli->max_xmit
Stefan Metzmacher [Tue, 13 Sep 2011 11:12:09 +0000 (13:12 +0200)]
s3:torture: use CLI_BUFFER_SIZE instead of cli->max_xmit

The max_data parameter of trans2/nttrans calls are not bound
to cli->max_xmit. Even with cli->max_xmit, which means the max
size of the whole SMB pdu, we would get fragmented trans2/nttrans
replies. That's why we can also use our maximum, which is CLI_BUFFER_SIZE.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Sep 13 14:52:35 CEST 2011 on sn-devel-104

13 years agos3:libsmb: make use of cli_state_available_size() in cli_smbwrite()
Stefan Metzmacher [Tue, 13 Sep 2011 11:10:33 +0000 (13:10 +0200)]
s3:libsmb: make use of cli_state_available_size() in cli_smbwrite()

metze

13 years agos3:libsmb: make use of cli_state_available_size() in cli_write_max_bufsize()
Stefan Metzmacher [Tue, 13 Sep 2011 09:39:07 +0000 (11:39 +0200)]
s3:libsmb: make use of cli_state_available_size() in cli_write_max_bufsize()

metze

13 years agos3:libsmb: make use of cli_state_available_size() in cli_read_max_bufsize()
Stefan Metzmacher [Tue, 13 Sep 2011 09:38:21 +0000 (11:38 +0200)]
s3:libsmb: make use of cli_state_available_size() in cli_read_max_bufsize()

metze

13 years agos3:libsmb: make use of cli_state_available_size() in cli_list_old_send()
Stefan Metzmacher [Tue, 13 Sep 2011 09:37:20 +0000 (11:37 +0200)]
s3:libsmb: make use of cli_state_available_size() in cli_list_old_send()

metze

13 years agos3:libsmb: make use of cli_state_available_size() in cli_sesssetup_blob_send()
Stefan Metzmacher [Tue, 13 Sep 2011 09:35:53 +0000 (11:35 +0200)]
s3:libsmb: make use of cli_state_available_size() in cli_sesssetup_blob_send()

metze

13 years agos3:libsmb: make use of cli_state_available_size() in cli_trans_format()
Stefan Metzmacher [Tue, 13 Sep 2011 09:34:33 +0000 (11:34 +0200)]
s3:libsmb: make use of cli_state_available_size() in cli_trans_format()

metze

13 years agos3:libsmb: add cli_state_available_size()
Stefan Metzmacher [Tue, 13 Sep 2011 09:23:49 +0000 (11:23 +0200)]
s3:libsmb: add cli_state_available_size()

metze

13 years agos3:clitar: remove unused/not existing extern variables
Stefan Metzmacher [Tue, 13 Sep 2011 06:44:17 +0000 (08:44 +0200)]
s3:clitar: remove unused/not existing extern variables

metze

13 years agos3: Fix Coverity ID 2613 -- UNINIT
Volker Lendecke [Tue, 13 Sep 2011 08:47:15 +0000 (10:47 +0200)]
s3: Fix Coverity ID 2613 -- UNINIT

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Sep 13 12:39:10 CEST 2011 on sn-devel-104

13 years agos3: Fix Coverity ID 2614 -- UNINIT
Volker Lendecke [Tue, 13 Sep 2011 08:46:32 +0000 (10:46 +0200)]
s3: Fix Coverity ID 2614 -- UNINIT

13 years agos3: Make saf_join_key() use talloc
Volker Lendecke [Mon, 12 Sep 2011 19:11:57 +0000 (21:11 +0200)]
s3: Make saf_join_key() use talloc

13 years agos3: Make saf_key() use talloc
Volker Lendecke [Mon, 12 Sep 2011 19:07:16 +0000 (21:07 +0200)]
s3: Make saf_key() use talloc

13 years agos3: Disentangle resolve_name() a bit
Volker Lendecke [Mon, 12 Sep 2011 18:56:13 +0000 (20:56 +0200)]
s3: Disentangle resolve_name() a bit

13 years agos3: Remove a reference to smbd_server_conn
Volker Lendecke [Mon, 12 Sep 2011 15:33:26 +0000 (17:33 +0200)]
s3: Remove a reference to smbd_server_conn

13 years agos3: Remove a reference to smbd_server_conn
Volker Lendecke [Mon, 12 Sep 2011 15:32:39 +0000 (17:32 +0200)]
s3: Remove a reference to smbd_server_conn

13 years agos3: Remove a reference to smbd_server_conn
Volker Lendecke [Mon, 12 Sep 2011 15:30:51 +0000 (17:30 +0200)]
s3: Remove a reference to smbd_server_conn

13 years agos3: Remove a reference to smbd_server_conn
Volker Lendecke [Mon, 12 Sep 2011 15:30:40 +0000 (17:30 +0200)]
s3: Remove a reference to smbd_server_conn

13 years agos3: Remove a reference to smbd_server_conn
Volker Lendecke [Mon, 12 Sep 2011 15:23:07 +0000 (17:23 +0200)]
s3: Remove a reference to smbd_server_conn

13 years agos3: Fix some nonempty blank lines
Volker Lendecke [Mon, 12 Sep 2011 15:19:27 +0000 (17:19 +0200)]
s3: Fix some nonempty blank lines

13 years agos3-selftest use a more portable shell syntax
Andrew Bartlett [Tue, 13 Sep 2011 05:19:46 +0000 (15:19 +1000)]
s3-selftest use a more portable shell syntax

"$10" evaulates to $1 and 0, not the 10th argument.

Thanks to Amitay for pointing this out!

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Sep 13 09:34:49 CEST 2011 on sn-devel-104

13 years agoscript/librelease.sh: automate Samba4 alpha releases
Andrew Bartlett [Tue, 13 Sep 2011 05:18:52 +0000 (15:18 +1000)]
script/librelease.sh: automate Samba4 alpha releases

13 years agos4-subdomain: match windows form for trustAuthInOutBlob
Andrew Tridgell [Wed, 7 Sep 2011 07:22:49 +0000 (17:22 +1000)]
s4-subdomain: match windows form for trustAuthInOutBlob

Windows does not put a version element in the array

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-subdomain: fixed domain guid choice for subdomain join
Andrew Tridgell [Wed, 7 Sep 2011 07:21:07 +0000 (17:21 +1000)]
s4-subdomain: fixed domain guid choice for subdomain join

We need to use the domain GUID that the server choose in the ncName
link

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-subdomain: don't delete account DN not created in subdomain join
Andrew Tridgell [Mon, 5 Sep 2011 07:23:48 +0000 (17:23 +1000)]
s4-subdomain: don't delete account DN not created in subdomain join

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-subdomain: use a password length of 128
Andrew Tridgell [Mon, 5 Sep 2011 06:45:28 +0000 (16:45 +1000)]
s4-subdomain: use a password length of 128

windows seems to use a fixed size for this password. It is possible
that windows servers can only handle one size, given we have observed
some strange behaviour from the windows kdc when we setup trusts

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-join: fixed non-subdomain join
Andrew Tridgell [Mon, 5 Sep 2011 06:43:26 +0000 (16:43 +1000)]
s4-join: fixed non-subdomain join

these two vars need to be initialised for general join

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-subdomain: fixed invocationID and hostIPs in subdomain join
Andrew Tridgell [Fri, 2 Sep 2011 05:12:11 +0000 (15:12 +1000)]
s4-subdomain: fixed invocationID and hostIPs in subdomain join

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-subdomain more work on sub-domain join
Andrew Bartlett [Fri, 26 Aug 2011 03:23:41 +0000 (13:23 +1000)]
s4-subdomain more work on sub-domain join

we can now create a subdomain of an existing windows domain using:

  samba-tool domain join sub.domain.dns.name subdomain

The ordering of the creation of the key records is quite tricky,
especially for the NTDSDSA object

Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>

13 years agos4: add createtrust tool for testing
Andrew Bartlett [Fri, 2 Sep 2011 00:35:46 +0000 (10:35 +1000)]
s4: add createtrust tool for testing

13 years agoselftest: add test for subdomain support
Andrew Bartlett [Thu, 25 Aug 2011 11:47:03 +0000 (21:47 +1000)]
selftest: add test for subdomain support

13 years agos4-join Add a partitions DN when we join a subdomain
Andrew Bartlett [Fri, 26 Aug 2011 06:07:05 +0000 (16:07 +1000)]
s4-join Add a partitions DN when we join a subdomain

13 years agos4-provision Perform 'modify' operations as system
Andrew Bartlett [Thu, 25 Aug 2011 09:15:13 +0000 (19:15 +1000)]
s4-provision Perform 'modify' operations as system

We need this so that we can modify the cn=configuration partition when
we are setting up a new subdomain.

The serverReference on our ${SERVERDN} is in that partition, and
without this change creating a new subdomain fails due to ACLs.

Andrew Bartlett

13 years agos4-join supply the NTDS GUID to the provision
Andrew Bartlett [Thu, 25 Aug 2011 09:13:34 +0000 (19:13 +1000)]
s4-join supply the NTDS GUID to the provision

Unlike other join operations, the creation of a subdomain makes local
changes to the DB, so we need to pass in the NTDS GUID to ensure the
one set on the object created in the parent domain is the one that is
used.

Andrew Bartlett

13 years agos4-provision Split addition of users and well known principals
Andrew Bartlett [Thu, 25 Aug 2011 03:18:43 +0000 (13:18 +1000)]
s4-provision Split addition of users and well known principals

If we are provisioning a subdomain, then these are already in
cn=configuration.

Andrew Bartlett

13 years agos4-provision Add initial support for joining as a new subdomain
Andrew Bartlett [Wed, 24 Aug 2011 05:39:51 +0000 (15:39 +1000)]
s4-provision Add initial support for joining as a new subdomain

To do this we need to reorganise a lot of the provision code, so that
we can create the framework for the inbound replicaton of the config
and schema partitions and then add in the new subdomain locally.

Andrew Bartlett

13 years agostart work on Samba 4.0 alpha18
Andrew Bartlett [Tue, 13 Sep 2011 01:39:09 +0000 (11:39 +1000)]
start work on Samba 4.0 alpha18

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Sep 13 05:44:47 CEST 2011 on sn-devel-104

13 years agoRelease Samba 4.0 alpha17
Andrew Bartlett [Tue, 13 Sep 2011 01:38:30 +0000 (11:38 +1000)]
Release Samba 4.0 alpha17

13 years agoWHATSNEW: more information on running dbcheck
Andrew Tridgell [Tue, 13 Sep 2011 02:05:00 +0000 (12:05 +1000)]
WHATSNEW: more information on running dbcheck

13 years agos4-python: Fix some formatting issues.
Jelmer Vernooij [Mon, 12 Sep 2011 23:27:50 +0000 (01:27 +0200)]
s4-python: Fix some formatting issues.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Sep 13 03:51:13 CEST 2011 on sn-devel-104

13 years agos4-python: Consistently use spaces rather than tabs, fix headers in several places.
Jelmer Vernooij [Mon, 12 Sep 2011 23:10:37 +0000 (01:10 +0200)]
s4-python: Consistently use spaces rather than tabs, fix headers in several places.

13 years agoAdd samba.tests.source, which checks Python files for copyright lines, license header...
Jelmer Vernooij [Mon, 12 Sep 2011 23:09:16 +0000 (01:09 +0200)]
Add samba.tests.source, which checks Python files for copyright lines, license headers and invalid characters (dos newlines, tabs).

13 years agotestparm.py: Use standard formatting of header.
Jelmer Vernooij [Mon, 12 Sep 2011 22:20:57 +0000 (00:20 +0200)]
testparm.py: Use standard formatting of header.

13 years agogroup.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:20:17 +0000 (00:20 +0200)]
group.py: Remove tab characters.

13 years agodrs.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:20:03 +0000 (00:20 +0200)]
drs.py: Remove tab characters.

13 years agodomain.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:19:51 +0000 (00:19 +0200)]
domain.py: Remove tab characters.

13 years agodelegation.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:19:45 +0000 (00:19 +0200)]
delegation.py: Remove tab characters.

13 years agodrs_utils.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:19:24 +0000 (00:19 +0200)]
drs_utils.py: Remove tab characters.

13 years agos4:lib/socket/interface.c - "ifaces" strictly needs to be initialised
Matthias Dieter Wallnöfer [Mon, 12 Sep 2011 13:45:11 +0000 (15:45 +0200)]
s4:lib/socket/interface.c - "ifaces" strictly needs to be initialised

Please consider a failing "get_interfaces" call and the "talloc_free()"
operation on a possible uninitialised "ifaces" on line 326.

https://bugzilla.samba.org/show_bug.cgi?id=8397

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Sep 12 23:49:12 CEST 2011 on sn-devel-104

13 years agoMove the talloc_move call until *after* the check on status. Don't want to move somet...
Jeremy Allison [Mon, 12 Sep 2011 18:23:17 +0000 (11:23 -0700)]
Move the talloc_move call until *after* the check on status. Don't want to move something that might be invalid.

Makes the code match what is currently in 3.6.x.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Sep 12 22:21:24 CEST 2011 on sn-devel-104

13 years agos3:libsmb: check the wct of the incoming SMBnegprot responses
Stefan Metzmacher [Mon, 12 Sep 2011 05:13:56 +0000 (07:13 +0200)]
s3:libsmb: check the wct of the incoming SMBnegprot responses

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Sep 12 20:50:27 CEST 2011 on sn-devel-104

13 years agos3:libsmb: let cli_pull_raw_error() return NT_STATUS_OK as DOS-Error success
Stefan Metzmacher [Mon, 12 Sep 2011 07:45:13 +0000 (09:45 +0200)]
s3:libsmb: let cli_pull_raw_error() return NT_STATUS_OK as DOS-Error success

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Sep 12 19:12:21 CEST 2011 on sn-devel-104

13 years agos3-auth: fix uninitialized server_info
Sumit Bose [Mon, 12 Sep 2011 13:50:31 +0000 (15:50 +0200)]
s3-auth: fix uninitialized server_info

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Sep 12 17:44:46 CEST 2011 on sn-devel-104

13 years agos3-lsa: Add conversion for auth info structs
Sumit Bose [Thu, 1 Sep 2011 16:18:31 +0000 (18:18 +0200)]
s3-lsa: Add conversion for auth info structs

struct lsa_TrustDomainInfoAuthInfo and struct
trustAuthInOutBlob can store the same information for different usage. The added
routines can convert one struct into the other.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Sep 12 15:52:17 CEST 2011 on sn-devel-104

13 years agodoc: suggest samba-tool dbcheck in upgrading-samba4.txt
Andrew Bartlett [Mon, 12 Sep 2011 10:41:29 +0000 (20:41 +1000)]
doc: suggest samba-tool dbcheck in upgrading-samba4.txt

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Sep 12 14:24:20 CEST 2011 on sn-devel-104

13 years agos4-s3-upgrade Remove upgrade_from_s3 script, use samba-tool domain samba3upgrade
Andrew Bartlett [Mon, 12 Sep 2011 10:21:53 +0000 (20:21 +1000)]
s4-s3-upgrade Remove upgrade_from_s3 script, use samba-tool domain samba3upgrade

13 years agostart Samba 4.0alpha17 release notes
Andrew Bartlett [Mon, 12 Sep 2011 04:16:12 +0000 (14:16 +1000)]
start Samba 4.0alpha17 release notes

13 years agos3-selftest: Set path to bin/net and bin/wbinfo in command line to test scripts
Andrew Bartlett [Sat, 10 Sep 2011 22:16:50 +0000 (08:16 +1000)]
s3-selftest: Set path to bin/net and bin/wbinfo in command line to test scripts

This makes it easier to reproduce these tests outside the test
environment, as we rely less on environment variables.

Andrew Bartlett

13 years agosamba-tool: Add "domain samba3upgrade" subcommand
Amitay Isaacs [Mon, 12 Sep 2011 06:03:34 +0000 (16:03 +1000)]
samba-tool: Add "domain samba3upgrade" subcommand

Added new command to upgrade from samba3 to samba4.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-s3-upgrade: Check for duplicate sids before provisioning
Amitay Isaacs [Mon, 12 Sep 2011 05:09:49 +0000 (15:09 +1000)]
s4-s3-upgrade: Check for duplicate sids before provisioning

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-provision: Fix the informational message from dns provisioning
Amitay Isaacs [Mon, 12 Sep 2011 03:17:50 +0000 (13:17 +1000)]
s4-provision: Fix the informational message from dns provisioning

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-provision: Create private dir for dns in a separate function
Amitay Isaacs [Mon, 12 Sep 2011 03:14:42 +0000 (13:14 +1000)]
s4-provision: Create private dir for dns in a separate function

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-s3-upgrade: Check for common user/group names before provisioning
Amitay Isaacs [Mon, 12 Sep 2011 02:14:00 +0000 (12:14 +1000)]
s4-s3-upgrade: Check for common user/group names before provisioning

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-provision: Generate appropriate named.conf file depending on dns_backend
Amitay Isaacs [Thu, 8 Sep 2011 05:33:41 +0000 (15:33 +1000)]
s4-provision: Generate appropriate named.conf file depending on dns_backend

For --dns_backend=BIND9, generate the dns zone file, and named.conf with
zone information.

For --dns-backend=BIND9_DLZ, generate the named.conf with dlz directive.

If no option is specified, default dns_backend is BIND9.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-provision: Remove dupliate creation of dns/spn_update_list files
Amitay Isaacs [Thu, 8 Sep 2011 05:29:59 +0000 (15:29 +1000)]
s4-provision: Remove dupliate creation of dns/spn_update_list files

dns_update_list and spn_update_list are set up using
create_dns_update_list() function.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-provision: Add named.conf template for BIND9 with DLZ support
Amitay Isaacs [Thu, 8 Sep 2011 05:24:11 +0000 (15:24 +1000)]
s4-provision: Add named.conf template for BIND9 with DLZ support

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-provision: Add Seperate instructions for BIND 9.7.x and 9.8.x.
Amitay Isaacs [Thu, 8 Sep 2011 04:44:44 +0000 (14:44 +1000)]
s4-provision: Add Seperate instructions for BIND 9.7.x and 9.8.x.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4-provision: Enable SPNs for DNS
Amitay Isaacs [Mon, 5 Sep 2011 06:20:00 +0000 (16:20 +1000)]
s4-provision: Enable SPNs for DNS

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4:samba-tool/domain.py - rename arguments "domain" -> "domain-level", "forest" ...
Matthias Dieter Wallnöfer [Sun, 11 Sep 2011 15:31:38 +0000 (17:31 +0200)]
s4:samba-tool/domain.py - rename arguments "domain" -> "domain-level", "forest" -> "forest-level"

This should clarify the scope of them.

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Sep 11 20:12:52 CEST 2011 on sn-devel-104

13 years agos4:samba-tool/domain.py - restore domain raise functionality
Matthias Dieter Wallnöfer [Fri, 9 Sep 2011 13:27:25 +0000 (15:27 +0200)]
s4:samba-tool/domain.py - restore domain raise functionality

The samba-tool command has accidentally been damaged by commit
2d4988c3d79e501003875cd26b7f9aaa72402b31.

Reviewed-by: Jelmer
13 years agoldb:ldb_controls.c - remove duplicate definition of "LDB_CONTROL_CMP"
Matthias Dieter Wallnöfer [Wed, 22 Jun 2011 12:48:33 +0000 (14:48 +0200)]
ldb:ldb_controls.c - remove duplicate definition of "LDB_CONTROL_CMP"

And fix the comment

Reviewed-by: Jelmer
13 years agoldb:pyldb.c - point out that "PyLdbResult_AsResult" does not convert everything
Matthias Dieter Wallnöfer [Tue, 21 Jun 2011 09:11:04 +0000 (11:11 +0200)]
ldb:pyldb.c - point out that "PyLdbResult_AsResult" does not convert everything

Reviewed-by: Jelmer
13 years agolib/util/charset: the comparsion must be against our charset modules
Andrew Bartlett [Sat, 10 Sep 2011 05:51:45 +0000 (15:51 +1000)]
lib/util/charset: the comparsion must be against our charset modules

There is little point testing this against the system iconv.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Sep 10 15:45:42 CEST 2011 on sn-devel-104

13 years agolib/util/charset Use name of ISO-8859-1 that matches our internal implementation
Andrew Bartlett [Sat, 10 Sep 2011 05:41:14 +0000 (15:41 +1000)]
lib/util/charset Use name of ISO-8859-1 that matches our internal implementation

13 years agolib/util/charset: Improve toture assertions in iconv test
Andrew Bartlett [Sat, 10 Sep 2011 03:23:22 +0000 (13:23 +1000)]
lib/util/charset: Improve toture assertions in iconv test

13 years agolib/util/charset Run charset sets with and without the system iconv
Andrew Bartlett [Fri, 9 Sep 2011 23:53:29 +0000 (09:53 +1000)]
lib/util/charset Run charset sets with and without the system iconv

We need to know that we can load the samba-provided modules, and that
they are correct.  However, we must mark a number of tests as
knownfail due to errors in our internal iconv modules.

Andrew Bartlett

13 years agolib/util/charset: add back loading of charset modules
Andrew Bartlett [Fri, 9 Sep 2011 13:51:06 +0000 (23:51 +1000)]
lib/util/charset: add back loading of charset modules

For autoconf builds these remain as modules, for waf builds they are
built into the charset library.

This is required to provide the CP850 charset when iconv is not available.

The charset modules static for the waf builds because with proper
shared libs, there isn't the same need for these to be in seperate .so
files.  The modules are also not produced if a system iconv is found,
except for developers, to allow testing of both code paths.

Andrew Bartlett

13 years agolibcli/smb: s/FLAGS2_UNKNOWN_BIT4/FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED
Stefan Metzmacher [Fri, 9 Sep 2011 20:43:28 +0000 (22:43 +0200)]
libcli/smb: s/FLAGS2_UNKNOWN_BIT4/FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Sep 10 00:34:50 CEST 2011 on sn-devel-104

13 years agos4-s3-upgrade Do not use python 2.6 style exceptions
Andrew Bartlett [Fri, 9 Sep 2011 02:44:56 +0000 (12:44 +1000)]
s4-s3-upgrade Do not use python 2.6 style exceptions

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Sep  9 08:54:16 CEST 2011 on sn-devel-104

13 years agobuild: a more robust zlib test
Andrew Bartlett [Fri, 9 Sep 2011 02:08:54 +0000 (12:08 +1000)]
build: a more robust zlib test

Just in-case, and done this way due to the #define maze that applies
to this function.  No actual host has been found that needs this yet.

Andrew Bartlett

13 years agosamba-tool: epilog option to OptionParser available in python >= 2.6
Amitay Isaacs [Fri, 9 Sep 2011 03:27:13 +0000 (13:27 +1000)]
samba-tool: epilog option to OptionParser available in python >= 2.6

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Provide feedback if synopsis is not defined for a command
Amitay Isaacs [Fri, 9 Sep 2011 03:26:04 +0000 (13:26 +1000)]
samba-tool: Provide feedback if synopsis is not defined for a command

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: max() with key option is available in python >= 2.6
Amitay Isaacs [Fri, 9 Sep 2011 03:24:10 +0000 (13:24 +1000)]
samba-tool: max() with key option is available in python >= 2.6

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Correctly handle sys.exit() called from subcommand
Amitay Isaacs [Fri, 9 Sep 2011 03:22:27 +0000 (13:22 +1000)]
samba-tool: Correctly handle sys.exit() called from subcommand

Catch SystemExit exception if any subcommand calls sys.exit()
and return with failure (-1).

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "ldapcmp" command synopsis
Giampaolo Lauria [Fri, 2 Sep 2011 15:23:26 +0000 (11:23 -0400)]
samba-tool: Fixed "ldapcmp" command synopsis

Fixed "ldapcmp" command syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "dbcheck" subcommand syntax
Giampaolo Lauria [Tue, 30 Aug 2011 22:08:44 +0000 (18:08 -0400)]
samba-tool: Fixed "dbcheck" subcommand syntax

Fixed syntax for "dbcheck" subcommand

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Moved _get_user_realm_domain fcn to common
Giampaolo Lauria [Wed, 7 Sep 2011 15:11:38 +0000 (11:11 -0400)]
samba-tool: Moved _get_user_realm_domain fcn to common

_get_user_realm_domain is used by both delegation and spn commands

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "testparm" syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:41:41 +0000 (13:41 -0400)]
samba-tool: Fixed "testparm" syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "user" command syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:35:00 +0000 (13:35 -0400)]
samba-tool: Fixed "user" command syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "rodc" syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:25:30 +0000 (13:25 -0400)]
samba-tool: Fixed "rodc" syntax

Remove options from syntax to be consistent w/ the rest of commands

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "ntacl" subcommands syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:15:25 +0000 (13:15 -0400)]
samba-tool: Fixed "ntacl" subcommands syntax

Removed options from syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "group" subcommands syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:12:36 +0000 (13:12 -0400)]
samba-tool: Fixed "group" subcommands syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "dsacl" command syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:05:19 +0000 (13:05 -0400)]
samba-tool: Fixed "dsacl" command syntax

Removed option from syntax to be consistent w/ the rest of commands

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "drs" subcommands syntax
Giampaolo Lauria [Fri, 2 Sep 2011 17:56:51 +0000 (13:56 -0400)]
samba-tool: Fixed "drs" subcommands syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "domain" subcommands syntax
Giampaolo Lauria [Fri, 2 Sep 2011 17:21:49 +0000 (13:21 -0400)]
samba-tool: Fixed "domain" subcommands syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agosamba-tool: Fixed "spn" command syntax
Giampaolo Lauria [Fri, 2 Sep 2011 16:52:54 +0000 (12:52 -0400)]
samba-tool: Fixed "spn" command syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>