kamenim/samba.git
13 years agoselftest: correct the import of Time::HighRes
Matthieu Patou [Mon, 18 Oct 2010 16:21:12 +0000 (20:21 +0400)]
selftest: correct the import of Time::HighRes

The "use" is always evaluated first even if enclosed into a if. So
on plateform without Time::Hires (ie. sun8 in the build farm). This
leads to an error.

Instead we use the synthax require Module + Module->import("function")

13 years agoldb:"ldb_schema_attribute_by_name_internal" - switch back to 32bit counters
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:19:00 +0000 (20:19 +0200)]
ldb:"ldb_schema_attribute_by_name_internal" - switch back to 32bit counters

Use the signed counter for the binary search but use an unsigned one for
accessing the entry.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Oct 18 19:01:31 UTC 2010 on sn-devel-104

13 years agoldb:ldb_tdb.c - fix up counter variables
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:10:17 +0000 (20:10 +0200)]
ldb:ldb_tdb.c - fix up counter variables

"find_element" returns an "int" since there is also the possibility that a
certain element doesn't exist - then "-1" is returned. But beside this
exception treat all other return values as unsigned.

13 years agoldb:ldb_tdb.c - improve the error outputs
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:07:49 +0000 (20:07 +0200)]
ldb:ldb_tdb.c - improve the error outputs

- Fix indentation
- Include always the failing DN
- Reorder the outputs to make them consistent

13 years agos4:"util_ldb" - remove some really unused dependancies
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 17:24:43 +0000 (19:24 +0200)]
s4:"util_ldb" - remove some really unused dependancies

13 years agolibcli/nbt: we don't need LIBCLI_COMPOSITE anymore
Stefan Metzmacher [Mon, 11 Oct 2010 20:29:30 +0000 (22:29 +0200)]
libcli/nbt: we don't need LIBCLI_COMPOSITE anymore

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 18 16:18:32 UTC 2010 on sn-devel-104

13 years agolibcli/nbt: convert nbt_name_register_bcast_send/recv to tevent_req
Stefan Metzmacher [Mon, 11 Oct 2010 19:18:15 +0000 (21:18 +0200)]
libcli/nbt: convert nbt_name_register_bcast_send/recv to tevent_req

metze

13 years agolibcli/nbt: s/name_register_bcast_handler/nbt_name_register_bcast_handler
Stefan Metzmacher [Mon, 11 Oct 2010 19:01:23 +0000 (21:01 +0200)]
libcli/nbt: s/name_register_bcast_handler/nbt_name_register_bcast_handler

metze

13 years agolibcli/nbt: s/register_bcast_state/nbt_name_register_bcast_state/
Stefan Metzmacher [Mon, 11 Oct 2010 18:59:35 +0000 (20:59 +0200)]
libcli/nbt: s/register_bcast_state/nbt_name_register_bcast_state/

metze

13 years agolibcli/nbt: move nbt_name_register_bcast_send to the top of nbt_name_register_bcast_*
Stefan Metzmacher [Mon, 11 Oct 2010 18:57:58 +0000 (20:57 +0200)]
libcli/nbt: move nbt_name_register_bcast_send to the top of nbt_name_register_bcast_*

metze

13 years agos4:nbt_server/register: add a nbtd_register_name_state
Stefan Metzmacher [Mon, 11 Oct 2010 20:17:02 +0000 (22:17 +0200)]
s4:nbt_server/register: add a nbtd_register_name_state

metze

13 years agolibcli/nbt: convert nbt_name_register_wins_send/recv to tevent_req
Stefan Metzmacher [Mon, 11 Oct 2010 19:58:29 +0000 (21:58 +0200)]
libcli/nbt: convert nbt_name_register_wins_send/recv to tevent_req

metze

13 years agolibcli/nbt: s/name_register_wins_handler/nbt_name_register_wins_handler
Stefan Metzmacher [Mon, 11 Oct 2010 19:23:58 +0000 (21:23 +0200)]
libcli/nbt: s/name_register_wins_handler/nbt_name_register_wins_handler

metze

13 years agolibcli/nbt: s/register_wins_state/nbt_name_register_wins_state
Stefan Metzmacher [Mon, 11 Oct 2010 19:21:26 +0000 (21:21 +0200)]
libcli/nbt: s/register_wins_state/nbt_name_register_wins_state

metze

13 years agolibcli/nbt: move nbt_name_register_wins_send() to the top of all nbt_name_register_wi...
Stefan Metzmacher [Mon, 11 Oct 2010 19:19:59 +0000 (21:19 +0200)]
libcli/nbt: move nbt_name_register_wins_send() to the top of all nbt_name_register_wins_* related code

metze

13 years agos4:nbt_server/winsclient: add a nbtd_wins_register_state
Stefan Metzmacher [Mon, 11 Oct 2010 18:49:28 +0000 (20:49 +0200)]
s4:nbt_server/winsclient: add a nbtd_wins_register_state

We now keep the nbtd_wins_register_state around between
nbt_name_register_wins_send() and nbt_name_register_wins_recv()

metze

13 years agolibcli/nbt: convert nbt_name_refresh_wins_send/recv to tevent_req
Stefan Metzmacher [Mon, 11 Oct 2010 06:54:27 +0000 (08:54 +0200)]
libcli/nbt: convert nbt_name_refresh_wins_send/recv to tevent_req

metze

13 years agolibcli/nbt: s/name_refresh_wins_handler/nbt_name_refresh_wins_handler
Stefan Metzmacher [Mon, 11 Oct 2010 06:33:06 +0000 (08:33 +0200)]
libcli/nbt: s/name_refresh_wins_handler/nbt_name_refresh_wins_handler

metze

13 years agolibcli/nbt: s/refresh_wins_state/nbt_name_refresh_wins_state
Stefan Metzmacher [Mon, 11 Oct 2010 06:18:16 +0000 (08:18 +0200)]
libcli/nbt: s/refresh_wins_state/nbt_name_refresh_wins_state

metze

13 years agolibcli/nbt: move nbt_name_refresh_wins_send() to the top of all nbt_name_refresh_wins...
Stefan Metzmacher [Mon, 11 Oct 2010 06:15:01 +0000 (08:15 +0200)]
libcli/nbt: move nbt_name_refresh_wins_send() to the top of all nbt_name_refresh_wins_* related code

metze

13 years agos4:nbt_server/winsclient: add a nbtd_wins_refresh_state
Stefan Metzmacher [Mon, 11 Oct 2010 07:41:16 +0000 (09:41 +0200)]
s4:nbt_server/winsclient: add a nbtd_wins_refresh_state

We now keep the nbtd_wins_refresh_state around between
nbt_name_refresh_wins_send() and nbt_name_refresh_wins_recv()

metze

13 years agos4:nbt_server/wins: fix compiler warnings
Stefan Metzmacher [Mon, 11 Oct 2010 20:26:09 +0000 (22:26 +0200)]
s4:nbt_server/wins: fix compiler warnings

metze

13 years agoInclude misc.idl for policy_handle in srvsvc.idl.
Tim Potter [Mon, 18 Oct 2010 14:54:31 +0000 (07:54 -0700)]
Include misc.idl for policy_handle in srvsvc.idl.

Autobuild-User: Tim Potter <tpot@samba.org>
Autobuild-Date: Mon Oct 18 15:35:40 UTC 2010 on sn-devel-104

13 years agos3: fix the build of idmap_adex, idmap_tdb2, idmap_hash and several vfs modules.
Günther Deschner [Mon, 18 Oct 2010 13:55:47 +0000 (15:55 +0200)]
s3: fix the build of idmap_adex, idmap_tdb2, idmap_hash and several vfs modules.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Oct 18 14:39:39 UTC 2010 on sn-devel-104

13 years agos3-waf: fix the build after libcli/security changes.
Günther Deschner [Mon, 18 Oct 2010 13:55:16 +0000 (15:55 +0200)]
s3-waf: fix the build after libcli/security changes.

Guenther

13 years agos3-waf: fix the build of smbtorture.
Günther Deschner [Mon, 11 Oct 2010 22:46:53 +0000 (00:46 +0200)]
s3-waf: fix the build of smbtorture.

Guenther

13 years agos3-waf: fix pdb modules build.
Günther Deschner [Mon, 11 Oct 2010 22:26:03 +0000 (00:26 +0200)]
s3-waf: fix pdb modules build.

Guenther

13 years agos4:libcli/util: add pipe related NT_STATUS_RPC_* codes
Stefan Metzmacher [Mon, 11 Oct 2010 21:04:28 +0000 (23:04 +0200)]
s4:libcli/util: add pipe related NT_STATUS_RPC_* codes

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 18 13:50:55 UTC 2010 on sn-devel-104

13 years agos3:libsmb: add pipe related NT_STATUS_RPC_* codes
Stefan Metzmacher [Mon, 11 Oct 2010 21:03:34 +0000 (23:03 +0200)]
s3:libsmb: add pipe related NT_STATUS_RPC_* codes

metze

13 years agolibcli/util: add pipe related NT_STATUS_RPC_* codes
Stefan Metzmacher [Mon, 11 Oct 2010 21:02:38 +0000 (23:02 +0200)]
libcli/util: add pipe related NT_STATUS_RPC_* codes

metze

13 years agos3-winbind: Fixed init order.
Andreas Schneider [Fri, 15 Oct 2010 15:58:39 +0000 (17:58 +0200)]
s3-winbind: Fixed init order.

We need the system server info in the rpc services.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Mon Oct 18 12:43:16 UTC 2010 on sn-devel-104

13 years agolibrpc: Fixed memory context of dcerpc_binding_from_tower.
Stefan Metzmacher [Mon, 18 Oct 2010 10:20:56 +0000 (12:20 +0200)]
librpc: Fixed memory context of dcerpc_binding_from_tower.

13 years agos4-gensec: Add dependency on com_err to GENSEC_KRB5.
Andreas Schneider [Mon, 18 Oct 2010 09:50:04 +0000 (11:50 +0200)]
s4-gensec: Add dependency on com_err to GENSEC_KRB5.

13 years agos4-ldb Add LDB_REQ_SET_LOCATION to help track handler use
Andrew Bartlett [Mon, 18 Oct 2010 11:13:20 +0000 (22:13 +1100)]
s4-ldb Add LDB_REQ_SET_LOCATION to help track handler use

This greatly assists in debugging what is going on with the
ldb handle, as it indicates where it was created.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Oct 18 11:54:46 UTC 2010 on sn-devel-104

13 years agos4-selftest Make GDB_PROVISION work again
Andrew Bartlett [Mon, 18 Oct 2010 11:11:40 +0000 (22:11 +1100)]
s4-selftest Make GDB_PROVISION work again

gdb --args won't run the #!/usr/bin/evn python

Andrew Bartlett

13 years agoldb Ensure we mark ongoing LDAP requests as PENDING
Andrew Bartlett [Mon, 18 Oct 2010 03:06:50 +0000 (14:06 +1100)]
ldb Ensure we mark ongoing LDAP requests as PENDING

13 years agos4-openldap-backend Don't set 'dbnosync' on cn=config
Andrew Bartlett [Mon, 18 Oct 2010 00:49:55 +0000 (11:49 +1100)]
s4-openldap-backend Don't set 'dbnosync' on cn=config

This isn't valid in current OpenLDAP versions.

Andrew Bartlett

13 years agos4-provision Use --ldap-backend-nosync rather than just --nosync
Andrew Bartlett [Mon, 18 Oct 2010 00:48:14 +0000 (11:48 +1100)]
s4-provision Use --ldap-backend-nosync rather than just --nosync

For some reason we had both options, and --ldap-backend-nosync is
the better name.

Andrew Bartlett

13 years agoheimdal_build: Add dependency on com_err to HEIMDAL_CONFIG.
Jelmer Vernooij [Mon, 18 Oct 2010 09:35:46 +0000 (11:35 +0200)]
heimdal_build: Add dependency on com_err to HEIMDAL_CONFIG.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Oct 18 10:27:47 UTC 2010 on sn-devel-104

13 years agoThis is typo fix patch for smbcacls.1.xml .
Samba-JP oota [Mon, 18 Oct 2010 05:10:29 +0000 (07:10 +0200)]
This is typo fix patch for smbcacls.1.xml .

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Oct 18 05:53:26 UTC 2010 on sn-devel-104

13 years agodsdb simple_ldap_map depends on LDBSAMBA
Andrew Bartlett [Sun, 17 Oct 2010 23:48:21 +0000 (10:48 +1100)]
dsdb simple_ldap_map depends on LDBSAMBA

This shows up at build time on MacOS and runtime on Linux when we
use the LDAP backend.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Oct 18 00:57:51 UTC 2010 on sn-devel-104

13 years agoRevert "s4:dsdb - make the RELAX control private"
Andrew Bartlett [Sun, 17 Oct 2010 23:24:56 +0000 (10:24 +1100)]
Revert "s4:dsdb - make the RELAX control private"

This must be available to the OpenLDAP backend, to set the GUID values
in some situations.  We need a proper ACL mechanism to control the use
or abuse of this control.

This reverts commit 10adee89367cee9add993869280542418fb3d370.

13 years agoheimdal: Attempt to fix path of hdb_asn1.h
Jelmer Vernooij [Sun, 17 Oct 2010 23:28:53 +0000 (01:28 +0200)]
heimdal: Attempt to fix path of hdb_asn1.h

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Oct 18 00:15:11 UTC 2010 on sn-devel-104

13 years agodsdb: Module aliases require to be prefixed with the subsystem name.
Jelmer Vernooij [Sun, 17 Oct 2010 23:17:56 +0000 (01:17 +0200)]
dsdb: Module aliases require to be prefixed with the subsystem name.

13 years agodcerpc_samr: Fix -l arguments for dcerpc_samr and dcerpc_atsvc.
Jelmer Vernooij [Sun, 17 Oct 2010 18:35:04 +0000 (20:35 +0200)]
dcerpc_samr: Fix -l arguments for dcerpc_samr and dcerpc_atsvc.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Oct 17 19:15:43 UTC 2010 on sn-devel-104

13 years agotdb: Bump version to 1.2.7 after addition of pytdb.__version__.
Jelmer Vernooij [Sun, 17 Oct 2010 17:39:09 +0000 (19:39 +0200)]
tdb: Bump version to 1.2.7 after addition of pytdb.__version__.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Oct 17 18:23:16 UTC 2010 on sn-devel-104

13 years agoheimdal: Add local simpler copy of to_list().
Jelmer Vernooij [Sat, 16 Oct 2010 17:01:18 +0000 (19:01 +0200)]
heimdal: Add local simpler copy of to_list().

13 years agoRevert "s4:remove "util_ldb" submodule and integrate the three gendb_* calls in ...
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 12:27:18 +0000 (14:27 +0200)]
Revert "s4:remove "util_ldb" submodule and integrate the three gendb_* calls in "dsdb/common/util.c""

This reverts commit 8a2ce5c47cee499f90b125ebde83de5f9f1a9aa0.

Jelmer pointed out that these are also in use by other LDB databases - not only
SAMDB ones.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Oct 17 13:37:16 UTC 2010 on sn-devel-104

13 years agos4:remove "util_ldb" submodule and integrate the three gendb_* calls in "dsdb/common...
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 08:37:23 +0000 (10:37 +0200)]
s4:remove "util_ldb" submodule and integrate the three gendb_* calls in "dsdb/common/util.c"

They're only in use by SAMDB code.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Oct 17 09:40:13 UTC 2010 on sn-devel-104

13 years agos4:lib/util/util_ldb.c - remove unused "gendb_add_ldif" call
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 08:29:46 +0000 (10:29 +0200)]
s4:lib/util/util_ldb.c - remove unused "gendb_add_ldif" call

13 years agos4:ldb-samba/ldb_wrap.c - fix indentation and trailing whitespaces
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 08:23:41 +0000 (10:23 +0200)]
s4:ldb-samba/ldb_wrap.c - fix indentation and trailing whitespaces

13 years agos4:"wrap_casefold" - move it to "ldb_wrap.c" since it's only used there
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 08:20:40 +0000 (10:20 +0200)]
s4:"wrap_casefold" - move it to "ldb_wrap.c" since it's only used there

13 years agos4:dsdb - make the RELAX control private
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 18:58:51 +0000 (20:58 +0200)]
s4:dsdb - make the RELAX control private

This makes our LDAP much more secure and less error-prone.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 16 19:43:36 UTC 2010 on sn-devel-104

13 years agos4:libcli/ldap/ldap_controls.c - fix up the controls list
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 18:46:20 +0000 (20:46 +0200)]
s4:libcli/ldap/ldap_controls.c - fix up the controls list

- add missing private controls and comments
- use control defines rather than hardcoded values -> easier to comprehend
- reorder controls

13 years agoldb:ldb.h - reorder controls/extended operations
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 18:45:08 +0000 (20:45 +0200)]
ldb:ldb.h - reorder controls/extended operations

This makes it easier to read

13 years agoheimdal: Remove some unused arguments from HEIMDAL_SUBSYSTEM().
Jelmer Vernooij [Sat, 16 Oct 2010 15:30:51 +0000 (17:30 +0200)]
heimdal: Remove some unused arguments from HEIMDAL_SUBSYSTEM().

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Oct 16 16:14:24 UTC 2010 on sn-devel-104

13 years agoheimdal: Allow leaving off prefix from asn1 option_file.
Jelmer Vernooij [Sat, 16 Oct 2010 15:26:24 +0000 (17:26 +0200)]
heimdal: Allow leaving off prefix from asn1 option_file.

13 years agoheimdal: Leave off ../heimdal prefix to HEIMDAL_BINARY().
Jelmer Vernooij [Sat, 16 Oct 2010 15:25:19 +0000 (17:25 +0200)]
heimdal: Leave off ../heimdal prefix to HEIMDAL_BINARY().

13 years agoheimdal: Allow leaving off prefix to HEIMDAL_ERRTABLE().
Jelmer Vernooij [Sat, 16 Oct 2010 15:23:06 +0000 (17:23 +0200)]
heimdal: Allow leaving off prefix to HEIMDAL_ERRTABLE().

13 years agoheimdal: Allow leaving off prefix for HEIMDAL_ASN1().
Jelmer Vernooij [Sat, 16 Oct 2010 15:21:05 +0000 (17:21 +0200)]
heimdal: Allow leaving off prefix for HEIMDAL_ASN1().

13 years agoheimdal: Allow leaving off ../heimdal prefix for proto headers.
Jelmer Vernooij [Sat, 16 Oct 2010 15:16:44 +0000 (17:16 +0200)]
heimdal: Allow leaving off ../heimdal prefix for proto headers.

13 years agoheimdal: Allow leaving off ../heimdal prefix for source files.
Jelmer Vernooij [Sat, 16 Oct 2010 15:13:10 +0000 (17:13 +0200)]
heimdal: Allow leaving off ../heimdal prefix for source files.

13 years agoheimdal: Add convenience functions for finding heimdal paths.
Jelmer Vernooij [Sat, 16 Oct 2010 15:08:27 +0000 (17:08 +0200)]
heimdal: Add convenience functions for finding heimdal paths.

13 years agoheimdal: Call HEIMDAL_AUTOPROTO() manually.
Jelmer Vernooij [Sat, 16 Oct 2010 15:06:41 +0000 (17:06 +0200)]
heimdal: Call HEIMDAL_AUTOPROTO() manually.

13 years agoheimdal: Call HEIMDAL_AUTOPROTO_PRIVATE() manually.
Jelmer Vernooij [Sat, 16 Oct 2010 15:03:06 +0000 (17:03 +0200)]
heimdal: Call HEIMDAL_AUTOPROTO_PRIVATE() manually.

13 years agoheimdal: Add variables for source files.
Jelmer Vernooij [Sat, 16 Oct 2010 14:46:22 +0000 (16:46 +0200)]
heimdal: Add variables for source files.

13 years agoheimdal: Simplify handling of ../heimdal prefixes in HEIMDAL_SUBSYSTEM.
Jelmer Vernooij [Sat, 16 Oct 2010 14:37:11 +0000 (16:37 +0200)]
heimdal: Simplify handling of ../heimdal prefixes in HEIMDAL_SUBSYSTEM.

13 years agoheimdal_build: Fix detection of system roken library.
Jelmer Vernooij [Sat, 16 Oct 2010 02:31:54 +0000 (04:31 +0200)]
heimdal_build: Fix detection of system roken library.

13 years agoheimdal_build: Remove ignored argument ldflags from HEIMDAL_BINARY().
Jelmer Vernooij [Sat, 16 Oct 2010 02:30:49 +0000 (04:30 +0200)]
heimdal_build: Remove ignored argument ldflags from HEIMDAL_BINARY().

13 years agoldb:pyldb.c - remove pointless comment
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 13:49:07 +0000 (15:49 +0200)]
ldb:pyldb.c - remove pointless comment

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 16 14:38:58 UTC 2010 on sn-devel-104

13 years agoldb:"ldb_dn_compare_base" - use "unsigned int" counters
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 13:10:11 +0000 (15:10 +0200)]
ldb:"ldb_dn_compare_base" - use "unsigned int" counters

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 16 13:54:13 UTC 2010 on sn-devel-104

13 years agoldb:"ldb_dn_add_child" - use "unsigned int" counters
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 13:08:40 +0000 (15:08 +0200)]
ldb:"ldb_dn_add_child" - use "unsigned int" counters

13 years agoldb:"ldb_dn_remove_base_components" - use an "unsigned int" counter
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 13:04:57 +0000 (15:04 +0200)]
ldb:"ldb_dn_remove_base_components" - use an "unsigned int" counter

13 years agoldb:"ldb_dn_canonical" - use an "unsigned int" counter
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 12:47:42 +0000 (14:47 +0200)]
ldb:"ldb_dn_canonical" - use an "unsigned int" counter

Convert it to use an "unsigned int" counter which represents the exact length
of the DN components.

13 years agos4:samldb LDB module - use appropriate fixed-length integer types where needed
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 12:19:19 +0000 (14:19 +0200)]
s4:samldb LDB module - use appropriate fixed-length integer types where needed

- The "systemFlags" we interpret always as signed
- Use "samdb_msg_add_int" where possible (much saver for integer storing than
  ldb_msg_add_fmt)

13 years agos4:dsdb/samdb/ldb_modules/util.c - remove now unused functions which set integers
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 09:00:12 +0000 (11:00 +0200)]
s4:dsdb/samdb/ldb_modules/util.c - remove now unused functions which set integers

Please do always use the functions which specifiy the appropriate integer
length to not run into platform-specific issues. Therefore I'm removing these
generic calls.

13 years agos4:samba3sid LDB module - handle the RID as uint32_t
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 08:59:30 +0000 (10:59 +0200)]
s4:samba3sid LDB module - handle the RID as uint32_t

- This is how we always deal with RIDs
- Use an integer-length safe function for the RID update

13 years agos4:objectclass LDB module - implement the "isCriticalSystemObject" subtree delete...
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 10:28:25 +0000 (12:28 +0200)]
s4:objectclass LDB module - implement the "isCriticalSystemObject" subtree delete protection

MS-ADTS 3.1.1.5.5.7.2

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 16 11:24:09 UTC 2010 on sn-devel-104

13 years agos4:ldif_handlers.c - fix a typo
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 09:32:38 +0000 (11:32 +0200)]
s4:ldif_handlers.c - fix a typo

13 years agos4:dsdb - fix unsigned integer save problems using the "%u" specifier
Matthias Dieter Wallnöfer [Thu, 14 Oct 2010 15:01:39 +0000 (17:01 +0200)]
s4:dsdb - fix unsigned integer save problems using the "%u" specifier

The issue here is that we have not yet first cast to int32_t explicitly,
before we cast to an signed int to printf() into the %d or cast to a
int64_t before we then cast to a long long to printf into a %lld.

There are *no* unsigned integers in Active Directory LDAP, even the RID
allocations and ms-DS-Secondary-KrbTgt-Number are *signed* quantities.
(See the schema, and the syntax definitions in schema_syntax.c).

The failure has been detected by Matthieu Patou on the buildfarm host "tridge"
due to a malformed "groupType" attribute.

The solution is to use the "%d" specifier. Either to use it directly - or better
(when possible) use the call "samdb_msg_add_uint" (which encapsulates it).

This patch changes such problematic situations.

13 years agos4:dsdb/common/util.c - describe the behaviour of the functions "samdb_msg_add_uint...
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 08:36:32 +0000 (10:36 +0200)]
s4:dsdb/common/util.c - describe the behaviour of the functions "samdb_msg_add_uint", "samdb_msg_add_uint64" and "samdb_msg_set_uint" a bit more

Unsigned int data in AD is a bit problematic to handle. Problem described by
abartlet.

13 years agoDon't arbitrarily clean all parametric options in add_a_service(),
Jeremy Allison [Sat, 16 Oct 2010 05:27:10 +0000 (22:27 -0700)]
Don't arbitrarily clean all parametric options in add_a_service(),
that is called from many places, not just smb.conf processing. Only
clean parametric options when doing actual smb.conf reading (or
registry equivalent).

Michael Adams, Volker, Metze, please check.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 16 06:46:19 UTC 2010 on sn-devel-104

13 years agoEnsure we have correct parameters to use Windows ACL modules.
Jeremy Allison [Sat, 16 Oct 2010 02:54:51 +0000 (19:54 -0700)]
Ensure we have correct parameters to use Windows ACL modules.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 16 03:36:04 UTC 2010 on sn-devel-104

13 years agoheimdal_build: Support using system asn1 library.
Jelmer Vernooij [Sat, 16 Oct 2010 01:27:02 +0000 (03:27 +0200)]
heimdal_build: Support using system asn1 library.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Oct 16 02:14:32 UTC 2010 on sn-devel-104

13 years agoheimdal_build: Skip some hx509 code when using system hx509.
Jelmer Vernooij [Sat, 16 Oct 2010 01:07:40 +0000 (03:07 +0200)]
heimdal_build: Skip some hx509 code when using system hx509.

13 years agoheimdal_build: Add comment with stub for finding the system libtommath.
Jelmer Vernooij [Sat, 16 Oct 2010 00:57:57 +0000 (02:57 +0200)]
heimdal_build: Add comment with stub for finding the system libtommath.

13 years agoheimdal_build: Initial work on supporting an external heimdal library.
Jelmer Vernooij [Sat, 16 Oct 2010 00:48:06 +0000 (02:48 +0200)]
heimdal_build: Initial work on supporting an external heimdal library.

13 years agoheimdal_build: Support using system hx509 library when explicitly
Jelmer Vernooij [Sat, 16 Oct 2010 00:25:40 +0000 (02:25 +0200)]
heimdal_build: Support using system hx509 library when explicitly
requested.

13 years agoheimdal_build: Fix build with system roken.
Jelmer Vernooij [Sat, 16 Oct 2010 00:15:36 +0000 (02:15 +0200)]
heimdal_build: Fix build with system roken.

13 years agoheimdal_build: Put version objects in a separate subsystem.
Jelmer Vernooij [Fri, 15 Oct 2010 23:49:41 +0000 (01:49 +0200)]
heimdal_build: Put version objects in a separate subsystem.

13 years agoheimdal: Support using system roken.
Jelmer Vernooij [Fri, 15 Oct 2010 22:58:56 +0000 (00:58 +0200)]
heimdal: Support using system roken.

13 years agoheimdal_build: Use existing functions for finding system libraries.
Jelmer Vernooij [Fri, 15 Oct 2010 22:41:34 +0000 (00:41 +0200)]
heimdal_build: Use existing functions for finding system libraries.

13 years agoAdd acl_xattr:ignore system acls boolean (normally false) to allow
Jeremy Allison [Fri, 15 Oct 2010 22:56:09 +0000 (15:56 -0700)]
Add acl_xattr:ignore system acls boolean (normally false) to allow
Samba ACL module to ignore mapping to lower POSIX layer. With this
fix Samba 3.6.x now passes RAW-ACLs (with certain smb.conf parameters
set).

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 16 01:26:31 UTC 2010 on sn-devel-104

13 years agoAdd make_default_filesystem_acl() function to be used in following change to acl_xatt...
Jeremy Allison [Fri, 15 Oct 2010 22:53:51 +0000 (15:53 -0700)]
Add make_default_filesystem_acl() function to be used in following change to acl_xattr and acl_tdb module.

13 years agoFix handling of "NULL" DACL. Map to u/g/w - rwx.
Jeremy Allison [Fri, 15 Oct 2010 22:42:44 +0000 (15:42 -0700)]
Fix handling of "NULL" DACL. Map to u/g/w - rwx.

Jeremy.

13 years agoFix "force unknown ACL user" to strip out foreign SIDs from POSIX ACLs if they can...
Jeremy Allison [Fri, 15 Oct 2010 22:28:23 +0000 (15:28 -0700)]
Fix "force unknown ACL user" to strip out foreign SIDs from POSIX ACLs if they can't be mapped.

13 years agoAdd debug message to get_nt_acl_internal() to see what we got.
Jeremy Allison [Fri, 15 Oct 2010 21:18:22 +0000 (14:18 -0700)]
Add debug message to get_nt_acl_internal() to see what we got.

13 years agoFix valgrind "uninitialized read" error on "info" when returning !NT_STATUS_OK.
Jeremy Allison [Fri, 15 Oct 2010 21:16:30 +0000 (14:16 -0700)]
Fix valgrind "uninitialized read" error on "info" when returning !NT_STATUS_OK.

Jeremy.

13 years agoFix bug #7734 - When creating files with "inherit ACLs" set to true, we neglect to...
Jeremy Allison [Fri, 15 Oct 2010 21:12:04 +0000 (14:12 -0700)]
Fix bug #7734 - When creating files with "inherit ACLs" set to true, we neglect to apply appropriate create masks.

Jeremy.

13 years agoFix bug #7733 - Invalid client DOS attributes on create can cause incorrect unix...
Jeremy Allison [Fri, 15 Oct 2010 20:30:07 +0000 (13:30 -0700)]
Fix bug #7733 - Invalid client DOS attributes on create can cause incorrect unix mode_t to be generated.

It turns out a client can send an NTCreateX call for a new file, but specify
FILE_ATTRIBUTE_DIRECTORY in the attribute list. Windows silently strips this,
but we don't - causing the unix_mode() function to go through the "mode bits
for new directory" codepath, instead of the "mode bits for new file" codepath.

Jeremy.