Jeff Layton [Fri, 14 Aug 2009 11:59:50 +0000 (07:59 -0400)]
cifs.upcall: clean up flag handling
Add a new stack var to hold the flags returned by the decoder routine
so that we don't need to worry so much about preserving "rc".
With this, we can drop privs before trying to find the location of
the credcache.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Fri, 14 Aug 2009 11:59:50 +0000 (07:59 -0400)]
cifs.upcall: try getting a "cifs/" principal and fall back to "host/"
cifs.upcall takes a "-c" flag that tells the upcall to get a principal
in the form of "cifs/hostname.example.com@REALM" instead of
"host/hostname.example.com@REALM". This has turned out to be a source of
great confusion for users.
Instead of requiring this flag, have the upcall try to get a "cifs/"
principal first. If that fails, fall back to getting a "host/"
principal.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Fri, 14 Aug 2009 11:59:49 +0000 (07:59 -0400)]
cifs.upcall: declare a structure for holding decoded args
The argument list for the decoder is becoming rather long. Declare an
args structure and use that for holding the args. This also simplifies
pointer handling a bit.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Fri, 14 Aug 2009 11:59:49 +0000 (07:59 -0400)]
cifs.upcall: formatting cleanup
Clean up some unneeded curly braces, and fix some indentation.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Fri, 14 Aug 2009 11:59:49 +0000 (07:59 -0400)]
cifs.upcall: clean up logging and add debug messages
Change the log levels to be more appropriate to the messages being
logged. Error messages should be LOG_ERR and not LOG_WARNING, for
instance.
Add some LOG_DEBUG messages that we can use to diagnose problems with
krb5 upcalls. With these, someone can set up syslog to log daemon.debug
and should be able to get more info when things aren't working.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Stefan Metzmacher [Fri, 14 Aug 2009 09:24:30 +0000 (11:24 +0200)]
s3:smbd: allow SMB2 Cancel to have the async flag set
metze
Stefan Metzmacher [Fri, 14 Aug 2009 09:14:42 +0000 (11:14 +0200)]
s3:smbd: fix parsing of the SMB2 body
Maybe there's no dynamic part on the wire.
metze
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 23:42:12 +0000 (01:42 +0200)]
s4:samdb python bindings - we don't need the attributes here
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 23:39:56 +0000 (01:39 +0200)]
s4:ldb - Free the asynchronous result
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 21:04:34 +0000 (23:04 +0200)]
s4: Correct the parameter logic of the "setpassword" script
Either the username or the filter are allowed. If both are given the filter is
going to be used due to a higher precedence.
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 09:37:38 +0000 (11:37 +0200)]
s4: Better way to call "dom_sid_to_rid" from ldap.py
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 08:43:42 +0000 (10:43 +0200)]
s4: Remove obsolete "samdb_password_quality_ok" function (it's just a one-line wrapper)
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 07:50:19 +0000 (09:50 +0200)]
s4: cracknames.c: Change the handling of the NT_STATUS_NO_MEMORY status results
With the previous check I got random failures when trying to connect to the
LDAP server.
Andrew Bartlett [Fri, 14 Aug 2009 03:10:42 +0000 (13:10 +1000)]
s4:ldap_server Correct removal of talloc_steal()
This corrects commit
7a82aed71b74af8bc2a8a4381541adbb22452d20. The
steal did not set ent->attributes, so it was incorrect to assign to
ent->attributes.
Andrew Bartlett
Andrew Tridgell [Fri, 14 Aug 2009 03:04:21 +0000 (13:04 +1000)]
fixed TESTS= in make test to allow multiple tests
Now you can do: make test TESTS="test1 test2" and it will run those
two tests, each matching tests using a case insensitive substring
match
Andrew Bartlett [Fri, 14 Aug 2009 02:57:46 +0000 (12:57 +1000)]
s4:ldap_server Remove another talloc_steal (with references)
This talloc_steal also conflicts with the ldb_map code, and like the
previous commit, is rudundent given the talloc_steal of the whole msg
above.
Andrew Bartlett
Andrew Bartlett [Fri, 14 Aug 2009 02:48:10 +0000 (12:48 +1000)]
s4:ldap_server Don't talloc_steal (with references) in ldap_backend
There may or may not be a need to take a reference to the 'name' in
the ldb_map code, but given we seal the whole msg just above here, it
makes no senst to steal the name, but not the values.
Andrew Bartlett
Jeremy Allison [Thu, 13 Aug 2009 00:44:48 +0000 (17:44 -0700)]
Fix EVERY SINGLE build on the buildfarm that doesn't have
bindtextdomain or textdomain. C'mon, this is what configure.in
is *FOR*.
Jeremy.
Jeremy Allison [Thu, 13 Aug 2009 00:07:13 +0000 (17:07 -0700)]
Move build over to storing DOS attributes in EA's.
Turn off "map to" directives. I've now fixed the
issues with the build tests running this way. I think
this is how most people run these days - please raise this on
the list (or revert) if you disagree.
Jeremy Allison [Wed, 12 Aug 2009 23:27:17 +0000 (16:27 -0700)]
When mapping EA's into a TDB, don't remove the EA
until the last link to the file is gone (fixes the
build farm RAW-RENAME test with xattr's in tdb's).
Jeremy.
Jeremy Allison [Wed, 12 Aug 2009 22:08:23 +0000 (15:08 -0700)]
Fix BASE-DELAYWRITE test by removing const from struct smb_filename
in smbd_do_qfilepathinfo(). update_stat_ex_mtime() modifies the
stat struct inside the smb_fname so don't make a copy of that
stat struct, use it directly - it's meant to be updated and
represent the state of the file we're returning.
Jeremy.
Jeremy Allison [Wed, 12 Aug 2009 20:54:38 +0000 (13:54 -0700)]
Documentation for "store create time".
Jeremy.
Jeremy Allison [Wed, 12 Aug 2009 20:00:54 +0000 (13:00 -0700)]
Add "store create time" parameter (docs to follow)
that stores the create time in the user.DosTimestamps EA.
Jeremy.
Jeremy Allison [Wed, 12 Aug 2009 17:58:00 +0000 (10:58 -0700)]
Fix some warnings in the AIX ACL code.
Jeremy.
Stefan Metzmacher [Wed, 12 Aug 2009 15:43:03 +0000 (17:43 +0200)]
libcli/smb: move smb2_create_blob code to libcli/smb/
I want to use this in source3/smbd/
metze
Stefan Metzmacher [Wed, 12 Aug 2009 15:52:55 +0000 (17:52 +0200)]
libcli: move some common SMB and SMB2 stuff into libcli/smb/
This will hold code that's shared between source3 and source4.
metze
Kai Blin [Wed, 12 Aug 2009 15:59:46 +0000 (17:59 +0200)]
librpc: rerun "make idl_full"
Stefan Metzmacher [Tue, 11 Aug 2009 16:31:27 +0000 (18:31 +0200)]
s3:smbd: as check_path_syntax() changes the string, we need to copy the string before
metze
Stefan Metzmacher [Tue, 11 Aug 2009 16:29:06 +0000 (18:29 +0200)]
s3:smbd: avoid 'goto out' in smbd_smb2_create_send()
metze
Stefan Metzmacher [Tue, 11 Aug 2009 16:09:05 +0000 (18:09 +0200)]
s3:smbd: make sure we don't call conn_free() with a NULL pointer for SMB2
metze
Stefan Metzmacher [Tue, 11 Aug 2009 16:08:26 +0000 (18:08 +0200)]
s3:smbd: correctly invalidate vuids when SMB2 is used
metze
Stefan Metzmacher [Tue, 11 Aug 2009 11:52:07 +0000 (13:52 +0200)]
s3:lib: map ECONNRESET to NT_STATUS_CONNECTION_RESET
metze
Matt Kraai [Wed, 12 Aug 2009 06:49:24 +0000 (08:49 +0200)]
libreplace: undef AI_ADDRCONFIG on QNX 6.3.0 (fix bug #6630)
Some of the functions in source3/lib/util_sock.c use AI_ADDRCONFIG. On QNX
6.3.0, this macro is defined but, if it's used, getaddrinfo will fail. This
prevents smbd from opening any sockets.
If I undefine AI_ADDRCONFIG on such systems and allow
lib/replace/system/network.h to define it to be 0, this works around the issue.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthias Dieter Wallnöfer [Tue, 11 Aug 2009 09:08:05 +0000 (11:08 +0200)]
s4:operational - Remove some outdated comments
Matthias Dieter Wallnöfer [Tue, 11 Aug 2009 09:02:03 +0000 (11:02 +0200)]
ldb: Don't break the standalone LDB build (operational module removed)
Matthias Dieter Wallnöfer [Tue, 11 Aug 2009 10:25:13 +0000 (12:25 +0200)]
s4:test for "primaryGroupToken"
Tests for the right behaviour of this introduced constructed attribute.
Since we don't support the read-only-ness of those attributes yet, I commented
some lines out.
Also I had to add a function for python which converts domain SIDs in RIDs.
And a small fix for the "groupType" test.
Matthias Dieter Wallnöfer [Mon, 10 Aug 2009 11:19:18 +0000 (13:19 +0200)]
s4:samldb module - Remove duplicate line
Matthias Dieter Wallnöfer [Mon, 10 Aug 2009 11:16:41 +0000 (13:16 +0200)]
s4:operational module - move and enhancements
This moves the "operational" LDB module to the right place under "dsdb/samdb/ldb_modules"
(suggested by abartlet) and enhances it for supporting dynamic generated
"primaryGroupToken" for AD groups. This should fix bug #6466.
Matthias Dieter Wallnöfer [Mon, 10 Aug 2009 09:06:33 +0000 (11:06 +0200)]
s4:pwsettings script - Fix a small glitch
This fixes the problem with the setting and getting of the "minPwdAge" and
"maxPwdAge" attributes. I wanted to handle them in days but forgot to add
conversions (from "ticks" (tenth of microsecond) -> "days" and backwards).
Kouhei Sutou [Mon, 10 Aug 2009 03:18:58 +0000 (12:18 +0900)]
Rename ASN1_BITFIELD to ASN1_BIT_STRING.
X.690 uses "BIT STRING" not "BIT FIELD".
Matthias Dieter Wallnöfer [Mon, 10 Aug 2009 08:12:51 +0000 (10:12 +0200)]
torture/basic: in run_derefopen() the file could have been deleted before the last unlink
Through a suggestion pointed out in bug #6622 the test file sometimes doesn't exist on
the last turn anymore. So we haven't to fail here since it could have been deleted by
a concurrent process (e.g. when the same test runs multiple times). Therefore also
NT_STATUS_OBJECT_NAME_NOT_FOUND is an acceptable result.
Matthias Dieter Wallnöfer [Sat, 8 Aug 2009 11:50:10 +0000 (13:50 +0200)]
s4:AD LDIFs - More refactoring
This commit includes:
- Additional static object data in SAMBA 4's AD to start supporting of
- forest updates, - lost and found, - quotas on DS, - physical locations,
- licensing of sites, - subnets, - policies for WMI, - DNS entries in AD
- Reordering of provision*.ldif files to be able to find entries and make future
additions easier
- Add comments in provision*.ldif files to point out where subentries are located
when they are based in other LDIFs
- Removations of autogenerated "cn" attributes
Stefan Metzmacher [Wed, 12 Aug 2009 08:24:01 +0000 (10:24 +0200)]
pidl: fix parse_idl test after idl.yp changes
We now generate 'FILE' and 'LINE' elements for each layer.
This change makes the expected PIDL trees human readable:-)
metze
Stefan Metzmacher [Wed, 12 Aug 2009 08:01:12 +0000 (10:01 +0200)]
pidl: fix samba3-cli test after the async function were added
metze
Andrew Tridgell [Wed, 12 Aug 2009 05:34:03 +0000 (15:34 +1000)]
try to give some hint as to what is causing NDR string errors
Andrew Tridgell [Wed, 12 Aug 2009 05:33:37 +0000 (15:33 +1000)]
when we get an NDR error in the logs, it is useful to know where it happened
Andrew Tridgell [Wed, 12 Aug 2009 05:20:02 +0000 (15:20 +1000)]
no need to shout about getting an oplock
Andrew Tridgell [Wed, 12 Aug 2009 05:19:42 +0000 (15:19 +1000)]
raise the debug level for a common message
when a client disconnects we expect this to happen, so don't print an
error each time
Andrew Tridgell [Wed, 12 Aug 2009 04:41:44 +0000 (14:41 +1000)]
Allow selection of the samba4 process model for 'make test'
To choose the process model, set the environment variable
SAMBA_PROCESS_MODEL to the desired model. This will allow us to enable
the standard process model for some machines in the build farm without
enabling it for all of them. I don't want to just enable it
universally as I am concerned with total memory using during some of
the tests.
Andrew Tridgell [Wed, 12 Aug 2009 04:38:55 +0000 (14:38 +1000)]
print server log on stderr as well as to log file
I think we are missing some important messages from the server during
'make test' because we don't show the log file contents during
runs. This patch uses tee to put the log messages to stderr so we can
see any server messages associated with the test that caused them.
Andrew Bartlett [Wed, 12 Aug 2009 01:09:50 +0000 (11:09 +1000)]
s4:provision Allow provision-backend to not run slapd for 'make test'
As the version of OpenLDAP required for Samba4 is fairly new, we don't
want to make it a requirement before this python code is run in 'make
test'.
As such, skip over the actual starting of slapd, but check the rest
runs alright (which still validates syntax and other modules).
Andrew Bartlett
Andrew Bartlett [Mon, 10 Aug 2009 12:01:28 +0000 (22:01 +1000)]
s4:selftest Don't start the slapd for the provision, only for the run
The provision-backend script now starts slapd for us
Andrew Bartlett
Andrew Bartlett [Mon, 10 Aug 2009 11:51:08 +0000 (21:51 +1000)]
s4:selftest Make OpenLDAP guess it's own modules from now on
In the releases of OpenLDAP we require (2.4.17) it can guess this much
itself, so no need for us to do it.
Andrew Bartlett
Andrew Bartlett [Mon, 10 Aug 2009 11:46:20 +0000 (21:46 +1000)]
s4:provision Make the --ol-slapd paramter take the full path to slapd
Andrew Bartlett [Mon, 10 Aug 2009 11:43:11 +0000 (21:43 +1000)]
s4:provision Assume the OpenLDAP backend can find it's own modules
Oliver Liebel [Sun, 9 Aug 2009 23:45:01 +0000 (09:45 +1000)]
s4:provision Rework and further automate setup of OpenLDAP backend
heres the summary of all changes/extensions:
- Andrew Bartlett's patch to generate indext
- Howard Chu's idea to use nosync on the DB included, but made optional
- slaptest-path is not needed any more (slapd -Ttest is used instead)
and is therefore removed. slapd-path is now recommended when
openldap-backend is chosen.
its also used for olc-conversion
- slapd-detection is now always done by ldapsearch (ldb module),
looking anonymous for objectClass: OpenLDAProotDSE via our ldapi_uri.
- if ldapsearch was not successfull, (no slapd listening on our socket)
slapd is
started via special generated slapdcommand_prov (ldapi_uri only)
- slapd-"provision-process" startup is done via pythons subprocess.
- the slapd-provision-pid is stored under paths.ldapdir/slapd_provision_pid.
- after provision-backend is finished:
--- slapd.pid is compared with our stored slapd_provision_pid.
if the are unique, slapd.pid will be read out, and the
slapd "provison"-process will be shut down.
--- proper slapd-shutdown is verified again with ldb-search -> ldapi_uri
-> rootDSE.
--- if the pids are different or one of the pid-files is missing, slapd
will not be shut down,
instead an error message is displayed to locate slapd manually
--- extended help-messages (relevant to slapd) are always displayed,
e.g. the commandline with which slapd has to be started when everythings
finished
(slapd-commandline is stored under paths.ldapdir/slapd_command_file.txt))
- upgraded the content of the mini-howto (howto-ol-backend-s4.txt)
Michael Adam [Tue, 11 Aug 2009 21:35:48 +0000 (23:35 +0200)]
s3:smbcacls: forbid change of debug level from config file
Michael
Michael Adam [Tue, 11 Aug 2009 12:28:31 +0000 (14:28 +0200)]
s3: refomat definitions of some generic access rights for better readability
Michael
Stefan Metzmacher [Fri, 1 May 2009 16:18:31 +0000 (18:18 +0200)]
selftest: configure "ncalrpc dir" for the client
Some torture tests will need this soon.
metze
Stefan Metzmacher [Fri, 1 May 2009 16:17:55 +0000 (18:17 +0200)]
selftest: fix typo lock => lockdir
metze
Stefan Metzmacher [Tue, 11 Aug 2009 11:50:16 +0000 (13:50 +0200)]
s3:winbindd: raise the timeout for lsa_Lookup*() calls from 10 to 35 seconds.
metze
Andrew Bartlett [Tue, 11 Aug 2009 08:20:39 +0000 (18:20 +1000)]
s4:torture Add test for the NTP signd server
This is used by at patch to the NTP project to supply authenticated
time as required by MS-SNTP. (ie, to keep windows clients in time sync
in the domain)
Andrew Bartlett
Kai Blin [Tue, 11 Aug 2009 07:33:51 +0000 (09:33 +0200)]
i18n: Update s3 net German translation.
Kai Blin [Tue, 11 Aug 2009 07:01:10 +0000 (09:01 +0200)]
s3 net: i18n support for net utility functions
Kai Blin [Tue, 11 Aug 2009 06:57:01 +0000 (08:57 +0200)]
s3 net: i18n support for net usershare
Kai Blin [Tue, 11 Aug 2009 06:40:48 +0000 (08:40 +0200)]
s3 net: i18n support for net user
Kai Blin [Tue, 11 Aug 2009 06:38:42 +0000 (08:38 +0200)]
s3 net: i18n support for net time
Kai Blin [Tue, 11 Aug 2009 06:35:46 +0000 (08:35 +0200)]
s3 net: i18n support for net status
Kai Blin [Tue, 11 Aug 2009 06:32:10 +0000 (08:32 +0200)]
s3 net: i18n support for net share
Kai Blin [Tue, 11 Aug 2009 06:31:04 +0000 (08:31 +0200)]
s3 net: i18n support for net sam
Kai Blin [Mon, 10 Aug 2009 18:38:33 +0000 (20:38 +0200)]
s3 net: i18n support for net rpc shell
Kai Blin [Mon, 10 Aug 2009 18:23:41 +0000 (20:23 +0200)]
s3 net: i18n support for net rpc service
Kai Blin [Mon, 10 Aug 2009 17:54:27 +0000 (19:54 +0200)]
s3 net: i18n support for net rpc samsync
Jeremy Allison [Mon, 10 Aug 2009 23:39:13 +0000 (16:39 -0700)]
Ensure the fsp->fsp_name stat_ex struct is always
up to date after the open.
Jeremy.
Jeremy Allison [Mon, 10 Aug 2009 22:07:53 +0000 (15:07 -0700)]
Refactor the use of create_time and change time to go
through functions. Will aid in making us pass RAW-SETFILEINFO.
Jeremy.
Kai Blin [Mon, 10 Aug 2009 16:52:24 +0000 (18:52 +0200)]
s3 net: i18n support for net rpc rights
Kai Blin [Mon, 10 Aug 2009 16:29:50 +0000 (18:29 +0200)]
s3 net: i18n support net rpc registry
Kai Blin [Mon, 10 Aug 2009 16:24:57 +0000 (18:24 +0200)]
s3 net: i18n support for net rpc printer
Kai Blin [Sun, 9 Aug 2009 14:57:51 +0000 (16:57 +0200)]
s3 net: i18n support for net rpc join
Günther Deschner [Mon, 10 Aug 2009 09:25:52 +0000 (11:25 +0200)]
s3-spoolss: remove device mode defines from nt_printing.h.
Guenther
Günther Deschner [Mon, 10 Aug 2009 09:25:09 +0000 (11:25 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 10 Aug 2009 09:24:40 +0000 (11:24 +0200)]
spoolss: fill in more details of the spoolss_DeviceMode.
Guenther
Volker Lendecke [Sat, 8 Aug 2009 11:43:41 +0000 (13:43 +0200)]
Implement db_rbt_traverse
Volker Lendecke [Sat, 8 Aug 2009 11:42:55 +0000 (13:42 +0200)]
Make wbinfo also print the members when querying a group
Matt Kraai [Fri, 7 Aug 2009 20:58:52 +0000 (13:58 -0700)]
libreplace: set SONAMEFLAG to "-Wl,-soname=" on QNX
Stefan Metzmacher [Sat, 8 Aug 2009 08:47:11 +0000 (10:47 +0200)]
s3:smbd: convert '\\' into '/' in SMB2 Create
metze
Stefan Metzmacher [Fri, 7 Aug 2009 13:21:07 +0000 (15:21 +0200)]
s3:smbd: rename conn => sconn for smbd_server_connection structs
This should avoid confusion between smbd_server_connection
and connection_struct variables.
metze
Alexander Bokovoy [Sat, 8 Aug 2009 05:07:24 +0000 (08:07 +0300)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Alexander Bokovoy [Sat, 8 Aug 2009 05:02:52 +0000 (08:02 +0300)]
Pass absolute file paths to Inkscape when transforming .svg files
Some recent versions of Inkscape (0.47 or around) have bug when export file name
is treated as relative against the directory of original .svg if it wasn't specified
as an absolute path. Fix it by always using absolute paths during conversion.
Jeremy Allison [Fri, 7 Aug 2009 19:38:31 +0000 (12:38 -0700)]
Move the checks for null timestamps down below the VFS_NTIMES
layer (as it's done in onefs). This simplifies greatly the
code in smb_set_file_time() w.r.t. changenotify messages.
Jeremy.
Jeremy Allison [Fri, 7 Aug 2009 17:19:20 +0000 (10:19 -0700)]
Correctly send out notify messages for timestamp changes.
"change time" has no notify message, so don't send anything
out when we change it. Use FILE_NOTIFY_CHANGE_CREATION correctly
when changing the create time.
Jeremy.
Matthias Dieter Wallnöfer [Wed, 5 Aug 2009 21:18:47 +0000 (23:18 +0200)]
s4: Add a new script for setting password properties for a domain in a easier way
Stefan Metzmacher [Fri, 7 Aug 2009 12:12:19 +0000 (14:12 +0200)]
s4:libcli/smb2: move SMB2_GETINFO_* flags into smb2_constants.h
metze
Stefan Metzmacher [Fri, 7 Aug 2009 12:11:11 +0000 (14:11 +0200)]
s4:libcli/smb2: remove unused and redundant SMB2 security flags
metze
Stefan Metzmacher [Fri, 7 Aug 2009 12:09:42 +0000 (14:09 +0200)]
s4:libcli: move SMB2 Find constants to smb2_constants.h
metze
Stefan Metzmacher [Fri, 7 Aug 2009 12:55:37 +0000 (14:55 +0200)]
s4:libcli/raw: we don't need to include "smb.h" explicit
metze
Stefan Metzmacher [Fri, 7 Aug 2009 12:55:01 +0000 (14:55 +0200)]
s4:libcli/raw: also include smb2_constants.h into interfaces.h
metze
Stefan Metzmacher [Thu, 6 Aug 2009 10:15:51 +0000 (12:15 +0200)]
s3:smbd: split the dir entry marshalling into smbd_marshall_dir_entry()
So that we can reuse it for SMB2 Find.
metze
Stefan Metzmacher [Thu, 6 Aug 2009 10:15:51 +0000 (12:15 +0200)]
s3:smbd: move dptr globals into struct smbd_server_connection
metze
Stefan Metzmacher [Fri, 7 Aug 2009 07:31:45 +0000 (09:31 +0200)]
s3:smbd: remove dirptr and dirpath from connection_struct
They're both only used in the context of a function,
so we can make them stack variables.
metze