Anders Broman [Sat, 28 Aug 2010 19:27:19 +0000 (19:27 -0000)]
Doxygen changes.
svn path=/trunk/; revision=33981
Sake Blok [Sat, 28 Aug 2010 11:05:51 +0000 (11:05 -0000)]
As mentioned on the users-mailinglist[1], it could be useful to have groups read access to the ringbuffer that dumpcap creates. That way, a group of people can access the capture files without having to use root access.
[1] http://www.wireshark.org/lists/wireshark-users/201008/msg00235.html
svn path=/trunk/; revision=33978
Sake Blok [Sat, 28 Aug 2010 09:44:18 +0000 (09:44 -0000)]
We change the owner and group of the first file, so we also want to change owner and group of the rest of the files in the ringbuffer.
svn path=/trunk/; revision=33977
Gerasimos Dimitriadis [Fri, 27 Aug 2010 21:30:12 +0000 (21:30 -0000)]
Support for eMLPP Priority IE in BSSMAP
svn path=/trunk/; revision=33971
Guy Harris [Fri, 27 Aug 2010 21:28:24 +0000 (21:28 -0000)]
Update some links.
svn path=/trunk/; revision=33969
Stig Bjørlykke [Fri, 27 Aug 2010 21:15:39 +0000 (21:15 -0000)]
Added Owen Kirby as author
svn path=/trunk/; revision=33965
Guy Harris [Fri, 27 Aug 2010 21:13:26 +0000 (21:13 -0000)]
Allow Dissect As... to select the Ethernet-without-FCS dissector for a
given UDP port; this is to handle the output for the Cisco CMTS "cable
intercept" command - it encapsulates Ethernet frames in UDP packets, but
the UDP port is user-defined.
svn path=/trunk/; revision=33964
Gerasimos Dimitriadis [Fri, 27 Aug 2010 21:09:05 +0000 (21:09 -0000)]
MNC, SANC, ISPC lists updated up to OB 960
svn path=/trunk/; revision=33963
Stig Bjørlykke [Fri, 27 Aug 2010 21:05:02 +0000 (21:05 -0000)]
From Owen Kirby via bug 5149:
Added a new dissector for SCoP.
svn path=/trunk/; revision=33962
Stig Bjørlykke [Fri, 27 Aug 2010 20:54:21 +0000 (20:54 -0000)]
From Frank Lahm via bug 5136:
Correct volume flags for FPGetSrvrParms.
svn path=/trunk/; revision=33961
Gerald Combs [Fri, 27 Aug 2010 19:52:17 +0000 (19:52 -0000)]
Display Teredo encapsulated IPv4 server and client addresses.
svn path=/trunk/; revision=33959
Gerald Combs [Fri, 27 Aug 2010 19:24:44 +0000 (19:24 -0000)]
Forward-port r33953.
Move the SetDllDirectory calls to ws_init_dll_search_path. If
SetDllDirectory fails, pass the Wireshark program path to
SetCurrentDirectory.
svn path=/trunk/; revision=33958
Jeff Morriss [Fri, 27 Aug 2010 18:36:01 +0000 (18:36 -0000)]
From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5150 : remove Makefile.in from the asn1 directories when doing a maintainer-clean
svn path=/trunk/; revision=33955
Stig Bjørlykke [Fri, 27 Aug 2010 17:18:28 +0000 (17:18 -0000)]
From Christian Durrer via bug 5155:
Added a new dissector for Ether-S-I/O protocol.
svn path=/trunk/; revision=33954
Stig Bjørlykke [Fri, 27 Aug 2010 16:30:38 +0000 (16:30 -0000)]
From Matthieu Lochegnies via bug 5153:
Show multiples DRDA commands from the same frame.
svn path=/trunk/; revision=33952
Bill Meier [Fri, 27 Aug 2010 15:01:28 +0000 (15:01 -0000)]
(Trivial) Fix a typo
svn path=/trunk/; revision=33951
Martin Mathieson [Fri, 27 Aug 2010 13:54:05 +0000 (13:54 -0000)]
Allow 3GPP release info to be displayed.
svn path=/trunk/; revision=33950
Stig Bjørlykke [Fri, 27 Aug 2010 11:55:14 +0000 (11:55 -0000)]
Added a check for constructed octet string to avoid a loop.
This fixes bug 5154.
svn path=/trunk/; revision=33949
Jaap Keuter [Fri, 27 Aug 2010 06:28:17 +0000 (06:28 -0000)]
Take in updates from the TLS registery.
svn path=/trunk/; revision=33948
Jaap Keuter [Fri, 27 Aug 2010 06:07:32 +0000 (06:07 -0000)]
Make wireshark-dev depend on the right automake.
svn path=/trunk/; revision=33947
Anders Broman [Fri, 27 Aug 2010 06:02:54 +0000 (06:02 -0000)]
From Kirill A. Korinskiy:
Enumerated is derived from the Integer32 AVP Base Format.
svn path=/trunk/; revision=33946
Bill Meier [Thu, 26 Aug 2010 23:40:27 +0000 (23:40 -0000)]
I suspect the changes to config.nmake committed in SVN #33942 were not intended.
Revert the changes (for now ?) so the Buildbot will run again.
svn path=/trunk/; revision=33945
Anders Broman [Thu, 26 Aug 2010 20:31:09 +0000 (20:31 -0000)]
Doxygen fixes.
svn path=/trunk/; revision=33942
Stig Bjørlykke [Thu, 26 Aug 2010 20:22:28 +0000 (20:22 -0000)]
Check input string in ps_clean_string().
This fixes bug 5148.
svn path=/trunk/; revision=33941
Anders Broman [Thu, 26 Aug 2010 19:40:57 +0000 (19:40 -0000)]
Fixed by running doxygen -u
svn path=/trunk/; revision=33939
Anders Broman [Thu, 26 Aug 2010 19:40:08 +0000 (19:40 -0000)]
Fix doxygen errors.
svn path=/trunk/; revision=33938
Stephen Fisher [Thu, 26 Aug 2010 18:06:56 +0000 (18:06 -0000)]
Show a text string of the Windows version (if Windows 2000 or higher.)
svn path=/trunk/; revision=33936
Gerald Combs [Thu, 26 Aug 2010 17:18:44 +0000 (17:18 -0000)]
Add a newline. Fixup whitespace.
svn path=/trunk/; revision=33933
Anders Broman [Thu, 26 Aug 2010 15:24:49 +0000 (15:24 -0000)]
Fix a number of doxygen directives.
svn path=/trunk/; revision=33930
Anders Broman [Thu, 26 Aug 2010 15:02:27 +0000 (15:02 -0000)]
Fix a number of doxygen directives.
svn path=/trunk/; revision=33929
Stig Bjørlykke [Thu, 26 Aug 2010 13:49:23 +0000 (13:49 -0000)]
From Juha Siltanen via bug 5144:
Added support for payload dissecting.
svn path=/trunk/; revision=33928
Anders Broman [Thu, 26 Aug 2010 07:12:03 +0000 (07:12 -0000)]
- Try to fix a couple of doxygen comments.
svn path=/trunk/; revision=33927
Anders Broman [Thu, 26 Aug 2010 06:46:30 +0000 (06:46 -0000)]
- Try to fix a couple of doxygen comments.
- whitspace changes.
svn path=/trunk/; revision=33926
Gerald Combs [Wed, 25 Aug 2010 22:41:26 +0000 (22:41 -0000)]
Move Windows-specific material inside an appropriate #ifdef.
svn path=/trunk/; revision=33925
Gerald Combs [Wed, 25 Aug 2010 20:30:59 +0000 (20:30 -0000)]
Add ws_load_library and ws_module_open, which respectively call
LoadLibrary and g_module_open only for the program directory and system
directory on Windows. Use them to replace a bunch of LoadLibrary and
g_module_open calls. Use the extension ".dll" for all the DLLs that we
load. Add comments about DLL loading in Python.
svn path=/trunk/; revision=33924
Jeff Morriss [Wed, 25 Aug 2010 18:20:56 +0000 (18:20 -0000)]
Update the WinPcap developer's pack to 4.1.2. Update PCAP_VERSION to 4.1.2 on Win64 too (for consistency more than anything I think).
svn path=/trunk/; revision=33923
Jeff Morriss [Wed, 25 Aug 2010 15:28:26 +0000 (15:28 -0000)]
Use PCAP_VERSION (from config.nmake) instead of hard coding the WinPcap version.
svn path=/trunk/; revision=33922
Jeff Morriss [Wed, 25 Aug 2010 15:27:14 +0000 (15:27 -0000)]
Change PCAP_VERSION to 4.1.2. Hopefully this will cause the U3/PortableApps builds to pick up WinPcap again.
svn path=/trunk/; revision=33921
Tomas Kukosa [Wed, 25 Aug 2010 14:10:58 +0000 (14:10 -0000)]
Fix wrong length of CSeq Method parameter
svn path=/trunk/; revision=33920
Martin Mathieson [Wed, 25 Aug 2010 13:27:27 +0000 (13:27 -0000)]
Let DCT2000 tree extend to end of ipprim or sctpprim bytes.
svn path=/trunk/; revision=33919
Martin Mathieson [Wed, 25 Aug 2010 13:01:00 +0000 (13:01 -0000)]
Show (again?) MAC-d PDUs inside MAC-es PDUs.
svn path=/trunk/; revision=33918
Gerald Combs [Wed, 25 Aug 2010 00:20:50 +0000 (00:20 -0000)]
Fix !Windows compilation.
svn path=/trunk/; revision=33917
Gerald Combs [Tue, 24 Aug 2010 23:39:29 +0000 (23:39 -0000)]
Partial fix for bug 5133. On Windows, call SetDllDirectory at startup if
it's present in Wireshark and dumpcap. This takes care of the airpcap.dll
PoC but we need to load wpcap.dll from a full path. We might want to
call SetDllDirectory from our other executables as well.
svn path=/trunk/; revision=33916
Anders Broman [Tue, 24 Aug 2010 20:03:33 +0000 (20:03 -0000)]
Make the expert filter popup behave as in filter_utils.
svn path=/trunk/; revision=33915
Stig Bjørlykke [Tue, 24 Aug 2010 15:47:10 +0000 (15:47 -0000)]
Display content entry (with length) in tree.
svn path=/trunk/; revision=33914
Stig Bjørlykke [Tue, 24 Aug 2010 15:46:33 +0000 (15:46 -0000)]
Fix modifier in .cnf file.
svn path=/trunk/; revision=33913
Stig Bjørlykke [Tue, 24 Aug 2010 15:43:32 +0000 (15:43 -0000)]
Rewrote to fetch content_tvb from dissect_ber_octet_string().
Display eContent entry (with length) in tree.
svn path=/trunk/; revision=33912
Stig Bjørlykke [Tue, 24 Aug 2010 15:09:11 +0000 (15:09 -0000)]
Display octet string fragments for RTSE segment data.
svn path=/trunk/; revision=33911
Stig Bjørlykke [Tue, 24 Aug 2010 15:08:07 +0000 (15:08 -0000)]
Display constructed octet strings with correct hf_id.
Show octet string fragments as for reassembly.
svn path=/trunk/; revision=33910
Bill Meier [Tue, 24 Aug 2010 14:59:11 +0000 (14:59 -0000)]
Fix issue which causes daintree-sna frames to be rejected with "capture length > packet length".
This fix adds back two lines of code removed in SVN #33678.
"Define WTAP_ENCAP_IEEE802_15_4_NOFCS, for use in file formats that don't
include the FCS, and use it for the Daintree SNA file format. [...]"
This fix just restores the discarding of two end-of-frame "pad" bytes as each frame is read
from the capture file; This seems to me to be the correct behaviour.
svn path=/trunk/; revision=33909
Stig Bjørlykke [Tue, 24 Aug 2010 11:36:10 +0000 (11:36 -0000)]
Indicate abort and abort-reason in info column.
svn path=/trunk/; revision=33908
Anders Broman [Tue, 24 Aug 2010 07:44:36 +0000 (07:44 -0000)]
Add Id.
svn path=/trunk/; revision=33907
Anders Broman [Tue, 24 Aug 2010 06:15:40 +0000 (06:15 -0000)]
From Gregor Beck:
ERROR:capture.c:141:capture_start: assertion failed: (capture_opts->state == CAPTURE_STOPPED)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5126
svn path=/trunk/; revision=33906
Tomas Kukosa [Tue, 24 Aug 2010 05:53:17 +0000 (05:53 -0000)]
- fix using hex values as constraint
- avoid crash if unknown type is used in type assignment
svn path=/trunk/; revision=33905
Anders Broman [Tue, 24 Aug 2010 05:44:55 +0000 (05:44 -0000)]
From Hamish Moffatt:
daintree-sna.c doesn't initialise capture_file snapshot_length.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5128
svn path=/trunk/; revision=33904
Anders Broman [Tue, 24 Aug 2010 05:38:49 +0000 (05:38 -0000)]
From Christian Durrer:
Not all Ether-S-Bus telegrams are recognized and displayed correctly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5123
svn path=/trunk/; revision=33903
Anders Broman [Tue, 24 Aug 2010 05:11:37 +0000 (05:11 -0000)]
Change the wording in the menu.
svn path=/trunk/; revision=33902
Bill Meier [Tue, 24 Aug 2010 00:25:50 +0000 (00:25 -0000)]
Use consistent indentation;
Fix a few @param comments.
svn path=/trunk/; revision=33901
Gerald Combs [Tue, 24 Aug 2010 00:24:44 +0000 (00:24 -0000)]
Display ISATAP encapsulated IPv4 addresses.
svn path=/trunk/; revision=33900
Stephen Fisher [Mon, 23 Aug 2010 23:09:32 +0000 (23:09 -0000)]
The ARP hardware type and operation code are listed with the IANA in decimal notation, not hex.
svn path=/trunk/; revision=33898
Bill Meier [Mon, 23 Aug 2010 19:29:08 +0000 (19:29 -0000)]
(Minor) Cleanup signal callbak signatures and related:
- Don't mark callback arg as _U_ if actually used (and vice-versa);
- Use Null as user_data in g_signal_callback if unused in callback;
- Use correct signature for certain event callbacks.
svn path=/trunk/; revision=33895
Jaap Keuter [Mon, 23 Aug 2010 18:16:22 +0000 (18:16 -0000)]
On request from Albert Chin:
Update libtoolize files
svn path=/trunk/; revision=33894
Bill Meier [Mon, 23 Aug 2010 16:48:42 +0000 (16:48 -0000)]
[Trivial] Use g_signal_connect() instead of g_signal_connect_data().
svn path=/trunk/; revision=33893
Bill Meier [Mon, 23 Aug 2010 16:39:52 +0000 (16:39 -0000)]
(Trivial) Use consistent indentation.
svn path=/trunk/; revision=33892
Jeff Morriss [Mon, 23 Aug 2010 16:18:06 +0000 (16:18 -0000)]
Remove #if 0'd out code (dfilter_combo_add_empty()).
svn path=/trunk/; revision=33891
Bill Meier [Mon, 23 Aug 2010 15:58:48 +0000 (15:58 -0000)]
(Trivial/Cosmetic) Fix signatures of some signal callback functions;
Also:Add some missing G_CALLBACKs (even in commented out code)
svn path=/trunk/; revision=33890
Bill Meier [Mon, 23 Aug 2010 14:36:01 +0000 (14:36 -0000)]
(Trivial) Whitespace cleanup.
svn path=/trunk/; revision=33889
Bill Meier [Mon, 23 Aug 2010 14:08:35 +0000 (14:08 -0000)]
new_packet_list_column_button_pressed_cb(): return gboolean (not void): it's an event callback;
Note:
the original code:
static void new_packet_list_column_button_pressed_cb() {
...
packet_list_popup(...);
}
the revised code:
static gboolean new_packet_list_column_button_pressed_cb() {
...
return packet_list_popup(...);
}
My guess is that the original code happened to work
on some?/all? supported platforms depending upon the actual
details of the generated calling_sequence/return code.
---------------
Also:
- new_packet_list_column_button_pressed_cb(): 'path' arg is unused;
- new_packet_list_double_click_cb(): user_data arg is unused so
don't supply same in the g_signal_connect.
svn path=/trunk/; revision=33888
Stig Bjørlykke [Mon, 23 Aug 2010 09:17:03 +0000 (09:17 -0000)]
Fix for attribute boolean, from bug 5127.
svn path=/trunk/; revision=33887
Gerald Combs [Sun, 22 Aug 2010 15:03:30 +0000 (15:03 -0000)]
[Automatic manuf and enterprise-numbers update for 2010-08-22]
svn path=/trunk/; revision=33881
Gerald Combs [Sun, 22 Aug 2010 00:41:06 +0000 (00:41 -0000)]
Add !ENDIF if needed.
svn path=/trunk/; revision=33880
Gerald Combs [Sat, 21 Aug 2010 17:45:03 +0000 (17:45 -0000)]
Add a "summary in tree" option similar to v4.
svn path=/trunk/; revision=33878
Gerald Combs [Sat, 21 Aug 2010 16:38:13 +0000 (16:38 -0000)]
Initialize a variable before we try to free it.
svn path=/trunk/; revision=33877
Bill Meier [Sat, 21 Aug 2010 13:48:52 +0000 (13:48 -0000)]
New packet list is no longer experimental.
svn path=/trunk/; revision=33876
Bill Meier [Sat, 21 Aug 2010 13:21:35 +0000 (13:21 -0000)]
Use GType instead of deprecated GtkType
svn path=/trunk/; revision=33875
Jeff Morriss [Sat, 21 Aug 2010 04:26:26 +0000 (04:26 -0000)]
Add some code to prefs_cleanup() to free (most of the) memory associated with the preferences. This only happens during shutdown so it's not fixing a memory leak, but it makes me more comfortable to know where the preferences memory is freed.
svn path=/trunk/; revision=33874
Jeff Morriss [Sat, 21 Aug 2010 03:54:55 +0000 (03:54 -0000)]
Document what prefs_register_string_preference() does with your value pointer.
svn path=/trunk/; revision=33873
Jeff Morriss [Sat, 21 Aug 2010 03:44:36 +0000 (03:44 -0000)]
prefs_register_string_preference() overwrites the given value pointer with a copy of the string. Since the string this dissector passes in is mallocated, keep a pointer to it and then free it after the pointer has been overwritten.
svn path=/trunk/; revision=33872
Jeff Morriss [Sat, 21 Aug 2010 03:31:30 +0000 (03:31 -0000)]
Remove duplicate definition of COL_MAX_LEN and COL_MAX_INFO_LEN: apparently no one needs them in this file (probably because they're marked as "don't use"). Now they are only defined in column_info.h .
svn path=/trunk/; revision=33871
Gerald Combs [Sat, 21 Aug 2010 00:19:32 +0000 (00:19 -0000)]
If we have something that looks like a stateless autoconfiguration
address, add the corresponding MAC address to the tree.
svn path=/trunk/; revision=33870
Jeff Morriss [Fri, 20 Aug 2010 22:15:07 +0000 (22:15 -0000)]
Free the err_str from capture_interface_list() even if the error isn't CANT_GET_INTERFACE_LIST.
svn path=/trunk/; revision=33866
Jeff Morriss [Fri, 20 Aug 2010 22:13:46 +0000 (22:13 -0000)]
When freeing the fileset entries, free the entry itself too.
svn path=/trunk/; revision=33865
Jeff Morriss [Fri, 20 Aug 2010 22:12:55 +0000 (22:12 -0000)]
Don't leak the memory used by the original title when we're appending the version to it.
svn path=/trunk/; revision=33864
Jeff Morriss [Fri, 20 Aug 2010 21:56:52 +0000 (21:56 -0000)]
From Turney Cal as a followup to rev 33841 and bug 5038:
I tested your update ("wireshark -r foo.pcap" from a cmd window) and
found that it did not use the current folder for the next Open dialog
and didn't save the folder in recent. The attached patch prepends the
filename with the current folder.
From me: don't leak memory when doing it.
svn path=/trunk/; revision=33863
Jeff Morriss [Fri, 20 Aug 2010 19:41:35 +0000 (19:41 -0000)]
From Kirill A. Korinskiy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5122:
I try use diameters XML files as sources for my XSL transform by xslt and found
some typos. I attach patch for fixing it.
svn path=/trunk/; revision=33862
Anders Broman [Fri, 20 Aug 2010 14:19:06 +0000 (14:19 -0000)]
Switch wlan_stat_dlg to use GUIManager step 2.
svn path=/trunk/; revision=33860
Stig Bjørlykke [Fri, 20 Aug 2010 12:05:44 +0000 (12:05 -0000)]
Use defined functions.
svn path=/trunk/; revision=33859
Anders Broman [Fri, 20 Aug 2010 11:57:20 +0000 (11:57 -0000)]
Remove a comment.
svn path=/trunk/; revision=33858
Anders Broman [Fri, 20 Aug 2010 11:56:44 +0000 (11:56 -0000)]
Fix indentation.
svn path=/trunk/; revision=33857
Anders Broman [Fri, 20 Aug 2010 11:54:18 +0000 (11:54 -0000)]
Switch wlan_stat_dlg to use GUIManager step 1.
svn path=/trunk/; revision=33856
Bill Meier [Thu, 19 Aug 2010 22:04:37 +0000 (22:04 -0000)]
Minor cleanup of rtp graph:
- Display current value in combo boxes (pixels_per_tick, etc) to always
match actual values being used to create graph;
- yscale combo box entries:
show values >= 1 sec as sec (not s000 ms);
- Determine max yscale label width properly as the largest of the
top or middle label lengths;
- Cleanup some indentation.
svn path=/trunk/; revision=33855
Bill Meier [Thu, 19 Aug 2010 21:51:35 +0000 (21:51 -0000)]
Fix two bugs related to use of the graph Y-Axis Scale combo-box:
1. Incorrect specification of units: Should be ms & s not us and ms;
Bug introduced in SVN #33834.
2. Selecting 50ms as the yscale actually used 50us as the scale;
Bug introduced in SVN #30543.
svn path=/trunk/; revision=33854
Stig Bjørlykke [Thu, 19 Aug 2010 20:11:28 +0000 (20:11 -0000)]
Fixed the popup menu table:
- Added missing NULL initializers
- Fixed some typos in the menu items
svn path=/trunk/; revision=33853
Anders Broman [Thu, 19 Aug 2010 19:05:56 +0000 (19:05 -0000)]
Use better naming.
svn path=/trunk/; revision=33852
Anders Broman [Thu, 19 Aug 2010 19:05:11 +0000 (19:05 -0000)]
Switch over to use the GUIManager(can be turned of by a #define).
svn path=/trunk/; revision=33851
Bill Meier [Thu, 19 Aug 2010 15:22:03 +0000 (15:22 -0000)]
Fix gcc compile errors....
svn path=/trunk/; revision=33850
Bill Meier [Thu, 19 Aug 2010 15:02:23 +0000 (15:02 -0000)]
Use proper signatures for event callback functions:
EG: Non-event signal callback functions shouldn't
be directly used as event callback functions.
Replace use of deprecated "GtkSignalFunc";
Whitespace cleanup.
svn path=/trunk/; revision=33849
Jeff Morriss [Thu, 19 Aug 2010 02:17:01 +0000 (02:17 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5114 (infinite loop in
bootp dissector when dissecting packetcable MTA capabilities).
Limit the tlv_len to G_MAXUINT16 to prevent an integer overflow from causing us to
increment the working offset by 0 (thus causing us to loop).
svn path=/trunk/; revision=33846
Guy Harris [Thu, 19 Aug 2010 00:14:07 +0000 (00:14 -0000)]
Add placeholder items for ^Z as Edit->Undo, shift-^Z as Edit->Redo,
and ^A as Edit->Select All.
Add more details about implementing Undo/Redo/Cut/Copy/Paste/Select All
in the comment for the placeholder items.
svn path=/trunk/; revision=33845
Bill Meier [Thu, 19 Aug 2010 00:09:56 +0000 (00:09 -0000)]
Use correct signature for "button-press-event" callback function;
Whitespace cleanup;
Use gboolean as appropriate;
svn path=/trunk/; revision=33844