Andrew Tridgell [Sun, 25 Apr 2010 11:00:44 +0000 (21:00 +1000)]
build: a library is only empty if it has no deps
Andrew Tridgell [Sun, 25 Apr 2010 02:58:52 +0000 (12:58 +1000)]
build: use option_group() not add_option_group()
option_group() ensures we don't end up with duplicate groups
Andrew Tridgell [Sun, 25 Apr 2010 02:41:41 +0000 (12:41 +1000)]
build: cope with duplicates in source lists
Volker Lendecke [Sun, 25 Apr 2010 09:42:44 +0000 (11:42 +0200)]
s3: async_domain_request is no longer used
Volker Lendecke [Sun, 25 Apr 2010 09:40:30 +0000 (11:40 +0200)]
s3: Convert add_trusted_domains() to wb_domain_request_send()
Volker Lendecke [Sun, 25 Apr 2010 08:36:58 +0000 (10:36 +0200)]
s3: Simplify trustdom_state
Don't store information explicitly as boolean flags that can be easily
retrieved from the domain when it's actually needed.
Volker Lendecke [Sun, 25 Apr 2010 08:25:55 +0000 (10:25 +0200)]
s3: Make "struct trustdom_state" its own talloc context
Volker Lendecke [Sun, 25 Apr 2010 08:15:43 +0000 (10:15 +0200)]
libwbclient: Talloc is no longer used
Stefan Metzmacher [Sat, 24 Apr 2010 17:36:01 +0000 (19:36 +0200)]
Revert "tsocket: not all systems have IPV6_V6ONLY"
This reverts commit
63fc3978089df403d7e63462593784ff3d05e6e7.
We now don't support IPv6 when IPV6_V6ONLY isn't available,
as we rely on the behavior.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 11:07:50 +0000 (13:07 +0200)]
lib/replace/wscript: make sure IPV6_V6ONLY is available for IPv6 support
We really on IPV6_V6ONLY being supported.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 11:07:50 +0000 (13:07 +0200)]
lib/replace: make sure IPV6_V6ONLY is available for IPv6 support
We really on IPV6_V6ONLY being supported.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 17:28:48 +0000 (19:28 +0200)]
lib/replace/wscript: add replacement for IPV6_V6ONLY on linux systems with broken headers
This is needed on SLES8.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 17:02:22 +0000 (19:02 +0200)]
lib/replace: add replacement for IPV6_V6ONLY on linux systems with broken headers
This is needed on SLES8.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 16:10:37 +0000 (18:10 +0200)]
buildtools/wafsamba: inline defines during configure into the tests
There 2 reasons for this change:
- This is how autoconf tests work and it makes config.log much more useful
- The waf c preprocessor ignored changes in bin/default/__confdefs.h when using
waf configure -C, because is outside of the configure tests project path
and handled like a system header.
Many thanks to ita for pointing out the fix.
metze
Stefan Metzmacher [Sat, 24 Apr 2010 18:02:44 +0000 (20:02 +0200)]
buildtools/wafsamba: make sure we create bin/default/ before trying to create symlinks in it
metze
Matthieu Patou [Fri, 23 Apr 2010 13:27:05 +0000 (17:27 +0400)]
s4 dns: Allow to specify static grant entries to be added to the dynamicaly generated named.conf.update
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Tim Potter [Sat, 24 Apr 2010 01:04:32 +0000 (11:04 +1000)]
s4-smbd: Fix compiler warning in prefork smbd.
My first patch in a while...
Tim.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Fri, 23 Apr 2010 06:11:44 +0000 (08:11 +0200)]
lib/zlib/wscript: fix system zlib detection
metze
Volker Lendecke [Sat, 24 Apr 2010 10:40:10 +0000 (12:40 +0200)]
Revert "nsswitch: Fix a memleak in wbinfo"
This reverts commit
a97f2a0a9c0f1c148a0152202296bb078103b40c.
This was not a memleak, it was a valgrind false positive. We store "details" in
a static.
Volker Lendecke [Sat, 24 Apr 2010 09:11:45 +0000 (11:11 +0200)]
s3: sendto_domain() is lo longer used
Volker Lendecke [Sat, 24 Apr 2010 08:49:06 +0000 (10:49 +0200)]
s3: Simplify (bool != True) to !bool
Jeremy Allison [Sat, 24 Apr 2010 07:29:41 +0000 (00:29 -0700)]
Implement oplocks within SMB2. Plumb into the existing SMB1 oplock system.
Seems to work but needs more tests (to be added).
Jeremy.
Jeremy Allison [Fri, 23 Apr 2010 22:35:34 +0000 (15:35 -0700)]
When sending the initial async response, this is never part of a chain.
Get the reply flags correct.
Jeremy.
Jeremy Allison [Fri, 23 Apr 2010 22:34:58 +0000 (15:34 -0700)]
Don't free the entire tevent_req on cancel, only the part we need (the immediate event).
Jeremy.
Volker Lendecke [Fri, 23 Apr 2010 17:46:03 +0000 (19:46 +0200)]
libwbclient: Test WBC_CHANGE_PASSWORD_LEVEL_RESPONSE
Volker Lendecke [Fri, 23 Apr 2010 17:44:05 +0000 (19:44 +0200)]
s3: Allow pdb password change using WINBINDD_PAM_CHNG_PSWD_AUTH_CRAP
Volker Lendecke [Fri, 23 Apr 2010 17:42:33 +0000 (19:42 +0200)]
s3: init_dc_connection() can't init for internal domains
This fixes a crash in winbindd_dual_pam_chng_pswd_auth_crap when given
global_sam_name() in the domain field
Volker Lendecke [Fri, 23 Apr 2010 17:41:29 +0000 (19:41 +0200)]
libwbclient: Actually copy something in wbcChangeUserPasswordEx
The length argument for memcpy was initialized to 0 and not initialized
Volker Lendecke [Tue, 20 Apr 2010 18:37:35 +0000 (20:37 +0200)]
s3: replace some data_blob_talloc by data_blob_const
Volker Lendecke [Tue, 20 Apr 2010 14:07:13 +0000 (16:07 +0200)]
libwbclient: Remove some pointless BAIL_ON_WBC_ERROR macro calls
Volker Lendecke [Tue, 20 Apr 2010 09:11:19 +0000 (11:11 +0200)]
s3: Convert WINBINDD_PAM_CHNG_PSWD_AUTH_CRAP to the new async API
Simo Sorce [Fri, 23 Apr 2010 21:26:33 +0000 (14:26 -0700)]
s3-smbd: group print relate data in own structure
Jeremy Allison [Fri, 23 Apr 2010 20:10:15 +0000 (13:10 -0700)]
Allow smb2 create requests to be cancelled.
Jeremy.
Ira Cooper [Fri, 23 Apr 2010 17:55:46 +0000 (10:55 -0700)]
Fix bug #7384 - dptr_Close has a bitmap leak.
s3: Fix to dptr_Close
This fixes a bitmap "leak" in dptr_Close by making it use the same internal
routines the rest of the code does.
Jeremy Allison [Fri, 23 Apr 2010 17:53:44 +0000 (10:53 -0700)]
At simo's request return struct tevent_req *treq -> treq. For consistency :-(.
Jeremy Allison [Fri, 23 Apr 2010 17:29:48 +0000 (10:29 -0700)]
Rename - no functional change. Stop all variables being called "req".
tevent_req -> treq
struct smb_request -> smb1req
struct smbd_smb2_request -> smb2req
Jeremy.
Andreas Schneider [Wed, 21 Apr 2010 15:13:02 +0000 (17:13 +0200)]
s3-spoolss: Added a winreg_get_printer function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 21 Apr 2010 10:56:39 +0000 (12:56 +0200)]
s3-spoolss: Added a winreg_create_printer function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 15 Apr 2010 15:53:39 +0000 (17:53 +0200)]
s3-spoolss: Added a winreg_update_printer function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Tue, 20 Apr 2010 01:50:52 +0000 (21:50 -0400)]
s3-spoolss: Added a winreg_get_driver_list function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Tue, 20 Apr 2010 01:01:38 +0000 (21:01 -0400)]
s3-spoolss: Added a winreg_del_driver function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 21 Apr 2010 13:38:39 +0000 (09:38 -0400)]
s3-spoolss: Added a winreg_get_driver function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 21 Apr 2010 13:37:08 +0000 (09:37 -0400)]
s3-spoolss: Added a winreg_add_driver function.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 15 Apr 2010 00:46:55 +0000 (20:46 -0400)]
s3-spoolss: Move info_ctr conversion to a public helper.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 23 Apr 2010 12:45:48 +0000 (14:45 +0200)]
s3-spoolss: Fixed winreg_delete_printer_key if key is NULL or emtpy.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 21 Apr 2010 13:58:51 +0000 (09:58 -0400)]
s3-spoolss: Add date and version winreg helpers.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 21 Apr 2010 16:12:50 +0000 (18:12 +0200)]
s3-spoolss: Added more winreg hepler functions.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 21 Apr 2010 13:51:37 +0000 (09:51 -0400)]
s3-spoolss: Added winreg helper functions
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 12 Apr 2010 13:54:01 +0000 (15:54 +0200)]
s3-spoolss: Added a winreg function to query a dword.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 15 Apr 2010 19:51:16 +0000 (21:51 +0200)]
s3-spoolss: Added a function to get the ChangeID from a printer.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 15 Apr 2010 13:18:26 +0000 (15:18 +0200)]
s3-spoolss: Added a function to update the ChangeID of a printer.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 9 Apr 2010 10:36:37 +0000 (12:36 +0200)]
s3-spoolss: Added winreg helper functions to write registry values.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 9 Apr 2010 07:26:24 +0000 (09:26 +0200)]
s3-spoolss: Fixed return values of winreg_printer_deleteform1.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 9 Apr 2010 07:26:08 +0000 (09:26 +0200)]
s3-spoolss: Added missing return value to winreg_printer_enumforms1 docs.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 21 Apr 2010 15:59:55 +0000 (17:59 +0200)]
s3-spoolss: Use const values for notify functions.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 22 Apr 2010 10:33:29 +0000 (12:33 +0200)]
s3-time: Added a function to get the startup time of the server.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Fri, 23 Apr 2010 13:31:21 +0000 (15:31 +0200)]
s3-lanman: fix uninitialized variable in api_RDosPrintJobDel().
Guenther
Günther Deschner [Fri, 23 Apr 2010 11:52:57 +0000 (13:52 +0200)]
s3-selftest: enable RPC-SPOOLSS-DRIVER against s3.
Guenther
Günther Deschner [Fri, 23 Apr 2010 11:52:19 +0000 (13:52 +0200)]
s4-smbtorture: skip tests when no local driver directory is around.
Guenther
Günther Deschner [Fri, 23 Apr 2010 11:51:33 +0000 (13:51 +0200)]
s3-selftest: add print$ share with two arch dirs.
(make test variant)
Guenther
Günther Deschner [Fri, 23 Apr 2010 11:51:02 +0000 (13:51 +0200)]
s3-selftest: add print$ share with two arch dirs.
Guenther
Günther Deschner [Fri, 23 Apr 2010 10:17:04 +0000 (12:17 +0200)]
s3-winbind: fix setup_domain_child() callers.
Volker, please check.
Guenther
Günther Deschner [Fri, 23 Apr 2010 09:39:12 +0000 (11:39 +0200)]
s4-smbtorture: use server_name for all printerdriver delete and enum operations.
With this s3 passes the RPC-PRINTER-DRIVER test.
Guenther
Günther Deschner [Fri, 23 Apr 2010 09:33:51 +0000 (11:33 +0200)]
s3-spoolss: make switch in _spoolss_AddPrinterDriver() a bit more clear.
Guenther
Günther Deschner [Fri, 23 Apr 2010 09:27:51 +0000 (11:27 +0200)]
s4-smbtorture: allow to upload or remove any file belonging to a driver.
Guenther
Volker Lendecke [Wed, 21 Apr 2010 15:04:49 +0000 (17:04 +0200)]
s3: Fix a winbind crash when scanning trusts
add_trusted_domain() for a new domain always needs to be followed by a
setup_domain_child(). This was not always done, in particular not when walking
to the forest root for additional trusts.
This is a minimal patch, we need to fix add_trusted_domain().
Jeremy Allison [Fri, 23 Apr 2010 06:52:19 +0000 (23:52 -0700)]
Make deferred opens (NT_STATUS_SHARING_VIOLATION) work over SMB2.
Makes SMB2Create call re-entrant internally.
Now this infrastructure is in place, oplocks will follow shortly.
Tested with Win7 client and with W2K8R2.
Jeremy.
Volker Lendecke [Fri, 23 Apr 2010 05:06:03 +0000 (07:06 +0200)]
s3: Fix a cut&paste error in a debug message in check_oem_password()
Günther Deschner [Fri, 23 Apr 2010 01:04:47 +0000 (03:04 +0200)]
s3-spoolss: make sure AddPrinterDriver calls into AddPrinterDriverEx.
Not vice versa. Also disable some info levels in AddPrinterDriver according to
MS-RPRN 3.1.4.4.1.
Found by torture test.
Guenther
Günther Deschner [Fri, 23 Apr 2010 01:03:59 +0000 (03:03 +0200)]
s4-smbtorture: fix test_EnumPrinterDrivers_findone().
Guenther
Günther Deschner [Fri, 23 Apr 2010 00:49:42 +0000 (02:49 +0200)]
s4-smbtorture: samba currently supports level 3 and 6 driver adds.
Guenther
Günther Deschner [Fri, 23 Apr 2010 00:34:43 +0000 (02:34 +0200)]
s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
Found by torture test.
Guenther
Günther Deschner [Thu, 22 Apr 2010 23:58:02 +0000 (01:58 +0200)]
s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
Guenther
Günther Deschner [Thu, 22 Apr 2010 16:47:27 +0000 (18:47 +0200)]
s4-smbtorture: allow to upload and later remove printer driver files in RPC-SPOOLSS-DRIVER.
Guenther
Günther Deschner [Thu, 2 Jul 2009 19:49:15 +0000 (21:49 +0200)]
s4-smbtorture: add RPC-SPOOLSS-DRIVER test.
Guenther
Günther Deschner [Wed, 21 Apr 2010 13:08:40 +0000 (15:08 +0200)]
s4-smbtorture: rework EnumPrinterDrivers tests a bit.
Guenther
Andrew Tridgell [Thu, 22 Apr 2010 22:24:34 +0000 (08:24 +1000)]
build: give a more useful error when the source dir has moved
you need a distclean if you mv the source directory
Andrew Tridgell [Thu, 22 Apr 2010 22:24:02 +0000 (08:24 +1000)]
build: use 'waf distclean' for make distclean
this cleans up the more than rm -rf bin
Andrew Bartlett [Thu, 22 Apr 2010 09:35:54 +0000 (19:35 +1000)]
s4:provision Remove moduleload for 'hdb' (wrong name).
The backends are not normally modules anyway
Günther Deschner [Thu, 22 Apr 2010 09:42:45 +0000 (11:42 +0200)]
spoolss: pretty-print a struct spoolss_Time.
Guenther
Andrew Tridgell [Thu, 22 Apr 2010 07:53:25 +0000 (17:53 +1000)]
s4-cldap: we should set the w2k8 flags even if not the PDC emulator
these two tests are independent
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 06:56:40 +0000 (16:56 +1000)]
s4-drs: validate RODC credentials via the user_sid
This checks whether a replication client is a RODC by inclusion of the
the DOMAIN_RID_ENTERPRISE_READONLY_DCS sid in the users token
Pair-Programmed-With: Rusty Russell <rusty@samba.org>
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 06:48:01 +0000 (16:48 +1000)]
s4-drs: added new SECURITY_RO_DOMAIN_CONTROLLER level
This is used for allowing operations by RODCs, and denying them
operations that should only be allowed for a full DC
This required a new domain_sid argument to
security_session_user_level()
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Pair-Programmed-With: Rusty Russell <rusty@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 06:44:53 +0000 (16:44 +1000)]
s4-net: fixed two compiler warnings
Andrew Tridgell [Thu, 22 Apr 2010 06:44:30 +0000 (16:44 +1000)]
s4-torture: fixed a initialiser
we were not initialising the whole array
Pair-Programmed-With: Rusty Russell <rusty@samba.org>
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 06:43:21 +0000 (16:43 +1000)]
s4-libnet: fixed two compiler warnings
Andrew Tridgell [Thu, 22 Apr 2010 06:41:32 +0000 (16:41 +1000)]
s4-drs: removed dsdb_validate_client_flags()
This test is in the wrong place. We end up validating our own flags.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 04:56:19 +0000 (14:56 +1000)]
s4-drs: only allow replication with the right invocationId
Non-administrator replication checks the invocationId matches
the sid of the user token being used
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 04:55:54 +0000 (14:55 +1000)]
s4-dsdb: removed an unused variable
Andrew Tridgell [Thu, 22 Apr 2010 04:54:52 +0000 (14:54 +1000)]
s4-dsdb: added dsdb_validate_invocation_id()
this validates that a invocationID matches an account sid
This will be used to ensure that we don't allow DRS replication
from someone a non-DC or administrator
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 04:53:53 +0000 (14:53 +1000)]
s4-dsdb: added dsdb_get_extended_dn_sid()
This will be used by the RODC code
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 04:52:19 +0000 (14:52 +1000)]
build: we don't need this makefile magic any more
The waf build now checks for all A=B variables passed via make
and sets the same waf internal variable. This means all waf options
are available via make.
Removing this from the Makefile makes us less reliant on a modern
version of make.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 22 Apr 2010 03:32:55 +0000 (13:32 +1000)]
s4-dsdb: moved rodc schema validation to samldb.c
This means we are only doing the checks for schema changes
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Fernando J V da Silva [Thu, 15 Apr 2010 21:54:13 +0000 (18:54 -0300)]
s4-drs: Use new samdb_rodc() function in s4 code
This patch fits the calling to the new samdb_rodc() function and
fix a little bug in this function.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Fernando J V da Silva [Thu, 15 Apr 2010 20:42:08 +0000 (17:42 -0300)]
s4-drs: Do not send RODC filtered attributes to RODCs on GetNCChanges reply
During building an object to send it on a GetNCChanges reply, it checks
the attributes and if any of them is a RODC filtered and the recipient
is a RODC, then such attribute is not sent.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Fernando J V da Silva [Thu, 15 Apr 2010 20:39:54 +0000 (17:39 -0300)]
s40-drs: Do not send GetNCChanges messages to RODCs
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Fernando J V da Silva [Thu, 15 Apr 2010 20:38:47 +0000 (17:38 -0300)]
s4-drs: dsdb_validate_client_flags() function
This function is intended to check if some client is not lying about
his flags. At this moment, it only checks for RODC flags.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Fernando J V da Silva [Thu, 15 Apr 2010 20:37:40 +0000 (17:37 -0300)]
s4-drs: samdb_is_rodc() function and new samdb_rodc() function
This patch creates the samdb_is_rodc() function, which looks for
the NTDSDSA object for a DC that has a specific invocationId
and if msDS-isRODC is present on such object and it is TRUE, then
consider the DC as a RODC.
The new samdb_rodc() function uses the samdb_is_rodc() function
for the local server.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Fernando J V da Silva [Thu, 25 Mar 2010 19:58:58 +0000 (16:58 -0300)]
s4-drs: Do not allow system-critical attributes to be RODC filtered
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Bartlett [Thu, 22 Apr 2010 07:20:21 +0000 (17:20 +1000)]
s4:provision Make OpenLDAP backend more robust
With the extra moduleload lines (which succeed if it's already
staticly linked), we now work with OpenLDAP overlays as modules.
Andrew Bartlett