Jeremy Allison [Tue, 14 Mar 2006 20:07:36 +0000 (20:07 +0000)]
r14393: Fix a couple of AIX warnings.
Jeremy.
(This used to be commit
8444c997bd3e18b1d04ebe85f06c8c6e34d7373f)
Günther Deschner [Tue, 14 Mar 2006 18:50:55 +0000 (18:50 +0000)]
r14392: Use KRB5_TGS_NAME.
Guenther
(This used to be commit
4cfd737cc1d8840888f80e360119eeb627acb381)
Jeremy Allison [Tue, 14 Mar 2006 17:21:30 +0000 (17:21 +0000)]
r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
(This used to be commit
f65d7afe1977d9d85046732842f9643716c15088)
Simo Sorce [Tue, 14 Mar 2006 13:58:17 +0000 (13:58 +0000)]
r14377: Fix coverity #4 for 3_0 too
(This used to be commit
aa26642ee19dcf7cfa3cb36032eadc823b01966b)
Günther Deschner [Tue, 14 Mar 2006 09:22:01 +0000 (09:22 +0000)]
r14368: Remove redundant set of logon flags (now in rpc_netlogon.h).
Guenther
(This used to be commit
8d4290cb8ed75cf12fa45bcf3e93cfe1a5567919)
Volker Lendecke [Tue, 14 Mar 2006 08:27:44 +0000 (08:27 +0000)]
r14367: Not that I fully understand what's going on here, but the code as it was here
was clearly buggy as Coverity showed with bug id #36.
According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship
it in the request.
Volker
(This used to be commit
075e784491e6f2b491bd063db08ff1267f9cabbb)
Jeremy Allison [Tue, 14 Mar 2006 06:22:18 +0000 (06:22 +0000)]
r14365: As solaris nss includes includes.h, make sure we use
the correct malloc-macros.
Jeremy.
(This used to be commit
412dc6f5dbc796126b94f3809fe660afac5d3c2a)
Jeremy Allison [Mon, 13 Mar 2006 23:58:58 +0000 (23:58 +0000)]
r14359: Try and fix Coverity #176 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit
a3b8bee3ff8211d78f793877c877ccd2e15825dd)
Jeremy Allison [Mon, 13 Mar 2006 23:56:02 +0000 (23:56 +0000)]
r14357: Try and fix Coverity #169 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
line, and those below, will be ignored--
M source/smbd/posix_acls.c
(This used to be commit
b8397c9f33424e0d1ed3ff849e1c99812f978000)
Jeremy Allison [Mon, 13 Mar 2006 23:48:13 +0000 (23:48 +0000)]
r14355: Try and fix Coverity #158 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit
7ada96a1cfb1e928b7dfde101ca250b20024243f)
Jeremy Allison [Mon, 13 Mar 2006 23:07:14 +0000 (23:07 +0000)]
r14353: Fix coverity bugs #61 and #62. Remember to divide by
the size of the data table. Clean up the struct a little.
Jeremy.
(This used to be commit
338538410d484a9358b60b05a86180275344ffa4)
Jeremy Allison [Mon, 13 Mar 2006 22:49:56 +0000 (22:49 +0000)]
r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring).
Fix Coverity #59.
Jeremy.
(This used to be commit
d793e1550cc8c79a2764609cddec082470d226e4)
Jeremy Allison [Mon, 13 Mar 2006 21:11:15 +0000 (21:11 +0000)]
r14345: Fix Coverity #71. We don't currently propagate *any*
alloc error back up the stack from smbldap_set_mod()
so ensure we abort correctly.
Jeremy.
(This used to be commit
9a1e35079af9404e1775e2a098990277b3771086)
Jeremy Allison [Mon, 13 Mar 2006 19:47:18 +0000 (19:47 +0000)]
r14342: Fix coverity #68, resource leak on error path.
Jeremy.
(This used to be commit
7520a8d2a10c72d330099c6502848afca60f56ff)
Jeremy Allison [Mon, 13 Mar 2006 19:40:51 +0000 (19:40 +0000)]
r14340: Fix coverity #78, resource leak in error path.
Jeremy.
(This used to be commit
76c4f2c4dc6fcd91a350985b16f4a6a321ac4bf6)
Jeremy Allison [Mon, 13 Mar 2006 18:59:31 +0000 (18:59 +0000)]
r14338: Fix coverity #55 by explicit cast.
Jeremy.
(This used to be commit
1fece52da4d667fa182aa9a87aaee3917860448b)
Jeremy Allison [Mon, 13 Mar 2006 18:56:26 +0000 (18:56 +0000)]
r14336: Try and quieten coverity #53 and #54. Make it obvious
we're using -1 as a special size_t case by casting.
Jeremy.
(This used to be commit
415530bd082bf351f5e4c1fd32408f123ed77f85)
Jeremy Allison [Mon, 13 Mar 2006 18:42:57 +0000 (18:42 +0000)]
r14333: Fix coverity #77, ensure we can't exit after allocation.
Jeremy.
(This used to be commit
15d78ab1fc83249552476d99144389cfe42a786f)
Lars Müller [Mon, 13 Mar 2006 17:45:04 +0000 (17:45 +0000)]
r14331: Add a comment on top of test_pam_modules about what we're testing.
(This used to be commit
90eb092083383c2b606e21dc65fb036bb973b032)
Günther Deschner [Mon, 13 Mar 2006 17:26:52 +0000 (17:26 +0000)]
r14329: Fix the build on systems without libcom_err.
Guenther
(This used to be commit
44fcd3113be970edd01f7f076c4b6cad2d03ebcd)
Lars Müller [Mon, 13 Mar 2006 16:19:44 +0000 (16:19 +0000)]
r14326: First catch of make test_pam_modules.
Testing pam_smbpass pam_winbind
dlopen() of "./bin/pam_smbpass.so" succeeded.
dlopen() of "./bin/pam_winbind.so" failed: ././bin/pam_winbind.so:
undefined symbol: secrets_fetch_domain_sid
make: *** [test_pam_modules] Error 1
(This used to be commit
4b545e0ce665fe772095c27fe11ce535477f84ce)
Lars Müller [Mon, 13 Mar 2006 16:10:26 +0000 (16:10 +0000)]
r14325: Add pam_modules rule which builds the configure(d) pam modules. This is
called as part of the all rule (again only if pam modules are requested
by configure).
Add pam_winbind rule.
Ensure proto_exists before we build the pam modules.
Add test_pam_modules rule to test if the built pam modules have any
unresolved symbols. For test_pam_modules we use script/tests/dlopen.sh
which was written by Nalin Dahyabhai <nalin@redhat.com>. Thanks Nalin!
RedHat and SuSE use this script to test nss and pam modules since
several years.
(This used to be commit
71b2eb55adcd28f3796254ea1ce0bcee6098e712)
Günther Deschner [Mon, 13 Mar 2006 15:13:35 +0000 (15:13 +0000)]
r14321: When we have libnscd and winbindd comes (back) online, try to flush the
nscd caches so that NSS-calls can deliver accurate information.
Guenther
(This used to be commit
a32a423a0e9e0d4dd21282fd528bcd3247fddbd1)
Lars Müller [Mon, 13 Mar 2006 14:22:43 +0000 (14:22 +0000)]
r14317: Use source/bin as dir to link pam_winbind instead of source/nsswitch/
The intention is to have the resulting binaries at one place. This is
also usefull for upcoming changes to provide a test_pammodules rule.
With these changes I even got aware of
testsuite/nsswitch/pam_winbind_syms.exp But this only covers
pam_winbind.
(This used to be commit
9883957b74ddefb5293e4aef0cc2f53ee4d417ac)
Jeremy Allison [Mon, 13 Mar 2006 06:52:03 +0000 (06:52 +0000)]
r14303: Fix coverity #223. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit
f71aa3ab8fdfd08c1bec57b6506ead7c4af7299d)
Jeremy Allison [Mon, 13 Mar 2006 06:50:33 +0000 (06:50 +0000)]
r14301: Fix coverity #224. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit
f1a5e5aefeeb78512c41cc8fc075b240696a3eb7)
Jeremy Allison [Mon, 13 Mar 2006 06:48:41 +0000 (06:48 +0000)]
r14299: Fix coverity #225. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit
1c0b4ed0acdb7fccb148d714796752fefc6dd78c)
Volker Lendecke [Mon, 13 Mar 2006 06:44:10 +0000 (06:44 +0000)]
r14298: The other half of Coverity # 217
(This used to be commit
b9fb3fc0e3708b4721aaa1dcb7756d3774fb8db8)
Jeremy Allison [Mon, 13 Mar 2006 04:27:53 +0000 (04:27 +0000)]
r14292: Janitor for tridge (samba3 talloc is almost identical
to Samba4 talloc).
Jeremy
- make the snprintf call in talloc portable to older solaris boxes
- fixed an error found sing the beam analyser
(This used to be commit
1e1bae7afd9cd0051878ff1810c8ddfc28129233)
Jeremy Allison [Mon, 13 Mar 2006 04:05:47 +0000 (04:05 +0000)]
r14289: Fix coverity #101, resource leak on error code path.
Jeremy.
(This used to be commit
d9e1d6fed099e7651807aa839a743fc7756ee326)
Jeremy Allison [Mon, 13 Mar 2006 03:59:53 +0000 (03:59 +0000)]
r14286: Similar clarifiction fix for coverity #102.
Jeremy.
(This used to be commit
f458596b0edd958321c5d4061f034846348a3fe6)
Jeremy Allison [Mon, 13 Mar 2006 03:56:24 +0000 (03:56 +0000)]
r14284: Fix coverity bug #103. Make code clearer - probably
not a real issue but this code is easier to read.
Jeremy.
(This used to be commit
6621acc68f9a65540330d5c0d07db2488a3e8678)
Jeremy Allison [Mon, 13 Mar 2006 03:50:26 +0000 (03:50 +0000)]
r14282: Change centry_string to only use talloc. Should
quieten coverity bug #194 (which I think is a
false positive).
Jeremy.
(This used to be commit
07d8b02d3dddf7322e096f3f0a7cc1c8fa709fa3)
Jim McDonough [Mon, 13 Mar 2006 01:49:01 +0000 (01:49 +0000)]
r14280: Fix Coverity #129 and 130: check before dereferencing a pointer. This
was especially silly as we checked immediately _after_ dereferencing it
:-/
(This used to be commit
7ebfe2cb26b72d7fac397cfe3ceb14f244388224)
Jim McDonough [Mon, 13 Mar 2006 01:42:40 +0000 (01:42 +0000)]
r14279: Fix coverity #86, 87, 88, 89:
Free grp_sid and owner_sid before returning. Also, only allow one group
or owner.
(This used to be commit
1043e0d90ccb3493417f7bf05b70bdf5513bb1a3)
Jim McDonough [Mon, 13 Mar 2006 01:32:30 +0000 (01:32 +0000)]
r14278: Remainder of fix for Coverity #79,80,81: only allow GROUP or OWNER to be
specified once in an ACL, so it can be allocated a second time,
overwriting the first
(This used to be commit
1804a8a01ebf3353574a2c5b26a1746b34715737)
Jeremy Allison [Mon, 13 Mar 2006 01:08:27 +0000 (01:08 +0000)]
r14275: Shut-up coverity false positive (bug #199) by making an assertion
explicit.
Jeremy.
(This used to be commit
aeae20a8d9f3658acb8edd373eb601bdf7eab98b)
Jeremy Allison [Mon, 13 Mar 2006 00:37:57 +0000 (00:37 +0000)]
r14273: Fix coverity bug #202. Memory leak on error path.
Jeremy.
(This used to be commit
d2be8163f2cf69681150ed7de720a37ffaa8e937)
Jim McDonough [Mon, 13 Mar 2006 00:35:33 +0000 (00:35 +0000)]
r14272: Fix Coverity # 81: free alloc'ed storage before returning
(This used to be commit
1899d8ea283845141b24d91d230248009744fe1a)
Jeremy Allison [Mon, 13 Mar 2006 00:30:18 +0000 (00:30 +0000)]
r14270: Fix coverity #203. Ensure we free on error exit.
Jeremy.
(This used to be commit
9fa2e1bdedb61557b43f86c2898b7bf8762bbb63)
Jeremy Allison [Mon, 13 Mar 2006 00:26:38 +0000 (00:26 +0000)]
r14268: Fix coverity error #204. Resource leak on error path.
Jeremy.
(This used to be commit
5f74e56b865e0bdde0e574cd5f97cf29b06ad155)
Jeremy Allison [Mon, 13 Mar 2006 00:25:04 +0000 (00:25 +0000)]
r14266: Fix coverity #205. Resource leak on error path.
Jeremy.
(This used to be commit
23d69758bbff9687ab508e12931a5a49691d7e0d)
Jeremy Allison [Mon, 13 Mar 2006 00:23:17 +0000 (00:23 +0000)]
r14264: Fix coverity #207. Resource leak on error path.
Jeremy.
(This used to be commit
0429b6e8c34a99d4b2a9a4849075ef2a5acadf9e)
Jeremy Allison [Mon, 13 Mar 2006 00:08:39 +0000 (00:08 +0000)]
r14261: Fix coverity #38. No null deref.
Jeremy.
(This used to be commit
2a2b966b7b92ac340d61ba157d207a42509a93d1)
Jeremy Allison [Mon, 13 Mar 2006 00:05:47 +0000 (00:05 +0000)]
r14259: Fix coverity #42. Ensure contact_domain can't be null derefed
in error code path.
Jeremy.
(This used to be commit
9f5fcdd8fb437882568e38e174e2df27bd077ba3)
James Peach [Sun, 12 Mar 2006 22:27:01 +0000 (22:27 +0000)]
r14255: Revert r14204 which was horribly broken.
(This used to be commit
950ed28f9f3f57dc449bd3bd6e7be7acb1e3d26d)
Jim McDonough [Sun, 12 Mar 2006 19:56:10 +0000 (19:56 +0000)]
r14252: Fix Coverity #72: free alloc'ed storage before return. Also found one
more that coverity didn't find from asprintf.
(This used to be commit
37b6e2c8de41754a5a1a3a6f798d57aa5d533ada)
Jeremy Allison [Sun, 12 Mar 2006 19:16:45 +0000 (19:16 +0000)]
r14250: Fix coverity bug #107. Resource leak on error path.
Jeremy.
(This used to be commit
ca96c7be778d01594a540917acd3c5c218d6459c)
Volker Lendecke [Sun, 12 Mar 2006 18:01:36 +0000 (18:01 +0000)]
r14249: We've dereferenced the_acl before, no point in checking.
Fix Coverity bug # 128.
Volker
(This used to be commit
84e9e73f3c71a0ccef76d56bc72dcd21160ed286)
Volker Lendecke [Sun, 12 Mar 2006 17:57:05 +0000 (17:57 +0000)]
r14248: Fix Coverity bug # 84
(This used to be commit
811ae2b21f98bd8926f8edd70de19fe18265e28e)
Volker Lendecke [Sun, 12 Mar 2006 17:53:57 +0000 (17:53 +0000)]
r14247: Fix Coverity bug # 136
(This used to be commit
1b247ff2ed380f5b7d28917d74d6ef5609330a45)
Volker Lendecke [Sun, 12 Mar 2006 17:48:51 +0000 (17:48 +0000)]
r14246: Fix Coverity bug # 85
(This used to be commit
ebc21336d80c5d417b309d4f9c22c074c324e123)
Volker Lendecke [Sun, 12 Mar 2006 17:44:00 +0000 (17:44 +0000)]
r14245: We've dereferenced argv before, no point in checking.
Fix Coverity bug # 144.
Volker
(This used to be commit
d47ee82f068f1dfbae4a1c81e6bd765d5d36f09f)
Volker Lendecke [Sun, 12 Mar 2006 17:29:42 +0000 (17:29 +0000)]
r14244: Okay, had not seen that this happened twice.
Fix Coverity bug # 142.
Volker
(This used to be commit
f2a24b63e395d5cbb9b81521cd7ffe904821b727)
Volker Lendecke [Sun, 12 Mar 2006 17:26:56 +0000 (17:26 +0000)]
r14243: Fix Coverity bug # 143
(This used to be commit
5a0087e636104ffa98f23b8d17b4d002a55bc6b7)
Volker Lendecke [Sun, 12 Mar 2006 17:24:10 +0000 (17:24 +0000)]
r14242: Fix Coverity bug # 82
(This used to be commit
9f645e996279be74aaeebcbecbfa07adce49ec7c)
Volker Lendecke [Sun, 12 Mar 2006 17:18:26 +0000 (17:18 +0000)]
r14241: Fix Coverity bug # 146
(This used to be commit
97789ec8fc4ae2d31f6dd554d9979abce186eb30)
Volker Lendecke [Sun, 12 Mar 2006 11:00:06 +0000 (11:00 +0000)]
r14236: Fix Coverity bug # 90
(This used to be commit
019dff53f906a6eb7961a95089bff12361e31e57)
Volker Lendecke [Sun, 12 Mar 2006 10:57:42 +0000 (10:57 +0000)]
r14235: Fix Coverity bug # 91
(This used to be commit
26d471c02c6ddff15836a3c0d30f9e37f018b66d)
Volker Lendecke [Sun, 12 Mar 2006 10:52:56 +0000 (10:52 +0000)]
r14234: Fix Coverity bug # 93
(This used to be commit
8a8d9057d98b24710c98fa48df9d7f330a8ebdc0)
Volker Lendecke [Sun, 12 Mar 2006 10:47:02 +0000 (10:47 +0000)]
r14233: Fix Coverity bug # 206
(This used to be commit
0dc3030bce7bc7a58c509c70fe503a70db80b62d)
Volker Lendecke [Sun, 12 Mar 2006 10:44:19 +0000 (10:44 +0000)]
r14232: Fix Coverity Bug # 218
(This used to be commit
932d769a32748695cfff4c761422feb2ef15acbb)
Jeremy Allison [Sun, 12 Mar 2006 04:18:43 +0000 (04:18 +0000)]
r14229: Something Coverity hasn't caught (yet) but I've gotten
sensitive to null derefs. get_timed_events_timeout()
can potentially return NULL. Cope with this.
Jeremy.
(This used to be commit
04838078723613628b298b7a87622df30432cf64)
Volker Lendecke [Sun, 12 Mar 2006 00:08:12 +0000 (00:08 +0000)]
r14228: Fix Coverity bug # 217
(This used to be commit
680bd1b004f26b5a0449114911c85ca587038147)
Volker Lendecke [Sun, 12 Mar 2006 00:03:00 +0000 (00:03 +0000)]
r14226: Fix Coverity bug # 109
(This used to be commit
e9a63e3b35822eefbc5e17b6f9a4aab5e8c03074)
Volker Lendecke [Sat, 11 Mar 2006 23:58:18 +0000 (23:58 +0000)]
r14225: Fix Coverity Bug # 67
(This used to be commit
740522875105ff52d53065cb35720426532fb174)
Volker Lendecke [Sat, 11 Mar 2006 23:52:09 +0000 (23:52 +0000)]
r14224: Fix Coverity bug # 6
(This used to be commit
e1c617adae51a4645804421394aba05de9dc1e3f)
Jeremy Allison [Sat, 11 Mar 2006 23:14:42 +0000 (23:14 +0000)]
r14221: Fix coverity #76. My previous change wasn't quite enough :-).
Jeremy.
(This used to be commit
21b70035f39973e9edff323219c3c7eeb1550e2b)
Jeremy Allison [Sat, 11 Mar 2006 23:11:24 +0000 (23:11 +0000)]
r14219: Fix coverity #135. Don't deref a ptr if it can be NULL.
Jeremy.
(This used to be commit
666d427c6e10aa4194348e8acc3997682f090b48)
Volker Lendecke [Sat, 11 Mar 2006 23:10:31 +0000 (23:10 +0000)]
r14218: Fix Coverity Bug # 2
(This used to be commit
26377b63a3a3d2d5ed23bdbb5f22b70ec7d3fcad)
Volker Lendecke [Sat, 11 Mar 2006 23:07:22 +0000 (23:07 +0000)]
r14217: Fix Coverity Bug # 7
(This used to be commit
b3cfa292cf204a87acde073e2f800123ee474e40)
Volker Lendecke [Sat, 11 Mar 2006 23:02:46 +0000 (23:02 +0000)]
r14216: Fix Coverity bug # 8
(This used to be commit
e4c9cba2f94043fe3c3e85e5640cfa6bd340b92f)
Volker Lendecke [Sat, 11 Mar 2006 22:21:27 +0000 (22:21 +0000)]
r14214: Fix Coverity Bug # 57
(This used to be commit
32364d8f01c75bd00ee1bef49c687d6dd3299d1f)
Jeremy Allison [Sat, 11 Mar 2006 20:23:50 +0000 (20:23 +0000)]
r14212: Definately fixes a coverity issue but I've lost track
of the coverity id.... Oh well - definately needs a fix.
Jeremy.
(This used to be commit
54c899ef3b82af612bc2dad450140c5f47d2332e)
James Peach [Sat, 11 Mar 2006 10:59:03 +0000 (10:59 +0000)]
r14207: Convert the lp_acl_compatibility() param into an enum.
(This used to be commit
5429c495c538e416010cf44e1d6fb771770a72ae)
James Peach [Sat, 11 Mar 2006 10:23:02 +0000 (10:23 +0000)]
r14204: Remove the basically unused P_GSTRING and P_UGSTRING
parameter types.
(This used to be commit
23328fe6fc5e3b4ed3dc35e1475d661a8593eb1a)
Jeremy Allison [Sat, 11 Mar 2006 02:48:20 +0000 (02:48 +0000)]
r14196: Move to using talloc, not malloc for all policy handles.
Jeremy
(This used to be commit
6f4804a265f60c614e6e215ed663da0d8205c613)
Jeremy Allison [Sat, 11 Mar 2006 02:43:25 +0000 (02:43 +0000)]
r14194: Coverity bug #35. Fix uninitialized pipe_hnd.
Jeremy.
(This used to be commit
8aca76f03540f3df5a81ddab2588c1f8219ac550)
Jeremy Allison [Sat, 11 Mar 2006 02:29:23 +0000 (02:29 +0000)]
r14192: Don't forget to correctly initialize pipe_hnd.
Coverity fix #34.
Jeremy.
(This used to be commit
6b3dc96dcf9b14177abfd3c901bfb0baad8afa76)
Jeremy Allison [Sat, 11 Mar 2006 02:20:58 +0000 (02:20 +0000)]
r14190: Coverity bug #33. Missing initialization of pipe_hnd.
Jeremy.
(This used to be commit
144fda363793f233236a5e539daec64fa2966f3b)
Jeremy Allison [Sat, 11 Mar 2006 02:17:00 +0000 (02:17 +0000)]
r14188: Coverity fix #32. Don't deref null.
Jeremy.
(This used to be commit
218c924d91a09517909ab09668a3ba7a0c6cb305)
Jeremy Allison [Sat, 11 Mar 2006 02:14:49 +0000 (02:14 +0000)]
r14186: Coverity fix #31. Don't deref null.
Jeremy.
(This used to be commit
014a3c86613f5c3fcbf12cd7df35c68bdce29331)
Jeremy Allison [Sat, 11 Mar 2006 02:12:25 +0000 (02:12 +0000)]
r14184: Coverity fix #56. Ensure we can't deref null.
Jeremy.
(This used to be commit
c76092a0662714b49c3c519d6f01174b8995a036)
Jeremy Allison [Sat, 11 Mar 2006 02:09:18 +0000 (02:09 +0000)]
r14182: Ensure we know that dom_sid cannot be null.
Jeremy.
(This used to be commit
e3a28bf4c8064f7053b7d1a25a2f087ac2095fcd)
Jeremy Allison [Fri, 10 Mar 2006 23:52:37 +0000 (23:52 +0000)]
r14178: Clarify code for Coverity #49. Ensure we know we
can't have an uninitialized *returned val.
Jeremy.
(This used to be commit
e83515afd2cb63b0dfa4f7fe00b6b7163bf35f2f)
Jeremy Allison [Fri, 10 Mar 2006 23:22:38 +0000 (23:22 +0000)]
r14176: Fix coverity bug #30. Ensure no possible null deref.
Jeremy.
(This used to be commit
e5d6069cf88c0aa632af5582fcd7466729b20934)
Jeremy Allison [Fri, 10 Mar 2006 18:32:18 +0000 (18:32 +0000)]
r14170: Paranioa fix for sesssetup.
Fix Coverity bug #26. Guard against NULL ref.
Jeremy.
(This used to be commit
c0f906ac8de850f4566b6b3be4e3c7d245e6e252)
Jeremy Allison [Fri, 10 Mar 2006 17:52:41 +0000 (17:52 +0000)]
r14168: Fix Coverity #219. I think this is a false coverity
warning as it seems to get confused with assignment
and comparison. Clarify the code anyway.
Jeremy.
(This used to be commit
754818f8cc0849bddf84b7a534cd65e8dcd932ac)
Jeremy Allison [Fri, 10 Mar 2006 17:51:22 +0000 (17:51 +0000)]
r14166: Fix const warning.
Jeremy.
(This used to be commit
2ec461ae583b9a07da3ce5abd7f90ea18e1535ae)
Alexander Bokovoy [Fri, 10 Mar 2006 14:39:29 +0000 (14:39 +0000)]
r14158: Fix coverity CID #147 -- do not dereference pointers before checking their existence
(This used to be commit
6b52423033b2eccdfad1e91e9d59619664f570ac)
Jim McDonough [Fri, 10 Mar 2006 14:28:51 +0000 (14:28 +0000)]
r14156: Fix coverity #114: free storage alloc'ed by sstring_sub()
(This used to be commit
655fb66b289bdd19c4432eea00fac935184f25c9)
Jim McDonough [Fri, 10 Mar 2006 14:20:09 +0000 (14:20 +0000)]
r14155: Fix coverity #115: free storage alloc'ed by sstring_sub()
(This used to be commit
a197b8c5cb02c8a5fac3882e7b76bcd7abb0279c)
Jim McDonough [Fri, 10 Mar 2006 14:17:44 +0000 (14:17 +0000)]
r14153: Fix coverity #116: free storage alloc'ed by sstring_sub()
(This used to be commit
dbc0ff5544f2d15b1d1bc41319c76274b79d92b4)
Jim McDonough [Fri, 10 Mar 2006 14:14:23 +0000 (14:14 +0000)]
r14152: Fix coverity #117: free storage alloc'ed by sstring_sub
(This used to be commit
cf36f5949f8ac5ea020fcaa796ad92852df25ae7)
Jim McDonough [Fri, 10 Mar 2006 14:09:34 +0000 (14:09 +0000)]
r14150: Fix coverity #118: not freeing alloc'ed storage returned from
sstring_sub().
(This used to be commit
6ff849f35ae3394d6557f79c73b0fe54fbb86d0f)
Günther Deschner [Fri, 10 Mar 2006 13:36:39 +0000 (13:36 +0000)]
r14148: Removing the not very well tested krb5 ticket refresh handling activated
over --with-kcm. No time to look after it for the moment.
Guenther
(This used to be commit
7ec2b31a8790db1466ffafeab533c11ab7ea801a)
Jim McDonough [Fri, 10 Mar 2006 13:33:02 +0000 (13:33 +0000)]
r14147: Fix coverity #119. alloc'ed memory returned not saved, so not freed.
Need to go back and correct the assumption that an "ldap xxx suffix"
parm must have an OU.
(This used to be commit
2d7ba11ffbe17af12257a91638be95d09c0c34c5)
Günther Deschner [Fri, 10 Mar 2006 13:14:01 +0000 (13:14 +0000)]
r14146: Just some typos.
Guenther
(This used to be commit
ade86cc787e266850fee982b008a9caf2c8ed7e7)
Günther Deschner [Fri, 10 Mar 2006 13:12:38 +0000 (13:12 +0000)]
r14145: Add missing WITH_KCM hunks from my local tree.
Guenther
(This used to be commit
977079a0583497255fbd4a48de52ebd404710b62)
Günther Deschner [Fri, 10 Mar 2006 13:01:08 +0000 (13:01 +0000)]
r14144: allow to set sec_info in rpcclients lsa_query_secobj.
Guenther
(This used to be commit
18ee669c604b344910308fef81c2544e208ef62c)