Guy Harris [Sat, 17 Sep 2005 02:14:44 +0000 (02:14 -0000)]
Fix Gerald's e-mail address (and possibly provoke a copy of the main
repository to the anonymous repository - the current anonymous
repository appears to be out-of-date, which is breaking the buildbot).
svn path=/trunk/; revision=15847
Guy Harris [Sat, 17 Sep 2005 00:39:52 +0000 (00:39 -0000)]
Mark some unused and unremovable arguments as unused.
svn path=/trunk/; revision=15846
Guy Harris [Sat, 17 Sep 2005 00:31:15 +0000 (00:31 -0000)]
Move some headers for stuff defined by a dissector into epan/dissectors
- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file.
svn path=/trunk/; revision=15845
Guy Harris [Sat, 17 Sep 2005 00:02:31 +0000 (00:02 -0000)]
Move a pile of protocol-related headers from the top-level source
directory to the epan directory. Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.
Fix Gerald's e-mail address in files we're moving.
svn path=/trunk/; revision=15844
Ulf Lamping [Fri, 16 Sep 2005 22:17:50 +0000 (22:17 -0000)]
add an expert info based on QualityCode and a COL_INFO output
svn path=/trunk/; revision=15843
Ulf Lamping [Fri, 16 Sep 2005 22:14:33 +0000 (22:14 -0000)]
slightly shrink COL_INFO output
svn path=/trunk/; revision=15842
Ulf Lamping [Fri, 16 Sep 2005 22:05:50 +0000 (22:05 -0000)]
split call id's with a #, if more than one DCE/RPC call is in a data PDU
svn path=/trunk/; revision=15841
Gerald Combs [Fri, 16 Sep 2005 16:25:53 +0000 (16:25 -0000)]
Sort each conversation column numerically. Fix up whitespace.
It looks like we can't put "COPYCMD=/Y" in config.nmake and expect nmake
to do the right thing. Add a comment, and set COPYCMD explicitly in the
root Makefile.nmake. The rest of the occurrences of xcopy will have to
be taken care of at some point.
svn path=/trunk/; revision=15840
Tim Potter [Fri, 16 Sep 2005 12:30:33 +0000 (12:30 -0000)]
Aargh - undo r15838 as I missed jmayer's commit of r15835.
svn path=/trunk/; revision=15839
Tim Potter [Fri, 16 Sep 2005 12:11:17 +0000 (12:11 -0000)]
Comment out pidl dissectors for the moment to get the win32 build
going again. I have most of a patch to get it working but I don't
think it will be finished tonight.
svn path=/trunk/; revision=15838
Guy Harris [Fri, 16 Sep 2005 09:47:18 +0000 (09:47 -0000)]
If we've enabled the display of BER encapsulation tokens, only put them
into the protocol tree once.
Fix the offsets and lengths used to put the variable binding values into
the protocol tree.
svn path=/trunk/; revision=15837
Jörg Mayer [Fri, 16 Sep 2005 09:31:05 +0000 (09:31 -0000)]
Add a local copy of pidl, add a README.ethereal to include
minimalistic building and usage instructions.
svn path=/trunk/; revision=15836
Jörg Mayer [Fri, 16 Sep 2005 08:55:51 +0000 (08:55 -0000)]
Move the packet-dcerpc-*.[hc] from pidl/ back to dissectors.
This makes Ethereal build again - there's no real reason that
ethereal fails to build for such a long time on so many platforms.
svn path=/trunk/; revision=15835
Jörg Mayer [Fri, 16 Sep 2005 08:40:08 +0000 (08:40 -0000)]
wka.tmpl:
Show MS NLB Adresses individually
manuf:
Update
svn path=/trunk/; revision=15834
Guy Harris [Fri, 16 Sep 2005 08:30:35 +0000 (08:30 -0000)]
Note problems with some values that appear in, for example, some SNMP
captures.
svn path=/trunk/; revision=15833
Guy Harris [Fri, 16 Sep 2005 07:50:02 +0000 (07:50 -0000)]
Fix a type.
svn path=/trunk/; revision=15832
Tim Potter [Fri, 16 Sep 2005 04:25:12 +0000 (04:25 -0000)]
Add conformance file used for building winreg dissector.
svn path=/trunk/; revision=15831
Ulf Lamping [Fri, 16 Sep 2005 00:02:31 +0000 (00:02 -0000)]
fixing the fix, it's time to go to bed ...
svn path=/trunk/; revision=15830
Ulf Lamping [Thu, 15 Sep 2005 23:44:07 +0000 (23:44 -0000)]
bugfix: don't crash (assert), if jumping to the first packet and packet_list is currently empty. Can happen at capture start.
svn path=/trunk/; revision=15829
Guy Harris [Thu, 15 Sep 2005 23:39:08 +0000 (23:39 -0000)]
Don't use u_char - not all platforms define it, and even those that do
might require other files to be included to get it.
svn path=/trunk/; revision=15828
Guy Harris [Thu, 15 Sep 2005 23:17:42 +0000 (23:17 -0000)]
Add a Makefile.
svn path=/trunk/; revision=15827
Luis Ontanon [Thu, 15 Sep 2005 19:30:44 +0000 (19:30 -0000)]
Add more information regarding call legs.
Make the release cause value filterable.
svn path=/trunk/; revision=15826
Luis Ontanon [Thu, 15 Sep 2005 19:26:05 +0000 (19:26 -0000)]
leak fix
svn path=/trunk/; revision=15825
Gerald Combs [Thu, 15 Sep 2005 18:42:04 +0000 (18:42 -0000)]
Fix fragment length checks. Fixes bugs 440 and 442-446.
svn path=/trunk/; revision=15824
Ronnie Sahlberg [Thu, 15 Sep 2005 13:41:56 +0000 (13:41 -0000)]
remove some redundant strcpy()
svn path=/trunk/; revision=15823
Ronnie Sahlberg [Thu, 15 Sep 2005 13:36:31 +0000 (13:36 -0000)]
remove some redundant strcpy()
svn path=/trunk/; revision=15822
Ronnie Sahlberg [Thu, 15 Sep 2005 13:31:05 +0000 (13:31 -0000)]
remove a whole bunch of strcpy() fix minor bug where whe checked the wrong string before we display it
svn path=/trunk/; revision=15821
Ronnie Sahlberg [Thu, 15 Sep 2005 13:20:32 +0000 (13:20 -0000)]
update for ospf from Senthil Kumar Nagappan
svn path=/trunk/; revision=15820
Ronnie Sahlberg [Thu, 15 Sep 2005 10:20:08 +0000 (10:20 -0000)]
delete the old dissector
svn path=/trunk/; revision=15819
Ronnie Sahlberg [Thu, 15 Sep 2005 10:19:25 +0000 (10:19 -0000)]
delete the old dissector and point the makefile to the new dissector
svn path=/trunk/; revision=15818
Ronnie Sahlberg [Thu, 15 Sep 2005 10:18:08 +0000 (10:18 -0000)]
new pidl generated atsvc dissector and its conformance file
svn path=/trunk/; revision=15817
Guy Harris [Thu, 15 Sep 2005 09:09:00 +0000 (09:09 -0000)]
Get rid of a no-longer-used variable.
svn path=/trunk/; revision=15816
Guy Harris [Thu, 15 Sep 2005 08:57:51 +0000 (08:57 -0000)]
Move OUIs from LLDP dissector to oui.h.
Get rid of remaining sprintf'ing into on-the-stack buffers.
Note where some items came from.
svn path=/trunk/; revision=15815
Guy Harris [Thu, 15 Sep 2005 08:55:43 +0000 (08:55 -0000)]
Use ep_strdup_printf() to generate the "not found in value_string table"
string for val_to_str().
svn path=/trunk/; revision=15814
Guy Harris [Thu, 15 Sep 2005 08:54:56 +0000 (08:54 -0000)]
Tag ep_strdup_printf() and se_strdup_printf() as printf-like functions,
so we get compile-time checking of arguments when possible.
svn path=/trunk/; revision=15813
Tim Potter [Thu, 15 Sep 2005 07:34:52 +0000 (07:34 -0000)]
A first go at importing some pidl generated code into ethereal. This
commit replaces the hand written dcerpc initshutdown and winreg
interfaces with autogenerated ones.
The pidl generated code is still a bit rought around the edges but will
hopefully improve with time.
svn path=/trunk/; revision=15812
Guy Harris [Thu, 15 Sep 2005 06:04:33 +0000 (06:04 -0000)]
Add PRIX64, as we now use it.
svn path=/trunk/; revision=15811
Anders Broman [Thu, 15 Sep 2005 05:38:37 +0000 (05:38 -0000)]
Replace the spnego dissector with an asn2eth generated one.
svn path=/trunk/; revision=15810
Guy Harris [Thu, 15 Sep 2005 05:22:20 +0000 (05:22 -0000)]
Rename TLV_INFO_MASK to TLV_INFO_LEN_MASK, to match TLV_TYPE_MASK.
Use "tvb_format_stringzpad()" rather than "tvb_format_text()" on
strings, as some of them are null-padded. (XXX - are they null-padded
or null-terminated?)
Clean up the TLV length checks, and do many more such checks.
svn path=/trunk/; revision=15809
Guy Harris [Thu, 15 Sep 2005 04:08:53 +0000 (04:08 -0000)]
We already define ETHERTYPE_LLDP in "etypes.h" - use that, don't define
our own.
Get rid of MAC_to_str() - ether_to_str() suffices.
Don't copy to on-the-stack fixed-size string buffers, just save the
results of various formatting calls as pointers.
Use tvb_format_text() to get displayable versions of text strings.
Use tvb_get_ipv4() and tvb_get_ipv6().
Don't put an item into the protocol tree as text and then put in a
hidden item that, if unhidden, would display the same or almost exactly
the same; just put the item into the tree unhidden.
svn path=/trunk/; revision=15808
Guy Harris [Thu, 15 Sep 2005 03:09:40 +0000 (03:09 -0000)]
Properly handle 64-bit integer constants (they don't happen by magic,
and the stuff you have to do is compiler-dependent, so use
G_GINT64_CONSTANT()).
Properly handle formatting 64-bit quantities (they don't format
correctly by magic, and the stuff you have to do is compiler-dependent,
so use PRI[duoxX]64).
Don't copy the result of tvb_bytes_to_str() to a string buffer and then
only use it as an argument to a "%s" - just use the result directly.
Don't copy constant strings to a buffer - just use the strings directly.
Fetch 64-bit integral quantities with tvb_get_ntoh64(); they're
presumably in a standard byte order, which is probably big-endian for
Internet-family protocols, and using tvb_memcpy() is *guaranteed* to be
wrong on some platforms.
Fix up a format string.
Fix up indentation a bit.
svn path=/trunk/; revision=15807
Guy Harris [Thu, 15 Sep 2005 03:03:29 +0000 (03:03 -0000)]
Squelch some warnings, fix some typoes.
svn path=/trunk/; revision=15806
Ulf Lamping [Wed, 14 Sep 2005 23:15:12 +0000 (23:15 -0000)]
fix wtap_dump_flush function name and don't check for it's return value. We don't do this check in Ethereal either and we will recognize problems at next write anyway ...
svn path=/trunk/; revision=15805
Ulf Lamping [Wed, 14 Sep 2005 21:57:30 +0000 (21:57 -0000)]
added compression support for capture file output. The Save/As dialog now has a checkbox "Compress with gzip"
currently limited to Ethereal and all the variants of libpcap filetypes only.
We might want to add output compression support to the other tools as well (tethereal, mergecap, ...).
We might also want to add support for the other filetypes, but this is only possible if the filetype functions doesn't use special output operations like fseek.
One bug is still left: if the input and output filetypes while saving are the same, Ethereal currently optimizes this by simply copy the binary file instead of using wiretap (so it will be faster but it will ignore the compress setting).
Don't know a good workaround for this, as I don't know a way to find out if the input file is currently compressed or not. One idea might be to use a heuristic on the filesize (compared to the packet size summmary). Another workaround I see is to remove this optimization, which is of course not the way I like to do it ...
svn path=/trunk/; revision=15804
Ulf Lamping [Wed, 14 Sep 2005 20:09:17 +0000 (20:09 -0000)]
add E_OUTOFMEMORY
svn path=/trunk/; revision=15803
Anders Broman [Wed, 14 Sep 2005 19:14:23 +0000 (19:14 -0000)]
From Peter Johansson
I added a description for the call to DISSECTOR_ASSERT in proto.c to be
printed to stderr.
svn path=/trunk/; revision=15802
Anders Broman [Wed, 14 Sep 2005 19:11:23 +0000 (19:11 -0000)]
Fix a warning.
svn path=/trunk/; revision=15801
Anders Broman [Wed, 14 Sep 2005 19:06:54 +0000 (19:06 -0000)]
From Brian Bogora:
Our company (Mitel) has developed an LLDP-MED plug-in for Ethereal.
svn path=/trunk/; revision=15800
Anders Broman [Wed, 14 Sep 2005 18:40:16 +0000 (18:40 -0000)]
From Dinesh G Dutt
Support some new messages and fix a couple of bugs.
packet-fc.h - Added a #define for a Cisco MDS-specific frame called OHMS (online health mgmt srv) packet-fc.c - Support for OHMS frame, fixed an incorrect "malformed frame" error caused on ACK1 frames (they
don't contain anything but (encap hdr + FC hdr + encap trailer), fixed incorrect detection of
last-data-frame
packet-fcct.h - Support for new service type, "Fabric Controller", used in conjunction with FC-SW3 ESS message,
exported the service name value string definitions and
packet-fcct.c - Support for recognizing "Fabric Controller" service type and "vendor-specific" service
packet-fcswils.h - Support for ESS & MRRA messages, defined as part of FC-SW3 packet-fcswils.c - Support for ESS & MRRA messages, defined as part of FC-SW3
packet-scsi.c - Support for Verify and Write&Verify SBC commands.
svn path=/trunk/; revision=15799
Anders Broman [Wed, 14 Sep 2005 17:08:41 +0000 (17:08 -0000)]
Do the variable binding with dissect_ber_x() routines rather than asn1 ones.
svn path=/trunk/; revision=15798
Anders Broman [Wed, 14 Sep 2005 17:04:36 +0000 (17:04 -0000)]
Dont't carsh if dissect_ber_null() isn't passed a hf_id.
svn path=/trunk/; revision=15797
Ronnie Sahlberg [Wed, 14 Sep 2005 16:06:11 +0000 (16:06 -0000)]
Allow dissection of dcerpc of short frames instead of aborting as soon as it is detected the pdu is "short"
svn path=/trunk/; revision=15796
Ronnie Sahlberg [Wed, 14 Sep 2005 16:04:59 +0000 (16:04 -0000)]
for octet strings that span beyond the end of a "short" tvb, create a new subset tvb of what we have and use that instead of bailing out completely.
svn path=/trunk/; revision=15795
Ronnie Sahlberg [Wed, 14 Sep 2005 16:02:54 +0000 (16:02 -0000)]
when we have raw keberos inside the spnego blob, pass it as is over to
the kerberos dissector and do not strip the ber tag and lengths off
svn path=/trunk/; revision=15794
Guy Harris [Wed, 14 Sep 2005 08:59:41 +0000 (08:59 -0000)]
Have cf_retap_packets() take an argument that indicates whether to
generate columns; use cf_retap_packets instead of cf_redissect_packets()
when running taps (the general flow graph stat uses the Info column).
svn path=/trunk/; revision=15793
Ulf Lamping [Wed, 14 Sep 2005 02:07:20 +0000 (02:07 -0000)]
fix #388: add /desktopicon and /quicklaunchicon command line options to the NSIS installer
update the User's Guide accordingly
svn path=/trunk/; revision=15792
Ulf Lamping [Tue, 13 Sep 2005 23:46:42 +0000 (23:46 -0000)]
Move "Expert Info" from "Statistics" to "Analyze" menu item.
*significantly* improve performance (100000 infos from ~5min to 25sec!)
Add a simple severity based filter mechanism.
replace // style comments by /**/
svn path=/trunk/; revision=15791
Ulf Lamping [Tue, 13 Sep 2005 19:01:08 +0000 (19:01 -0000)]
Turn around the sequence of PATH, so the former PATH will be in front of the newly added things.
This way, the cygwin link.exe command will be behind the link.exe from MSVC.
Also added a definition of the docbook dir, floating around in my personal file for a while. This will be needed if the User's Guide is included in the NSIS installer later.
svn path=/trunk/; revision=15790
Gerald Combs [Tue, 13 Sep 2005 19:01:01 +0000 (19:01 -0000)]
In smb_trans_defragment(), throw an exception if we encounter a too-large
fragment size. The limit is conservatively set at 65536 bytes. It may
have to be increased. Fixes bug 421.
Add an entry to the release notes.
svn path=/trunk/; revision=15789
Ulf Lamping [Tue, 13 Sep 2005 18:45:52 +0000 (18:45 -0000)]
implement a way to add menu items to the "Analyze" menu
svn path=/trunk/; revision=15788
Ulf Lamping [Tue, 13 Sep 2005 18:42:12 +0000 (18:42 -0000)]
don't crash with a NULL pointer exception, if "do not decode as" is used
svn path=/trunk/; revision=15787
Ulf Lamping [Tue, 13 Sep 2005 18:40:58 +0000 (18:40 -0000)]
add to the protocol item a short description what a "Short Frame" is
svn path=/trunk/; revision=15786
Ulf Lamping [Tue, 13 Sep 2005 18:39:26 +0000 (18:39 -0000)]
increment index of IID's in COL_INFO
svn path=/trunk/; revision=15785
Ulf Lamping [Tue, 13 Sep 2005 18:38:19 +0000 (18:38 -0000)]
use the same name for menu item and dialog box title, use the right capitalization for both
svn path=/trunk/; revision=15784
Anders Broman [Tue, 13 Sep 2005 16:56:28 +0000 (16:56 -0000)]
Get application ID from the packet.
svn path=/trunk/; revision=15783
Anders Broman [Tue, 13 Sep 2005 16:48:13 +0000 (16:48 -0000)]
From Peter Johansson
PATH contents one had before starting the build, that PATH is added to the new PATH variable 5 additional times
instead of 1.
I have made changes (supplied) to config.nmake that takes care of this
problem.
svn path=/trunk/; revision=15782
Ulf Lamping [Tue, 13 Sep 2005 08:03:16 +0000 (08:03 -0000)]
don't simply remove the expert_info output at BoundsError, but add the comment from Guy why this (usually) isn't a bug (because of a short snapshot length).
svn path=/trunk/; revision=15781
Anders Broman [Tue, 13 Sep 2005 05:05:19 +0000 (05:05 -0000)]
From Ankur Aggarwal:
First phase of testing revealed the following errors
svn path=/trunk/; revision=15780
Anders Broman [Tue, 13 Sep 2005 05:00:17 +0000 (05:00 -0000)]
From Stefan Metzmacher
Some updates to the winsrepl-dssector to add COL_INFO strings...
svn path=/trunk/; revision=15779
Anders Broman [Tue, 13 Sep 2005 04:53:36 +0000 (04:53 -0000)]
From Alejandro Vaquero.
svn path=/trunk/; revision=15778
Anders Broman [Tue, 13 Sep 2005 04:51:49 +0000 (04:51 -0000)]
From Piros Lucian:
A new dissector - cimd dissector. CIMD stands for Computer Interface to Message Distribution and it's used to transfer short messages between applications and Nokia Short Message Service Center.
svn path=/trunk/; revision=15777
Guy Harris [Tue, 13 Sep 2005 04:00:47 +0000 (04:00 -0000)]
Move the definition of GNUC_FORMAT_CHECK() to its own header, use it in
column-utils.h, and add it to expert.h, so we check the arguments to
"expert_add_info_format()", at least if the format argument is a
constant string.
Fix some more calls to "expert_add_info_format()" to pass it a format
string.
Don't record BoundsError exceptions as expert events - they merely
reflect a capture done with a snapshot length too short to capture all
of the packet (any case where it's caused by something else is a bug).
svn path=/trunk/; revision=15776
Guy Harris [Tue, 13 Sep 2005 02:39:37 +0000 (02:39 -0000)]
Don't pass an arbitrary string from a packet to a routine expecting a
format string - the arbitrary string might contain "%" characters, so
the routine might then fetch arbitrary junk and try to use it as, for
example, a string pointer.
svn path=/trunk/; revision=15775
Guy Harris [Tue, 13 Sep 2005 00:50:43 +0000 (00:50 -0000)]
Convert some more "tvb_memcpy()"s fetching IPv4 and IPv6 addresses to
calls to "tvb_get_ipv4()" and "tvb_get_ipv6()".
Fix a call in the BGP dissector to properly fetch an IEEE floating-point
number.
Update some I-D info.
svn path=/trunk/; revision=15774
Ulf Lamping [Mon, 12 Sep 2005 20:10:44 +0000 (20:10 -0000)]
When jumping (e.g. using menu item Go/Go to Packet...) to a new packet which is currently not displayed, this newly selected packet will become the first in the packet list.
This is inconvenient, as most of the time (at least) I'm interested not only in the packets behind the newly selected one, but also to have some history *before* it.
So this change will scroll the packet list to have the selected packet after the first third of the packet list.
This change won't take effect if the new packet is already visible (only the selection is changed) or it's near the beginning or end of the packet list (so the whole beginning/end of the list is shown).
svn path=/trunk/; revision=15772
Ulf Lamping [Mon, 12 Sep 2005 20:02:58 +0000 (20:02 -0000)]
add number of defragmented bytes to the expert info output
svn path=/trunk/; revision=15771
Guy Harris [Mon, 12 Sep 2005 19:50:45 +0000 (19:50 -0000)]
Get rid of "dtd_grammar.out" on a "make distclean".
Get rid of all the Flex-generated (and Lemon-generated) files on a
"nmake -f Makefile.nmake distclean".
svn path=/trunk/; revision=15770
Guy Harris [Mon, 12 Sep 2005 19:32:35 +0000 (19:32 -0000)]
Add a header file to declare routines defined in lexer and used in
parser, or vice versa.
svn path=/trunk/; revision=15769
Guy Harris [Mon, 12 Sep 2005 15:54:20 +0000 (15:54 -0000)]
Again, "g_strdown()" doesn't return a value in GLib 1.2[.x].
svn path=/trunk/; revision=15768
Guy Harris [Mon, 12 Sep 2005 07:55:14 +0000 (07:55 -0000)]
"g_strdown()" doesn't return a value in GLib 1.2[.x]; don't depend on it
doing so.
svn path=/trunk/; revision=15767
Guy Harris [Mon, 12 Sep 2005 07:44:11 +0000 (07:44 -0000)]
The previous checkin for packet-isup.c was accidentally checked in along
with some unrelated changes; it got rid of some calls to get IPv4/IPv6
addresses and add them to the protocol tree, replacing them with
proto_tree_add_item() calls, and fixed up the length of one protocol
tree item.
Note that we have (at least) three count 'em three different routines
for dissecting/displaying NSAPs (there might be more - I might have
missed some), and suggest that we might want to reduce that to one.
Update the URL for ICP values for IPv{4,6} addresses inside NSAPs.
Fix the offset in the call to add the IPv6 address part of an NSAP
containing such an address, and the length in the call adding the DSP
for an NSAP containing an IPv4 address.
Fix up indentation a bit.
svn path=/trunk/; revision=15766
Michael Tüxen [Mon, 12 Sep 2005 06:24:02 +0000 (06:24 -0000)]
In now supports also:
- http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-sctpimpguide-15.txt
- http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-addip-sctp-13.txt
- http://www.ietf.org/internet-drafts/draft-stewart-sctp-pktdrprep-02.txt
- http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-sctp-auth-01.txt
- http://www.ietf.org/internet-drafts/draft-ladha-sctp-nonce-02.txt
svn path=/trunk/; revision=15765
Guy Harris [Mon, 12 Sep 2005 06:21:35 +0000 (06:21 -0000)]
Don't collide with the "regular" IPv6 defintions in at least some
platforms in ipv6-utils.h.
svn path=/trunk/; revision=15764
Ulf Lamping [Mon, 12 Sep 2005 00:29:19 +0000 (00:29 -0000)]
fix fault defragmentation the same way as in the request/response path
Unfortunately, I don't have a capture file to test this...
svn path=/trunk/; revision=15763
Ulf Lamping [Mon, 12 Sep 2005 00:16:57 +0000 (00:16 -0000)]
fix reassembling problem I've introduced yesterday, by using fragment_add_seq_next() function instead of fragment_add()
in addition, I had to implement fragment_get_reassembled() in addition to fragment_get(), which works with reassembled_table
svn path=/trunk/; revision=15762
Guy Harris [Sun, 11 Sep 2005 22:31:36 +0000 (22:31 -0000)]
Fix a typo.
svn path=/trunk/; revision=15761
Guy Harris [Sun, 11 Sep 2005 22:25:33 +0000 (22:25 -0000)]
Frame numbers are unsigned, and they start at 1; 0 is what's used for
"unknown" for frame numbers. Note that in epan/frame_data.h, and make
the frame number in experts unsigned, and use 0 for "unknown", and
display it as an unsigned number - and, if it's 0, don't display it at
all.
Fix the signature of "expert_dlg_draw()" to match what a tap's draw
routine's signature is expected to be.
svn path=/trunk/; revision=15760
Guy Harris [Sun, 11 Sep 2005 22:19:41 +0000 (22:19 -0000)]
Add some braces to squelch a compiler warning.
Fix up indentation.
svn path=/trunk/; revision=15759
Guy Harris [Sun, 11 Sep 2005 21:25:37 +0000 (21:25 -0000)]
Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.
Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).
svn path=/trunk/; revision=15758
Ulf Lamping [Sun, 11 Sep 2005 21:10:26 +0000 (21:10 -0000)]
rename fragment_add_dcerpc -> fragment_add_dcerpc_dg to avoid confusion a bit,
as connection oriented (cn) and connectionless (dg) DCE/RPC uses different ways to handle defragmentation and this function is only used for dg
svn path=/trunk/; revision=15757
Anders Broman [Sun, 11 Sep 2005 21:10:20 +0000 (21:10 -0000)]
Get rid of dependency on format-oid.h
svn path=/trunk/; revision=15756
Ulf Lamping [Sun, 11 Sep 2005 17:15:00 +0000 (17:15 -0000)]
some things fixed, leftover from code cleanup (thanks to the buggy MSVC dependencies)
svn path=/trunk/; revision=15755
Ulf Lamping [Sun, 11 Sep 2005 16:55:34 +0000 (16:55 -0000)]
I'm adding the "Expert Info" prototype now, as it seems to be in a state where others might have a look and probably already find it useful :-). Anyway, we can easily disable it at one or two places in the code if it get's in our way of a new release.
Please see: http://wiki.ethereal.com/Development/ExpertInfo for a complete overview of the intended feature and it's current state of implementation.
While I'm working on this, I've also added some more status result codes to the DCE/RPC and DCOM dissectors.
svn path=/trunk/; revision=15754
Guy Harris [Sat, 10 Sep 2005 19:43:41 +0000 (19:43 -0000)]
Add "tvb_get_ipv4()" and "tvb_get_ipv6()" addresses, to fetch IPv4 and
IPv6 addresses. Use "tvb_get_ipv4()" in the WINS Replication dissector,
so that it gets the right answer on little-endian *AND* big-endian
machines.
svn path=/trunk/; revision=15753
Guy Harris [Sat, 10 Sep 2005 19:39:56 +0000 (19:39 -0000)]
In "dissect_sip()", return 0 if "dissect_sip_common()" returns a
negative value, so we reject the packet as "not SIP".
Add a "dissect_sip_tcp_heur()" that's heuristic - it'll return FALSE if
the first packet doesn't look like SIP, but once it's dissected one
packet it'll just treat subsequent SIP packets as continuations if they
don't look right.
Clean up indentation a bit.
svn path=/trunk/; revision=15752
Luis Ontanon [Sat, 10 Sep 2005 18:59:02 +0000 (18:59 -0000)]
propperly handle the errors when loading a file fails.
svn path=/trunk/; revision=15751
Luis Ontanon [Sat, 10 Sep 2005 18:46:03 +0000 (18:46 -0000)]
don't use fgets() as MSVC does not implement it. use fgetc instead.
svn path=/trunk/; revision=15750
Ulf Lamping [Sat, 10 Sep 2005 18:33:32 +0000 (18:33 -0000)]
fix MSVC slash/backslash and other such problems, now getting:
dtd_preparse.obj : error LNK2001: Nichtaufgeloestes externes Symbol _fgetln
MSVC doesn't support fgetln!
svn path=/trunk/; revision=15749
Luis Ontanon [Sat, 10 Sep 2005 18:00:28 +0000 (18:00 -0000)]
Make sure lemon is built before trying to use it
svn path=/trunk/; revision=15748
Luis Ontanon [Sat, 10 Sep 2005 17:55:16 +0000 (17:55 -0000)]
fix the dtd_grammar.c rule
svn path=/trunk/; revision=15747