Andrew Bartlett [Thu, 8 Sep 2011 23:03:23 +0000 (09:03 +1000)]
selftest: change plugin_dc to test using s3fs
Andrew Bartlett [Tue, 28 Feb 2012 23:06:31 +0000 (10:06 +1100)]
selftest: skip the troublesome samba4.rpc.unixinfo test
The issue here is that while the single rpc_server process is stuck in
an nss_winbind getpwuid() call, winbindd cannot contact netlogon to
make the connection to the domain.
nss_winbind comes into play when (for s3fs) the
NSS_WRAPPER_WINBIND_SO_PATH environment variable is set. In the
medium term, the unixinfo pipe should either be rewritten fully async
or removed.
Andrew Bartlett
Stefan Metzmacher [Fri, 24 Feb 2012 14:58:40 +0000 (15:58 +0100)]
s4:winbind: use ncalrpc for connections to ourself
That avoids recursion if "smbd" is used as file server.
metze
Andrew Bartlett [Wed, 29 Feb 2012 01:48:21 +0000 (12:48 +1100)]
selftest: Do not run chgdcpass test on the main DC
If winbindd has it's password changed from under it, it becomes
grumpy.
Andrew Bartlett
Andrew Bartlett [Tue, 28 Feb 2012 23:37:40 +0000 (10:37 +1100)]
s4-winbindd: Do not ask for a tree that we will not use
Amitay Isaacs [Wed, 29 Feb 2012 05:05:53 +0000 (16:05 +1100)]
testsuite: Replace deprecated bzero with memset
This fixes build issues on solaris reported in bug #8767.
https://bugzilla.samba.org/show_bug.cgi?id=8767
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Feb 29 10:39:10 CET 2012 on sn-devel-104
Michael Adam [Wed, 29 Feb 2012 04:49:49 +0000 (05:49 +0100)]
libcli/smb/smb2_signing: rename smb2_key_deviration -> smb2_key_derivation
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Feb 29 09:01:54 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 12:27:38 +0000 (13:27 +0100)]
s3:torture/test_smb2: test path based calls during reauth in SMB2-MULTI-CHANNEL
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Feb 29 07:23:14 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 12:27:38 +0000 (13:27 +0100)]
s3:torture/test_smb2: test handle based calls during reauth in SMB2-MULTI-CHANNEL
metze
Stefan Metzmacher [Mon, 27 Feb 2012 10:19:22 +0000 (11:19 +0100)]
s3:torture/test_smb2: do a reauth over multiple channels in SMB2-MULTI-CHANNEL
metze
Stefan Metzmacher [Mon, 27 Feb 2012 10:50:40 +0000 (11:50 +0100)]
s3:torture/test_smb2: add a 3rd channel to SMB2-MULTI-CHANNEL
metze
Stefan Metzmacher [Wed, 29 Feb 2012 02:57:34 +0000 (03:57 +0100)]
s3:torture/test_smb2: expect FILE_CLOSED on invalid handles in SMB2-MULTI-CHANNEL
metze
Stefan Metzmacher [Wed, 29 Feb 2012 02:42:52 +0000 (03:42 +0100)]
s4:torture/smb2: remove unused var
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:33:46 +0000 (09:33 +0100)]
libcli/smb/smbXcli: use smb2_key_deviration() to setup SMB 2.24 keys
This uses the key diveration function from "NIST Special Publication 800-108"
in counter mode (section 5.1).
Thanks to Jeremy, Michael and Volker for the debugging!
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Feb 29 04:54:48 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 08:32:33 +0000 (09:32 +0100)]
libcli/smb/smb2_signing: implement aes_cmac_128 based signing for SMB 2.24
metze
Stefan Metzmacher [Wed, 22 Feb 2012 12:13:47 +0000 (13:13 +0100)]
libcli/smb/smb2_signing: add smb2_key_deviration()
This implements a simplified version of "NIST Special Publication 800-108" section 5.1
using hmac-sha256.
Thanks to Jeremy, Michael and Volker for the debugging!
metze
Stefan Metzmacher [Wed, 29 Feb 2012 00:39:31 +0000 (01:39 +0100)]
lib/crypto: add aes_cmac_128_test.c as local.crypto.aes_cmac_128 test
metze
Stefan Metzmacher [Sat, 18 Feb 2012 10:47:31 +0000 (11:47 +0100)]
lib/crypto: add aes_cmac_128* (rfc 4493)
Thanks to Jeremy, Michael and Volker for the debugging!
metze
Volker Lendecke [Tue, 28 Feb 2012 01:47:46 +0000 (02:47 +0100)]
s3: Introduce "req" helper var in reply_lockingX_success
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Feb 29 03:08:53 CET 2012 on sn-devel-104
Volker Lendecke [Tue, 28 Feb 2012 02:14:37 +0000 (03:14 +0100)]
s3: Fix a const warning
Volker Lendecke [Tue, 28 Feb 2012 19:28:55 +0000 (20:28 +0100)]
s3: Add a test that makes a chained open break an oplock
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Feb 29 01:13:03 CET 2012 on sn-devel-104
Volker Lendecke [Tue, 28 Feb 2012 21:36:06 +0000 (22:36 +0100)]
s3: More fix for smbd -i
We need a full re-initialize, otherwise we don't re-init the USR1
signal handler
Jeremy Allison [Tue, 28 Feb 2012 17:47:50 +0000 (09:47 -0800)]
Fix problem reported by Tom Lee <tlee2951@gmail.com> - when calculating
the share security mask, take priviliges into account for the connecting
user.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Feb 28 20:21:26 CET 2012 on sn-devel-104
Andrew Tridgell [Thu, 9 Feb 2012 03:33:09 +0000 (14:33 +1100)]
torture: added samba4-ntvfs target
this will be used for the samba4 server with the ntvfs backend
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Feb 28 13:34:44 CET 2012 on sn-devel-104
Andrew Tridgell [Thu, 9 Feb 2012 03:07:00 +0000 (14:07 +1100)]
s3fs: when samba is logging to stdout, ask smbd to also do so
this prevents make test getting spurious errors about opening log
files in the install prefix
Andrew Tridgell [Wed, 30 Nov 2011 03:08:28 +0000 (14:08 +1100)]
smbd: detect EOF on stdin in --foreground mode
if EOF is detected on stdin then exit
Andrew Tridgell [Tue, 3 Jan 2012 05:48:29 +0000 (16:48 +1100)]
selftest: added a pipe on stdin in s3 child processes
this adds a pipe for STDIN in smbd, nmbd and winbindd when run in
selftest. This allows those processes to detect when they should exit
by looking for EOF on stdin.
Andrew Tridgell [Mon, 2 May 2011 23:35:07 +0000 (09:35 +1000)]
s3fs: added file_server directory
this contains a file server backend that forks and starts smbd
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Tue, 6 Sep 2011 01:34:35 +0000 (11:34 +1000)]
s4-smb_server Remove inetd-mode samba3 hook
Amitay Isaacs [Tue, 28 Feb 2012 07:26:28 +0000 (18:26 +1100)]
upgradedns: Missing rename from upgradedns to samba_upgradedns
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue Feb 28 10:06:03 CET 2012 on sn-devel-104
Michael Adam [Tue, 28 Feb 2012 04:33:23 +0000 (05:33 +0100)]
s4:torture:smb2:durable-open: fix a silly access-after-free panic
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Feb 28 08:33:44 CET 2012 on sn-devel-104
Stefan Metzmacher [Tue, 28 Feb 2012 04:11:23 +0000 (05:11 +0100)]
s3:torture/test_smb2: test a tree_connect during reauth
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Feb 28 06:58:44 CET 2012 on sn-devel-104
Stefan Metzmacher [Tue, 28 Feb 2012 03:24:12 +0000 (04:24 +0100)]
s3:torture/test_smb2: check directory listing during reauth
metze
Michael Adam [Tue, 28 Feb 2012 00:44:10 +0000 (01:44 +0100)]
s4:selftest: skip smb2.session testsuite
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Feb 28 03:19:52 CET 2012 on sn-devel-104
Michael Adam [Tue, 28 Feb 2012 00:27:59 +0000 (01:27 +0100)]
s4:selftest: remove old "samba4.smb2.persistent.handle1" from knownfail - test does not exist
Michael Adam [Sun, 26 Feb 2012 16:53:13 +0000 (17:53 +0100)]
s4:torture:smb2: add new "session" testsuite starting with a session.reconnect test
Michael Adam [Sun, 26 Feb 2012 01:36:13 +0000 (02:36 +0100)]
s4:torture:smb2: add durable_open.reopen2a - variant of reopen2 with session reconnect
Michael Adam [Sun, 26 Feb 2012 00:45:53 +0000 (01:45 +0100)]
s4:torture:smb2: add torture_smb2_connection_ext() that takes previous_session
Michael Adam [Sun, 26 Feb 2012 00:45:00 +0000 (01:45 +0100)]
s4:libcli:smb2: add a smb2_connect_ext variant of smb2_connect that takes a previous_session argument
Michael Adam [Sun, 26 Feb 2012 00:43:50 +0000 (01:43 +0100)]
s4:libcli:smb2: add a previous session argument to smb2_connect_send()
Michael Adam [Sun, 26 Feb 2012 00:36:51 +0000 (01:36 +0100)]
s4:torture:smb2: add previous_session argument to torture_smb2_session_setup()
To allow for doing a session reconnect
Michael Adam [Sat, 25 Feb 2012 21:32:03 +0000 (22:32 +0100)]
s4:libcli:smb2: add a previous session argument to smb2_session_setup_spnego()
So that we can do a session reconnect.
Michael Adam [Sun, 26 Feb 2012 16:35:28 +0000 (17:35 +0100)]
s3:libsmb:smb2: pass previous session ID to session setup, not previous session
We only need the session, and under some circumstances, it might complicate
things for the caller to have to cope with the whole structure (talloc...).
Matthieu Patou [Sat, 25 Feb 2012 00:13:10 +0000 (16:13 -0800)]
s3-winbindd: Close netlogon connection if the status returned by the NetrSamLogonEx call is timeout in the pam_auth_crap path
If not the child process would hang for quite a long time up to the
moment when the connection is cleaned by the kernel (took ~ 20 minutes)
in my tests.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Feb 27 23:10:03 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 12:23:53 +0000 (13:23 +0100)]
s3:torture/test_smb2: show that a session is not valid for path based calls during reauth
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Feb 27 16:29:02 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 12:18:42 +0000 (13:18 +0100)]
s3:torture/test_smb2: show that a session is valid during a multi-leg reauth
metze
Stefan Metzmacher [Mon, 27 Feb 2012 12:26:00 +0000 (13:26 +0100)]
s3:torture/test_smb2: fix missleading file name in reauth test
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:29:53 +0000 (09:29 +0100)]
libcli/smb/smb2_signing: pass down 'protocol' to smb2_signing_[sign|check]_pdu()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Feb 27 14:26:32 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 08:27:51 +0000 (09:27 +0100)]
libcli/smb/smb2_signing: rename session_key to signing_key
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:24:38 +0000 (09:24 +0100)]
libcli/smb/smbXcli: remove unused if statement from smb2cli_conn_dispatch_incoming()
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:20:20 +0000 (09:20 +0100)]
s4:libcli/smb2: remove unused 'session_key' from struct smb2_session
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:16:28 +0000 (09:16 +0100)]
s4:librpc/dcerpc_smb2: make use of smb2cli_session_application_key()
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:03:54 +0000 (09:03 +0100)]
libcli/smb/smbXcli: add smb2cli_session_application_key()
metze
Stefan Metzmacher [Mon, 27 Feb 2012 07:48:55 +0000 (08:48 +0100)]
libcli/smb/smbXcli: maintain smb2 channel_signing_key separate from the signing_key
The signing_key is fix across all channels and is used for session setups
on a channel binding.
Note:
- the last session setup response is signed with the new channel signing key.
- the reauth session setups are signed with the channel signing key.
It's also not needed to remember the main session key.
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:58:53 +0000 (09:58 +0100)]
libcli/smb/smbXcli: remove unused checks from smb2cli_session_create_channel()
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:18:33 +0000 (09:18 +0100)]
s3:torture/test_smb2: remove explicit smb2_signing_check_pdu()
smb2cli_session_set_session_key() already checks the signature
and that function really knows the signing key.
metze
Stefan Metzmacher [Mon, 27 Feb 2012 10:52:50 +0000 (11:52 +0100)]
s3:torture/test_smb2: a reauth doesn't update the session/signing key
metze
Stefan Metzmacher [Wed, 22 Feb 2012 08:01:10 +0000 (09:01 +0100)]
lib/crypto: fix hmac_sha256_final() prototype
metze
Andrew Tridgell [Thu, 9 Feb 2012 03:10:41 +0000 (14:10 +1100)]
dbwrap: changed log level for information about lock order
we were filling our logs with lock ordering debug lines
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 27 12:50:29 CET 2012 on sn-devel-104
Andrew Bartlett [Mon, 13 Feb 2012 06:47:11 +0000 (17:47 +1100)]
selftest: up the default log level in s3
This may help show more detail when our tests fail.
Andrew Bartlett
Andrew Bartlett [Mon, 27 Feb 2012 05:29:14 +0000 (16:29 +1100)]
s3-selftest: avoid running LOCAL- tests twice
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 27 09:07:59 CET 2012 on sn-devel-104
Andrew Bartlett [Mon, 27 Feb 2012 03:24:30 +0000 (14:24 +1100)]
s3-param: Align lp_{max,min}protocol with lib/param names
This adds an alisas to ensure that both our loadparm systems know all
the names.
I would like to move to the 'server ..' name as canonical, and this
will be raised on the list.
Andrew Bartlett
Andrew Tridgell [Thu, 9 Feb 2012 04:14:10 +0000 (15:14 +1100)]
torture: don't check the NOINDEXED bit in attribute comparison
this bit is dependent on user settings on the filesystem
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Mon, 27 Feb 2012 04:36:45 +0000 (15:36 +1100)]
selftest: plugin_s4_dc can now handle kerberos properly
Andrew Bartlett [Mon, 27 Feb 2012 05:46:22 +0000 (16:46 +1100)]
s4-netlogond: Fix use of uninitialised value dns_name
The GET_CHECK_STR macro (now unrolled) did not initialise the trusts->array[n].dns_name
when the value was not set. New tests for our trusted domains code create
domain trusts without a DNS domain name. Found by the autobuild flakey build detector.
Andrew Bartlett
Rusty Russell [Mon, 27 Feb 2012 03:45:47 +0000 (14:15 +1030)]
lib/tdb2: rename tdb2.pc to tdb.pc
The library is called tdb, so the pc file must have the same name.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Mon Feb 27 06:59:58 CET 2012 on sn-devel-104
Jelmer Vernooij [Mon, 27 Feb 2012 02:50:37 +0000 (03:50 +0100)]
upgradehelpers: Simplify transaction handling.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 27 05:25:04 CET 2012 on sn-devel-104
Jelmer Vernooij [Mon, 27 Feb 2012 01:46:31 +0000 (02:46 +0100)]
samba.xattr: Massively simplify copytree_with_xattrs.
Jelmer Vernooij [Sun, 26 Feb 2012 23:53:19 +0000 (00:53 +0100)]
upgradeprovision: Only backup sysvol directory if it exists.
This is not the case for standalone installations.
Bug: https://bugs.launchpad.net/samba/+bug/930370
Bug: https://bugzilla.samba.org/show_bug.cgi?id=8781
Jelmer Vernooij [Sun, 26 Feb 2012 23:50:00 +0000 (00:50 +0100)]
samba.xattr: Split copying of tree with extended attributes out into separate module.
Michael Adam [Thu, 23 Feb 2012 14:49:51 +0000 (15:49 +0100)]
s4:torture:smb2:durable-open: prevent using a disconnected handle in reopen4
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 27 03:44:16 CET 2012 on sn-devel-104
Michael Adam [Thu, 23 Feb 2012 22:43:18 +0000 (23:43 +0100)]
s4:torture:smb2:durable-open: introduce new variable for the new session
This is to clarify the code.
Michael Adam [Thu, 23 Feb 2012 22:25:18 +0000 (23:25 +0100)]
s4:torture:smb2:durable-open: make a comment more precise in the reopen4 test
Michael Adam [Thu, 23 Feb 2012 14:35:15 +0000 (15:35 +0100)]
s4:torture:smb2:durable_open: use the correct tree in the final close call
Jelmer Vernooij [Sun, 26 Feb 2012 22:15:48 +0000 (23:15 +0100)]
provision: Write configuration without help of templates.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 27 00:52:46 CET 2012 on sn-devel-104
Jelmer Vernooij [Sun, 26 Feb 2012 21:43:15 +0000 (22:43 +0100)]
pyparam: fix formatting.
Jelmer Vernooij [Sun, 26 Feb 2012 21:23:27 +0000 (22:23 +0100)]
provision: Simplify make_smbconf a bit.
Jelmer Vernooij [Sun, 26 Feb 2012 21:09:44 +0000 (22:09 +0100)]
provision: Fix order for error formatting.
Jelmer Vernooij [Sun, 26 Feb 2012 20:47:50 +0000 (21:47 +0100)]
provision: Raise proper error when shares are missing rather than AssertionError.
Jelmer Vernooij [Sun, 26 Feb 2012 19:51:04 +0000 (20:51 +0100)]
provision: Share more code for determine_netbios_name() with samba.valid_netbios_name().
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 26 22:24:42 CET 2012 on sn-devel-104
Jelmer Vernooij [Sun, 26 Feb 2012 19:45:43 +0000 (20:45 +0100)]
provision/backend: Properly close all opened files.
Jelmer Vernooij [Sun, 26 Feb 2012 19:42:41 +0000 (20:42 +0100)]
provision: Properly close opened files.
Jelmer Vernooij [Sun, 26 Feb 2012 19:40:26 +0000 (20:40 +0100)]
provision: Reuse determine_netbios_name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:39:13 +0000 (20:39 +0100)]
provision: Add tests for determine_netbios_name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:38:50 +0000 (20:38 +0100)]
provision: Factor out determination of new netbios name.
Jelmer Vernooij [Sun, 26 Feb 2012 15:25:56 +0000 (16:25 +0100)]
join: Don't print provision results when they're just noise.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 26 17:56:57 CET 2012 on sn-devel-104
Jelmer Vernooij [Sun, 26 Feb 2012 15:23:18 +0000 (16:23 +0100)]
provision: Split out result reporting for backends.
Jelmer Vernooij [Sun, 26 Feb 2012 15:07:21 +0000 (16:07 +0100)]
provision: Put adminpass details in ProvisionResult.
Jelmer Vernooij [Sun, 26 Feb 2012 14:56:52 +0000 (15:56 +0100)]
provision/tests: Test for phpldapadminconfig path.
Jelmer Vernooij [Sun, 26 Feb 2012 14:44:40 +0000 (15:44 +0100)]
provision: Leave result reporting up to caller.
Volker Lendecke [Sun, 26 Feb 2012 08:20:38 +0000 (09:20 +0100)]
s3: Remove pointless parentheses
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 26 11:10:15 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 25 Feb 2012 22:42:52 +0000 (23:42 +0100)]
s3-configure: Add CFLAGS_APPEND variable
This makes it possible to add some CFLAGS to the end of the CFLAGS list. I use
it for adding -Wno-unused-value when compiling with clang.
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 26 01:21:49 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 25 Feb 2012 20:27:28 +0000 (21:27 +0100)]
s3: Use the correct enum values
wbcIdType and id_type have the same values, but different names
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Feb 25 23:46:36 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 25 Feb 2012 20:20:21 +0000 (21:20 +0100)]
nsswitch: Remove a pointless if-clause
gr->num_gr_mem is a uint32, so it can never be < 0
Volker Lendecke [Sat, 25 Feb 2012 20:17:40 +0000 (21:17 +0100)]
libcli: Remove a pointless check
"n" is size_t, so it is always >=0.
Jelmer Vernooij [Sat, 25 Feb 2012 19:04:57 +0000 (20:04 +0100)]
provision: Start splitting out provision result reporting from actual provisioning.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Feb 25 22:13:10 CET 2012 on sn-devel-104
Jelmer Vernooij [Sat, 25 Feb 2012 16:55:52 +0000 (17:55 +0100)]
provision: Properly close ldb transactions.
Jelmer Vernooij [Sat, 25 Feb 2012 16:50:14 +0000 (17:50 +0100)]
'samba-tool gpo': Properly close transaction.
Jelmer Vernooij [Sat, 25 Feb 2012 16:36:54 +0000 (17:36 +0100)]
ntacl: There is no 'secrets database' configuration option.
Jelmer Vernooij [Sat, 25 Feb 2012 16:35:41 +0000 (17:35 +0100)]
Factor out sanitize_server_role.