Simo Sorce [Thu, 19 Apr 2012 15:16:03 +0000 (11:16 -0400)]
loadparm: Add helper function to fetch default lifetime policies
This use long to fetch time_t quantities, because there are architectures were
time_t is a signed long but long != int, So long is the proper way to deal with
it.
Simo Sorce [Thu, 19 Apr 2012 15:00:45 +0000 (11:00 -0400)]
loadparm: Add convenience function to return long integers
Simo Sorce [Thu, 19 Apr 2012 14:58:39 +0000 (10:58 -0400)]
loadparm: Fix broken lp_ulong utility function
Simo Sorce [Thu, 19 Apr 2012 14:34:54 +0000 (10:34 -0400)]
Move README file in the right place.
Someone forgot to move the README when they moved the code ...
Joseph Tam [Thu, 19 Apr 2012 18:46:16 +0000 (11:46 -0700)]
Fix bug #8877 - Syslog broken owing to mistyping of debug_settings.syslog.
Setting "syslog only = yes" did not divert log messages to syslog. The test in
lib/util/debug.c:Debug1():747
if( syslog_level < state.settings.syslog )
produces wrong results since .syslog is typed "bool" rather than "int".
The attached patch fixes this by typing this field correctly as "int".
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr 20 00:06:12 CEST 2012 on sn-devel-104
Volker Lendecke [Thu, 19 Apr 2012 14:09:41 +0000 (16:09 +0200)]
s3: Fix Coverity ID 2682 -- NULL_RETURNS
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Apr 19 22:28:34 CEST 2012 on sn-devel-104
Volker Lendecke [Thu, 19 Apr 2012 13:38:25 +0000 (15:38 +0200)]
s3: Fix Coverity ID 2727 to 2740 -- UNINIT
Volker Lendecke [Thu, 19 Apr 2012 13:30:06 +0000 (15:30 +0200)]
s3: Fix Coverity ID 2686 -- RESOURCE_LEAK
Andrew Bartlett [Thu, 19 Apr 2012 12:45:48 +0000 (22:45 +1000)]
s4-python: Ensure we handle the no-eadb case for system xattrs in get/setntacl
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 19 20:51:16 CEST 2012 on sn-devel-104
Daniele Dario [Thu, 19 Apr 2012 10:13:41 +0000 (12:13 +0200)]
Added number of FSMO roles owned by the server we are trying to demote.
Andrew Bartlett [Thu, 19 Apr 2012 12:31:29 +0000 (22:31 +1000)]
s4-provision: Always give the warning if we are using eadb. It really should be for testing only
Volker Lendecke [Thu, 19 Apr 2012 11:32:14 +0000 (13:32 +0200)]
s3: Fix the build on FreeBSD
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Apr 19 19:13:45 CEST 2012 on sn-devel-104
Volker Lendecke [Thu, 19 Apr 2012 09:36:11 +0000 (11:36 +0200)]
s3: Fix Coverity ID 2682: NULL_RETURNS
Volker Lendecke [Thu, 19 Apr 2012 07:03:18 +0000 (09:03 +0200)]
librpc: Make finding newest pidl file more portable
FreeBSD find does not support the -printf argument.
David, please check if this still work for you!
Volker Lendecke [Thu, 19 Apr 2012 09:15:46 +0000 (11:15 +0200)]
s3: Fix Coverity ID 2743: CHECKED_RETURN
Volker Lendecke [Thu, 19 Apr 2012 08:47:07 +0000 (10:47 +0200)]
s3: Fix Coverity ID 2744: CHECKED_RETURN
Volker Lendecke [Thu, 19 Apr 2012 08:27:07 +0000 (10:27 +0200)]
s3: Fix Coverity ID 2745 and 2746: FORWARD_NULL
We can assume that the rbt dbs are around
Volker Lendecke [Thu, 19 Apr 2012 08:20:27 +0000 (10:20 +0200)]
s3: Fix Coverity ID 2747: FORWARD_NULL
For the notify cleanup process we have a notify context without a
messaging entry. We will never call notify_add/remove for this, but
the code should protect against this.
Volker Lendecke [Thu, 19 Apr 2012 08:04:04 +0000 (10:04 +0200)]
s3: Attempt to fix Coverity ID 2748: INTEGER_OVERFLOW
Not sure this will actually please Coverity, but it fixes a severe bug
Volker Lendecke [Thu, 19 Apr 2012 07:51:11 +0000 (09:51 +0200)]
s3: Fix Coverity ID 2749: REVERSE_INULL
Simo Sorce [Mon, 9 Apr 2012 12:33:37 +0000 (08:33 -0400)]
waf: Fix mispelling
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Apr 19 17:36:41 CEST 2012 on sn-devel-104
Simo Sorce [Thu, 19 Apr 2012 13:35:08 +0000 (09:35 -0400)]
Fix Error messages
Björn Jacke [Thu, 19 Apr 2012 11:26:20 +0000 (13:26 +0200)]
s3/ldap: remove outdated netscape ds 5 schema file
remove outdated netscape ds 5 schema file and put a README there pointing to
the FDS schema file instead. This fixes bug #8869
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Thu Apr 19 15:54:56 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 19 Apr 2012 06:31:52 +0000 (16:31 +1000)]
s3-xattr_tdb: Remove dead code: talloc_stackframe() cannot fail
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 19 14:15:42 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 19 Apr 2012 06:31:40 +0000 (16:31 +1000)]
s3-dbwrap: Remove dead code: talloc_stackframe() cannot fail
Andrew Bartlett [Thu, 19 Apr 2012 00:39:56 +0000 (10:39 +1000)]
s3-passdb: Remove unused sampass->pass_must_change_time
There is no need to call pdb_set_pass_must_change_time() because
nothing ever consults that value. It is always calculated from the
domain policy.
Also, this means we no longer store the value in LDAP. The value
would only ever be set when migrating from tdbsam or smbpasswd, not on
password changes, so would become incorrect over time.
Andrew Bartlett
Matthieu Patou [Thu, 19 Apr 2012 08:51:24 +0000 (01:51 -0700)]
s4-kcc: avoid a false alarm with rodc
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Thu Apr 19 12:32:58 CEST 2012 on sn-devel-104
Matthieu Patou [Thu, 19 Apr 2012 08:44:14 +0000 (01:44 -0700)]
samba_spnupdate: don't try to register DNS related SPN if we are not mastering the NC
For RW DC the impact is pretty small but for RODC the whole SPN set is
rejected by the target DC as RODC hasn't the right to register DNS SPN
if it is not mastering this NC.
Volker Lendecke [Thu, 19 Apr 2012 06:24:27 +0000 (08:24 +0200)]
s3: Fix a "ISO C90 forbids mixed declarations and code"
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Apr 19 10:32:27 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 19 Apr 2012 04:14:35 +0000 (14:14 +1000)]
dbcheck: Add a check that every FSMO role has a valid owner
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 19 07:49:54 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 19 Apr 2012 03:57:29 +0000 (13:57 +1000)]
s4-samba-tool: Fix samba-tool fsmo seize
This is currently untested, and a restructure broke it.
Andrew Bartlett
Andrew Bartlett [Thu, 19 Apr 2012 00:42:05 +0000 (10:42 +1000)]
s4-s3upgrade: Do not ever set a domain-wide maxPwdAge of 0
This means no-expiry in s3, and so we must treat it like -1.
Andrew Bartlett
Andrew Bartlett [Wed, 18 Apr 2012 23:59:40 +0000 (09:59 +1000)]
s4-s3upgrade: Ignore (with warning) groups that are listed but we cannot list members for
Jeremy Allison [Wed, 18 Apr 2012 19:38:06 +0000 (12:38 -0700)]
Fix samba3.raw.samba3hide test - ensure we set up POSIX capabilities
before doing POSIX calls like chmod.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 18 23:14:40 CEST 2012 on sn-devel-104
Jeremy Allison [Wed, 18 Apr 2012 19:37:20 +0000 (12:37 -0700)]
Add smb_raw_setfsinfo() - currently only available level is SMB_SET_CIFS_UNIX_INFO.
Jeremy Allison [Wed, 18 Apr 2012 19:36:19 +0000 (12:36 -0700)]
Ensure we have 12 bytes of data for a SMB_SET_CIFS_UNIX_INFO call. Add debug.
Volker Lendecke [Wed, 18 Apr 2012 16:05:24 +0000 (18:05 +0200)]
s4-torture: Fix the raw.notify mask test
When we do the notify triggers via a different client connection, adding the
notify record becomes subject to a race. Add a dummy operation after the
initial changenotify request was sent to make sure the notify record actually
arrived.
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Apr 18 19:47:53 CEST 2012 on sn-devel-104
Volker Lendecke [Wed, 18 Apr 2012 12:45:20 +0000 (14:45 +0200)]
s4-torture: Use 2 client connections for raw.notify.mask
This makes the test more interesting in a cluster
Volker Lendecke [Wed, 18 Apr 2012 12:45:20 +0000 (14:45 +0200)]
s4-torture: Use 2 client connections for raw.notify.tree
This makes the test more interesting in a cluster
Volker Lendecke [Wed, 18 Apr 2012 12:45:20 +0000 (14:45 +0200)]
s4-torture: Use 2 client connections for raw.notify.recursive
This makes the test more interesting in a cluster
Volker Lendecke [Wed, 18 Apr 2012 12:23:06 +0000 (14:23 +0200)]
s3-dbwrap: Fix an unused var warning
Michael Adam [Wed, 18 Apr 2012 12:12:28 +0000 (14:12 +0200)]
s4:torture:smb2: add a session.reauth2 test.
* open a file,
* reauth anonymously
* try to access file via handle
* reauth as user
* try to access file again
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Apr 18 16:53:35 CEST 2012 on sn-devel-104
Michael Adam [Mon, 16 Apr 2012 12:58:48 +0000 (14:58 +0200)]
s4:torture:smb2: rename the file in the session-reauth1 test more systematically
The original name seems to have come in via copy and paste.
Michael Adam [Mon, 16 Apr 2012 12:57:18 +0000 (14:57 +0200)]
s4:torture:smb2: rename the session_reauth test to session_reauth1
More tests reauth? will follow...
Volker Lendecke [Wed, 18 Apr 2012 10:57:06 +0000 (12:57 +0200)]
s4-torture: notify all is empty now
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Apr 18 15:16:13 CEST 2012 on sn-devel-104
Volker Lendecke [Wed, 18 Apr 2012 10:56:39 +0000 (12:56 +0200)]
s4-torture: Separate out the notify alignment subtest
Volker Lendecke [Wed, 18 Apr 2012 10:54:25 +0000 (12:54 +0200)]
s4-torture: Separate out the notify basedir subtest
Volker Lendecke [Wed, 18 Apr 2012 10:53:08 +0000 (12:53 +0200)]
s4-torture: Separate out the notify overflow subtest
Volker Lendecke [Wed, 18 Apr 2012 10:51:26 +0000 (12:51 +0200)]
s4-torture: Separate out the notify tree subtest
Volker Lendecke [Wed, 18 Apr 2012 10:49:55 +0000 (12:49 +0200)]
s4-torture: Separate out the notify double subtest
Volker Lendecke [Wed, 18 Apr 2012 10:47:39 +0000 (12:47 +0200)]
s4-torture: Separate out the notify tcp_dis subtest
Volker Lendecke [Wed, 18 Apr 2012 10:44:21 +0000 (12:44 +0200)]
s4-torture: Separate out the notify ulogoff subtest
Volker Lendecke [Wed, 18 Apr 2012 10:42:13 +0000 (12:42 +0200)]
s4-torture: Separate out the notify exit subtest
Volker Lendecke [Wed, 18 Apr 2012 10:39:08 +0000 (12:39 +0200)]
s4-torture: Separate out the notify tdis subtest
Volker Lendecke [Wed, 18 Apr 2012 10:31:12 +0000 (12:31 +0200)]
s4-torture: Separate out the notify file subtest
Volker Lendecke [Wed, 18 Apr 2012 10:27:38 +0000 (12:27 +0200)]
s4-torture: Separate out the notify mask_change subtest
Volker Lendecke [Wed, 18 Apr 2012 10:24:59 +0000 (12:24 +0200)]
s4-torture: Separate out the notify recursive subtest
Volker Lendecke [Wed, 18 Apr 2012 10:22:31 +0000 (12:22 +0200)]
s4-torture: Separate out the notify mask subtest
Volker Lendecke [Wed, 18 Apr 2012 10:19:12 +0000 (12:19 +0200)]
s4-torture: Separate out the notify dir subtest
Volker Lendecke [Wed, 18 Apr 2012 09:47:48 +0000 (11:47 +0200)]
s4-torture: Separate out the notify tcon subtest
Volker Lendecke [Wed, 18 Apr 2012 09:43:12 +0000 (11:43 +0200)]
s4-torture: Make notify a suite
Volker Lendecke [Wed, 18 Apr 2012 09:49:35 +0000 (11:49 +0200)]
libsmb: Actually use an introduced variable
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Apr 18 13:39:53 CEST 2012 on sn-devel-104
Volker Lendecke [Wed, 18 Apr 2012 08:22:39 +0000 (10:22 +0200)]
Talloc doc: Fix a cut&paste error
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Apr 18 11:59:49 CEST 2012 on sn-devel-104
Pavel Březina [Mon, 16 Apr 2012 13:23:55 +0000 (15:23 +0200)]
Talloc doc: talloc_pool() when not enough memory in the pool
Pavel Březina [Mon, 16 Apr 2012 13:04:44 +0000 (15:04 +0200)]
Talloc doc: TALLOC_FREE_FILL
Pavel Březina [Mon, 16 Apr 2012 12:49:03 +0000 (14:49 +0200)]
Talloc doc: talloc_set_log_stderr()
Documents this function.
Pavel Březina [Mon, 16 Apr 2012 12:47:16 +0000 (14:47 +0200)]
Talloc doc: talloc_set_log_fn()
Documents this function.
Pavel Březina [Mon, 16 Apr 2012 12:43:37 +0000 (14:43 +0200)]
Talloc doc: talloc_set_abort_fn()
Documents this function.
Pavel Březina [Mon, 16 Apr 2012 11:32:02 +0000 (13:32 +0200)]
Talloc doc: talloc_asprintf_append_buffer()
Explains the difference between _append and _append_buffer.
Pavel Březina [Mon, 16 Apr 2012 11:17:59 +0000 (13:17 +0200)]
Talloc doc: talloc_strndup_append_buffer()
Explains the difference between _append and _append_buffer.
Pavel Březina [Mon, 16 Apr 2012 11:12:41 +0000 (13:12 +0200)]
Talloc doc: talloc_strndup_append()
The destination string is reallocated instead of duplicating the result.
Pavel Březina [Mon, 16 Apr 2012 10:59:22 +0000 (12:59 +0200)]
Talloc doc: talloc_strdup_append_buffer()
Explains the difference between _append and _append_buffer.
Pavel Březina [Mon, 16 Apr 2012 10:44:08 +0000 (12:44 +0200)]
Talloc doc: talloc_strdup_append()
The destination string is reallocated instead of duplicating the result.
Andrew Tridgell [Wed, 18 Apr 2012 05:46:14 +0000 (15:46 +1000)]
dbcheck: added fix for incorrect RMD_FLAGS
this fixes the case where a DN link has RMD_FLAGS=0 for a link inside
a deleted object
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Apr 18 09:19:41 CEST 2012 on sn-devel-104
Andrew Tridgell [Wed, 18 Apr 2012 05:45:31 +0000 (15:45 +1000)]
dsdb: added SHOW_DELETED to samldb_member_check()
when dbcheck is fixing DNs, it will sometimes operated on a deleted DN
link
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 18 Apr 2012 04:35:17 +0000 (14:35 +1000)]
replace: added ENOATTR define if undefined
this fixes the build of the tdb xattr wrapper code on systems without
xattr headers
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Wed, 11 Apr 2012 15:18:37 +0000 (17:18 +0200)]
s4:dbchecker.py - integrate the "objectClass" fixing code
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 11 Apr 2012 14:06:03 +0000 (16:06 +0200)]
s4:dsdb/pydsdb.c - call the "objectClass" normalisation code from Python
This allows the dbchecker to fix ordering/inconsistency problems with
the mentioned attribute.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 11 Apr 2012 19:09:38 +0000 (21:09 +0200)]
LDB:ldb_tdb/ldb_tdb.c - allow LDB modify replaces with different value ordering
This is essential for fixing up wrong ordered "objectClass" attributes.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Tridgell [Tue, 17 Apr 2012 04:01:08 +0000 (14:01 +1000)]
ldb: added ldb_msg_element_equal_ordered()
this gives us a order sensitive msg element comparison. We need this
to allow dbcheck to fix the order of objectClass attributes.
Jeremy Allison [Wed, 18 Apr 2012 03:20:28 +0000 (20:20 -0700)]
Add docs for aio_linux vfs module.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 18 07:20:19 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 16 Apr 2012 09:01:15 +0000 (19:01 +1000)]
s3fs: Use xattr_tdb format for xattr storage
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Apr 18 05:39:01 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 16 Apr 2012 08:59:34 +0000 (18:59 +1000)]
s4-python: Add python wrapper for xattr_tdb format xattr storage
This uses the format used by the vfs_xattr_tdb module. The s4
posix:eadb format is kept, just in a new file and module.
Andrew Bartlett
Andrew Bartlett [Mon, 16 Apr 2012 12:18:14 +0000 (22:18 +1000)]
s3-xattr_tdb: Use talloc_stackframe() more to allow calling from common code
Andrew Bartlett [Mon, 16 Apr 2012 07:14:06 +0000 (17:14 +1000)]
s3-xattr_tdb: Be nice to xattr_tdb_getxattr callers, return the full blob
In this case, the blob is already in memory, so it is easier to return the full
blob to the caller, and let the caller decide if some interface restriction
stops the full blob from being passed all the way up the stack.
This allows us to quickly write a python wrapper for this xattr storage
mechanism.
Andrew Bartlett
Andrew Bartlett [Mon, 16 Apr 2012 05:49:13 +0000 (15:49 +1000)]
s3-xattr_tdb: make xattr_tdb a private library, for use outside vfs_xattr_tdb
Andrew Bartlett [Mon, 16 Apr 2012 05:36:15 +0000 (15:36 +1000)]
s3-lib: Add file_id_string()
Andrew Bartlett [Mon, 16 Apr 2012 05:34:40 +0000 (15:34 +1000)]
s3-build: move file_id.c into samba3-util and create a private header
Andrew Bartlett [Mon, 16 Apr 2012 04:21:33 +0000 (14:21 +1000)]
dbwrap: Add dbwrap_tdb to private dbwrap library
Andrew Bartlett
Andrew Bartlett [Mon, 16 Apr 2012 04:20:46 +0000 (14:20 +1000)]
s3-build: Add missing samba3-util dep to tdb-wrap3
Andrew Bartlett [Mon, 16 Apr 2012 04:18:49 +0000 (14:18 +1000)]
lib/util: Move map_nt_error_from_tdb to the top level
This will help with making dbwrap available as a top level library.
Andrew Bartlett
Andrew Bartlett [Mon, 16 Apr 2012 03:37:39 +0000 (13:37 +1000)]
s3-dbwrap: push lp_ctx up another layer in the stack
This will allow db_open_tdb() to be called from common code, which may
already have a loadparm context loaded.
It also slowly moves the lp_ctx up the stack, as required to remove
the library loop between smbconf and the registry.
Andrew Bartlett
Andrew Bartlett [Mon, 16 Apr 2012 03:36:01 +0000 (13:36 +1000)]
s3-dbwrap: Add talloc_stackframe() calls
This is in preperation for calling dbwrap from common code, where we may not
have a stackframe set up.
Andrew Bartlett
Andrew Bartlett [Tue, 17 Apr 2012 01:25:40 +0000 (11:25 +1000)]
build: Remove more of the s3 special cases in waf: only pidfile.c needs -DCONFIGFILE
Michael Adam [Fri, 6 Apr 2012 00:20:37 +0000 (02:20 +0200)]
s4:samdb:rootdse: implement the schemaUpgradeInProgress operation in ldap modify
This is preliminary in that it is implemented as a no-op for a start
just to be able to successfully answer the request, which seems to be
sufficient in order to e.g. survive the exchange schema extensions.
Signed-off-by: Matthieu Patou <mat@matws.net>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Apr 18 02:48:28 CEST 2012 on sn-devel-104
Matthieu Patou [Tue, 17 Apr 2012 06:24:10 +0000 (23:24 -0700)]
s4-schema: set subClassOf by default to top if not specified
Signed-off-by: Michael Adam <obnox@samba.org>
Matthieu Patou [Mon, 16 Apr 2012 22:34:24 +0000 (15:34 -0700)]
s4-schema: remove unused variable
Matthieu Patou [Mon, 16 Apr 2012 22:22:24 +0000 (15:22 -0700)]
s4-schema: Generate some schema related attribute as MS AD is doing if they are not present in ldb requests
Matthieu Patou [Sun, 15 Apr 2012 21:50:20 +0000 (14:50 -0700)]
s4-schema: rename dsdb_attribute_from_ldb to dsdb_set_attribute_from_ldb and dsdb_class_from_ldb to dsdb_set_class_from_ldb
Matthieu Patou [Sun, 15 Apr 2012 19:37:00 +0000 (12:37 -0700)]
s4: use enums instead of strings it's cheaper