Guy Harris [Thu, 6 Sep 2012 08:21:51 +0000 (08:21 -0000)]
Fix some of the links for Subversion, which is now at
subversion.apache.org.
svn path=/trunk/; revision=44787
Anders Broman [Thu, 6 Sep 2012 08:03:15 +0000 (08:03 -0000)]
From Chris Elston:
Add support for control message authentication checking for IP encapsulated L2TPv3 packets.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7700
svn path=/trunk/; revision=44786
Pascal Quantin [Wed, 5 Sep 2012 21:23:50 +0000 (21:23 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7701 :
Do sanity check on option length earlier
svn path=/trunk/; revision=44785
Gerald Combs [Wed, 5 Sep 2012 20:58:15 +0000 (20:58 -0000)]
Run 'git log' if we have a .git directory. Fixes a copy+paste error.
svn path=/trunk/; revision=44784
Martin Kaiser [Wed, 5 Sep 2012 20:31:52 +0000 (20:31 -0000)]
fix compilation on Win7x64 (I hope)
svn path=/trunk/; revision=44783
Martin Kaiser [Wed, 5 Sep 2012 20:08:09 +0000 (20:08 -0000)]
add modelines for the ftp dissector
svn path=/trunk/; revision=44782
Martin Kaiser [Wed, 5 Sep 2012 19:51:57 +0000 (19:51 -0000)]
from Alexander Koeppe
ftp PASV and PORT commands: mark ip address and port in data view
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7693
svn path=/trunk/; revision=44781
Gerald Combs [Wed, 5 Sep 2012 19:00:41 +0000 (19:00 -0000)]
The Qt documentation is mysteriously silent about where qmake can find
Qt DLLs on Windows. %QTDIR%? $$QMAKE_LIBDIR_QT? "qmkake -query" says
$$[QT_INSTALL_BINS] so we'll try that.
svn path=/trunk/; revision=44780
Pascal Quantin [Wed, 5 Sep 2012 12:45:54 +0000 (12:45 -0000)]
Replace process_RequestOperation macro by a real function to speedup compilation time
svn path=/trunk/; revision=44779
Anders Broman [Wed, 5 Sep 2012 11:54:09 +0000 (11:54 -0000)]
Update value_strings
svn path=/trunk/; revision=44778
Pascal Quantin [Wed, 5 Sep 2012 10:16:24 +0000 (10:16 -0000)]
From Harald Welte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7696 :
packet-gsm_abis_om2000: Add support for MO IF bytes 2 and 3
svn path=/trunk/; revision=44777
Pascal Quantin [Wed, 5 Sep 2012 09:54:42 +0000 (09:54 -0000)]
From Harald Welte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7695 :
Fix minor inconsistency in packet-gsm_abis_om2000.c
svn path=/trunk/; revision=44776
Anders Broman [Wed, 5 Sep 2012 07:40:36 +0000 (07:40 -0000)]
From Jared August:
PTPv2: Added IEEE C37.238 TLV support
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7694
svn path=/trunk/; revision=44775
Evan Huus [Wed, 5 Sep 2012 01:44:09 +0000 (01:44 -0000)]
Remove string constants from g_assert() calls, as per thread on wireshark-dev:
http://www.wireshark.org/lists/wireshark-dev/201209/msg00030.html
svn path=/trunk/; revision=44774
Pascal Quantin [Tue, 4 Sep 2012 20:43:24 +0000 (20:43 -0000)]
Add dissection of SIP Servers option to DHCPv4 (RFC 3361)
svn path=/trunk/; revision=44773
Guy Harris [Tue, 4 Sep 2012 20:42:21 +0000 (20:42 -0000)]
Use libwireshark's xDLC handling functions and macros to process the
control field. This means processing the AX.25 header data in one pass.
The field after the control field is the "protocol identifier" field,
not the "packet identifier" field.
svn path=/trunk/; revision=44772
Pascal Quantin [Tue, 4 Sep 2012 18:26:18 +0000 (18:26 -0000)]
Fix compilation with gcc
svn path=/trunk/; revision=44771
Pascal Quantin [Tue, 4 Sep 2012 18:14:20 +0000 (18:14 -0000)]
Set SVN properties
svn path=/trunk/; revision=44770
Michael Mann [Tue, 4 Sep 2012 17:54:27 +0000 (17:54 -0000)]
Add GED125 dissector
Bug 2692 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2692)
svn path=/trunk/; revision=44769
Anders Broman [Tue, 4 Sep 2012 08:57:03 +0000 (08:57 -0000)]
From Pontus Fuchs:
Fall back to CMD_SET_WIPHY for older kernels.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6973
svn path=/trunk/; revision=44768
Alexis La Goutte [Tue, 4 Sep 2012 08:19:08 +0000 (08:19 -0000)]
Add modelines for DNS dissector
svn path=/trunk/; revision=44767
Alexis La Goutte [Tue, 4 Sep 2012 08:18:31 +0000 (08:18 -0000)]
Add modelines for Qtshark file
svn path=/trunk/; revision=44766
Jörg Mayer [Tue, 4 Sep 2012 02:35:25 +0000 (02:35 -0000)]
- Replace packet_list_recreate_visible_rows -> packet_list_recreate_visible_rows_list
- Replace new_packet_list_ -> packet_list_
svn path=/trunk/; revision=44765
Jörg Mayer [Tue, 4 Sep 2012 01:57:36 +0000 (01:57 -0000)]
Rename new_packet_list.[ch] to packet_list.[ch]
svn path=/trunk/; revision=44764
Jörg Mayer [Tue, 4 Sep 2012 00:42:07 +0000 (00:42 -0000)]
Small whitespace changes
svn path=/trunk/; revision=44763
Martin Kaiser [Mon, 3 Sep 2012 21:25:07 +0000 (21:25 -0000)]
unify the handling for all DVB/MPEG sections
don't initialize pointer where it's not required
remove unnecessary 'if (tree)' checks
svn path=/trunk/; revision=44762
Martin Kaiser [Mon, 3 Sep 2012 21:18:50 +0000 (21:18 -0000)]
highlight only the actual bytes of EIT, SDT, TDT, TOT and BAT
minor whitespace cleanup
skip initialization and 'if (tree)' where it's not required
svn path=/trunk/; revision=44761
Martin Kaiser [Mon, 3 Sep 2012 21:11:01 +0000 (21:11 -0000)]
fix a typo in dvb service descriptor
svn path=/trunk/; revision=44760
Jeff Morriss [Mon, 3 Sep 2012 19:56:25 +0000 (19:56 -0000)]
LIBGCRYPT_CFLAGS and LIBGNUTLS_CFLAGS don't seem to be necessary here.
svn path=/trunk/; revision=44759
Jeff Morriss [Mon, 3 Sep 2012 19:53:35 +0000 (19:53 -0000)]
(Attempt to) fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7411 :
Use LIBGCRYPT_CFLAGS if we have it.
svn path=/trunk/; revision=44758
Jeff Morriss [Mon, 3 Sep 2012 19:33:45 +0000 (19:33 -0000)]
Don't fetch the value twice (unsigned integer case). Fix a cut-n-pasteo.
svn path=/trunk/; revision=44757
Martin Kaiser [Mon, 3 Sep 2012 18:50:21 +0000 (18:50 -0000)]
add modelines for dvb sections
svn path=/trunk/; revision=44756
Martin Kaiser [Mon, 3 Sep 2012 18:37:03 +0000 (18:37 -0000)]
add editor modelines (that match the current indentation style)
svn path=/trunk/; revision=44755
Martin Kaiser [Mon, 3 Sep 2012 17:56:24 +0000 (17:56 -0000)]
add a vertical scrollbar to the text input windows for capture comment
and packet comment
scrollbar is shown only when the text does not fit into the window
this fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7677
svn path=/trunk/; revision=44754
Pascal Quantin [Mon, 3 Sep 2012 17:11:55 +0000 (17:11 -0000)]
Add missing newline at end of file
svn path=/trunk/; revision=44753
Jakub Zawadzki [Mon, 3 Sep 2012 15:21:38 +0000 (15:21 -0000)]
When inserting row there's no need to call packet_list_get_iter.
Also, don't set iter.user_data[23] in packet_list_get_iter().
We don't use them in packet_list_store.
svn path=/trunk/; revision=44752
Jakub Zawadzki [Mon, 3 Sep 2012 15:15:59 +0000 (15:15 -0000)]
new_packet_list: cleanup show_cell_data_func
- remove one level of indent (first if not really requied)
- when fdata->color_filter don't copy fg_color, bg_color
to temporary color_t structures,
color_t_to_gdkcolor() don't modify them.
svn path=/trunk/; revision=44751
Jakub Zawadzki [Mon, 3 Sep 2012 15:12:49 +0000 (15:12 -0000)]
cinfo.columns_changed is only used by ui/gtk, move it to cfile structure.
svn path=/trunk/; revision=44750
Pascal Quantin [Mon, 3 Sep 2012 12:48:57 +0000 (12:48 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7666 :
Check that DRDA command has a minimum length of 10 bytes to prevent a potential infinite loop
svn path=/trunk/; revision=44749
Jakub Zawadzki [Mon, 3 Sep 2012 12:00:40 +0000 (12:00 -0000)]
MT: move global frame_end_routines to packet_info.
svn path=/trunk/; revision=44748
Jakub Zawadzki [Mon, 3 Sep 2012 12:00:08 +0000 (12:00 -0000)]
MT: move global field_info_tmp to tree_data_t
svn path=/trunk/; revision=44747
Pascal Quantin [Mon, 3 Sep 2012 06:50:19 +0000 (06:50 -0000)]
From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7688 :
Fix right-click filters of procedures in the SCSI SRT statistics for SBC (broken by r43993)
svn path=/trunk/; revision=44746
Ronnie Sahlberg [Sun, 2 Sep 2012 21:46:50 +0000 (21:46 -0000)]
SCSI: lots of MMC improvements and prettifications
svn path=/trunk/; revision=44745
Ronnie Sahlberg [Sun, 2 Sep 2012 20:02:29 +0000 (20:02 -0000)]
SCSI: Improve decoding of GET_EVENT_STATUS_NOTIFICATION
svn path=/trunk/; revision=44744
Evan Huus [Sun, 2 Sep 2012 17:12:12 +0000 (17:12 -0000)]
Use parentheses to clarify ambiguous operator precedence.
svn path=/trunk/; revision=44743
Evan Huus [Sun, 2 Sep 2012 16:46:39 +0000 (16:46 -0000)]
Fix compile with gcc. Mostly removing unused parameters and code.
Change one tvb_get_bits8 to tvb_get_bits16 since the queried length is
9 bits long (should this be added to checkAPI somehow?)
svn path=/trunk/; revision=44742
Anders Broman [Sun, 2 Sep 2012 15:05:43 +0000 (15:05 -0000)]
From Mike Morrin:
Enhancemnt to GSM RLCMAC dissection adding dissection of data block headers
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615
svn path=/trunk/; revision=44741
Gerald Combs [Sun, 2 Sep 2012 14:03:30 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-09-02]
svn path=/trunk/; revision=44738
Anders Broman [Sun, 2 Sep 2012 09:47:49 +0000 (09:47 -0000)]
Add default branch to try to fix buildbot [-Werror=switch]
svn path=/trunk/; revision=44737
Anders Broman [Sun, 2 Sep 2012 08:36:38 +0000 (08:36 -0000)]
From Cal Turney: Incorrect io-stat table format when unsupported -t operand is specified and when using AVG of relative_time fields https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7685
svn path=/trunk/; revision=44736
Michael Mann [Sun, 2 Sep 2012 02:28:55 +0000 (02:28 -0000)]
length check "heuristics" for FF dissector (UDP + TCP)
Fix compiler error
"Fix" WTP+WSP packets incorrectly dissected as Foundation FieldBus packets https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4822
svn path=/trunk/; revision=44735
Evan Huus [Sat, 1 Sep 2012 23:33:54 +0000 (23:33 -0000)]
Clean up mgcpDialedDigits and add modelines.
Build the digit string directly in heap memory. This removes
the (arbitrary?) length limit and saves us the cost of a g_strdup.
Also does away with a cppcheck warning.
svn path=/trunk/; revision=44734
Evan Huus [Sat, 1 Sep 2012 23:13:03 +0000 (23:13 -0000)]
Remove a bunch of unused variables.
Protect a pointer dereference by moving it so it's guarded by the existing
null check.
Issues caught by cppcheck.
svn path=/trunk/; revision=44733
Guy Harris [Sat, 1 Sep 2012 19:42:53 +0000 (19:42 -0000)]
Include packet-6lowpan.h in the release tarball.
svn path=/trunk/; revision=44732
Evan Huus [Sat, 1 Sep 2012 16:20:43 +0000 (16:20 -0000)]
Add expert warning when we get a mysql EOF marker and the
connection is in a state where we're not expecting one.
svn path=/trunk/; revision=44731
Evan Huus [Sat, 1 Sep 2012 15:12:43 +0000 (15:12 -0000)]
Add modelines and make indentation consistent.
svn path=/trunk/; revision=44730
Evan Huus [Sat, 1 Sep 2012 15:00:49 +0000 (15:00 -0000)]
Remove duplicate assignment (caught by cppcheck).
svn path=/trunk/; revision=44729
Chris Maynard [Sat, 1 Sep 2012 14:16:40 +0000 (14:16 -0000)]
Add Litao Gao (contribution via bug7673).
svn path=/trunk/; revision=44728
Evan Huus [Sat, 1 Sep 2012 13:49:42 +0000 (13:49 -0000)]
Don't leak memory when given an empty remote host (caught by cppcheck).
svn path=/trunk/; revision=44727
Evan Huus [Sat, 1 Sep 2012 13:37:04 +0000 (13:37 -0000)]
Temporarilly comment out param names while they're unused (basically
until the functions are implemented) so qtshark will compile with gcc.
svn path=/trunk/; revision=44726
Evan Huus [Sat, 1 Sep 2012 13:02:14 +0000 (13:02 -0000)]
Fix C++-style comment caught by checkAPI.
svn path=/trunk/; revision=44725
Anders Broman [Sat, 1 Sep 2012 12:06:58 +0000 (12:06 -0000)]
Revert
length check "heuristics" for FF dissector (UDP + TCP)
"Fix" WTP+WSP packets incorrectly dissected as Foundation FieldBus packets https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4822
As it fails with
cc1: warnings being treated as errors
packet-ff.c: In function 'dissect_ff_tcp':
packet-ff.c:13061: warning: passing argument 7 of 'tcp_dissect_pdus' from incompatible pointer type
svn path=/trunk/; revision=44724
Anders Broman [Sat, 1 Sep 2012 11:54:16 +0000 (11:54 -0000)]
From Owen Kirby:
6LoWPAN: Automatic context detection and draft-ietf-6lowpan-nd-19 updates.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7521
svn path=/trunk/; revision=44723
Anders Broman [Sat, 1 Sep 2012 11:37:42 +0000 (11:37 -0000)]
From Michael Mann:
length check "heuristics" for FF dissector (UDP + TCP)
"Fix" WTP+WSP packets incorrectly dissected as Foundation FieldBus packets https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4822
svn path=/trunk/; revision=44722
Anders Broman [Sat, 1 Sep 2012 11:22:29 +0000 (11:22 -0000)]
From Litao Gao:
Implementation of IRemoteSCMActivator::RemoteCreateInstance and some minor bug fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7673
svn path=/trunk/; revision=44721
Anders Broman [Sat, 1 Sep 2012 07:42:07 +0000 (07:42 -0000)]
From David Ward: OSPF dissector: add filters for v3 LS Type field. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7684
svn path=/trunk/; revision=44720
Evan Huus [Sat, 1 Sep 2012 02:56:32 +0000 (02:56 -0000)]
Fix part of build on latest GCC.
svn path=/trunk/; revision=44719
Gerald Combs [Fri, 31 Aug 2012 23:37:10 +0000 (23:37 -0000)]
Don't try to read from our input pipe on Windows after we're done capturing.
svn path=/trunk/; revision=44718
Gerald Combs [Fri, 31 Aug 2012 23:18:45 +0000 (23:18 -0000)]
Connect and disconnect our signals correctly.
Capture still doesn't work correctly under Windows.
svn path=/trunk/; revision=44717
Gerald Combs [Fri, 31 Aug 2012 23:13:43 +0000 (23:13 -0000)]
Fix compilation on Windows.
The moc man page says "The moc does not expand #include or #define,
it simply skips any preprocessor directives it encounters." This means
our signals and slots have to exist everywhere, even if they're empty
on some platforms.
Remove some duplicate definitions.
svn path=/trunk/; revision=44716
Gerald Combs [Fri, 31 Aug 2012 22:50:44 +0000 (22:50 -0000)]
Initialize a variable so that we can quit. Remove some debugging
statements.
svn path=/trunk/; revision=44715
Gerald Combs [Fri, 31 Aug 2012 22:25:51 +0000 (22:25 -0000)]
It ain't Wireshark unless we can capture.
Implement basic capture start and stop. Add a lot of menu items and
enable and disable them when appropriate. Rename a few variables.
Next step: Let the user select an interface (we just use the default for
now).
svn path=/trunk/; revision=44714
Alexis La Goutte [Fri, 31 Aug 2012 12:11:44 +0000 (12:11 -0000)]
Add Q&A icon for qtshark
svn path=/trunk/; revision=44713
Alexis La Goutte [Fri, 31 Aug 2012 12:04:35 +0000 (12:04 -0000)]
Add icon for Q&A (Ask)
The same (fav)icon of Ask Website
svn path=/trunk/; revision=44712
Anders Broman [Fri, 31 Aug 2012 09:39:52 +0000 (09:39 -0000)]
From Chris Elston:
Added L2TPv3 control message authentication checking
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7680
svn path=/trunk/; revision=44711
Anders Broman [Fri, 31 Aug 2012 09:29:34 +0000 (09:29 -0000)]
From Chris Elston:
Split md5_hmac for incremental use
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7680
svn path=/trunk/; revision=44710
Anders Broman [Fri, 31 Aug 2012 09:25:36 +0000 (09:25 -0000)]
From Chris Elston:
Split sha1_hmac for incremental use.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7680
svn path=/trunk/; revision=44709
Alexis La Goutte [Fri, 31 Aug 2012 07:56:24 +0000 (07:56 -0000)]
File => Open (Ctrl+O) on Qtshark (broke with last change...)
Use Qt:Autoconnect SLOT/Signal
svn path=/trunk/; revision=44708
Anders Broman [Fri, 31 Aug 2012 07:30:01 +0000 (07:30 -0000)]
From Cal Turney: Fix Performance regression in tshark -z io,stat https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7674
svn path=/trunk/; revision=44707
Chris Maynard [Thu, 30 Aug 2012 20:36:53 +0000 (20:36 -0000)]
tools/checkhf.pl reported 3 unused hf entries. Commented them out for now.
BTW:
tools/checkAPIs.pl reports 109 useless add_text()'s vs. 346 add_<something else>() calls (31.50%), under 50% threshhold, but not really that great.
tools/checkfiltername.pl reports 42 errors.
svn path=/trunk/; revision=44706
Jeff Morriss [Thu, 30 Aug 2012 20:22:09 +0000 (20:22 -0000)]
Remove trailing space in some hf names.
Add some hf names (some entries had only a space for a name).
Remove non-ASCII chars and C++/C99-style comments.
svn path=/trunk/; revision=44705
Pascal Quantin [Thu, 30 Aug 2012 19:13:38 +0000 (19:13 -0000)]
Display hf_dns_rr_opt_client_addr as FT_BYTES
svn path=/trunk/; revision=44704
Anders Broman [Thu, 30 Aug 2012 18:40:49 +0000 (18:40 -0000)]
Add Japanese ISUP variant(not all IE's)
IE dissection code from Brian Mceniery.
svn path=/trunk/; revision=44703
Alexis La Goutte [Thu, 30 Aug 2012 17:03:50 +0000 (17:03 -0000)]
From David Drysdale via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7552
Add support for EDNS0 option from draft-vandergaast-edns-client-subnet-01
From me
* use/prefer proto_tree_add_item
* use switch() for optcode (may be there is other optcode later...)
svn path=/trunk/; revision=44702
Chris Maynard [Thu, 30 Aug 2012 15:23:54 +0000 (15:23 -0000)]
Fix Session ID parsing. Patch from Fransesco Fondelli via bug 6881.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6881
svn path=/trunk/; revision=44701
Pascal Quantin [Thu, 30 Aug 2012 12:08:53 +0000 (12:08 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7679:
Do not try to set IR header length when the profile is unknown
svn path=/trunk/; revision=44700
Evan Huus [Wed, 29 Aug 2012 22:53:21 +0000 (22:53 -0000)]
Fix uninitialized variable as caught by cppcheck.
svn path=/trunk/; revision=44699
Evan Huus [Wed, 29 Aug 2012 22:19:29 +0000 (22:19 -0000)]
Add casts to fix compilation with GCC.
Remove * from gconstpointers, they are already pointer types.
Add modelines to packet.c and clean up indentation a bit.
svn path=/trunk/; revision=44698
Jakub Zawadzki [Wed, 29 Aug 2012 22:14:55 +0000 (22:14 -0000)]
Fix memleak.
svn path=/trunk/; revision=44697
Michael Mann [Wed, 29 Aug 2012 21:23:07 +0000 (21:23 -0000)]
Fix Bug 7348 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7348)
svn path=/trunk/; revision=44696
Chris Maynard [Wed, 29 Aug 2012 17:05:38 +0000 (17:05 -0000)]
Trivial typo fix and duplicate word removal.
svn path=/trunk/; revision=44695
Chris Maynard [Wed, 29 Aug 2012 16:15:01 +0000 (16:15 -0000)]
Allow wpa-psk decryption keys to be successfully entered.
Problems reported on ask.wireshark.org here:
1) http://ask.wireshark.org/questions/13951/invalid-key-format-wireshark-182
2) http://ask.wireshark.org/questions/13688/error-updating-record-invalid-key-format
#BACKPORT (to 1.8)
svn path=/trunk/; revision=44694
Guy Harris [Wed, 29 Aug 2012 10:31:29 +0000 (10:31 -0000)]
At least with the version of Xcode that comes with Leopard,
/usr/include/ffi/fficonfig.h doesn't define MACOSX, which causes the
build of GLib to fail. If we don't find "#define.*MACOSX" in
/usr/include/ffi/fficonfig.h, explictly define it.
svn path=/trunk/; revision=44693
Pascal Quantin [Tue, 28 Aug 2012 15:14:30 +0000 (15:14 -0000)]
Remove useless include (GeoIP initialization was removed from epan_init() in r43604)
svn path=/trunk/; revision=44692
Jakub Zawadzki [Tue, 28 Aug 2012 09:10:34 +0000 (09:10 -0000)]
Yet another case of bug #7316 (r42989) and bug #7668 (r44688)
Use correct field type for ccp.opt.oui
svn path=/trunk/; revision=44689
Jakub Zawadzki [Tue, 28 Aug 2012 08:44:41 +0000 (08:44 -0000)]
Fix bug #7668
Use correct field type for lcp.opt.oui
svn path=/trunk/; revision=44688
Evan Huus [Tue, 28 Aug 2012 02:08:42 +0000 (02:08 -0000)]
Fix a dead store and a few duplicate 'break' statements as caught by
clang and cppcheck.
svn path=/trunk/; revision=44687
Evan Huus [Tue, 28 Aug 2012 02:01:25 +0000 (02:01 -0000)]
Remove variadic macro that accidentally made it in a while back.
svn path=/trunk/; revision=44686
Bill Meier [Mon, 27 Aug 2012 16:17:38 +0000 (16:17 -0000)]
Fix 2 memory leaks;
Essentially: 'fid' & 'fragment' hash tables can be global (i.e., need not be 'per call')
thus removing g_malloc'd storage never freed because it was pointed to in
se_alloc'd structs.
Fixes Bug #4134: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4134
Also: fix a compile error when compiling with '#define DEBUG_DESEGMENT'
svn path=/trunk/; revision=44685
Pascal Quantin [Mon, 27 Aug 2012 11:47:37 +0000 (11:47 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7622 :
Fix dissection of a few TDS fields (line number in ERR and MSG token, user type in RESULTS token, row count in DONE token) when the TDS version is >= 7.2.
Add a mechanism to memorize the TDS 7.X version in the conversation based on the TDS version found in LOGIN ACK token. This version is used for dissection when a TDS version is not set in preferences (TDS protocol type set to "not specified").
svn path=/trunk/; revision=44684