Anders Broman [Wed, 19 Aug 2009 18:37:13 +0000 (18:37 -0000)]
From Didier Gautheron:
Part 2
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize expert info.
Slightly changed by me.
svn path=/trunk/; revision=29478
Anders Broman [Wed, 19 Aug 2009 18:36:36 +0000 (18:36 -0000)]
From Didier Gautheron:
Part 1
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize expert info.
Slightly changed by me.
svn path=/trunk/; revision=29477
Jörg Mayer [Wed, 19 Aug 2009 15:42:24 +0000 (15:42 -0000)]
As pointed out by Alexis La Goutte via PM, r29474 didn't
support the different MAC formats (eui48 and eui64) properly.
Now, eui48 is printed as mac, the rest is still handled as
blob.
svn path=/trunk/; revision=29476
Kovarththanan Rajaratnam [Wed, 19 Aug 2009 13:52:15 +0000 (13:52 -0000)]
We shouldn't conditionalise on _filtering_ tap listerners to determine whether tapping should be performed or not. We also need to handle _normal_ tap listerners. This change backs out the regression introduced in r29435.
Thanks to Didier: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3916
svn path=/trunk/; revision=29475
Jörg Mayer [Wed, 19 Aug 2009 12:25:40 +0000 (12:25 -0000)]
Add support for Radio Mac/Wireless Specific Information optional
header fields. This patch lacks handling of padding since a) I don't
have a trace containing padding and b) I don't understand the
wording in the rfc (it's to ambigous for my liking).
svn path=/trunk/; revision=29474
Anders Broman [Wed, 19 Aug 2009 11:34:40 +0000 (11:34 -0000)]
From Jochen Bartl:
EIGRP dissector enhancements (IPv6, Stub routing, Authentication TLVs)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3907
svn path=/trunk/; revision=29473
Anders Broman [Wed, 19 Aug 2009 09:32:56 +0000 (09:32 -0000)]
From Jan Lübbe:
packet-gsm_a_rr.c: flip gsm_a_rr_mv_vals, 0 means vaild.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3915
svn path=/trunk/; revision=29472
Anders Broman [Wed, 19 Aug 2009 07:55:11 +0000 (07:55 -0000)]
From Didier Gautheron:
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Make col_expr const gchar.
svn path=/trunk/; revision=29471
Anders Broman [Wed, 19 Aug 2009 06:04:30 +0000 (06:04 -0000)]
Fix a memmory leak.
svn path=/trunk/; revision=29470
Anders Broman [Tue, 18 Aug 2009 23:00:42 +0000 (23:00 -0000)]
Add new_packet_list_recent_write_all().
svn path=/trunk/; revision=29469
Jaap Keuter [Tue, 18 Aug 2009 17:36:30 +0000 (17:36 -0000)]
Properly handle closing/destruction of RTP player window.
svn path=/trunk/; revision=29468
Anders Broman [Tue, 18 Aug 2009 14:40:51 +0000 (14:40 -0000)]
Make copy summary work for new_packet_list.
XXX The enum in .h file does not seem to work???
svn path=/trunk/; revision=29467
Anders Broman [Tue, 18 Aug 2009 14:39:32 +0000 (14:39 -0000)]
Minor clean up.
svn path=/trunk/; revision=29466
Stig Bjørlykke [Tue, 18 Aug 2009 14:37:25 +0000 (14:37 -0000)]
Search for includes and libs in /opt/local/ (MacPorts).
svn path=/trunk/; revision=29465
Jeff Morriss [Tue, 18 Aug 2009 13:25:49 +0000 (13:25 -0000)]
Add an expert info noting that an ANSI message with the national indicator set to 0 (international) is unusual.
svn path=/trunk/; revision=29464
Anders Broman [Tue, 18 Aug 2009 12:15:36 +0000 (12:15 -0000)]
Make build bot happy?
svn path=/trunk/; revision=29463
Anders Broman [Tue, 18 Aug 2009 11:39:55 +0000 (11:39 -0000)]
Typo: parameter_tvb to be used.
svn path=/trunk/; revision=29462
Anders Broman [Tue, 18 Aug 2009 08:00:05 +0000 (08:00 -0000)]
From Mathias de Paulis Nilsson:
Updates to V8.5.0.
svn path=/trunk/; revision=29461
Jaap Keuter [Tue, 18 Aug 2009 06:41:12 +0000 (06:41 -0000)]
From Swapnil Barai:
Minor Bug in Bearer Context in Packet-gtpv2.c fixed.
svn path=/trunk/; revision=29460
Stephen Fisher [Tue, 18 Aug 2009 00:32:11 +0000 (00:32 -0000)]
Display Microsoft's Remote Desktop Protocol (RDP) extension to the X.224
connection request that shows the session load balancing information. There
appears to be more dissecting that can be done for this field, but I don't
have any sample captures to test this.
svn path=/trunk/; revision=29459
Kovarththanan Rajaratnam [Mon, 17 Aug 2009 20:14:59 +0000 (20:14 -0000)]
As pointed out by Guy, we should probably explain why the gulong -> size_t cast is 'safe'
svn path=/trunk/; revision=29458
Jaap Keuter [Mon, 17 Aug 2009 19:10:19 +0000 (19:10 -0000)]
Change window_new() to dlg_window_new() and destroy the window with the top level window.
svn path=/trunk/; revision=29457
Kovarththanan Rajaratnam [Mon, 17 Aug 2009 17:19:31 +0000 (17:19 -0000)]
setbit() is (AFAIK) defined in <sys/param.h> (OpenBSD) so rename to dect_setbit() to avoid clash. getbit() is also renamed for consistency.
Fixes the issue reported by Stan: http://www.wireshark.org/lists/wireshark-users/200908/msg00128.html
svn path=/trunk/; revision=29456
Anders Broman [Mon, 17 Aug 2009 15:13:58 +0000 (15:13 -0000)]
Remove #if 0
svn path=/trunk/; revision=29455
Anders Broman [Mon, 17 Aug 2009 15:05:43 +0000 (15:05 -0000)]
Prepare to store column data from pinfo.
svn path=/trunk/; revision=29454
Kovarththanan Rajaratnam [Mon, 17 Aug 2009 11:21:33 +0000 (11:21 -0000)]
Move the NULL pointer 'tree' check under TRY_TO_FAKE_THIS_ITEMs umbrella
svn path=/trunk/; revision=29453
Kovarththanan Rajaratnam [Mon, 17 Aug 2009 11:13:36 +0000 (11:13 -0000)]
Don't do PROTO_REGISTRAR_GET_NTH twice.
svn path=/trunk/; revision=29452
Kovarththanan Rajaratnam [Mon, 17 Aug 2009 04:23:47 +0000 (04:23 -0000)]
Add proper type cast.
Thanks to Martin for reporting this.
svn path=/trunk/; revision=29451
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 15:33:05 +0000 (15:33 -0000)]
Add missing call to packets_bar_update() after thaw'ing
svn path=/trunk/; revision=29450
Gerald Combs [Sun, 16 Aug 2009 15:03:26 +0000 (15:03 -0000)]
[Automatic manuf and enterprise-numbers update for 2009-08-16]
svn path=/trunk/; revision=29447
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 12:36:22 +0000 (12:36 -0000)]
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 10:53:47 +0000 (10:53 -0000)]
Add a new function, tvb_new_subset_remaining(), which is a sligtly optimized version of tvb_new_subset(). The latter can be mapped to the former by tvb_new_subset(tvb, offset, -1 /* backing_length */, -1 /* reported_length */). We can disable some bounds checking because 'backing_length' and 'reported_length' are hardcoded to -1.
The current implementation of tvb_new_subset_remaining() only has the THROW_ON(reported_length < 1) check removed when compared to tvb_new_subset(). So there's room for improvement in this function. We should be able to disable some more (redundant) bounds checking.
svn path=/trunk/; revision=29445
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 09:48:25 +0000 (09:48 -0000)]
Remove unused parameters
svn path=/trunk/; revision=29444
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 09:18:17 +0000 (09:18 -0000)]
Remove the non-thread safe usage of 'last_tvb' variable in tvb_new_subset()
svn path=/trunk/; revision=29443
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 08:18:17 +0000 (08:18 -0000)]
Make some of the check_XXX functions accept the length/reported length of the tvbuff as arguments instead the tvbuff. We'll need this feature in order to remove the non-thread usage of the 'last_tvb' variable in tvb_new_subset()
svn path=/trunk/; revision=29442
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 07:29:11 +0000 (07:29 -0000)]
Remove a non thread-safe usage (useful when/if we ever support threading) of a static tvbuff in tvb_new_real_data(). The current version uses a static 'last_tvb' to keep track of the last allocated tvbuff. This is needed because some of the function we call can throw an exception. This patch improves this strategy by throwing an exception (if needed) before we try to allocate the tvbuff. This way we avoid a memleak _and_ we don't have to track the 'last_tvb' tvbuff.
svn path=/trunk/; revision=29441
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 04:54:33 +0000 (04:54 -0000)]
Use the slice allocator if GLIB >= 2,10,0
svn path=/trunk/; revision=29440
Kovarththanan Rajaratnam [Sun, 16 Aug 2009 04:08:00 +0000 (04:08 -0000)]
Switch over to using GPtrArray instead of manually g_renew'ing. This switch has some benefits:
1) We don't have to manually resize
2) GPtrArray uses a sligtly more efficient allocation scheme. It increases the size of the array exponentially which reduces the amount of memcpy's we have to do when we resize the array
svn path=/trunk/; revision=29439
Stephen Fisher [Sun, 16 Aug 2009 02:35:44 +0000 (02:35 -0000)]
Mark function paramter as unused with _U_ to please gcc.
svn path=/trunk/; revision=29438
Anders Broman [Sat, 15 Aug 2009 21:59:03 +0000 (21:59 -0000)]
Try to please build bot
svn path=/trunk/; revision=29437
Anders Broman [Sat, 15 Aug 2009 21:12:56 +0000 (21:12 -0000)]
Prepare for storing column data in packet list store.
svn path=/trunk/; revision=29436
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 14:13:36 +0000 (14:13 -0000)]
Inline a few checks in the add_packet_to_packet_list() function since it's called in tight loop. This will help us to avoid calling functions that simply returns. This is especially the case when we're dealing with the new packet list due to its dissect-on-demand nature where colour/column construction is delayed until the row becomes visible.
svn path=/trunk/; revision=29435
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 13:24:59 +0000 (13:24 -0000)]
Use the slice allocator if GLIB >= 2,10,0 as suggested by Anders Broman
svn path=/trunk/; revision=29434
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 12:41:24 +0000 (12:41 -0000)]
Add a missing DISSECTOR_ASSERT in tvb_init()
svn path=/trunk/; revision=29433
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 12:29:25 +0000 (12:29 -0000)]
Make mem chunk static
svn path=/trunk/; revision=29432
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 11:21:36 +0000 (11:21 -0000)]
Use HFILL instead of hard coding the values
svn path=/trunk/; revision=29431
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 09:13:16 +0000 (09:13 -0000)]
Switch over to using GLib's g_malloc/g_free in the name of consistency.
svn path=/trunk/; revision=29430
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 08:38:50 +0000 (08:38 -0000)]
This should have been part of r29428. This patch forces proto_field_is_referenced() to respect the fake_protocols flag set by Protocol Hierarchy stats tap.
svn path=/trunk/; revision=29429
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 08:05:10 +0000 (08:05 -0000)]
The frame dissector contains a kludge to workaround the fact that the Protocol Hierarchy stats tap always needs the protocol node to appear even though no color, display filter etc. reference it. This is no longer needed due to r29380.
svn path=/trunk/; revision=29428
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 06:38:10 +0000 (06:38 -0000)]
This patch introduces packet_add_new_data_source() which effectively deprecates add_new_data_source(). This is based on the following observation:
1) The tvb + name (aka. data_source) is only used when the protocol tree is visible
The current implementation of add_new_data_source() doesn't take this into account and simply allocates a data_source regardless. This is what packet_add_new_data_source() tries to rectify.
A couple of dissectors have already been switched over to the new packet_add_new_data_source(). Many are still missing. Help appreciated!
svn path=/trunk/; revision=29427
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 05:26:02 +0000 (05:26 -0000)]
Micro optimize by storing PACKET_LIST(tree_model) into a local variable and using that instead of computing PACKET_LIST(tree_model) each time.
svn path=/trunk/; revision=29426
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 05:06:27 +0000 (05:06 -0000)]
Avoid superfluous g_strdup()
svn path=/trunk/; revision=29425
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 04:24:43 +0000 (04:24 -0000)]
Enable 'Mark Packet' in the Edit menu
svn path=/trunk/; revision=29424
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 04:19:45 +0000 (04:19 -0000)]
Add support for mark/unmark all frames in our new packet list
svn path=/trunk/; revision=29423
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 04:05:04 +0000 (04:05 -0000)]
Find next/previous mark is also supported so don't exclude it
svn path=/trunk/; revision=29422
Kovarththanan Rajaratnam [Sat, 15 Aug 2009 03:57:14 +0000 (03:57 -0000)]
Don't exclude functionality we already support
svn path=/trunk/; revision=29421
Martin Mathieson [Sat, 15 Aug 2009 01:29:29 +0000 (01:29 -0000)]
Allow s1ap not to be dissected (to avoid seeing errors, possibly due to proprietary variants).
svn path=/trunk/; revision=29420
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 19:35:01 +0000 (19:35 -0000)]
Make 'Apply as filter'/'Prepare filter' work for new packet list.
svn path=/trunk/; revision=29419
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 18:59:15 +0000 (18:59 -0000)]
Remove the hacky row_from_iter() function and use new_packet_list_get_record() instead. Alas, new_packet_list_get_record() is also somewhat hacky in its nature, but hey at least we're using one less hacky thing.
svn path=/trunk/; revision=29418
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 18:49:48 +0000 (18:49 -0000)]
Make mark/unmark frame work with the new filter model
svn path=/trunk/; revision=29417
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 18:32:44 +0000 (18:32 -0000)]
Remove unused functions/prototypes
svn path=/trunk/; revision=29416
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 18:29:32 +0000 (18:29 -0000)]
New packet list: right clicking on a row now selects the given row.
svn path=/trunk/; revision=29415
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 15:56:23 +0000 (15:56 -0000)]
Make first/last frame work again with the new filter model.
svn path=/trunk/; revision=29414
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 15:44:57 +0000 (15:44 -0000)]
Make next/previous frame work again with the new filter model.
svn path=/trunk/; revision=29413
Anders Broman [Fri, 14 Aug 2009 15:31:59 +0000 (15:31 -0000)]
Typos.
Fixes:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3878
svn path=/trunk/; revision=29412
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 13:33:17 +0000 (13:33 -0000)]
Don't attach our original packet list model in new_packet_list_thaw(). It's pointless because we override it in filter_function().
svn path=/trunk/; revision=29411
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 10:17:13 +0000 (10:17 -0000)]
From Artem Tamazov via. 3899:
Remove superfluous /MP
svn path=/trunk/; revision=29410
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 05:49:57 +0000 (05:49 -0000)]
Make display filtering work for NEW_PACKET_LIST. This didn't work previously because we would simply append the new filtered packets onto the existing ones.
svn path=/trunk/; revision=29409
Kovarththanan Rajaratnam [Fri, 14 Aug 2009 05:22:12 +0000 (05:22 -0000)]
Always add packet to the new packet list regardless of whether the packet passed the display filter test or not. We do this because we do the filtering inside the new packet list.
svn path=/trunk/; revision=29408
Anders Broman [Thu, 13 Aug 2009 21:46:00 +0000 (21:46 -0000)]
Start to implement display filtering.
svn path=/trunk/; revision=29407
Anders Broman [Thu, 13 Aug 2009 21:36:01 +0000 (21:36 -0000)]
Get the pointer to the packet list record and use the data directly.
svn path=/trunk/; revision=29406
Kovarththanan Rajaratnam [Thu, 13 Aug 2009 20:00:36 +0000 (20:00 -0000)]
Add needed header due to stack allocated 'edt' structure
svn path=/trunk/; revision=29405
Kovarththanan Rajaratnam [Thu, 13 Aug 2009 19:42:46 +0000 (19:42 -0000)]
Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic.
svn path=/trunk/; revision=29404
Kovarththanan Rajaratnam [Thu, 13 Aug 2009 12:17:20 +0000 (12:17 -0000)]
Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893
svn path=/trunk/; revision=29403
Tomas Kukosa [Thu, 13 Aug 2009 11:12:35 +0000 (11:12 -0000)]
fix build failure without GnuTLS
svn path=/trunk/; revision=29402
Tomas Kukosa [Thu, 13 Aug 2009 10:36:53 +0000 (10:36 -0000)]
use G_GSIZE_MODIFIER instead of %zd which is not supported by MSVC
svn path=/trunk/; revision=29401
Tomas Kukosa [Thu, 13 Aug 2009 09:07:03 +0000 (09:07 -0000)]
Fix SSL decryption failure if client and server have the same TCP port
svn path=/trunk/; revision=29400
Anders Broman [Thu, 13 Aug 2009 07:56:13 +0000 (07:56 -0000)]
From Gerasimos Dimitriadis:
DTAP decoding of Mobile Station Classmark 3 (R7 and R8)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3891
svn path=/trunk/; revision=29399
Anders Broman [Wed, 12 Aug 2009 22:40:13 +0000 (22:40 -0000)]
From Gerasimos Dimitriadis:
DTAP decoding of Mobile Station Classmark 3 (R6).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3886
svn path=/trunk/; revision=29398
Kovarththanan Rajaratnam [Wed, 12 Aug 2009 19:32:54 +0000 (19:32 -0000)]
White space changes
svn path=/trunk/; revision=29397
Kovarththanan Rajaratnam [Wed, 12 Aug 2009 18:24:49 +0000 (18:24 -0000)]
DISSECTOR_ASSERT on FT_PCRE in construct_match_selected_string().
svn path=/trunk/; revision=29396
Gerald Combs [Wed, 12 Aug 2009 17:08:08 +0000 (17:08 -0000)]
Temporarily disable dissector bug checking. Fixing the ones we've found
so far will take a while and in the meantime looking for dissector
assertions is keeping us from finding more serious bugs.
svn path=/trunk/; revision=29395
Kovarththanan Rajaratnam [Wed, 12 Aug 2009 15:12:19 +0000 (15:12 -0000)]
From William Preston via. 3549:
A typo in 2 of the field names causes the apn not to be displayed.
svn path=/trunk/; revision=29394
Balint Reczey [Wed, 12 Aug 2009 12:55:27 +0000 (12:55 -0000)]
Fix COL_INFO and COL_PROTOCOL for Teredo Direct IPv6 Connectivity Test
svn path=/trunk/; revision=29393
Tomas Kukosa [Wed, 12 Aug 2009 06:10:08 +0000 (06:10 -0000)]
fix memoryleak causing crash with long SSL traces
svn path=/trunk/; revision=29392
Jaap Keuter [Wed, 12 Aug 2009 00:02:23 +0000 (00:02 -0000)]
Restore the formatting of the saved graph.
svn path=/trunk/; revision=29391
Jaap Keuter [Tue, 11 Aug 2009 23:52:04 +0000 (23:52 -0000)]
Complete the fix in r29389.
svn path=/trunk/; revision=29390
Gerald Combs [Tue, 11 Aug 2009 23:44:22 +0000 (23:44 -0000)]
Instead of calling DISSECTOR_ASSERT_NOT_REACHED, just say the subchannel
is unknown. Fixes bug 3864.
svn path=/trunk/; revision=29389
Gerald Combs [Tue, 11 Aug 2009 23:29:21 +0000 (23:29 -0000)]
Add some length checks.
svn path=/trunk/; revision=29388
Balint Reczey [Tue, 11 Aug 2009 23:20:03 +0000 (23:20 -0000)]
From Ivan Sy (with minor modifications):
Show Teredo Connectivity tests.
Fix offset of ICMPv6 sequence number.
svn path=/trunk/; revision=29387
Anders Broman [Tue, 11 Aug 2009 21:27:36 +0000 (21:27 -0000)]
From swapnil:
Small Bug in TFT (Flow label) and ULI.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3876
svn path=/trunk/; revision=29386
Gerald Combs [Tue, 11 Aug 2009 21:11:12 +0000 (21:11 -0000)]
Use the right size for FT_UINT16.
svn path=/trunk/; revision=29385
Gerald Combs [Tue, 11 Aug 2009 20:58:36 +0000 (20:58 -0000)]
Add some length checks. Fixes a few recent fuzz bugs.
svn path=/trunk/; revision=29384
Gerald Combs [Tue, 11 Aug 2009 18:37:59 +0000 (18:37 -0000)]
Add a bunch of length checks. Fixes bug 3826.
svn path=/trunk/; revision=29383
Kovarththanan Rajaratnam [Tue, 11 Aug 2009 18:28:10 +0000 (18:28 -0000)]
(Trivial change) move ensure_contiguous() to reflect call hierarchy
svn path=/trunk/; revision=29382
Kovarththanan Rajaratnam [Tue, 11 Aug 2009 18:16:55 +0000 (18:16 -0000)]
Turn a comment in fast_ensure_contiguous() into a DISSECTOR_ASSERT() to make the implied requirement explicit.
svn path=/trunk/; revision=29381
Kovarththanan Rajaratnam [Tue, 11 Aug 2009 18:08:03 +0000 (18:08 -0000)]
TRY_TO_FAKE_THIS_ITEM now fakes FT_PROTOCOL per default. If there are any users (e.g. proto_hier_stats.c, others?) that relies on FT_PROTOCOL nodes being created they'll now need to call the newly introduced epan_dissect_fake_protocols() to disable this optimization.
Also make use of TRY_TO_FAKE_THIS_ITEM in proto_tree_add_text_node(), proto_tree_add_none_format() and proto_tree_add_protocol_format().
svn path=/trunk/; revision=29380
Gerald Combs [Tue, 11 Aug 2009 17:53:39 +0000 (17:53 -0000)]
Be a little more explicit in our description of tvb_get_ptr.
svn path=/trunk/; revision=29379
Bill Meier [Tue, 11 Aug 2009 13:44:35 +0000 (13:44 -0000)]
Don't coerce a (void *) to a (guint32 *).
The (void *) pointer in this case may point to
"unaligned" data.
svn path=/trunk/; revision=29378
Anders Broman [Tue, 11 Aug 2009 12:22:00 +0000 (12:22 -0000)]
From Gerasimos Dimitriadis:
DTAP decoding of Mobile Station Classmark 3 (R4 and R5).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3866
svn path=/trunk/; revision=29377