amitay/samba.git
15 years agochange the dsdb_control_current_partition to not include internal variables
Andrew Tridgell [Wed, 2 Sep 2009 03:36:54 +0000 (13:36 +1000)]
change the dsdb_control_current_partition to not include internal variables

This structures was used in two ways. In one way it held variables
that are logically internal to the partition module, and in the other
way it was used to pass the partition DN down to other modules. This
change makes the structure contain just the dn which is being passed
down.

This change is part of the support for linked attributes. We will be
passing this control down from above the partition module to force
which partition a request acts upon. The partition module now only
adds this control if it isn't already there.

15 years agodon't allow two controls to be added with the same OID
Andrew Tridgell [Wed, 2 Sep 2009 03:33:37 +0000 (13:33 +1000)]
don't allow two controls to be added with the same OID

Two controls with the same OID makes no sense, as they may
have different data attached

15 years agoDisplay ldif formatted versions of all DRS changes at log level 4
Andrew Tridgell [Wed, 2 Sep 2009 01:20:26 +0000 (11:20 +1000)]
Display ldif formatted versions of all DRS changes at log level 4

This helps a lot with debugging the DRS replication code

15 years agoWrap DRS changes in a transaction
Andrew Tridgell [Wed, 2 Sep 2009 01:17:43 +0000 (11:17 +1000)]
Wrap DRS changes in a transaction

We should always apply a whole set of DRS changes or none of them. See
[MS-DRSR] 3.3.2

15 years agoadd a ref to the WSPP docs
Andrew Tridgell [Wed, 2 Sep 2009 01:15:44 +0000 (11:15 +1000)]
add a ref to the WSPP docs

15 years agofixed spelling
Andrew Tridgell [Wed, 2 Sep 2009 01:15:29 +0000 (11:15 +1000)]
fixed spelling

15 years agoadded ldb_ldif_message_string()
Andrew Tridgell [Wed, 2 Sep 2009 01:14:33 +0000 (11:14 +1000)]
added ldb_ldif_message_string()

This function provides a easy function for displaying a ldb_message
structure in a human readable format. It is especially useful for
calling in gdb.

15 years agos3-smbpasswd: Fix Bug #6584: allow DOM\user when changing passwords remotely.
Simo Sorce [Sat, 29 Aug 2009 23:31:02 +0000 (19:31 -0400)]
s3-smbpasswd: Fix Bug #6584: allow DOM\user when changing passwords remotely.

Signed-off-by: Günther Deschner <gd@samba.org>
15 years agowbclient: Fix Bug #6680: always activate handling of large (> 256 byte) ntlmv2
Günther Deschner [Tue, 1 Sep 2009 09:58:05 +0000 (11:58 +0200)]
wbclient: Fix Bug #6680: always activate handling of large (> 256 byte) ntlmv2
blobs in wbcAuthenticateUserEx().

Guenther

15 years agos3-docs: Update build howto.
Karolin Seeger [Tue, 1 Sep 2009 10:55:23 +0000 (12:55 +0200)]
s3-docs: Update build howto.

This addresses bug #6661.

Karolin

15 years agonetlogon: fill in more details for the netr_LogonControlX family of calls.
Günther Deschner [Mon, 31 Aug 2009 15:12:07 +0000 (17:12 +0200)]
netlogon: fill in more details for the netr_LogonControlX family of calls.

Guenther

15 years agos3-netlogon: add DS_WEB_SERVICE_REQUIRED bit for dsgetdcname calls.
Günther Deschner [Mon, 31 Aug 2009 15:12:34 +0000 (17:12 +0200)]
s3-netlogon: add DS_WEB_SERVICE_REQUIRED bit for dsgetdcname calls.

Guenther

15 years agoldb: Depend on libtalloc 2.0.0
Simo Sorce [Sun, 30 Aug 2009 21:52:03 +0000 (17:52 -0400)]
ldb: Depend on libtalloc 2.0.0

15 years agoldb: cosmetic changes in ldb_dn
Simo Sorce [Sun, 30 Aug 2009 20:07:44 +0000 (16:07 -0400)]
ldb: cosmetic changes in ldb_dn

- remove trailing spaces and tabs
- shorten some variable names for readability
- try to break superlong lines for readability

15 years agos3: Fix libtalloc so version
Simo Sorce [Sun, 30 Aug 2009 17:53:14 +0000 (13:53 -0400)]
s3: Fix libtalloc so version

15 years agos3:libwbclient: Fix bug 6349, initialize domain info struct
Volker Lendecke [Sun, 30 Aug 2009 09:39:41 +0000 (11:39 +0200)]
s3:libwbclient: Fix bug 6349, initialize domain info struct

15 years agos3:winbind: Fix bug 5626
Volker Lendecke [Sun, 30 Aug 2009 09:12:17 +0000 (11:12 +0200)]
s3:winbind: Fix bug 5626

Apparently the AIX compiler can't deal with sizeless array declarations

15 years agow3:winbind: Convert WINBINDD_ALLOCATE_GID to the new API
Volker Lendecke [Sun, 30 Aug 2009 07:46:34 +0000 (09:46 +0200)]
w3:winbind: Convert WINBINDD_ALLOCATE_GID to the new API

15 years agow3:winbind: Convert WINBINDD_ALLOCATE_UID to the new API
Volker Lendecke [Sun, 30 Aug 2009 07:41:43 +0000 (09:41 +0200)]
w3:winbind: Convert WINBINDD_ALLOCATE_UID to the new API

15 years agoOne would expect I could spell my name...
Michael Adam [Sat, 29 Aug 2009 22:55:28 +0000 (00:55 +0200)]
One would expect I could spell my name...

15 years agoOne would expect I could spell my name.
Michael Adam [Sat, 29 Aug 2009 22:54:35 +0000 (00:54 +0200)]
One would expect I could spell my name.

15 years agotdb: move the original abi_checks script to script/abi_checks_gcc.sh
Michael Adam [Fri, 28 Aug 2009 14:04:47 +0000 (16:04 +0200)]
tdb: move the original abi_checks script to script/abi_checks_gcc.sh

Michael

15 years agotdb: run abi_checks as part of "make test".
Michael Adam [Sat, 29 Aug 2009 22:40:18 +0000 (00:40 +0200)]
tdb: run abi_checks as part of "make test".

Strange: I had to place "test:: abi_checks" before the main
"test::" target here, otherwise the abi checks would not get run.

Michael

15 years agotdb: remove files generated by "make abi_checks" in "make clean".
Michael Adam [Sat, 29 Aug 2009 22:28:31 +0000 (00:28 +0200)]
tdb: remove files generated by "make abi_checks" in "make clean".

Michael

15 years agotdb: add a target "abi_checks" to tdb.
Michael Adam [Fri, 28 Aug 2009 14:03:06 +0000 (16:03 +0200)]
tdb: add a target "abi_checks" to tdb.

Simply run "make abi_checks" to call the abi check script appropriately.

Michael

15 years agotdb: add script/abi_checks.sh. check for abi changes without gcc magic.
Michael Adam [Fri, 28 Aug 2009 13:53:12 +0000 (15:53 +0200)]
tdb: add script/abi_checks.sh. check for abi changes without gcc magic.

USAGE: abi_checks.sh LIBRARY_NAME header1 [header2 ...]

This creates symbol signature lists using the mksyms and mksigs scripts
and compares them with the checked in lists.

Michael

15 years agotdb: add script to extract signatures from header files.
Michael Adam [Fri, 28 Aug 2009 13:08:19 +0000 (15:08 +0200)]
tdb: add script to extract signatures from header files.

This produces output like the output gcc produces when
invoked with the -aux-info switch.

Run like this: cat include/tdb.h | ./script/mksigs.pl

This simple parser is probably too coarse to handle all
possible header files, but it treats tdb.h correctly...

Michael

15 years agotdb: add scripts to extract library symbols (exports file) from headers
Michael Adam [Fri, 28 Aug 2009 13:01:17 +0000 (15:01 +0200)]
tdb: add scripts to extract library symbols (exports file) from headers

Michael

15 years agotalloc: move the original abi_checks script to script/abi_checks_gcc.sh
Michael Adam [Fri, 28 Aug 2009 14:04:47 +0000 (16:04 +0200)]
talloc: move the original abi_checks script to script/abi_checks_gcc.sh

Michael

15 years agotalloc: remove talloc_free from the exports
Michael Adam [Sat, 29 Aug 2009 22:06:58 +0000 (00:06 +0200)]
talloc: remove talloc_free from the exports

Michael

15 years agotalloc: run abi_checks as part of "make test"
Michael Adam [Sat, 29 Aug 2009 22:16:36 +0000 (00:16 +0200)]
talloc: run abi_checks as part of "make test"

Michael

15 years agotalloc: remove files generated by "make abi_check" in "make clean"
Michael Adam [Sat, 29 Aug 2009 22:25:24 +0000 (00:25 +0200)]
talloc: remove files generated by "make abi_check" in "make clean"

Michael

15 years agotalloc: add a target "abi_checks" to talloc.
Michael Adam [Fri, 28 Aug 2009 14:03:06 +0000 (16:03 +0200)]
talloc: add a target "abi_checks" to talloc.

Simply run "make abi_checks" to call the abi check script appropriately.

Michael

15 years agotalloc: add script/abi_checks.sh. check for abi changes without gcc magic.
Michael Adam [Fri, 28 Aug 2009 13:53:12 +0000 (15:53 +0200)]
talloc: add script/abi_checks.sh. check for abi changes without gcc magic.

USAGE: abi_checks.sh LIBRARY_NAME header1 [header2 ...]

This creates symbol signature lists using the mksyms and mksigs scripts
and compares them with the checked in lists.

Michael

15 years agotalloc: add script to extract signatures from header files.
Michael Adam [Fri, 28 Aug 2009 13:08:19 +0000 (15:08 +0200)]
talloc: add script to extract signatures from header files.

This produces output like the output gcc produces when
invoked with the -aux-info switch.

Run like this: cat talloc.h | ./script/mksigs.pl

This simple parser is probably too coarse to handle all possible
header files, but it does treat talloc.h correctly.

Michael

15 years agotalloc: add scripts to extract library symbols (exports file) from headers
Michael Adam [Fri, 28 Aug 2009 13:01:17 +0000 (15:01 +0200)]
talloc: add scripts to extract library symbols (exports file) from headers

Michael

15 years agos3:winbind: Convert WINBINDD_LIST_GROUPS to the new API
Volker Lendecke [Sat, 29 Aug 2009 15:17:47 +0000 (17:17 +0200)]
s3:winbind: Convert WINBINDD_LIST_GROUPS to the new API

15 years agos3:winbind: Convert WINBINDD_LIST_USERS to the new API
Volker Lendecke [Sat, 29 Aug 2009 14:05:02 +0000 (16:05 +0200)]
s3:winbind: Convert WINBINDD_LIST_USERS to the new API

15 years agos3:nsstest: Fix a very confusing behaviour in nsstest
Volker Lendecke [Sat, 29 Aug 2009 17:39:35 +0000 (19:39 +0200)]
s3:nsstest: Fix a very confusing behaviour in nsstest

Testing getgrent I thought I get the offset calculations wrong whereas
it was only nsstest printing stuff with spaces...

15 years agos3:winbind: add a fake NDR winbind cache validator
Volker Lendecke [Sat, 29 Aug 2009 17:28:42 +0000 (19:28 +0200)]
s3:winbind: add a fake NDR winbind cache validator

15 years agos3:winbind: Convert the getgrent functions to the new API
Volker Lendecke [Thu, 27 Aug 2009 21:33:45 +0000 (23:33 +0200)]
s3:winbind: Convert the getgrent functions to the new API

15 years agos3:winbind: Add a comment about fill_grent_mem_domusers...
Volker Lendecke [Sat, 29 Aug 2009 13:21:29 +0000 (15:21 +0200)]
s3:winbind: Add a comment about fill_grent_mem_domusers...

15 years agos3:winbind: Add some missing error checks
Volker Lendecke [Thu, 27 Aug 2009 21:27:37 +0000 (23:27 +0200)]
s3:winbind: Add some missing error checks

15 years agos3:winbind: Fix a typo
Volker Lendecke [Thu, 27 Aug 2009 19:54:58 +0000 (21:54 +0200)]
s3:winbind: Fix a typo

15 years agos3:winbind: Add async wb_next_grent
Volker Lendecke [Thu, 27 Aug 2009 19:53:15 +0000 (21:53 +0200)]
s3:winbind: Add async wb_next_grent

15 years agos3:winbind: Add async QueryGroupList
Volker Lendecke [Thu, 27 Aug 2009 17:54:18 +0000 (19:54 +0200)]
s3:winbind: Add async QueryGroupList

15 years agow3:winbind: Convert WINBINDD_LOOKUPRIDS to the new API
Volker Lendecke [Thu, 27 Aug 2009 15:11:24 +0000 (17:11 +0200)]
w3:winbind: Convert WINBINDD_LOOKUPRIDS to the new API

15 years agos3:winbind: Convert the GETDCNAME routines to the new API
Volker Lendecke [Wed, 26 Aug 2009 10:27:32 +0000 (12:27 +0200)]
s3:winbind: Convert the GETDCNAME routines to the new API

15 years agos3:winbind: Add async wb_dsgetdcname
Volker Lendecke [Wed, 26 Aug 2009 09:33:16 +0000 (11:33 +0200)]
s3:winbind: Add async wb_dsgetdcname

15 years agos3:winbind: Convert winbindd_dsgetdcname to the new API
Volker Lendecke [Tue, 25 Aug 2009 21:02:44 +0000 (23:02 +0200)]
s3:winbind: Convert winbindd_dsgetdcname to the new API

15 years agos3:winbind: Add an async dsgetdcname call
Volker Lendecke [Tue, 25 Aug 2009 20:13:34 +0000 (22:13 +0200)]
s3:winbind: Add an async dsgetdcname call

15 years agos3:winbind: Convert the GETPWENT routines to the new API
Volker Lendecke [Mon, 17 Aug 2009 21:13:48 +0000 (23:13 +0200)]
s3:winbind: Convert the GETPWENT routines to the new API

15 years agos3:winbind: Add async next_pwent
Volker Lendecke [Mon, 17 Aug 2009 20:50:39 +0000 (22:50 +0200)]
s3:winbind: Add async next_pwent

15 years agos3:winbind: Add async fill_pwent
Volker Lendecke [Mon, 17 Aug 2009 20:44:55 +0000 (22:44 +0200)]
s3:winbind: Add async fill_pwent

15 years agos3:winbind: Add async query_user_list
Volker Lendecke [Mon, 17 Aug 2009 20:40:19 +0000 (22:40 +0200)]
s3:winbind: Add async query_user_list

15 years agos3:winbind: simplify wb_seqnums_done a bit
Volker Lendecke [Tue, 25 Aug 2009 10:38:47 +0000 (12:38 +0200)]
s3:winbind: simplify wb_seqnums_done a bit

15 years agos3:winbind: Make wb_seqnums.c update the winbind cache seqnums
Volker Lendecke [Tue, 25 Aug 2009 10:29:25 +0000 (12:29 +0200)]
s3:winbind: Make wb_seqnums.c update the winbind cache seqnums

15 years agos3:winbind: Fix a bug found by RPC-SAMR
Volker Lendecke [Fri, 28 Aug 2009 12:25:11 +0000 (14:25 +0200)]
s3:winbind: Fix a bug found by RPC-SAMR

We need to enumerate passdb alias members

Thanks to gd for bugging me :-)

15 years agos3:winbind: Fix a typo
Volker Lendecke [Thu, 27 Aug 2009 14:13:51 +0000 (16:13 +0200)]
s3:winbind: Fix a typo

15 years agos3:winbind: Rename wbint_GroupMembers to wbint_Principals
Volker Lendecke [Sun, 23 Aug 2009 10:43:43 +0000 (12:43 +0200)]
s3:winbind: Rename wbint_GroupMembers to wbint_Principals

15 years agos3:winbind: Rename wbint_GroupMember to wbint_Principal
Volker Lendecke [Sun, 23 Aug 2009 10:38:35 +0000 (12:38 +0200)]
s3:winbind: Rename wbint_GroupMember to wbint_Principal

15 years agotevent: Fix a segfault upon the first signal
Volker Lendecke [Sat, 29 Aug 2009 07:41:32 +0000 (09:41 +0200)]
tevent: Fix a segfault upon the first signal

When the first signal arrives, tevent_common_signal_handler() crashed: "ev" is
initialized to NULL, so the first "write(ev->pipe_fds[1], &c, 1);" dereferences
NULL.

Rusty, Tridge, please check. Also, can you tell me a bit more about the
environment you tested this in? I'd be curious to see where this survived.

Thanks,

Volker

15 years agos3: Add catia to the list of modules compiled by default
Aravind Srinivasan [Wed, 26 Aug 2009 21:54:58 +0000 (14:54 -0700)]
s3: Add catia to the list of modules compiled by default

Signed-off-by: Tim Prouty <tprouty@samba.org>
15 years agos3: Major revamp for catia vfs module
Aravind Srinivasan [Wed, 26 Aug 2009 21:55:38 +0000 (14:55 -0700)]
s3: Major revamp for catia vfs module

This patch builds out catia to allow fully configurable mappings,
including mappings from single byte to multi-byte characters.
Additionally, a much more complete list of vfs operations are now
covered.

Signed-off-by: Tim Prouty <tprouty@samba.org>
15 years agos3: Add a new VFS op called SMB_VFS_TRANSLATE_NAME
Aravind Srinivasan [Wed, 26 Aug 2009 21:56:09 +0000 (14:56 -0700)]
s3: Add a new VFS op called SMB_VFS_TRANSLATE_NAME

This vop is designed to work in tandem with SMB_VFS_READDIR to allow
vfs modules to make modifications to arbitrary filenames before
they're consumed by callers.  Subsequently the core directory
enumeration code in smbd is now changed to free the memory that may be
allocated in a module.  This vop enables the new version of catia in
the following patch.

Signed-off-by: Tim Prouty <tprouty@samba.org>
15 years agos4:ldb Don't sleep(100) in this error case, but debug the LDIF
Andrew Bartlett [Fri, 28 Aug 2009 09:26:53 +0000 (19:26 +1000)]
s4:ldb Don't sleep(100) in this error case, but debug the LDIF

15 years agos4: Create helpers functions related to provision
Matthieu Patou [Wed, 26 Aug 2009 16:30:15 +0000 (20:30 +0400)]
s4: Create helpers functions related to provision

One for getting attributes with DN syntax, one for getting forward
linked attributes and one for getting the list of partition

15 years agos4-ldb: update dlinklist.h to match main copy (lib/util/dlinklist.h)
Michael Adam [Fri, 28 Aug 2009 12:09:58 +0000 (14:09 +0200)]
s4-ldb: update dlinklist.h to match main copy (lib/util/dlinklist.h)

Michael

15 years agos3-ldb: update dlinklist.h to match main copy (lib/util/dlinklist.h)
Michael Adam [Fri, 28 Aug 2009 12:06:28 +0000 (14:06 +0200)]
s3-ldb: update dlinklist.h to match main copy (lib/util/dlinklist.h)

This also removes build warnings of redefined macros
since it uses the embracing "#ifndef _DLINKLIST_H ... #endif".

Michael

15 years agos4: include ntlmssp header in auth/ntlmssp/ntlmssp.h.
Günther Deschner [Fri, 28 Aug 2009 11:42:39 +0000 (13:42 +0200)]
s4: include ntlmssp header in auth/ntlmssp/ntlmssp.h.

Guenther

15 years agos3-ntlmssp: use generated ntlmssp code for debugging purpose.
Günther Deschner [Wed, 12 Aug 2009 18:22:58 +0000 (20:22 +0200)]
s3-ntlmssp: use generated ntlmssp code for debugging purpose.

Guenther

15 years agos3-ntlmssp: add NDR helper routines for ntlmssp.
Günther Deschner [Fri, 28 Aug 2009 09:37:28 +0000 (11:37 +0200)]
s3-ntlmssp: add NDR helper routines for ntlmssp.

Guenther

15 years agos4: fix the build after ntlmssp header change.
Günther Deschner [Fri, 28 Aug 2009 09:36:28 +0000 (11:36 +0200)]
s4: fix the build after ntlmssp header change.

Guenther

15 years agolibcli/auth: remove unused NTLMSSP_NAME_TYPE_ flags.
Günther Deschner [Tue, 25 Aug 2009 10:30:48 +0000 (12:30 +0200)]
libcli/auth: remove unused NTLMSSP_NAME_TYPE_ flags.

Guenther

15 years agos4-ntlmssp: use interface constants in TargetInfo blob.
Günther Deschner [Tue, 25 Aug 2009 10:27:51 +0000 (12:27 +0200)]
s4-ntlmssp: use interface constants in TargetInfo blob.

Guenther

15 years agos4-ntlmssp: use NTLMSSP headers from IDL and remove duplicate constants.
Günther Deschner [Tue, 25 Aug 2009 10:12:59 +0000 (12:12 +0200)]
s4-ntlmssp: use NTLMSSP headers from IDL and remove duplicate constants.

Guenther

15 years agos3-ntlmssp: use interface constants in TargetInfo blob.
Günther Deschner [Fri, 14 Aug 2009 12:08:45 +0000 (14:08 +0200)]
s3-ntlmssp: use interface constants in TargetInfo blob.

Guenther

15 years agos3-ntlmssp: use NTLMSSP headers from IDL and remove duplicate constants.
Günther Deschner [Wed, 12 Aug 2009 18:22:04 +0000 (20:22 +0200)]
s3-ntlmssp: use NTLMSSP headers from IDL and remove duplicate constants.

Guenther

15 years agontlmssp: add ndr_print_ntlmssp_{nt,lm}_response() function.
Günther Deschner [Fri, 21 Aug 2009 18:41:03 +0000 (20:41 +0200)]
ntlmssp: add ndr_print_ntlmssp_{nt,lm}_response() function.

Guenther

15 years agontlmssp: re-run make samba3-idl and add generated files.
Günther Deschner [Wed, 12 Aug 2009 18:19:47 +0000 (20:19 +0200)]
ntlmssp: re-run make samba3-idl and add generated files.

Guenther

15 years agontlmssp: add NTLMSSP_MESSAGE_SIGNATURE to IDL.
Günther Deschner [Thu, 13 Aug 2009 23:01:21 +0000 (01:01 +0200)]
ntlmssp: add NTLMSSP_MESSAGE_SIGNATURE to IDL.

Guenther

15 years agontlmssp: add AUTHENTICATE_MESSAGE to idl.
Günther Deschner [Wed, 12 Aug 2009 21:18:52 +0000 (23:18 +0200)]
ntlmssp: add AUTHENTICATE_MESSAGE to idl.

Guenther

15 years agontlmssp: add CHALLENGE_MESSAGE to IDL.
Günther Deschner [Wed, 12 Aug 2009 16:14:31 +0000 (18:14 +0200)]
ntlmssp: add CHALLENGE_MESSAGE to IDL.

Guenther

15 years agontlmssp: add NEGOTIATE_MESSAGE to IDL.
Günther Deschner [Thu, 13 Aug 2009 22:31:53 +0000 (00:31 +0200)]
ntlmssp: add NEGOTIATE_MESSAGE to IDL.

Guenther

15 years agontlmssp: add string helper functions to handle OEM and UNICODE charset.
Günther Deschner [Thu, 13 Aug 2009 22:48:58 +0000 (00:48 +0200)]
ntlmssp: add string helper functions to handle OEM and UNICODE charset.

Guenther

15 years agontlmssp: add ntlmssp helper skeleton.
Günther Deschner [Thu, 13 Aug 2009 15:11:07 +0000 (17:11 +0200)]
ntlmssp: add ntlmssp helper skeleton.

Guenther

15 years agontlmssp: add IDL.
Günther Deschner [Wed, 12 Aug 2009 13:23:28 +0000 (15:23 +0200)]
ntlmssp: add IDL.

Guenther

15 years agolib/tevent: close pipe_fds on event_context destruction
Rusty Russell [Fri, 28 Aug 2009 02:41:23 +0000 (12:11 +0930)]
lib/tevent: close pipe_fds on event_context destruction

The "hack_fds" were never closed before; now they're inside event_context
they should be closed when that is destroyed.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
15 years agolib/tevent: handle tevent_common_add_signal on different event contexts.
Rusty Russell [Fri, 28 Aug 2009 02:38:47 +0000 (12:08 +0930)]
lib/tevent: handle tevent_common_add_signal on different event contexts.

I don't know if this is a problem in real life.

The code assumes there's only one tevent_context; all signals will notify
the first event context.  That's counter-intuitive if you ever use more
than one, and there's nothing else in this code which prevents it AFAICT.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
15 years agolib/tevent: fix race with signals and tevent_common_add_signal
Rusty Russell [Fri, 28 Aug 2009 02:34:22 +0000 (12:04 +0930)]
lib/tevent: fix race with signals and tevent_common_add_signal

We carefully preserve the old signal handler, but we replace it before
we've set up everything; in particular, if we fail setting up the
pipe_hack we could write a NUL char to stdout (fd 0), instead of
calling the old signal handler.

Replace the signal handler as the very last thing we do.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
15 years agolib/tdb: don't overwrite TDBs with different version numbers.
Rusty Russell [Fri, 28 Aug 2009 02:26:34 +0000 (11:56 +0930)]
lib/tdb: don't overwrite TDBs with different version numbers.

In future, this may happen, and we don't want to clobber them.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
15 years agolib/tevent: remove spectacularly complicated manual subtraction
Rusty Russell [Wed, 26 Aug 2009 08:00:32 +0000 (17:30 +0930)]
lib/tevent: remove spectacularly complicated manual subtraction

To be completely honest, I don't quite know whether to laugh or cry at
this one:

1 + (0xFFFFFFFF & ~(s.seen - s.count))
== 1 + (~(s.seen - s.count)) # s.seen, s.count are uint32_t
== s.count - s.seen # -A == ~A + 1

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
15 years agoutil: fix comment and clarify argument name in DLIST_DEMOTE()
Michael Adam [Wed, 26 Aug 2009 10:58:47 +0000 (12:58 +0200)]
util: fix comment and clarify argument name in DLIST_DEMOTE()

Michael

15 years agos3:smbd: teach filename_convert() about fake files (2nd fix for bug #6642)
Stefan Metzmacher [Wed, 19 Aug 2009 07:58:38 +0000 (09:58 +0200)]
s3:smbd: teach filename_convert() about fake files (2nd fix for bug #6642)

metze

15 years agos3:smbd: add is_fake_file_path() that takes only the raw path as string
Stefan Metzmacher [Wed, 19 Aug 2009 07:57:47 +0000 (09:57 +0200)]
s3:smbd: add is_fake_file_path() that takes only the raw path as string

metze

15 years agos3:streams: check for :$DATA only in the backend (fix bug #6642)
Stefan Metzmacher [Tue, 18 Aug 2009 09:34:54 +0000 (11:34 +0200)]
s3:streams: check for :$DATA only in the backend (fix bug #6642)

We need to allow "\\$Extend\\$Quota:$Q:$INDEX_ALLOCATION" to pass
check_path(), so that the Quota Dialog works.

metze

15 years agos3:error_map: make NTSTATUS -> errno -> NTSTATUS mapping consistent for NT_STATUS_INV...
Stefan Metzmacher [Tue, 18 Aug 2009 09:32:37 +0000 (11:32 +0200)]
s3:error_map: make NTSTATUS -> errno -> NTSTATUS mapping consistent for NT_STATUS_INVALID_PARAMETER

Why have we mapped EINVAL -> NT_STATUS_INVALID_HANDLE before?

metze

15 years agos3-ntlmssp: remove trailing whitespace.
Günther Deschner [Thu, 13 Aug 2009 22:36:21 +0000 (00:36 +0200)]
s3-ntlmssp: remove trailing whitespace.

Guenther

15 years agolibcli/auth: add netlogon_creds_step_crypt() and netlogon_creds_first_step()
Stefan Metzmacher [Tue, 25 Aug 2009 09:25:47 +0000 (11:25 +0200)]
libcli/auth: add netlogon_creds_step_crypt() and netlogon_creds_first_step()

This abstracts the usage of crypto functions instead of directly calling
des_crypt112().

metze

Signed-off-by: Günther Deschner <gd@samba.org>
15 years agolibcli/auth: remove some useless lines
Stefan Metzmacher [Tue, 25 Aug 2009 09:12:48 +0000 (11:12 +0200)]
libcli/auth: remove some useless lines

metze

Signed-off-by: Günther Deschner <gd@samba.org>