mat/samba.git
16 years agoFix signing bug found by Volker. That one was *subtle*.
Jeremy Allison [Tue, 4 Dec 2007 21:30:22 +0000 (13:30 -0800)]
Fix signing bug found by Volker. That one was *subtle*.
Jeremy
(This used to be commit 816aea6c1a426eb2450061b847729e22bdac33a0)

16 years agoFix crash bug with vl's new trans handling in old transs
Jeremy Allison [Tue, 4 Dec 2007 20:53:21 +0000 (12:53 -0800)]
Fix crash bug with vl's new trans handling in old transs
calls. Make this look like the (working) transs2 handling
(replace inbuf, not write to outbuf - outbuf isn't allocated
yet so you get a null deref).
Jeremy.
(This used to be commit f04e37a630f8e7538d670d34db4ea7fc7c0b50a3)

16 years agoGone from usershare.
Jeremy Allison [Tue, 4 Dec 2007 03:19:19 +0000 (19:19 -0800)]
Gone from usershare.
Jeremy.
(This used to be commit f1555f4f0d66e57fd19f200f842e4d05527accd5)

16 years agoDon't forget to delete the stackframe.
Jeremy Allison [Tue, 4 Dec 2007 02:56:54 +0000 (18:56 -0800)]
Don't forget to delete the stackframe.
Jeremy.
(This used to be commit 0551ee3402daebe5b96a66162d7702ca5a31da52)

16 years agoGetting to the home stretch for elimination of pstrings...
Jeremy Allison [Tue, 4 Dec 2007 02:48:41 +0000 (18:48 -0800)]
Getting to the home stretch for elimination of pstrings...
Jeremy.
(This used to be commit 041163551194102ca67fef52c57d87020a1d09bc)

16 years agoRemove more pstrings, from the winbindd protocol def and
Jeremy Allison [Tue, 4 Dec 2007 01:57:46 +0000 (17:57 -0800)]
Remove more pstrings, from the winbindd protocol def and
inside winbindd. Remove unused pstring types.
Jeremy.
(This used to be commit 9ccac8abb0420393569dbca73e7daf2742aa1099)

16 years agoMake strhex_to_str clear on string limits. Remove pstring from web/*.c
Jeremy Allison [Tue, 4 Dec 2007 01:17:05 +0000 (17:17 -0800)]
Make strhex_to_str clear on string limits. Remove pstring from web/*.c
Jeremy.
(This used to be commit f9c8d62389f8cb47837e5360209936176537df13)

16 years agoFix the build. fstrterminate was used in one place.
Jeremy Allison [Mon, 3 Dec 2007 23:47:30 +0000 (15:47 -0800)]
Fix the build. fstrterminate was used in one place.
Jeremy.
(This used to be commit 0ccd87c56b34bdc34c73d700d21544fe269f9141)

16 years agoRemove unused wpstring and macros. Stop using pstrcpy in smbd/*.c
Jeremy Allison [Mon, 3 Dec 2007 23:19:22 +0000 (15:19 -0800)]
Remove unused wpstring and macros. Stop using pstrcpy in smbd/*.c
Jeremy.
(This used to be commit e72bce5b62fb0a9d0ff4a3d76490219994f303cf)

16 years agoChange tdb_unpack "P" to return a malloc'ed string rather
Jeremy Allison [Mon, 3 Dec 2007 22:54:06 +0000 (14:54 -0800)]
Change tdb_unpack "P" to return a malloc'ed string rather
than expect a pstring space to put data into.
Fix the (few) callers.
Jeremy.
(This used to be commit 7722a7d2c63f84b8105aa775b39f0ceedd4ed513)

16 years agoLast pstring here.
Jeremy Allison [Mon, 3 Dec 2007 22:11:45 +0000 (14:11 -0800)]
Last pstring here.
Jeremy.
(This used to be commit 98d86dcbd898f48748bbfbe1066a7014d25392d1)

16 years agoRemove pstring from clirap2 by completely rewriting the damn
Jeremy Allison [Mon, 3 Dec 2007 22:09:48 +0000 (14:09 -0800)]
Remove pstring from clirap2 by completely rewriting the damn
thing :-). Now with added paranoia.
Jeremy.
(This used to be commit b6b5f92bc9457220df384bdb13530c393d294ce7)

16 years agoFix shutdown callers.
Günther Deschner [Mon, 3 Dec 2007 17:40:36 +0000 (18:40 +0100)]
Fix shutdown callers.

Guenther
(This used to be commit de2fdc6b5a78932f8ea5cf4c4715296f18dae4d3)

16 years agoFix wkssvc callers.
Günther Deschner [Mon, 3 Dec 2007 17:40:09 +0000 (18:40 +0100)]
Fix wkssvc callers.

Guenther
(This used to be commit b734cd8aab163d794b969c4e1e721e81a8b4d44c)

16 years agoFix dfs callers.
Günther Deschner [Mon, 3 Dec 2007 17:36:25 +0000 (18:36 +0100)]
Fix dfs callers.

Guenther
(This used to be commit 0a8759d0118715ef1546ae5fc404a26f874f2d80)

16 years agoFix svcctl callers.
Günther Deschner [Mon, 3 Dec 2007 17:25:13 +0000 (18:25 +0100)]
Fix svcctl callers.

Guenther
(This used to be commit 91bf2ac1af66acd8bcc831e758b3765fc94b2485)

16 years agoFix winreg callers.
Günther Deschner [Mon, 3 Dec 2007 17:21:40 +0000 (18:21 +0100)]
Fix winreg callers.

Guenther
(This used to be commit 677d9e6d86997a1ae10266e9bab3b18c3fdd2890)

16 years agoForgot header in previous commit.
Günther Deschner [Mon, 3 Dec 2007 17:20:02 +0000 (18:20 +0100)]
Forgot header in previous commit.

Guenther
(This used to be commit 8a1b306b826c75dde9caadc93b022bfa9bf3c4e3)

16 years agoRegenerate pidl rpc client calls that are WERROR based.
Günther Deschner [Mon, 3 Dec 2007 17:19:20 +0000 (18:19 +0100)]
Regenerate pidl rpc client calls that are WERROR based.

Guenther
(This used to be commit 298b0ce951f02705c5660a4171f7cc208de7a1db)

16 years agoRemove workaround for broken capabilites.h from lib/system.c - now in lib/replace.
Michael Adam [Mon, 3 Dec 2007 15:52:44 +0000 (16:52 +0100)]
Remove workaround for broken capabilites.h from lib/system.c - now in lib/replace.

Michael
(This used to be commit a3fbb5323222334c86c0dc360df8c6a39039bbe6)

16 years agoReformat configure checks for broken capabilities.h.
Michael Adam [Mon, 3 Dec 2007 15:50:55 +0000 (16:50 +0100)]
Reformat configure checks for broken capabilities.h.

Michael
(This used to be commit 834a16225a8fb905a8f870a17ba67670e622eccc)

16 years agoMove check for broken system capabilites.h headers to lib/replace.
Michael Adam [Mon, 3 Dec 2007 15:43:51 +0000 (16:43 +0100)]
Move check for broken system capabilites.h headers to lib/replace.

Michael
(This used to be commit 8ec10c4ab1aa890c9f03d34bd872c93ae5c4d84c)

16 years agoAdd check for ppc statfs.h header to workaround for broken capabilities.h.
Michael Adam [Mon, 3 Dec 2007 15:42:08 +0000 (16:42 +0100)]
Add check for ppc statfs.h header to workaround for broken capabilities.h.

Taken from s3:lib/system.c

Michael
(This used to be commit 07e6cfdc626c2778292e5b0b338a35046c482cf9)

16 years agoAdd decode_wkssvc_join_password_buffer().
Günther Deschner [Mon, 3 Dec 2007 13:06:22 +0000 (14:06 +0100)]
Add decode_wkssvc_join_password_buffer().

Guenther
(This used to be commit ba2a544baf1e1cc3652512ed5df2bb408fa8bdfd)

16 years agoReanimate rpcclient wkssvc command.
Günther Deschner [Mon, 3 Dec 2007 11:42:17 +0000 (12:42 +0100)]
Reanimate rpcclient wkssvc command.

Guenther
(This used to be commit 1d615e3ac397106f47c51ace36c01a8f6e1d5d13)

16 years agoActually implement reboot feature for net dom join/unjoin.
Günther Deschner [Mon, 3 Dec 2007 10:07:27 +0000 (11:07 +0100)]
Actually implement reboot feature for net dom join/unjoin.

Guenther
(This used to be commit bbbeeba163f173d774937103a36560a4a4f49d4b)

16 years agoReformatting
Volker Lendecke [Mon, 3 Dec 2007 09:45:47 +0000 (10:45 +0100)]
Reformatting
(This used to be commit 28c0a77ec1eb4bc69679c00dcdacaa6ee4d8e3f5)

16 years agoFix some bogus uninitialized variable warnings
Volker Lendecke [Sat, 1 Dec 2007 10:41:44 +0000 (11:41 +0100)]
Fix some bogus uninitialized variable warnings
(This used to be commit 48a162b709cc14632fd02c4cd40aa8cfafc53324)

16 years agoBump up debug level
Volker Lendecke [Sun, 2 Dec 2007 11:54:11 +0000 (12:54 +0100)]
Bump up debug level

Fix bug 5115
(This used to be commit d3c839c22edeca2de68574a8f5dd328080577f3a)

16 years agoIn nttransact_create, we also need to check for delete readonly
Volker Lendecke [Sat, 1 Dec 2007 14:01:01 +0000 (15:01 +0100)]
In nttransact_create, we also need to check for delete readonly
(This used to be commit f4cc9cab518e97c1049aaad7516aba212ae15c95)

16 years agoFix some C++ warnings
Volker Lendecke [Sat, 1 Dec 2007 10:43:12 +0000 (11:43 +0100)]
Fix some C++ warnings
(This used to be commit 156c7f10bb63a610f85b52242cfd1b67bfa73c29)

16 years agoFix an uninitialized variable
Volker Lendecke [Sat, 1 Dec 2007 10:43:00 +0000 (11:43 +0100)]
Fix an uninitialized variable
(This used to be commit edce7bd7a9dd1064ba8aec34b334c7395228f40b)

16 years agoFix some C++ warnings
Volker Lendecke [Sat, 1 Dec 2007 10:42:32 +0000 (11:42 +0100)]
Fix some C++ warnings

I think were are actually bugs.
(This used to be commit 1be19f07889ae09f79030f1ff8f2cf5e9a3d9dc5)

16 years agoFix missing error cleanup noticed by Derrell.
Jeremy Allison [Sat, 1 Dec 2007 05:57:43 +0000 (21:57 -0800)]
Fix missing error cleanup noticed by Derrell.
Jeremy.
(This used to be commit 37f00926c29c22f27e7192c1fff0a08ce136cb86)

16 years agoEnsure we have 2 bytes of zeros as a pad-buffer at the
Jeremy Allison [Sat, 1 Dec 2007 02:02:19 +0000 (18:02 -0800)]
Ensure we have 2 bytes of zeros as a pad-buffer at the
end of all returned trans/trans2/nttrans client replies.
Not included in a count - for safety purposes.
Jeremy.
(This used to be commit 3e65fa5bcf5d1af3983f2e576698eccaad79fcda)

16 years agoWhitespace cleanup.
Jeremy Allison [Sat, 1 Dec 2007 00:45:44 +0000 (16:45 -0800)]
Whitespace cleanup.
Jeremy.
(This used to be commit 4dfe19be1c3a63b8517c6580c9cd363c7271693d)

16 years agoRemove pstring from clirap.c.
Jeremy Allison [Sat, 1 Dec 2007 00:13:35 +0000 (16:13 -0800)]
Remove pstring from clirap.c.
Jeremy.
(This used to be commit 6e27663cb44a79f729fa4366e000c43383f6d1b7)

16 years agoRemoved all pstrings from libsmbclient. Derryl please
Jeremy Allison [Fri, 30 Nov 2007 22:19:55 +0000 (14:19 -0800)]
Removed all pstrings from libsmbclient. Derryl please
check. Passes valgrind tests I've run in examples/libsmbclient.
Jeremy.
(This used to be commit 9d0034faed939a4534637696f1631ac2da60e4a3)

16 years agoFix restart after length count.
Jeremy Allison [Fri, 30 Nov 2007 22:15:34 +0000 (14:15 -0800)]
Fix restart after length count.
Jeremy.
(This used to be commit fa8115f32bfd37f75c284ff0f6906dbc2af0f40c)

16 years agoAvoid to include net prototypes, just reference user creds.
Günther Deschner [Fri, 30 Nov 2007 19:33:51 +0000 (20:33 +0100)]
Avoid to include net prototypes, just reference user creds.

Guenther
(This used to be commit 09e01a47164702f67403e61bc478d1cb54f0508e)

16 years agoAdd "net dom" command suite to "net".
Günther Deschner [Fri, 30 Nov 2007 19:21:37 +0000 (20:21 +0100)]
Add "net dom" command suite to "net".

Guenther
(This used to be commit a41f9aef843378b1f85f9b3d672d00f3399fa342)

16 years agoAdd "net dom unjoin" code.
Günther Deschner [Fri, 30 Nov 2007 19:20:54 +0000 (20:20 +0100)]
Add "net dom unjoin" code.

Guenther
(This used to be commit 58d49023b9bc7d27e770f18a25cc6cebdc95b300)

16 years agoAdd "net dom join" code.
Günther Deschner [Fri, 30 Nov 2007 19:20:18 +0000 (20:20 +0100)]
Add "net dom join" code.

Guenther
(This used to be commit 177dab0ce31970c851531ffd2a6c5946e329a048)

16 years agoAdd header file for NetJoinDomain() and friends.
Günther Deschner [Fri, 30 Nov 2007 19:18:46 +0000 (20:18 +0100)]
Add header file for NetJoinDomain() and friends.

Guenther
(This used to be commit 7cea527e8712cde34378ae8b32aad1e4aab0c17b)

16 years agoAdd NetUnjoinDomain().
Günther Deschner [Fri, 30 Nov 2007 18:57:08 +0000 (19:57 +0100)]
Add NetUnjoinDomain().

Guenther
(This used to be commit fd9d73ad44b0f0b3656a50a663b60aa26e7f7376)

16 years agoRobustness-fixes for NetJoinDomain().
Günther Deschner [Fri, 30 Nov 2007 18:56:41 +0000 (19:56 +0100)]
Robustness-fixes for NetJoinDomain().

Guenther
(This used to be commit 2d5236cc37fe015ce9098a0ebe99cdc0ca3537ae)

16 years agoGive NetJoinDomain() enough time to finish.
Günther Deschner [Fri, 30 Nov 2007 18:55:40 +0000 (19:55 +0100)]
Give NetJoinDomain() enough time to finish.

Guenther
(This used to be commit 7f021b3cb7845c6eb142668f66599886cd92182f)

16 years agodomain_name is a ref pointer.
Günther Deschner [Fri, 30 Nov 2007 18:52:27 +0000 (19:52 +0100)]
domain_name is a ref pointer.

Guenther
(This used to be commit b350e482b9b211caf08c22c7528b51e47b4a5cce)

16 years agoMerge join error codes from Samba 4.
Günther Deschner [Fri, 30 Nov 2007 18:46:25 +0000 (19:46 +0100)]
Merge join error codes from Samba 4.

Guenther
(This used to be commit 88a01bd810c36631272c5db727334bdc6f12f07d)

16 years agoAdd NetJoinDomain call.
Günther Deschner [Fri, 30 Nov 2007 17:49:21 +0000 (18:49 +0100)]
Add NetJoinDomain call.

Guenther
(This used to be commit 08a5a036ba97d1f4830d73e95b8369aa9e6683e8)

16 years agoMove param helper routines to one place.
Günther Deschner [Fri, 30 Nov 2007 17:47:25 +0000 (18:47 +0100)]
Move param helper routines to one place.

Guenther
(This used to be commit 6bf2c8038c4bc7a52b7f260209ade0bdeb95c685)

16 years agoMake encode_wkssvc_join_password_buffer() non-static.
Günther Deschner [Fri, 30 Nov 2007 13:34:33 +0000 (14:34 +0100)]
Make encode_wkssvc_join_password_buffer() non-static.

Guenther
(This used to be commit 258ef17a266548bc02bed1870fd4ef5a272300b3)

16 years agoMerge encode_wkssvc_join_password_buffer() from samba4.
Günther Deschner [Fri, 30 Nov 2007 13:05:53 +0000 (14:05 +0100)]
Merge encode_wkssvc_join_password_buffer() from samba4.

Guenther
(This used to be commit b1d36cdb86978cb31d470fccf2dc24d366835c36)

16 years agoAdd talloc versions of all the next_token() functions.
Jeremy Allison [Fri, 30 Nov 2007 21:09:04 +0000 (13:09 -0800)]
Add talloc versions of all the next_token() functions.
Now I can really start removing fixed length strings...
Jeremy.
(This used to be commit 0ae61e26547e594e94037d4474a008221e5df8cf)

16 years agoRemove pstrings from clifile.c.
Jeremy Allison [Fri, 30 Nov 2007 01:47:31 +0000 (17:47 -0800)]
Remove pstrings from clifile.c.
Jeremy.
(This used to be commit d5658914c2d6ec878d9a11f8a1fa57f1697362e3)

16 years agoRemove PSTRING_LEN from smbd/ nmbd/.
Jeremy Allison [Fri, 30 Nov 2007 01:25:41 +0000 (17:25 -0800)]
Remove PSTRING_LEN from smbd/ nmbd/.
Remove pstring from libsmb/clidfs.c except for a nasty
hack (that will be removed when pstrings are gone from
client/).
Jeremy.
(This used to be commit cc257b71d13daa47e6f2315d0f07a60eb4aaeca6)

16 years agoFix _reg_perfcount_get_instance_info()
Günther Deschner [Fri, 30 Nov 2007 01:16:46 +0000 (02:16 +0100)]
Fix _reg_perfcount_get_instance_info()

Guenther
(This used to be commit 20c1ba23f2e2902ef7c2237c63addfef2ae75eac)

16 years agoMerge recent wkssvc changes from samba4.
Günther Deschner [Fri, 30 Nov 2007 00:44:44 +0000 (01:44 +0100)]
Merge recent wkssvc changes from samba4.

Guenther
(This used to be commit 7539fb4c840a9b4429f347cebbda9c631746267a)

16 years agoFix build warning.
Günther Deschner [Tue, 27 Nov 2007 17:09:50 +0000 (18:09 +0100)]
Fix build warning.

Guenther
(This used to be commit bf4881d7774681e22f270697c7623bde33c30fe0)

16 years agoFix memleak.
Jeremy Allison [Fri, 30 Nov 2007 00:30:18 +0000 (16:30 -0800)]
Fix memleak.
Jeremy.
(This used to be commit ccacd170472869391bd1e5bc850b1467492b8fa3)

16 years agoRemove the explicit TALLOC_CTX * from cli_struct.
Jeremy Allison [Thu, 29 Nov 2007 21:24:54 +0000 (13:24 -0800)]
Remove the explicit TALLOC_CTX * from cli_struct.
Make us very explicit about how long a talloc ctx
should last.
Jeremy.
(This used to be commit ba9e2be2b5a59684e854609f9d82ea1633448c62)

16 years agoRemove pstrings. Ensure we validate offsets.
Jeremy Allison [Thu, 29 Nov 2007 21:24:14 +0000 (13:24 -0800)]
Remove pstrings. Ensure we validate offsets.
Jeremy.
(This used to be commit ff06cc34e66a18ba71dd54f6c78b05a45b9f2d85)

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 29 Nov 2007 17:48:33 +0000 (09:48 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit aff5a52136b85fe82c4acb08d12009187d1fe6c7)

16 years agoAllow calling "net rpc join" and "net rpc trustdom" without specifying server IP.
Michael Adam [Thu, 29 Nov 2007 14:16:06 +0000 (15:16 +0100)]
Allow calling "net rpc join" and "net rpc trustdom" without specifying server IP.

This was a logic bug (typo) in a call to get_pdc_ip() in net_find_server().

Michael
(This used to be commit 988c5ff3f47b7508b229464bbed2ca1948d6e27c)

16 years agoRemove unused code (and pstring).
Jeremy Allison [Wed, 28 Nov 2007 22:08:49 +0000 (14:08 -0800)]
Remove unused code (and pstring).
Jeremy.
(This used to be commit a261a61226248b41be22dd4f2873b5ed82bc2a24)

16 years agoAdd a warning for a potential bug I've run into
Volker Lendecke [Wed, 28 Nov 2007 12:43:31 +0000 (13:43 +0100)]
Add a warning for a potential bug I've run into
(This used to be commit 223352e32372f1b055298cfc6f2770043a845e3d)

16 years agoGive rpcclient a talloc stackframe.
Michael Adam [Wed, 28 Nov 2007 14:24:18 +0000 (15:24 +0100)]
Give rpcclient a talloc stackframe.

Michael
(This used to be commit 3330394d2d5d58576d9ddb52f60a3e27f31d5198)

16 years agoRemove pstrings from asn1.c.
Jeremy Allison [Wed, 28 Nov 2007 07:40:54 +0000 (23:40 -0800)]
Remove pstrings from asn1.c.
Jeremy.
(This used to be commit 82f393e60378eb42ddcc740241902eee495719d3)

16 years agoRemove pstrings from namequery.c.
Jeremy Allison [Wed, 28 Nov 2007 07:10:20 +0000 (23:10 -0800)]
Remove pstrings from namequery.c.
Jeremy.
(This used to be commit 71ccd0c42e0ae66172ca5797be3d3a01f4a67a69)

16 years agoFixed obvious typo.
Jeremy Allison [Wed, 28 Nov 2007 07:00:11 +0000 (23:00 -0800)]
Fixed obvious typo.
Jeremy.
(This used to be commit 9755c5311416f17bac0a848d027cafb3fd487618)

16 years agoRemove unused prototype for smbldap_get_single_pstring().
Jeremy Allison [Wed, 28 Nov 2007 06:22:35 +0000 (22:22 -0800)]
Remove unused prototype for smbldap_get_single_pstring().
Don't use pstr_sprintf() on an fstring - change to talloc.
Jeremy.
(This used to be commit 6cae4b5fa1bcb848cb2a28daaafeefd6bcd08274)

16 years agoSave one extra strdup per lp_string. Use talloc_sub_basic()
Jeremy Allison [Wed, 28 Nov 2007 03:12:42 +0000 (19:12 -0800)]
Save one extra strdup per lp_string. Use talloc_sub_basic()
directly.
Jeremy.
(This used to be commit f1e401ef5c89ecf12921b7adb228da438521a693)

16 years agoRemove pstring from srv_spoolss_nt.c. All gone from rpc_server/*.c
Jeremy Allison [Wed, 28 Nov 2007 03:05:08 +0000 (19:05 -0800)]
Remove pstring from srv_spoolss_nt.c. All gone from rpc_server/*.c
Jeremy.
(This used to be commit b5a2a1e3f82a0d319fc9a1d76f5166150680f4d4)

16 years agoFix old cut-and-paste bug where the wrong field was being written to.
Jeremy Allison [Wed, 28 Nov 2007 01:50:39 +0000 (17:50 -0800)]
Fix old cut-and-paste bug where the wrong field was being written to.
Jerry please check.
Jeremy.
(This used to be commit 6a556fd73ac8c247c15df664f7910f8688abfdbc)

16 years agoWhitespace cleanup.
Jeremy Allison [Wed, 28 Nov 2007 01:48:59 +0000 (17:48 -0800)]
Whitespace cleanup.
Jeremy.
(This used to be commit 3052172d2bfe9d787777525e90816394aac2dd54)

16 years agoMake init_unistr2_from_unistr take an explicit talloc context.
Jeremy Allison [Wed, 28 Nov 2007 01:48:44 +0000 (17:48 -0800)]
Make init_unistr2_from_unistr take an explicit talloc context.
Make init_unistr() re-use rpcstr_push_talloc().
Jeremy.
(This used to be commit 04aecde5cfdb00d5aa32f9675c797266aba83c0f)

16 years agoRemove pstrings from everything except srv_spoolss_nt.c.
Jeremy Allison [Tue, 27 Nov 2007 22:35:30 +0000 (14:35 -0800)]
Remove pstrings from everything except srv_spoolss_nt.c.
Jeremy.
(This used to be commit 0002a9e96b0ef78316295a6eb94ff29b64e2f988)

16 years agofix a obscure compiler warning
Guenther Deschner [Tue, 27 Nov 2007 20:53:41 +0000 (21:53 +0100)]
fix a obscure compiler warning

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jeremy,

I have never seen this warning before:
"warning: comparison is always false due to limited range of data type".

Guenther
- --
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner@redhat.com
Samba Team                              gd@samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHTIOOSOk3aI7hFogRArxMAJwP0ktE96tHcwn9nXG6AOqonpeDgQCgm/zi
54B6HJZvx6zdUTMFFNWqUb0=
=kUJa
-----END PGP SIGNATURE-----

>From 6a4935ee455adc1251fce2759f97d35f303bd40e Mon Sep 17 00:00:00 2001
From: =?utf-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
Date: Tue, 27 Nov 2007 21:48:39 +0100
Subject: [PATCH] Getting rid of "comparison is always false due to limited range of data type"
 warning.

Guenther
(This used to be commit 951202913956e113841585f7372e8db8f9aeb76a)

16 years agoRemove pstring from everything in rpc_server except
Jeremy Allison [Tue, 27 Nov 2007 19:22:58 +0000 (11:22 -0800)]
Remove pstring from everything in rpc_server except
srv_spoolss_nt.c and srv_srvsvc_nt.c.
They're next :-).
Jeremy.
(This used to be commit 55b4f9d003b036af69085f7b64e0df08c5ba440d)

16 years agoUnless talloc has some new magic there is a ctx missing here.
Günther Deschner [Tue, 27 Nov 2007 17:01:56 +0000 (18:01 +0100)]
Unless talloc has some new magic there is a ctx missing here.

Guenther
(This used to be commit 172f7ce96dc12cfc7d2209d8ed56aeebefd6207b)

16 years agoUse the proper boolean constants - the type has been
Michael Adam [Tue, 27 Nov 2007 15:36:06 +0000 (16:36 +0100)]
Use the proper boolean constants - the type has been
changed from BOOL to bool.

Michael
(This used to be commit 03673f2cd614526e7720275a5ba0869c68429f4d)

16 years agoRemove some statics
Volker Lendecke [Sun, 25 Nov 2007 09:10:52 +0000 (10:10 +0100)]
Remove some statics
(This used to be commit 1fab16ffb888cd4ec18e52d9da33976a67a5d104)

16 years agoRemove pstrings from nsswitch/ and registry/
Jeremy Allison [Tue, 27 Nov 2007 01:24:56 +0000 (17:24 -0800)]
Remove pstrings from nsswitch/ and registry/
Jeremy.
(This used to be commit 331c0d6216e1a1607a49ed7eb4078e10138ec16a)

16 years agoRemove a global
Volker Lendecke [Sat, 24 Nov 2007 16:27:19 +0000 (17:27 +0100)]
Remove a global
(This used to be commit 3088bc76f1ceffecaa5aea039be79973c9876f0c)

16 years agoFix bug 5055
Volker Lendecke [Mon, 26 Nov 2007 14:28:13 +0000 (15:28 +0100)]
Fix bug 5055
(This used to be commit 8bcd2df841bae63e7d58c35d4728b7d853471697)

16 years agoImprove debug message
Volker Lendecke [Mon, 26 Nov 2007 13:30:50 +0000 (14:30 +0100)]
Improve debug message

Fix bug 5056, thanks to debian package maintainer
(This used to be commit 5b4ba4bfc54e2fa468abe15383e5b33eb5bd1324)

16 years agoFix a C++ warning
Volker Lendecke [Mon, 26 Nov 2007 10:55:55 +0000 (11:55 +0100)]
Fix a C++ warning
(This used to be commit 9bf5ead4b2be57fa84e5b3137bfa0305a916f10f)

16 years ago1. lib/system.c (xattr code for Solaris) could not be
Tomoki AONO [Sat, 24 Nov 2007 16:59:40 +0000 (01:59 +0900)]
1. lib/system.c (xattr code for Solaris) could not be
built against c90 compilers. (declaration after
statement.) Sample patch attached.
(This used to be commit 102a247df99967f25dbaf40c9be2d48a8e15c64c)

16 years agoIn libsmbclient, map NT_STATUS_OBJECT_PATH_NOT_FOUND to ENOENT
Volker Lendecke [Sun, 25 Nov 2007 11:54:52 +0000 (12:54 +0100)]
In libsmbclient, map NT_STATUS_OBJECT_PATH_NOT_FOUND to ENOENT

Thanks to SATOH Fumiyasu!

This fixes bug 4974
(This used to be commit 41e07682dc1fa535ddaf405efa26fabb33c8bbf9)

16 years agoRemove a static
Volker Lendecke [Sat, 24 Nov 2007 15:32:38 +0000 (16:32 +0100)]
Remove a static
(This used to be commit 85a84f72ffc440fb71744cb72de2dba07793123c)

16 years agoMake remote_password_change return malloced error strings
Volker Lendecke [Fri, 23 Nov 2007 11:04:35 +0000 (12:04 +0100)]
Make remote_password_change return malloced error strings

This fixes a segfault in smbpasswd -r
(This used to be commit 49949f0b85007c7c2b3c340c12f3d18909862135)

16 years agoadd talloc_stackframe() to eventlogadm
Volker Lendecke [Fri, 23 Nov 2007 13:34:13 +0000 (14:34 +0100)]
add talloc_stackframe() to eventlogadm

Thanks to Günther Kukkukk for noticing
(This used to be commit 9751cc222c70fd669a1cc1ad61ffb4e2e8444019)

16 years agoprinting: fix default printing subsystem detection
Stefan Metzmacher [Fri, 23 Nov 2007 10:51:33 +0000 (11:51 +0100)]
printing: fix default printing subsystem detection

"system/printing.h" includes an outdated copy of
the stuff in samba3's includes.h, so we should not use it.

metze
(This used to be commit 0a7338abfabaf31c2cbd81fb4ac8f1ce45735bed)

16 years agosmbd: close_stat() should be static
Stefan Metzmacher [Wed, 21 Nov 2007 15:41:12 +0000 (16:41 +0100)]
smbd: close_stat() should be static

metze
(This used to be commit e186b60afacfb609968b581a6d32757e1885a319)

16 years agoDo not link in SOCKET_WRAPPER_OBJ twice
Volker Lendecke [Thu, 22 Nov 2007 14:48:47 +0000 (15:48 +0100)]
Do not link in SOCKET_WRAPPER_OBJ twice
(This used to be commit 99b3289aa44c94c16f5330eba841fd9c21c6303b)

16 years agoCosmetic fix
Volker Lendecke [Wed, 7 Nov 2007 19:18:38 +0000 (20:18 +0100)]
Cosmetic fix
(This used to be commit 8d8cb8f9ccbc013b97c252d27c3af4e2eb10d56a)

16 years agoAdd a missing prototype
Volker Lendecke [Tue, 13 Nov 2007 10:43:48 +0000 (11:43 +0100)]
Add a missing prototype
(This used to be commit 89e2984a84951373d0e93fe06d0c69c8a62bc777)

16 years agoFix an uninitialized variable
Volker Lendecke [Mon, 12 Nov 2007 16:36:34 +0000 (17:36 +0100)]
Fix an uninitialized variable
(This used to be commit e8b866ad87476ef69c06993d255269ce9fba3121)

16 years agoFix a type-punned warning
Volker Lendecke [Fri, 16 Nov 2007 13:48:26 +0000 (14:48 +0100)]
Fix a type-punned warning
(This used to be commit 4c992e4340eda31e686a2d2a8db6364aaa456c11)

16 years agoMerge ssh://git.samba.org/data/git/samba into v3-2-test
James Peach [Thu, 22 Nov 2007 02:31:35 +0000 (18:31 -0800)]
Merge ssh://git.samba.org/data/git/samba into v3-2-test
(This used to be commit 660ea443364e949ed06c28b00f0e1c3757f0da27)