Tim Prouty [Tue, 27 Jan 2009 00:50:31 +0000 (16:50 -0800)]
s3 build: Eliminate the gmake-specific Makefile syntax
Tim Prouty [Mon, 26 Jan 2009 23:38:19 +0000 (15:38 -0800)]
s3 make test: Fix a bug in the previous commit
Luckily the build farm caught this
Tim Prouty [Sun, 25 Jan 2009 22:38:44 +0000 (14:38 -0800)]
s3 make test: Add the ability to specify a custom smb.conf for make test
- Adds new -c <custom conf> option to selftest.sh that when specified
adds a line to make test's server.conf: "include <custom conf>"
- Adds getopts processing to selftest.sh
- Changes selftest.sh shrdir arg to use -s <shrdir>
- Changes selftest.sh smbtorture4_path arg to use -t <smbtortur4 path>
- Adds configure option --with-selftest-custom-conf=<custom conf>
- Updates Makefile.in to take advantage of the new/changed parameters
Jelmer Vernooij [Mon, 26 Jan 2009 17:14:41 +0000 (18:14 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Mon, 26 Jan 2009 16:31:50 +0000 (17:31 +0100)]
pyrpc: Raise proper NDR error codes with matching strings rather than mapping
to NTSTATUS first.
Jelmer Vernooij [Mon, 26 Jan 2009 16:31:22 +0000 (17:31 +0100)]
Add function for mapping NDR error codes to strings.
Andreas Schneider [Mon, 26 Jan 2009 13:38:34 +0000 (14:38 +0100)]
Document default of the printing config variable.
Signed-off-by: Andreas Schneider <anschneider@suse.de>
Karolin Seeger [Mon, 26 Jan 2009 13:17:23 +0000 (14:17 +0100)]
docs: Add manpage for vfs_shadow_copy2.
Karolin
Volker Lendecke [Mon, 26 Jan 2009 02:38:05 +0000 (03:38 +0100)]
Decouple clistr_pull from struct cli_state->inbuf
Volker Lendecke [Sun, 25 Jan 2009 19:33:22 +0000 (20:33 +0100)]
Fix an error path memleak
Volker Lendecke [Sun, 25 Jan 2009 19:32:59 +0000 (20:32 +0100)]
Make smb_bytes_push_str deal with a NULL buf returning NULL
Volker Lendecke [Sun, 25 Jan 2009 11:22:20 +0000 (12:22 +0100)]
Fix chain_reply for pipe reads
The caller might have over-allocated reply->outbuf. Deal with that.
Sorry, Günther, for giving you so much pain ...
Volker
Jelmer Vernooij [Sun, 25 Jan 2009 04:35:21 +0000 (05:35 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Sun, 25 Jan 2009 04:32:30 +0000 (05:32 +0100)]
Add prototypes required by samba-gtk.
Volker Lendecke [Sat, 24 Jan 2009 14:08:14 +0000 (15:08 +0100)]
Fix a segfault in parse_logentry
entry->data_record.strings is type smb_ucs2, so the pointer arithmetic
increments by two :-)
todd stecher [Sat, 24 Jan 2009 00:55:18 +0000 (16:55 -0800)]
Modify OneFS module to support new NTIMES interfaces
todd stecher [Fri, 23 Jan 2009 22:40:19 +0000 (14:40 -0800)]
Extend NTIMES to allow setting create_time
1) Add in smb_file_time struct to clarify code and make room for createtime.
2) Get and set create time from SMB messages.
3) Fixup existing VFS modules + examples Some OS'es allow for the
setting of the birthtime through kernel interfaces. This value is
generically used for Windows createtime, but is not settable in the
code today.
todd stecher [Fri, 23 Jan 2009 22:38:40 +0000 (14:38 -0800)]
This change allows for the autoconfigre detection of sub-second time resolution in the FreeBSD stat structure
Günther Deschner [Tue, 20 Jan 2009 23:33:01 +0000 (00:33 +0100)]
s4-smbtorture: add my copyright.
Guenther
Günther Deschner [Tue, 20 Jan 2009 23:25:50 +0000 (00:25 +0100)]
s4-smbtorture: add BackupLog handling in eventlog test.
Guenther
Günther Deschner [Tue, 20 Jan 2009 22:01:58 +0000 (23:01 +0100)]
s3-rpcclient: add eventlog_loginfo command.
Guenther
Günther Deschner [Tue, 20 Jan 2009 21:18:29 +0000 (22:18 +0100)]
s3-rpcclient: add eventlog_backuplog command.
Guenther
Günther Deschner [Tue, 20 Jan 2009 19:10:16 +0000 (20:10 +0100)]
s3-rpcclient: add eventlog_registerevsource command.
Guenther
Günther Deschner [Tue, 20 Jan 2009 18:26:41 +0000 (19:26 +0100)]
s3-rpcclient: add eventlog_reporteventsource command.
Guenther
Günther Deschner [Tue, 20 Jan 2009 18:01:43 +0000 (19:01 +0100)]
s4-smbtorture: add test_GetLogIntormation test.
Guenther
Günther Deschner [Tue, 20 Jan 2009 18:09:53 +0000 (19:09 +0100)]
s3-rpcclient: add eventlog_reportevent command.
Guenther
Günther Deschner [Tue, 20 Jan 2009 17:42:47 +0000 (18:42 +0100)]
s4-smbtorture: add ReportEventW test.
Guenther
Günther Deschner [Thu, 22 Jan 2009 18:35:33 +0000 (19:35 +0100)]
s3-eventlog: add missing _eventlog_ReportEventAndSourceW stub call.
Guenther
Günther Deschner [Sat, 24 Jan 2009 02:30:48 +0000 (03:30 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 20 Jan 2009 21:18:53 +0000 (22:18 +0100)]
eventlog: fill in IDL for eventlog_OpenBackupEventLogW.
Guenther
Günther Deschner [Tue, 20 Jan 2009 21:06:01 +0000 (22:06 +0100)]
eventlog: fill in IDL for eventlog_BackupEventLogW.
Guenther
Günther Deschner [Tue, 20 Jan 2009 19:00:02 +0000 (20:00 +0100)]
eventlog: fill in IDL for eventlog_DeregisterEventSource.
Guenther
Günther Deschner [Tue, 20 Jan 2009 18:58:17 +0000 (19:58 +0100)]
eventlog: fill in IDL for eventlog_RegisterEventSourceW.
Guenther
Günther Deschner [Tue, 20 Jan 2009 18:20:26 +0000 (19:20 +0100)]
eventlog: add missing IDL (opnum 24) for eventlog_ReportEventAndSourceW.
Guenther
Günther Deschner [Tue, 20 Jan 2009 17:56:34 +0000 (18:56 +0100)]
eventlog: fill in IDL for eventlog_GetLogIntormation.
Guenther
Günther Deschner [Tue, 20 Jan 2009 17:32:01 +0000 (18:32 +0100)]
eventlog: fill in IDL for eventlog_ReportEventW.
Guenther
Günther Deschner [Sat, 24 Jan 2009 01:59:24 +0000 (02:59 +0100)]
Revert "s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server."
This reverts commit
c0f1309010b79be67557af5ffbd1c429a3f3d99a.
Günther Deschner [Sat, 24 Jan 2009 01:10:47 +0000 (02:10 +0100)]
s3-eventlog: fix various invalid memcpy in read_package_entry().
Guenther
Günther Deschner [Sat, 24 Jan 2009 01:07:40 +0000 (02:07 +0100)]
s3-eventlog: fix buffer allocation in eventlog read call.
This broke with
f6fa3080fee1b20df9f1968500840a88cf0ee592 back in April 2007...
Guenther
Tim Prouty [Sat, 24 Jan 2009 01:29:21 +0000 (17:29 -0800)]
talloc: Change the two other definitions of TALLOC_FREE to match the primary version
Eventually these two other definitions should be removed and all of
the TALLOC macros should live in the same header. Until then, this
patch eliminates some build warnings.
Tim Prouty [Sat, 24 Jan 2009 00:09:13 +0000 (16:09 -0800)]
s3 ldb: Fix vasprintf segfault that has been the source of build machine failures this week
The bug was introduced when converting samba3's ldb_search interface
to match samba4:
47951fc5d0085e124666b7667715bba98076820e
f3ecb701335b1129947127d4c45eef970b66875c
Volker Lendecke [Fri, 23 Jan 2009 22:15:05 +0000 (23:15 +0100)]
talloc_free() copes with a NULL pointer just fine
Saved around 10kb of code on my box :-)
Dan Sledz [Fri, 9 Jan 2009 01:09:28 +0000 (17:09 -0800)]
s3: OneFS unmappable sids support.
Updates the onefs vfs module to add configurable behavior to deal
with sids that are unknown to us. The best examples are aces that
come from robocopy/xcopy.
Adds the following share level options (which are specific to the vfs_onefs
module):
onefs: ignore unmappable sids (Default = false)
If this option is set to true, sids which could not be resolved to
a uid/gid are ignored. If an unmappable sid is encountered as the owner
or group, the owner/group is converted to BUILTIN\Administrators.
onefs: unmappable sids ignore list (Default = empty)
Only the sids in the list are ignored.
onefs: ignore sacls (Default = false)
SACLs are ignored
onefs: unmappable sids deny everyone (Default = false)
If an unmappable sid is found in a deny ACE, the ACE's identity is
changed to Everyone.
Kai Blin [Fri, 23 Jan 2009 11:25:49 +0000 (12:25 +0100)]
s4: add ../lib/async_req to the s4 build
Kai Blin [Fri, 23 Jan 2009 10:54:30 +0000 (11:54 +0100)]
async_req: Move to top level dir
Karolin Seeger [Fri, 23 Jan 2009 12:02:46 +0000 (13:02 +0100)]
docs: Fix formatting issue in man libsmbclient.
Karolin
Stefan Metzmacher [Fri, 23 Jan 2009 10:24:25 +0000 (11:24 +0100)]
s4: we're on the way to alhpa7
metze
Jeremy Allison [Fri, 23 Jan 2009 00:21:02 +0000 (16:21 -0800)]
Apply same logic fix for #4308 Excel save operation corrupts file ACLs
to NFSv4 ACL code as this uses the same flawed logic as posix_acls.c.
Jeremy.
Jeremy Allison [Thu, 22 Jan 2009 23:57:41 +0000 (15:57 -0800)]
Fix logic error in try_chown - we shouldn't arbitrarily chown
to ourselves unless that was passed in.
Jeremy.
Jeremy Allison [Thu, 22 Jan 2009 22:38:57 +0000 (14:38 -0800)]
Second part of the attemt to fix #4308 - Excel save operation corrupts file ACLs.
If the chown succeeds then the ACL set should also. Ensure this is the case
(refactor some of this code to make it simpler to read also).
Jeremy.
Volker Lendecke [Thu, 22 Jan 2009 17:52:15 +0000 (18:52 +0100)]
Abstract away the transport in cli_pipe.c
Sorry for the monster checkin, I could not really find a way to do this in
steps.
Volker Lendecke [Thu, 22 Jan 2009 17:39:29 +0000 (18:39 +0100)]
Add the socket rpc client transport
Volker Lendecke [Thu, 22 Jan 2009 17:34:06 +0000 (18:34 +0100)]
Add the named pipe rpc client transport
Volker Lendecke [Thu, 22 Jan 2009 21:04:55 +0000 (22:04 +0100)]
RPC_CLIENT_OBJ is the right variable for cli_pipe.o
Volker Lendecke [Thu, 22 Jan 2009 17:50:37 +0000 (18:50 +0100)]
Add struct rpc_cli_transport
Jelmer Vernooij [Thu, 22 Jan 2009 21:49:30 +0000 (22:49 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Tim Prouty [Thu, 22 Jan 2009 21:14:04 +0000 (13:14 -0800)]
s3: Fix warning
Jeremy Allison [Thu, 22 Jan 2009 18:57:10 +0000 (10:57 -0800)]
Another attempt to fix bug #4308 - Excel save operation corrupts file ACLs.
Simo is completely correct. We should be doing the chown *first*, and fail the
ACL set if this fails. The long standing assumption I made when writing the
initial POSIX ACL code was that Windows didn't control who could chown a file
in the same was as POSIX. In POSIX only root can do this whereas I wasn't sure
who could do this in Windows at the time (I didn't understand the privilege
model). So the assumption was that setting the ACL was more important (early
tests showed many failed ACL set's due to inability to chown). But now we have
privileges in smbd, and we must always fail an ACL set when we can't chown
first. The key that Simo noticed is that the CREATOR_OWNER bits in the ACL
incoming are relative to the *new* owner, not the old one. This is why the old
user owner disappears on ACL set - their access was set via the USER_OBJ in the
creator POSIX ACL and when the ownership changes they lose their access.
Patch is simple - just ensure we do the chown first before evaluating the
incoming ACL re-read the owners. We already have code to do this it just wasn't
rigorously being applied.
Jeremy.
Simo Sorce [Thu, 22 Jan 2009 16:51:37 +0000 (11:51 -0500)]
Do not start a transaction this way.
Because we still want to commit any changes that successfully apply we
never want to do a global cancel, and because of how transaction nesting
works that means we never cancel any "transaction" at the single modify
operation level.
Let each operation start its own transaction so that the transaction is
properly canceled if any error is returned and half committed operations
(though plugins failing) are properly reverted on a per operation basis.
Volker Lendecke [Thu, 22 Jan 2009 16:53:22 +0000 (17:53 +0100)]
Fix a segfault: rpccli_* expect the reply_pdu to always be initialized
Jelmer Vernooij [Thu, 22 Jan 2009 14:23:32 +0000 (15:23 +0100)]
Remove obsolete samr Python module - use samba.dcerpc.samr instead.
Jelmer Vernooij [Thu, 22 Jan 2009 13:49:51 +0000 (14:49 +0100)]
Implement as_sddl.
Jelmer Vernooij [Thu, 22 Jan 2009 13:37:59 +0000 (14:37 +0100)]
Support parsing sddl for security descriptors.
Stefan Metzmacher [Thu, 22 Jan 2009 10:52:54 +0000 (11:52 +0100)]
lib/replace: add defines to let the callers find out if pwrite and pread are thread/fork safe
metze
Stefan Metzmacher [Wed, 21 Jan 2009 06:39:28 +0000 (07:39 +0100)]
s3:printing: make some functions static and use tevent functions
metze
Stefan Metzmacher [Wed, 21 Jan 2009 06:39:56 +0000 (07:39 +0100)]
s3:messages: finally make message_dispatch() static
metze
Stefan Metzmacher [Wed, 21 Jan 2009 06:37:07 +0000 (07:37 +0100)]
s3:printing: handle tevent_context events in the sys_select() call
metze
Stefan Metzmacher [Wed, 21 Jan 2009 06:35:07 +0000 (07:35 +0100)]
s3:winbindd: we don't need to call message_dispatch() anymore it's event triggered now
metze
Stefan Metzmacher [Wed, 21 Jan 2009 06:34:49 +0000 (07:34 +0100)]
s3:nmbd: we don't need to call message_dispatch() anymore it's event triggered now
metze
Stefan Metzmacher [Wed, 21 Jan 2009 06:33:19 +0000 (07:33 +0100)]
s3:smbd: we don't need to call message_dispatch() anymore it's event triggered now
metze
Stefan Metzmacher [Wed, 21 Jan 2009 06:31:33 +0000 (07:31 +0100)]
s3:msgtest: don't call message_dispatch() anymore, use tevent_loop_once() instead
metze
Stefan Metzmacher [Wed, 21 Jan 2009 06:30:13 +0000 (07:30 +0100)]
s3:smbcontrol: don't call message_dispatch() anymore, it's triggered by tevent_loop_once()
metze
Stefan Metzmacher [Mon, 12 Jan 2009 17:14:04 +0000 (18:14 +0100)]
s3:messaging: start with to use signal events instead of the raw signal interfaces
metze
Stefan Metzmacher [Fri, 9 Jan 2009 13:02:18 +0000 (14:02 +0100)]
s3:smbd: restructure kernel oplocks code
This converts the irix oplocks code to use a fd event
and removes the last special case for file descriptors
for the main sys_select().
metze
Stefan Metzmacher [Tue, 20 Jan 2009 03:14:20 +0000 (04:14 +0100)]
s3: always call run_events() before and after sys_select()
And always setup the fd events.
metze
Stefan Metzmacher [Tue, 20 Jan 2009 00:58:04 +0000 (01:58 +0100)]
s3:events: always run_events() before sys_select()
We might have pending signal events not only timed events.
metze
Volker Lendecke [Thu, 22 Jan 2009 11:13:29 +0000 (12:13 +0100)]
Actually complete
3662c2b...
Volker Lendecke [Thu, 22 Jan 2009 10:36:16 +0000 (11:36 +0100)]
cli_get_pipe_name_from_iface does not need the cli_state
I leave the TALLOC_CTX in, we might have to allocate it in the future
Jelmer Vernooij [Thu, 22 Jan 2009 10:37:27 +0000 (11:37 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Thu, 22 Jan 2009 10:35:28 +0000 (11:35 +0100)]
Move configure test files to the top-level and share them between s3 and
s4.
Michael Adam [Thu, 22 Jan 2009 07:14:06 +0000 (08:14 +0100)]
s3: run "make samba3-idl"
Michael
Michael Adam [Thu, 22 Jan 2009 07:10:11 +0000 (08:10 +0100)]
pidl/python: Add explicit casts, fixing implicit cast warnings.
Michael
Michael Adam [Thu, 22 Jan 2009 00:19:38 +0000 (01:19 +0100)]
run make idl_full, thus adding explicit casts to gen_ndr server code
Michael
Michael Adam [Thu, 22 Jan 2009 00:17:40 +0000 (01:17 +0100)]
pidl: reduce implicit cast warnings in gen_ndr server code
Michael
todd stecher [Mon, 19 Jan 2009 23:09:51 +0000 (15:09 -0800)]
Memory leaks and other fixes found by Coverity
Jelmer Vernooij [Wed, 21 Jan 2009 17:54:20 +0000 (18:54 +0100)]
Fix path to check_python.m4.
Jelmer Vernooij [Wed, 21 Jan 2009 17:50:16 +0000 (18:50 +0100)]
libsmbconf: Remove use of some Samba3-specific macros.
Jelmer Vernooij [Wed, 21 Jan 2009 17:50:02 +0000 (18:50 +0100)]
libsmbconf: Add build magic for Samba 4.
Jelmer Vernooij [Wed, 21 Jan 2009 17:40:06 +0000 (18:40 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Michael Adam [Wed, 21 Jan 2009 17:10:23 +0000 (18:10 +0100)]
libsmbconf: move the non-registry parts of libsmbconf to top level
Michael
Michael Adam [Wed, 21 Jan 2009 17:25:47 +0000 (18:25 +0100)]
s3:libsmbconf: include smbconf headers with lib/smbconf prefix
Michael
Michael Adam [Wed, 21 Jan 2009 16:16:37 +0000 (17:16 +0100)]
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in reg backend
Michael
Michael Adam [Wed, 21 Jan 2009 16:14:56 +0000 (17:14 +0100)]
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in txt backend
Michael
Michael Adam [Wed, 21 Jan 2009 16:12:50 +0000 (17:12 +0100)]
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf_init
Michael
Michael Adam [Wed, 21 Jan 2009 16:11:46 +0000 (17:11 +0100)]
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in testsuite
Michael
Michael Adam [Wed, 21 Jan 2009 16:11:02 +0000 (17:11 +0100)]
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf_util.c
Michael
Michael Adam [Wed, 21 Jan 2009 16:10:20 +0000 (17:10 +0100)]
s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf.c
Michael
Michael Adam [Wed, 21 Jan 2009 15:59:09 +0000 (16:59 +0100)]
s3:libsmbconf: remove the init headers from smbconf.h
give the smbconf_init() dispatcher and the backends
(smbconf_reg and smbconf_txt) a header of their own each.
This allows to use the basic infrastructure and
single backends individually.
Michael
Michael Adam [Wed, 21 Jan 2009 15:24:32 +0000 (16:24 +0100)]
s3:libsmbconf: remove unused function smbconf_is_writeable_bystring()
Michael
Jelmer Vernooij [Wed, 21 Jan 2009 17:38:40 +0000 (18:38 +0100)]
pidl/python: Add explicit casts, fixes warnings about casts when enabled.