Volker Lendecke [Sun, 8 Apr 2012 22:40:38 +0000 (00:40 +0200)]
tevent: Fix a typo
Volker Lendecke [Mon, 9 Apr 2012 07:17:29 +0000 (09:17 +0200)]
s3: Fix the pthreadpool build on OS/X
OS/X does not have clock_gettime, and without replace.h we do not
get the replacement macro
Volker Lendecke [Sun, 8 Apr 2012 19:49:59 +0000 (21:49 +0200)]
s3: Initialize aio_pending_size from aio_pthread
Volker Lendecke [Sun, 8 Apr 2012 19:47:38 +0000 (21:47 +0200)]
s3: Initialize aio_pending_size from aio_pthread
Volker Lendecke [Sun, 8 Apr 2012 18:11:53 +0000 (20:11 +0200)]
s3: Move the aio signal init to the vfs module
On platforms that don't have an RT signal space, signal initialization
fails. aio_fork and aio_pthread don't need the signal, so this would
block them from running as well.
Andrew Bartlett [Mon, 9 Apr 2012 04:52:03 +0000 (14:52 +1000)]
autobuild: Also test a distribution-style build with external libs
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 9 10:06:38 CEST 2012 on sn-devel-104
Jelmer Vernooij [Sun, 8 Apr 2012 01:56:24 +0000 (03:56 +0200)]
wafsamba: Return missing libs rather than last syslib.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Apr 8 05:31:15 CEST 2012 on sn-devel-104
Volker Lendecke [Sat, 7 Apr 2012 10:33:32 +0000 (12:33 +0200)]
s3: Compile fix for dbwrap_file.c
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Apr 7 14:10:35 CEST 2012 on sn-devel-104
Jeremy Allison [Fri, 6 Apr 2012 22:35:55 +0000 (15:35 -0700)]
Found whilst back-porting the fix for bug 8837 - smbd crashes when deleting directory and veto files are enabled.
The delete tokens are unique to each name hash representing a pathname,
if we don't correctly return here we'll add duplicate tokens for a
given pasname hash.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 7 02:13:58 CEST 2012 on sn-devel-104
Jeremy Allison [Fri, 6 Apr 2012 21:20:12 +0000 (14:20 -0700)]
Bug found by Herb. blkcnt_t st_ex_blksize is defined as a signed value. When it is
on a 32-bit system and defined as a long, then inside vfswrap_get_alloc_size()
we cast to a uint64_t. This sign-extends when converting to unsigned,
so if the high bit of st_ex_blksize is set we return insane values to clients.
Björn Baumbach [Wed, 4 Apr 2012 14:58:24 +0000 (16:58 +0200)]
docs-xml: fix default name resolve order (fix bug #7564)
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Apr 6 09:54:37 CEST 2012 on sn-devel-104
Björn Baumbach [Wed, 4 Apr 2012 14:41:35 +0000 (16:41 +0200)]
docs: remove whitespace in example samba.ldif (fix bug #8789)
Björn Baumbach [Tue, 17 Jan 2012 11:31:17 +0000 (12:31 +0100)]
docs: add reload-printers command to smbcontrol manual page
Björn Baumbach [Tue, 10 Jan 2012 15:59:38 +0000 (16:59 +0100)]
s3-utils: add do_reload_printers command to smbcontol
Add command to force smbd to reload printers by sending MSG_PRINTER_PCAP.
Andrew Bartlett [Thu, 5 Apr 2012 04:53:08 +0000 (14:53 +1000)]
build: Remove SMB_OFF_T, replace with off_t
Now that we always require a 64 bit off_t, we no longer need SMB_OFF_T.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Apr 6 01:47:43 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 3 Apr 2012 22:47:26 +0000 (08:47 +1000)]
s3-build: Remove unused configure checks for xattr functions
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 5 07:13:29 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 3 Apr 2012 22:46:25 +0000 (08:46 +1000)]
s3-vfs: Remove unused lremovexattr call from VFS modules, system.c and configure
If this is ever needed again, it would be more appropriate as an options argument
to removexattr.
Andrew Bartlett
Andrew Bartlett [Tue, 3 Apr 2012 22:35:01 +0000 (08:35 +1000)]
s3-build: Remove unused configure checks for xattr functions
Andrew Bartlett [Tue, 3 Apr 2012 22:34:25 +0000 (08:34 +1000)]
s3-vfs: Remove unused lsetxattr call from VFS modules, system.c and configure
If this is ever needed again, it would be more appropriate as an options argument
to listxattr.
Andrew Bartlett
Andrew Bartlett [Tue, 3 Apr 2012 22:26:22 +0000 (08:26 +1000)]
s3-vfs: Remove unused llistxattr call from VFS modules, system.c and configure
If this is ever needed again, it would be more appropriate as an options argument
to listxattr.
Andrew Bartlett
Andrew Bartlett [Mon, 2 Apr 2012 02:43:15 +0000 (12:43 +1000)]
s3-vfs: Remove unused lgetxattr call from VFS modules, system.c and configure
Andrew Bartlett [Thu, 5 Apr 2012 00:36:55 +0000 (10:36 +1000)]
build: Add configure summary checking to waf build
When we remove the autoconf build, this can be re-expressed in python, but
for now it is good to share this double-check.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 5 04:11:45 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 5 Apr 2012 00:26:29 +0000 (10:26 +1000)]
build: Fix bitrotted configure summary, we now also test HAVE_IFACE_GETIFADDRS
Andrew Bartlett [Thu, 5 Apr 2012 00:21:09 +0000 (10:21 +1000)]
build: Restore configure summary checking
This was accidentily lost in:
commit
b1ce226af8b61ad7e3c37860a59c6715012e738b
Author: James Peach <jpeach@samba.org>
Date: Fri Jun 15 21:58:49 2007 +0000
r23510: Tidy calls to smb_panic by removing trailing newlines. Print the
failed expression in SMB_ASSERT.
(This used to be commit
171dc060e2a576d724eed1ca65636bdafffd7713)
Andrew Bartlett [Wed, 4 Apr 2012 23:59:41 +0000 (09:59 +1000)]
build: Add more assertions that fcntl locking works 64-bit
Andrew Bartlett [Wed, 28 Mar 2012 02:53:37 +0000 (13:53 +1100)]
build: Remove unused GLIBC_HACK_FCNTL64
This is not set from anywhere, and refers to Red Hat 7.0, which is
really, really old now.
Andrew Bartlett
Andrew Bartlett [Wed, 28 Mar 2012 02:48:01 +0000 (13:48 +1100)]
build: Fix sys_open() removal by including system/filesys.h
Andrew Bartlett [Wed, 28 Mar 2012 02:32:54 +0000 (13:32 +1100)]
build: Remove SMB_F* locking defines
Andrew Bartlett [Wed, 28 Mar 2012 02:26:34 +0000 (13:26 +1100)]
build: Remove SMB_STRUCT_FLOCK define
Andrew Bartlett [Wed, 28 Mar 2012 02:22:03 +0000 (13:22 +1100)]
build: Remove SMB_STRUCT_DIR define
Andrew Bartlett [Wed, 28 Mar 2012 02:18:14 +0000 (13:18 +1100)]
build: Remove SMB_STRUCT_DIRENT define
Andrew Bartlett [Wed, 28 Mar 2012 02:09:39 +0000 (13:09 +1100)]
build: Remove sys_rewinddir wrapper
Andrew Bartlett [Wed, 28 Mar 2012 02:08:27 +0000 (13:08 +1100)]
build: Remove sys_closedir wrapper
Andrew Bartlett [Wed, 28 Mar 2012 02:05:21 +0000 (13:05 +1100)]
build: Remove sys_telldir wrapper
Andrew Bartlett [Wed, 28 Mar 2012 02:04:03 +0000 (13:04 +1100)]
build: Remove sys_seekdir wrapper
Andrew Bartlett [Wed, 28 Mar 2012 02:03:00 +0000 (13:03 +1100)]
build: Remove sys_readdir wrapper
Andrew Bartlett [Wed, 28 Mar 2012 02:01:19 +0000 (13:01 +1100)]
build: Remove sys_opendir wrapper
Andrew Bartlett [Wed, 28 Mar 2012 01:51:17 +0000 (12:51 +1100)]
build: Remove sys_fopen wrapper
Andrew Bartlett [Wed, 28 Mar 2012 01:48:00 +0000 (12:48 +1100)]
build: Remove sys_open wrapper
Andrew Bartlett [Wed, 28 Mar 2012 01:45:06 +0000 (12:45 +1100)]
build: Remove sys_creat wrapper
Andrew Bartlett [Wed, 28 Mar 2012 01:41:41 +0000 (12:41 +1100)]
build: Remove fallback call to sys_open as HAVE_CREAT is not actually checked for
Andrew Bartlett [Wed, 28 Mar 2012 01:38:31 +0000 (12:38 +1100)]
build: Remove sys_ftell wrapper
Andrew Bartlett [Wed, 28 Mar 2012 01:37:04 +0000 (12:37 +1100)]
build: Remove sys_lseek wrapper
Andrew Bartlett [Wed, 28 Mar 2012 01:35:09 +0000 (12:35 +1100)]
build: Remove sys_ftruncate wrapper
Andrew Bartlett [Tue, 27 Mar 2012 23:56:54 +0000 (10:56 +1100)]
build: combine off_t 64 bit and largefile test
Andrew Bartlett [Tue, 27 Mar 2012 23:40:02 +0000 (10:40 +1100)]
vfs: Remove -D_LARGEFILE64_SOURCE from vfs examples Makefile
Andrew Bartlett [Tue, 27 Mar 2012 23:21:22 +0000 (10:21 +1100)]
build: #ifdef LARGE_SMB_OFF_T as off_t is now always 64 bits
Andrew Bartlett [Tue, 27 Mar 2012 23:03:24 +0000 (10:03 +1100)]
Remove off64_t declarations
Andrew Bartlett [Tue, 27 Mar 2012 23:01:52 +0000 (10:01 +1100)]
build: Fix configure test that was declaring an off64_t
Andrew Bartlett [Tue, 27 Mar 2012 22:49:48 +0000 (09:49 +1100)]
build: do not use HAVE_EXPLICIT_LARGEFILE_SUPPORT and *64() fucntions any more
Andrew Bartlett [Tue, 27 Mar 2012 22:39:57 +0000 (09:39 +1100)]
build: Remove configure tests for *64 functions and types
We now use the standard types only.
Andrew Bartlett
Andrew Bartlett [Tue, 27 Mar 2012 22:47:53 +0000 (09:47 +1100)]
build: Require 64-bit files support and do not define HAVE_EXPLICIT_LARGEFILE_SUPPORT
Andrew Bartlett [Wed, 4 Apr 2012 22:25:13 +0000 (08:25 +1000)]
build: Add getconf LFS_CFLAGS support to waf build
Andrew Bartlett [Tue, 27 Mar 2012 22:34:12 +0000 (09:34 +1100)]
build: use only standard _FILE_OFFSET_BITS=64 macro for large files
(We also already use any other macro as set by getconf LFS_CFLAGS, and
the standard AC_SYS_LARGEFILE macro in libreplace).
This is instead of using the transitional *64 posix largefile API
Andrew Bartlett
Andrew Bartlett [Wed, 4 Apr 2012 22:25:32 +0000 (08:25 +1000)]
lib/replace: Add getconf LFS_CFLAGS support to autoconf build
Jeremy Allison [Wed, 4 Apr 2012 21:57:12 +0000 (14:57 -0700)]
Third part of fix for bug #8837 - smbd crashes when deleting directory and veto files are enabled.
Use correct check to see if veto files has been enabled. Even if not
set lp_veto_files() returns a valid string address (to a '\0' character).
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 5 01:36:04 CEST 2012 on sn-devel-104
Jeremy Allison [Wed, 4 Apr 2012 21:54:02 +0000 (14:54 -0700)]
Second part of bugfix for bug #8837 - smbd crashes when deleting directory and veto files are enabled.
Store the 'struct security_token' as well as the 'struct security_unix_token'
inside the locking db when setting a delete on close.
Jeremy Allison [Wed, 4 Apr 2012 21:53:10 +0000 (14:53 -0700)]
First part of fix for bug 8837 - smbd crashes when deleting directory and veto files are enabled.
Add some const to the sec_ctx code.
Andreas Schneider [Mon, 2 Apr 2012 12:23:27 +0000 (14:23 +0200)]
systemd: Add samba service file.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Apr 4 18:04:09 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 3 Apr 2012 17:57:03 +0000 (19:57 +0200)]
s4:librpc/rpc: also parse ncacn_packet pdus with LIBNDR_FLAG_OBJECT_PRESENT
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Apr 3 23:06:31 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 3 Apr 2012 17:55:42 +0000 (19:55 +0200)]
s4:librpc/rpc: don't mix up paylod ndr flags with the dcerpc layer
If the transfer syntax is NDR64, it's only for the payload not
for the dcerpc pdus.
metze
Andrew Bartlett [Mon, 12 Mar 2012 08:52:33 +0000 (19:52 +1100)]
build: Remove checks for krb5_decode_ap_req, free_AP_REQ and KRB5_TICKET_HAS_KEYINFO
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Apr 3 19:19:33 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 12 Mar 2012 08:26:16 +0000 (19:26 +1100)]
build: Remove unused check for HAVE_KRB5_TKT_ENC_PART2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:44:52 +0000 (18:44 +1100)]
s3-krb5 Remove unused get_kvno_from_ap_req()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:41:57 +0000 (18:41 +1100)]
s3-krb5 Remove unused get_enctype_from_ap_req
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:40:06 +0000 (18:40 +1100)]
s3-krb5: Remove unused smb_krb5_get_keyinfo_from_ap_req()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:38:35 +0000 (18:38 +1100)]
s3-krb5: Remove unused get_key_from_keytab
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:37:06 +0000 (18:37 +1100)]
s3-krb5: remove unused unwrap_pac()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:33:12 +0000 (18:33 +1100)]
s3-krb5: remove unused get_auth_data_from_tkt
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:31:42 +0000 (18:31 +1100)]
s3-krb5: Remove unused get_authtime_from_tkt
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:29:57 +0000 (18:29 +1100)]
s3-krb5: Remove unused krb5_rd_req_return_keyblock_from_keytab
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:29:40 +0000 (18:29 +1100)]
s3-krb5: Remove unused get_principal_from_tkt
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:24:25 +0000 (18:24 +1100)]
s3-libads: Remove ads_verify_ticket() as it is now unused
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 12 Mar 2012 07:21:10 +0000 (18:21 +1100)]
s3-libads: Rework kerberos_return_pac() to use GENSEC for the server-side
This removes the last user of ads_verify_ticket(), and means that we
only have one code path to verify an incoming krb5 (GSSAPI) ticket.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sun, 11 Mar 2012 01:30:22 +0000 (12:30 +1100)]
s3-libsmb: Remove unused spnego_parse_krb5_wrap()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sat, 10 Mar 2012 21:11:36 +0000 (08:11 +1100)]
build: Reduce deps of ntlm_auth
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sat, 10 Mar 2012 21:10:16 +0000 (08:10 +1100)]
s3-ntlm_auth: use manage_gensec_request for squid-2.5-ntlmssp
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sat, 10 Mar 2012 20:04:38 +0000 (07:04 +1100)]
s3-auth: Order GENSEC mechs by priority, krb5 before NTLMSSP
Otherwise, really simple clients (such as the current ntlm_auth gss-spnego client)
will not select krb5.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sat, 10 Mar 2012 20:04:38 +0000 (07:04 +1100)]
s3-ntlm_auth: add ntlm_auth_generate_session_info_pac()
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sat, 10 Mar 2012 19:45:39 +0000 (06:45 +1100)]
s3-ntlm_auth Use GENSEC for gss-spnego server
This imports the gensec handling code from the source4 ntlm_auth, which
will eventually be used for all the NTLMSSP and SPNEGO clients and servers
but which is only used for gss-spnego for now.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 3 Apr 2012 11:55:08 +0000 (13:55 +0200)]
s4:ldap_server: fix typo in DEBUG() message
metze
Jelmer Vernooij [Tue, 3 Apr 2012 14:12:54 +0000 (16:12 +0200)]
wafsamba: Avoid NameError when printing error about missing system deps.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Apr 3 17:46:42 CEST 2012 on sn-devel-104
Volker Lendecke [Tue, 3 Apr 2012 11:20:39 +0000 (13:20 +0200)]
s3: Enhance the dbwrap needed x attempts msg
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Tue Apr 3 15:17:11 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 3 Apr 2012 04:18:09 +0000 (14:18 +1000)]
lib/util: charset modules do not exist any more
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Apr 3 08:07:42 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 3 Apr 2012 03:31:15 +0000 (13:31 +1000)]
file_server: Move vfs objects initialisation into file_server.c smb.conf wrapper
Andrew Bartlett [Mon, 2 Apr 2012 08:39:09 +0000 (18:39 +1000)]
s3-vfs: initial work on posix:eadb module
This is a module that, like vfs_xattr_tdb, stores extended attributes
in a DB on disk. This uses the format needed to support the
posix:eadb smb.conf option.
Andrew Bartlett
Andrew Bartlett [Tue, 3 Apr 2012 03:35:39 +0000 (13:35 +1000)]
s4-ntvfs: Rename xattr_tdb.c to posix_eadb.c and make more generally useful
This is now a small library, to be called from ntvfs, python and
vfs_posix_eadb. The rename makes it clear that this has a different
DB format to that used by vfs_xattr_tdb, and matches the posix:eadb
smb.conf parameter used to configure it.
Andrew Bartlett
Andrew Bartlett [Tue, 3 Apr 2012 03:23:43 +0000 (13:23 +1000)]
s3-vfs: Use new smb_load_module for better diagnostics
Andrew Bartlett [Tue, 3 Apr 2012 03:23:18 +0000 (13:23 +1000)]
s3-smbd: Inline init_modules() into only caller
Andrew Bartlett [Tue, 3 Apr 2012 03:22:41 +0000 (13:22 +1000)]
lib/util: Add smb_load_module that returns DEBUG(0) errors on failure
These errors are very important when trying to work out why a module
does not load, and this rework allows them to be shown when loading
vfs modules.
Andrew Bartlett
Stefan Metzmacher [Mon, 26 Mar 2012 11:50:44 +0000 (13:50 +0200)]
s4:smb_server/smb2: add missing 'return;' statements in smb2srv_chain_reply()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Apr 2 23:02:53 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 26 Mar 2012 11:49:36 +0000 (13:49 +0200)]
s4:smb_server/smb2: after smbsrv_terminate_connection() we have to return
req is a talloc child of the connection...
metze
Stefan Metzmacher [Mon, 26 Mar 2012 11:48:51 +0000 (13:48 +0200)]
s4:smb_server/smb2: fix memory leak in smb2srv_chain_reply()
metze
Stefan Metzmacher [Mon, 26 Mar 2012 11:47:39 +0000 (13:47 +0200)]
s4:smb_server/smb2: use helper variable smb2srv_chain_reply()
metze
Stefan Metzmacher [Mon, 19 Mar 2012 22:52:25 +0000 (23:52 +0100)]
s4:smb_server/smb: remove a request from the list before adding the next one in a chain.
metze
Volker Lendecke [Mon, 2 Apr 2012 08:50:33 +0000 (10:50 +0200)]
s3: Notifies should never time out
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Apr 2 12:31:17 CEST 2012 on sn-devel-104
Amitay Isaacs [Mon, 2 Apr 2012 07:15:09 +0000 (17:15 +1000)]
s4-upgradedns: Fix the fqdn for forest dns zone
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Mon Apr 2 10:56:10 CEST 2012 on sn-devel-104
Richard Sharpe [Sun, 1 Apr 2012 20:14:49 +0000 (13:14 -0700)]
Fix some of the issues that Jelmer identified in my first patch. This might be
changed again, especially when I figure out how to return the file as an
object.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Mon Apr 2 01:43:44 CEST 2012 on sn-devel-104
Richard Sharpe [Sat, 31 Mar 2012 05:04:28 +0000 (22:04 -0700)]
Add an open and close method to samba.smb.SMB so we can open and close files.
Also, fix up some documentation.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Sun Apr 1 16:29:52 CEST 2012 on sn-devel-104
Volker Lendecke [Sat, 31 Mar 2012 11:37:20 +0000 (13:37 +0200)]
s3-aio-fork: Fix a segfault in vfs_aio_fork
aio_suspend does not signal the main process with a signal, it just waits. The
aio_fork module does not use the signal at all, it directly calls back into the
main smbd by calling smbd_aio_complete_aio_ex. This is an abstraction
violation, but the alternative would have been to use signals where they are
not needed. However, in wait_for_aio_completion this bites us: With aio_fork we
call handle_aio_completed twice on the same aio_ex struct: Once from the call
to handle_aio_completion within the aio_fork module and once from the code in
wait_for_aio_completion.
This patch fixes it in a pretty bad way by introducing flag variables and more
state. But the mid-term plan is to replace the posix aio calls from the vfs and
do pread_send/recv and pwrite_send/recv at the vfs layer, so this will
significantly change anyway.
Thanks to Kirill Malkin <kirill.malkin@starboardstorage.com> for reporting this
crash!
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Mar 31 15:25:55 CEST 2012 on sn-devel-104