mount.cifs: eliminate some unneeded flags in parsed_mount_info

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: parse unc into separate fields

The UNC is currently handled as a single string and mount.cifs will
just munge it whenever it needs to change the delimiter type or
uppercase it, etc. This is tricky to handle correctly and means that
we often need to keep track of what's already been changed. Instead
of doing this, just track the pieces of the UNC in separate fields
in the parsed_mount_info, and then use those pieces to build strings
as needed.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: add username and domain fields to parsed_mount_info

...and fill and use them accordingly.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: make mountpassword a field in parsed_info

...rather than a buffer pointed to by a global var

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: make parse_options return proper mount error codes

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: have parse_options fill parsed_mount_info

Allocate a zeroed out parsed_mount_info struct and have parse_options
put its info into that instead. realloc() is no longer used here and
instead we just have the option parser carefully check that the result
will fit in the buffer before copying it.

We also no longer use snprintf to stuff info directly into the buffer.
It may not be possible given the other checks, but snprintf can leave a
non-NULL terminated string. Use strlcat everywhere instead to ensure
that doesn't occur.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: declare new struct for holding parsed mount info

Currently mount.cifs puts mount info into a disparate series of
dynamically sized buffers. Declate a new struct that holds a set of
fixed-size buffers.  The option and UNC parsing routines can place their
results in this struct.

This should make it easier to implement privilege separation using
shared memory to pass data between processes.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs-utils: release 4.1

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: fix ver= option passed to the kernel

Rather than passing the VERSION string to the kernel in the ver=
option, track the OPTIONS_VERSION separately and pass that to the
kernel. If we ever need to have different behavior in kernel for
different mount.cifs versions, we can bump this number.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: don't use exit(3) in get_password_from_file

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: don't use exit(3) in mount_cifs_usage() and open_cred_file()

...to help ensure that exit processing is handled appropriately.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: don't use exit(3) in main()

Clean up error handling in main() so that cleanup tasks are completed
rather than assuming exit processing will handle it.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: fix error handling when duplicating options string

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: make check_mountpoint a noop for non-legacy builds

Now that we chdir() to the mountpoint, the checks in that function are
pointless. Just make it a noop for non-legacy setuid builds.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: remove uuid option

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: remove bogus rsize/wsize options

They don't actually do anything.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: simplify command-line option parsing

Let getopt_long do the work of parsing options, then check what's left.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: remove unneeded uname call

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: clean up parse_server

Get rid of a lot of unnecessary nesting.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: clean up preprocessor macros

...remove some unneeded junk.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Update the README

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs-utils: switch to using autoconf package version

Rather than using a hardcoded version string, use the VERSION macro
that autoconf provides. This will help make it clear what version
is actually being used in bug reports when someone runs
"mount.cifs -V" or "cifs.upcall --version".

Also, clean up AC_INIT and AM_INIT_AUTOMAKE macros.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

autotools: make cifs.upcall dependent on an enable option

Make it so that cifs.upcall is built by default, but autodisable it if
the needed headers aren't present.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mount.cifs: check for NULL addr pointer before handling scopeid

Signed-off-by: Jeff Layton <jlayton@redhat.com>

docs: these tools are no longer part of Samba

Remove references to samba(7).
There's no cifs-utils(7) man page, so don't refer to one.

Signed-off-by: Michael Wood <esiotrot@gmail.com>

docs: change source from Samba 3.6

These tools are no longer part of the Samba suite, so change the source
to cifs-utils 4.0.

Signed-off-by: Michael Wood <esiotrot@gmail.com>

autotools: check for keyutils.h

...and throw a (hopefully) helpful error message if it's not present.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: use non-legacy krb5.h location

<krb5.h> is deprecated in favor of <krb5/krb5.h>. Also, make autoconf
throw a more helpful error message if it's not present.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

autotools: remove autogenerated files from git repo

Signed-off-by: Jeff Layton <jlayton@redhat.com>

autoconf: make sure C files include config.h

Signed-off-by: Jeff Layton <jlayton@redhat.com>

autoconf: now it works with autoconf 2.59 (RHEL5)

suggest to install libtalloc-devel if talloc.h is missing

spnego.c: make sure to free talloc contexts

We're using talloc_init to get a context in these functions but they
aren't freeing them.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

automake: make sure to link cifs.upcall to keyutils

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Don't make "configure" part of the repo

autoconf: reshuffle header and function checking

Make sure we bail out if necessary functions and headers aren't present.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs-utils: make sure -Wall is always set for builds

Signed-off-by: Jeff Layton <jlayton@redhat.com>

autoconf: bail out if talloc.h or krb5.h aren't present

Signed-off-by: Jeff Layton <jlayton@redhat.com>

autoconf: fix "quoting" around macro args in configure.ac

Signed-off-by: Jeff Layton <jlayton@redhat.com>

autoconf: add some missing files for the release

...we don't want people to have to run autoreconf on their own, so
add them to the tree.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

silence some build warnings

mount.cifs.c: In function 'main':
mount.cifs.c:1201: warning: 'dev_name' may be used uninitialized in this function
mount.cifs.c:1217: warning: 'addr6' may be used uninitialized in this function

asn1.c: In function 'ber_read_OID_String':
asn1.c:591: warning: 'bytes_eaten' may be used uninitialized in this function

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: include util.h

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Clean up ChangeLog and fix versioning

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Add manpages to makefile

Signed-off-by: Jeff Layton <jlayton@redhat.com>

add autoconf check for talloc.h

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Add checks for specific krb5 functions

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Add check for krb5.h.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Add more docs...

The client guide and manpage XML sources

...eventually we should add a way to build the manpages from XML

Signed-off-by: Jeff Layton <jlayton@redhat.com>

add manpages for mount.cifs and cifs.upcall

...for now we just add them as regular troff manpages.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: add proper licenses to files

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: remove strncasecmp redefinition

...no need for that now.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

util.c: move strlcat and strlcpy into a separate "util.c" object

Signed-off-by: Jeff Layton <jlayton@redhat.com>

replace.h: pare down some unneeded replacements

A lot of this stuff is for other platforms, which we don't need to
really worry about much with cifs-utils.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

spnego.c: add new spnego.c file with SPNEGO/GSSAPI routines we need

Signed-off-by: Jeff Layton <jlayton@redhat.com>

asn1.c: remove a couple of unneeded functions

These depends on some utility functions that we don't have and
we aren't planning to use them anyway. Just remove them.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

add asn.1 files from samba tree

Signed-off-by: Jeff Layton <jlayton@redhat.com>

spnego.h: add some needed OID's

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: include arpa/inet.h

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: include netdb.h

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: replace SMB_XMALLOC_ARRAY with calloc

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: include time.h

Signed-off-by: Jeff Layton <jlayton@redhat.com>

replace.h: add SAFE_FREE

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: add a spnego.h file

...to hold SPNEGO definitions.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: fix up the includes

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: replace SMB_STRNDUP with strndup

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Initial autotools addition

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: borrow some of the samba headers

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: replace cli_krb5_get_ticket

We need to replace the function that we use to fetch krb5 creds since
that's currently provided by a libsmbclient object.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: don't use smb_krb5_unparse_name

...we don't really need a talloc-ified version here. Just use the normal
one. Also don't use strnequal. Use strncasecmp instead.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

cifs.upcall: don't use smb_krb5_principal_get_realm

...we need our own version.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Initial import of files from samba master branch

(commit 6e510b49c03be9caba4f587f3f6cec547841b0d7)