Günther Deschner [Tue, 9 Feb 2010 14:24:34 +0000 (15:24 +0100)]
testprogs: print monitor info levels in EnumMonitors() spoolss tests.
Guenther
Günther Deschner [Tue, 9 Feb 2010 14:00:54 +0000 (15:00 +0100)]
testprogs: print port info levels in EnumPorts() spoolss tests.
Guenther
Günther Deschner [Tue, 9 Feb 2010 13:49:04 +0000 (14:49 +0100)]
testprogs: print form info levels in EnumForms(),GetForm() spoolss tests.
Guenther
Stefan Metzmacher [Tue, 9 Feb 2010 11:58:29 +0000 (12:58 +0100)]
s3:selftest: make selftest requires bash for now
So force bash until we removed the dependency to bash.
metze
Stefan Metzmacher [Tue, 9 Feb 2010 11:57:01 +0000 (12:57 +0100)]
s3:passdb: only use gid_to_sid() result if the result is a group of our local sam
Otherwise retry with pdb_gid_to_sid().
metze
Björn Jacke [Tue, 9 Feb 2010 08:07:54 +0000 (09:07 +0100)]
s3: fix some wrong newlines in de translation strings
Björn Jacke [Tue, 9 Feb 2010 08:09:57 +0000 (09:09 +0100)]
vfs_catia: fix return type warnings
Andrew Tridgell [Tue, 9 Feb 2010 02:18:31 +0000 (13:18 +1100)]
s4-torture: allow host-only in unc lists in smbtorture
Allow UNC lists like this:
192.168.2.1
192.168.2.2
192.168.2.3
the share name will be taken from the command line
Jeremy Allison [Mon, 8 Feb 2010 22:35:02 +0000 (14:35 -0800)]
Make "nmbd bind explicit broadcast" on by default.
Fix a comment typo.
Jeremy.
Jeremy Allison [Mon, 8 Feb 2010 19:04:38 +0000 (11:04 -0800)]
Fix bug #6876 for acl_tdb module.
As pointed out by bj@sernet.de, the rmdir module initializer was
duplicated. Fix this properly.
Jeremy.
Stefan Metzmacher [Mon, 8 Feb 2010 17:38:03 +0000 (18:38 +0100)]
s3:libsmb: fix NetServerEnum3 rap calls.
metze
Stefan Metzmacher [Fri, 5 Feb 2010 17:08:46 +0000 (18:08 +0100)]
s3:smbd: implement api_RNetServerEnum3
This is needed to support large browse lists.
metze
Stefan Metzmacher [Mon, 8 Feb 2010 17:45:18 +0000 (18:45 +0100)]
s3:smbd: add/improve some DEBUG messages in api_RNetServerEnum2()
metze
Stefan Metzmacher [Fri, 5 Feb 2010 15:55:15 +0000 (16:55 +0100)]
s3:smbd: rename api_RNetServerEnum => api_RNetServerEnum2
metze
Stefan Metzmacher [Mon, 8 Feb 2010 11:59:13 +0000 (12:59 +0100)]
s3:docs-xml: document "nmbd bind explicit broadcast"
metze
Stefan Metzmacher [Mon, 8 Feb 2010 11:51:29 +0000 (12:51 +0100)]
s3:nmbd: change "nmbd:bind explicit broadcast" into "nmbd bind explicit broadcast"
metze
Stefan Metzmacher [Thu, 28 Jan 2010 10:04:05 +0000 (11:04 +0100)]
s3:nmbd: also listen explicit on the subnet broadcast addresses
And send replies always via the unicast address of the subnet.
This behavior is off by default (as before)
and can be enabled with "nmbd:bind explicit broadcast = yes".
metze
Simo Sorce [Mon, 8 Feb 2010 15:25:13 +0000 (10:25 -0500)]
release-scripts: parametrize scripts
This should make it easier to keep all release scripts alined as it will reduce
the difference between them to ideally a few variables
Also moves the tdb script in the scripts directory.
Simo Sorce [Mon, 8 Feb 2010 15:05:24 +0000 (10:05 -0500)]
talloc: Fix abi checks in release script
We must perform abi checks against the version we are going to release.
Not against the current tree we are in.
Simo Sorce [Mon, 8 Feb 2010 15:02:49 +0000 (10:02 -0500)]
talloc: Fix abi checks and ifdefs
teach the abi check scripts to skip the DOXYGEN sections
fix the header to use #ifdef DOXYGEN and not #if DOXYGEN
Günther Deschner [Wed, 9 Dec 2009 10:21:08 +0000 (11:21 +0100)]
s4-smbtorture: skip over ValidatePassword if DCERPC error is returned.
Guenther
Matthias Dieter Wallnöfer [Mon, 8 Feb 2010 11:08:36 +0000 (12:08 +0100)]
s4:subtree_delete - "NULL" as format string isn't allowed on FreeBSD
I changed the format string into "(objectClass=*)" which should be an
equivalent expression for choosing all available objects.
Consider bug 7115 for the issue.
Günther Deschner [Mon, 8 Feb 2010 10:53:59 +0000 (11:53 +0100)]
s3-net: fix net ads dns usage calls.
Bjoern, please check.
Guenther
Stefan Metzmacher [Fri, 5 Feb 2010 15:20:21 +0000 (16:20 +0100)]
s3:pdb_ldap: don't search for the users primary group, if we already know it
metze
Stefan Metzmacher [Wed, 3 Feb 2010 10:32:41 +0000 (11:32 +0100)]
s3:pdb_ldap: optimize ldapsam_alias_memberships() and cache ldap searches.
ldapsam_alias_memberships() does the same LDAP search twice, triggered
via add_aliases() from create_local_nt_token().
This happens when no domain aliases are used.
metze
Stefan Metzmacher [Thu, 4 Feb 2010 16:19:57 +0000 (17:19 +0100)]
s3:pdb_ldap: try to build the full unix_pw structure with ldapsam:trusted support
And also store the gid_to_sid mappings in the idmap_cache.
metze
Stefan Metzmacher [Thu, 4 Feb 2010 16:16:59 +0000 (17:16 +0100)]
s3:passdb: speed up pdb_get_group_sid()
Use the cached version gid_to_sid() instead
of pdb_gid_to_sid().
And also avoid the expensive lookup_sid() call
for wellkown domain groups.
metze
Volker Lendecke [Sun, 31 Jan 2010 14:18:51 +0000 (15:18 +0100)]
s3: Make pdb_copy_sam_account also copy the group sid
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Sat, 30 Jan 2010 21:28:19 +0000 (22:28 +0100)]
s3: shortcut gid_to_sid when "ldapsam:trusted = yes"
The normal gid_to_sid behaviour is to call sys_getgrgid()
to get the name for the given gid and then call the
getsamgrnam passdb method for the resulting name.
In the ldapsam:trusted case we can reduce the gid_to_sid
operation to one simple search for the gidNumber attribute
and only get the sambaSID attribute from the correspoinding
LDAP object. This reduces the number of ldap roundtrips
for this operation.
metze
Stefan Metzmacher [Mon, 8 Feb 2010 08:57:31 +0000 (09:57 +0100)]
s4:heimdal: regerenate files
Andrew using cp like in commit
ca12e7bc8ff4a91f2044c0a60550fec902e97a78
is wrong as that removes #include "config.h" and breaks the build on AIX.
metze
Stefan Metzmacher [Mon, 8 Feb 2010 08:29:22 +0000 (09:29 +0100)]
s4:heimdal_build: allow flex-2.5.35:bison-2.4.1 to regenerate files
metze
Stefan Metzmacher [Mon, 8 Feb 2010 07:55:44 +0000 (08:55 +0100)]
libreplace: add check for NSS_WRAPPER_DISABLE similar to SOCKET_WRAPPER_DISABLE
metze
Volker Lendecke [Sun, 7 Feb 2010 17:09:11 +0000 (18:09 +0100)]
libreplace: Attempt to fix bug 5910, detect a broken getaddrinfo
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Bo Yang [Tue, 9 Feb 2010 08:35:40 +0000 (16:35 +0800)]
s3: Don't invalidate cache for uninitialized domains.
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Tue, 9 Feb 2010 09:02:20 +0000 (17:02 +0800)]
s3: signals are processed twice in child.
Signed-off-by: Bo Yang <boyang@samba.org>
Björn Jacke [Sun, 7 Feb 2010 23:08:38 +0000 (00:08 +0100)]
s3: quiet the unresolved symbol warnings of the Compaq compiler when linking our vfs modules
Andrew Tridgell [Sun, 7 Feb 2010 10:12:14 +0000 (21:12 +1100)]
s4-torture: more useful error message in SMB2-DIR
Andrew Tridgell [Sun, 7 Feb 2010 10:08:56 +0000 (21:08 +1100)]
nbt: don't reference the event_ctx in nbtsock
This causes talloc_free with references errors
Andrew Tridgell [Sun, 7 Feb 2010 23:58:48 +0000 (10:58 +1100)]
talloc: fixed doc typo
Andreas Schneider [Sun, 7 Feb 2010 23:40:07 +0000 (00:40 +0100)]
Move the talloc details to the mainpage.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andreas Schneider [Sun, 17 Jan 2010 10:25:34 +0000 (11:25 +0100)]
talloc: Added doxygen config file.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andreas Schneider [Sun, 17 Jan 2010 10:25:02 +0000 (11:25 +0100)]
talloc: Documented talloc with doxygen.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Björn Jacke [Sun, 7 Feb 2010 19:10:57 +0000 (20:10 +0100)]
s3: fix build issue on Tru64
Thanks, Volker for the hint - acl_type is a macro on Tru64. Renamed it
to acltype. This fixes #7103.
Volker Lendecke [Sun, 7 Feb 2010 19:55:13 +0000 (20:55 +0100)]
s3: Fix some DEBUG statements
Volker Lendecke [Sun, 7 Feb 2010 11:08:39 +0000 (12:08 +0100)]
s3: Make cli_get_fs_volume_info() use cli_trans()
Volker Lendecke [Sun, 7 Feb 2010 11:01:36 +0000 (12:01 +0100)]
s3: Remove some unused code
Volker Lendecke [Sun, 7 Feb 2010 10:14:22 +0000 (11:14 +0100)]
s3: Fix some comments
Volker Lendecke [Sun, 7 Feb 2010 10:05:07 +0000 (11:05 +0100)]
s3: Fix some nonempty blank lines
Volker Lendecke [Sat, 6 Feb 2010 15:56:29 +0000 (16:56 +0100)]
libwbclient: wbc_create_logon_info is always called with mem_ctx==NULL
Volker Lendecke [Sat, 6 Feb 2010 15:54:05 +0000 (16:54 +0100)]
libwbclient: wbc_create_password_policy_info is always called with mem_ctx==NULL
Volker Lendecke [Sat, 6 Feb 2010 15:53:07 +0000 (16:53 +0100)]
libwbclient: wbc_create_error_info is always called with mem_ctx==NULL
Andrew Tridgell [Sun, 7 Feb 2010 07:11:42 +0000 (18:11 +1100)]
s4-registry: fixed byte order assumptions
the registry tests were broken on big-endian systems
Simo Sorce [Sat, 6 Feb 2010 15:48:39 +0000 (10:48 -0500)]
tdb: raise version to 1.2.1
after recent fixes we need to raise the version to 1.2.1 so that
we can require also the right patched version.
Volker Lendecke [Sat, 6 Feb 2010 11:56:19 +0000 (12:56 +0100)]
pam_winbind: Remove a nested if-statement. Bo, please check!
Volker Lendecke [Sat, 6 Feb 2010 11:55:00 +0000 (12:55 +0100)]
pam_winbind: Use strchr instead of strstr for a single character
Jeremy Allison [Sat, 6 Feb 2010 06:51:11 +0000 (22:51 -0800)]
Fix trailing whitespace errors I added (sorry).
Jeremy.
Bo Yang [Sun, 7 Feb 2010 06:45:42 +0000 (14:45 +0800)]
s3: Fix malformed require_membership_of_sid.
Signed-off-by: Bo Yang <boyang@samba.org>
Andrew Tridgell [Sat, 6 Feb 2010 03:14:45 +0000 (19:14 -0800)]
s3-events: make the old timed events compatible with tevent
tevent ensures that a timed event is only called once. The old events
code relied on the called handler removing the event itself. If the
handler removed the event after calling a function which invoked the
event loop then the timed event could loop forever.
This change makes the two timed event systems more compatible, by
allowing the handler to free the te if it wants to, but ensuring it is
off the linked list of events before the handler is called, and
ensuring it is freed even if the handler doesn't free it.
Andrew Tridgell [Sat, 6 Feb 2010 05:08:56 +0000 (21:08 -0800)]
s3-smbd: add a rate limited cleanup of brl, connections and locking db
On unclean shutdown we can end up with stale entries in the brlock,
connections and locking db. Previously we would do the cleanup on
every unclean exit, but that can cause smbd to be completely
unavailable for several minutes when a large number of child smbd
processes exit.
This adds a rate limited cleanup of the databases, with the default
that cleanup happens at most every 20s
Andrew Tridgell [Sat, 6 Feb 2010 05:02:24 +0000 (21:02 -0800)]
s3-brlock: we don't need these MSG_SMB_UNLOCK calls now
These have been replaced with the min timeout in blocking.c
Andrew Tridgell [Sat, 6 Feb 2010 04:59:43 +0000 (20:59 -0800)]
s3-brlock: add a minimim retry time for pending blocking locks
When we are waiting on a pending byte range lock, another smbd might
exit uncleanly, and therefore not notify us of the removal of the
lock, and thus not trigger the lock to be retried.
We coped with this up to now by adding a message_send_all() in the
SIGCHLD and cluster reconfigure handlers to send a MSG_SMB_UNLOCK to
all smbd processes. That would generate O(N^2) work when a large
number of clients disconnected at once (such as on a network outage),
which could leave the whole system unusable for a very long time (many
minutes, or even longer).
By adding a minimum re-check time for pending byte range locks we
avoid this problem by ensuring that pending locks are retried at a
more regular interval.
Andrew Tridgell [Sat, 6 Feb 2010 03:26:22 +0000 (14:26 +1100)]
s4-ldb: fixed api.py selftest
subunitrun seemed to be calling a test from its own source, instead of
the samba test. Fix this by calling the test directly.
Jeremy Allison [Sat, 6 Feb 2010 00:20:34 +0000 (16:20 -0800)]
Remove now unused variable.
Jeremy.
Jeremy Allison [Fri, 5 Feb 2010 23:20:18 +0000 (15:20 -0800)]
Fix bug 7104 - "wide links" and "unix extensions" are incompatible.
Change parameter "wide links" to default to "no".
Ensure "wide links = no" if "unix extensions = yes" on a share.
Fix man pages to refect this.
Remove "within share" checks for a UNIX symlink set - even if
widelinks = no. The server will not follow that link anyway.
Correct DEBUG message in check_reduced_name() to add missing "\n"
so it's really clear when a path is being denied as it's outside
the enclosing share path.
Jeremy.
Volker Lendecke [Fri, 5 Feb 2010 14:55:14 +0000 (15:55 +0100)]
s3: Make use of ZERO_STRUCTP
Volker Lendecke [Fri, 5 Feb 2010 14:53:19 +0000 (15:53 +0100)]
s3: Remove a pointless if-statement
Volker Lendecke [Fri, 5 Feb 2010 14:50:11 +0000 (15:50 +0100)]
s3: Make guest_user_info() static
Volker Lendecke [Fri, 5 Feb 2010 14:40:12 +0000 (15:40 +0100)]
s3: Hide some uses of pdb_get_init_flags (which I would love to remove...)
Volker Lendecke [Fri, 5 Feb 2010 14:43:26 +0000 (15:43 +0100)]
s3: Fix some nonempty blank lines
Matthias Dieter Wallnöfer [Sat, 30 Jan 2010 13:25:51 +0000 (14:25 +0100)]
s4:UID wrapper - Make it work on older distributions
On my older CentOS 4 installation I had the problem with the missing
substitution prototypes ("uwrap_*"). So I added them to "uid_wrapper.h".
Also, I made the head of the "uid_wrapper.c" file more like the one of
"nss_wrapper.c" - it shouldn't change that much, I did it only to be consistent.
This patch should fix the build on older distributions while keep it running on
newer ones.
Matthias Dieter Wallnöfer [Sat, 30 Jan 2010 13:25:51 +0000 (14:25 +0100)]
s4:UID wrapper - Fix includes
The includes of the UID wrapper headers werent't really efficient according
to metze's post on the technical mailing list (http://lists.samba.org/archive/samba-technical/2010-February/069165.html).
To achieve this move the "uid_wrapper.h" includes into "lib/util/unix_privs.c",
"lib/util/util.c", "ntvfs/posix/pvfs_acl.c" and "ntvfs/unixuid/vfs_unixuid.c".
Matthias Dieter Wallnöfer [Sat, 30 Jan 2010 13:18:57 +0000 (14:18 +0100)]
NSS wrapper - add dependency to "nsstest"
The code part makes use of the "NSS wrapper" if it is enabled. Surprisingly
the build process doesn't break with the missing dependency on more recent
systems. But with an older CentOS 4 installation it has been broken.
This patch should fix the problem on older distributions while keep the build
running on newer ones.
Matthias Dieter Wallnöfer [Fri, 5 Feb 2010 15:58:32 +0000 (16:58 +0100)]
s4:Heimdal build - never require the NSS wrapper for Heimdal Kerberos
Disable the use of it in the heimdal code.
Notice: This doesn't need to be ported upstream since it only affects the
build in conjunction with s4.
Lars Müller [Fri, 5 Feb 2010 16:38:04 +0000 (17:38 +0100)]
s3: normalize "Changing password for" msg IDs and STRs
An additional space at the end of the "Changing password for" msgid lead
to untranslated pam_winnind messages.
Kamen Mazdrashki [Tue, 2 Feb 2010 12:28:57 +0000 (14:28 +0200)]
s4/drs: propagate DRS_ extension flags in code base
Kamen Mazdrashki [Tue, 2 Feb 2010 12:27:46 +0000 (14:27 +0200)]
s4/idl: Regenerate IDL for DRSUAPI interface
Kamen Mazdrashki [Tue, 2 Feb 2010 11:48:01 +0000 (13:48 +0200)]
s4/idl: add DRSUAPI_SUPPORTED_EXTENSION_RECYCLE_BIN ext. flag for DRSUAPI
This flag corresponds to DRS_EXT_RECYCLE_BIN extended
flag in [MS-DRSR] documentation.
Reference:
[MS-DRSR] - 5.37
Description:
If present, signifies that the DC has enabled
the Recycle Binoptional feature.
Kamen Mazdrashki [Tue, 2 Feb 2010 11:46:20 +0000 (13:46 +0200)]
s4/idl: add DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V10 flag for DRSUAPI
This flag corresponds to DRS_EXT_GETCHGREQ_V10 flag
in [MS-DRSR] documentation.
Reference:
[MS-DRSR] - 5.37
Description:
If present, signifies that the DC supports DRS_MSG_GETCHGREQ_V10.
Kamen Mazdrashki [Tue, 2 Feb 2010 11:44:49 +0000 (13:44 +0200)]
s4/idl: add DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V5 flag for DRSUAPI
This flag corresponds to DRS_EXT_GETCHGREQ_V5 flag
in [MS-DRSR] documentation.
Reference:
[MS-DRSR] - 5.37
Description:
If present, signifies that the DC supports DRS_MSG_GETCHGREQ_V5.
Kamen Mazdrashki [Tue, 2 Feb 2010 11:34:55 +0000 (13:34 +0200)]
s4/idl: add DRSUAPI_SUPPORTED_EXTENSION_ADDENTRY flag for DRSUAPI
This flag corresponds to DRS_EXT_ADDENTRY flag
in [MS-DRSR] documentation.
Reference:
[MS-DRSR] - 5.37
Description:
If present, signifies that the DC supports IDL_DRSAddEntry.
Jeremy Allison [Fri, 5 Feb 2010 00:23:32 +0000 (16:23 -0800)]
Fix bug 7075 - bug in vfs_scannedonly rmdir implementation.
Check for NULL on opendir, correctly call next rmdir.
Jeremy.
Stefan Metzmacher [Thu, 4 Feb 2010 14:19:50 +0000 (15:19 +0100)]
s3:passdb: fix a type Domain Users has RID -513
metze
Stefan Metzmacher [Thu, 4 Feb 2010 13:03:20 +0000 (14:03 +0100)]
s3:libsmb: don't reuse the callers stype variable in cli_NetServerEnum()
When we need to do more than one network operation to get the
browse list we need to use the same 'stype' value each time.
metze
Andrew Tridgell [Thu, 4 Feb 2010 09:19:05 +0000 (20:19 +1100)]
s4-torture: handle NT_STATUS_CONNECTION_RESET
a CONNECTION_RESET is now the normal "client disconnect" status code
Matthias Dieter Wallnöfer [Thu, 4 Feb 2010 08:22:39 +0000 (09:22 +0100)]
s4:mark the SYSTEM control always as non-critical
It is needed to not break the various LDAP backends. For reference look at
bug #7040.
Björn Jacke [Thu, 4 Feb 2010 10:03:55 +0000 (11:03 +0100)]
s3:nsswitch: also use pthread CFLAGS for the nsswitch modules that might require it
Björn Jacke [Thu, 4 Feb 2010 09:35:45 +0000 (10:35 +0100)]
s3: fix build on Tru64 after it broke with deactivating pthread pool support
Björn Jacke [Wed, 3 Feb 2010 22:28:38 +0000 (23:28 +0100)]
s3:vfs_scannedonly: fix build on HP-UX
Jelmer Vernooij [Wed, 3 Feb 2010 22:55:58 +0000 (23:55 +0100)]
net: Fix python 2.4 compatibility.
Volker Lendecke [Wed, 3 Feb 2010 06:37:29 +0000 (07:37 +0100)]
s3: Simplify the code a bit: Catch (len==0) early
Christian Ambach [Wed, 3 Feb 2010 13:20:16 +0000 (14:20 +0100)]
update samba schema for IBM Directory Server
this increases the sambapasswordhistory field length to 64 and
fixes a warning about a wrong booleanmatch setting
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Jeremy Allison [Wed, 3 Feb 2010 00:43:41 +0000 (16:43 -0800)]
Fix bug 7081 - vfs_expand_msdfs doesn't work correctly (with fix identified)
Fix inspired by idea from Eric Horst <erich@cac.washington.edu>.
Jeremy.
Jeremy Allison [Wed, 3 Feb 2010 00:32:51 +0000 (16:32 -0800)]
Fix bug 7063 - Samba 3.4.5 on ubuntu 8.04 64 bit - Core dumps.
Reported and found by Martin Hochreiter <linuxbox@wavenet.at>.
Ensure we copy the right amount of registry data into the outgoing
buffer.
Jeremy.
Björn Jacke [Tue, 2 Feb 2010 17:27:49 +0000 (18:27 +0100)]
s3:configure: check complete set of EA functions only when we found at least one
this saves us some time in configure
Matt Kraai [Tue, 5 Jan 2010 17:42:54 +0000 (09:42 -0800)]
Change uint_t to unsigned int in source4
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matt Kraai [Tue, 5 Jan 2010 17:42:23 +0000 (09:42 -0800)]
Change uint_t to unsigned int in source3
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matt Kraai [Tue, 5 Jan 2010 17:41:53 +0000 (09:41 -0800)]
Change uint_t to unsigned int in pidl
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matt Kraai [Tue, 5 Jan 2010 17:41:24 +0000 (09:41 -0800)]
Change uint_t to unsigned int in libcli
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matt Kraai [Tue, 5 Jan 2010 17:40:54 +0000 (09:40 -0800)]
Change uint_t to unsigned int in lib/util
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matt Kraai [Tue, 5 Jan 2010 17:40:26 +0000 (09:40 -0800)]
Change uint_t to unsigned int in lib/talloc
Signed-off-by: Stefan Metzmacher <metze@samba.org>