Andrew Tridgell [Thu, 24 Sep 2009 23:53:06 +0000 (16:53 -0700)]
s4-acl: fixed SD creation
Thanks for Nadya and Metze for this. The SDs were being created with
invalid fields (noticed by w2k8-r2 client when joining our domain)
Andrew Tridgell [Thu, 24 Sep 2009 23:51:15 +0000 (16:51 -0700)]
libds: fixed spelling error
Andrew Tridgell [Thu, 24 Sep 2009 23:50:59 +0000 (16:50 -0700)]
s4-drs: fixed sorting of replPropertyMetaData
This also ensures we add the SHOW_DELETED control on searches for old
replPropertyMetaData attributes
Jelmer Vernooij [Sun, 27 Sep 2009 15:37:53 +0000 (17:37 +0200)]
parmlist: Add more tests.
Jelmer Vernooij [Sun, 27 Sep 2009 14:49:26 +0000 (16:49 +0200)]
rpc_server: Fix warnings.
Jelmer Vernooij [Sun, 27 Sep 2009 14:43:01 +0000 (16:43 +0200)]
librpc: Fix path to ndr_standard pc file.
Jelmer Vernooij [Sun, 27 Sep 2009 14:34:59 +0000 (16:34 +0200)]
selftest: Prefer system tap2subunit if available.
Jelmer Vernooij [Sun, 27 Sep 2009 12:39:58 +0000 (14:39 +0200)]
parmlist: Add basic tests for test_get_int().
Jelmer Vernooij [Sun, 27 Sep 2009 12:13:38 +0000 (14:13 +0200)]
util/parmlist: Add some more comments.
Jelmer Vernooij [Sat, 26 Sep 2009 21:59:35 +0000 (23:59 +0200)]
libutil: Add separate utility code for dealing with settings as a
collection of key/value pairs.
Jelmer Vernooij [Sat, 26 Sep 2009 18:55:18 +0000 (20:55 +0200)]
gensec: Avoid exposing lp_ctx on the API level.
Jelmer Vernooij [Sat, 26 Sep 2009 17:41:59 +0000 (19:41 +0200)]
pygensec: Add initial work on a gensec Python module.
Wilco Baan Hofman [Sat, 26 Sep 2009 15:05:34 +0000 (17:05 +0200)]
regshell: Add support for 'cd ..' and cd relative to the root.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Jelmer Vernooij [Sat, 26 Sep 2009 13:41:22 +0000 (15:41 +0200)]
registry: Fix warning freeing talloc pointer with multiple parents.
Jelmer Vernooij [Sat, 26 Sep 2009 11:53:27 +0000 (13:53 +0200)]
ldb: Check for talloc using pkg-config before checking manually, so we
find version errors.
Jelmer Vernooij [Sat, 26 Sep 2009 10:51:49 +0000 (12:51 +0200)]
s4/make: Remove object files in ../libds as part of "make clean".
Jeremy Allison [Sat, 26 Sep 2009 05:19:27 +0000 (22:19 -0700)]
Fix the opaque sample module for the new VFS interface.
Jeremy.
Jeremy Allison [Sat, 26 Sep 2009 05:02:18 +0000 (22:02 -0700)]
Update the advice for the new VFS system.
Jeremy.
Jeremy Allison [Sat, 26 Sep 2009 04:43:13 +0000 (21:43 -0700)]
Remove unused static fn.
Jeremy.
Jeremy Allison [Sat, 26 Sep 2009 04:39:52 +0000 (21:39 -0700)]
Rewrite vfs_transparent example for the new VFS changes.
Jeremy.
Jeremy Allison [Sat, 26 Sep 2009 03:51:50 +0000 (20:51 -0700)]
Fix vfs module sample for new interface.
Jeremy.
Jelmer Vernooij [Sat, 26 Sep 2009 00:38:09 +0000 (02:38 +0200)]
samba.tests.provision: Remove broken become_dc test.
Jelmer Vernooij [Fri, 25 Sep 2009 23:34:22 +0000 (01:34 +0200)]
pidl(s4.python): Fix arguments to PyCObject_FromVoidPtr for string_array's.
Caught by Guenther.
Matthieu Patou [Tue, 22 Sep 2009 20:51:25 +0000 (00:51 +0400)]
pythonbindings: allow add() to have an array of controls as second parameter
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Simo Sorce [Fri, 25 Sep 2009 14:59:04 +0000 (10:59 -0400)]
Fixing timeval calculation
The code was always doubling microseconds when attempting to round up.
Günther Deschner [Fri, 25 Sep 2009 10:17:17 +0000 (12:17 +0200)]
lib/util: fix build warning.
Guenther
Matthias Dieter Wallnöfer [Wed, 23 Sep 2009 17:40:14 +0000 (19:40 +0200)]
s4:LDIFs - enhance the section comments
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 08:43:42 +0000 (10:43 +0200)]
s4:auth/gensec/schannel - fix a const warning
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 08:17:17 +0000 (10:17 +0200)]
s3:smbd/password - move list pointers into blocks
Günther Deschner [Thu, 24 Sep 2009 21:39:18 +0000 (23:39 +0200)]
s3-libndr: fix build warning.
Guenther
Stefan Metzmacher [Thu, 24 Sep 2009 19:35:38 +0000 (21:35 +0200)]
s3:winbindd_cm: don't invalidate the whole connection when just samr gave ACCCESS_DENIED
metze
Stefan Metzmacher [Thu, 17 Sep 2009 23:54:22 +0000 (01:54 +0200)]
s4:schannel: fix some compiler warnings
If we only do signing we can pass down a const data buffer.
metze
Stefan Metzmacher [Sun, 20 Sep 2009 21:29:11 +0000 (23:29 +0200)]
s3:rpc_client: don't randomly fragment rpc pdu's in developer mode
This is really confusing and also breaks against windows,
as it doesn't accept fragmented bind requests.
metze
Nadezhda Ivanova [Fri, 25 Sep 2009 01:57:27 +0000 (18:57 -0700)]
Merge branch 'master' of git://git.samba.org/samba
Nadezhda Ivanova [Fri, 25 Sep 2009 01:29:57 +0000 (18:29 -0700)]
Fixed a dereferenced null pointer.
Jeff Layton [Fri, 25 Sep 2009 00:55:43 +0000 (20:55 -0400)]
mount.cifs: print output to stderr
When a mount fails, mount.cifs often prints an error message. In most
cases, this error goes to stdout instead of stderr like it should. Fix
it to print errors to stderr instead.
Reported-by: Jan Engelhardt <jengelh@gmx.de>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeremy Allison [Fri, 25 Sep 2009 00:44:45 +0000 (17:44 -0700)]
Reduce debug log level from 0 -> 7 on non-critical message.
Jeremy.
John H Terpstra [Fri, 25 Sep 2009 00:26:03 +0000 (19:26 -0500)]
Patches to fix typos thanks to OPC oota.
John H Terpstra [Fri, 25 Sep 2009 00:18:33 +0000 (19:18 -0500)]
Bug fix thanks to vjbangis viray
Jeremy Allison [Thu, 24 Sep 2009 22:52:58 +0000 (15:52 -0700)]
Remove the const from the str_list_XXX functions that
allocate both list and containing strings. This fixes
problems that people have tried to cast away and are
not needed.
Jeremy.
Jeremy Allison [Thu, 24 Sep 2009 22:44:28 +0000 (15:44 -0700)]
Revert
b39c390280d1f268e2550c731057aec550a3f086 - casts should not
be here.
Jeremy.
Jeremy Allison [Thu, 24 Sep 2009 22:42:36 +0000 (15:42 -0700)]
Revert
918b5a7e057bd91289ec06b3ef8d95da43a50ede. This code
should *not* return const.
Jeremy.
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:52:19 +0000 (23:52 +0200)]
s3: Fix up various string "const" warnings
My changed introduced some warnings. Fix them.
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:50:05 +0000 (23:50 +0200)]
s3:util_str "str_list_make_v3" - introduce also here the "const" result
I did this to match with the default util strlist library.
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:49:41 +0000 (23:49 +0200)]
s3:vfs_default - correct function parameters
Günther Deschner [Thu, 24 Sep 2009 16:20:50 +0000 (18:20 +0200)]
s3-winbindd: no reason to call winbindd_can_contact_domain() three times in query_user().
Guenther
Günther Deschner [Thu, 24 Sep 2009 16:20:13 +0000 (18:20 +0200)]
s3: remove unused printing macros.
Guenther
Steven Danneman [Thu, 14 May 2009 23:14:03 +0000 (23:14 +0000)]
s3 onefs: Fix 1 second share mode delay handling
When racing to the open and loosing we may get a share_mode violation.
In this case handle the 1-second delay via a defferred open properly.
This requires us to retrieve the share_mode_lock before deferring
open so we don't dereference a NULL pointer assuming we already had
the lck because we were the first opener.
Steven Danneman [Thu, 14 May 2009 23:12:23 +0000 (23:12 +0000)]
s3 onefs: Fix a race condition exists in onefs_open.c between multiple opens to the same file.
Two openers can stat a file at the same time, see that it doesn't exist,
and then both race to open it first. The loser will enter
onefs_open_file_ntcreate believing that the file doesnt exist, and thus
skip any current state lookups for that file. This includes setting
the file_id, and having a valid stat buffer.
Normally on first create the file_id will be set during the open, but
the second opener in this scenario may fail the open (oplock/share mode)
and file_id will not be set, nor will the stat buffer be valid.
In the error paths of this patch, we now double check that the file_id
and the stat buffer are valid before doing other operations.
Zack Kirsch [Wed, 22 Apr 2009 23:30:55 +0000 (23:30 +0000)]
s3 onefs: Add some debugging/asserts to give more info when there is bad deferred open state.
Signed-off-by: Tim Prouty <tprouty@samba.org>
Tim Prouty [Fri, 28 Aug 2009 22:53:09 +0000 (22:53 +0000)]
s4 torture: Fix RAW-STREAMS to request more specific permissions
This allows RAW-STREAMS to pass when the user isn't root on some
systems that don't give full access rights to non-root users.
Tim Prouty [Fri, 28 Aug 2009 22:53:05 +0000 (22:53 +0000)]
s3: Add more helpful debugging to some of the streams code
Aravind Srinivasan [Wed, 23 Sep 2009 20:37:04 +0000 (20:37 +0000)]
vfs catia: Fix a NULL dereference when CATIA is loaded with no mappings specified.
When we use the CATIA vfs module and don't have any mapping specified,
we return NULL for the mapped_name, thereby resulting in segfaults.
When we don't have catia mapping, we should just use the old name
instead of returning NULL for the mapped_name.
Signed-off-by: Tim Prouty <tprouty@samba.org>
Aravind Srinivasan [Thu, 3 Sep 2009 20:46:10 +0000 (20:46 +0000)]
vfs catia: Fix the double translation that was happening with createfile and open.
Since the catia translation is implemented for open, it should not
also be done in createfile. By removing createfile from catia,
translation is now done correctly for the primary open path.
In order to support systems that have custom createfile
implementations that don't eventually call SMB_VFS_OPEN,
SMB_VFS_TRANSLATE_NAME has been expanded to take an additional
argument that specifies direction.
Signed-off-by: Tim Prouty <tprouty@samba.org>
Aravind Srinivasan [Wed, 2 Sep 2009 17:20:21 +0000 (17:20 +0000)]
vfs catia: Fix a possible NULL dereference
Also free some unfreed memory.
Signed-off-by: Tim Prouty <tprouty@samba.org>
Andrew Tridgell [Thu, 24 Sep 2009 14:08:31 +0000 (07:08 -0700)]
s4-drs: el may not be a talloc pointer
Use msg->elements for the new element values
Andrew Tridgell [Thu, 24 Sep 2009 14:19:46 +0000 (07:19 -0700)]
s4-drs: regenerate IDL after ndr size change
Andrew Tridgell [Thu, 24 Sep 2009 14:19:01 +0000 (07:19 -0700)]
s4-drs: add defines for replication flags on attributes
Andrew Tridgell [Thu, 24 Sep 2009 14:18:21 +0000 (07:18 -0700)]
s4-ldb: sort replPropertyMetaData by attid
We need to sort on both module add and modify
Andrew Tridgell [Thu, 24 Sep 2009 14:16:50 +0000 (07:16 -0700)]
s4-ldb: add instanceType in repl_meta_data module
We need to add instanceType on new records if not added by caller. This is needed in repl_meta_data
to ensure we fill in the meta data for replication
Andrew Tridgell [Thu, 24 Sep 2009 14:02:47 +0000 (07:02 -0700)]
s4-drs: fixed the size of DN binary blobs on the wire
Comparison with w2k8 traces shows the size field of
drsuapi_DsReplicaObjectIdentifier3Binary is taken from
drsuapi_DsReplicaObjectIdentifier3
Thanks to metze for spotting this
Andrew Tridgell [Thu, 24 Sep 2009 14:12:14 +0000 (07:12 -0700)]
s4-drs: include deleted objects in getncchanges reply
Even though we don't create deleted objects ourselves yet, we need to
pass along deleted objects we receive from other replication partners
Andrew Tridgell [Thu, 24 Sep 2009 14:05:07 +0000 (07:05 -0700)]
s4-drs: add SHOW_DELETED control on dsdb utility calls
The dsdb_find_dn_by_guid() and dsdb_find_sid_by_dn() are using by
the DRS server call getncchanges on objects that may be deleted.
Andrew Tridgell [Wed, 23 Sep 2009 21:53:28 +0000 (14:53 -0700)]
s4-libnet: allow the functional level of becomeDC to be specified
Use
ads:functional level = 4
for DS_DC_FUNCTION_2008_R2
See libds/common/flags.h
Andrew Tridgell [Thu, 24 Sep 2009 17:33:36 +0000 (10:33 -0700)]
s4-libnet: avoid a steal with references error
Jelmer Vernooij [Wed, 23 Sep 2009 17:52:52 +0000 (19:52 +0200)]
Add init file for DCE/RPC tests.
Jelmer Vernooij [Wed, 23 Sep 2009 17:52:45 +0000 (19:52 +0200)]
PEP8
Jelmer Vernooij [Wed, 23 Sep 2009 14:54:17 +0000 (16:54 +0200)]
Revert "s4:python fixed subunit tests of dcerpc"
This reverts commit
ffd48a79ee34dc90c0f6f16564c3a0de8b53d3d2.
Volker Lendecke [Thu, 24 Sep 2009 11:11:14 +0000 (13:11 +0200)]
s3: Forgot to check in one build failure for vfs_gpfs.c
Volker Lendecke [Thu, 24 Sep 2009 11:10:54 +0000 (13:10 +0200)]
s3: Remove an unused variable
Volker Lendecke [Thu, 24 Sep 2009 10:49:18 +0000 (12:49 +0200)]
s3: Make the vfs_gpfs compile at least
Not sure whether it works in this state :-)
Stefan Metzmacher [Thu, 24 Sep 2009 04:45:10 +0000 (06:45 +0200)]
Revert "s3:winbindd: use a tcp connection for lsa in case lookup_names/lookup_sids doesn't work over ncacn_np"
This reverts commit
f23691cffd39e5df81b7b075e61ed1def6cce9f6.
This should not have been commited...
metze
Stefan Metzmacher [Thu, 24 Sep 2009 04:38:08 +0000 (06:38 +0200)]
s3:rpc_server: we need to make a copy of my_name in serverinfo_to_SamInfo_base()
This is important for the case the server_info already contains a logon_server.
metze
Günther Deschner [Thu, 17 Sep 2009 07:43:36 +0000 (09:43 +0200)]
s3:winbindd: use a tcp connection for lsa in case lookup_names/lookup_sids doesn't work over ncacn_np
metze
Anatoliy Atanasov [Wed, 23 Sep 2009 23:51:55 +0000 (16:51 -0700)]
s4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_SPECIAL_SECRET_PROCESSING in getncchanges
When this flag is specified in the request these attributes are treated as
secret: currentValue, dBCSPwd, initialAuthIncoming, initialAuthOutgoing,
lmPwdHistory, ntPwdHistory, priorValue, supplementalCredentials,
trustAuthIncoming, trustAuthOutgoing, unicodePwd
Their value is changed to NULL and the meta_data.originating_change_time to 0
Anatoliy Atanasov [Wed, 23 Sep 2009 23:52:34 +0000 (16:52 -0700)]
s4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_ASYNC_REP in getncchanges
When this flag is specified in the request we should return
for ncRoot only and so scope of search is LDB_SCOPE_BASE.
Anatoliy Atanasov [Wed, 23 Sep 2009 23:58:58 +0000 (16:58 -0700)]
s4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_FULL_SYNC_PACKET in getncchanges
When this flag is specified in the request we shouldn't use the
uptodateness vector in the request.
Anatoliy Atanasov [Wed, 23 Sep 2009 22:48:10 +0000 (15:48 -0700)]
idl: regenerate idl
Anatoliy Atanasov [Wed, 23 Sep 2009 22:47:14 +0000 (15:47 -0700)]
s4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_CRITICAL_ONLY req in getncchanges
Stefan Metzmacher [Fri, 8 Dec 2006 00:11:39 +0000 (00:11 +0000)]
Revert "r20074: this values seem to be typos in drsuapi"
This reverts commit
1dfd365d57dcd712d315a1a903c8d3d0a0f0fc12
This change was from and the flags I was seeing have another meaning.
metze
Signed-off-by: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
Andrew Bartlett [Tue, 1 Sep 2009 09:56:56 +0000 (19:56 +1000)]
s4:ldif_handlers Fix memory leak in objectCategory LDIF handler
Andrew Tridgell [Wed, 23 Sep 2009 20:56:10 +0000 (13:56 -0700)]
s4-drs: fill in more guids and SIDs, plus filter rDN
In DsGetNCChanges we need to fill in the parentGUID and objectGUID of
each object, plus we need to filter out the rDN from the meta data,
and always send the instanceType
Andrew Tridgell [Wed, 23 Sep 2009 20:54:47 +0000 (13:54 -0700)]
s4-dsdb: cope with windows sending extra pad bytes
Andrew Tridgell [Wed, 23 Sep 2009 20:52:39 +0000 (13:52 -0700)]
s4-dsdb: added dsdb_find_sid_by_dn()
Andrew Tridgell [Wed, 23 Sep 2009 03:57:18 +0000 (20:57 -0700)]
s4-drsserver: fixed addition of sort control
Andrew Tridgell [Wed, 23 Sep 2009 03:56:54 +0000 (20:56 -0700)]
fixed spelling
Andrew Tridgell [Wed, 23 Sep 2009 03:56:32 +0000 (20:56 -0700)]
s4-drs: ignore zero value elements in DRS add operations
w2k8 sometimes sends us a new object via DRS with an attribute with no
values
Andrew Tridgell [Mon, 21 Sep 2009 23:30:31 +0000 (16:30 -0700)]
s4-netlogon: always set the dNSHostName in GetDomainInfo
This seems to be what w2k8 does
Andrew Tridgell [Mon, 21 Sep 2009 17:45:14 +0000 (10:45 -0700)]
regenerate IDL
Andrew Tridgell [Mon, 21 Sep 2009 17:42:42 +0000 (10:42 -0700)]
s4-netlogon: make GetDomainInfo response match w2k8
Andrew Tridgell [Mon, 21 Sep 2009 17:41:06 +0000 (10:41 -0700)]
s4-cldap: return domainFunctionality from SAM
Andrew Tridgell [Mon, 21 Sep 2009 17:38:40 +0000 (10:38 -0700)]
idl: fixed string termination for netlogon GetDomainInfo
Andrew Tridgell [Mon, 21 Sep 2009 17:38:09 +0000 (10:38 -0700)]
s4-nbt: added NBT_SERVER_DNS_FOREST
Volker Lendecke [Wed, 23 Sep 2009 13:47:05 +0000 (15:47 +0200)]
s3:gencache: Make gencache_del() return success for expired entries
This fixes nasty error messages from "net cache flush"
Volker Lendecke [Wed, 23 Sep 2009 13:41:06 +0000 (15:41 +0200)]
s3:gencache: Remove some over-paranoid locking
Volker Lendecke [Wed, 23 Sep 2009 13:21:40 +0000 (15:21 +0200)]
s3:gencache: Add a "was_expired" argument to gencache_get_data_blob
This is set to true if the routine returns failure due to an existing but
expired entry.
Jelmer Vernooij [Wed, 23 Sep 2009 12:22:36 +0000 (14:22 +0200)]
Check for PyString_FromString being NULL.
Jelmer Vernooij [Wed, 23 Sep 2009 09:01:52 +0000 (11:01 +0200)]
provision: Avoid linking in multiple copies of security python module.
Volker Lendecke [Wed, 23 Sep 2009 04:23:50 +0000 (06:23 +0200)]
s3:winbind: Fix an uninitialized variable
Andrew Tridgell [Wed, 23 Sep 2009 00:07:33 +0000 (17:07 -0700)]
s4-drsserver: sort by DN to give tree order
This might help the windows client with ordered requests. Later we
need to support the "ancestors" mode flag.