Gerald Carter [Mon, 20 Mar 2006 10:18:23 +0000 (10:18 +0000)]
r14577: BUG Fixes:
* Add back in the import/export support to pdbedit
* Fix segv in pam_smbpass
* Cleanup some error paths in pdb_tdb and pdb_interface
(This used to be commit
df53d64910fbb96eb810102e986b3c337d54c463)
Günther Deschner [Mon, 20 Mar 2006 10:05:51 +0000 (10:05 +0000)]
r14576: Skip remaining keytab entries when we have a clear indication that
krb5_rd_req could decrypt the ticket but that ticket is just not valid
at the moment (either not yet valid or already expired). (This also
prevents an MIT kerberos related crash)
Guenther
(This used to be commit
8a0c1933d3f354a8aff67482b8c7d0d1083e0c8f)
James Peach [Sun, 19 Mar 2006 23:32:50 +0000 (23:32 +0000)]
r14574: Allow use of sendfile as long as the write cache has not been enabled
on the particular file we are performing I/O on, irrespective of whether
the write cache is globally enabled
(This used to be commit
0809e2cb1dfff1cd0e8631b23b415cb2d8a67312)
Volker Lendecke [Sun, 19 Mar 2006 11:11:37 +0000 (11:11 +0000)]
r14559: Oplocks have changed, process_smb can be static again
(This used to be commit
19e9bc03f81d8d000b683cf5c5f478ba25ddeb0d)
Gerald Carter [Fri, 17 Mar 2006 20:35:44 +0000 (20:35 +0000)]
r14530: removing unused 'winbind max idle children' parameter
(This used to be commit
0e789b7e43388b0e7155708981b4ab52ec6d3961)
Stefan Metzmacher [Fri, 17 Mar 2006 16:30:00 +0000 (16:30 +0000)]
r14522: sync socket_wrapper code with samba4
metze
(This used to be commit
7cf4ad8899d2109ff30d3168fd5028f8548ec34f)
Gerald Carter [Fri, 17 Mar 2006 14:44:15 +0000 (14:44 +0000)]
r14515: fix soname breakage caused by mad merge from trunk (missed replacing a AC variable)
(This used to be commit
7d92cff7a3327cc9da5a4723bd62e68e0402acb8)
Günther Deschner [Fri, 17 Mar 2006 14:31:05 +0000 (14:31 +0000)]
r14514: Fixing last commit. Thanks Volker.
Guenther
(This used to be commit
345d2ab5d399a99f271148cf308271cb7fc2c0ca)
Günther Deschner [Fri, 17 Mar 2006 14:18:05 +0000 (14:18 +0000)]
r14513: Fix winbindd_chauthtok: only fallback when the chgpasswd3 call is not
supported.
Is there a better way to check for the 0x1c010002 status code?
Guenther
(This used to be commit
c7268dc9ac304e1b6dac80762087a57484906103)
Gerald Carter [Fri, 17 Mar 2006 13:57:00 +0000 (13:57 +0000)]
r14512: Guenther, This code breaks winbind with MIT krb1.3.
I'm disabling it for now until we have en effective
means of dealing with the ticket request flags for users
and computers.
(This used to be commit
635f0c9c01c2e389ca916e9004e9ea064bf69cbb)
Volker Lendecke [Fri, 17 Mar 2006 11:53:33 +0000 (11:53 +0000)]
r14509: Attempt to fix the build on "sun1"
(This used to be commit
6704859950eb93d86906d4916cf6842d9a970d2f)
Günther Deschner [Fri, 17 Mar 2006 10:43:33 +0000 (10:43 +0000)]
r14508: Return PAM_SUCCESS in pam_sm_close_session when there is no KRB5CCNAME
environment.
Guenther
(This used to be commit
1f1402e45db8d80a7c19208fae934e1b0f3da134)
Günther Deschner [Fri, 17 Mar 2006 10:36:07 +0000 (10:36 +0000)]
r14507: Re-disable accidentially re-enabled paranoia check. This should make
offline logons work again with NT4 and older Samba3 DCs.
Guenther
(This used to be commit
0892077fcec913ef76b017b5bfe058d20a322915)
Günther Deschner [Fri, 17 Mar 2006 10:22:13 +0000 (10:22 +0000)]
r14506: Remove remaining references to a KCM credential cache type.
Guenther
(This used to be commit
aae8f8ae7a79d06c74151186f3c2470bdec5687d)
Günther Deschner [Fri, 17 Mar 2006 10:14:33 +0000 (10:14 +0000)]
r14505: Rename the timed_event to lockout_policy_event.
Guenther
(This used to be commit
3e607aa69ae2d43fb6ec170d03221a6b22d3f35d)
Günther Deschner [Fri, 17 Mar 2006 09:25:26 +0000 (09:25 +0000)]
r14503: Fix principal in debug statement.
Guenther
(This used to be commit
7b1fcb75dadd5ff232d60f93206867cf13322f2e)
Günther Deschner [Thu, 16 Mar 2006 23:54:05 +0000 (23:54 +0000)]
r14496: Add WBFLAG_PAM_GET_PWD_POLICY bit to only callout for domain password
policies when requested.
No panic, the flags is uint32 so we are not running out of WBFLAG bits.
Guenther
(This used to be commit
2155bb0535656f294bd054d6a0a7d16a9a71c31b)
Günther Deschner [Thu, 16 Mar 2006 22:54:07 +0000 (22:54 +0000)]
r14495: Allow to play with the logon_param flag when testing samlogons.
Guenther
(This used to be commit
52d721b6384cf6f94e1ebb59d21bf09737a539b5)
Günther Deschner [Thu, 16 Mar 2006 22:17:03 +0000 (22:17 +0000)]
r14493: There is no point in falling back to a samlogon when a krb5login has
failed with a clear error indication. This prevents the bad logon count
beeing increased on the DC.
Guenther
(This used to be commit
5fdddffba5cf05ccac23a64fbe404a34e73fa73c)
Jeremy Allison [Thu, 16 Mar 2006 21:05:15 +0000 (21:05 +0000)]
r14489: Guard against coverity reversion. #181 is a false positive
but make the intent clearer.
Jeremy.
(This used to be commit
2703df7a8f26a315ae6ab53de8f7814fa66a1c54)
Gerald Carter [Thu, 16 Mar 2006 16:46:23 +0000 (16:46 +0000)]
r14482: Fixes for spoolss code (after coverity fixes) when the
client sends a NULL RPC_BUFFER*
(This used to be commit
69f816e9f885bdeb6e8c67222b6fdca76d9d1025)
Volker Lendecke [Thu, 16 Mar 2006 15:21:41 +0000 (15:21 +0000)]
r14480: Kill one boolean flag passed down :-)
(This used to be commit
d9b85e3b287c24d2a3e2076da331fe06192b0eef)
Gerald Carter [Thu, 16 Mar 2006 13:48:01 +0000 (13:48 +0000)]
r14475: patch from Oliver Schulze L. <oliver@samera.com.py> for BUG 3580. Make RHEL makerpms.sh script more verbose and add some additional options to the rpmbuild process
(This used to be commit
7d73973db1a9133d6165b52031f09257046a64f7)
Günther Deschner [Thu, 16 Mar 2006 13:37:23 +0000 (13:37 +0000)]
r14474: Also flush the nscd caches before entering the main winbindd loop.
Guenther
(This used to be commit
c81eb71834dc827db63c8adb3f816bbbe916473c)
Günther Deschner [Thu, 16 Mar 2006 11:32:01 +0000 (11:32 +0000)]
r14468: Better fix to avoid winbind panic when we have an inproper configuration
and want to just shutdown and exit.
Guenther
(This used to be commit
0aa6328ed6ba6d0d24169ffdff0099405c9bfb00)
Günther Deschner [Thu, 16 Mar 2006 11:04:21 +0000 (11:04 +0000)]
r14467: Reverting 13660. This needs to be fixed differently.
Guenther
(This used to be commit
4157bfe9cfe79ff78e7e527a50058cf9103cab61)
Jeremy Allison [Wed, 15 Mar 2006 23:10:38 +0000 (23:10 +0000)]
r14462: Fix warning. ber_tag_t is an unsigned int for
printing purposes.
Jeremy.
(This used to be commit
3c33eda430426e40e179799e7341db10c4b2e98e)
Jeremy Allison [Wed, 15 Mar 2006 22:52:59 +0000 (22:52 +0000)]
r14460: SMBexit closes by pid and vuid. Tested with smbtorture.
Jeremy.
(This used to be commit
71e81580421225d5b35a25d46a7b6064a826685c)
Gerald Carter [Wed, 15 Mar 2006 17:40:28 +0000 (17:40 +0000)]
r14457: Add a few more special cases for RID 513 in the samr code.
Now that I know what all the requirements for this group are
I can generalize the code some more and make it cleaner.
But at least this is working with lusrmgr.msc on XP and 2k now.
(This used to be commit
d2c1842978cd50485849bfc4fb6d94767d96cab0)
Jeremy Allison [Wed, 15 Mar 2006 16:37:37 +0000 (16:37 +0000)]
r14454: Janitor for tridge - same code exists in Samba3 and 4.
Jeremy.
-----------------------------
fixed an hmac-md5 error for keys longer than 64 (using deallocated
stack variable)
(This used to be commit
f3879dd6bbbb20524e138b9ba8a54f6464fee5eb)
Gerald Carter [Wed, 15 Mar 2006 16:09:24 +0000 (16:09 +0000)]
r14452: Sorry. Need more coffee....
* Fix sprintf() args when createing the group search filter.
(This used to be commit
0b7549997a3739b2c1500e7838ebaaa249dbfaf4)
Gerald Carter [Wed, 15 Mar 2006 16:00:34 +0000 (16:00 +0000)]
r14451: In order to get pdb_ldap searching for SID_NAME_ALIAS
groups in the ${MACHINESID} and S_1-5-32 domains correctly,
I had to add a substr search on sambaSID.
* add substr matching rule to OpenLDAP schema
(we need to update the other schema as will since this
is a pretty important change). Sites will need to
- install the new schema
- add 'indea sambaSID sub' to slapd.conf
- run slapindex
* remove uses of SID_NAME_WKN_GRP in pdb_ldap.c
(This used to be commit
2c0a46d73122e9000a900f7e16f9b010ad4b78e3)
Gerald Carter [Wed, 15 Mar 2006 15:38:15 +0000 (15:38 +0000)]
r14450: Fix more get_md4pw() breakage caused by missing "breaks"
in the switch statement which matched the schannel type
against the account type.
(This used to be commit
57c705ea63381ed9ab09145b4f57a736931fa6ca)
Gerald Carter [Wed, 15 Mar 2006 15:11:44 +0000 (15:11 +0000)]
r14449: fix the build (sorry everyone)
(This used to be commit
e49ca3af8c2522aee670e6b807d7b3df31be47f6)
Gerald Carter [Wed, 15 Mar 2006 14:58:39 +0000 (14:58 +0000)]
r14448: * protect against NULL cli_state* pointers in cli_rpc_pipe_open()
* Fix inverted logic check for machine accounts in get_md4pw()
(This used to be commit
a36529535dcb5a262e7627b80fb62a31240dc8ad)
Günther Deschner [Wed, 15 Mar 2006 12:23:09 +0000 (12:23 +0000)]
r14443: rework get_md4pw() to ease debugging. The only functional change is that
we now check wheter the sec_channel_type matches the trust account type.
Guenther
(This used to be commit
c35eb449375d53ffa0815897e7723c203be1f732)
Gerald Carter [Wed, 15 Mar 2006 05:50:52 +0000 (05:50 +0000)]
r14432: Give in and grant BUILT\Administrators all privileges
(This used to be commit
b6170910604dba6533b727de8d7f0cc75256d14f)
James Peach [Wed, 15 Mar 2006 05:49:32 +0000 (05:49 +0000)]
r14428: Call fill_share_mode_entry with NO_OPLOCK instead of 0.
(This used to be commit
a39cbaa699d111264c2c9dda49a6e4f42acd3fb8)
Gerald Carter [Wed, 15 Mar 2006 03:46:20 +0000 (03:46 +0000)]
r14421: This does two things
* Automatically creates the BUILTIN\Users group similar to
how BUILTIN\Administrators is done. This code does need to
be cleaned up considerably. I'll continue to work on this.
* The important fix is for getusergroups() when dealing with a
local user and nested groups. Now I can run the following
successfully:
$ su - jerry -c groups
users BUILTIN\users
(This used to be commit
f54d911e686ffd68ddc6dbc073987b9d8eb2fa5b)
Jeremy Allison [Wed, 15 Mar 2006 03:27:03 +0000 (03:27 +0000)]
r14418: Try and fix Coverity #39 and #40 by making the
implicit function contract explicit.
Jeremy.
(This used to be commit
6de5e9ae4628d384631db9b66e22d439a303b75c)
Jeremy Allison [Wed, 15 Mar 2006 03:00:49 +0000 (03:00 +0000)]
r14416: Remove deadcode. Coverity #198.
Jeremy.
(This used to be commit
7fc61f5a63c982cfd0fbe1838979ba7be8f69fca)
Jim McDonough [Wed, 15 Mar 2006 02:31:11 +0000 (02:31 +0000)]
r14408: More on fix for coverity #36. The previous fix would cause us to
marshall a buffer based on an unknown size. Zero out the sec_desc
buffer to prevent this. This is still not getting proper results for
a registry security descriptor (everything gets ACCESS DENIED), but
at least we aren't blowing out memory now...
(This used to be commit
cb370cc28ce361628df137c9aef02739aca062db)
Jeremy Allison [Wed, 15 Mar 2006 02:16:14 +0000 (02:16 +0000)]
r14406: Disable this call until we can sort out how this
should be done correctly. Fix coverity #37.
Jeremy.
(This used to be commit
d241f74e06eac7b61e5b7e09c2b9a955ec560fec)
Jeremy Allison [Wed, 15 Mar 2006 00:35:51 +0000 (00:35 +0000)]
r14405: Fix the build when nscd_flush_cache is detected
(variable definition was missing).
Jeremy.
(This used to be commit
48594f0270502149069fc883096181a9730d76bf)
Gerald Carter [Wed, 15 Mar 2006 00:10:38 +0000 (00:10 +0000)]
r14403: * modifies create_local_nt_token() to create a BUILTIN\Administrators
group IFF sid_to_gid(S-1-5-32-544) fails and 'winbind nested groups = yes'
* Add a SID domain to the group mapping enumeration passdb call
to fix the checks for local and builtin groups. The SID can be
NULL if you want the old semantics for internal maintenance.
I only updated the tdb group mapping code.
* remove any group mapping from the tdb that have a
gid of -1 for better consistency with pdb_ldap.c.
The fixes the problem with calling add_group_map() in
the tdb code for unmapped groups which might have had
a record present.
* Ensure that we distinguish between groups in the
BUILTIN and local machine domains via getgrnam()
Other wise BUILTIN\Administrators & SERVER\Administrators
would resolve to the same gid.
* Doesn't strip the global_sam_name() from groups in the
local machine's domain (this is required to work with
'winbind default domain' code)
Still todo.
* Fix fallback Administrators membership for root and domain Admins
if nested groups = no or winbindd is not running
* issues with "su - user -c 'groups'" command
* There are a few outstanding issues with BUILTIN\Users that
Windows apparently tends to assume. I worked around this
presently with a manual group mapping but I do not think
this is a good solution. So I'll probably add some similar
as I did for Administrators.
(This used to be commit
612979476aef62e8e8eef632fa6be7d30282bb83)
Jeremy Allison [Tue, 14 Mar 2006 21:01:30 +0000 (21:01 +0000)]
r14399: Fix deadcode coverity bug #3.
Jeremy.
(This used to be commit
3799f18b356934592206679310e6e409c0d1ca0f)
Jeremy Allison [Tue, 14 Mar 2006 20:37:24 +0000 (20:37 +0000)]
r14397: Fix deadcode in coverity error #1.
Jeremy.
(This used to be commit
4a4953c4d27cd1e925c9afe24fa49b015ce033ec)
Jeremy Allison [Tue, 14 Mar 2006 20:32:27 +0000 (20:32 +0000)]
r14395: Fix coverity bug #55. Ensure no unsigned/signed comparisons.
Jeremy.
(This used to be commit
cd3ad3f1a6f622b4bad5cb21b132de4cc476e03f)
Jeremy Allison [Tue, 14 Mar 2006 20:07:36 +0000 (20:07 +0000)]
r14393: Fix a couple of AIX warnings.
Jeremy.
(This used to be commit
8444c997bd3e18b1d04ebe85f06c8c6e34d7373f)
Günther Deschner [Tue, 14 Mar 2006 18:50:55 +0000 (18:50 +0000)]
r14392: Use KRB5_TGS_NAME.
Guenther
(This used to be commit
4cfd737cc1d8840888f80e360119eeb627acb381)
Jeremy Allison [Tue, 14 Mar 2006 17:21:30 +0000 (17:21 +0000)]
r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
(This used to be commit
f65d7afe1977d9d85046732842f9643716c15088)
Simo Sorce [Tue, 14 Mar 2006 13:58:17 +0000 (13:58 +0000)]
r14377: Fix coverity #4 for 3_0 too
(This used to be commit
aa26642ee19dcf7cfa3cb36032eadc823b01966b)
Günther Deschner [Tue, 14 Mar 2006 09:22:01 +0000 (09:22 +0000)]
r14368: Remove redundant set of logon flags (now in rpc_netlogon.h).
Guenther
(This used to be commit
8d4290cb8ed75cf12fa45bcf3e93cfe1a5567919)
Volker Lendecke [Tue, 14 Mar 2006 08:27:44 +0000 (08:27 +0000)]
r14367: Not that I fully understand what's going on here, but the code as it was here
was clearly buggy as Coverity showed with bug id #36.
According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship
it in the request.
Volker
(This used to be commit
075e784491e6f2b491bd063db08ff1267f9cabbb)
Jeremy Allison [Tue, 14 Mar 2006 06:22:18 +0000 (06:22 +0000)]
r14365: As solaris nss includes includes.h, make sure we use
the correct malloc-macros.
Jeremy.
(This used to be commit
412dc6f5dbc796126b94f3809fe660afac5d3c2a)
Jeremy Allison [Mon, 13 Mar 2006 23:58:58 +0000 (23:58 +0000)]
r14359: Try and fix Coverity #176 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit
a3b8bee3ff8211d78f793877c877ccd2e15825dd)
Jeremy Allison [Mon, 13 Mar 2006 23:56:02 +0000 (23:56 +0000)]
r14357: Try and fix Coverity #169 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
line, and those below, will be ignored--
M source/smbd/posix_acls.c
(This used to be commit
b8397c9f33424e0d1ed3ff849e1c99812f978000)
Jeremy Allison [Mon, 13 Mar 2006 23:48:13 +0000 (23:48 +0000)]
r14355: Try and fix Coverity #158 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit
7ada96a1cfb1e928b7dfde101ca250b20024243f)
Jeremy Allison [Mon, 13 Mar 2006 23:07:14 +0000 (23:07 +0000)]
r14353: Fix coverity bugs #61 and #62. Remember to divide by
the size of the data table. Clean up the struct a little.
Jeremy.
(This used to be commit
338538410d484a9358b60b05a86180275344ffa4)
Jeremy Allison [Mon, 13 Mar 2006 22:49:56 +0000 (22:49 +0000)]
r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring).
Fix Coverity #59.
Jeremy.
(This used to be commit
d793e1550cc8c79a2764609cddec082470d226e4)
Jeremy Allison [Mon, 13 Mar 2006 21:11:15 +0000 (21:11 +0000)]
r14345: Fix Coverity #71. We don't currently propagate *any*
alloc error back up the stack from smbldap_set_mod()
so ensure we abort correctly.
Jeremy.
(This used to be commit
9a1e35079af9404e1775e2a098990277b3771086)
Jeremy Allison [Mon, 13 Mar 2006 19:47:18 +0000 (19:47 +0000)]
r14342: Fix coverity #68, resource leak on error path.
Jeremy.
(This used to be commit
7520a8d2a10c72d330099c6502848afca60f56ff)
Jeremy Allison [Mon, 13 Mar 2006 19:40:51 +0000 (19:40 +0000)]
r14340: Fix coverity #78, resource leak in error path.
Jeremy.
(This used to be commit
76c4f2c4dc6fcd91a350985b16f4a6a321ac4bf6)
Jeremy Allison [Mon, 13 Mar 2006 18:59:31 +0000 (18:59 +0000)]
r14338: Fix coverity #55 by explicit cast.
Jeremy.
(This used to be commit
1fece52da4d667fa182aa9a87aaee3917860448b)
Jeremy Allison [Mon, 13 Mar 2006 18:56:26 +0000 (18:56 +0000)]
r14336: Try and quieten coverity #53 and #54. Make it obvious
we're using -1 as a special size_t case by casting.
Jeremy.
(This used to be commit
415530bd082bf351f5e4c1fd32408f123ed77f85)
Jeremy Allison [Mon, 13 Mar 2006 18:42:57 +0000 (18:42 +0000)]
r14333: Fix coverity #77, ensure we can't exit after allocation.
Jeremy.
(This used to be commit
15d78ab1fc83249552476d99144389cfe42a786f)
Lars Müller [Mon, 13 Mar 2006 17:45:04 +0000 (17:45 +0000)]
r14331: Add a comment on top of test_pam_modules about what we're testing.
(This used to be commit
90eb092083383c2b606e21dc65fb036bb973b032)
Günther Deschner [Mon, 13 Mar 2006 17:26:52 +0000 (17:26 +0000)]
r14329: Fix the build on systems without libcom_err.
Guenther
(This used to be commit
44fcd3113be970edd01f7f076c4b6cad2d03ebcd)
Lars Müller [Mon, 13 Mar 2006 16:19:44 +0000 (16:19 +0000)]
r14326: First catch of make test_pam_modules.
Testing pam_smbpass pam_winbind
dlopen() of "./bin/pam_smbpass.so" succeeded.
dlopen() of "./bin/pam_winbind.so" failed: ././bin/pam_winbind.so:
undefined symbol: secrets_fetch_domain_sid
make: *** [test_pam_modules] Error 1
(This used to be commit
4b545e0ce665fe772095c27fe11ce535477f84ce)
Lars Müller [Mon, 13 Mar 2006 16:10:26 +0000 (16:10 +0000)]
r14325: Add pam_modules rule which builds the configure(d) pam modules. This is
called as part of the all rule (again only if pam modules are requested
by configure).
Add pam_winbind rule.
Ensure proto_exists before we build the pam modules.
Add test_pam_modules rule to test if the built pam modules have any
unresolved symbols. For test_pam_modules we use script/tests/dlopen.sh
which was written by Nalin Dahyabhai <nalin@redhat.com>. Thanks Nalin!
RedHat and SuSE use this script to test nss and pam modules since
several years.
(This used to be commit
71b2eb55adcd28f3796254ea1ce0bcee6098e712)
Günther Deschner [Mon, 13 Mar 2006 15:13:35 +0000 (15:13 +0000)]
r14321: When we have libnscd and winbindd comes (back) online, try to flush the
nscd caches so that NSS-calls can deliver accurate information.
Guenther
(This used to be commit
a32a423a0e9e0d4dd21282fd528bcd3247fddbd1)
Lars Müller [Mon, 13 Mar 2006 14:22:43 +0000 (14:22 +0000)]
r14317: Use source/bin as dir to link pam_winbind instead of source/nsswitch/
The intention is to have the resulting binaries at one place. This is
also usefull for upcoming changes to provide a test_pammodules rule.
With these changes I even got aware of
testsuite/nsswitch/pam_winbind_syms.exp But this only covers
pam_winbind.
(This used to be commit
9883957b74ddefb5293e4aef0cc2f53ee4d417ac)
Jeremy Allison [Mon, 13 Mar 2006 06:52:03 +0000 (06:52 +0000)]
r14303: Fix coverity #223. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit
f71aa3ab8fdfd08c1bec57b6506ead7c4af7299d)
Jeremy Allison [Mon, 13 Mar 2006 06:50:33 +0000 (06:50 +0000)]
r14301: Fix coverity #224. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit
f1a5e5aefeeb78512c41cc8fc075b240696a3eb7)
Jeremy Allison [Mon, 13 Mar 2006 06:48:41 +0000 (06:48 +0000)]
r14299: Fix coverity #225. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
(This used to be commit
1c0b4ed0acdb7fccb148d714796752fefc6dd78c)
Volker Lendecke [Mon, 13 Mar 2006 06:44:10 +0000 (06:44 +0000)]
r14298: The other half of Coverity # 217
(This used to be commit
b9fb3fc0e3708b4721aaa1dcb7756d3774fb8db8)
Jeremy Allison [Mon, 13 Mar 2006 04:27:53 +0000 (04:27 +0000)]
r14292: Janitor for tridge (samba3 talloc is almost identical
to Samba4 talloc).
Jeremy
- make the snprintf call in talloc portable to older solaris boxes
- fixed an error found sing the beam analyser
(This used to be commit
1e1bae7afd9cd0051878ff1810c8ddfc28129233)
Jeremy Allison [Mon, 13 Mar 2006 04:05:47 +0000 (04:05 +0000)]
r14289: Fix coverity #101, resource leak on error code path.
Jeremy.
(This used to be commit
d9e1d6fed099e7651807aa839a743fc7756ee326)
Jeremy Allison [Mon, 13 Mar 2006 03:59:53 +0000 (03:59 +0000)]
r14286: Similar clarifiction fix for coverity #102.
Jeremy.
(This used to be commit
f458596b0edd958321c5d4061f034846348a3fe6)
Jeremy Allison [Mon, 13 Mar 2006 03:56:24 +0000 (03:56 +0000)]
r14284: Fix coverity bug #103. Make code clearer - probably
not a real issue but this code is easier to read.
Jeremy.
(This used to be commit
6621acc68f9a65540330d5c0d07db2488a3e8678)
Jeremy Allison [Mon, 13 Mar 2006 03:50:26 +0000 (03:50 +0000)]
r14282: Change centry_string to only use talloc. Should
quieten coverity bug #194 (which I think is a
false positive).
Jeremy.
(This used to be commit
07d8b02d3dddf7322e096f3f0a7cc1c8fa709fa3)
Jim McDonough [Mon, 13 Mar 2006 01:49:01 +0000 (01:49 +0000)]
r14280: Fix Coverity #129 and 130: check before dereferencing a pointer. This
was especially silly as we checked immediately _after_ dereferencing it
:-/
(This used to be commit
7ebfe2cb26b72d7fac397cfe3ceb14f244388224)
Jim McDonough [Mon, 13 Mar 2006 01:42:40 +0000 (01:42 +0000)]
r14279: Fix coverity #86, 87, 88, 89:
Free grp_sid and owner_sid before returning. Also, only allow one group
or owner.
(This used to be commit
1043e0d90ccb3493417f7bf05b70bdf5513bb1a3)
Jim McDonough [Mon, 13 Mar 2006 01:32:30 +0000 (01:32 +0000)]
r14278: Remainder of fix for Coverity #79,80,81: only allow GROUP or OWNER to be
specified once in an ACL, so it can be allocated a second time,
overwriting the first
(This used to be commit
1804a8a01ebf3353574a2c5b26a1746b34715737)
Jeremy Allison [Mon, 13 Mar 2006 01:08:27 +0000 (01:08 +0000)]
r14275: Shut-up coverity false positive (bug #199) by making an assertion
explicit.
Jeremy.
(This used to be commit
aeae20a8d9f3658acb8edd373eb601bdf7eab98b)
Jeremy Allison [Mon, 13 Mar 2006 00:37:57 +0000 (00:37 +0000)]
r14273: Fix coverity bug #202. Memory leak on error path.
Jeremy.
(This used to be commit
d2be8163f2cf69681150ed7de720a37ffaa8e937)
Jim McDonough [Mon, 13 Mar 2006 00:35:33 +0000 (00:35 +0000)]
r14272: Fix Coverity # 81: free alloc'ed storage before returning
(This used to be commit
1899d8ea283845141b24d91d230248009744fe1a)
Jeremy Allison [Mon, 13 Mar 2006 00:30:18 +0000 (00:30 +0000)]
r14270: Fix coverity #203. Ensure we free on error exit.
Jeremy.
(This used to be commit
9fa2e1bdedb61557b43f86c2898b7bf8762bbb63)
Jeremy Allison [Mon, 13 Mar 2006 00:26:38 +0000 (00:26 +0000)]
r14268: Fix coverity error #204. Resource leak on error path.
Jeremy.
(This used to be commit
5f74e56b865e0bdde0e574cd5f97cf29b06ad155)
Jeremy Allison [Mon, 13 Mar 2006 00:25:04 +0000 (00:25 +0000)]
r14266: Fix coverity #205. Resource leak on error path.
Jeremy.
(This used to be commit
23d69758bbff9687ab508e12931a5a49691d7e0d)
Jeremy Allison [Mon, 13 Mar 2006 00:23:17 +0000 (00:23 +0000)]
r14264: Fix coverity #207. Resource leak on error path.
Jeremy.
(This used to be commit
0429b6e8c34a99d4b2a9a4849075ef2a5acadf9e)
Jeremy Allison [Mon, 13 Mar 2006 00:08:39 +0000 (00:08 +0000)]
r14261: Fix coverity #38. No null deref.
Jeremy.
(This used to be commit
2a2b966b7b92ac340d61ba157d207a42509a93d1)
Jeremy Allison [Mon, 13 Mar 2006 00:05:47 +0000 (00:05 +0000)]
r14259: Fix coverity #42. Ensure contact_domain can't be null derefed
in error code path.
Jeremy.
(This used to be commit
9f5fcdd8fb437882568e38e174e2df27bd077ba3)
James Peach [Sun, 12 Mar 2006 22:27:01 +0000 (22:27 +0000)]
r14255: Revert r14204 which was horribly broken.
(This used to be commit
950ed28f9f3f57dc449bd3bd6e7be7acb1e3d26d)
Jim McDonough [Sun, 12 Mar 2006 19:56:10 +0000 (19:56 +0000)]
r14252: Fix Coverity #72: free alloc'ed storage before return. Also found one
more that coverity didn't find from asprintf.
(This used to be commit
37b6e2c8de41754a5a1a3a6f798d57aa5d533ada)
Jeremy Allison [Sun, 12 Mar 2006 19:16:45 +0000 (19:16 +0000)]
r14250: Fix coverity bug #107. Resource leak on error path.
Jeremy.
(This used to be commit
ca96c7be778d01594a540917acd3c5c218d6459c)
Volker Lendecke [Sun, 12 Mar 2006 18:01:36 +0000 (18:01 +0000)]
r14249: We've dereferenced the_acl before, no point in checking.
Fix Coverity bug # 128.
Volker
(This used to be commit
84e9e73f3c71a0ccef76d56bc72dcd21160ed286)
Volker Lendecke [Sun, 12 Mar 2006 17:57:05 +0000 (17:57 +0000)]
r14248: Fix Coverity bug # 84
(This used to be commit
811ae2b21f98bd8926f8edd70de19fe18265e28e)
Volker Lendecke [Sun, 12 Mar 2006 17:53:57 +0000 (17:53 +0000)]
r14247: Fix Coverity bug # 136
(This used to be commit
1b247ff2ed380f5b7d28917d74d6ef5609330a45)
Volker Lendecke [Sun, 12 Mar 2006 17:48:51 +0000 (17:48 +0000)]
r14246: Fix Coverity bug # 85
(This used to be commit
ebc21336d80c5d417b309d4f9c22c074c324e123)