Kovarththanan Rajaratnam [Sun, 9 Aug 2009 07:01:26 +0000 (07:01 -0000)]
Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
Kovarththanan Rajaratnam [Sun, 9 Aug 2009 06:47:24 +0000 (06:47 -0000)]
Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29341
Kovarththanan Rajaratnam [Sun, 9 Aug 2009 06:26:46 +0000 (06:26 -0000)]
Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
Guy Harris [Sun, 9 Aug 2009 01:23:09 +0000 (01:23 -0000)]
Don't use DISSECTOR_ASSERT() to check a packet's content. Fixes bug
3827.
svn path=/trunk/; revision=29339
Gerald Combs [Sat, 8 Aug 2009 22:20:08 +0000 (22:20 -0000)]
Check TLV lengths before we try to add them to the tree. Fixes bug 3824.
svn path=/trunk/; revision=29338
Kovarththanan Rajaratnam [Sat, 8 Aug 2009 12:40:59 +0000 (12:40 -0000)]
From Bahaa Naamneh via Bug 3538:
This patch ensures that the filter autocompletion code handles protocols (radius and wimaxasncp) which uses delayed initialisation of protocols fields.
svn path=/trunk/; revision=29337
Kovarththanan Rajaratnam [Sat, 8 Aug 2009 09:57:07 +0000 (09:57 -0000)]
Make sure that we pass on the same set of parameters to asn2wrs.py on Unix/Windows. This fix ensures that the generated copyright headers are identical on both platforms.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3658
svn path=/trunk/; revision=29336
Kovarththanan Rajaratnam [Sat, 8 Aug 2009 09:22:58 +0000 (09:22 -0000)]
Pass on WinPcap/MSVC redistributable executables to the WiresharkPortable launcher and not the extractor.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3547.
svn path=/trunk/; revision=29335
Jaap Keuter [Sat, 8 Aug 2009 04:51:42 +0000 (04:51 -0000)]
From Ivan Sy:
Fixed IPv6 malformed packet when ip6_nxt (Next Header) is equal to "59". as per section 4.7 RFC 2460.
svn path=/trunk/; revision=29334
Guy Harris [Sat, 8 Aug 2009 01:23:15 +0000 (01:23 -0000)]
Note that the new behavior matches what Wireshark does.
svn path=/trunk/; revision=29333
Guy Harris [Sat, 8 Aug 2009 01:21:55 +0000 (01:21 -0000)]
Move one comment before all of the code to which it refers.
Update another comment with information from the corresponding comment
in tshark.c
Move some code so that it's run only if its result is used.
Add an additional comment about logging on UN*X.
svn path=/trunk/; revision=29332
Gerald Combs [Sat, 8 Aug 2009 00:27:31 +0000 (00:27 -0000)]
If we have a format error, don't try adding something to the
tree. Fixes bug 3822.
svn path=/trunk/; revision=29331
Bill Meier [Fri, 7 Aug 2009 22:36:14 +0000 (22:36 -0000)]
fuzz-test: Fix/change WIRESHARK_ABORT_ON_DISSECTOR_BUG handling:
1. If enabled: the variable must be exported to the env to take effect;
2. Upon reflection: disable this feature:
tshark has been changed to output WARNING messages to stderr as a
default; This means that DISSECTOR_BUGs and failed DISSECTOR_ASSERTs
which cause WARNING log level messages will thus be output to stderr and
thus will be detected by the fuzz-test.
svn path=/trunk/; revision=29330
Gerald Combs [Fri, 7 Aug 2009 21:53:40 +0000 (21:53 -0000)]
From Matt P via bug 3774:
Patch utilizes techniques incorporated in the packet-ieee8023.c dissect_802_3()
routine to dynamically calculate the remaining payload length. This is then
compared to the length included in the CCSDS header.
svn path=/trunk/; revision=29329
Bill Meier [Fri, 7 Aug 2009 21:22:54 +0000 (21:22 -0000)]
tshark: console_log_level preference now controls which log msgs are sent to stderr;
Note: This is a behavior change:
Given the default value for the console_log_level preference
tshark will now show ERROR, CRITICAL and WARNING level log messages.
Prior to this change tshark was hardwired to show only
ERROR and CRITICAL level messages.
Time will tell whether this change results in too much noise
in tshark output.
svn path=/trunk/; revision=29328
Jörg Mayer [Fri, 7 Aug 2009 18:49:24 +0000 (18:49 -0000)]
- Add an AC macro to test linker flags.
- Test whether the linker supports --as-needed and if so,
adds it to LDFLAGS
svn path=/trunk/; revision=29327
Jörg Mayer [Fri, 7 Aug 2009 18:47:56 +0000 (18:47 -0000)]
* Tue May 26 2009 cmorve69@yahoo.es
- made it compile with --as-needed
This patch was taken from the opensuse wireshark.spec file.
No thanks go to the author and the package maintainers of
this package for not sending this upstream - it would have
made it into 1.2.0.
svn path=/trunk/; revision=29326
Jörg Mayer [Fri, 7 Aug 2009 18:45:06 +0000 (18:45 -0000)]
- Add rfc number comments on not-yet-decoded options
- Decode autoconfigure option
svn path=/trunk/; revision=29325
Kovarththanan Rajaratnam [Fri, 7 Aug 2009 14:01:44 +0000 (14:01 -0000)]
Back out r29323. The non fully qualified path seems to work for everyone else so don't mess with it.
svn path=/trunk/; revision=29324
Kovarththanan Rajaratnam [Fri, 7 Aug 2009 13:18:02 +0000 (13:18 -0000)]
Use fully qualified path to bash
svn path=/trunk/; revision=29323
Kovarththanan Rajaratnam [Fri, 7 Aug 2009 12:15:46 +0000 (12:15 -0000)]
Free frame data slice on file reset
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3813
svn path=/trunk/; revision=29322
Gerald Combs [Fri, 7 Aug 2009 00:15:35 +0000 (00:15 -0000)]
Clean up the last two DIRTY_DISSECTOR_SRC entries.
svn path=/trunk/; revision=29321
Bill Meier [Thu, 6 Aug 2009 23:51:45 +0000 (23:51 -0000)]
Fix some individual cases of 'if (unsigned) < 0'
svn path=/trunk/; revision=29320
Bill Meier [Thu, 6 Aug 2009 23:47:21 +0000 (23:47 -0000)]
'if (curr_len <= 0)' won't work as desired when curr_len is declared as unsigned.
The fix: change to 'if ((signed)curr_len <= 0)'.
This is a bit of a hack but I think it works.
See the comment in this file (packet-gsm_a_common.h).
svn path=/trunk/; revision=29319
Guy Harris [Thu, 6 Aug 2009 23:26:24 +0000 (23:26 -0000)]
Those items are 32 bits or longer, so the cast should be safe; add an
additional cast in the hopes that they squelch "dereferencing
type-punned pointer" warnings.
svn path=/trunk/; revision=29318
Michael Tüxen [Thu, 6 Aug 2009 22:26:05 +0000 (22:26 -0000)]
packet-sctp.c seems to be clean (at least it is on Mac OS X).
svn path=/trunk/; revision=29317
Stig Bjørlykke [Thu, 6 Aug 2009 22:06:37 +0000 (22:06 -0000)]
Added new_packet_list_set_font() and initialize fonts when using
new packet list.
svn path=/trunk/; revision=29316
Michael Tüxen [Thu, 6 Aug 2009 21:55:10 +0000 (21:55 -0000)]
Get it compiling when HAVE_LIBGCRYPT is not defined.
svn path=/trunk/; revision=29315
Bill Meier [Thu, 6 Aug 2009 21:42:40 +0000 (21:42 -0000)]
Fix some indentation and spacing
svn path=/trunk/; revision=29314
Gerald Combs [Thu, 6 Aug 2009 20:55:04 +0000 (20:55 -0000)]
Fix compilation warnings in a few dissectors and try moving them to the
"clean" list.
svn path=/trunk/; revision=29313
Bill Meier [Thu, 6 Aug 2009 18:44:38 +0000 (18:44 -0000)]
Prevent possible (benign ?) array references with an array index of -1.
svn path=/trunk/; revision=29312
Bill Meier [Thu, 6 Aug 2009 16:13:31 +0000 (16:13 -0000)]
Remove inadvertantly committed comments re issue yet to be fixed ...
svn path=/trunk/; revision=29311
Bill Meier [Thu, 6 Aug 2009 16:10:29 +0000 (16:10 -0000)]
Register ett[] subtree array only once.
svn path=/trunk/; revision=29310
Bill Meier [Thu, 6 Aug 2009 16:06:11 +0000 (16:06 -0000)]
Register ett[] subtree array only once.
svn path=/trunk/; revision=29309
Gerald Combs [Wed, 5 Aug 2009 19:03:48 +0000 (19:03 -0000)]
Convert a GString to an ep_strbuf_t (and squelch a static analysis
warning in the process). Remove an unused variable.
svn path=/trunk/; revision=29308
Jaap Keuter [Wed, 5 Aug 2009 18:42:45 +0000 (18:42 -0000)]
From Gerasimos Dimitriadis:
Fixes/enhances the decoding of the Mobile Identity IE for type of identity
"TMGI and optional MBMS Session Identity".
svn path=/trunk/; revision=29307
Jaap Keuter [Wed, 5 Aug 2009 18:21:52 +0000 (18:21 -0000)]
Fix for bug 3811:
Add missing shorthand application/vnd.ms-sync besides application/vnd.ms-sync.wbxml.
svn path=/trunk/; revision=29306
Jaap Keuter [Wed, 5 Aug 2009 18:17:18 +0000 (18:17 -0000)]
From Ivan Sy:
Add support for Support for DHCID RR (RFC 4701).
svn path=/trunk/; revision=29305
Gerald Combs [Wed, 5 Aug 2009 15:39:29 +0000 (15:39 -0000)]
Squelch a couple of Clang Static Analyzer warnings.
svn path=/trunk/; revision=29304
Martin Mathieson [Wed, 5 Aug 2009 08:02:12 +0000 (08:02 -0000)]
Show power headroom report inside its own subtree.
svn path=/trunk/; revision=29303
Jaap Keuter [Wed, 5 Aug 2009 07:33:44 +0000 (07:33 -0000)]
Fix for bug 3806:
Add presentation of Block Ack Bitmap.
svn path=/trunk/; revision=29302
Gerald Combs [Wed, 5 Aug 2009 00:36:27 +0000 (00:36 -0000)]
Add a couple of pointer checks.
svn path=/trunk/; revision=29301
Guy Harris [Wed, 5 Aug 2009 00:13:38 +0000 (00:13 -0000)]
Fix typo.
svn path=/trunk/; revision=29300
Guy Harris [Tue, 4 Aug 2009 23:14:40 +0000 (23:14 -0000)]
Put the initializers for the elements of value_string arrays into curly
brackets, so the API checks for non-terminated value_string arrays will
not falsely think the arrays are non-terminated.
svn path=/trunk/; revision=29299
Jaap Keuter [Tue, 4 Aug 2009 21:05:38 +0000 (21:05 -0000)]
Optimize empty strings to NULL pointers.
svn path=/trunk/; revision=29298
Bill Meier [Tue, 4 Aug 2009 19:29:42 +0000 (19:29 -0000)]
Fix benign double subtree registration of an ett_... variable.
svn path=/trunk/; revision=29297
Bill Meier [Tue, 4 Aug 2009 19:01:34 +0000 (19:01 -0000)]
Minor changes:
- Move proto_register...() to the end of the file as per convention;
- Move ett[] to be local to proto_register...();
- "if (...==-1)" not req'd in proto_register...();
- #include <moduleinfo.h> not req'd;
- Remove unneeded forward declarations.
svn path=/trunk/; revision=29296
Bill Meier [Tue, 4 Aug 2009 18:52:01 +0000 (18:52 -0000)]
Initialize several ett_... variables to -1
svn path=/trunk/; revision=29295
Bill Meier [Tue, 4 Aug 2009 18:48:45 +0000 (18:48 -0000)]
Init ett_... variables to -1
svn path=/trunk/; revision=29294
Bill Meier [Tue, 4 Aug 2009 18:46:51 +0000 (18:46 -0000)]
Remove duplicate entry from ett[]
svn path=/trunk/; revision=29293
Guy Harris [Tue, 4 Aug 2009 18:39:43 +0000 (18:39 -0000)]
Clean up white space a bit - use 2-space indenting.
Put a bunch of code that does nothing unless data_val is non-null inside
"if (data_val)", and get rid of the individual tests.
svn path=/trunk/; revision=29292
Gerald Combs [Tue, 4 Aug 2009 17:59:48 +0000 (17:59 -0000)]
Miscellaneous cleanups.
svn path=/trunk/; revision=29291
Martin Mathieson [Tue, 4 Aug 2009 10:41:08 +0000 (10:41 -0000)]
Show number of predefined bytes in info column.
svn path=/trunk/; revision=29290
Jörg Mayer [Tue, 4 Aug 2009 07:50:49 +0000 (07:50 -0000)]
Warning fix: comma at end of enum
svn path=/trunk/; revision=29289
Gerald Combs [Tue, 4 Aug 2009 00:35:30 +0000 (00:35 -0000)]
Don't exit with an error if we can't find the svn executable.
svn path=/trunk/; revision=29288
Gerald Combs [Mon, 3 Aug 2009 23:51:13 +0000 (23:51 -0000)]
Rework an assignment to keep static analyzers from complaining.
svn path=/trunk/; revision=29287
Gerald Combs [Mon, 3 Aug 2009 23:50:55 +0000 (23:50 -0000)]
Remove a couple of unused variables.
svn path=/trunk/; revision=29286
Gerald Combs [Mon, 3 Aug 2009 23:49:05 +0000 (23:49 -0000)]
Add some null checks.
svn path=/trunk/; revision=29285
Bill Meier [Mon, 3 Aug 2009 23:18:59 +0000 (23:18 -0000)]
More minor cleanups:
- Move proto_register to near the end of the file as per convention;
- Remove unneeded #include <epan/reassemble.h>;
- Comment out unused ett[] array and associated;
svn path=/trunk/; revision=29284
Bill Meier [Mon, 3 Aug 2009 22:38:43 +0000 (22:38 -0000)]
Minor cleanups:
- Comment out code which creates two dissector tables and then
stores a preference value in each of them;
AFAICT the tables are not accessed elsewhere;
- Comment out the no longer required prefs callback specification
in proto_register;
- "if (... == -1)" not req'd in proto_register;
- Remove unused proto_reg_wimax function.
svn path=/trunk/; revision=29283
Bill Meier [Mon, 3 Aug 2009 22:09:08 +0000 (22:09 -0000)]
Various minor cleanups:
- Do all find_dissector() calls only once during proto_reg_handoff
(not each time a sub-dissector is called when dissecting frames).
- Move proto_register & proto_reg_handoff to the end of the file as per convention;
- Move a global variables to be local;
- Change a global variable to be static;
- Remove unneeded multiple #include <string.h>
- Remove an unneeded variable and a few unneeded lines of code.
svn path=/trunk/; revision=29282
Guy Harris [Mon, 3 Aug 2009 21:17:30 +0000 (21:17 -0000)]
Clean up indentation somewhat.
svn path=/trunk/; revision=29281
Jaap Keuter [Mon, 3 Aug 2009 21:12:41 +0000 (21:12 -0000)]
From Gerasimos Dimitriadis:
Added decoding support for the High Layer Compatibility IE in DTAP and updated
the relevant part in Q.931. Also some minor enhancements in Q.931.
svn path=/trunk/; revision=29280
Guy Harris [Mon, 3 Aug 2009 21:07:08 +0000 (21:07 -0000)]
Thou shalt terminate thy value_string arrays with {0, NULL}.
svn path=/trunk/; revision=29279
Gerald Combs [Mon, 3 Aug 2009 19:50:35 +0000 (19:50 -0000)]
Add a null pointer check. Remove some unused variables.
svn path=/trunk/; revision=29278
Jaap Keuter [Mon, 3 Aug 2009 18:23:04 +0000 (18:23 -0000)]
From Ivan Sy:
Support for Host Identity Protocol (HIP) Domain Name System (DNS) Extension.
svn path=/trunk/; revision=29277
Bill Meier [Mon, 3 Aug 2009 18:06:36 +0000 (18:06 -0000)]
Remove 1 commented-out #include inadvertantly committed.
svn path=/trunk/; revision=29276
Bill Meier [Mon, 3 Aug 2009 17:25:17 +0000 (17:25 -0000)]
Add some debug code (commented out) to check for duplicate dissector port registrations,
svn path=/trunk/; revision=29275
Bill Meier [Mon, 3 Aug 2009 16:21:55 +0000 (16:21 -0000)]
Reword some help text slightly.
svn path=/trunk/; revision=29274
Bill Meier [Mon, 3 Aug 2009 16:18:06 +0000 (16:18 -0000)]
Use find_dissector() instead of create_dissector_handle();
Fix some indentation.
svn path=/trunk/; revision=29273
Bill Meier [Mon, 3 Aug 2009 15:18:44 +0000 (15:18 -0000)]
Do find_dissector_table() in proto_reg_handoff().
svn path=/trunk/; revision=29272
Bill Meier [Mon, 3 Aug 2009 14:17:31 +0000 (14:17 -0000)]
(Trivial) Fix two typos.
svn path=/trunk/; revision=29271
Stig Bjørlykke [Mon, 3 Aug 2009 09:58:14 +0000 (09:58 -0000)]
Added missing packet-usb-hid.h
svn path=/trunk/; revision=29270
Stig Bjørlykke [Mon, 3 Aug 2009 08:05:44 +0000 (08:05 -0000)]
Handle usb_hid_item_usage_vals as range_string.
svn path=/trunk/; revision=29269
Bill Meier [Sun, 2 Aug 2009 19:54:33 +0000 (19:54 -0000)]
Do dissector_add() only if port non-zero; register dissector for "decode-as".
svn path=/trunk/; revision=29268
Bill Meier [Sun, 2 Aug 2009 19:20:20 +0000 (19:20 -0000)]
packet-stun2 registers for TCP & UDP port 3478 so packet-stun need not register for same.
svn path=/trunk/; revision=29267
Bill Meier [Sun, 2 Aug 2009 19:17:09 +0000 (19:17 -0000)]
Change default range from 1401,1401 to 1401 so that the port isn't double-registered.
svn path=/trunk/; revision=29266
Bill Meier [Sun, 2 Aug 2009 19:09:36 +0000 (19:09 -0000)]
Don't do dissector_add twice on TCP port 3689;
packet-daap requests registration on that port via http_dissector_add
and thus packet-http does not need to do a default registration on that port.
Also: fix a typo in a comment.
svn path=/trunk/; revision=29265
Gerald Combs [Sun, 2 Aug 2009 15:03:29 +0000 (15:03 -0000)]
[Automatic manuf and enterprise-numbers update for 2009-08-02]
svn path=/trunk/; revision=29262
Bill Meier [Sun, 2 Aug 2009 12:58:57 +0000 (12:58 -0000)]
Remove unneeded #include <epan/emem.h>; fix some indentation.
svn path=/trunk/; revision=29261
Jaap Keuter [Sun, 2 Aug 2009 12:53:14 +0000 (12:53 -0000)]
Add additional cypher types.
svn path=/trunk/; revision=29260
Jaap Keuter [Sun, 2 Aug 2009 12:11:38 +0000 (12:11 -0000)]
Fix for bug 3800:
Correctly track the size of Feedback Control Information in Payload specific RTCP feedback packet.
svn path=/trunk/; revision=29259
Martin Mathieson [Sat, 1 Aug 2009 09:52:12 +0000 (09:52 -0000)]
Remember Msg3 bytes and compare with Msg4 Contention Resolution bodies.
svn path=/trunk/; revision=29258
Guy Harris [Fri, 31 Jul 2009 23:38:02 +0000 (23:38 -0000)]
Fix indentation, get rid of a comment that might no longer apply (dump
*what* as hex? The stuff we now display as generic fields?).
svn path=/trunk/; revision=29257
Gerald Combs [Fri, 31 Jul 2009 22:16:29 +0000 (22:16 -0000)]
From Adam Nielsen via bug 3659:
Here is a patch against SVN that implements preliminary support for USB HID
devices. At the moment it only dissects the initial set up packets (which you
will see if you hotplug a keyboard or mouse.)
The patch also fixes a minor bug in the USB dissector code which reported
certain packets as malformed due to miscounting bytes, and it reports control
packet data and padding data in a more user-friendly manner.
svn path=/trunk/; revision=29256
Guy Harris [Fri, 31 Jul 2009 20:13:53 +0000 (20:13 -0000)]
Completely remove an unused variable, don't just comment it out
(especially with a C++/C99-style comment that not all compilers used to
compile Wireshark accept).
svn path=/trunk/; revision=29255
Gerald Combs [Fri, 31 Jul 2009 19:19:25 +0000 (19:19 -0000)]
From Holger Freyther via bug 3776:
Part 1:
Rename packet-gsm_abis_ip.c to packet-gsm_ipa.c.
Part 2:
Rename to the content to match the filename.
Part 3:
Add GSM A/SCCP support to the packet-gsm_ipa.c dissector
Adjusted patch to take laforge's comment into account. Use guint16 for the
length and use the ntohs routine to convert the length.
svn path=/trunk/; revision=29254
Gerald Combs [Fri, 31 Jul 2009 16:37:53 +0000 (16:37 -0000)]
From Ivan Sy via bug 3797:
Support for SPF RR (RFC 4408)
- this has the same format as TXT RR (see section 3.1.1) below.
Currently wireshark 1.2.1 shows this as Unknown type 99
svn path=/trunk/; revision=29253
Jaap Keuter [Fri, 31 Jul 2009 07:05:43 +0000 (07:05 -0000)]
From Ivan Sy:
Add support for SSHFP RR (RFC 4255).
svn path=/trunk/; revision=29252
Stephen Fisher [Fri, 31 Jul 2009 07:02:02 +0000 (07:02 -0000)]
Include packet_info.h before ui_utils.h since we just started passing a
packet_info structure to one of the functions.
svn path=/trunk/; revision=29251
Jaap Keuter [Fri, 31 Jul 2009 06:51:27 +0000 (06:51 -0000)]
From Ivan Sy:
NAPTR RR (RFC 3403) replacement MUST be a fully qualified domain-name.
svn path=/trunk/; revision=29250
Gerald Combs [Thu, 30 Jul 2009 23:47:36 +0000 (23:47 -0000)]
Remove more unused variables.
svn path=/trunk/; revision=29249
Guy Harris [Thu, 30 Jul 2009 21:40:22 +0000 (21:40 -0000)]
Fix warnings:
the behavior of x = x++ is undefined by the ANSI C standard -
they obviously just meant x++;
get rid of unused variables.
svn path=/trunk/; revision=29248
Anders Broman [Thu, 30 Jul 2009 21:11:26 +0000 (21:11 -0000)]
From swapnil:
Packet-gtpv2.c dissector extended to support more IE's.
svn path=/trunk/; revision=29247
Gerald Combs [Thu, 30 Jul 2009 17:54:58 +0000 (17:54 -0000)]
From Kovarththanan Rajaratnam via bug 3506:
The exception throwing code in except.c/h should be annotated with
"noreturn" to indicate that they never return. Running static analysis
on Wireshark without this annotation causes a lot of false positives
since these analyzers assume that the exception handling code are
ordinary functions that will eventually return.
svn path=/trunk/; revision=29246
Gerald Combs [Thu, 30 Jul 2009 17:22:00 +0000 (17:22 -0000)]
Remove a couple of unused variables.
svn path=/trunk/; revision=29245
Martin Mathieson [Thu, 30 Jul 2009 16:53:33 +0000 (16:53 -0000)]
Show backoff indicator value in subheader tree root.
svn path=/trunk/; revision=29244
Gerald Combs [Thu, 30 Jul 2009 16:17:46 +0000 (16:17 -0000)]
Remove some unused variable assignments.
svn path=/trunk/; revision=29243
Gerald Combs [Thu, 30 Jul 2009 00:40:32 +0000 (00:40 -0000)]
Remove some unused variables.
svn path=/trunk/; revision=29242
Bill Meier [Wed, 29 Jul 2009 23:18:34 +0000 (23:18 -0000)]
Fix a typo
svn path=/trunk/; revision=29241