Stefan Metzmacher [Thu, 6 Oct 2016 06:25:16 +0000 (08:25 +0200)]
libcli/smb/smb_direct.c
Stefan Metzmacher [Thu, 6 Oct 2016 06:25:05 +0000 (08:25 +0200)]
more
Stefan Metzmacher [Thu, 6 Oct 2016 05:26:47 +0000 (07:26 +0200)]
fix it?
Stefan Metzmacher [Wed, 5 Oct 2016 17:39:46 +0000 (19:39 +0200)]
c->state.receive_posted
Stefan Metzmacher [Wed, 5 Oct 2016 17:18:10 +0000 (19:18 +0200)]
ACCPECT fix initial send_credits => 0
Stefan Metzmacher [Wed, 5 Oct 2016 17:17:53 +0000 (19:17 +0200)]
KEEP only once
Stefan Metzmacher [Wed, 5 Oct 2016 16:54:20 +0000 (18:54 +0200)]
debug smb_direct credits
Stefan Metzmacher [Wed, 5 Oct 2016 16:54:05 +0000 (18:54 +0200)]
sq TODO smb_direct_connection_negotiate_accept_ibv_handler c->state.receive_credits += granted;
Stefan Metzmacher [Wed, 5 Oct 2016 16:53:44 +0000 (18:53 +0200)]
smb_direct_connection_post_io
Stefan Metzmacher [Wed, 5 Oct 2016 16:29:55 +0000 (18:29 +0200)]
TODO smb_direct_connection_negotiate_accept_ibv_handler c->state.receive_credits += granted;
TODO still wrong, we need to incremend in smb_direct_connection_post_recv()
Stefan Metzmacher [Wed, 5 Oct 2016 15:54:46 +0000 (17:54 +0200)]
libcli/smb/smb_direct.c wait for IBV_WC_RDMA_READ completion
Ralph Boehme [Wed, 5 Oct 2016 10:22:23 +0000 (12:22 +0200)]
WIP
Ralph Boehme [Tue, 4 Oct 2016 08:58:22 +0000 (10:58 +0200)]
libcli/smb/smb_direct: split up smb_direct_connection_sock_handler()
Split up smb_direct_connection_sock_handler() into read and write helper
funcs.
Ralph Boehme [Tue, 4 Oct 2016 04:19:21 +0000 (06:19 +0200)]
FIXUP: libcli/smb/smb_direct_client: fix smb_direct_accept()
First working smb session ovder smb-d transport.
Commit:
d7d380bad5ced419e53b2a01a21a72e2b0654e73
Trace: smb-d-step3.pcap
Ralph Boehme [Tue, 4 Oct 2016 04:18:24 +0000 (06:18 +0200)]
smb-d-daemon: pass conn smbd_direct_daemon_send_fd, not daemon state
Ralph Boehme [Tue, 4 Oct 2016 04:17:48 +0000 (06:17 +0200)]
s3/smbd: log accepted SMB-D connection and associated fd
Ralph Boehme [Mon, 3 Oct 2016 08:27:27 +0000 (01:27 -0700)]
s3/smbd: make smbd_add_connection() working with socket fd
Ralph Boehme [Mon, 3 Oct 2016 08:25:49 +0000 (01:25 -0700)]
smb_direct_client: ignore return value from msghdr_extract_fds()
This is what the rest of the codebase does as well, not sure why why it
returns a large value (iirc I've seen
35182561677316) different from 1.
Stefan Metzmacher [Sat, 1 Oct 2016 09:23:32 +0000 (11:23 +0200)]
debug it...
Stefan Metzmacher [Sat, 1 Oct 2016 09:23:17 +0000 (11:23 +0200)]
setup s->parent = parent
Stefan Metzmacher [Sat, 1 Oct 2016 09:22:38 +0000 (11:22 +0200)]
fix smb_direct_listener_accept_recv ...
Ralph Boehme [Sat, 1 Oct 2016 08:06:46 +0000 (01:06 -0700)]
WIP pass fd to smbd
Ralph Boehme [Sat, 1 Oct 2016 04:06:02 +0000 (21:06 -0700)]
DEBUG: add some nice debug message
Ralph Boehme [Sat, 1 Oct 2016 04:05:07 +0000 (21:05 -0700)]
SUCCESS: smb-d negotiate request and response
Commit:
bfa44ad4bc1078713ce8c7685bf880f7fdcb6e2a
Trace: smb-d-step2.pcap
Ralph Boehme [Sat, 1 Oct 2016 03:13:14 +0000 (20:13 -0700)]
WIP smb_direct_connection_negotatiate_accept_send/recv
Ralph Boehme [Sat, 1 Oct 2016 02:24:17 +0000 (19:24 -0700)]
WIP
Ralph Boehme [Fri, 30 Sep 2016 22:42:00 +0000 (15:42 -0700)]
needed? ignore EAGAIN in from rdma_get_cm_event
Working up to accepting RDMA connection. Next step is to read SMB-D nego
req and response.
Trace: smb-d-step1.pcap
Commit:
e12b372d2d615256f86c0eee063c036c0645ad80
Ralph Boehme [Fri, 30 Sep 2016 22:41:41 +0000 (15:41 -0700)]
disable smbd -i again
Ralph Boehme [Fri, 30 Sep 2016 21:23:37 +0000 (14:23 -0700)]
Revert "WIP move around fde"
This reverts commit
99d84cbc9836e58fa54082a59b8f4e4cbb44f1b4.
Ralph Boehme [Fri, 30 Sep 2016 21:23:02 +0000 (14:23 -0700)]
WIP move around fde
Ralph Boehme [Fri, 30 Sep 2016 21:18:29 +0000 (14:18 -0700)]
make it work
Stefan Metzmacher [Fri, 30 Sep 2016 13:54:45 +0000 (15:54 +0200)]
inline smb_direct_listener_accept_rdma_handler
Stefan Metzmacher [Fri, 30 Sep 2016 13:54:24 +0000 (15:54 +0200)]
implicit channeimplicit channell
Stefan Metzmacher [Fri, 30 Sep 2016 13:54:03 +0000 (15:54 +0200)]
HACK smbd -i
Stefan Metzmacher [Fri, 30 Sep 2016 13:53:41 +0000 (15:53 +0200)]
more
Stefan Metzmacher [Fri, 30 Sep 2016 13:52:03 +0000 (15:52 +0200)]
more
Stefan Metzmacher [Fri, 30 Sep 2016 08:16:06 +0000 (10:16 +0200)]
smb_direct_listener...
Stefan Metzmacher [Fri, 30 Sep 2016 08:05:12 +0000 (10:05 +0200)]
libcli/smb/smb_direct.c move a bit
Stefan Metzmacher [Fri, 30 Sep 2016 07:21:55 +0000 (09:21 +0200)]
smb_direct_connection_rdma_connect_send rdma_create_id
Stefan Metzmacher [Fri, 30 Sep 2016 06:29:31 +0000 (08:29 +0200)]
more...
Ralph Boehme [Fri, 30 Sep 2016 06:19:06 +0000 (23:19 -0700)]
WIP daemon
Ralph Boehme [Fri, 30 Sep 2016 06:08:43 +0000 (23:08 -0700)]
WIP
Stefan Metzmacher [Fri, 30 Sep 2016 05:46:38 +0000 (07:46 +0200)]
more...
Stefan Metzmacher [Fri, 30 Sep 2016 04:24:26 +0000 (06:24 +0200)]
libcli/smb/smb_direct.c
Stefan Metzmacher [Fri, 30 Sep 2016 04:10:34 +0000 (06:10 +0200)]
b/async_req/async_sock.c libcli/smb/smbXcli_base.c debug
Stefan Metzmacher [Fri, 30 Sep 2016 04:09:49 +0000 (06:09 +0200)]
libcli/smb/smbXcli_base.c size..
Stefan Metzmacher [Fri, 30 Sep 2016 00:57:35 +0000 (02:57 +0200)]
HACK SMB_DIRECT_IO_MAX_DATA 1364
Stefan Metzmacher [Fri, 30 Sep 2016 00:56:56 +0000 (02:56 +0200)]
libcli/smb/smb_direct.c needed? post individual items
Stefan Metzmacher [Fri, 30 Sep 2016 00:56:16 +0000 (02:56 +0200)]
libcli/smb/smbXcli_base.c smd_direct hacks
Stefan Metzmacher [Fri, 30 Sep 2016 00:56:02 +0000 (02:56 +0200)]
more libcli/smb/smb_direct.c
Ralph Boehme [Fri, 30 Sep 2016 04:25:59 +0000 (21:25 -0700)]
WIP add debug
Ralph Boehme [Fri, 30 Sep 2016 04:11:55 +0000 (21:11 -0700)]
FIXUP smb_direct.c
Ralph Boehme [Fri, 30 Sep 2016 04:11:48 +0000 (21:11 -0700)]
FIXUP daemon
Stefan Metzmacher [Thu, 29 Sep 2016 11:13:03 +0000 (13:13 +0200)]
more tests required may workwith
Stefan Metzmacher [Thu, 29 Sep 2016 10:53:28 +0000 (12:53 +0200)]
revert libcli/smb/smbXcli_base.c
Stefan Metzmacher [Thu, 29 Sep 2016 08:45:34 +0000 (10:45 +0200)]
put doesn't work yet...
Stefan Metzmacher [Thu, 29 Sep 2016 08:44:10 +0000 (10:44 +0200)]
HACK no debug libcli/smb/smb_direct.c
Stefan Metzmacher [Thu, 29 Sep 2016 08:35:34 +0000 (10:35 +0200)]
libcli/smb/smb_transport_tcp.c no debug
Stefan Metzmacher [Thu, 29 Sep 2016 08:19:24 +0000 (10:19 +0200)]
libcli/smb/smb_direct.c retry ibv_poll_cq()
Stefan Metzmacher [Thu, 29 Sep 2016 08:03:04 +0000 (10:03 +0200)]
Revert "try to get next ... fails"
This reverts commit
a5886bff5e7431e3735df07947c8cd4b6b2e72f4.
Stefan Metzmacher [Thu, 29 Sep 2016 08:02:46 +0000 (10:02 +0200)]
try to get next ... fails
Stefan Metzmacher [Thu, 29 Sep 2016 08:00:33 +0000 (10:00 +0200)]
debug more...
Stefan Metzmacher [Thu, 29 Sep 2016 00:29:11 +0000 (02:29 +0200)]
more
Stefan Metzmacher [Wed, 28 Sep 2016 19:56:16 +0000 (21:56 +0200)]
it almost works... we need to grant more credits...
Stefan Metzmacher [Wed, 28 Sep 2016 12:25:18 +0000 (14:25 +0200)]
more ...
Stefan Metzmacher [Wed, 28 Sep 2016 11:45:50 +0000 (13:45 +0200)]
libcli/smb/smb_direct.c
Stefan Metzmacher [Wed, 28 Sep 2016 11:44:57 +0000 (13:44 +0200)]
libcli/smb/smb_transport_direct.c debug hacks
Stefan Metzmacher [Wed, 28 Sep 2016 06:15:46 +0000 (08:15 +0200)]
libcli/smb/smb_direct.c
Stefan Metzmacher [Wed, 28 Sep 2016 04:48:04 +0000 (06:48 +0200)]
libcli/smb/smb_transport_direct.c: state->hdr for send
Ralph Boehme [Thu, 29 Sep 2016 19:36:53 +0000 (12:36 -0700)]
WIP
Ralph Boehme [Thu, 29 Sep 2016 05:43:29 +0000 (22:43 -0700)]
FIUXP daemon
Ralph Boehme [Wed, 28 Sep 2016 01:09:03 +0000 (18:09 -0700)]
s3/smbd: connect to smb_direct_daemon
Ralph Boehme [Tue, 27 Sep 2016 17:54:46 +0000 (10:54 -0700)]
libcli/smb: smb-dd client API
Ralph Boehme [Sun, 18 Sep 2016 15:28:37 +0000 (17:28 +0200)]
s3/smbd: start smb_direct_daemon
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Ralph Boehme [Sun, 18 Sep 2016 13:53:23 +0000 (15:53 +0200)]
libcli/smb: add smb_direct daemon infrastructure
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Ralph Boehme [Tue, 27 Sep 2016 17:52:51 +0000 (10:52 -0700)]
libcli: add a bunch of SMB-D related helper functions
Ralph Boehme [Mon, 26 Sep 2016 17:13:29 +0000 (10:13 -0700)]
librpc: add initial idl for smb_direct_daemon
Ralph Boehme [Sun, 18 Sep 2016 13:27:32 +0000 (15:27 +0200)]
HACK: fix cast to smb_direct_transport
Ralph Boehme [Sun, 18 Sep 2016 10:27:07 +0000 (12:27 +0200)]
HACK: fix build
Stefan Metzmacher [Sat, 24 Aug 2013 09:26:35 +0000 (11:26 +0200)]
STEP:smbXcli_base: Revert "STEP:smbXcli_base: pass it DEBUG"
This reverts commit
8d782952da7796be840c1e04e1d5b51f2e935b23.
Stefan Metzmacher [Thu, 27 Sep 2012 11:26:04 +0000 (13:26 +0200)]
STEP:smbXcli_base: pass it DEBUG
Stefan Metzmacher [Thu, 27 Sep 2012 08:28:41 +0000 (10:28 +0200)]
STEP:smbXcli_base: HACK smbXcli_base => smb_transport
Stefan Metzmacher [Sun, 17 Sep 2017 02:45:21 +0000 (04:45 +0200)]
Revert "STEP:smbsock_connect: pass it DEBUG"
This reverts commit
cece8fefd39c4619df8b8b5a8ba8e45a31b6889a.
Stefan Metzmacher [Thu, 27 Sep 2012 11:26:04 +0000 (13:26 +0200)]
STEP:smbsock_connect: pass it DEBUG
Stefan Metzmacher [Sun, 16 Sep 2012 21:43:06 +0000 (23:43 +0200)]
STEP:smbsock_connect: hack call smb_direct
Stefan Metzmacher [Fri, 10 Aug 2012 13:36:16 +0000 (15:36 +0200)]
STEP:smb_transport_direct: TODO... smb_transport_direct...
Stefan Metzmacher [Fri, 21 Sep 2012 20:17:56 +0000 (22:17 +0200)]
STEP:smb_transport: TODO: libcli/smb: add smb_transport*
This is a generic abstraction for a transport that can be used
by our SMB1/2/3 code.
TODO: don't return the NBT header in smb_transport_read_pdu_recv
(smb_transport_tcp_read_pdu_recv), but that needs more work in
the callers...
Volker Lendecke [Thu, 31 May 2018 19:16:21 +0000 (21:16 +0200)]
dns: Check for talloc_memdup failure
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jun 1 14:05:56 CEST 2018 on sn-devel-144
Volker Lendecke [Thu, 31 May 2018 19:11:16 +0000 (21:11 +0200)]
dns: TALLOC_FREE already checks for !=NULL
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Thu, 31 May 2018 18:57:36 +0000 (20:57 +0200)]
dns: Simplify logic a bit
We don't need a separate boolean variable
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Thu, 31 May 2018 18:56:31 +0000 (20:56 +0200)]
dns: Simplify logic a bit
We've done an early return if (!found_tsig) a few lines before.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Wed, 30 May 2018 15:24:35 +0000 (17:24 +0200)]
dnsupdate: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Lukas Slebodnik [Sat, 21 Oct 2017 13:09:01 +0000 (15:09 +0200)]
ldb: Fix memory leak on module context
Introduced in
e8cdacc509016d9273d63faf334d9f827585c3eb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13459
Signed-off-by: Lukas Slebodnik <lslebodn@fedoraproject.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jun 1 11:10:24 CEST 2018 on sn-devel-144
Andrew Bartlett [Thu, 31 May 2018 18:42:24 +0000 (06:42 +1200)]
lib/audit_logging: Remove #ifdef HAVE_JANSSON from audit_logging_test binary
Instead, we either build or do not build the entire binary.
This is much more likely to raise an error in make test if the build system
changes. The concern is that HAVE_JANSSON can go away and the tests just vanish.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Andrew Bartlett [Thu, 31 May 2018 20:56:53 +0000 (08:56 +1200)]
lib/audit_logging: Make function prototypes look like the rest of Samba
The previous style is needed sometimes to avoid an 80-col limit, but
is not how most of Samba looks.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Gary Lockyer [Wed, 16 May 2018 20:03:00 +0000 (08:03 +1200)]
lib audit_logging: re-factor and add functions.
Re-factor the common calls to json_dumps DEBUGC and audit_message_send
into a separate function.
Add functions to retrieve json object and json array elements
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Sachin Prabhu [Fri, 20 Apr 2018 12:51:10 +0000 (13:51 +0100)]
s4-torture: add test for lease break after file unlink
When deleting a file, all leases granting handle caching lease to the
file should be recalled.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13458
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun 1 02:57:46 CEST 2018 on sn-devel-144
Gary Lockyer [Wed, 30 May 2018 02:45:03 +0000 (14:45 +1200)]
rpc_server backupkey: pass remote connection data
Ensure that the requesting session data is passed to the audit logging
module for BackupKey requests.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 31 12:35:15 CEST 2018 on sn-devel-144
Gary Lockyer [Wed, 30 May 2018 02:44:19 +0000 (14:44 +1200)]
rpc_server lsa: pass remote connection data
Ensure that the session details of the requesting user are available to
the audit logging module for the CreateSecret and OpenSecret operations.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Gary Lockyer [Wed, 30 May 2018 02:43:25 +0000 (14:43 +1200)]
rpc_server: common routine to open ldb in system session
Add a function to open an ldb connection under the system session and
save the remote users session details in a ldb_opaque. This will allow
the audit logging to log the original session for operations performed
in the system session.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>