Jeremy Allison [Wed, 21 Oct 2009 00:41:27 +0000 (17:41 -0700)]
Fix comments on new test.
Jeremy
Jeremy Allison [Wed, 21 Oct 2009 00:37:43 +0000 (17:37 -0700)]
Add local (or NFS) lock test to smbtorture. Checks that local locks
conflict with CIFS locks (see bug 6868).
Jeremy.
Günther Deschner [Tue, 20 Oct 2009 21:47:40 +0000 (23:47 +0200)]
s4-smbtorture: fix RPC-LSA-LSALOOKUP test against w2k3 and w2k8.
Make sure to split out lsa_LookupName NULL name test so that we can better track
results from bogus names and NULL names.
Guenther
Jeremy Allison [Tue, 20 Oct 2009 20:42:28 +0000 (13:42 -0700)]
Fix "make install" by removing all references to python. Not currently
needed in source3, and isn't working anyway.
Jeremy.
Jeremy Allison [Tue, 20 Oct 2009 20:28:05 +0000 (13:28 -0700)]
Remove pythonmods from the build in source3, it doesn't build anyway
and isn't needed (as far as I can tell).
Jeremy.
Jeremy Allison [Tue, 20 Oct 2009 20:09:42 +0000 (13:09 -0700)]
Fix the pam_smbpass.so build with the recent linker flag changes.
Jeremy.
Günther Deschner [Tue, 20 Oct 2009 16:34:09 +0000 (18:34 +0200)]
s4-smbtorture: Make it simpler to specify number of trusted domains to create in
RPC-LSA-TRUSTED-DOMAINS.
Guenther
Günther Deschner [Tue, 20 Oct 2009 16:35:49 +0000 (18:35 +0200)]
s3-lsa: Fix _lsa_EnumTrustDom().
Windows clients were showing a lot of duplicates in their list of trusted
domains.
Found by RPC-LSA-TRUSTED-DOMAIN torture test.
Guenther
Günther Deschner [Tue, 20 Oct 2009 16:35:16 +0000 (18:35 +0200)]
s3-pdb_ldap: fix crash bug in ldapsam_set_trusteddom_pw().
Thanks Volker for the hint.
Guenther
Björn Jacke [Tue, 20 Oct 2009 18:45:46 +0000 (20:45 +0200)]
s3:Makefile: rename LDSHFLAG variables to make meaning more obvious
Günther Deschner [Tue, 20 Oct 2009 13:54:40 +0000 (15:54 +0200)]
s3-lsa: Fix _lsa_CreateAccount() for usage of SEC_FLAG_MAXIMUM_ALLOWED.
Found by RPC-LSA-PRIVILEGES torture test.
Guenther
Günther Deschner [Thu, 16 Jul 2009 16:46:10 +0000 (18:46 +0200)]
s3-selftest: enable RPC-LSA-PRIVILEGES against Samba 3.
Guenther
Günther Deschner [Tue, 20 Oct 2009 13:09:32 +0000 (15:09 +0200)]
s4-smbtorture: Fix wrong comment in RPC-LSA-TRUSTED-DOMAIN test.
Guenther
Günther Deschner [Tue, 20 Oct 2009 10:59:49 +0000 (12:59 +0200)]
s4-smbtorture: split out EnumTrustedDomainsEx test in RPC-LSA-TRUSTED-DOMAINS.
Guenther
Günther Deschner [Tue, 20 Oct 2009 13:15:06 +0000 (15:15 +0200)]
s3-lsa: Allow to lookup 'NT AUTHORITY\Anonymous Logon' as well.
This is to finally pass RPC-LSA-LOOKUPNAMES test.
Guenther
Günther Deschner [Tue, 20 Oct 2009 13:13:56 +0000 (15:13 +0200)]
s3-lsa: allow to lookup BUILTIN\ in lsa_LookupNames.
Found by RPC-LSA-LOOKUPNAMES torture test.
Guenther
Günther Deschner [Tue, 20 Oct 2009 13:12:58 +0000 (15:12 +0200)]
s3-lsa: When looking up domains in LookupNames, do not strip the sid.
Found by RPC-LSA-LOOKUPNAMES torture test.
Guenther
Günther Deschner [Tue, 20 Oct 2009 13:11:58 +0000 (15:11 +0200)]
s3-lsa: allow to have NULL strings in lsa LookupName queries.
Found by RPC-LSA-LOOKUPNAMES torture test.
Guenther
Günther Deschner [Tue, 20 Oct 2009 13:00:55 +0000 (15:00 +0200)]
s4-smbtorture: add stricter tests for LSA-LOOKUPNAMES replies.
Guenther
Günther Deschner [Wed, 15 Jul 2009 22:52:28 +0000 (00:52 +0200)]
s4-smbtorture: move all LookupNames tests into RPC-LSA-LOOKUPNAMES.
Guenther
Björn Jacke [Tue, 20 Oct 2009 06:01:52 +0000 (08:01 +0200)]
s3:configure: add support for Solaris' ld -z ignore
try linker flags for ignoring unused libs in this order:
-Wl,--as-needed (gcc like + binutils)
-Wl,-z,ignore (gcc like + Solaris linker)
-z ignore (old Sun C)
Björn Jacke [Mon, 19 Oct 2009 23:13:56 +0000 (01:13 +0200)]
s3: make unresolved symbols in libs throw errors
except for the Samba internal plugins unresolved symbol references should not
show up in shared libraries. For historical reasons it's the default behaviour
of linkers to ignore those in shared libs. We use -z defs (alias
--no-undefined) to not ignore them in shared libs.
Björn Jacke [Sun, 18 Oct 2009 20:51:06 +0000 (22:51 +0200)]
s3: allow using different LDFLAGS for internal libs/plugins
internal libs have unresolved symbols intentionally.
Thanks to Buchan Milne for suggestion and patch. This addresses #6792.
Andrew Tridgell [Tue, 20 Oct 2009 05:34:42 +0000 (16:34 +1100)]
s4-torture: fixed a pipe leak
The RPC-SAMR-PASSWORDS* tests could leak RPC pipes, causing an
overallocation of fd's on the server
Andrew Tridgell [Tue, 20 Oct 2009 05:18:51 +0000 (16:18 +1100)]
s4-selftest: the secleak test is not designed for automated running
Andrew Tridgell [Tue, 20 Oct 2009 04:41:30 +0000 (15:41 +1100)]
s4: ran minimal_includes.pl on source4/auth/gensec
Andrew Tridgell [Tue, 20 Oct 2009 04:39:35 +0000 (15:39 +1100)]
s4: ran minimal_includes.pl on source4/auth/ntlmssp
Andrew Tridgell [Tue, 20 Oct 2009 04:38:03 +0000 (15:38 +1100)]
s4: ran minimal_includes.pl on source4/auth/ntlm
Andrew Tridgell [Tue, 20 Oct 2009 04:34:30 +0000 (15:34 +1100)]
s4: ran minimal_includes.pl on source4/client
Andrew Tridgell [Tue, 20 Oct 2009 04:32:35 +0000 (15:32 +1100)]
s4: ran minimal_includes.pl on source4/rpc_server
Andrew Tridgell [Tue, 20 Oct 2009 04:01:46 +0000 (15:01 +1100)]
s4: ran minimal_includes.pl on source4/winbind
Andrew Tridgell [Tue, 20 Oct 2009 03:53:08 +0000 (14:53 +1100)]
s4-torture: ran minimal_includes.pl over source4/torture
This reduces compile time somewhat.
Andrew Tridgell [Tue, 20 Oct 2009 03:31:50 +0000 (14:31 +1100)]
s4-script: cleanup tmp files in minimial_includes.pl
also changes to use perl fns, instead of shell
Andrew Tridgell [Tue, 20 Oct 2009 04:19:27 +0000 (15:19 +1100)]
s4-selftest: skip two more scanners
Protocol scanners are not any use in the build farm
Andrew Tridgell [Tue, 20 Oct 2009 03:27:57 +0000 (14:27 +1100)]
s4-torture: fixed a fd/mem leak in the RPC-LSA-SECRETS test
This test left a large number of lsa pipes open, which could trigger
the server running out of fds
Andrew Tridgell [Tue, 20 Oct 2009 02:54:55 +0000 (13:54 +1100)]
s4-selftest: skip the trans2.scan test
This test consumes a huge number of file descriptors on the server
(random binds to the WKSSVC pipe)
Andrew Tridgell [Tue, 20 Oct 2009 02:00:12 +0000 (13:00 +1100)]
s4-dsdb: fixed empty structure error on solaris8
Nadya, I'm guessing you plan on adding some real elements to this
structure later. For now I've added _dummy so the build can continue
with the Solaris C compiler.
Andrew Tridgell [Tue, 20 Oct 2009 01:13:15 +0000 (12:13 +1100)]
s4-idl: don't call a variable 'stat'
never call a structure member by the name of a standard C lib call. It
breaks the build on some systems.
Andrew Tridgell [Tue, 20 Oct 2009 00:34:49 +0000 (11:34 +1100)]
lib-util: check for too many combinations in generate_unique_strs()
Andrew Tridgell [Mon, 19 Oct 2009 23:59:40 +0000 (10:59 +1100)]
tdb: fixed the intermittent failure of tdbtorture in the build farm
There was a race condition that caused the torture.tdb to be left in a
state that needed recovery. The torture code thought that any message
from the tdb code was an error, so the "recovered" message, which is a
TDB_DEBUG_TRACE message, marked the run as being an error when it
isn't.
John H Terpstra [Mon, 19 Oct 2009 18:29:17 +0000 (13:29 -0500)]
Fixes for typos. Thank-you PC Oota.
Günther Deschner [Mon, 19 Oct 2009 14:54:37 +0000 (16:54 +0200)]
wbinfo: use wbcLookupDomainControllerEx for wbinfo --dsgetdcname.
Guenther
Günther Deschner [Mon, 19 Oct 2009 14:55:15 +0000 (16:55 +0200)]
libwbclient: fix wbcLookupDomainController().
Found by WINBIND-WBCLIENT torture test.
Guenther
Günther Deschner [Fri, 16 Oct 2009 11:39:24 +0000 (13:39 +0200)]
s4-smbtorture: test wbcLookupDomainController{Ex} in WINBIND-WBCLIENT.
Guenther
Günther Deschner [Mon, 19 Oct 2009 16:41:15 +0000 (18:41 +0200)]
gitignore: remove old netlogon prototypes.
Guenther
Matthias Dieter Wallnöfer [Mon, 19 Oct 2009 16:34:29 +0000 (18:34 +0200)]
s4:torture "cldap" test - restore the removed constraints and add more
Consider for description the post on the technical mailing list. I hope that this
satisfies abartlet again.
Matthias Dieter Wallnöfer [Mon, 19 Oct 2009 16:25:05 +0000 (18:25 +0200)]
s4:password_hash LDB module - substitute "lp_workgroup" with "lp_sam_name"
According to abartlet's response on my post about "lp_workgroup" this should be
the right call.
Andrew Tridgell [Mon, 19 Oct 2009 11:58:23 +0000 (22:58 +1100)]
selftest: try to get the valgrind errors showing again in the build farm
Andrew Tridgell [Mon, 19 Oct 2009 11:47:45 +0000 (22:47 +1100)]
util: fixed generate_unique_strs() to be portable
'place' was going negative, and giving undefined results. The result
was duplicate names which gave errors in SMB2-DIR on PPC and other
systems.
Andrew Tridgell [Mon, 19 Oct 2009 10:37:20 +0000 (21:37 +1100)]
s4-selftest: fixed 'make testenv'
The 'TERM' variable is used for terminal type, so we can't use it for
what terminal to use.
Andrew Tridgell [Mon, 19 Oct 2009 10:36:41 +0000 (21:36 +1100)]
s4-pyldb: fixed 64 bit issues
The python argument parse functions take standard C types, not enums
and time_t. This broken the python interface on PPC.
Andrew Tridgell [Mon, 19 Oct 2009 09:31:40 +0000 (20:31 +1100)]
s4-idmap: the idmap database should be indexed
Andrew Tridgell [Mon, 19 Oct 2009 08:16:39 +0000 (19:16 +1100)]
s4-libnet: fixed privilege handling in samsync to use the right db
I only noticed this one because of Karolins spelling fix :-)
Andrew Tridgell [Mon, 19 Oct 2009 07:46:02 +0000 (18:46 +1100)]
s4-pvfs: fill in alignment_requirement (valgrind error)
Karolin Seeger [Mon, 19 Oct 2009 08:40:15 +0000 (10:40 +0200)]
s4:test: Fix typo.
Karolin
Karolin Seeger [Mon, 19 Oct 2009 07:47:33 +0000 (09:47 +0200)]
Fix typo.
privilage -> privilege
Karolin
Andrew Tridgell [Mon, 19 Oct 2009 03:17:02 +0000 (14:17 +1100)]
Revert "selftest: fixed filter to know about a "error" result"
This reverts commit
1de7e43fb4a4863e3663af8b2a2d9f19cf82d7f3.
This is much more delicate than it seems
Andrew Tridgell [Mon, 19 Oct 2009 02:50:32 +0000 (13:50 +1100)]
s4-selftest: move secdesc.python test to skip list
This test produces a python backtrace due to
LDAP_INSUFFICIENT_ACCESS_RIGHTS errors, which are expected until the
new acl code is finished. The python backtrace overrides the
'knownfail' listing, so we need to skip this test for now.
Andrew Tridgell [Mon, 19 Oct 2009 02:25:55 +0000 (13:25 +1100)]
selftest: fixed filter to know about a "error" result
This is what caused some of the python tests to not match knownfail
entries
Andrew Tridgell [Mon, 19 Oct 2009 02:25:07 +0000 (13:25 +1100)]
s4-test: removed duplicate knownfail entry
Andrew Tridgell [Mon, 19 Oct 2009 01:59:49 +0000 (12:59 +1100)]
s4-pvfs: another uninitialised variable
thanks to valgrind for this one
Bo Yang [Wed, 14 Oct 2009 22:23:48 +0000 (06:23 +0800)]
s3: Don't fail authentication when one or some group of require-membership-of is invalid.
Signed-off-by: Bo Yang <boyang@samba.org>
Andrew Tridgell [Mon, 19 Oct 2009 00:56:53 +0000 (11:56 +1100)]
s4-pvfs: fixed uninitialised variable
This caused havoc on the build farm. Interestingly, it only affected
gcc 4.3.3, not gcc 4.4.1
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 16:13:17 +0000 (18:13 +0200)]
s4:ldb_msg_check_string_attribute - add a comment about the result values
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 16:00:59 +0000 (18:00 +0200)]
Revert "s4:ldb_msg - Use LDB constants on results"
This reverts commit
56a8baff3df6a5120b6c7bbca771dfb7c6934fd5.
Simo pointed out that I was wrong here.
Björn Jacke [Sun, 18 Oct 2009 15:01:57 +0000 (17:01 +0200)]
s3:configure: fix avahi activation
Avahi was correctly found but not activated since
e4a26c942.
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 12:30:50 +0000 (14:30 +0200)]
s4:torture "cldap" test - rework and test more results
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 09:59:11 +0000 (11:59 +0200)]
s4:sites - get the server site (name) from DSDB
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 09:11:57 +0000 (11:11 +0200)]
s4:dcerpc_netlogon - unify the two workstation object lookups (DNS hostname and supported encryption types)
This is simply for better performance (no functional change).
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:26:41 +0000 (22:26 +0200)]
s4:ldb_msg - Use LDB constants on results
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:27:42 +0000 (22:27 +0200)]
s4:ldb_ldap - Fix intendation
Andrew Tridgell [Sun, 18 Oct 2009 05:32:01 +0000 (16:32 +1100)]
s4-test: the ldap secdesc test is expected to fail for now
Nadya, if this is not correct and you think this should be passing
already the please let me know. When I looked over it, it doesn't look
like it has a chance of passing until your acl module is in place and
enabled by default.
Andrew Tridgell [Sun, 18 Oct 2009 04:57:21 +0000 (15:57 +1100)]
s4-test: SMB2 oplocks in s4 are a mess
I don't have time to fix these right now, and as we don't advertise
SMB2 by default I'll mark it as a known failure till we start enabling
SMB2 by default.
Andrew Tridgell [Sun, 18 Oct 2009 04:56:16 +0000 (15:56 +1100)]
s4: spelling error
Andrew Tridgell [Sun, 18 Oct 2009 03:22:42 +0000 (14:22 +1100)]
s4-torture: fixed the streams tests for Samba4
In some cases we were not doing streams tests on s4 that we should. In
others, we were calling tests that are known to fail on s4. Some of
those are a bit puzzling.
Andrew Tridgell [Sun, 18 Oct 2009 03:19:27 +0000 (14:19 +1100)]
s4-streams: fixed handling of stream rename and overwrite
Andrew Tridgell [Sun, 18 Oct 2009 03:15:48 +0000 (14:15 +1100)]
s4-pvfs: rename with full name gives SHARING_VIOLATION
Andrew Tridgell [Sun, 18 Oct 2009 03:14:16 +0000 (14:14 +1100)]
s4-pvfs: when reporting the file name, don't include the :$DATA suffix
Andrew Tridgell [Sun, 18 Oct 2009 03:13:45 +0000 (14:13 +1100)]
s4-pvfs: the STREAM_INFORMATION calls don't need any access flags
Andrew Tridgell [Sun, 18 Oct 2009 01:24:09 +0000 (12:24 +1100)]
s4-pvfs: fixed update of stream sizes
The data_blob_free() was changing the size we set the stream to
Jeremy Allison [Sun, 18 Oct 2009 03:46:22 +0000 (20:46 -0700)]
Fix posix_unlink test. Was doing grep without quotes around the
target string.
Jeremy.
Andrew Tridgell [Sat, 17 Oct 2009 23:32:06 +0000 (10:32 +1100)]
s4-pvfs: more fixes for ACLs on file creation
The passed in SD is not used to limit the access mask allowed on file
create.
Andrew Tridgell [Sat, 17 Oct 2009 23:30:10 +0000 (10:30 +1100)]
s4-smb2: fixed SMB2 find commands
The change to check for invalid \ prefix on SMB2 paths broke the
internal SMB2 code.
Andrew Tridgell [Sat, 17 Oct 2009 10:17:29 +0000 (21:17 +1100)]
s4-pvfs: change the handling of access checking on create
Previously when a file was created, we produces the resulting access
mask based on an ACL check against the parent. This change means we
now calculate the inherited ACL much earlier, and produce the
resulting access mask from that ACL, or the user supplied ACL.
Andrew Tridgell [Sat, 17 Oct 2009 10:14:59 +0000 (21:14 +1100)]
smb2-torture: samba4 allows SEC_FLAG_SECURITY to be used with privileges
Andrew Tridgell [Sat, 17 Oct 2009 09:10:03 +0000 (20:10 +1100)]
s4: fixed howto for new binary name
Jeremy Allison [Sat, 17 Oct 2009 19:56:15 +0000 (12:56 -0700)]
Fix the smbtorture4 build. root_fid is a "union smb_handle". tridge
please check.
Jeremy.
Jeremy Allison [Sat, 17 Oct 2009 17:38:44 +0000 (10:38 -0700)]
Trying to find out why the posix_unlink test build farm is still failing even
though we're now successfully deleting the symlink.
Jeremy.
Jeremy Allison [Sat, 17 Oct 2009 17:36:33 +0000 (10:36 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Volker Lendecke [Sat, 17 Oct 2009 15:00:13 +0000 (17:00 +0200)]
s3:winbind: Move fillup_pw_field() as static to wb_fill_pwent.c
Andrew Tridgell [Sat, 17 Oct 2009 02:12:24 +0000 (13:12 +1100)]
s4-smbserver: removed bogus initialisation of two union arms
Thanks to Metze for spotting this.
Andrew Tridgell [Sat, 17 Oct 2009 01:58:17 +0000 (12:58 +1100)]
s4-pvfs: when uwrap is enabled, ignore chown errors
chown is expected to fail under uwrap
Andrew Tridgell [Sat, 17 Oct 2009 01:50:51 +0000 (12:50 +1100)]
s4-torture: fixed the default ACL for s4
s4 returns group and world ACEs in the default acl, based on unix
permissions
Andrew Tridgell [Fri, 16 Oct 2009 23:54:46 +0000 (10:54 +1100)]
s4-torture: minor debugging enhancements
Andrew Tridgell [Fri, 16 Oct 2009 23:50:08 +0000 (10:50 +1100)]
s4-schema: We should not need Samba4TopExtra now
The last attribute this contained was 'privilege' which is now gone
Andrew Tridgell [Fri, 16 Oct 2009 22:09:42 +0000 (09:09 +1100)]
s4-pvfs: don't auto-apply privilege bits in unix acl handling either
Andrew Tridgell [Fri, 16 Oct 2009 22:09:19 +0000 (09:09 +1100)]
s4-acl: SEC_FLAG_MAXIMUM_ALLOWED doesn't auto-apply privilege access masks
Andrew Tridgell [Fri, 16 Oct 2009 12:06:02 +0000 (23:06 +1100)]
s4-torture: the BASE-CREATEX_ACCESS test is broken for non-administrators
See my msg to samba-technical about this test and privilege testing.
Andrew Tridgell [Fri, 16 Oct 2009 12:04:01 +0000 (23:04 +1100)]
s4-torture: cleanup after the MAXIMUM_ALLOWED test
Andrew Tridgell [Fri, 16 Oct 2009 12:03:42 +0000 (23:03 +1100)]
s4-pvfs: use privileges rather than "uid == 0" in unix access check
This makes the unix access check much closer to the full ACL check