Bill Meier [Tue, 24 Mar 2009 17:00:53 +0000 (17:00 -0000)]
From David Castleford: ismacrypt dissector
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3009)
svn path=/trunk/; revision=27840
Balint Reczey [Tue, 24 Mar 2009 11:54:56 +0000 (11:54 -0000)]
Removed code duplication in ASCII key computation.
svn path=/trunk/; revision=27839
Tomas Kukosa [Tue, 24 Mar 2009 07:01:22 +0000 (07:01 -0000)]
add native-nmake.cmd into EXTRA_DIST
svn path=/trunk/; revision=27838
Martin Mathieson [Mon, 23 Mar 2009 22:16:25 +0000 (22:16 -0000)]
Add CRC error flag to frames, and show in stats window.
svn path=/trunk/; revision=27837
Anders Broman [Mon, 23 Mar 2009 21:24:04 +0000 (21:24 -0000)]
From Michael Lum:
ANSI MAP FeatureRequest update
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3349
svn path=/trunk/; revision=27836
Balint Reczey [Mon, 23 Mar 2009 18:14:28 +0000 (18:14 -0000)]
Fix ASCII key computation.
This fixes bug 2943 thus allows ESP decoding again, which was
broken since r25264.
svn path=/trunk/; revision=27835
Anders Broman [Mon, 23 Mar 2009 17:33:20 +0000 (17:33 -0000)]
Get rid of another Clist.
svn path=/trunk/; revision=27834
Anders Broman [Mon, 23 Mar 2009 17:32:39 +0000 (17:32 -0000)]
Some updates and bug fixes.
svn path=/trunk/; revision=27833
Anders Broman [Mon, 23 Mar 2009 17:31:50 +0000 (17:31 -0000)]
Update to the 200903 release.
svn path=/trunk/; revision=27832
Anders Broman [Mon, 23 Mar 2009 17:30:38 +0000 (17:30 -0000)]
Fix: The AuthDir invoke is missing optional tags for a couple of parameters.
and FeatReq invoke fixes.
svn path=/trunk/; revision=27831
Stig Bjørlykke [Mon, 23 Mar 2009 13:31:04 +0000 (13:31 -0000)]
Fixed some data types to remove some warnings.
svn path=/trunk/; revision=27830
Stig Bjørlykke [Mon, 23 Mar 2009 13:15:56 +0000 (13:15 -0000)]
Fixed some data types to remove some warnings.
svn path=/trunk/; revision=27829
Stig Bjørlykke [Mon, 23 Mar 2009 13:13:05 +0000 (13:13 -0000)]
Fixed some data types to remove some warnings.
svn path=/trunk/; revision=27828
Stig Bjørlykke [Mon, 23 Mar 2009 13:03:18 +0000 (13:03 -0000)]
Removed some "statement not reached" warnings.
svn path=/trunk/; revision=27827
Stig Bjørlykke [Mon, 23 Mar 2009 12:44:50 +0000 (12:44 -0000)]
Removed some "initializer does not fit or is out of range" warnings.
svn path=/trunk/; revision=27826
Stig Bjørlykke [Mon, 23 Mar 2009 12:41:56 +0000 (12:41 -0000)]
Fixed some data types to remove some warnings in the solaris build.
svn path=/trunk/; revision=27825
Bill Meier [Sun, 22 Mar 2009 22:15:23 +0000 (22:15 -0000)]
P64 change
svn path=/trunk/; revision=27824
Anders Broman [Sun, 22 Mar 2009 21:20:56 +0000 (21:20 -0000)]
Dissect all the ESM messages.
svn path=/trunk/; revision=27823
Bill Meier [Sun, 22 Mar 2009 20:55:31 +0000 (20:55 -0000)]
P64 changes: Fix some cases for which size_t is not required
svn path=/trunk/; revision=27822
Guy Harris [Sun, 22 Mar 2009 18:06:06 +0000 (18:06 -0000)]
Sigh.
dladdr() in GNU libc isn't available (<dlfcn.h> doesn't define Dl_info)
unless _GNU_SOURCE is defined.
In addition, it's not guaranteed to return anything more useful than
argv[0]; just in case that changes at some point in the future, however,
we still use it, we just run it through the same machinery that we run
argv[0] through. (On Mac OS X, for example, the path of the executable
is handed to the run-time linker by the kernel, so it *is* useful
there.)
svn path=/trunk/; revision=27821
Bill Meier [Sun, 22 Mar 2009 16:25:01 +0000 (16:25 -0000)]
(Minor) Change a g_snprint to a g_strlcpy;
Also: Fix an off-by-1 inadvertantly introduced a while back.
svn path=/trunk/; revision=27820
Bill Meier [Sun, 22 Mar 2009 15:42:03 +0000 (15:42 -0000)]
g_snprintf() & etc since glib 1.3.12 don't return -1,
and also always NUL terminate the string.
svn path=/trunk/; revision=27819
Bill Meier [Sun, 22 Mar 2009 15:31:44 +0000 (15:31 -0000)]
From Jakub Zawadzki: g_snprintf() & etc since glib 1.3.12
don't return -1, and also always NUL terminate the string.
We can clean sources by removing dead/unnecessary code.
From me: A few additional changes re use of g_snprintf.
svn path=/trunk/; revision=27818
Gerald Combs [Sun, 22 Mar 2009 15:03:23 +0000 (15:03 -0000)]
[Automatic manuf update for 2009-03-22]
svn path=/trunk/; revision=27816
Guy Harris [Sun, 22 Mar 2009 06:53:17 +0000 (06:53 -0000)]
Change the signature of init_progfile_dir() so the casting of the
function pointer (to main) to an argument to dladdr() is done in
init_progfile_dir() rather than its callers.
svn path=/trunk/; revision=27814
Guy Harris [Sun, 22 Mar 2009 06:38:02 +0000 (06:38 -0000)]
In Solaris, the second argument to dladdr() is just a void *, not a
const void *.
svn path=/trunk/; revision=27813
Guy Harris [Sun, 22 Mar 2009 00:42:33 +0000 (00:42 -0000)]
Attempt to use dladdr() to get the pathname of the executable image if
it's available and works.
svn path=/trunk/; revision=27812
Guy Harris [Fri, 20 Mar 2009 23:20:45 +0000 (23:20 -0000)]
proto_item_append_string() actually appends to the string value for a
protocol tree item; the item being added to isn't a string, so
proto_item_append_text() should be used - but the second argument to
proto_item_append_text() should always be a format string.
Use #if 0/#endif to leave a data structure in the source code without
compiling it in, rather than a comment (if you use a comment, things can
break if you put a comment into the commented-out code).
svn path=/trunk/; revision=27811
Gerald Combs [Fri, 20 Mar 2009 23:15:15 +0000 (23:15 -0000)]
Switch back to 1.1.4.
svn path=/trunk/; revision=27810
Martin Mathieson [Fri, 20 Mar 2009 22:39:29 +0000 (22:39 -0000)]
Fix broken linux build.
svn path=/trunk/; revision=27809
Anders Broman [Fri, 20 Mar 2009 20:15:46 +0000 (20:15 -0000)]
Further NAS updates.
svn path=/trunk/; revision=27808
Gerald Combs [Fri, 20 Mar 2009 16:17:02 +0000 (16:17 -0000)]
Temporarily switch back to building 1.1.3 final.
svn path=/trunk/; revision=27807
Stig Bjørlykke [Fri, 20 Mar 2009 12:41:03 +0000 (12:41 -0000)]
Put check_col() in each column util function, as discussed in bug 2902.
This will eliminate some problems when not checking before calling the
functions, and makes the dissector code looks cleaner.
Cleaning up the dissectors is TBD.
svn path=/trunk/; revision=27806
Stig Bjørlykke [Fri, 20 Mar 2009 11:06:20 +0000 (11:06 -0000)]
From Dejan Bucar (bug 3345):
Added official LINX Ethernet type.
svn path=/trunk/; revision=27804
Ulf Lamping [Fri, 20 Mar 2009 10:44:42 +0000 (10:44 -0000)]
remove GPLv2 CRC code, the new epan CRC stuff is working well
svn path=/trunk/; revision=27803
Anders Broman [Thu, 19 Mar 2009 22:03:33 +0000 (22:03 -0000)]
More NAS EPS updates and bugfixes.
svn path=/trunk/; revision=27802
Anders Broman [Thu, 19 Mar 2009 22:02:46 +0000 (22:02 -0000)]
Revert the previous changes MCC and MNC are coded differently in different places.
svn path=/trunk/; revision=27801
Bill Meier [Thu, 19 Mar 2009 17:49:11 +0000 (17:49 -0000)]
As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
svn path=/trunk/; revision=27800
Bill Meier [Thu, 19 Mar 2009 17:47:00 +0000 (17:47 -0000)]
-As suggested by Jakub Zawadzki: use sizeof(...) rather than a numeric constant in various places;
Also:
- Change indentation to be consistent;
svn path=/trunk/; revision=27799
Bill Meier [Thu, 19 Mar 2009 17:44:57 +0000 (17:44 -0000)]
-As suggested by Jakub Zawadzki: use sizeof(...) rather than a numeric constant in various places;
Also:
- Change ct_port_to_str to be slightly simpler and more efficient;
- Change indentation to be consistent;
svn path=/trunk/; revision=27798
Gerald Combs [Thu, 19 Mar 2009 17:40:18 +0000 (17:40 -0000)]
Add an expert item for the seconds-encoded-as-little-endian bug.
svn path=/trunk/; revision=27797
Anders Broman [Thu, 19 Mar 2009 06:42:46 +0000 (06:42 -0000)]
Use GTK 2.16 and glib 2.20.
svn path=/trunk/; revision=27796
Anders Broman [Thu, 19 Mar 2009 06:41:41 +0000 (06:41 -0000)]
From Michael Lum:
MEID digit translation fix.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3341
svn path=/trunk/; revision=27795
Bill Meier [Thu, 19 Mar 2009 01:54:09 +0000 (01:54 -0000)]
- Move register_dissector(...) from proto_reg_handoff() to proto_register();
- Use dissector_add_handle("udp",...) rather than dissector_add(""udp",0,...)
svn path=/trunk/; revision=27794
Guy Harris [Thu, 19 Mar 2009 00:05:26 +0000 (00:05 -0000)]
Don't include <stdint.h>, as our Win32 environment appears not to have
it; we're using GLib types, instead.
svn path=/trunk/; revision=27793
Guy Harris [Wed, 18 Mar 2009 23:30:21 +0000 (23:30 -0000)]
Clean up indentation.
Note that -5047 can also mean "disk quota exceeded".
Define the ASP errors as 32-bit (negative) numbers, just like the AFP
errors.
Add a couple of ASP errors to the list of error values.
svn path=/trunk/; revision=27792
Stig Bjørlykke [Wed, 18 Mar 2009 23:06:08 +0000 (23:06 -0000)]
Removed C++ style comments.
svn path=/trunk/; revision=27791
Gerald Combs [Wed, 18 Mar 2009 21:59:30 +0000 (21:59 -0000)]
Create an "epan/crc" directory for CRC code. Add crc-16-plain.[ch],
generated from pycrc. The command line used to generate the file is in
epan/crc/Makefile.common. I used "plain" to distinguish it from CCITT,
USB, and other 16-bit CRCs. Integrate the new CRC code into our
infrastructure.
Add crc16_plain_tvb_offset() to epan/crc16.[ch] and use it in
plugins/profinet/packet-pn-rt.c. This _should_ work correctly, but
hasn't been tested.
svn path=/trunk/; revision=27790
Guy Harris [Wed, 18 Mar 2009 21:40:04 +0000 (21:40 -0000)]
Don't g_assert() in a dissector, just drive on.
Use ws_fopen(), not fopen(), to open files.
svn path=/trunk/; revision=27789
Guy Harris [Wed, 18 Mar 2009 21:37:56 +0000 (21:37 -0000)]
Don't g_assert() in a dissector; just drive on.
svn path=/trunk/; revision=27788
Guy Harris [Wed, 18 Mar 2009 20:56:21 +0000 (20:56 -0000)]
None of those strings will have a length that doesn't fit in a gulong.
svn path=/trunk/; revision=27787
Guy Harris [Wed, 18 Mar 2009 20:54:28 +0000 (20:54 -0000)]
Get rid of a bunch of uses of size_t where int suffices.
svn path=/trunk/; revision=27786
Guy Harris [Wed, 18 Mar 2009 20:48:42 +0000 (20:48 -0000)]
Squelch a P64 warning.
svn path=/trunk/; revision=27785
Guy Harris [Wed, 18 Mar 2009 20:47:22 +0000 (20:47 -0000)]
Get rid of P64 warnings; those strings should never be longer than 2^31-1.
svn path=/trunk/; revision=27784
Guy Harris [Wed, 18 Mar 2009 20:45:57 +0000 (20:45 -0000)]
Use g_strreverse() to reverse strings.
svn path=/trunk/; revision=27783
Guy Harris [Wed, 18 Mar 2009 20:42:59 +0000 (20:42 -0000)]
Get rid of some P64 warnings; those lengths should never be > 2^31-1.
svn path=/trunk/; revision=27782
Guy Harris [Wed, 18 Mar 2009 20:41:45 +0000 (20:41 -0000)]
Get rid of uses of size_t; they're not necessary, and it causes a pile
of 64-bit-to-32-bit conversion warnings in LLP64 environments such as
Win64.
svn path=/trunk/; revision=27781
Richard van der Hoff [Wed, 18 Mar 2009 20:31:15 +0000 (20:31 -0000)]
improve dissection of optional parameters. In particular, make the tag and length fields explicit.
svn path=/trunk/; revision=27780
Richard van der Hoff [Wed, 18 Mar 2009 20:30:35 +0000 (20:30 -0000)]
fix unused parameter warning
svn path=/trunk/; revision=27779
Anders Broman [Wed, 18 Mar 2009 19:40:54 +0000 (19:40 -0000)]
- Fix APDU dissection.
- NAS EPS bugfixes and enhancements.
svn path=/trunk/; revision=27778
Gerald Combs [Wed, 18 Mar 2009 17:05:41 +0000 (17:05 -0000)]
Fix the Lua path on Win64.
svn path=/trunk/; revision=27777
Martin Mathieson [Wed, 18 Mar 2009 16:21:45 +0000 (16:21 -0000)]
Use retx info in stats window.
User guide help not added yet, as having trouble building...
svn path=/trunk/; revision=27776
Bill Meier [Wed, 18 Mar 2009 15:35:55 +0000 (15:35 -0000)]
From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
From me:
- As suggested by Jakub actually use sizeof(...) rather than a numeric constant
in various places;
svn path=/trunk/; revision=27775
Martin Mathieson [Wed, 18 Mar 2009 15:35:45 +0000 (15:35 -0000)]
Allow a lot more than 32 subheaders.
svn path=/trunk/; revision=27774
Bill Meier [Wed, 18 Mar 2009 15:25:19 +0000 (15:25 -0000)]
From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
From me:
- As suggested by Jakub actually use sizeof(...) rather than a numeric constant
in various places;
- Use #if 0 rather than /* */ to comment out code;
- Fix indentation to be consistent.
svn path=/trunk/; revision=27773
Bill Meier [Wed, 18 Mar 2009 15:03:46 +0000 (15:03 -0000)]
From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
- As suggested actually use sizeof(...) rather than a numeric constant.
- g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.
svn path=/trunk/; revision=27772
Bill Meier [Wed, 18 Mar 2009 14:44:15 +0000 (14:44 -0000)]
From Jakub Zawadzki: Use size of buffer [not size -1];
Also: as suggested actually use sizeof() rather than a constant.
From me:
-Rework hostlist_port_to_str slightly to be simpler and
more efficient;
-Fix indentation to be consistent.
svn path=/trunk/; revision=27771
Anders Broman [Wed, 18 Mar 2009 07:36:53 +0000 (07:36 -0000)]
From Munenori Ohuchi:
Enhacement to support 'WiMAX Forum/3GPP2 Proxy Mobile IPv4'.
svn path=/trunk/; revision=27770
Anders Broman [Wed, 18 Mar 2009 07:31:35 +0000 (07:31 -0000)]
From Bjørn Mork:
Decode ipv6prefix attributes in packet-radius.
svn path=/trunk/; revision=27769
Anders Broman [Wed, 18 Mar 2009 07:29:36 +0000 (07:29 -0000)]
From Patrick A Baldwin:
Enhancements for CCSDS Dissectors.
svn path=/trunk/; revision=27768
Gerald Combs [Wed, 18 Mar 2009 05:42:03 +0000 (05:42 -0000)]
Move to 1.1.4.
svn path=/trunk/; revision=27767
Bill Meier [Wed, 18 Mar 2009 00:03:41 +0000 (00:03 -0000)]
From Jakub Zawadzki: Glib2 g_snprintf doesn't return -1;
Also: from me: fix an "off by 1" issue in inet_ntop_4
which could result in a trailing character of the
output string being truncated rather than an ENOSPC
error being reported.
svn path=/trunk/; revision=27766
Gerald Combs [Tue, 17 Mar 2009 23:26:55 +0000 (23:26 -0000)]
Build 1.1.3.
svn path=/trunk/; revision=27765
Anders Broman [Tue, 17 Mar 2009 21:33:15 +0000 (21:33 -0000)]
Revert the changes, it blows up when resizeing windows...
svn path=/trunk/; revision=27764
Anders Broman [Tue, 17 Mar 2009 20:32:19 +0000 (20:32 -0000)]
Yet another typo..
*sigh
svn path=/trunk/; revision=27763
Anders Broman [Tue, 17 Mar 2009 20:21:16 +0000 (20:21 -0000)]
Use GTK 2.16 and glib 2.20.
svn path=/trunk/; revision=27762
Anders Broman [Tue, 17 Mar 2009 20:20:36 +0000 (20:20 -0000)]
Fix a typo.
svn path=/trunk/; revision=27761
Guy Harris [Tue, 17 Mar 2009 19:37:10 +0000 (19:37 -0000)]
Clean up indentation.
Cast the num_msus and num_bytes values to double before dividing them by
the appropriate divisor, to make sure the division is done in floating
point; that's only necessary in one case (when dividing by an integer),
but we do it in all cases for regularity.
g_strdup_printf() g_mallocs the string; use g_strdup() for the
zero-divisor case, so that the string is g_mallocated in all cases.
Note in a comment that they need to be freed.
Make the array to which the strings in question are allocated arrays of
"char *" rather than "const char *", to catch cases where a constant
string is assigned to them.
svn path=/trunk/; revision=27760
Bill Meier [Tue, 17 Mar 2009 19:30:58 +0000 (19:30 -0000)]
(Minor): Remove some unneccessary code; Fix a typo;
svn path=/trunk/; revision=27759
Bill Meier [Tue, 17 Mar 2009 19:28:05 +0000 (19:28 -0000)]
Add a comment about the way g_snprintf is used.
svn path=/trunk/; revision=27758
Anders Broman [Tue, 17 Mar 2009 18:36:00 +0000 (18:36 -0000)]
Get rid of another Clist.
svn path=/trunk/; revision=27757
Bill Meier [Tue, 17 Mar 2009 18:13:44 +0000 (18:13 -0000)]
Add a comment about the way g_snprintf() is used.
svn path=/trunk/; revision=27756
Gerald Combs [Tue, 17 Mar 2009 16:05:07 +0000 (16:05 -0000)]
Don't compile with -WX for flex-generated output, similar to what we do in
wiretap/Makefile.nmake.
svn path=/trunk/; revision=27755
Bill Meier [Tue, 17 Mar 2009 15:39:07 +0000 (15:39 -0000)]
Do checkAPIs for wireshark_SOURCES
svn path=/trunk/; revision=27754
Bill Meier [Tue, 17 Mar 2009 15:34:18 +0000 (15:34 -0000)]
Use smiFree for libsmi >= v 0.4.8; Also: sprintf->g_snprintf
svn path=/trunk/; revision=27753
Anders Broman [Tue, 17 Mar 2009 05:56:59 +0000 (05:56 -0000)]
Commited by mistake, reverting.
svn path=/trunk/; revision=27752
Bill Meier [Tue, 17 Mar 2009 01:47:20 +0000 (01:47 -0000)]
sprintf --> g_snprintf
svn path=/trunk/; revision=27751
Guy Harris [Tue, 17 Mar 2009 00:13:59 +0000 (00:13 -0000)]
Update the comment about Ross Williams' paper.
svn path=/trunk/; revision=27750
Ulf Lamping [Mon, 16 Mar 2009 22:36:34 +0000 (22:36 -0000)]
fix type
svn path=/trunk/; revision=27749
Ulf Lamping [Mon, 16 Mar 2009 21:40:00 +0000 (21:40 -0000)]
update to the latest PROTINET changes:
- add SubFrameBlock dissection
- add subframe heuristics and dissection
- update frame id "layout"
- raise plugin version to 0.2.4
crc16 algorithm copied from Linux sources (GPL V2 only!)
svn path=/trunk/; revision=27748
Guy Harris [Mon, 16 Mar 2009 21:17:53 +0000 (21:17 -0000)]
Fix syntax error.
svn path=/trunk/; revision=27747
Bill Meier [Mon, 16 Mar 2009 19:43:45 +0000 (19:43 -0000)]
Replace use of unneccessary (and deprecated) GtkCtree.
svn path=/trunk/; revision=27746
Bill Meier [Mon, 16 Mar 2009 19:34:02 +0000 (19:34 -0000)]
Hack toprevent checkAPIs complaining about use of 'free'
svn path=/trunk/; revision=27745
Bill Meier [Mon, 16 Mar 2009 19:30:25 +0000 (19:30 -0000)]
strcpy-->g-strlcpy; Also: Add $Id$
svn path=/trunk/; revision=27744
Bill Meier [Mon, 16 Mar 2009 19:02:18 +0000 (19:02 -0000)]
[Trivial] fix some wording in a comment
svn path=/trunk/; revision=27743
Michael Tüxen [Mon, 16 Mar 2009 18:26:37 +0000 (18:26 -0000)]
Fix compilation: Mark unused arg as _U_.
svn path=/trunk/; revision=27742
Anders Broman [Mon, 16 Mar 2009 18:01:25 +0000 (18:01 -0000)]
Get rid of Clists, move a comment, move display as hex to gui_utils.
svn path=/trunk/; revision=27741
Guy Harris [Mon, 16 Mar 2009 16:49:47 +0000 (16:49 -0000)]
Get rid of unused routine (which gets errors when compiled on Win64).
svn path=/trunk/; revision=27740
Martin Mathieson [Mon, 16 Mar 2009 15:39:52 +0000 (15:39 -0000)]
Add a ReTX count (resends being caused by HARQ NACKs).
svn path=/trunk/; revision=27739
Bill Meier [Mon, 16 Mar 2009 14:32:01 +0000 (14:32 -0000)]
Use g_malloc instead of malloc.
svn path=/trunk/; revision=27738