Anders Broman [Thu, 2 Apr 2009 17:12:44 +0000 (17:12 -0000)]
Yin Sun:
tipc v1 improvement.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3381
svn path=/trunk/; revision=27932
Anders Broman [Thu, 2 Apr 2009 17:04:04 +0000 (17:04 -0000)]
Remove #if 0
svn path=/trunk/; revision=27931
Gerald Combs [Thu, 2 Apr 2009 03:55:37 +0000 (03:55 -0000)]
From Peter Hertting: Fix the maximum poll interval.
svn path=/trunk/; revision=27930
Gerald Combs [Thu, 2 Apr 2009 03:51:42 +0000 (03:51 -0000)]
Fix a typo.
svn path=/trunk/; revision=27929
Gerald Combs [Thu, 2 Apr 2009 03:44:00 +0000 (03:44 -0000)]
The format argument of val_to_str() formats a guint32, not a char *. Fixes
bug 3383.
svn path=/trunk/; revision=27928
Guy Harris [Wed, 1 Apr 2009 20:52:53 +0000 (20:52 -0000)]
Describe the format of libpcap records a little better - no, it's not
valid C89, but it's more accurate (and lets you know that the packet
data has only caplen bytes).
Fix up a list.
svn path=/trunk/; revision=27925
Anders Broman [Wed, 1 Apr 2009 16:22:51 +0000 (16:22 -0000)]
Add to new functions from the optimization patch:
tvb_child_uncompress()
tvb_new_child_real_data()
svn path=/trunk/; revision=27924
Anders Broman [Wed, 1 Apr 2009 16:21:00 +0000 (16:21 -0000)]
According to the section 2.4 of the spec.
http://www.3gpp2.org/Public_html/specs/X.S0004-540-E_v2.0_070723.pdf
mandatory parameters for the message Authentication Failure Report.
1. Electronic serial number
2. MSID(i.e MIN/IMSI)
3.Report Type
4.System Access Type
5.System Capabilities(Serving)
svn path=/trunk/; revision=27923
Bill Meier [Wed, 1 Apr 2009 13:22:07 +0000 (13:22 -0000)]
From Abhik Sarkar: SMPP TLV tag value_strings.
"I have chosen _not_ to use the value_string array in the header field for the
tag because the information appears in too many places - once in the sub-tree
and again once in the field which displays the value. Displaying the tag name
again in the tag field would make the same information appear three times in
four lines."
See Bug #3369 [https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3369]
From me: Use consistent indentation throughout packet-smpp.c
svn path=/trunk/; revision=27922
Guy Harris [Wed, 1 Apr 2009 04:01:13 +0000 (04:01 -0000)]
The second argument to Gestalt() is an SInt32, which, for backwards
compatibility reasons, is a long rather than an int in ILP32 mode
(probably dating back to the old 68000 days, when 32-bit arithmetic was
slower than 16-bit arithmetic, so an int was 16 bits and a long 32 bits
on some 68K machines) and is an int in LP64 mode.
svn path=/trunk/; revision=27921
Gerald Combs [Wed, 1 Apr 2009 00:30:45 +0000 (00:30 -0000)]
Only #undef inet_aton if we're using ADNS on Windows.
svn path=/trunk/; revision=27920
Gerald Combs [Tue, 31 Mar 2009 23:38:31 +0000 (23:38 -0000)]
Rawshark fixes from Duncan Salerno.
svn path=/trunk/; revision=27919
Gerald Combs [Tue, 31 Mar 2009 22:51:59 +0000 (22:51 -0000)]
Add a check to make sure we don't try to allocate a huge buffer. If
we get an improper buffer length, throw an error instead of
aborting. Clean up the debugging code.
svn path=/trunk/; revision=27918
Bill Meier [Tue, 31 Mar 2009 21:47:58 +0000 (21:47 -0000)]
Change to prevent "off-the-end" array access if invalid payload-type/media-format;
Prevents crash as reported in bug 3373:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3373)
svn path=/trunk/; revision=27917
Anders Broman [Tue, 31 Mar 2009 18:52:36 +0000 (18:52 -0000)]
Update value strings.
svn path=/trunk/; revision=27916
Anders Broman [Tue, 31 Mar 2009 18:51:59 +0000 (18:51 -0000)]
Fix a typo.
svn path=/trunk/; revision=27915
Guy Harris [Tue, 31 Mar 2009 18:09:24 +0000 (18:09 -0000)]
Make the forward declaration of dissect_snmp() match the definition.
svn path=/trunk/; revision=27914
Martin Mathieson [Tue, 31 Mar 2009 17:31:07 +0000 (17:31 -0000)]
Fix gcc 3.4.6 warning about setjmp/longjmp.
svn path=/trunk/; revision=27913
Bill Meier [Tue, 31 Mar 2009 15:33:15 +0000 (15:33 -0000)]
If GLib < 2.10.0 use g_mem_chunk instead of g_slice.
svn path=/trunk/; revision=27912
Bill Meier [Tue, 31 Mar 2009 12:08:44 +0000 (12:08 -0000)]
#include reassemble.h not req'd
svn path=/trunk/; revision=27911
Bill Meier [Tue, 31 Mar 2009 12:05:48 +0000 (12:05 -0000)]
#include reassemble.h not req'd; Also: move proto_register... & etc to be last in file.
svn path=/trunk/; revision=27910
Bill Meier [Tue, 31 Mar 2009 11:59:59 +0000 (11:59 -0000)]
From: yami <yamisoe [AT] gmail.com>: Update comment in .c file; copy same to .h file
svn path=/trunk/; revision=27909
Guy Harris [Tue, 31 Mar 2009 07:10:17 +0000 (07:10 -0000)]
Get rid of val_to_strlen() - strlen() on the results of val_to_str()
suffices (and 100 is an odd choice of failure), and it shouldn't return
a guint8 in any case.
Don't use tvb_length() to determine how big a packet is - you want the
real size, not the possibly-shortened-by-a-snapshot-length size.
Don't make things guint8 if they're not guaranteed to be one byte long.
Use an ep_strbuf in another case.
svn path=/trunk/; revision=27908
Anders Broman [Tue, 31 Mar 2009 05:44:48 +0000 (05:44 -0000)]
From Vincent Helfre:
Fix unaligned bitfields.
svn path=/trunk/; revision=27907
Anders Broman [Mon, 30 Mar 2009 22:38:56 +0000 (22:38 -0000)]
Dissect security protected NAS message(un ciphered).
svn path=/trunk/; revision=27906
Bill Meier [Mon, 30 Mar 2009 21:59:31 +0000 (21:59 -0000)]
Fix bug: ptr to an ep str kept for use while capture file open.
svn path=/trunk/; revision=27905
Jörg Mayer [Mon, 30 Mar 2009 21:55:22 +0000 (21:55 -0000)]
Andreas Schuler:
add framenumber, extended fixed part capabilities and higher
layer capabilities
Me;
- replace div by crc to fix a shadowed global variable
- the last argument to proto_tree_add_item is the endianess
indicator, not the value
- replace // by /* */
svn path=/trunk/; revision=27904
Gerald Combs [Mon, 30 Mar 2009 20:52:25 +0000 (20:52 -0000)]
More Win64 fixes.
svn path=/trunk/; revision=27903
Jaap Keuter [Mon, 30 Mar 2009 20:05:42 +0000 (20:05 -0000)]
Change of metatech email address.
svn path=/trunk/; revision=27902
Anders Broman [Mon, 30 Mar 2009 20:03:04 +0000 (20:03 -0000)]
Extention and bug fixes.
svn path=/trunk/; revision=27901
Gerald Combs [Mon, 30 Mar 2009 19:39:01 +0000 (19:39 -0000)]
Fixup whitespace.
svn path=/trunk/; revision=27900
Gerald Combs [Mon, 30 Mar 2009 19:38:47 +0000 (19:38 -0000)]
Call ep_strbuf_append_printf() from ep_strbuf_append().
svn path=/trunk/; revision=27899
Anders Broman [Mon, 30 Mar 2009 19:00:00 +0000 (19:00 -0000)]
More size_t casts(Unfinished)
svn path=/trunk/; revision=27898
Gerald Combs [Mon, 30 Mar 2009 18:40:33 +0000 (18:40 -0000)]
More size_t casts.
svn path=/trunk/; revision=27897
Gerald Combs [Mon, 30 Mar 2009 17:53:41 +0000 (17:53 -0000)]
In packet-enttec.c and packet-fw1.c, replace string pointer tracking with a
string buffer. In packet-ftp.c and packet-gift.c, cast some size_t's.
svn path=/trunk/; revision=27896
Gerald Combs [Mon, 30 Mar 2009 17:24:50 +0000 (17:24 -0000)]
Replace another string pointer dance with a string buffer.
svn path=/trunk/; revision=27895
Anders Broman [Mon, 30 Mar 2009 16:35:58 +0000 (16:35 -0000)]
Handle NAL-unit start code correctly.
svn path=/trunk/; revision=27894
Bill Meier [Mon, 30 Mar 2009 11:57:14 +0000 (11:57 -0000)]
From Jens Steinhauser: IEEE C37.118 Synchrophasor dissector
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2798
Committed with minor changes:
- Add the standard Wireshark copyright lines
[Wireshark ... Copyright 1998 Gerald Combs]
- Move proto_register... and proto_reg_handoff... to
the end of the file as per the usual Wireshark
dissector file format.
svn path=/trunk/; revision=27893
Martin Mathieson [Mon, 30 Mar 2009 09:34:15 +0000 (09:34 -0000)]
Initialise a variable to prevent a warning (that looks invalid to me).
svn path=/trunk/; revision=27892
Gerald Combs [Mon, 30 Mar 2009 03:40:12 +0000 (03:40 -0000)]
Add a couple of size_t casts to packet-dnp.c.
Make the length arguments of format_text() and format_text_wsp()
size_t's, since it's natural to use strlen() for that.
svn path=/trunk/; revision=27891
Bill Meier [Sun, 29 Mar 2009 22:16:26 +0000 (22:16 -0000)]
Define certain fcns as static (if not used externally).
Also: whiule we're at it:
- fix hf[] blurbs as appropriate to use NULL;
- fix some indentation
svn path=/trunk/; revision=27890
Anders Broman [Sun, 29 Mar 2009 21:59:28 +0000 (21:59 -0000)]
Handle the case when FMTP parameters are "out-of-order".
- - Use NULL instead of repeated text in blurb in hf[];
svn path=/trunk/; revision=27889
Anders Broman [Sun, 29 Mar 2009 21:20:15 +0000 (21:20 -0000)]
More size_t casts.
svn path=/trunk/; revision=27888
Anders Broman [Sun, 29 Mar 2009 18:26:06 +0000 (18:26 -0000)]
More size_t casts.
svn path=/trunk/; revision=27887
Anders Broman [Sun, 29 Mar 2009 16:08:17 +0000 (16:08 -0000)]
- Dissect Supplemental enhancement information (SEI).
- Use NULL instead of repeated text in blurb in hf[];
svn path=/trunk/; revision=27886
Bill Meier [Sun, 29 Mar 2009 15:34:26 +0000 (15:34 -0000)]
Fix code so changing port pref will work + other small changes:
- Use NULL instead of "" in blurb in hf[];
- Remove unnecessary #includes;
- Make various internal functions static;
- Use tabs consistently for indentation;
- Some reformatting of statements;
svn path=/trunk/; revision=27885
Gerald Combs [Sun, 29 Mar 2009 15:03:32 +0000 (15:03 -0000)]
[Automatic manuf update for 2009-03-29]
svn path=/trunk/; revision=27883
Anders Broman [Sun, 29 Mar 2009 14:37:57 +0000 (14:37 -0000)]
More size_t casts.
svn path=/trunk/; revision=27882
Anders Broman [Sun, 29 Mar 2009 14:16:37 +0000 (14:16 -0000)]
Fix:
packet-ldss.c: In function 'dissect_ldss_transfer':
packet-ldss.c:469: warning: 'ldss_tree' may be used uninitialized in this function
packet-ldss.c:469: warning: 'line_tree' may be used uninitialized in this function
svn path=/trunk/; revision=27881
Anders Broman [Sun, 29 Mar 2009 13:47:15 +0000 (13:47 -0000)]
More size_t casts.
svn path=/trunk/; revision=27880
Anders Broman [Sun, 29 Mar 2009 12:07:30 +0000 (12:07 -0000)]
More size_t casts.
svn path=/trunk/; revision=27879
Stephen Fisher [Sun, 29 Mar 2009 05:30:26 +0000 (05:30 -0000)]
Squelch warning about variable may be used uninitialized in this function
svn path=/trunk/; revision=27878
Stephen Fisher [Sun, 29 Mar 2009 04:58:27 +0000 (04:58 -0000)]
Patch from enhancement bug #3265: LDSS (local download sharing service)
svn path=/trunk/; revision=27877
Guy Harris [Sat, 28 Mar 2009 17:30:31 +0000 (17:30 -0000)]
Don't use sprintf() - use ep_strbufs and ep_strbuf_append_printf()
instead.
svn path=/trunk/; revision=27876
Gerald Combs [Sat, 28 Mar 2009 05:14:16 +0000 (05:14 -0000)]
Add a missing check.
svn path=/trunk/; revision=27875
Gerald Combs [Sat, 28 Mar 2009 00:35:02 +0000 (00:35 -0000)]
Fix a couple items from the last checkin.
svn path=/trunk/; revision=27874
Gerald Combs [Sat, 28 Mar 2009 00:27:03 +0000 (00:27 -0000)]
Replace a lot of pointer tracking and some GStrings with emem_strbufs. Add
ep_strbuf_printf and ep_strbuf_append_c.
svn path=/trunk/; revision=27873
Gerald Combs [Fri, 27 Mar 2009 23:05:37 +0000 (23:05 -0000)]
Add initial support for string buffers - ep_allocated, growable strings
similar to GLib's GStrings. Use them to create the list of TCP flags.
svn path=/trunk/; revision=27872
Stephen Fisher [Fri, 27 Mar 2009 20:16:15 +0000 (20:16 -0000)]
Remove extra parenthesis on two lines
svn path=/trunk/; revision=27871
Stephen Fisher [Fri, 27 Mar 2009 19:45:46 +0000 (19:45 -0000)]
Add request/response like tracking to the TFTP dissector. In this case, it
is used to show the source or destination filename being trasnferred on
every packet of that transfer as a generated item.
svn path=/trunk/; revision=27870
Stephen Fisher [Fri, 27 Mar 2009 19:41:18 +0000 (19:41 -0000)]
Put the new tvb_get_seasonal_string() function to good use.
svn path=/trunk/; revision=27869
Stephen Fisher [Fri, 27 Mar 2009 19:40:23 +0000 (19:40 -0000)]
Introduce two new functions:
tvb_get_seasonal_string();
tvb_get_seasonal_stringz();
.. which work the same as the ephemeral versions of the functions, but use
se_alloc() instead of ep_alloc().
svn path=/trunk/; revision=27868
Gerald Combs [Fri, 27 Mar 2009 16:25:49 +0000 (16:25 -0000)]
Add a note about 10.5.
svn path=/trunk/; revision=27867
Gerald Combs [Fri, 27 Mar 2009 16:17:31 +0000 (16:17 -0000)]
More size_t casts.
svn path=/trunk/; revision=27866
Bill Meier [Fri, 27 Mar 2009 14:47:49 +0000 (14:47 -0000)]
(Trivial): fix a typo
svn path=/trunk/; revision=27865
Bill Meier [Fri, 27 Mar 2009 14:46:54 +0000 (14:46 -0000)]
Replace some unnecessary use of g_snprintf and g_strdup_printf
svn path=/trunk/; revision=27864
Bill Meier [Fri, 27 Mar 2009 14:30:51 +0000 (14:30 -0000)]
(Minor): Remove unnecessary use of g_snprintf
svn path=/trunk/; revision=27863
Bill Meier [Fri, 27 Mar 2009 12:48:11 +0000 (12:48 -0000)]
(Minor); if (! initialized) not req'd; move hf[] to proto_register;
Remove unnecessary include files.
svn path=/trunk/; revision=27862
Bill Meier [Fri, 27 Mar 2009 12:16:02 +0000 (12:16 -0000)]
As suggested by Jakob Zawadzki: (Bug #3311): g_free() is NULL safe, so we don't need check against it.
svn path=/trunk/; revision=27861
Anders Broman [Fri, 27 Mar 2009 07:17:05 +0000 (07:17 -0000)]
From Artem Tamazov:
Added: FR MPLS PW support. Expanded: "default MPLS payload" menu.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3325
svn path=/trunk/; revision=27860
Anders Broman [Fri, 27 Mar 2009 07:08:07 +0000 (07:08 -0000)]
From Andreas Heise:
SIP dissector fix: mismatch of P-Asserted-Identity and P-Answer-State headers
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3356
svn path=/trunk/; revision=27859
Anders Broman [Fri, 27 Mar 2009 06:59:15 +0000 (06:59 -0000)]
In informationDirective use MSID instead of mobileIdentificationNumber.
svn path=/trunk/; revision=27858
Stephen Fisher [Fri, 27 Mar 2009 02:33:23 +0000 (02:33 -0000)]
Set svn:keywords Id and svn:eol-style native
svn path=/trunk/; revision=27857
Bill Meier [Thu, 26 Mar 2009 22:34:53 +0000 (22:34 -0000)]
From Peter <pva At gentoo.org>: Fix build err: "variable 'payload_len' might be clobbered by 'longjmp' or 'vfork'"
Fixes Bug #3353
svn path=/trunk/; revision=27856
Bill Meier [Thu, 26 Mar 2009 21:46:07 +0000 (21:46 -0000)]
(Trivial): Fix a typo
svn path=/trunk/; revision=27855
Jörg Mayer [Thu, 26 Mar 2009 18:33:50 +0000 (18:33 -0000)]
Repleace "" by NULL in hf-array (inspired by commit 27851).
svn path=/trunk/; revision=27854
Anders Broman [Thu, 26 Mar 2009 18:01:26 +0000 (18:01 -0000)]
From Vincent Helfre:
Fix unaligned bitfields.
From me activate the SEQUENCE OF patch.
svn path=/trunk/; revision=27853
Anders Broman [Thu, 26 Mar 2009 17:59:30 +0000 (17:59 -0000)]
Add missing files to the distribution.
svn path=/trunk/; revision=27852
Bill Meier [Thu, 26 Mar 2009 17:17:06 +0000 (17:17 -0000)]
(Trivial): Use NULL instead of "" in hfp[] blurbs
svn path=/trunk/; revision=27851
Balint Reczey [Thu, 26 Mar 2009 14:40:18 +0000 (14:40 -0000)]
Fix ESP Initialization Vector dissection.
svn path=/trunk/; revision=27850
Jeff Morriss [Thu, 26 Mar 2009 13:30:58 +0000 (13:30 -0000)]
Move iax2_analysis.c from WIRESHARK_GTK_SRC to WIRESHARK_TAP_SRC
svn path=/trunk/; revision=27849
Anders Broman [Wed, 25 Mar 2009 22:04:23 +0000 (22:04 -0000)]
Make it possible to check for extension marker in SEQUENCE OF and SET OF.
Fore some reason the trace in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3360 does not decode properly
if dissecting the exension marker so leave that code #if 0:ed out for now.
svn path=/trunk/; revision=27848
Balint Reczey [Wed, 25 Mar 2009 18:04:30 +0000 (18:04 -0000)]
From Frederic Roudaut:
Add CAST5-CBC and HMAC-RIPEMD160-96 support.
svn path=/trunk/; revision=27847
Martin Mathieson [Wed, 25 Mar 2009 15:36:23 +0000 (15:36 -0000)]
Show number of UEs in label above table.
svn path=/trunk/; revision=27846
Jörg Mayer [Wed, 25 Mar 2009 00:28:54 +0000 (00:28 -0000)]
Forgot Makefile.common (packet-wassp.c)
svn path=/trunk/; revision=27845
Jörg Mayer [Tue, 24 Mar 2009 22:13:18 +0000 (22:13 -0000)]
Andreas Schuler
Fix display problems with b-fields:
increase the length of the string and use sprintf.
Original German comment:
weiter hab ich festgestellt das das b-field nicht richtig dargestellt wird .
Entweder ist g_snprintf broken , oder wir sind beide zu unf\344hig die
funktion zu benutzen .
Der string wird aus 16x %.2x + leerzeichen zusammengesetzt , was nach
meinen berechnungen eine h\366chstl\344nge von 144 zeichen + nullbyte ergibt .
deshalb hab ich die stringvariable auf 145 hochgesetzt und benutze wieder
sprintf . hier der patch dazu .
svn path=/trunk/; revision=27844
Jörg Mayer [Tue, 24 Mar 2009 22:09:21 +0000 (22:09 -0000)]
Andreas Schuler
small fix:
In a PP packet TA=7 gets dissected as Paging tail. In case of PP it
is really an Mt .
svn path=/trunk/; revision=27843
Jörg Mayer [Tue, 24 Mar 2009 22:02:05 +0000 (22:02 -0000)]
Beginnings of WASSP dissection - that's the protocol run between
HiPath Wireless controllers and the APs.
svn path=/trunk/; revision=27842
Martin Mathieson [Tue, 24 Mar 2009 17:28:30 +0000 (17:28 -0000)]
Only report CRC Status when we know it to be valid.
svn path=/trunk/; revision=27841
Bill Meier [Tue, 24 Mar 2009 17:00:53 +0000 (17:00 -0000)]
From David Castleford: ismacrypt dissector
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3009)
svn path=/trunk/; revision=27840
Balint Reczey [Tue, 24 Mar 2009 11:54:56 +0000 (11:54 -0000)]
Removed code duplication in ASCII key computation.
svn path=/trunk/; revision=27839
Tomas Kukosa [Tue, 24 Mar 2009 07:01:22 +0000 (07:01 -0000)]
add native-nmake.cmd into EXTRA_DIST
svn path=/trunk/; revision=27838
Martin Mathieson [Mon, 23 Mar 2009 22:16:25 +0000 (22:16 -0000)]
Add CRC error flag to frames, and show in stats window.
svn path=/trunk/; revision=27837
Anders Broman [Mon, 23 Mar 2009 21:24:04 +0000 (21:24 -0000)]
From Michael Lum:
ANSI MAP FeatureRequest update
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3349
svn path=/trunk/; revision=27836
Balint Reczey [Mon, 23 Mar 2009 18:14:28 +0000 (18:14 -0000)]
Fix ASCII key computation.
This fixes bug 2943 thus allows ESP decoding again, which was
broken since r25264.
svn path=/trunk/; revision=27835
Anders Broman [Mon, 23 Mar 2009 17:33:20 +0000 (17:33 -0000)]
Get rid of another Clist.
svn path=/trunk/; revision=27834
Anders Broman [Mon, 23 Mar 2009 17:32:39 +0000 (17:32 -0000)]
Some updates and bug fixes.
svn path=/trunk/; revision=27833
Anders Broman [Mon, 23 Mar 2009 17:31:50 +0000 (17:31 -0000)]
Update to the 200903 release.
svn path=/trunk/; revision=27832
Anders Broman [Mon, 23 Mar 2009 17:30:38 +0000 (17:30 -0000)]
Fix: The AuthDir invoke is missing optional tags for a couple of parameters.
and FeatReq invoke fixes.
svn path=/trunk/; revision=27831
Stig Bjørlykke [Mon, 23 Mar 2009 13:31:04 +0000 (13:31 -0000)]
Fixed some data types to remove some warnings.
svn path=/trunk/; revision=27830