Andrew Bartlett [Mon, 6 Aug 2012 08:46:30 +0000 (18:46 +1000)]
build: Make -Werror=format check only run where NULL is still accepted
This is needed because ldb_search() allows a NULL parameter for the format string
and this needs to be permitted by the format string checker before we want to
make this error fatal.
Andrew Bartlett
Andrew Bartlett [Mon, 6 Aug 2012 08:33:35 +0000 (18:33 +1000)]
Rework recursive waf build to be a selftest-enabled not a developer build
This essentially reverts commit
a943a9ba2f739e8aee630f774915e8204aa8cf3a.
I've fixed this by making lib/param/parm_table.c honour --enable-selftest.
Andrew Bartlett
Andrew Bartlett [Mon, 6 Aug 2012 08:32:32 +0000 (18:32 +1000)]
build: Remove duplicate declaration of --enable-selftest
Andrew Bartlett [Mon, 6 Aug 2012 08:32:21 +0000 (18:32 +1000)]
lib/param: Also enable vlp when --enable-selftest is specified
Stefan Metzmacher [Sun, 5 Aug 2012 18:34:17 +0000 (20:34 +0200)]
s3:smbd: remove unused variable in sesssetup.c
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sun Aug 5 23:09:06 CEST 2012 on sn-devel-104
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_server: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_ioctl: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_lock: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_setinfo: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_getinfo: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_negprot: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_write: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_tcon: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_create: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_find: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 13:00:23 +0000 (15:00 +0200)]
s3:smb2_sesssetup: make use of SMBD_SMB2_* macros
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:58:57 +0000 (14:58 +0200)]
s3:smb2_glue: make use of SMBD_SMB2_IN_HDR_PTR()
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:55:58 +0000 (14:55 +0200)]
s3:smb2_read: make use of SMBD_SMB2_IN_BODY_PTR()
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:57:35 +0000 (14:57 +0200)]
s3:smb2_notify: make use of SMBD_SMB2_IN_*_PTR()
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:55:58 +0000 (14:55 +0200)]
s3:smb2_flush: make use of SMBD_SMB2_IN_BODY_PTR()
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:55:58 +0000 (14:55 +0200)]
s3:smb2_close: make use of SMBD_SMB2_IN_BODY_PTR()
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:55:29 +0000 (14:55 +0200)]
s3:smb2_break: make use of SMBD_SMB2_IN_BODY_PTR()
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:53:15 +0000 (14:53 +0200)]
s3:smbd: add helper macros to access smb2req->{in,out}.vector[]
For SMB3 encryption we need to change the vector layout
and we better hide this behind some central macros.
metze
Stefan Metzmacher [Sun, 5 Aug 2012 14:35:08 +0000 (16:35 +0200)]
s3:smb2_server: use 'i' instead of '1' as vector index in smbd_smb2_request_pending_timer()
If we reach this code i is currently always 1, but it's easier to unstand this
way.
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sun Aug 5 20:00:26 CEST 2012 on sn-devel-104
Stefan Metzmacher [Sun, 5 Aug 2012 12:26:40 +0000 (14:26 +0200)]
s3:smb2_lock: remove unused in_smbpid
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:26:40 +0000 (14:26 +0200)]
s3:smb2_write: remove unused in_smbpid
metze
Stefan Metzmacher [Sun, 5 Aug 2012 12:25:48 +0000 (14:25 +0200)]
s3:smb2_read: remove unused in_smbpid
metze
Stefan Metzmacher [Fri, 3 Aug 2012 10:47:11 +0000 (12:47 +0200)]
s4:domain join: setup RODC invocationId
Pair-Programmed-With: Björn Baumbach <bb@sernet.de>
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Aug 4 18:27:21 CEST 2012 on sn-devel-104
Andreas Schneider [Fri, 3 Aug 2012 16:21:38 +0000 (18:21 +0200)]
doc: Remove build/ from doxygen config or it will not work in brew.
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sat Aug 4 16:31:22 CEST 2012 on sn-devel-104
Stefan Metzmacher [Fri, 3 Aug 2012 06:44:39 +0000 (08:44 +0200)]
s3:smbd: add support for SMB_EXTENDED_SIGNATURES in SMBtconX
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Aug 4 14:28:04 CEST 2012 on sn-devel-104
Stefan Metzmacher [Fri, 3 Aug 2012 06:42:43 +0000 (08:42 +0200)]
s3:smbd: setup the application session key with the first tcon on a session
Look for Server.Session.SessionKeyState in [MS-SMB].
The first SMBtconX sets the state to available, which makes it possible
to protect the session key at that stage, if client and server
support TREE_CONNECT_ANDX_EXTENDED_SIGNATURE.
metze
Stefan Metzmacher [Sat, 4 Aug 2012 08:05:51 +0000 (10:05 +0200)]
s3:rpc_server/wkssvc: make usage of session_extract_session_key()
This makes sure we return NO_USER_SESSION_KEY if there's no session key.
metze
Stefan Metzmacher [Sat, 4 Aug 2012 08:05:51 +0000 (10:05 +0200)]
s3:rpc_server/netlogon: make usage of session_extract_session_key()
This makes sure we return NO_USER_SESSION_KEY if there's no session key.
metze
Stefan Metzmacher [Thu, 2 Aug 2012 16:47:48 +0000 (18:47 +0200)]
s3:smbd: setup session->global->signing_/application_key during SPNEGO SMB1 session setups
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Aug 4 11:09:42 CEST 2012 on sn-devel-104
Stefan Metzmacher [Thu, 2 Aug 2012 16:47:48 +0000 (18:47 +0200)]
s3:smbd: setup session->global->signing_/application_key during old SMB1 session setups
metze
Stefan Metzmacher [Thu, 2 Aug 2012 16:46:09 +0000 (18:46 +0200)]
s3:smbd: keep the "application session key" during SMB1 reauth
metze
Stefan Metzmacher [Thu, 2 Aug 2012 06:51:13 +0000 (08:51 +0200)]
s4:torture: add support for SMB_EXTENDED_SIGNATURES during SMBtconX
metze
Stefan Metzmacher [Thu, 2 Aug 2012 06:51:13 +0000 (08:51 +0200)]
s4:libcli: add support for SMB_EXTENDED_SIGNATURES during SMBtconX
metze
Stefan Metzmacher [Wed, 1 Aug 2012 09:47:07 +0000 (11:47 +0200)]
s3:libsmb: add EXTENDED_SIGNATURE support in cli_tcon_andx*()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 07:01:25 +0000 (09:01 +0200)]
libcli/smb: add smb1cli_session_protect_session_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 07:28:06 +0000 (09:28 +0200)]
libcli/smb: add smb_key_derivation() for TREE_CONNECT_ANDX_EXTENDED_SIGNATURES support
metze
Stefan Metzmacher [Fri, 3 Aug 2012 07:58:29 +0000 (09:58 +0200)]
libcli/smb: pass hdr/len to smb_signing_check/sign_pdu() and skip the nbt header
metze
Stefan Metzmacher [Fri, 3 Aug 2012 07:57:19 +0000 (09:57 +0200)]
s3:smbd: skip nbt header in srv_check_sign_mac()
metze
Stefan Metzmacher [Fri, 3 Aug 2012 07:29:20 +0000 (09:29 +0200)]
libcli/smb: change smb_signing to skip the NBT_HEADER_SIZE internally
metze
Stefan Metzmacher [Sat, 4 Aug 2012 07:07:24 +0000 (09:07 +0200)]
auth/ntlmssp: avoid talloc_tos() in ntlmssp_client_initial()
This avoids a smb_panic at log level = 10.
If we don't have a talloc stackframe yet.
metze
Christian Ambach [Fri, 3 Aug 2012 10:42:41 +0000 (12:42 +0200)]
s3-ctdb: return proper exit code
do not loose the result from ctdbd_messaging_send_blob()
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Fri Aug 3 14:49:01 CEST 2012 on sn-devel-104
Christian Ambach [Fri, 3 Aug 2012 10:29:10 +0000 (12:29 +0200)]
s3-ctdb: adjust a loglevel
Volker Lendecke [Mon, 16 Jul 2012 14:18:19 +0000 (16:18 +0200)]
s3-ctdb: Fix ctdb_serverids_exist for target nodes that died
Signed-off-by: Christian Ambach <ambi@samba.org>
Volker Lendecke [Mon, 16 Jul 2012 13:50:06 +0000 (15:50 +0200)]
s3-ctdb: Add debugs to ctdb_serverids_exist
Signed-off-by: Christian Ambach <ambi@samba.org>
Gregor Beck [Wed, 1 Aug 2012 13:31:18 +0000 (15:31 +0200)]
lib/dbwrap: rewrite lock order check to ease debugging
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Aug 3 12:52:38 CEST 2012 on sn-devel-104
Björn Baumbach [Mon, 30 Jul 2012 15:09:07 +0000 (17:09 +0200)]
docs-xml: fix pid directory example
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Aug 3 10:30:37 CEST 2012 on sn-devel-104
Björn Baumbach [Mon, 30 Jul 2012 15:02:55 +0000 (17:02 +0200)]
docs-xml: fix dfree cache time example
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 2 Aug 2012 14:27:20 +0000 (16:27 +0200)]
s4:dsdb:replicated_objects: do not move 'instanceType' to the end of msg->elements on RODC replication
It's very important that the order of msg->elements and md->ctr.ctr1.array
is the same.
metze
Björn Baumbach [Wed, 1 Aug 2012 13:09:00 +0000 (15:09 +0200)]
s4: samba_spnupdate: fix "if we are DNS server" check
We need to check if we have hasMasterNCs. If we are RODC we have
hasFullReplicaNCs instead of hasMasterNCs.
TODO: maybe check for hasFullReplicaNCs, too?
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Fri, 3 Aug 2012 00:00:56 +0000 (10:00 +1000)]
build: fix typo
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 3 03:56:38 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 2 Aug 2012 05:16:13 +0000 (15:16 +1000)]
s3-pysmbd: Add hook for get_nt_acl()
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Aug 2 13:27:55 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 2 Aug 2012 03:36:55 +0000 (13:36 +1000)]
s3-pysmbd: fix DEBUG
Andrew Bartlett [Thu, 2 Aug 2012 03:36:43 +0000 (13:36 +1000)]
s3-pysmbd: Add my copyright
Andrew Bartlett [Thu, 2 Aug 2012 03:35:24 +0000 (13:35 +1000)]
s3-pysmbd: Add set_nt_acl() function based on parts of vfstest
This will allow us to set the full NT ACL on a file, using the VFS
layer, during provision of the AD DC.
Andrew Bartlett
Andrew Bartlett [Thu, 2 Aug 2012 08:05:03 +0000 (18:05 +1000)]
s3-pypassdb: Fix wrapper for pdb_domain_info to return correct dns_{domain,forest}
Stefan Metzmacher [Thu, 2 Aug 2012 06:48:11 +0000 (08:48 +0200)]
s4:torture: send the TCONX_FLAG_EXTENDED_RESPONSE flag
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Aug 2 10:54:18 CEST 2012 on sn-devel-104
Stefan Metzmacher [Thu, 2 Aug 2012 06:48:11 +0000 (08:48 +0200)]
s4:libcli: send the TCONX_FLAG_EXTENDED_RESPONSE flag
metze
Andrew Tridgell [Thu, 2 Aug 2012 04:59:37 +0000 (14:59 +1000)]
heimdal: fixed -Werror=format error in com_err
This needs to be merged upstream
Autobuild-User(master): Andrew Tridgell <tridge@samba.org>
Autobuild-Date(master): Thu Aug 2 08:59:24 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 1 Aug 2012 10:01:07 +0000 (12:01 +0200)]
s3:smbd: add a optional_support helper variable to reply_tcon_and_X()
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Aug 1 18:25:26 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 1 Aug 2012 09:48:30 +0000 (11:48 +0200)]
s3:smbd: make use of TCONX_FLAG_DISCONNECT_TID define
metze
Stefan Metzmacher [Wed, 1 Aug 2012 09:46:22 +0000 (11:46 +0200)]
s3:libsmb: add a optional_support helper variable
metze
Stefan Metzmacher [Wed, 1 Aug 2012 09:45:36 +0000 (11:45 +0200)]
s3:libsmb: add a tcon_flags helper variable
metze
Stefan Metzmacher [Wed, 1 Aug 2012 09:33:27 +0000 (11:33 +0200)]
libcli/smb: move some TCON related defines to smb_constants.h
metze
Stefan Metzmacher [Wed, 1 Aug 2012 09:00:02 +0000 (11:00 +0200)]
s3:rpc_client: rename pipe_auth_data->user_session_key to transport_session_key
metze
Stefan Metzmacher [Wed, 1 Aug 2012 08:50:30 +0000 (10:50 +0200)]
s3:libsmb: remove unused cli_state->user_session_key
metze
Stefan Metzmacher [Wed, 1 Aug 2012 08:48:53 +0000 (10:48 +0200)]
s3:utils/net_rpc*: make use of cli_get_session_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 08:30:06 +0000 (10:30 +0200)]
s3:libnet_join: make use of cli_get_session_key() in libnet_join_joindomain_rpc()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 08:18:22 +0000 (10:18 +0200)]
s3:rpc_client: make use of smbXcli_session_application_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 07:41:53 +0000 (09:41 +0200)]
s4:libcli/raw: remove unused smbcli_session->user_session_key
metze
Stefan Metzmacher [Wed, 1 Aug 2012 07:10:09 +0000 (09:10 +0200)]
s4:librpc/dcerpc_smb2: sync smb2_session_key() with smb_session_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 07:09:34 +0000 (09:09 +0200)]
s4:librpc/dcerpc_smb: make use of smbXcli_session_application_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 07:01:01 +0000 (09:01 +0200)]
libcli/smb: remove unused smb2cli_session_application_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 06:59:57 +0000 (08:59 +0200)]
s4:librpc/dcerpc_smb2: make use of smbXcli_session_application_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 06:59:01 +0000 (08:59 +0200)]
libcli/smb: add smbXcli_session_application_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 06:57:40 +0000 (08:57 +0200)]
s4:libcli/smb_composite: make use of smb1cli_session_set_session_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 06:55:49 +0000 (08:55 +0200)]
s4:libcli/smb_composite: always use set_user_session_key() helper
metze
Stefan Metzmacher [Wed, 1 Aug 2012 06:54:51 +0000 (08:54 +0200)]
s3:libsmb: make use of smb1cli_session_set_session_key()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 12:14:39 +0000 (14:14 +0200)]
libcli/smb: allow resetting of the smb1 application_key
We need this untill we have fixed all callers...
metze
Stefan Metzmacher [Wed, 1 Aug 2012 11:25:18 +0000 (13:25 +0200)]
libcli/smb: let smb1cli_session_set_id() reset the application_key
We have some callers which reuse smbXcli_session,
e.g. cli_state_set_uid()
metze
Stefan Metzmacher [Wed, 1 Aug 2012 06:53:30 +0000 (08:53 +0200)]
libcli/smb: add smb1cli_session_set_session_key()
metze
Michael Adam [Mon, 30 Jul 2012 13:31:59 +0000 (09:31 -0400)]
s3:ctdbd_conn: use unitX_t types consistently throughout the module
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Richard Sharpe [Wed, 1 Aug 2012 02:36:18 +0000 (19:36 -0700)]
Add two flags to allow for handling of Extended Signatures (Session Key Protection) on a TCON_AND_X request and response.
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Wed Aug 1 06:36:37 CEST 2012 on sn-devel-104
Richard Sharpe [Sun, 3 Jun 2012 05:27:22 +0000 (22:27 -0700)]
Make it possible to build under Solaris make as well as FreeBSD and Linux. Also add comments on changes that might be needed
Andrew Bartlett [Tue, 31 Jul 2012 02:25:56 +0000 (12:25 +1000)]
VERSION: Move on to beta6!
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jul 31 16:09:23 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 31 Jul 2012 02:25:16 +0000 (12:25 +1000)]
VERSION: Mark as the beta5 release
Andrew Bartlett [Tue, 31 Jul 2012 02:24:49 +0000 (12:24 +1000)]
WHATSNEW: prepare for 4.0 beta5
Andrew Bartlett [Mon, 30 Jul 2012 06:00:58 +0000 (16:00 +1000)]
s4-repl: Add tests for add replication conflicts and use of LostAndFound
LostAndFound is used when we find children of a deleted object that are not themselves deleted.
Andrew Bartlett
Andrew Bartlett [Tue, 31 Jul 2012 00:47:57 +0000 (10:47 +1000)]
s4-dsdb: Replace any existing lastKnownParent attribute during delete
This allows a lastKnownParent from LostAndFound to be replaced.
Andrew Bartlett
Andrew Bartlett [Tue, 31 Jul 2012 00:18:43 +0000 (10:18 +1000)]
s4-dsdb: Improve tracing in repl_meta_data
When we call ldb_module_done() rather than just calling the callback, we make log entries
that are critical in debugging.
Andrew Bartlett
Andrew Bartlett [Mon, 30 Jul 2012 02:11:35 +0000 (12:11 +1000)]
s4-dsdb: Handle rename conflicts in both directions
Previously we would only consider renaming the local object, now we can cope with
renaming the remote object as well.
This should avoid most of the cases where Samba AD replication can just stop.
Andrew Bartlett
Andrew Bartlett [Tue, 31 Jul 2012 00:17:20 +0000 (10:17 +1000)]
lib/ldb: Ensure rename target does not exist before deleting old record
This is all in a transaction, but when we are handling rename errors in the repl_meta_data
module, we key off the error, and do not close the transaction. We found that the
old record was gone and so could not try renaming it again to a conflict DN.
Andrew Bartlett
Andrew Bartlett [Tue, 31 Jul 2012 07:10:42 +0000 (17:10 +1000)]
s4-dsdb: Request extended DN and show deleted when searching for a possible parent
This fixes up the lastKnownParent attribute on lostAndFound objects to have a GUID
(found by dbcheck).
Andrew Bartlett
Volker Lendecke [Mon, 30 Jul 2012 12:50:52 +0000 (14:50 +0200)]
s3: Fix Coverity ID 710791 Resource leak
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jul 31 13:34:53 CEST 2012 on sn-devel-104
Volker Lendecke [Mon, 30 Jul 2012 12:48:28 +0000 (14:48 +0200)]
s3: Fix Coverity ID 710803 Resource leak
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 30 Jul 2012 12:45:25 +0000 (14:45 +0200)]
s3: Fix Coverity ID 710818 Resource leak
Signed-off-by: Stefan Metzmacher <metze@samba.org>