Michael Adam [Wed, 28 Nov 2007 14:24:18 +0000 (15:24 +0100)]
Give rpcclient a talloc stackframe.
Michael
Jeremy Allison [Wed, 28 Nov 2007 07:40:54 +0000 (23:40 -0800)]
Remove pstrings from asn1.c.
Jeremy.
Jeremy Allison [Wed, 28 Nov 2007 07:10:20 +0000 (23:10 -0800)]
Remove pstrings from namequery.c.
Jeremy.
Jeremy Allison [Wed, 28 Nov 2007 07:00:11 +0000 (23:00 -0800)]
Fixed obvious typo.
Jeremy.
Jeremy Allison [Wed, 28 Nov 2007 06:22:35 +0000 (22:22 -0800)]
Remove unused prototype for smbldap_get_single_pstring().
Don't use pstr_sprintf() on an fstring - change to talloc.
Jeremy.
Jeremy Allison [Wed, 28 Nov 2007 03:12:42 +0000 (19:12 -0800)]
Save one extra strdup per lp_string. Use talloc_sub_basic()
directly.
Jeremy.
Jeremy Allison [Wed, 28 Nov 2007 03:05:08 +0000 (19:05 -0800)]
Remove pstring from srv_spoolss_nt.c. All gone from rpc_server/*.c
Jeremy.
Jeremy Allison [Wed, 28 Nov 2007 01:50:39 +0000 (17:50 -0800)]
Fix old cut-and-paste bug where the wrong field was being written to.
Jerry please check.
Jeremy.
Jeremy Allison [Wed, 28 Nov 2007 01:48:59 +0000 (17:48 -0800)]
Whitespace cleanup.
Jeremy.
Jeremy Allison [Wed, 28 Nov 2007 01:48:44 +0000 (17:48 -0800)]
Make init_unistr2_from_unistr take an explicit talloc context.
Make init_unistr() re-use rpcstr_push_talloc().
Jeremy.
Jeremy Allison [Tue, 27 Nov 2007 22:35:30 +0000 (14:35 -0800)]
Remove pstrings from everything except srv_spoolss_nt.c.
Jeremy.
Guenther Deschner [Tue, 27 Nov 2007 20:53:41 +0000 (21:53 +0100)]
fix a obscure compiler warning
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Jeremy,
I have never seen this warning before:
"warning: comparison is always false due to limited range of data type".
Guenther
- --
Günther Deschner GPG-ID:
8EE11688
Red Hat gdeschner@redhat.com
Samba Team gd@samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFHTIOOSOk3aI7hFogRArxMAJwP0ktE96tHcwn9nXG6AOqonpeDgQCgm/zi
54B6HJZvx6zdUTMFFNWqUb0=
=kUJa
-----END PGP SIGNATURE-----
>From
6a4935ee455adc1251fce2759f97d35f303bd40e Mon Sep 17 00:00:00 2001
From: =?utf-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
Date: Tue, 27 Nov 2007 21:48:39 +0100
Subject: [PATCH] Getting rid of "comparison is always false due to limited range of data type"
warning.
Guenther
Jeremy Allison [Tue, 27 Nov 2007 19:22:58 +0000 (11:22 -0800)]
Remove pstring from everything in rpc_server except
srv_spoolss_nt.c and srv_srvsvc_nt.c.
They're next :-).
Jeremy.
Günther Deschner [Tue, 27 Nov 2007 17:01:56 +0000 (18:01 +0100)]
Unless talloc has some new magic there is a ctx missing here.
Guenther
Michael Adam [Tue, 27 Nov 2007 15:36:06 +0000 (16:36 +0100)]
Use the proper boolean constants - the type has been
changed from BOOL to bool.
Michael
Volker Lendecke [Sun, 25 Nov 2007 09:10:52 +0000 (10:10 +0100)]
Remove some statics
Jeremy Allison [Tue, 27 Nov 2007 01:24:56 +0000 (17:24 -0800)]
Remove pstrings from nsswitch/ and registry/
Jeremy.
Volker Lendecke [Sat, 24 Nov 2007 16:27:19 +0000 (17:27 +0100)]
Remove a global
Volker Lendecke [Mon, 26 Nov 2007 14:28:13 +0000 (15:28 +0100)]
Fix bug 5055
Volker Lendecke [Mon, 26 Nov 2007 13:30:50 +0000 (14:30 +0100)]
Improve debug message
Fix bug 5056, thanks to debian package maintainer
Volker Lendecke [Mon, 26 Nov 2007 10:55:55 +0000 (11:55 +0100)]
Fix a C++ warning
Tomoki AONO [Sat, 24 Nov 2007 16:59:40 +0000 (01:59 +0900)]
1. lib/system.c (xattr code for Solaris) could not be
built against c90 compilers. (declaration after
statement.) Sample patch attached.
Volker Lendecke [Sun, 25 Nov 2007 11:54:52 +0000 (12:54 +0100)]
In libsmbclient, map NT_STATUS_OBJECT_PATH_NOT_FOUND to ENOENT
Thanks to SATOH Fumiyasu!
This fixes bug 4974
Volker Lendecke [Sat, 24 Nov 2007 15:32:38 +0000 (16:32 +0100)]
Remove a static
Volker Lendecke [Fri, 23 Nov 2007 11:04:35 +0000 (12:04 +0100)]
Make remote_password_change return malloced error strings
This fixes a segfault in smbpasswd -r
Volker Lendecke [Fri, 23 Nov 2007 13:34:13 +0000 (14:34 +0100)]
add talloc_stackframe() to eventlogadm
Thanks to Günther Kukkukk for noticing
Stefan Metzmacher [Fri, 23 Nov 2007 10:51:33 +0000 (11:51 +0100)]
printing: fix default printing subsystem detection
"system/printing.h" includes an outdated copy of
the stuff in samba3's includes.h, so we should not use it.
metze
Stefan Metzmacher [Wed, 21 Nov 2007 15:41:12 +0000 (16:41 +0100)]
smbd: close_stat() should be static
metze
Volker Lendecke [Thu, 22 Nov 2007 14:48:47 +0000 (15:48 +0100)]
Do not link in SOCKET_WRAPPER_OBJ twice
Volker Lendecke [Wed, 7 Nov 2007 19:18:38 +0000 (20:18 +0100)]
Cosmetic fix
Volker Lendecke [Tue, 13 Nov 2007 10:43:48 +0000 (11:43 +0100)]
Add a missing prototype
Volker Lendecke [Mon, 12 Nov 2007 16:36:34 +0000 (17:36 +0100)]
Fix an uninitialized variable
Volker Lendecke [Fri, 16 Nov 2007 13:48:26 +0000 (14:48 +0100)]
Fix a type-punned warning
James Peach [Thu, 22 Nov 2007 02:31:35 +0000 (18:31 -0800)]
Merge ssh://git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 22 Nov 2007 01:42:52 +0000 (17:42 -0800)]
Remove pstrings from pam_smbpass - make local_password_change
return malloced strings.
Jeremy.
Jeremy Allison [Wed, 21 Nov 2007 21:56:36 +0000 (13:56 -0800)]
Remove pstring from printing/*.c except for the
tdb_unpack requirement (I'll be making that an
allocating interface later).
Jeremy.
Jeremy Allison [Wed, 21 Nov 2007 18:31:18 +0000 (10:31 -0800)]
Doh ! Don't use #else when #endif is needed.
Jeremy.
Jeremy Allison [Wed, 21 Nov 2007 18:10:52 +0000 (10:10 -0800)]
Add set_sockaddr_port function for winbindd.
Jeremy.
Gerald (Jerry) Carter [Wed, 21 Nov 2007 16:27:22 +0000 (10:27 -0600)]
Allocate a talloc_stackframe() in main() for wbinfo.
Gerald (Jerry) Carter [Wed, 21 Nov 2007 16:27:01 +0000 (10:27 -0600)]
Fix unresolved symbols in smbumount from addition of talloc_stackframe().
Jeremy Allison [Wed, 21 Nov 2007 03:17:47 +0000 (19:17 -0800)]
Add talloc stackframe for ntlm_auth.c
Jeremy.
Jeremy Allison [Wed, 21 Nov 2007 03:05:30 +0000 (19:05 -0800)]
Remove pstrcpy I missed.
Jeremy.
Jeremy Allison [Wed, 21 Nov 2007 02:55:36 +0000 (18:55 -0800)]
More pstring removal....
Jeremy.
Jeremy Allison [Wed, 21 Nov 2007 01:57:47 +0000 (17:57 -0800)]
Remove pstring from services/*.c
Jeremy.
Jeremy Allison [Wed, 21 Nov 2007 01:54:01 +0000 (17:54 -0800)]
Ensure we have a talloc stackframe (found by Kukks).
Jeremy.
Jeremy Allison [Wed, 21 Nov 2007 01:18:16 +0000 (17:18 -0800)]
More pstring elimination.
Jeremy.
David Losada Carballo [Wed, 21 Nov 2007 00:45:33 +0000 (16:45 -0800)]
Extend commit module to help with NFS quotas.
Add "commit on eof" and "commit past eof" modes. Patch from David
Losada Carballo with some modifications during the merge.
Jeremy Allison [Tue, 20 Nov 2007 23:31:37 +0000 (15:31 -0800)]
More trivial pstring removal.
Jeremy.
Jeremy Allison [Tue, 20 Nov 2007 23:31:18 +0000 (15:31 -0800)]
Paranoia check that space_remaining never goes -ve.
Jeremy.
Gerald (Jerry) Carter [Tue, 20 Nov 2007 19:24:03 +0000 (13:24 -0600)]
Prevent segv in winbindd running on a DC using the "idmap backend" syntax.
The number of domains should be counted as they are added and not assumed
to match the loop counter.
manually cherry-picked
8ad2826c48a0d4d26abc3bb209860c776f55822f
Jeremy Allison [Tue, 20 Nov 2007 02:56:22 +0000 (18:56 -0800)]
Remove more pstring. Unify talloc_sub functions to make
them a better match for replacing string_sub. Remove
more unused code.
Jeremy.
Jeremy Allison [Tue, 20 Nov 2007 01:51:21 +0000 (17:51 -0800)]
Start to remove some of the pstring functions we're
no longer using.
Jeremy.
Jeremy Allison [Tue, 20 Nov 2007 01:43:28 +0000 (17:43 -0800)]
Always check return from push_ascii.
Jeremy.
Volker Lendecke [Mon, 19 Nov 2007 11:36:16 +0000 (12:36 +0100)]
Add stackframes to public libsmbclient functions
As we use talloc_tos() in inner libsmbclient/ functions more and more, we need
to make sure not to create memleaks by not free'ing talloc stackframes. This
patch wraps all calls in libsmbclient.c that are publically exported into a
talloc_stackframe()/talloc_free() pair.
Jeremy, Derrell, can you check this?
Thanks,
Volker
Jeremy Allison [Mon, 19 Nov 2007 23:15:09 +0000 (15:15 -0800)]
Remove pstring from nmbd.
Jeremy.
Karolin Seeger [Mon, 22 Oct 2007 11:10:55 +0000 (13:10 +0200)]
Add error message to net rap file and net rap file user
Volker Lendecke [Sun, 18 Nov 2007 13:45:19 +0000 (14:45 +0100)]
Add a comment
Volker Lendecke [Sun, 18 Nov 2007 13:24:54 +0000 (14:24 +0100)]
Fix a valgrind error
James Peach [Sun, 18 Nov 2007 21:56:19 +0000 (13:56 -0800)]
Detect Heimdal Kerberos on OpenBSD 4.2.
Patch from Sean McCreary <samba-technical@mcwest.org>.
Jeremy Allison [Sat, 17 Nov 2007 01:07:11 +0000 (17:07 -0800)]
Remove pstring from modules directory.
Jeremy.
Jeremy Allison [Sat, 17 Nov 2007 01:06:57 +0000 (17:06 -0800)]
Ensure we use PATH_MAX for symlinks.
Jeremy.
Jeremy Allison [Sat, 17 Nov 2007 01:06:36 +0000 (17:06 -0800)]
Fix bug #4393 smbclient does not store files with zero filesize in tar-archives
from tometzky@batory.org.pl.
Jeremy.
Jeremy Allison [Fri, 16 Nov 2007 21:29:42 +0000 (13:29 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Michael Adam [Fri, 16 Nov 2007 21:26:26 +0000 (22:26 +0100)]
Fix for bug #4781: allow cleaning of /etc/mtab by canonicalizing mountpoint.
Canonicalize mountpoint by trimming trailing slashes before unmounting.
This allows for correct cleanup of /etc/mtab after unmounting.
Thanks to Steve Langasek <vorlon@debian.org>.
Michael
Michael Adam [Fri, 16 Nov 2007 21:22:05 +0000 (22:22 +0100)]
Fix an implicit cast warning.
Michael
Jeremy Allison [Fri, 16 Nov 2007 21:14:24 +0000 (13:14 -0800)]
Match the 3.0.27a version of this function.
Jeremy.
Jeremy Allison [Fri, 16 Nov 2007 02:27:26 +0000 (18:27 -0800)]
Add MAX_DNS_NAME_LENGTH, remove more pstrings.
Jeremy.
Jeremy Allison [Fri, 16 Nov 2007 01:59:12 +0000 (17:59 -0800)]
Fix bug noticed by kukks <linux@kukkukk.com> where
ip list didn't match namelist added to subnetdb.
Could cause bogus IP addresses to be reported for
the __SAMBA__ name.
Jeremy.
Michael Adam [Thu, 15 Nov 2007 23:45:44 +0000 (00:45 +0100)]
Fix the build on RHEL5, when libcap-devel is installed.
The /usr/include/sys/capability.h defines _LINUX_TYPES_H
which prevents /usr/include/linux/types.h from being parsed
(when included afterwards). Thus certain types are undefined
that are for instance needed in /usr/include/linux/dqblk_xfs.h.
This breaks the build of lib/sysquotas_xfs.c.
This commit adds a configure check and a workaround for this.
Michael
Michael Adam [Thu, 15 Nov 2007 23:34:37 +0000 (00:34 +0100)]
Fix an implicit cast warning.
Michael
Jeremy Allison [Thu, 15 Nov 2007 22:19:52 +0000 (14:19 -0800)]
More pstring removal. This one was tricky. I had to add
one horror (pstring_clean_name()) which will have to
remain until I've removed all pstrings from the client code.
Jeremy.
Jeremy Allison [Thu, 15 Nov 2007 21:18:42 +0000 (13:18 -0800)]
alpha_strcpy includes the space for the terminating nul.
Jeremy.
Gerald (Jerry) Carter [Thu, 15 Nov 2007 02:51:14 +0000 (20:51 -0600)]
Fix for CVE-2007-5398.
== Subject: Remote code execution in Samba's WINS
== server daemon (nmbd) when processing name
== registration followed name query requests.
==
== CVE ID#: CVE-2007-5398
==
== Versions: Samba 3.0.0 - 3.0.26a (inclusive)
...
Secunia Research reported a vulnerability that allows for
the execution of arbitrary code in nmbd. This defect may
only be exploited when the "wins support" parameter has
been enabled in smb.conf.
Michael Adam [Thu, 15 Nov 2007 10:08:53 +0000 (11:08 +0100)]
Fix bug #5083 (and duplicate bug #5084).
Make solarisacl_sys_acl_get_fd() return a result
when there is one (thereby fixing a memleak).
Thanks to Markus Zell for reporting this.
Michael
Jeremy Allison [Thu, 15 Nov 2007 00:05:42 +0000 (16:05 -0800)]
Remove smbldap_get_single_pstring() and all pstrings
from pdb_ldap.c. I don't have an LDAP passdb setup here,
so I'm going to need some help on testing this.
Jeremy.
Jeremy Allison [Wed, 14 Nov 2007 18:37:18 +0000 (10:37 -0800)]
Remove pstring from auth/*
Jeremy.
Jeremy Allison [Wed, 14 Nov 2007 02:42:42 +0000 (18:42 -0800)]
Remove pstring from param/
This was a little tricky..... I'll watch the
build farm.
Jeremy.
Jeremy Allison [Tue, 13 Nov 2007 23:00:48 +0000 (15:00 -0800)]
Remove all pstring from groupdb/
Jeremy.
Michael Adam [Tue, 13 Nov 2007 22:26:38 +0000 (23:26 +0100)]
Fix potential orphaned open files.
Calling can_access_file could lead to orphaned open files
when SMB_VFS_GET_NT_ACL returned ENOSYS (not implemented).
Michael
Jeremy Allison [Tue, 13 Nov 2007 20:51:31 +0000 (12:51 -0800)]
Remove last pstring from smbd/*.c
Jeremy.
Michael Adam [Mon, 12 Nov 2007 11:49:40 +0000 (12:49 +0100)]
Fix build of the zfs_acl module.
There was one caller of smb_get_nt_acl_nfs4() forgotten
in the change of return value.
Michael
Michael Adam [Mon, 12 Nov 2007 11:48:29 +0000 (12:48 +0100)]
Fix the build: correct prototype.
Adapt prototype of smb_get_nt_acl_nfs4() in the header file, too.
Michael
Volker Lendecke [Sat, 13 Oct 2007 19:06:49 +0000 (21:06 +0200)]
Make [f]get_nt_acl return NTSTATUS
Jeremy Allison [Tue, 13 Nov 2007 02:12:26 +0000 (18:12 -0800)]
More pstring removal from smbd/*.c
Jeremy.
Jeremy Allison [Tue, 13 Nov 2007 01:59:18 +0000 (17:59 -0800)]
Remove pstrings from lanman.c
Jeremy.
Jeremy Allison [Mon, 12 Nov 2007 23:02:50 +0000 (15:02 -0800)]
Remove all pstrings from smbd/chgpasswd.c.
Jeremy.
Jeremy Allison [Mon, 12 Nov 2007 19:39:35 +0000 (11:39 -0800)]
Fix bug #5073. Allow "delete readonly = yes" to correctly
override deletion of a file. Fix from David Shaw <dshaw@jabberwocky.com>
Jeremy.
Jeremy Allison [Mon, 12 Nov 2007 05:46:52 +0000 (21:46 -0800)]
Three more pstring removals.
Jeremy.
Jeremy Allison [Mon, 12 Nov 2007 05:45:55 +0000 (21:45 -0800)]
Remove a pstring.
Jeremy.
Volker Lendecke [Sun, 11 Nov 2007 14:30:01 +0000 (15:30 +0100)]
Some pstring removal
Hi!
Feel free to push :-)
Volker
From
7fae6b3709a973bd0a5a13d3f5c880c61d5e35de Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@sernet.de>
Date: Sun, 11 Nov 2007 15:28:59 +0100
Subject: [PATCH] Remove some static pstrings
Volker Lendecke [Sun, 11 Nov 2007 11:49:42 +0000 (12:49 +0100)]
Cosmetic fix
Do directory vs file open before entering open_file_stat
Jeremy Allison [Sun, 11 Nov 2007 21:18:22 +0000 (13:18 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Volker Lendecke [Sun, 11 Nov 2007 14:50:16 +0000 (15:50 +0100)]
Remove a static fstring
Feel free to push :-)
Volker
Volker Lendecke [Sun, 11 Nov 2007 14:38:50 +0000 (15:38 +0100)]
Remove a static fstring
I'm not sure why this used to be static, to me it seems that every time this
variable is overwritten. I just don't see how name_status_find() could return
true and not overwrite name. Can someone please review this and potentially
check it in?
Thanks,
Volker
Volker Lendecke [Sat, 10 Nov 2007 22:15:40 +0000 (23:15 +0100)]
Convert ctdb_conn.c to enum ndr_error_code
Fix the build
Volker Lendecke [Sat, 10 Nov 2007 20:37:24 +0000 (21:37 +0100)]
Add ndr_errstr
Jeremy Allison [Sun, 11 Nov 2007 06:31:34 +0000 (22:31 -0800)]
Always define PATH_MAX. Makes code simpler (removes
a bunch of #defines). Remove pstring from msdfs.c.
Jeremy.
Jeremy Allison [Sat, 10 Nov 2007 23:36:47 +0000 (15:36 -0800)]
Remove last pstring from sesssetup.c
Jeremy.
Jeremy Allison [Sat, 10 Nov 2007 23:02:08 +0000 (15:02 -0800)]
Fix the build when realpath doesn't take null
as a last arg.
Jeremy.
Jeremy Allison [Sat, 10 Nov 2007 22:43:39 +0000 (14:43 -0800)]
Remove pstring from service.c.
Jeremy.