Karolin Seeger [Fri, 9 Jan 2009 14:54:16 +0000 (15:54 +0100)]
s3/smbpasswd: Check if Unix account exists before asking for the password.
Admins shouldn't have to type in the password twice when the passdb account
cannot be created because the Unix account is missing.
Karolin
Stefan Metzmacher [Fri, 9 Jan 2009 12:10:07 +0000 (13:10 +0100)]
s4:debug: make setup_logging() a bit more compatible with samba3
In samba3 the 2nd argument is bool interactive.
E.g ndrdump uses true there which used to map to DEBUG_FILE
in samba4, it maps to DEBUG_STDOUT now, which is better.
In the end end samba3 should also use the samba4 version of
setup_logging()
metze
Stefan Metzmacher [Fri, 9 Jan 2009 11:23:11 +0000 (12:23 +0100)]
Revert "quote ' inside '...' and make sure shell isn't eating \ by using perl here."
This reverts commit
2a52b059ce44403ff6ced066e0bb23fa6cc66a73.
It breaks the build on ubuntu.
metze
Björn Jacke [Fri, 9 Jan 2009 11:05:55 +0000 (12:05 +0100)]
quote ' inside '...' and make sure shell isn't eating \ by using perl here.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Karolin Seeger [Fri, 9 Jan 2009 10:22:00 +0000 (11:22 +0100)]
docs: Improve man mount.cifs.
Add hint about specifying the workgroup in the credentials file.
Whitespace cleanup.
This fixes bug #4541.
Patch based on proposed patch from Christian Perrier <bubulle@debian.org>.
Thanks for reporting and providing a patch!
Karolin
Björn Jacke [Thu, 8 Jan 2009 18:14:48 +0000 (19:14 +0100)]
fix syntax error in case statement
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 8 Jan 2009 14:38:47 +0000 (15:38 +0100)]
s3:smbd: handle incoming smb requests via event handlers
We use a fd event and receive incoming smb requests
when the fd becomes readable. It's not completely
nonblocking yet, but it should behave like the old code.
We use timed events to trigger retries for deferred open calls.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 18:45:13 +0000 (19:45 +0100)]
s3:events: debug sys_select() errors
metze
Stefan Metzmacher [Thu, 8 Jan 2009 14:16:51 +0000 (15:16 +0100)]
s3:events: install a tevent debug handler that calls DEBUG()
metze
Andrew Bartlett [Fri, 9 Jan 2009 01:06:18 +0000 (12:06 +1100)]
Only do special DN tracking for normal DNs in OpenLDAP backend.
This means trying (again, harder), not to do this for DN+Binary and
DN+String attributes.
Andrew Bartlett
Jeremy Allison [Thu, 8 Jan 2009 23:41:49 +0000 (15:41 -0800)]
Fix bug #6021 - smbclient du command does not recuse properly
Jeremy.
Volker Lendecke [Wed, 7 Jan 2009 17:44:52 +0000 (18:44 +0100)]
Now that all policy_handle free_fn's are just TALLOC_FREE, dump free_fn
Volker Lendecke [Wed, 7 Jan 2009 17:11:24 +0000 (18:11 +0100)]
Use TALLOC for struct lsa_info
Volker Lendecke [Wed, 7 Jan 2009 17:06:21 +0000 (18:06 +0100)]
Make use of a talloc_destructor for free_printer_entry
Volker Lendecke [Wed, 7 Jan 2009 16:56:08 +0000 (17:56 +0100)]
Make use of a talloc_destructor for free_eventlog_info()
Volker Lendecke [Wed, 7 Jan 2009 16:48:10 +0000 (17:48 +0100)]
Make samr_info a talloc context of its own
Volker Lendecke [Wed, 7 Jan 2009 16:36:54 +0000 (17:36 +0100)]
Simplify init_pipe_handle_list a bit
Günther Deschner [Thu, 8 Jan 2009 18:13:22 +0000 (19:13 +0100)]
s3-rpcclient: add eventlog test client.
Guenther
Günther Deschner [Thu, 8 Jan 2009 18:12:59 +0000 (19:12 +0100)]
s3-eventlog: minor cosmetics.
Guenther
Günther Deschner [Thu, 8 Jan 2009 17:39:12 +0000 (18:39 +0100)]
s3-eventlog: trying to make eventlog_io_q_read_eventlog readable.
Guenther
Günther Deschner [Thu, 8 Jan 2009 17:02:51 +0000 (18:02 +0100)]
s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server.
Jerry, please check.
Guenther
Jeremy Allison [Thu, 8 Jan 2009 18:36:10 +0000 (10:36 -0800)]
Fix race condition in alarm lock processing noticed by Richard Sharpe <realrichardsharpe@gmail.com>.
"It seems to me that if the lock is already held by another process when we
enter this code, there is a race between the timeout and the granting. If
the lock is subsequently granted, the process releasing the lock will signal
the wait variable (or whatever) and our process will be scheduled. However,
if the timeout occurs before we are scheduled, the timeout will be delivered
first.
We will have the lock but will forget we have the lock, and never release
it."
Jeremy.
Günther Deschner [Thu, 8 Jan 2009 18:15:41 +0000 (19:15 +0100)]
s3-net: fix type in rpc_service_list_internal(). Sorry...
Guenther
Günther Deschner [Thu, 8 Jan 2009 16:28:20 +0000 (17:28 +0100)]
s4-smbtorture: extend test_QueryServiceConfig2W a bit.
Guenther
Günther Deschner [Thu, 8 Jan 2009 15:54:08 +0000 (16:54 +0100)]
s4-smbtorture: fix build of svcctl torture test.
Guenther
Günther Deschner [Thu, 8 Jan 2009 14:45:09 +0000 (15:45 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 8 Jan 2009 15:49:47 +0000 (16:49 +0100)]
svcctl: use svcctl_ServiceState in some other places.
Guenther
Günther Deschner [Thu, 8 Jan 2009 15:49:18 +0000 (16:49 +0100)]
svcctl: use hex range format in IDL.
Guenther
Günther Deschner [Thu, 8 Jan 2009 15:44:54 +0000 (16:44 +0100)]
svcctl: add ENUM_SERVICE_STATUSW and ENUM_SERVICE_STATUSA.
Guenther
Günther Deschner [Thu, 8 Jan 2009 14:43:49 +0000 (15:43 +0100)]
svcctl: remove redundant SERVICE_STATE_* defines.
Guenther
Stefan Metzmacher [Thu, 8 Jan 2009 15:23:59 +0000 (16:23 +0100)]
s3:smbd: fix the build with dmapi support
struct smbd_dmapi_context *dmapi_ctx;
is in globals.c
metze
Stefan Metzmacher [Thu, 8 Jan 2009 14:57:59 +0000 (15:57 +0100)]
s4:blackbox: don't remove newlines in the subunit failure output
metze
Stefan Metzmacher [Thu, 8 Jan 2009 14:15:46 +0000 (15:15 +0100)]
s4:events: don't trigger \n in debug messages two times
metze
Jelmer Vernooij [Thu, 8 Jan 2009 14:47:34 +0000 (15:47 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Volker Lendecke [Thu, 8 Jan 2009 14:25:50 +0000 (15:25 +0100)]
Attempt to fix the build
Jelmer Vernooij [Thu, 8 Jan 2009 14:23:35 +0000 (15:23 +0100)]
Make sure smbtorture4 can find all gensec modules. (Fixes RPC-BINDSAMBA3)
Günther Deschner [Thu, 8 Jan 2009 12:23:59 +0000 (13:23 +0100)]
s3-svcctl: use pidl based struct SERVICE_STATUS.
Guenther
Günther Deschner [Thu, 8 Jan 2009 12:08:18 +0000 (13:08 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 8 Jan 2009 12:06:38 +0000 (13:06 +0100)]
s3-svcctl: add copyright to svcctl rpc_server.
Guenther
Günther Deschner [Thu, 8 Jan 2009 12:05:29 +0000 (13:05 +0100)]
s3-svcctl: remove some more redundant headers.
Guenther
Günther Deschner [Thu, 8 Jan 2009 11:46:54 +0000 (12:46 +0100)]
s3-svcctl: move SVC_HANDLE_IS* defines to implementation specific header file.
Guenther
Günther Deschner [Thu, 8 Jan 2009 11:40:25 +0000 (12:40 +0100)]
s3-svcctl: remove (now duplicate) defines.
Guenther
Günther Deschner [Thu, 8 Jan 2009 11:39:50 +0000 (12:39 +0100)]
svcctl: add svcctl_ServiceStatus and svcctl_ControlsAccepted.
Guenther
Günther Deschner [Thu, 8 Jan 2009 11:28:35 +0000 (12:28 +0100)]
s3-svcctl: remove (now duplicate) SVCCTL_STAT* defines.
Guenther
Jelmer Vernooij [Thu, 8 Jan 2009 12:15:10 +0000 (13:15 +0100)]
Don't attempt to use GNUTLS >= 2.6, as it is known broken with the socket-tls backend.
Jelmer Vernooij [Thu, 8 Jan 2009 11:51:19 +0000 (12:51 +0100)]
Fix ldap.py test on systems that *can* find the record (the search fails here locally).
Jelmer Vernooij [Thu, 8 Jan 2009 11:45:57 +0000 (12:45 +0100)]
Print the failed value in the time tests.
Jelmer Vernooij [Thu, 8 Jan 2009 11:27:52 +0000 (12:27 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Stefan Metzmacher [Thu, 8 Jan 2009 11:03:45 +0000 (12:03 +0100)]
s3:smbd: move all globals and static variables in globals.[ch]
The goal is to move all this variables into a big context structure.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 11:00:15 +0000 (12:00 +0100)]
s3:smbd: variables in a main() don't need to be static
metze
Stefan Metzmacher [Thu, 8 Jan 2009 10:52:52 +0000 (11:52 +0100)]
s3:smbd: open_sockets_smbd() don't need a static variable arrount atexit()
open_sockets_smbd() is only called once.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 10:37:06 +0000 (11:37 +0100)]
s3:smbd: keep dmapi globals in one context struct
metze
Stefan Metzmacher [Thu, 8 Jan 2009 09:43:10 +0000 (10:43 +0100)]
s3:smbd: remove stupid static variables for the nfs quota code
metze
Stefan Metzmacher [Thu, 8 Jan 2009 08:04:30 +0000 (09:04 +0100)]
s3:smbd: remove pointless static variable in uid.c
We always free the value at the end of the function,
so we don't need a static variable to hold just NULL
for the time the function isn't executed.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 08:02:21 +0000 (09:02 +0100)]
s3:smbd: make static const in mangle_hash2.c really static const
const char *foo, means a non-const pointer to
a const char.
const char * const foo, means a const pointer to
a const char.
char * const foo, would mean a const pointer to
a non-const char.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:57:52 +0000 (08:57 +0100)]
s3:smbd: make const globals in mangle_hash2.c really static const
const char *foo, means a non-const pointer to
a const char.
const char * const foo, means a const pointer to
a const char.
char * const foo, would mean a const pointer to
a non-const char.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:51:41 +0000 (08:51 +0100)]
s3:smbd: make globals in utmp.c static const
const char *foo, means a non-const pointer to
a const char.
const char * const foo, means a const pointer to
a const char.
char * const foo, would mean a const pointer to
a non-const char.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:50:36 +0000 (08:50 +0100)]
s3:smbd: it's pointless to have a global magic_char
We call magic_char = lp_magicchar(p) each time it's used.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:47:57 +0000 (08:47 +0100)]
s3:smbd: remove pointless static variables in chgpasswd.c
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:38:01 +0000 (08:38 +0100)]
s3:smbd: make fake_files[] static const
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:36:24 +0000 (08:36 +0100)]
s3:smbd: make mangle_fns const
metze
Jelmer Vernooij [Thu, 8 Jan 2009 11:20:20 +0000 (12:20 +0100)]
Avoid using a utility header for Python replacements included in Samba,
since this will not be shipped with talloc/tdb/tevent/etc.
Günther Deschner [Wed, 7 Jan 2009 14:05:28 +0000 (15:05 +0100)]
s3-svcctl: remove old hand marshalling of svcctl_QueryServiceConfig2W.
Guenther
Günther Deschner [Wed, 7 Jan 2009 14:05:01 +0000 (15:05 +0100)]
s3-svcctl: use pidl for _svcctl_QueryServiceConfig2W.
Guenther
Günther Deschner [Wed, 7 Jan 2009 11:38:23 +0000 (12:38 +0100)]
s3-svcctl: fix return code for _svcctl_QueryServiceStatusEx.
Guenther
Günther Deschner [Tue, 6 Jan 2009 18:00:05 +0000 (19:00 +0100)]
s3-svcctl: remove old hand marshalling of svcctl_QueryServiceStatusEx.
Guenther
Günther Deschner [Tue, 6 Jan 2009 17:59:44 +0000 (18:59 +0100)]
s3-svcctl: use pidl for _svcctl_QueryServiceStatusEx.
Guenther
Günther Deschner [Fri, 14 Nov 2008 12:49:36 +0000 (13:49 +0100)]
s4-smbtorture: use names for info level in test_QueryServiceStatusEx.
Guenther
Günther Deschner [Fri, 14 Nov 2008 12:48:59 +0000 (13:48 +0100)]
s4-smbtorture: add my copyright to svcctl test.
Guenther
Günther Deschner [Wed, 7 Jan 2009 14:06:04 +0000 (15:06 +0100)]
s3-svcctl: use pidl's ndr opcodes for NDR_SVCCTL_QUERYSERVICECONFIGW.
Guenther
Günther Deschner [Tue, 6 Jan 2009 17:19:29 +0000 (18:19 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 7 Jan 2009 16:50:09 +0000 (17:50 +0100)]
svcctl: add svcctl_ServiceState.
Guenther
Günther Deschner [Wed, 7 Jan 2009 14:03:45 +0000 (15:03 +0100)]
svcctl: add SERVICE_FAILURE_ACTIONS and SERVICE_DESCRIPTION to IDL.
Guenther
Günther Deschner [Tue, 6 Jan 2009 17:58:18 +0000 (18:58 +0100)]
svcctl: add SERVICE_STATUS_PROCESS to idl.
Guenther
Günther Deschner [Tue, 6 Jan 2009 17:15:01 +0000 (18:15 +0100)]
svcctl: add svcctl_ErrorControl and svcctl_Type (based on samba3) to IDL.
Guenther
Günther Deschner [Fri, 14 Nov 2008 11:03:18 +0000 (12:03 +0100)]
svcctl: add svcctl_ConfigLevel from samba 3.
Guenther
Günther Deschner [Fri, 14 Nov 2008 10:58:12 +0000 (11:58 +0100)]
svcctl: move SVC_STATUS_ to idl.
Guenther
Tim Prouty [Wed, 7 Jan 2009 22:33:25 +0000 (14:33 -0800)]
s3/s4 build: Fix Py_RETURN_NONE to work with python versions < 2.4
Tim Prouty [Wed, 7 Jan 2009 21:12:35 +0000 (13:12 -0800)]
s3 merged build: Fix include error
On some builds compiling source4/ntvfs/common/brlock_tdb.c was failing
because tdb_wrap.h couldn't find tdb.h. Adding the path should fix
the problem.
Jeremy Allison [Wed, 7 Jan 2009 22:57:20 +0000 (14:57 -0800)]
Fix bug #6016 - Alternate Data Streams / Extended Attributes seem to conflict.
Jeremy.
Jelmer Vernooij [Wed, 7 Jan 2009 21:40:49 +0000 (22:40 +0100)]
Display lsa string contents.
Jelmer Vernooij [Wed, 7 Jan 2009 21:40:13 +0000 (22:40 +0100)]
Set proper python exception when running out of memory.
Jelmer Vernooij [Wed, 7 Jan 2009 20:45:49 +0000 (21:45 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
boyang [Wed, 7 Jan 2009 19:02:04 +0000 (11:02 -0800)]
refresh sequence number as soon as possible when domain->sequence_number == -1 or domain->last_status is not ok.
Volker Lendecke [Wed, 7 Jan 2009 16:15:47 +0000 (17:15 +0100)]
Remove unused struct CLI_POLICY_HND
Volker Lendecke [Wed, 7 Jan 2009 10:39:34 +0000 (10:39 +0000)]
Several fixes to our use of splice
The splice manpage explicitly requires loff_t as offset. Copy "offset" there.
Probably not required, but I wanted to make sure it's as required.
Splice blocks with large buffers. For me it worked with 16k and blocked with
32k and beyond. It would be nice to see a clarification in the manpage of
splice for this behaviour.
Splice if used with an offset increments the offset. From the manpage this was
at least not entirely obvious :-)
I haven't yet activated this (try_splice_call ist still false by default), it
needs more testing.
Volker
Jelmer Vernooij [Wed, 7 Jan 2009 10:06:00 +0000 (11:06 +0100)]
Fix ldap.py test.
Andrew Bartlett [Wed, 7 Jan 2009 05:30:05 +0000 (16:30 +1100)]
Use new error constant (missing from
6efb7ff9)
Andrew Bartlett [Wed, 7 Jan 2009 05:29:23 +0000 (16:29 +1100)]
Raise a python exception when the ldb search fails
This fixes a regression found by ldap.py in the new hand-written
python bindings.
Andrew Bartlett
Andrew Tridgell [Wed, 7 Jan 2009 05:46:34 +0000 (16:46 +1100)]
added support for stream renames in Samba4
This allows the RAW-STREAMS test to work again. We still have some
limitations though:
- renames of a stream to the default stream doesn't work
- delete on close handling between streams and the main file
is still broken
Stefan Metzmacher [Wed, 7 Jan 2009 05:32:25 +0000 (06:32 +0100)]
s4:smbclient: correct initialize smbclient_context
Found by valgrind.
metze
Stefan Metzmacher [Wed, 7 Jan 2009 05:30:37 +0000 (06:30 +0100)]
tevent: don't try to dereference fde->event_ctx when the event context doesn't exists anymore
metze
Jeremy Allison [Wed, 7 Jan 2009 01:34:06 +0000 (17:34 -0800)]
Make winbindd_cm.c use winbindd_reinit_after_fork().
Jeremy.
Jeremy Allison [Wed, 7 Jan 2009 00:05:28 +0000 (16:05 -0800)]
Fix bug #6017, - magic script does not work. based on a patch from monyo@samba.gr.jp.
Jeremy.
Jeremy Allison [Tue, 6 Jan 2009 23:14:52 +0000 (15:14 -0800)]
Add winbindd_reinit_after_fork(), cleaning out all possible events
in a forked child.
Jeremy.
Jelmer Vernooij [Tue, 6 Jan 2009 22:52:34 +0000 (23:52 +0100)]
Start on alpha6 release notes.
Volker Lendecke [Tue, 6 Jan 2009 22:25:41 +0000 (23:25 +0100)]
Add a talloc failure check
Jelmer Vernooij [Tue, 6 Jan 2009 21:36:01 +0000 (22:36 +0100)]
When loading the default configuration, allow the configuration file to be
missing.
Jeremy Allison [Tue, 6 Jan 2009 21:16:46 +0000 (13:16 -0800)]
Factor out lots of common code into a function.
Jeremy.
Volker Lendecke [Tue, 6 Jan 2009 20:54:51 +0000 (21:54 +0100)]
Add some const to dcerpc_binding_build_tower()