Evan Huus [Tue, 18 Jun 2013 21:42:54 +0000 (21:42 -0000)]
Resurrect wmem_memdup in its own misc. utilities group. Emem provides it, so we
need to provide an analogue at least for now.
svn path=/trunk/; revision=50018
Evan Huus [Tue, 18 Jun 2013 21:25:37 +0000 (21:25 -0000)]
Add wmem_alloc_array, wmem_strsplit, wmem_strconcat.
svn path=/trunk/; revision=50017
Martin Mathieson [Tue, 18 Jun 2013 21:02:00 +0000 (21:02 -0000)]
Configure MAC LCID -> RLC channel settings from RRC.
svn path=/trunk/; revision=50016
Jakub Zawadzki [Tue, 18 Jun 2013 20:52:31 +0000 (20:52 -0000)]
Pass hfinfo and not hfindex to internal proto functions.
svn path=/trunk/; revision=50015
Michael Mann [Tue, 18 Jun 2013 20:48:42 +0000 (20:48 -0000)]
Update "TTL low or unexpected" coloring rule to ignore vrrp, carp and MulticastDNS all of which intentionally use TTL 255. Bug 5010 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5010)
Add carp to routing protocols while we're at it.
svn path=/trunk/; revision=50014
Evan Huus [Tue, 18 Jun 2013 19:55:29 +0000 (19:55 -0000)]
Refactor insert32 to use lookup_or_insert32 with the right flags.
svn path=/trunk/; revision=50013
Evan Huus [Tue, 18 Jun 2013 19:43:18 +0000 (19:43 -0000)]
Refactor lookup_or_insert32 to remove a bunch of continue and break statements
as well as a confusing while(TRUE).
svn path=/trunk/; revision=50012
Evan Huus [Tue, 18 Jun 2013 19:32:40 +0000 (19:32 -0000)]
Simplify node structure. Use a boolean for whether or not it's a subtree, and an
enum for the color (red/black). Don't use bitfields since they don't save us
much (if anything) in terms of space and don't nest the fields in their own
anonymous struct.
svn path=/trunk/; revision=50011
Evan Huus [Tue, 18 Jun 2013 19:19:21 +0000 (19:19 -0000)]
Factor function for node creation out and use it in several places.
svn path=/trunk/; revision=50010
Evan Huus [Tue, 18 Jun 2013 19:01:01 +0000 (19:01 -0000)]
Scrap wmem_memdup, it's not actually as useful as I thought it would be.
svn path=/trunk/; revision=50009
Evan Huus [Tue, 18 Jun 2013 18:57:28 +0000 (18:57 -0000)]
Factor common code for red-black tree array lookups into a helper function and
use it for both direct lookups and less-than-or-equal-to lookups.
svn path=/trunk/; revision=50008
Evan Huus [Tue, 18 Jun 2013 17:48:04 +0000 (17:48 -0000)]
Remove wmem_tree_create_subtree, it does nothing we can't do with
wmem_tree_new.
svn path=/trunk/; revision=50007
Evan Huus [Tue, 18 Jun 2013 17:39:15 +0000 (17:39 -0000)]
Factor string-packing code into a common function to use in both insert_string
and lookup_string.
svn path=/trunk/; revision=50006
Jörg Mayer [Tue, 18 Jun 2013 12:22:40 +0000 (12:22 -0000)]
Fix compile error:
[ 79%] Building C object CMakeFiles/text2pcap.dir/text2pcap.c.o
In file included from /usr/include/glib-2.0/glib/galloca.h:34:0,
from /usr/include/glib-2.0/glib.h:32,
from /home/jmayer/work/wireshark/svn/trunk/wsutil/file_util.h:34,
from /home/jmayer/work/wireshark/svn/trunk/text2pcap.c:116:
/home/jmayer/work/wireshark/svn/trunk/text2pcap.c: In function ‘write_current_packet’:
/usr/include/glib-2.0/glib/gtypes.h:186:22: error: declaration of ‘__v’ shadows a previous local [-Werror=shadow]
({ register guint16 __v, __x = ((guint16) (val)); \
^
/usr/include/glib-2.0/glib/gtypes.h:237:38: note: in expansion of macro ‘GUINT16_SWAP_LE_BE_IA32’
# define GUINT16_SWAP_LE_BE(val) (GUINT16_SWAP_LE_BE_IA32 (val))
^
/usr/lib/glib-2.0/include/glibconfig.h:192:29: note: in expansion of macro ‘GUINT16_SWAP_LE_BE’
#define GUINT16_TO_BE(val) (GUINT16_SWAP_LE_BE (val))
^
/usr/include/glib-2.0/glib/gtypes.h:359:23: note: in expansion of macro ‘GUINT16_TO_BE’
#define g_htons(val) (GUINT16_TO_BE (val))
^
/home/jmayer/work/wireshark/svn/trunk/text2pcap.c:705:35: note: in expansion of macro ‘g_htons’
pseudoh.length = g_htons(length - g_ntohs(HDR_IPv6.ip6_ctlun.ip6_un1.ip6_un1_plen) + sizeof(HDR_UDP));
^
/usr/include/glib-2.0/glib/gtypes.h:237:38: note: in expansion of macro ‘GUINT16_SWAP_LE_BE_IA32’
# define GUINT16_SWAP_LE_BE(val) (GUINT16_SWAP_LE_BE_IA32 (val))
^
/usr/lib/glib-2.0/include/glibconfig.h:192:29: note: in expansion of macro ‘GUINT16_SWAP_LE_BE’
#define GUINT16_TO_BE(val) (GUINT16_SWAP_LE_BE (val))
^
/usr/include/glib-2.0/glib/gtypes.h:327:31: note: in expansion of macro ‘GUINT16_TO_BE’
#define GUINT16_FROM_BE(val) (GUINT16_TO_BE (val))
^
/usr/include/glib-2.0/glib/gtypes.h:357:23: note: in expansion of macro ‘GUINT16_FROM_BE’
#define g_ntohs(val) (GUINT16_FROM_BE (val))
^
/home/jmayer/work/wireshark/svn/trunk/text2pcap.c:705:52: note: in expansion of macro ‘g_ntohs’
pseudoh.length = g_htons(length - g_ntohs(HDR_IPv6.ip6_ctlun.ip6_un1.ip6_un1_plen) + sizeof(HDR_UDP));
^
/usr/include/glib-2.0/glib/gtypes.h:186:22: error: shadowed declaration is here [-Werror=shadow]
({ register guint16 __v, __x = ((guint16) (val)); \
^
/usr/include/glib-2.0/glib/gtypes.h:237:38: note: in expansion of macro ‘GUINT16_SWAP_LE_BE_IA32’
# define GUINT16_SWAP_LE_BE(val) (GUINT16_SWAP_LE_BE_IA32 (val))
^
/usr/lib/glib-2.0/include/glibconfig.h:192:29: note: in expansion of macro ‘GUINT16_SWAP_LE_BE’
#define GUINT16_TO_BE(val) (GUINT16_SWAP_LE_BE (val))
^
/usr/include/glib-2.0/glib/gtypes.h:359:23: note: in expansion of macro ‘GUINT16_TO_BE’
#define g_htons(val) (GUINT16_TO_BE (val))
^
/home/jmayer/work/wireshark/svn/trunk/text2pcap.c:705:35: note: in expansion of macro ‘g_htons’
pseudoh.length = g_htons(length - g_ntohs(HDR_IPv6.ip6_ctlun.ip6_un1.ip6_un1_plen) + sizeof(HDR_UDP));
^
/usr/include/glib-2.0/glib/gtypes.h:186:27: error: declaration of ‘__x’ shadows a previous local [-Werror=shadow]
({ register guint16 __v, __x = ((guint16) (val)); \
^
/usr/include/glib-2.0/glib/gtypes.h:237:38: note: in expansion of macro ‘GUINT16_SWAP_LE_BE_IA32’
# define GUINT16_SWAP_LE_BE(val) (GUINT16_SWAP_LE_BE_IA32 (val))
^
/usr/lib/glib-2.0/include/glibconfig.h:192:29: note: in expansion of macro ‘GUINT16_SWAP_LE_BE’
#define GUINT16_TO_BE(val) (GUINT16_SWAP_LE_BE (val))
^
/usr/include/glib-2.0/glib/gtypes.h:359:23: note: in expansion of macro ‘GUINT16_TO_BE’
#define g_htons(val) (GUINT16_TO_BE (val))
^
/home/jmayer/work/wireshark/svn/trunk/text2pcap.c:705:35: note: in expansion of macro ‘g_htons’
pseudoh.length = g_htons(length - g_ntohs(HDR_IPv6.ip6_ctlun.ip6_un1.ip6_un1_plen) + sizeof(HDR_UDP));
^
/usr/include/glib-2.0/glib/gtypes.h:237:38: note: in expansion of macro ‘GUINT16_SWAP_LE_BE_IA32’
# define GUINT16_SWAP_LE_BE(val) (GUINT16_SWAP_LE_BE_IA32 (val))
^
/usr/lib/glib-2.0/include/glibconfig.h:192:29: note: in expansion of macro ‘GUINT16_SWAP_LE_BE’
#define GUINT16_TO_BE(val) (GUINT16_SWAP_LE_BE (val))
^
/usr/include/glib-2.0/glib/gtypes.h:327:31: note: in expansion of macro ‘GUINT16_TO_BE’
#define GUINT16_FROM_BE(val) (GUINT16_TO_BE (val))
^
/usr/include/glib-2.0/glib/gtypes.h:357:23: note: in expansion of macro ‘GUINT16_FROM_BE’
#define g_ntohs(val) (GUINT16_FROM_BE (val))
^
/home/jmayer/work/wireshark/svn/trunk/text2pcap.c:705:52: note: in expansion of macro ‘g_ntohs’
pseudoh.length = g_htons(length - g_ntohs(HDR_IPv6.ip6_ctlun.ip6_un1.ip6_un1_plen) + sizeof(HDR_UDP));
^
/usr/include/glib-2.0/glib/gtypes.h:186:27: error: shadowed declaration is here [-Werror=shadow]
({ register guint16 __v, __x = ((guint16) (val)); \
^
/usr/include/glib-2.0/glib/gtypes.h:237:38: note: in expansion of macro ‘GUINT16_SWAP_LE_BE_IA32’
# define GUINT16_SWAP_LE_BE(val) (GUINT16_SWAP_LE_BE_IA32 (val))
^
/usr/lib/glib-2.0/include/glibconfig.h:192:29: note: in expansion of macro ‘GUINT16_SWAP_LE_BE’
#define GUINT16_TO_BE(val) (GUINT16_SWAP_LE_BE (val))
^
/usr/include/glib-2.0/glib/gtypes.h:359:23: note: in expansion of macro ‘GUINT16_TO_BE’
#define g_htons(val) (GUINT16_TO_BE (val))
^
/home/jmayer/work/wireshark/svn/trunk/text2pcap.c:705:35: note: in expansion of macro ‘g_htons’
pseudoh.length = g_htons(length - g_ntohs(HDR_IPv6.ip6_ctlun.ip6_un1.ip6_un1_plen) + sizeof(HDR_UDP));
^
cc1: all warnings being treated as errors
make[2]: *** [CMakeFiles/text2pcap.dir/text2pcap.c.o] Error 1
Feel free to choose a less offensive variable name
svn path=/trunk/; revision=50005
Evan Huus [Tue, 18 Jun 2013 06:22:47 +0000 (06:22 -0000)]
Add test block for wmem_tree_lookup32_array_le(), fix other tests where certain
random seeds would cause collisions and false failures.
svn path=/trunk/; revision=50004
Evan Huus [Tue, 18 Jun 2013 05:41:16 +0000 (05:41 -0000)]
Wmem tree tests with non-trivial keys.
svn path=/trunk/; revision=50003
Evan Huus [Tue, 18 Jun 2013 05:31:12 +0000 (05:31 -0000)]
Re-port a bunch of the red-black tree code from wmem with fewer modifications,
and enable the tests.
Lesson: make it work, *then* refactor it into sanity.
svn path=/trunk/; revision=50002
Pascal Quantin [Tue, 18 Jun 2013 01:13:07 +0000 (01:13 -0000)]
Add ability to export decrypted SSL/DTLS PDUs
svn path=/trunk/; revision=50001
Jeff Morriss [Tue, 18 Jun 2013 01:08:17 +0000 (01:08 -0000)]
From Anders:
Use integers intead of strings for hf_sync_timestamp
And hf_sync_packet_nr.
Ad ref. to specification.
svn path=/trunk/; revision=50000
Evan Huus [Tue, 18 Jun 2013 01:02:26 +0000 (01:02 -0000)]
Don't limit the on-the-wire length of packets to 64KB, there are larger packets
out there (especially over USB) and we should be able to load them as long as
they are snapped to a sane length.
Also validate that packets do not specify a snapshot length larger than the one
in the file header, though only make it a warning, as this is not necessarily a
fatally corrupt packet.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8808
svn path=/trunk/; revision=49999
Evan Huus [Tue, 18 Jun 2013 00:21:32 +0000 (00:21 -0000)]
Add tests for red-black tree array keys, if0-ed out until I can make them not
blow up. Not sure if the tests are wrong or if I broke something during the port
from wmem...
svn path=/trunk/; revision=49998
Luis Ontanon [Mon, 17 Jun 2013 23:45:42 +0000 (23:45 -0000)]
Yet another iteration
svn path=/trunk/; revision=49997
Guy Harris [Mon, 17 Jun 2013 23:43:55 +0000 (23:43 -0000)]
Put the code to fill in the struct wtap_pkthdr and to read the packet
data into a common routine, and use it in both the read and seek-read
routines.
svn path=/trunk/; revision=49996
Gerald Combs [Mon, 17 Jun 2013 23:30:56 +0000 (23:30 -0000)]
From Dirk Jagdmann via bug 7525: macosx-setup.sh improvements.
svn path=/trunk/; revision=49995
Alexis La Goutte [Mon, 17 Jun 2013 22:56:35 +0000 (22:56 -0000)]
Fix qt make buildbot step
Qt make don't like cp ../../lib/lib{wireshark,wiretap,wsutil}.* .
cp: cannot stat `../../lib/lib{wireshark,wiretap,wsutil}.*': No such file or directory
svn path=/trunk/; revision=49994
Evan Huus [Mon, 17 Jun 2013 22:51:50 +0000 (22:51 -0000)]
Extract some common code for array lookups, and replace some DISSECTOR
assertions with regular glib assertions - there's no guarantee that wmem code
will always be run from within a dissector.
svn path=/trunk/; revision=49993
Evan Huus [Mon, 17 Jun 2013 22:41:43 +0000 (22:41 -0000)]
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8810
Use value_string array names_nfs4_operation_ext for nfs.main_opname, just like
nfs.opname does.
svn path=/trunk/; revision=49992
Evan Huus [Mon, 17 Jun 2013 22:22:17 +0000 (22:22 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8809
The LLRP Standard 1.0.1 defines the ProtocolID Parameter as 8 bit value (see
LLRP Standard 1.0.1 document, page 138, AccessSpecParameter) but Wireshark
treats it as 16 bit value and therefore doesn't recognize the
EPCGlobalClass1Gen2 protocol type and marks the whole packet afterwards as
invalid.
svn path=/trunk/; revision=49991
Guy Harris [Mon, 17 Jun 2013 22:18:24 +0000 (22:18 -0000)]
Merge more of the read and seek-read code paths.
svn path=/trunk/; revision=49990
Pascal Quantin [Mon, 17 Jun 2013 21:54:21 +0000 (21:54 -0000)]
More PDU export work:
- add automatic export of port type when exporting a source / destination port
- add export of SCTP PPID (usefulness to be checked)
- fix some field size
svn path=/trunk/; revision=49989
Guy Harris [Mon, 17 Jun 2013 21:18:47 +0000 (21:18 -0000)]
Merge "read record header" and "read packet data" routines into a single
routine, used both by read and seek-read routines.
svn path=/trunk/; revision=49988
Pascal Quantin [Mon, 17 Jun 2013 19:52:01 +0000 (19:52 -0000)]
Fix 7bit ASCII / IA5 SMS dissection broken in r49910
svn path=/trunk/; revision=49986
Evan Huus [Mon, 17 Jun 2013 19:25:45 +0000 (19:25 -0000)]
Ensure that the length parameter to dissect_per_length_determinant is
initialized even in cases where we error or otherwise fail to dissect.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8722
Thanks to Pascal for his help digging through this one.
svn path=/trunk/; revision=49985
Pascal Quantin [Mon, 17 Jun 2013 18:44:19 +0000 (18:44 -0000)]
Apply r49983 to other dissectors
svn path=/trunk/; revision=49984
Chris Maynard [Mon, 17 Jun 2013 15:39:56 +0000 (15:39 -0000)]
tvb_length_remaining() can return -1 so don't cast its return value to an unsigned type when performing integer comparisons. Instead, cast strlen()'s return value to a signed type and perform the comparison that way.
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=49983
Evan Huus [Mon, 17 Jun 2013 14:18:23 +0000 (14:18 -0000)]
Misc tweaks to packet-http-urlencoded.c
- add modelines
- convert emem to wmem
- add cast to satisfy my version of GCC
svn path=/trunk/; revision=49982
Luis Ontanon [Mon, 17 Jun 2013 09:17:48 +0000 (09:17 -0000)]
the Licence
svn path=/trunk/; revision=49981
Luis Ontanon [Mon, 17 Jun 2013 09:11:30 +0000 (09:11 -0000)]
Checking in as it compiles...
svn path=/trunk/; revision=49980
Michael Tüxen [Mon, 17 Jun 2013 08:08:14 +0000 (08:08 -0000)]
Fix typo.
svn path=/trunk/; revision=49979
Jakub Zawadzki [Mon, 17 Jun 2013 07:41:48 +0000 (07:41 -0000)]
Fix for previous commit, don't use string if get_form_key_value() failed.
svn path=/trunk/; revision=49978
Jakub Zawadzki [Mon, 17 Jun 2013 07:35:30 +0000 (07:35 -0000)]
Add small dissector for application/x-www-form-urlencoded
svn path=/trunk/; revision=49977
Stig Bjørlykke [Mon, 17 Jun 2013 07:20:54 +0000 (07:20 -0000)]
Added a missing CFRelease.
svn path=/trunk/; revision=49976
Stig Bjørlykke [Mon, 17 Jun 2013 07:20:23 +0000 (07:20 -0000)]
Added a missing CFRelease.
svn path=/trunk/; revision=49975
Pascal Quantin [Mon, 17 Jun 2013 04:26:16 +0000 (04:26 -0000)]
Use a more compact display for the status bitmap
svn path=/trunk/; revision=49974
Pascal Quantin [Mon, 17 Jun 2013 04:22:45 +0000 (04:22 -0000)]
Remove preceding zeroes
svn path=/trunk/; revision=49973
Martin Kaiser [Mon, 17 Jun 2013 00:57:16 +0000 (00:57 -0000)]
the dos2unix cygwin package is required for compiling on windows
svn path=/trunk/; revision=49972
Evan Huus [Mon, 17 Jun 2013 00:45:44 +0000 (00:45 -0000)]
Fix the test to respect the new behaviour.
svn path=/trunk/; revision=49971
Evan Huus [Mon, 17 Jun 2013 00:08:44 +0000 (00:08 -0000)]
Much smarter handling of autoreset trees.
svn path=/trunk/; revision=49970
Evan Huus [Sun, 16 Jun 2013 22:37:55 +0000 (22:37 -0000)]
More callback tweaks, to permit unregistering a callback from the same place
it was originally registered.
svn path=/trunk/; revision=49969
Evan Huus [Sun, 16 Jun 2013 22:25:27 +0000 (22:25 -0000)]
Fix include to use "" not <> for local headers.
svn path=/trunk/; revision=49968
Evan Huus [Sun, 16 Jun 2013 22:08:56 +0000 (22:08 -0000)]
Update wmem README for the tree implementation.
svn path=/trunk/; revision=49967
Evan Huus [Sun, 16 Jun 2013 22:07:24 +0000 (22:07 -0000)]
Rework the user callback code a bit to make it saner to use with the auto-reset
trees.
svn path=/trunk/; revision=49966
Luis Ontanon [Sun, 16 Jun 2013 19:44:32 +0000 (19:44 -0000)]
rename epan_child.h
svn path=/trunk/; revision=49965
Michael Mann [Sun, 16 Jun 2013 16:50:17 +0000 (16:50 -0000)]
Prepend custom Destination IP and Source IP (ipv4 or ipv6) in the pcap. Bug 5650 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5650)
svn path=/trunk/; revision=49964
Martin Kaiser [Sun, 16 Jun 2013 15:29:14 +0000 (15:29 -0000)]
fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8806
assign the return values of decode_...() functions to a signed int
check for negative return values
svn path=/trunk/; revision=49963
Evan Huus [Sun, 16 Jun 2013 15:17:53 +0000 (15:17 -0000)]
Simplify the tree code slightly - just don't call the transform function
if it's NULL, meaning we don't need to define an identity callback.
svn path=/trunk/; revision=49962
Martin Mathieson [Sun, 16 Jun 2013 15:11:21 +0000 (15:11 -0000)]
Clarify interface/test for DL HARQ id, and remove a trailing comma from
an enum.
svn path=/trunk/; revision=49961
Martin Mathieson [Sun, 16 Jun 2013 14:24:47 +0000 (14:24 -0000)]
Improve the way PDCP status PDUs are shown.
For the bitmap, present and missing SNs are both
interesting, but only until the last received SN
(i.e. the last byte of the bitmap will be padded
out with zero bits).
It would be possible to use existing sequence analysis
info, where available, to decide if any zeros beyond the last
received SN are interesting...
svn path=/trunk/; revision=49959
Gerald Combs [Sun, 16 Jun 2013 14:03:36 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2013-06-16]
svn path=/trunk/; revision=49957
Luis Ontanon [Sun, 16 Jun 2013 04:34:38 +0000 (04:34 -0000)]
some minor fixes
svn path=/trunk/; revision=49956
Martin Kaiser [Sun, 16 Jun 2013 02:52:01 +0000 (02:52 -0000)]
display some more box names
svn path=/trunk/; revision=49955
Martin Mathieson [Sun, 16 Jun 2013 02:35:51 +0000 (02:35 -0000)]
Make the B->A graph label show as A<-B to be consistent with the column
heading.
svn path=/trunk/; revision=49954
Martin Mathieson [Sun, 16 Jun 2013 01:53:43 +0000 (01:53 -0000)]
Add some comments around looking up names for port numbers.
(calling getservbyname() is really slow, but only called once per port
number...)
svn path=/trunk/; revision=49953
Evan Huus [Sun, 16 Jun 2013 01:47:43 +0000 (01:47 -0000)]
Add warning comment to tree autoreset function about allocator
destruction order, and note that it may need thinking about.
svn path=/trunk/; revision=49952
Evan Huus [Sun, 16 Jun 2013 01:44:09 +0000 (01:44 -0000)]
Fix occasional wmem_test failure, allocator destruction order matters
(should it?)
svn path=/trunk/; revision=49951
Guy Harris [Sun, 16 Jun 2013 01:40:04 +0000 (01:40 -0000)]
Make the libwiretap Buffer routines usable from C++, and fix the C++ UI
code to handle the API changes for the seek-read routines.
svn path=/trunk/; revision=49950
Guy Harris [Sun, 16 Jun 2013 00:20:00 +0000 (00:20 -0000)]
Have the seek-read routines take a Buffer rather than a guint8 pointer
as the "where to put the packet data" argument.
This lets more of the libwiretap code be common between the read and
seek-read code paths, and also allows for more flexibility in the "fill
in the data" path - we can expand the buffer as needed in both cases.
svn path=/trunk/; revision=49949
Michael Mann [Sun, 16 Jun 2013 00:14:07 +0000 (00:14 -0000)]
Replace if-else-if with switch statements
svn path=/trunk/; revision=49948
Luis Ontanon [Sat, 15 Jun 2013 21:28:43 +0000 (21:28 -0000)]
Further iteration
svn path=/trunk/; revision=49947
Chris Maynard [Sat, 15 Jun 2013 12:57:32 +0000 (12:57 -0000)]
Make use of text metrics and devmode data to properly format a page for printing. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7543
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=49946
Evan Huus [Sat, 15 Jun 2013 10:40:56 +0000 (10:40 -0000)]
Most of a red-black tree implementation for wmem, based heavily on the emem
version.
One plane trip's worth of work.
svn path=/trunk/; revision=49945
Guy Harris [Sat, 15 Jun 2013 09:05:04 +0000 (09:05 -0000)]
Pull some of the code to set the struct wtap_pkthdr into
parse_netscreen_hex_dump().
svn path=/trunk/; revision=49944
Guy Harris [Sat, 15 Jun 2013 01:51:21 +0000 (01:51 -0000)]
Fill in at least some of the struct wtap_pkthdr in both the read and
seek-read routines.
svn path=/trunk/; revision=49943
Guy Harris [Fri, 14 Jun 2013 23:59:04 +0000 (23:59 -0000)]
Rename radcom_process_rec_header() to radcom_process_rec_header() and
move the code to file in a struct wtap_pkthdr there.
svn path=/trunk/; revision=49942
Michael Mann [Fri, 14 Jun 2013 19:46:54 +0000 (19:46 -0000)]
Remove check_col() and the occasional tree.
This leaves just the Pidl dissectors remaining for removal of check_col() in the dissectors directory. A small handful of check_col() calls remain outside of the dissectors.
svn path=/trunk/; revision=49941
Luis Ontanon [Fri, 14 Jun 2013 19:19:29 +0000 (19:19 -0000)]
Final draft for the epan working child API
svn path=/trunk/; revision=49940
Chris Maynard [Fri, 14 Jun 2013 17:57:08 +0000 (17:57 -0000)]
Fix IEEE802a OUI lookups.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3123
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=49939
Michael Mann [Fri, 14 Jun 2013 17:49:53 +0000 (17:49 -0000)]
Removed check_col() and the occasional tree.
svn path=/trunk/; revision=49938
Chris Maynard [Fri, 14 Jun 2013 17:47:54 +0000 (17:47 -0000)]
Ensure that Wireshark isn't obscured by the system taskbar or by any other desktop toolbars. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3034
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=49937
Martin Kaiser [Fri, 14 Jun 2013 15:53:52 +0000 (15:53 -0000)]
remove some unnecessary check_col() calls
svn path=/trunk/; revision=49936
Martin Kaiser [Fri, 14 Jun 2013 15:50:20 +0000 (15:50 -0000)]
add editor modelines
svn path=/trunk/; revision=49935
Martin Kaiser [Fri, 14 Jun 2013 15:33:58 +0000 (15:33 -0000)]
new dissector for the MP4/ISOBMFF file format
svn path=/trunk/; revision=49934
Martin Kaiser [Fri, 14 Jun 2013 15:08:10 +0000 (15:08 -0000)]
make line endings consistent
add svn properties
svn path=/trunk/; revision=49933
Evan Huus [Fri, 14 Jun 2013 14:56:00 +0000 (14:56 -0000)]
Mark unused params as such.
svn path=/trunk/; revision=49932
Michael Mann [Fri, 14 Jun 2013 14:35:34 +0000 (14:35 -0000)]
Add Common Address Redundancy Protocol (CARP) dissector, bug 8633 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8633)
From Uli Heilmeier
CARP shares the same protocol ID as VRRP (and VRRP's is IANA registered), so heuristics are provided. VRRP and CARP are very similar, so I'm not sure having heuristics for both dissectors will help CARP.
svn path=/trunk/; revision=49931
Michael Mann [Fri, 14 Jun 2013 14:13:28 +0000 (14:13 -0000)]
Add heuristic capabilities to the IP dissector. The motivating factor was the CARP dissector, bug 8633 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8633)
This should allow the ugly IPIP/TAPA hack to be replaced with a proper heuristic, but I don't see any sample TAPA traces to feel confident in making the change myself.
svn path=/trunk/; revision=49930
Jeff Morriss [Fri, 14 Jun 2013 13:20:41 +0000 (13:20 -0000)]
Add parentheses around assignment used as truth value.
svn path=/trunk/; revision=49929
Jeff Morriss [Fri, 14 Jun 2013 13:08:45 +0000 (13:08 -0000)]
From Anders: add some commands, AVPs, and application IDs.
From me: fix up some white space/indentation.
svn path=/trunk/; revision=49928
Michael Mann [Fri, 14 Jun 2013 12:44:50 +0000 (12:44 -0000)]
Remove check_col() from ASN.1 dissectors
svn path=/trunk/; revision=49927
Jörg Mayer [Fri, 14 Jun 2013 11:44:19 +0000 (11:44 -0000)]
And back it out again, just like the Makefile.am
svn path=/trunk/; revision=49926
Jörg Mayer [Fri, 14 Jun 2013 11:42:40 +0000 (11:42 -0000)]
Copy over
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=49865
to cmake
svn path=/trunk/; revision=49925
Martin Kaiser [Fri, 14 Jun 2013 04:01:21 +0000 (04:01 -0000)]
try_val_to_str() may return NULL
although this is nearly impossible here,
use val_to_str_const() anyway to be on the safe side
svn path=/trunk/; revision=49924
Michael Mann [Fri, 14 Jun 2013 02:50:46 +0000 (02:50 -0000)]
Remove check_col() and the occasional tree.
svn path=/trunk/; revision=49923
Jeff Morriss [Fri, 14 Jun 2013 02:44:15 +0000 (02:44 -0000)]
From Katrina Zhang via Anders (manually applied by me): dissect node features.
From me: remove some tabs and trailing white space.
svn path=/trunk/; revision=49922
Michael Mann [Fri, 14 Jun 2013 01:56:28 +0000 (01:56 -0000)]
Remove check_col() and the occasional tree.
svn path=/trunk/; revision=49921
Michael Mann [Fri, 14 Jun 2013 01:02:11 +0000 (01:02 -0000)]
Remove check_col() and the occasional tree.
svn path=/trunk/; revision=49920
Gerald Combs [Thu, 13 Jun 2013 18:58:29 +0000 (18:58 -0000)]
On OS X set the toolbar icon size to match our current icons.
svn path=/trunk/; revision=49919
Pascal Quantin [Thu, 13 Jun 2013 14:20:20 +0000 (14:20 -0000)]
Fix typo error
svn path=/trunk/; revision=49918
Pascal Quantin [Thu, 13 Jun 2013 14:18:10 +0000 (14:18 -0000)]
Add basic dissection of Prefix Exclude option
svn path=/trunk/; revision=49917
Jeff Morriss [Thu, 13 Jun 2013 13:51:19 +0000 (13:51 -0000)]
From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8794 :
Display the value of unknown sense descriptor codes in the tree item.
Also fix the length of the subtree.
svn path=/trunk/; revision=49916