Günther Deschner [Thu, 24 Jan 2013 22:31:19 +0000 (23:31 +0100)]
spoolss: make RPC_PrintNamedProperty public
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Mon, 21 Jan 2013 20:37:12 +0000 (21:37 +0100)]
spoolss: fill in IDL for JobNamedProperty calls.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 18 Jan 2013 23:20:42 +0000 (00:20 +0100)]
spoolss: make more container objects public for iremotewinspool.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 18 Jan 2013 23:47:42 +0000 (00:47 +0100)]
spoolss: add idl for spoolss_RpcSendRecvBidiData.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Tue, 5 Feb 2013 15:10:34 +0000 (16:10 +0100)]
s4-torture: add missing NTSTATUS checks in test_AddJob().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Wed, 30 Jan 2013 19:05:51 +0000 (20:05 +0100)]
spoolss: add [ms_union] to spoolss.idl where appropriate.
Normally we would activate [ms_union] for the entire interface but given the
fact we use this IDL file also for custom-marshalled structures we would
generate union arm alignment also for the custom-marshalled unions where they
are inappropriate. Thus, only enable [ms_union] only for unions that are part of
the MS-RPRN IDL.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Wed, 30 Jan 2013 14:55:18 +0000 (15:55 +0100)]
spoolss: fix string types in spoolss_JTEXP.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Tue, 29 Jan 2013 20:57:58 +0000 (21:57 +0100)]
spoolss: Fix two size elements in the devmode private spoolss_JTEXP struct.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Volker Lendecke [Mon, 20 May 2013 12:26:08 +0000 (14:26 +0200)]
talloc: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Mon May 20 18:48:49 CEST 2013 on sn-devel-104
Matthieu Patou [Wed, 2 Jan 2013 04:57:25 +0000 (20:57 -0800)]
ldb_tdb: Warn when reindexing is done
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 20 15:47:33 CEST 2013 on sn-devel-104
Matthieu Patou [Fri, 17 May 2013 15:14:29 +0000 (17:14 +0200)]
smbtorture: Show the list of cracknames we expect to have and the result
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 14:21:57 +0000 (07:21 -0700)]
smbtorture: fix a warning due to a set but unused var
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 14:19:22 +0000 (07:19 -0700)]
smbtorture: fix crash when the returning a crackname with an empty name
when a valid one was expected
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:26:46 +0000 (05:26 -0700)]
Fix warning by setting the variable from GUID to const GUID
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:24:08 +0000 (05:24 -0700)]
Fix more unused vars
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:22:33 +0000 (05:22 -0700)]
Fix a warning about a set but unused variable by actually using it
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:22:15 +0000 (05:22 -0700)]
Fix warnings about set but unused variables
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:17:41 +0000 (05:17 -0700)]
Fix a warning about a shadowed variable by renaming the shadowing var
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 11:50:20 +0000 (04:50 -0700)]
buildtools: Fix compilation warnings
STATIC_%s_MODULES_PROTO is defined on the compilation command line by
-DSTATIC_<something>_MODULES_PROTO which the compiler seems to turn into
define STATIC_<something>_MODULES_PROTO 1 thus yielding a warning due to
unused var
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Tue, 22 Jan 2013 08:09:11 +0000 (00:09 -0800)]
operational: remove double loops
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Tue, 22 Jan 2013 06:27:10 +0000 (22:27 -0800)]
dsdb-schema: remove looping on all schema classes for system_possible_inferrior
The logic to populate possible inferriors and system possible inferriors
is the same so instead of looping twice we do both attributes (depending
on the type of the class) in the same loop
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Kai Blin [Fri, 17 May 2013 12:16:26 +0000 (14:16 +0200)]
swat: Remove swat.
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sat May 18 16:32:38 CEST 2013 on sn-devel-104
Kai Blin [Fri, 18 Jan 2013 17:36:45 +0000 (18:36 +0100)]
dns: Also print packet information for DBGC_DNS
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sat May 18 12:48:15 CEST 2013 on sn-devel-104
Kai Blin [Fri, 18 Jan 2013 17:35:15 +0000 (18:35 +0100)]
librpc: Add NDR_PRINT_DEBUGC to ndr print to a debug class
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Kai Blin [Fri, 18 Jan 2013 08:44:02 +0000 (09:44 +0100)]
debug: Add ability to dump_data per debug class
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Volker Lendecke [Fri, 17 May 2013 13:14:58 +0000 (15:14 +0200)]
smbd: Fix a ISO C90 forbids mixed declarations and code warning
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Sat May 18 01:40:04 CEST 2013 on sn-devel-104
Vadim Zhukov [Fri, 17 May 2013 08:43:08 +0000 (12:43 +0400)]
More generic check for OpenBSD platform
OpenBSD versioning is different from many other
projects, and, say, 5.0 does not differ from 4.9 more than from 5.1. So the
right approach will be to check that platform name starts with "openbsd"
instead. This is also the thing OpenBSD developers do when patching other
software, so this patch is consistent with already existing practicies.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9888
Reviewed-by: Lars Müller <lars@samba.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri May 17 17:58:16 CEST 2013 on sn-devel-104
Björn Jacke [Wed, 15 May 2013 13:52:25 +0000 (15:52 +0200)]
docs: mention AD prerequirements for using idmap_ad
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Björn Jacke [Wed, 15 May 2013 11:34:33 +0000 (13:34 +0200)]
doc: some fixes for vfs_full_audit man page
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Matthias Dieter Wallnöfer [Fri, 17 May 2013 08:31:28 +0000 (10:31 +0200)]
s4:dsdb python tests - set the executable flag
Reviewed-by: Matthieu Patou <mat@samba.org>
Autobuild-User(master): Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date(master): Fri May 17 15:11:29 CEST 2013 on sn-devel-104
Christian Ambach [Thu, 16 May 2013 13:07:44 +0000 (15:07 +0200)]
s3:lib/ctdb_conn make sure we are root before connecting to CTDB
CTDB socket is only reachable for root, make sure we are root when trying to connect to it
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Fri May 17 13:16:37 CEST 2013 on sn-devel-104
Volker Lendecke [Thu, 16 May 2013 14:11:54 +0000 (16:11 +0200)]
lib: Add before/after hooks to async_connect
This will facilitiate [un]become_root for smbd to connect safely to ctdbd.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
Christian Ambach [Tue, 7 May 2013 07:08:07 +0000 (09:08 +0200)]
waf: build vfs_aixacl2 module by default on AIX
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Christian Ambach [Tue, 7 May 2013 07:06:50 +0000 (09:06 +0200)]
waf: only use -fstack-protector when both compiler and linker support it
otherwise build with xlc on AIX fails because the compiler silently ignores the parameter
but the linker does not like it
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Björn Jacke [Thu, 16 May 2013 14:19:22 +0000 (16:19 +0200)]
docs/rpcdaemon: some formating fixes
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 17 10:34:18 CEST 2013 on sn-devel-104
Matthieu Patou [Sat, 12 Jan 2013 04:05:39 +0000 (20:05 -0800)]
drsuapi: Debug more clearly why NC is bad in updateRefs
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 17 04:17:14 CEST 2013 on sn-devel-104
Christian Ambach [Thu, 16 May 2013 13:06:49 +0000 (15:06 +0200)]
nsswitch: fix some typos
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 17 01:09:33 CEST 2013 on sn-devel-104
Christian Ambach [Tue, 14 May 2013 19:02:15 +0000 (21:02 +0200)]
s3:lib/dbwrap add missing curly braces
violation of README.Coding
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Christian Ambach [Tue, 23 Apr 2013 09:20:42 +0000 (11:20 +0200)]
s3:include remove non-blank line endings
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Thu, 16 May 2013 00:32:50 +0000 (10:32 +1000)]
auth: Ensure auth_sam is not used on the AD DC
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu May 16 22:51:26 CEST 2013 on sn-devel-104
Andrew Bartlett [Mon, 13 May 2013 02:06:14 +0000 (14:06 +1200)]
dsdb: Expand on what the error finding the ntSecurityDescriptor was in acl_read
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 13 May 2013 02:05:28 +0000 (14:05 +1200)]
autobuild.py add ntdb to the samba-libs task, to ensure it works as an external library
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 2 Apr 2013 05:10:03 +0000 (16:10 +1100)]
rpc_server-drsuapi: Include the failing DN when unable to convert DB objects to DRS
This is a very serious situation (it should not happen) so getting information on the
objects that this happens for would be very helpful.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 2 Apr 2013 04:36:47 +0000 (15:36 +1100)]
dsdb-schema: Print clear debug message when we find a OID in our local DB we cannot convert
We need to work out why we are unable to make a mapping for an OID in our database, because
we should not have been able to add it without such a mapping.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 26 Mar 2013 00:51:38 +0000 (11:51 +1100)]
dsdb-repl: Allow the name attribute (and name-based schema lookups) to be skipped in dsdb_repl_make_working_schema()
This allows us to use a schema that may only be valid for attributeID based lookups, during the schema load.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sun, 14 Apr 2013 04:36:08 +0000 (14:36 +1000)]
python-samba-tool domain classicupgrade: Use transactions when adding users/groups/members
This should make things a bit faster when importing very large numbers of users
as we will not constantly rewrite the indicies on disk.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sun, 14 Apr 2013 03:32:05 +0000 (13:32 +1000)]
samba-tool dbcheck: Use dsdb.DS_GUID_DELETED_OBJECTS_CONTAINER rather than the literal value
This is better practice.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 11 Apr 2013 08:13:16 +0000 (18:13 +1000)]
python-samba-tool domain classicupgrade: Correct message about re-promoting BDCs
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 11 Apr 2013 07:21:33 +0000 (17:21 +1000)]
pdb_ldap: Do not skip accounts without a sambaAcctFlags value
We allow this to mean a sambaAcctFlags value of zero in other parts of the code
and by allowing these users to show up in a search, we can read and correct them
during the classicupgrade, rather than not know they exist at all.
Most parts of the code do not look for ACB_NORMAL, which is why
these users appear to work.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 10 Apr 2013 23:33:16 +0000 (09:33 +1000)]
python-samba-tool domain classicupgrade: Actually Skip domain trust accounts
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 10 Apr 2013 23:32:13 +0000 (09:32 +1000)]
python-samba-tool domain classicupgrade: Skip machine accounts that do not end in $
These accounts will not work anyway, as all the domain member lookup code in netlogon expects the $.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 8 May 2013 00:59:05 +0000 (12:59 +1200)]
build: Do not set PATH in install_with_python now we set $PYTHON
This will ensure that the scripts get rewritten to use this specific python, as it
will not be found in the path by the waf scripts.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 2 May 2013 04:29:21 +0000 (16:29 +1200)]
s3-rpc_server: Ensure we are root when starting and usiing gensec
This fixes bug 9465.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 29 Apr 2013 00:00:04 +0000 (10:00 +1000)]
gensec: Make the no-hostname status message much less scary
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Fri, 26 Apr 2013 06:44:00 +0000 (16:44 +1000)]
build: Blacklist the release-4-0-0 provision as well
This reduces the size of the published tarball while ensuring we test with it
during autobuild.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Kai Blin [Thu, 16 May 2013 10:13:22 +0000 (12:13 +0200)]
dns: Fix allocation of txt_record in txt record tests
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu May 16 15:39:15 CEST 2013 on sn-devel-104
Kai Blin [Sun, 13 Jan 2013 23:56:48 +0000 (00:56 +0100)]
dns: more debug debug options in the tests
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
Kai Blin [Sun, 9 Dec 2012 19:50:05 +0000 (05:50 +1000)]
dns: Add support for MX queries
Due to an oversight, the internal DNS server supports MX record updates,
but not MX record queries. Add support for MX queries and tests.
This should fix bug #9485
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
Kai Blin [Sun, 13 Jan 2013 23:55:37 +0000 (00:55 +0100)]
dns: Also add a print-out for the out_packet
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
Kai Blin [Mon, 14 Jan 2013 00:14:29 +0000 (01:14 +0100)]
dns: Use new DNS debugclass in DNS server
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
Kai Blin [Mon, 14 Jan 2013 00:13:47 +0000 (01:13 +0100)]
debug: Add debugclass for DNS server
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
Volker Lendecke [Tue, 7 May 2013 08:17:26 +0000 (10:17 +0200)]
winbind4: Fix bug 9832 -- talloc use after free
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 16 13:37:41 CEST 2013 on sn-devel-104
Karolin Seeger [Wed, 15 May 2013 16:24:42 +0000 (18:24 +0200)]
source4/winbind/wb_samba3_cmd.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 16 07:49:24 CEST 2013 on sn-devel-104
Karolin Seeger [Wed, 15 May 2013 16:23:49 +0000 (18:23 +0200)]
source4/dsdb/schema/schema_convert_to_ol.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:22:39 +0000 (18:22 +0200)]
source4/dsdb/samdb/ldb_modules/local_password.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:21:52 +0000 (18:21 +0200)]
source4/auth/kerberos/kerberos-notes.txt: Fix typo.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:20:42 +0000 (18:20 +0200)]
source4/TODO: Fix typo.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:19:36 +0000 (18:19 +0200)]
source3/utils/ntlm_auth.c: Fix typo in debug message.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:18:07 +0000 (18:18 +0200)]
source3/modules/vfs_catia.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:16:51 +0000 (18:16 +0200)]
source3/libsmb/ntlmssp.c: Fix typo.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:16:03 +0000 (18:16 +0200)]
samba_tool/base.py: Fix typo.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:15:18 +0000 (18:15 +0200)]
netcmd/group.py: Fix typo.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:13:44 +0000 (18:13 +0200)]
Wireshark/Conformance.pm: Fix typo.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:12:52 +0000 (18:12 +0200)]
pidl/TODO: Fix typo.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:11:10 +0000 (18:11 +0200)]
lib/testtools/testtools/tests/test_testresult.py: Fix typos.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:09:51 +0000 (18:09 +0200)]
lib/subunit/README: Fix typo.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Wed, 15 May 2013 16:08:51 +0000 (18:08 +0200)]
docs-xml: Fix typo in vfs_smb_traffic_analyzer.8.xml.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Sat, 11 May 2013 08:36:12 +0000 (10:36 +0200)]
gensec: Make gensec_security_oids_from_ops static
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May 15 20:05:34 CEST 2013 on sn-devel-104
Volker Lendecke [Sat, 11 May 2013 08:35:59 +0000 (10:35 +0200)]
gensec: Make gensec_security_by_sasl_list static
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Sat, 11 May 2013 08:35:33 +0000 (10:35 +0200)]
gensec: Make gensec_interface_version public
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Matthieu Patou [Tue, 14 May 2013 13:20:18 +0000 (06:20 -0700)]
samba-tool/tests: Force the gecos of the user to a fixed value.
When --gecos is not specified samba-tool user add will try to read the
gecos field from a getpw call. And if user's GECOS is empty (like the
build user on sn-devel-104) then the test will fail because we can't add
an empty gecos.
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed May 15 16:19:23 CEST 2013 on sn-devel-104
Matthieu Patou [Wed, 15 May 2013 11:46:33 +0000 (04:46 -0700)]
dsdb-drepl: create a new schedulable event for running pending operations
So instead of running dreplsrv_periodic_schedule when receiving a
DRS_REPLICA_SYNC request which will force the DC to look for changes
with all the DC it usually replicate to, we reduce it to the DC
specified in the DRS_REPLICA_SYNC request. It will allow also to do have the
correct options as set by the client who send the DRS_REPLICA_SYNC.
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 29 Apr 2013 10:27:25 +0000 (12:27 +0200)]
lib/param: remove unused 'printer_admin'
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue May 14 21:45:19 CEST 2013 on sn-devel-104
Stefan Metzmacher [Tue, 30 Apr 2013 06:39:00 +0000 (08:39 +0200)]
doc-xml/smbdotconf: fix server [min|max] protocol documentation
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 7 May 2013 12:15:35 +0000 (14:15 +0200)]
talloc: only provide the --enable-talloc-compat1 in standalone build
The compat library is already only built in standalone build,
so we need the configure option also only in the standalone build.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Björn Jacke [Tue, 14 May 2013 14:51:28 +0000 (16:51 +0200)]
winbind/idmap_ad: be verbose about the user that we fail to map
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Tue, 14 May 2013 13:43:10 +0000 (15:43 +0200)]
vfs_gpfs: slightly simplify connect()
DISCONNECT can be arbitrarily complex, TALLOC_FREE of a simple struct
is easier.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue May 14 18:11:29 CEST 2013 on sn-devel-104
Shekhar Amlekar [Tue, 7 May 2013 12:28:16 +0000 (17:58 +0530)]
s3:rpc_server/srvsvc check access before doing work
Before doing the (potentially) costly enumerations,
check if the user has necessary privileges first
Signed-off-by: Shekhar Amlekar <samlekar@in.ibm.com>
Reviewed-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Tue May 14 16:22:24 CEST 2013 on sn-devel-104
Volker Lendecke [Sat, 11 May 2013 08:51:22 +0000 (10:51 +0200)]
torture: Remove some unused code
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
Christian Ambach [Fri, 10 May 2013 22:45:15 +0000 (00:45 +0200)]
tdb: include information about hash function being used in tdbtool info output
makes it possible to easily determine if the tdb under examination
uses jenkins hash or not
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Volker Lendecke [Tue, 14 May 2013 08:52:33 +0000 (10:52 +0200)]
smbd: Remove a pointless variable
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue May 14 13:19:44 CEST 2013 on sn-devel-104
Matthieu Patou [Mon, 6 May 2013 07:58:28 +0000 (00:58 -0700)]
selftests-drs: make our generated class subclass of classschema
Without this change objectclass=["top", "classSchema", "Foobar"] will
not be sorted correctly and will generated an error saying that class
Foobar is unreleated to classSchema (which is not true). It's mimicing what
other classes of the default schema are doing (ie. contact)
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 14 07:07:19 CEST 2013 on sn-devel-104
Matthieu Patou [Mon, 13 May 2013 16:16:24 +0000 (09:16 -0700)]
Export PROMOTED_DC related variable
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Mon, 6 May 2013 08:09:05 +0000 (01:09 -0700)]
dsdb: make the name of non related class more obvious
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Mon, 13 May 2013 21:23:33 +0000 (09:23 +1200)]
build: Add missing dep from vfs_nfs4acl_xattr to NDR_NFS4ACL
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue May 14 01:23:17 CEST 2013 on sn-devel-104
Volker Lendecke [Sun, 12 May 2013 10:47:39 +0000 (12:47 +0200)]
lib: Fix CID 241650 Sizeof not portable
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sun May 12 17:44:55 CEST 2013 on sn-devel-104
Volker Lendecke [Sun, 12 May 2013 10:44:41 +0000 (12:44 +0200)]
pthreadpool: Fix CID 710828 Sizeof not portable
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Volker Lendecke [Sun, 12 May 2013 10:33:49 +0000 (12:33 +0200)]
dbwrap: Fix CID
1002092 Uninitialized scalar variable
We don't set saved_errno in the ret==0 case.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Björn Baumbach [Wed, 8 May 2013 08:27:26 +0000 (10:27 +0200)]
docs: smb.conf: fix max read/write/trans default values (bug #9871)
Commit
6d128aac119d948f0ecb0dcf6b400b4eb4027fe6 has increased the limit:
"s3:smb2_server increase defaults for read/write/trans sizes to 1MB"
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 10 23:14:50 CEST 2013 on sn-devel-104
Christian Ambach [Mon, 6 May 2013 17:00:29 +0000 (19:00 +0200)]
s4:torture fix a build break on AIX
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 9 08:05:12 CEST 2013 on sn-devel-104