Jörg Mayer [Sun, 26 Aug 2012 03:17:53 +0000 (03:17 -0000)]
Extend a comment.
svn path=/trunk/; revision=44675
Pascal Quantin [Sat, 25 Aug 2012 21:31:29 +0000 (21:31 -0000)]
From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gmr1_bcch: Add guards in the SI1/2 choice of segment
Although the CSN1 dissector itself will just stop if there is
no matching segment, it will leave the choice field uninitizalized
and so when we use it to fill some other text, it crashes ...
To protect against that, we put a last choice entry that will always
match. As a bonus, it triggers an explicit error in CSN so you
know something is wrong.
svn path=/trunk/; revision=44674
Pascal Quantin [Sat, 25 Aug 2012 21:19:47 +0000 (21:19 -0000)]
From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gmr1_bcch: Whitespaces fixes
svn path=/trunk/; revision=44673
Pascal Quantin [Sat, 25 Aug 2012 21:16:08 +0000 (21:16 -0000)]
From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gmr1_rr: Add support for "Assignment Command 1" messages
svn path=/trunk/; revision=44672
Pascal Quantin [Sat, 25 Aug 2012 21:09:49 +0000 (21:09 -0000)]
From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gsmtap: Call GMR-1 RACH dissector when appropriate
svn path=/trunk/; revision=44671
Pascal Quantin [Sat, 25 Aug 2012 21:04:48 +0000 (21:04 -0000)]
From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
Add GMR-1 RACH dissection
svn path=/trunk/; revision=44670
Evan Huus [Sat, 25 Aug 2012 19:12:03 +0000 (19:12 -0000)]
Have CMake also consider the include path "lua5.2" (note the dot),
since that is where it can be found on recent Ubuntus, and without it
you get a mix of 5.1 includes and 5.2 libraries, which breaks the build.
svn path=/trunk/; revision=44669
Pascal Quantin [Sat, 25 Aug 2012 13:54:39 +0000 (13:54 -0000)]
Update protocol name to match the changes done in r44661
svn path=/trunk/; revision=44668
Pascal Quantin [Sat, 25 Aug 2012 13:32:41 +0000 (13:32 -0000)]
Following r44648, revert part of r44162 and followups so as to have a top level gsm_a filter name
svn path=/trunk/; revision=44667
Bill Meier [Sat, 25 Aug 2012 01:20:32 +0000 (01:20 -0000)]
Extern (and use) extended value string instead of the associated value string array.
svn path=/trunk/; revision=44665
Michael Mann [Sat, 25 Aug 2012 00:55:46 +0000 (00:55 -0000)]
cleanup g_malloc memory leaks
svn path=/trunk/; revision=44664
Bill Meier [Sat, 25 Aug 2012 00:54:04 +0000 (00:54 -0000)]
value_sring fixes;
- fix dup: use correct value for an entry (typo);
- comment out 2nd entry of a dup pair: 2 cases
svn path=/trunk/; revision=44663
Michael Mann [Sat, 25 Aug 2012 00:39:17 +0000 (00:39 -0000)]
cleanup some unnecessary g_malloc calls
svn path=/trunk/; revision=44662
Michael Mann [Fri, 24 Aug 2012 23:27:24 +0000 (23:27 -0000)]
effectively revert r44161, having the display filters favor '.' over '_'
svn path=/trunk/; revision=44661
Bill Meier [Fri, 24 Aug 2012 20:56:23 +0000 (20:56 -0000)]
Fix a trivial typo.
svn path=/trunk/; revision=44660
Bill Meier [Fri, 24 Aug 2012 20:44:33 +0000 (20:44 -0000)]
Force extended value string linear search (not binary search) in one case:
Fixed: { -2, -1, 0, 1, 3} (note gap) used a binary search (which would fail);
Note: { -2, -1, 0, 1, 2 ,3 } (no gap) allowed; will still do a direct access;
Also: Add a comment to README.developer extended value string section.
svn path=/trunk/; revision=44659
Bill Meier [Fri, 24 Aug 2012 20:22:48 +0000 (20:22 -0000)]
Minor update to tcp_dissect_pdus() section.
svn path=/trunk/; revision=44658
Bill Meier [Fri, 24 Aug 2012 20:07:52 +0000 (20:07 -0000)]
Replace dup value_string array entry with correct entry; (dup was typo)
svn path=/trunk/; revision=44657
Bill Meier [Fri, 24 Aug 2012 19:49:53 +0000 (19:49 -0000)]
Allow extended value string binary search (istead of linear search): re-order value_srring array entries slightly.
svn path=/trunk/; revision=44656
Gerald Combs [Fri, 24 Aug 2012 15:25:42 +0000 (15:25 -0000)]
Revert r44644 and 44645. g_source_*, g_timeout_, and g_io_* all depend
on the GLib main loop which isn't portable (unless you want to want to
manage the main loop yourself).
svn path=/trunk/; revision=44655
Michael Mann [Fri, 24 Aug 2012 03:05:05 +0000 (03:05 -0000)]
Check for PFNAME #define as it is a common substitute for a literal string for the proto filter name and consider it the proto filter name.
Ignore "duplicates" that are generated because a display filter is prefixed by a #define (which checkfiltername.pl is not smart enough to handle), causing an empty string
svn path=/trunk/; revision=44654
Michael Mann [Fri, 24 Aug 2012 02:48:36 +0000 (02:48 -0000)]
match display filter prefix for all filters
svn path=/trunk/; revision=44653
Michael Mann [Fri, 24 Aug 2012 02:17:42 +0000 (02:17 -0000)]
Adding period to proto filter name for being part of the "diameter" grouping.
svn path=/trunk/; revision=44652
Michael Mann [Fri, 24 Aug 2012 02:04:10 +0000 (02:04 -0000)]
minor display filter field typos
svn path=/trunk/; revision=44651
Michael Mann [Fri, 24 Aug 2012 02:02:22 +0000 (02:02 -0000)]
Add period separator for "base" proto filter name.
svn path=/trunk/; revision=44650
Michael Mann [Thu, 23 Aug 2012 21:31:20 +0000 (21:31 -0000)]
Allow proto filter names to have a period in them and allow display filter names to use any period separated value as a prefix. For example "gmr1.foo.bar" would allow "gmr1", "gmr1.foo" and "gmr1.foo.bar" as valid prefixes. Otherwise it will be flagged as a possible error.
Also added a "FILE TYPE" for proto filter names with a period so that they can be verified. Presumably only "large", possibly "meta" protocols (probably spanning multiple dissector files) will be allowed to use a period in the proto filter name.
svn path=/trunk/; revision=44648
Jeff Morriss [Thu, 23 Aug 2012 19:07:24 +0000 (19:07 -0000)]
Don't call dissect_custom_message() when it's not initialized.
svn path=/trunk/; revision=44646
Gerald Combs [Thu, 23 Aug 2012 18:51:24 +0000 (18:51 -0000)]
Fix compilation on Windows.
svn path=/trunk/; revision=44645
Gerald Combs [Thu, 23 Aug 2012 18:42:48 +0000 (18:42 -0000)]
Move the pipe input routines to the common UI directory.
svn path=/trunk/; revision=44644
Gerald Combs [Thu, 23 Aug 2012 17:42:02 +0000 (17:42 -0000)]
Allow focus in the task list, which in turn allows keyboard navigation.
svn path=/trunk/; revision=44643
Bill Meier [Thu, 23 Aug 2012 17:30:42 +0000 (17:30 -0000)]
Comment out all but first value_string array entries with dup values:
kept: first dup since that's the one which would
be found with a linear search.
svn path=/trunk/; revision=44642
Gerald Combs [Thu, 23 Aug 2012 17:29:05 +0000 (17:29 -0000)]
Fill in some missing functionality. Rename some variables and rearrange
a few things.
svn path=/trunk/; revision=44641
Bill Meier [Thu, 23 Aug 2012 17:24:46 +0000 (17:24 -0000)]
Replace dup value (typo ?) with what seems to be the correct value.
svn path=/trunk/; revision=44640
Bill Meier [Thu, 23 Aug 2012 17:22:13 +0000 (17:22 -0000)]
Fix incorrect value (typo) in value-string array.
svn path=/trunk/; revision=44639
Bill Meier [Thu, 23 Aug 2012 17:18:26 +0000 (17:18 -0000)]
Comment out dups (many of which are marked "deprecated" in packet-x11-keysymdef.h)
svn path=/trunk/; revision=44638
Bill Meier [Thu, 23 Aug 2012 17:11:36 +0000 (17:11 -0000)]
Cleanup: Whitespace and long lines;
Also: remove a few boilerplate comments.
svn path=/trunk/; revision=44637
Bill Meier [Thu, 23 Aug 2012 15:38:03 +0000 (15:38 -0000)]
value-string arrays - allow "direct" access: fix dup val & fill in a "gap".
svn path=/trunk/; revision=44636
Bill Meier [Thu, 23 Aug 2012 12:53:36 +0000 (12:53 -0000)]
Fix extended value-string linear search: Move out-of-order value-string array entry.
svn path=/trunk/; revision=44635
Bill Meier [Thu, 23 Aug 2012 12:51:32 +0000 (12:51 -0000)]
Fix extended value-string linear search: remove 2 dups from value-string array.
svn path=/trunk/; revision=44634
Jörg Mayer [Thu, 23 Aug 2012 12:30:16 +0000 (12:30 -0000)]
The proper way to set compiler flags in cmake is not by using
add_definitions() but the variables CMAKE_C{,XX}_FLAGS. Set these
flags correctly at the toplevel, so no hack in the ui/qt/ subdir
is required anymore.
svn path=/trunk/; revision=44633
Jörg Mayer [Thu, 23 Aug 2012 12:27:50 +0000 (12:27 -0000)]
Replace if(os1) endif() if(os2) endif() with elseif
svn path=/trunk/; revision=44632
Jörg Mayer [Thu, 23 Aug 2012 12:20:25 +0000 (12:20 -0000)]
Replace hand crafted be-le conversion by its glib counterpart.
That way processor specific optimizations may be picked up.
svn path=/trunk/; revision=44631
Jörg Mayer [Thu, 23 Aug 2012 11:11:24 +0000 (11:11 -0000)]
The name configure.in has been deprecated for many years.
Use configure.ac instead.
svn path=/trunk/; revision=44630
Jörg Mayer [Thu, 23 Aug 2012 10:34:45 +0000 (10:34 -0000)]
Remove commented out rules
Whitespace fixes
svn path=/trunk/; revision=44629
Jörg Mayer [Thu, 23 Aug 2012 10:30:37 +0000 (10:30 -0000)]
Fixes for warnings: unused-but-set-variable
svn path=/trunk/; revision=44628
Jörg Mayer [Thu, 23 Aug 2012 09:45:15 +0000 (09:45 -0000)]
Update spec link to version 2.1
svn path=/trunk/; revision=44627
Jörg Mayer [Thu, 23 Aug 2012 09:40:08 +0000 (09:40 -0000)]
Add comment where to find the specification
svn path=/trunk/; revision=44626
Jörg Mayer [Thu, 23 Aug 2012 09:31:57 +0000 (09:31 -0000)]
Add link to version 1 specification.
Remote trailing whitespcace.
svn path=/trunk/; revision=44625
Guy Harris [Thu, 23 Aug 2012 04:45:56 +0000 (04:45 -0000)]
Get rid of unnecessary function pointer - just directly call the
function in the switch statement. This keeps us from calling through an
uninitialized pointer for custome parameter numbers other than
LLRP_VENDOR_IMPINJ (as warned of by at least some compilers).
svn path=/trunk/; revision=44624
Martin Mathieson [Thu, 23 Aug 2012 04:00:39 +0000 (04:00 -0000)]
Rationalise the way lists/elements are allocated.
svn path=/trunk/; revision=44623
Gerald Combs [Thu, 23 Aug 2012 03:18:48 +0000 (03:18 -0000)]
Visual C++ 2008 → 2010.
svn path=/trunk/; revision=44622
Evan Huus [Thu, 23 Aug 2012 03:03:54 +0000 (03:03 -0000)]
From Martin Kupec via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7658
Major enhancements to the LLRP dissector.
svn path=/trunk/; revision=44621
Gerald Combs [Thu, 23 Aug 2012 02:59:31 +0000 (02:59 -0000)]
Catch key events where needed and direct them to the display filter
QLineEdit. Use Tango colors for syntax highlighting. Rename a few
variables.
svn path=/trunk/; revision=44620
Evan Huus [Thu, 23 Aug 2012 02:48:26 +0000 (02:48 -0000)]
From Martin Kupec via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7658
Don't pass string-related encoding flags to get_uint_value() when handling
FT_UINT_STRING fields. This was causing all such fields with non-ASCII
encodings to use little-endian encoding, even when OR-ed with ENC_BIG_ENDIAN.
(not actually the topic of the above bug, but discovered during LLRP protocol
testing, which was the topic of the above bug)
svn path=/trunk/; revision=44619
Gerald Combs [Wed, 22 Aug 2012 23:33:43 +0000 (23:33 -0000)]
Add larger sizes to try to make Windows 8 happy.
svn path=/trunk/; revision=44618
Guy Harris [Wed, 22 Aug 2012 21:01:46 +0000 (21:01 -0000)]
Put the state of flags in the hop_flags field into the summary line.
Note in the introductory comment what "LISP" refers to, for the benefit
of those of us who grew up thinking it stood for "LISt Processing".
svn path=/trunk/; revision=44617
Gerald Combs [Wed, 22 Aug 2012 20:39:36 +0000 (20:39 -0000)]
Handle return/enter/escape in the Go to Packet QLineEdit.
svn path=/trunk/; revision=44616
Pascal Quantin [Wed, 22 Aug 2012 20:15:54 +0000 (20:15 -0000)]
Try to make Ubuntu buildbot happy
svn path=/trunk/; revision=44615
Martin Mathieson [Wed, 22 Aug 2012 19:01:01 +0000 (19:01 -0000)]
proto_item_append_string() doesn't work this case, so stop using it.
I am tempted though to chage proto_item_append_string() just be like
proto_item_append_text() without the call to g_vsnprintf(), which is the
expensize part I was hoping to avoid.
svn path=/trunk/; revision=44614
Pascal Quantin [Wed, 22 Aug 2012 16:37:41 +0000 (16:37 -0000)]
From Loránd Jakab via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7654:
Add features to the Locator/ID Separation Protocol (LISP) dissector
svn path=/trunk/; revision=44613
Anders Broman [Wed, 22 Aug 2012 13:35:20 +0000 (13:35 -0000)]
Add French National parameter https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7656
svn path=/trunk/; revision=44612
Evan Huus [Wed, 22 Aug 2012 00:53:13 +0000 (00:53 -0000)]
From Teguh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7657
Replace the last instance of gnutls_datum with gnutls_datum_t. The former
is deprecated, and the latter is already being used elsewhere in the file.
svn path=/trunk/; revision=44611
Martin Mathieson [Tue, 21 Aug 2012 21:37:31 +0000 (21:37 -0000)]
Delete the ROHC from here as it is superceded by packet-rohc.c
svn path=/trunk/; revision=44610
Martin Mathieson [Tue, 21 Aug 2012 21:36:59 +0000 (21:36 -0000)]
Call proto_item_append_string() rather than proto_item_append_text()
when there are no specifiers.
svn path=/trunk/; revision=44609
Martin Mathieson [Tue, 21 Aug 2012 17:19:05 +0000 (17:19 -0000)]
Avoid some calls to strlen() by remembering return value from
g_strlcpy().
svn path=/trunk/; revision=44608
Martin Mathieson [Tue, 21 Aug 2012 17:17:53 +0000 (17:17 -0000)]
Use tvb_get_stringz() rather than tvb_get_const_stringz(). I know that
these strings will be in a single, contiguous tvb...
svn path=/trunk/; revision=44607
Martin Mathieson [Tue, 21 Aug 2012 17:12:13 +0000 (17:12 -0000)]
Use proto_item_append_string() rather than proto_item_append_text() with
%s.
svn path=/trunk/; revision=44606
Pascal Quantin [Tue, 21 Aug 2012 15:14:50 +0000 (15:14 -0000)]
Add dissection of locationInformation IE in Ericsson proprietary extension
svn path=/trunk/; revision=44605
Pascal Quantin [Tue, 21 Aug 2012 10:40:04 +0000 (10:40 -0000)]
Fix filter names for Ericsson proprietary extensions
svn path=/trunk/; revision=44604
Pascal Quantin [Tue, 21 Aug 2012 09:32:04 +0000 (09:32 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7648 :
Add support for Ericsson proprietary extensions to GSM MAP dissector
svn path=/trunk/; revision=44603
Gerald Combs [Tue, 21 Aug 2012 03:07:39 +0000 (03:07 -0000)]
Fix compilation.
svn path=/trunk/; revision=44602
Gerald Combs [Mon, 20 Aug 2012 21:22:01 +0000 (21:22 -0000)]
Restore the previous focus when we're done going to a packet.
svn path=/trunk/; revision=44601
Jeff Morriss [Mon, 20 Aug 2012 19:56:34 +0000 (19:56 -0000)]
Flow-Direction is 3GPP code 1080 not 1073.
Add in a few other (numerically) nearby AVPs.
svn path=/trunk/; revision=44600
Gerald Combs [Mon, 20 Aug 2012 17:55:43 +0000 (17:55 -0000)]
Stylize the "go to packet" bar.
svn path=/trunk/; revision=44597
Pascal Quantin [Mon, 20 Aug 2012 12:47:47 +0000 (12:47 -0000)]
Remove unused hf_gsm_map_imsi_digits entry and fix filter name for hf_gsm_map_TBCD_digits (which is also used for IMEI, ASCI call reference, MS Group ID and MS Long Group ID on top of IMSI)
svn path=/trunk/; revision=44596
Pascal Quantin [Mon, 20 Aug 2012 09:28:01 +0000 (09:28 -0000)]
Avoid defining 2 entries with incompatible types (FT_BYTES vs FT_NONE) and same filter
svn path=/trunk/; revision=44595
Gerald Combs [Mon, 20 Aug 2012 04:34:23 +0000 (04:34 -0000)]
Basic "Go to Packet" implementation.
svn path=/trunk/; revision=44594
Sake Blok [Sun, 19 Aug 2012 23:52:37 +0000 (23:52 -0000)]
Enhance the http dissector to correctly reassemble http
headers when the first tcp segment does not contain a
full line.
svn path=/trunk/; revision=44593
Gerald Combs [Sun, 19 Aug 2012 23:52:08 +0000 (23:52 -0000)]
Handle double-clicks in the tree.
svn path=/trunk/; revision=44592
Gerald Combs [Sun, 19 Aug 2012 21:52:57 +0000 (21:52 -0000)]
Be more specific.
svn path=/trunk/; revision=44591
Gerald Combs [Sun, 19 Aug 2012 21:44:22 +0000 (21:44 -0000)]
Try colors from the Tango palette.
svn path=/trunk/; revision=44590
Evan Huus [Sun, 19 Aug 2012 21:24:02 +0000 (21:24 -0000)]
Split test_file_close out of do_file_close and use it in file_open_cmd_cb.
Means we don't end up closing the current file if the user decides not
to open a new file after all.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7649
svn path=/trunk/; revision=44589
Anders Broman [Sun, 19 Aug 2012 21:08:54 +0000 (21:08 -0000)]
Try to fix the buildbot
svn path=/trunk/; revision=44588
Gerald Combs [Sun, 19 Aug 2012 20:47:11 +0000 (20:47 -0000)]
Add automatic tree expansion. Get rid of some unnecessary void * casts.
Fix a couple of compilation warnings.
svn path=/trunk/; revision=44587
Pascal Quantin [Sun, 19 Aug 2012 18:15:20 +0000 (18:15 -0000)]
Apply the speed improvement from r44578 to 64bits variant and length determinant decoding.
Compute the buffer size so that it can contain the field name and the bit string display.
svn path=/trunk/; revision=44586
Gerald Combs [Sun, 19 Aug 2012 14:03:36 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-08-19]
svn path=/trunk/; revision=44582
Evan Huus [Sun, 19 Aug 2012 13:50:22 +0000 (13:50 -0000)]
Don't go into a tight loop when there's no specific number of passes.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7651
Also, use consistent indentation.
svn path=/trunk/; revision=44581
Evan Huus [Sun, 19 Aug 2012 13:38:53 +0000 (13:38 -0000)]
From Toralf Förster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7652
Use a fast bash built-in rather than a slow call out to `expr` to increment
the loop count.
svn path=/trunk/; revision=44580
Martin Kaiser [Sun, 19 Aug 2012 12:53:13 +0000 (12:53 -0000)]
highlight only the bytes that actually belong to the CAT
svn path=/trunk/; revision=44579
Martin Mathieson [Sun, 19 Aug 2012 03:55:51 +0000 (03:55 -0000)]
Calling g_strlcat() for every bit of a constrained integer was really
slow. Track the index and write the characters directly (while still
carefully checking that we don't spill the buffer).
svn path=/trunk/; revision=44578
Martin Mathieson [Sun, 19 Aug 2012 03:05:32 +0000 (03:05 -0000)]
Both lists of elements are always allocated together, so save a scan
through the segments by only getting the counts once.
svn path=/trunk/; revision=44577
Martin Mathieson [Sun, 19 Aug 2012 02:27:13 +0000 (02:27 -0000)]
Correct a number in a value_string.
Spotted in a profile that match_strval_ext() was calling
match_strval_linear() a lot (this value_string has 1476 entries - it was
epensive!).
Found error by adding temp debug to _match_strval_ext_init() - do we
ever expect the entries not to be in order? Am wondering if the warning
should be committed.
svn path=/trunk/; revision=44576
Martin Mathieson [Sun, 19 Aug 2012 01:58:29 +0000 (01:58 -0000)]
Speed up drawing of axes by taking cairo_stroke() and
cairo_set_line_width() out of the loops they are in.
svn path=/trunk/; revision=44575
Martin Mathieson [Sun, 19 Aug 2012 01:56:39 +0000 (01:56 -0000)]
Save time by not appending byte values to the SDU item if will be hidden anyway (as happens
when RLC dissector is called).
svn path=/trunk/; revision=44574
Gerald Combs [Sun, 19 Aug 2012 01:16:42 +0000 (01:16 -0000)]
Make sure osx-dmg.sh is executable.
svn path=/trunk/; revision=44573
Gerald Combs [Sun, 19 Aug 2012 00:49:55 +0000 (00:49 -0000)]
Get the package version using configure.in, not grep+sed. Make sure we
exit with an error in a few places where it would be useful.
svn path=/trunk/; revision=44572
Michael Mann [Sun, 19 Aug 2012 00:21:26 +0000 (00:21 -0000)]
use session allocated memory for rtp_add_address/srtp_add_address hash tables
svn path=/trunk/; revision=44571
Jörg Mayer [Sun, 19 Aug 2012 00:14:14 +0000 (00:14 -0000)]
Commit 44474 added some arguments to the ac_init macro that broke
extraction of the wireshark version for cmake. Now the version part
is either terminated by ")" (old) or "," (added).
It looks like .*? does not exist for non-greedy matches in cmake regex.
svn path=/trunk/; revision=44570
Guy Harris [Sat, 18 Aug 2012 22:25:50 +0000 (22:25 -0000)]
ui_main_welcome.h is another file generated by uic, so list it in
GENERATED_NODIST_HEADER_FILES.
svn path=/trunk/; revision=44569
Pascal Quantin [Sat, 18 Aug 2012 20:25:54 +0000 (20:25 -0000)]
Move deciphering routine in a function and adapt it for unacknowledged mode
svn path=/trunk/; revision=44568