Michael Adam [Wed, 30 May 2012 11:10:57 +0000 (13:10 +0200)]
build: rename build targets smbclient -> smbclient4 and smbclient3 -> smbclient
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu May 31 06:36:55 CEST 2012 on sn-devel-104
Michael Adam [Wed, 30 May 2012 10:21:42 +0000 (12:21 +0200)]
s4:selftest: change the blackbox.samba_tool_demote test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:18:35 +0000 (12:18 +0200)]
s4:selftest: change the blackbox.passwords test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:16:49 +0000 (12:16 +0200)]
s4:selftest: change the blackbox.pkinit test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:15:10 +0000 (12:15 +0200)]
s4:selftest: change the blackbox.kinit test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:09:25 +0000 (12:09 +0200)]
s4:selftest: change the blackbox.export.keytab test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:07:18 +0000 (12:07 +0200)]
s4:selftest: change the blackbox.chgdcpass test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:04:30 +0000 (12:04 +0200)]
s4:selftest: change the blackbox.samba_tool test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 09:57:16 +0000 (11:57 +0200)]
s4:selftets: change the blackbox.bogusdomain test to use binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 09:48:02 +0000 (11:48 +0200)]
s4:selftest: change the blackbox.smbclient test to use binary mapping for smbclient
Michael Adam [Thu, 24 May 2012 23:40:58 +0000 (01:40 +0200)]
s3:selftest: add a binary mapping for smbclient4
Michael Adam [Thu, 24 May 2012 23:40:32 +0000 (01:40 +0200)]
selftest: add a binary mapping for smbclient4
Michael Adam [Wed, 30 May 2012 11:09:57 +0000 (13:09 +0200)]
build: rename build targets nmblookup -> nmblookup4 and nmblookup3 -> nmblookup
Michael Adam [Wed, 30 May 2012 11:01:18 +0000 (13:01 +0200)]
build: add a build suffix ("4") for s4-binaries
Michael Adam [Tue, 29 May 2012 14:35:18 +0000 (16:35 +0200)]
s4:selftest: determine nmblookup via binary mapping for blackbox test in tests.py
Michael Adam [Thu, 24 May 2012 23:44:17 +0000 (01:44 +0200)]
selftest:Samba4: use the nmblookup4 binary mapping
Michael Adam [Thu, 24 May 2012 23:42:37 +0000 (01:42 +0200)]
s3:selftest: add a binary mapping for nmblookup4
Michael Adam [Thu, 24 May 2012 23:42:20 +0000 (01:42 +0200)]
selftest: add a binary mapping for nmblookup4
Michael Adam [Tue, 29 May 2012 11:59:14 +0000 (13:59 +0200)]
s3:selftest: improve strange linebreaks for blackbox tests in tests.py for readability
Michael Adam [Tue, 29 May 2012 11:51:05 +0000 (13:51 +0200)]
s3:selftest: introduce a variable for binpath('dbwrap_tool') in tests.py
Michael Adam [Tue, 29 May 2012 11:47:32 +0000 (13:47 +0200)]
s3:selftest: introduce a variable for binpath('ntlm_auth3') in tests.py
Michael Adam [Tue, 29 May 2012 11:45:49 +0000 (13:45 +0200)]
s3:selftest: introduce a variable for binpath('smbtorture3') in tests.py
Michael Adam [Tue, 29 May 2012 11:44:03 +0000 (13:44 +0200)]
s3:selftest: introduce a variable for binpath('net') in tests.py
Michael Adam [Tue, 29 May 2012 10:18:19 +0000 (12:18 +0200)]
s3:selftest: introduce a variable for binpath('wbinfo') in tests.py
to remove explicit calls to binpath('wbinfo')
Michael Adam [Tue, 29 May 2012 10:16:12 +0000 (12:16 +0200)]
s3:selftest: introduce a variable for binpath('smbclient3') to test.py
to remove manual calls to binpath("smbclient3")
Michael Adam [Tue, 29 May 2012 10:10:16 +0000 (12:10 +0200)]
s3:selftest: introduce a variable for binpath('nmblookup3') in tests.py
Michael Adam [Fri, 18 May 2012 13:02:31 +0000 (15:02 +0200)]
s3:build: fix some spacing in wscript_build
Jeremy Allison [Thu, 31 May 2012 00:12:10 +0000 (17:12 -0700)]
Stop spamming the logs with "Could not remove pid XX from serverid.tdb" messages and initiating the cleanup function on every process death.
We now have many sub-processes from smbd that don't serve SMB1/SMB2 requests and
don't register themselves in the serverid.tdb. Only initiate the cleanup
from processes that were explicitly in the child list.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu May 31 04:44:09 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 30 May 2012 13:06:12 +0000 (15:06 +0200)]
lib/dbwrap: make it possible to delete/store the current record during traverse
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu May 31 02:50:09 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 30 May 2012 14:50:06 +0000 (16:50 +0200)]
lib/dbwrap: don't alter the record on failure in db_rbt_store()
metze
Stefan Metzmacher [Wed, 30 May 2012 14:48:39 +0000 (16:48 +0200)]
lib/dbwrap: fix db_rbt_store and update the per record node pointer
metze
Stefan Metzmacher [Wed, 30 May 2012 14:05:03 +0000 (16:05 +0200)]
lib/dbwrap: remove unused per db_record pointer in dbwrap_rbt
metze
Ira Cooper [Wed, 30 May 2012 18:50:06 +0000 (11:50 -0700)]
Fix bad bugfix for bug #8910 - resolve_ads() code can return zero addresses and miss valid DC IP addresses
Original code incorrectly used a while() instead of a for() loop.
We need to iterate over the entire array here.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 30 23:29:03 CEST 2012 on sn-devel-104
Jeremy Allison [Tue, 29 May 2012 22:25:39 +0000 (15:25 -0700)]
Fix metze's complaint about the bugfix for bug #8953 - winbind can hang as nbt_getdc() has no timeout.
This code explicitly isn't needed as the tevent code will take
care of this.
Stefan Metzmacher [Wed, 30 May 2012 11:20:19 +0000 (13:20 +0200)]
s3:libsmb: use nb_connect_send() directly instead of doing a 0 timer for port 139
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed May 30 20:51:51 CEST 2012 on sn-devel-104
Günther Deschner [Wed, 30 May 2012 12:54:27 +0000 (14:54 +0200)]
selftest: bug #8373 is fixed and we should always test this now.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 30 18:56:38 CEST 2012 on sn-devel-104
Amitay Isaacs [Wed, 30 May 2012 11:07:38 +0000 (21:07 +1000)]
dsdb: Fix error checking conditions in partition_metadata module
Thanks to Matthieu Patou <mat@matws.net> for pointing it out.
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed May 30 17:00:01 CEST 2012 on sn-devel-104
Volker Lendecke [Wed, 30 May 2012 11:01:33 +0000 (21:01 +1000)]
librpc: Fix an incompatible pointer type warning
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Andrew Bartlett [Wed, 30 May 2012 06:40:03 +0000 (16:40 +1000)]
s4-provision: Use the s3fs file server by default in migrations
This covers both migrations from s3 and joining a domain as a new DC.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 30 14:57:22 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 30 May 2012 07:44:42 +0000 (17:44 +1000)]
s3-build: Fix configure checks for Heimdal
A series of small errors meant that all Heimdal versions became
unsupported, when for the autoconf build, some versions have what we
need.
Andrew Bartlett
Andrew Bartlett [Wed, 30 May 2012 09:21:12 +0000 (19:21 +1000)]
build: Make gss_wrap_iov mandatory for krb5 build
This isn't in Heimdal 1.1, so we still fail on that version, but at
least we fail for the right reasons.
Andrew Bartlett
Andrew Bartlett [Wed, 30 May 2012 07:41:51 +0000 (17:41 +1000)]
lib/krb5_wrap: Move krb5_princ_size helper to source4 as it is only used there
This is also where the related krb5_princ_component is declared.
Also fix the configure check to use the correct name
This helps the autoconf build on Heimdal.
Andrew Bartlett
Stefan Metzmacher [Wed, 30 May 2012 08:22:19 +0000 (10:22 +0200)]
s3:utils: use cli_tree_connect() instead of cli_tcon_andx()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed May 30 12:54:05 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 30 May 2012 08:20:11 +0000 (10:20 +0200)]
s3:libsmb: use cli_tree_connect() instead of cli_tcon_andx()
cli_tree_connect() is more generic and uses what the server supports
metze
Stefan Metzmacher [Wed, 30 May 2012 08:07:21 +0000 (10:07 +0200)]
s3:libsmb: fallback to SMBtcon for old servers
metze
Andrew Bartlett [Mon, 28 May 2012 05:00:12 +0000 (15:00 +1000)]
s3-loadparm: Swap synonyms of max/min protocol to server max/min protocol
This matches the lib/param code, as is a seperate parameter for the
client there.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 30 06:04:41 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 29 May 2012 22:23:38 +0000 (08:23 +1000)]
s3-build: We do not have CHARSET modules any more
Andrew Bartlett [Mon, 28 May 2012 07:30:44 +0000 (17:30 +1000)]
lib/param: Put common FN_ macros into param_functions.c
This will in turn make it possible to put the actual parameter
definitions in common.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 07:35:30 +0000 (17:35 +1000)]
lib/param: Add a few more s3 parameters
Andrew Bartlett [Mon, 28 May 2012 07:28:04 +0000 (17:28 +1000)]
s3-param: Use same function name for "max xmit" as lib/param
Again, this helps with merging the FN_ list.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 07:19:07 +0000 (17:19 +1000)]
s3-param: Use same variable names as lib/param
Again, this helps with merging the FN_ list.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 07:14:05 +0000 (17:14 +1000)]
s3-param: Import parameters from lib/param to make this list common
This will allow the list of FN_ macros to be made a common .c file.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 06:51:47 +0000 (16:51 +1000)]
s3-param: Rename lp_dns_proxy() -> lp_wins_dns_proxy() for clarity
This avoids some confusion now we have a DNS server as well.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 06:51:15 +0000 (16:51 +1000)]
lib/param: Import s3 parameters into lib/param to allow the parameter lists merge
This will allow us to create just one list of the FN_ macros, included
into both parameter systems.
This will in turn allow the actual parameter definitions
to be merged in a similar way.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 06:34:14 +0000 (16:34 +1000)]
lib/param: Mark a few more parameters const (matching s3)
While this makes no difference in the lib/param code, this allows the C files
to be compared and merged.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 06:26:11 +0000 (16:26 +1000)]
param: mark realm parameter as const
Andrew Bartlett [Mon, 28 May 2012 05:17:44 +0000 (15:17 +1000)]
param: Sort global param functions macros to ease the s3/s4 merge
This makes it easier to them merge these two function lists without
changing the meaning of the output.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 04:55:39 +0000 (14:55 +1000)]
lib/param: Add .flags to max/min protocol to match s3
This reduces the difference in the parameter tables.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 04:53:26 +0000 (14:53 +1000)]
lib/param: Add .flags to wins parameters to match s3
This reduces the difference in the parameter tables.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 04:47:28 +0000 (14:47 +1000)]
lib/param: Harmonise 'password server' parameter between s3 and s4
Andrew Bartlett [Tue, 22 May 2012 01:56:50 +0000 (11:56 +1000)]
s3-build: Remove build of libtdb.so from the autoconf build
We now either link tdb statically or we use the system provided tdb
This means that we now only have one build system for externally-available
tdb, which in turn ensures we have a consistent shared library built as
libtdb.so
Andrew Bartlett
Andrew Bartlett [Tue, 22 May 2012 01:55:49 +0000 (11:55 +1000)]
s3-build: Remove build of libtalloc.so from the autoconf build
We now either link talloc statically or we use the system provided talloc
This means that we now only have one build system for externally-available
talloc, which in turn ensures we have a consistent shared library built as
libtalloc.so
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 02:13:14 +0000 (12:13 +1000)]
s3-iconv: Remove unused script/gen-8bit-gap.sh
We decided to rely on a system iconv rather than these
modules.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 02:50:34 +0000 (12:50 +1000)]
build: Provide .pc file for libsmbsharemodes
This is not the exact same file as the autoconf build, because of
the differnet processing semantics.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 02:50:05 +0000 (12:50 +1000)]
build: Provide .pc file for libnetapi
This is not the exact same file as the autoconf build, because of
the differnet processing semantics.
Andrew Bartlett
Andrew Bartlett [Tue, 29 May 2012 08:56:56 +0000 (18:56 +1000)]
build: Remove unused release scripts for tevent
These now use waf dist, and the script/librelease.sh script as a wrapper.
The mksyms.sh call in the source3/Makefile uses the copy in source3/script
Andrew Bartlett
Andrew Bartlett [Tue, 29 May 2012 08:56:36 +0000 (18:56 +1000)]
build: Remove unused release scripts for tdb
These now use waf dist, and the script/librelease.sh script as a wrapper.
The mksyms.sh call in the source3/Makefile uses the copy in source3/script
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 02:15:05 +0000 (12:15 +1000)]
build: Remove unused release scripts for talloc
These now use waf dist, and the script/librelease.sh script as a wrapper.
The mksyms.sh call in the source3/Makefile uses the copy in source3/script
Andrew Bartlett
Kai Blin [Tue, 29 May 2012 21:05:14 +0000 (23:05 +0200)]
libcli/dns: Rename UDP-based calls to reflect their use
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed May 30 02:35:27 CEST 2012 on sn-devel-104
Kai Blin [Fri, 25 May 2012 05:54:39 +0000 (07:54 +0200)]
Add myself as libcli/dns maintainer
Kai Blin [Tue, 29 May 2012 22:30:29 +0000 (00:30 +0200)]
s4-dns: Use W_ERROR_HAVE_NO_MEMORY in create_response_rr
Kai Blin [Tue, 29 May 2012 22:23:33 +0000 (00:23 +0200)]
s4-dns: Use proper talloc hierarchy for NS records in create_response_rr
Kai Blin [Tue, 29 May 2012 22:23:14 +0000 (00:23 +0200)]
s4-dns: Use proper talloc hierarchy for AAAA records in create_response_rr
Volker Lendecke [Tue, 29 May 2012 08:03:13 +0000 (10:03 +0200)]
s4-dns: Remove sync dns_process
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Mon, 28 May 2012 16:42:54 +0000 (18:42 +0200)]
s4-dns: Make the TCP dns server async
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Mon, 28 May 2012 16:42:54 +0000 (18:42 +0200)]
s4-dns: Make the UDP dns server async
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Mon, 28 May 2012 16:23:50 +0000 (18:23 +0200)]
s4-dns: Remove sync dns_server_process_query
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 15:02:57 +0000 (17:02 +0200)]
s4-dns: Make dns_process_send asyn
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 14:46:29 +0000 (16:46 +0200)]
s4-dns: Remove unused sync ask_forwarder wrapper
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 12:53:47 +0000 (14:53 +0200)]
s4-dns: Make dns_server_process_query async
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 11:49:41 +0000 (13:49 +0200)]
s4-dns: Make ask_forwarder async
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 11:49:26 +0000 (13:49 +0200)]
lib: add tevent_req_poll_werror
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Tue, 29 May 2012 13:20:21 +0000 (15:20 +0200)]
s4-dns: Create a proper talloc hierarchy in create_response_rr
Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Tue, 29 May 2012 07:45:44 +0000 (09:45 +0200)]
s4-dns: Add debug output for unmappable WERROR to DNS errcode
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Tue, 29 May 2012 06:53:44 +0000 (08:53 +0200)]
s4-dns: Fix some typos
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Tue, 29 May 2012 06:45:07 +0000 (08:45 +0200)]
librpc: Fix some typos
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 14:15:41 +0000 (16:15 +0200)]
s4-dns: Remove some break; statements
We fall through implicitly, and that pattern is used elsewhere in Samba as
well.
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 13:59:32 +0000 (15:59 +0200)]
s4-dns: Fix an unlikely potential memleak
If state was alloc'ed to NULL, in_packet to != NULL and out_packet to NULL, we
leak in_packet.
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 12:57:49 +0000 (14:57 +0200)]
s4-dns: Use talloc_asprintf_append_buffer in create_response_rr
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 12:57:11 +0000 (14:57 +0200)]
s4-dns: Add some NULL checks to create_response_rr
Signed-off-by: Kai Blin <kai@samba.org>
Matthias Dieter Wallnöfer [Thu, 24 May 2012 18:43:17 +0000 (20:43 +0200)]
s4:dbchecker - handle the "none" case correctly
This means that *no* fixing will be done, also the first possible one
will be omitted as well.
Reviewed-by: abartlet
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue May 29 21:36:25 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 29 May 2012 12:08:43 +0000 (14:08 +0200)]
s3:smb2_ioctl: verify credit charge
Based on a patch from Christian Ambach <ambi@samba.org>.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 29 18:55:29 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 29 May 2012 11:25:31 +0000 (13:25 +0200)]
s3:smb2_ioctl: add more validation checks
metze
Stefan Metzmacher [Tue, 29 May 2012 10:06:22 +0000 (12:06 +0200)]
s3:smb2_ioctl: add some more validation checks
Based on a patch from Christian Ambach <ambi@samba.org>.
metze
Günther Deschner [Fri, 25 May 2012 12:50:11 +0000 (14:50 +0200)]
s4-torture: verify #8373 and add ndr nbt tests for LOGON_PRIMARY_QUERY nbt_netlogon_requests.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 29 15:49:10 CEST 2012 on sn-devel-104
Christian Ambach [Thu, 10 May 2012 12:51:13 +0000 (14:51 +0200)]
s4:torture report connection error via torture_fail
to make smbtorture report the error instead of complaining about missing torture_ call
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 29 13:57:42 CEST 2012 on sn-devel-104
Christian Ambach [Fri, 11 May 2012 17:03:50 +0000 (19:03 +0200)]
s3:smbd/smb2_find add a debug message
like the ones in the other calls that check for max sizes
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Christian Ambach [Fri, 11 May 2012 17:03:32 +0000 (19:03 +0200)]
s3:smbd/smb2_getinfo add a debug message
like the ones in the other calls that check for max sizes
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Christian Ambach [Fri, 11 May 2012 17:02:21 +0000 (19:02 +0200)]
s3:smbd/smb2_setinfo add a debug message
similar to the ones present in other paths
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Christian Ambach [Fri, 11 May 2012 17:01:43 +0000 (19:01 +0200)]
s3:smbd/smb2_read improve debug message
make the message similar to the ones in other paths
Signed-off-by: Stefan Metzmacher <metze@samba.org>