Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "dcerpc_util: let dcerpc_pull_auth_trailer() expose the reject reason"
This reverts commit
d43131aff781be614e4dcd9938290f5bdd7ef5f7.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "dcerpc_util: let dcerpc_pull_auth_trailer() expose the reject reason selftest/knownfail.d/dcerpc-auth-pad"
This reverts commit
f9e4b8cb01347b1ade2bc78910ab2dba734e6554.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "dcerpc_util: let dcerpc_pull_auth_trailer() ignore data_and_pad for bind, alter, auth3"
This reverts commit
034601c52e073e280e4d149175cfd48916683577.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "dcerpc_util: let dcerpc_pull_auth_trailer() ignore data_and_pad for bind, alter, auth3 selftest/knownfail.d/dcerpc-auth-pad"
This reverts commit
754bcf4ec557ff64f69cb69d52aeca8ddee45887.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "dcesrv_core: a failure from gensec_update results in NAK_REASON_INVALID_CHECKSUM"
This reverts commit
3be0d6dcaf66bbd14edd1870ad07e6360693b35c.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "dcesrv_core: a failure from gensec_update results in NAK_REASON_INVALID_CHECKSUM selftest/knownfail.d/dcerpc-auth-pad"
This reverts commit
aa70f761a99f6181ff183a1da91eea2aa0fcfaa6.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "dcesrv_core: alter_context logon failures should result in DCERPC_FAULT_ACCESS_DENIED"
This reverts commit
a7ffcc7fef387d4566e159ab769de42efeae7669.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "dcesrv_core: alter_context logon failures should result in DCERPC_FAULT_ACCESS_DENIED test_spnego_change_auth_type1 selftest/knownfail.d/dcerpc-auth-pad"
This reverts commit
de5313503f66d9ccc085c71d6cec561862d5bcc9.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "gensec:ntlmssp: only allow messages up to 2888 bytes"
This reverts commit
74e733f5760118690dc4ee39091f574538952fc8.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "gensec:ntlmssp: only allow messages up to 2888 bytes - selftest/knownfail.d/dcerpc-auth-pad"
This reverts commit
cfa42362bfdc4041edfdb21b1643735e550244b1.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "gensec:spnego: ignore trailing bytes in SPNEGO_SERVER_START state"
This reverts commit
8841efe00eeefa66dfadaf357cf96d5cd846146b.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "gensec:spnego: ignore trailing bytes in SPNEGO_SERVER_START state - selftest/knownfail.d/dcerpc-auth-pad"
This reverts commit
d7039225d3edd0ab48af0394ff64473f302e5a12.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "TEST7 fix comment in test_spnego_change_auth_type1"
This reverts commit
56496b051278d880b27f4819496a12f7738c7c50.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "TEST3 LATER python/samba/tests/dcerpc/raw_testcase.py get_invalid_creds"
This reverts commit
e7b4975167daff8d02c281bcc6f70afec272b4c4.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "TEST5 test_no_auth_ctx_request"
This reverts commit
cef85d8d2d0d134dde068b4f8584f3d1aa13dc20.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX7 fix default_auth_level_connect auth_invalid => FAULT_ACCESS_DENIED"
This reverts commit
e5219025e3570652df189e7a7113c96288ae2cc7.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX7 sq2 fix default_auth_level_connect auth_invalid => FAULT_ACCESS_DENIED"
This reverts commit
7ed46a31759d73a81fa79bc0078f56d281b3473b.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX8 librpc/rpc/dcesrv better fault codes dcesrv_auth_prepare_auth3"
This reverts commit
18ac21c36f4a7de3014d7e22e1fcf91538e11cc1.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX8 auth3 check against call->conn->transport_max_recv_frag"
This reverts commit
a257bd0118ffeb3abe7c0bde2594d1584515e348.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX8 auth3 with 4 legs results in DCERPC_NCA_S_PROTO_ERROR"
This reverts commit
1d668508be98d668aedc9e25d95c15697c203d1d.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX8 SQ auth3 with 4 legs results in DCERPC_NCA_S_PROTO_ERROR => no"
This reverts commit
da000aeac269cc8c8f7da34a699722f57b3168b6.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX8 auth3 fault codes"
This reverts commit
20f63deb3517e767f55fa92eb97b1c0d16d6c3e5.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX8 sq dcesrv_auth_prepare_auth3"
This reverts commit
d9a88514dca678af886d6ad800d8f4d9783f06af.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "FIX8 if (a->auth_type != auth_type) => auth_invalid"
This reverts commit
4d8548fa69098df98e8e0002e3251a63143f24b9.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "rm selftest/knownfail.d/dcerpc-auth-pad"
This reverts commit
cd4672614b13cb31160ae617aaff816f523eacc3.
Stefan Metzmacher [Wed, 10 Jan 2024 16:04:01 +0000 (17:04 +0100)]
Revert "exec SMB_CONF_PATH=/dev/null SERVER=172.31.9.188 TARGET_HOSTNAME=w2012r2-188.w2012r2-l6.base USERNAME=administrator PASSWORD=
A1b2C3d4 python/samba/tests/dcerpc/raw_protocol.py -v -f TestDCERPC_BIND"
This reverts commit
75eca2713c97471318a5b8bb707672d2881d366a.
Stefan Metzmacher [Fri, 15 Oct 2021 08:17:30 +0000 (10:17 +0200)]
exec SMB_CONF_PATH=/dev/null SERVER=172.31.9.188 TARGET_HOSTNAME=w2012r2-188.w2012r2-l6.base USERNAME=administrator PASSWORD=
A1b2C3d4 python/samba/tests/dcerpc/raw_protocol.py -v -f TestDCERPC_BIND
exec TDB_NO_FSYNC=1 make -j test _FAIL_IMMEDIATELY=1 SOCKET_WRAPPER_KEEP_PCAP=1 TESTS='raw_protocol'
Stefan Metzmacher [Tue, 17 Nov 2020 16:47:23 +0000 (17:47 +0100)]
rm selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Tue, 17 Nov 2020 13:00:34 +0000 (14:00 +0100)]
FIX8 if (a->auth_type != auth_type) => auth_invalid
Stefan Metzmacher [Tue, 17 Nov 2020 12:05:36 +0000 (13:05 +0100)]
FIX8 sq dcesrv_auth_prepare_auth3
Stefan Metzmacher [Fri, 13 Nov 2020 04:12:48 +0000 (05:12 +0100)]
FIX8 auth3 fault codes
Stefan Metzmacher [Fri, 13 Nov 2020 02:44:56 +0000 (03:44 +0100)]
FIX8 SQ auth3 with 4 legs results in DCERPC_NCA_S_PROTO_ERROR => no
fault, just a delayed one
Stefan Metzmacher [Thu, 12 Nov 2020 15:40:31 +0000 (16:40 +0100)]
FIX8 auth3 with 4 legs results in DCERPC_NCA_S_PROTO_ERROR
Stefan Metzmacher [Thu, 12 Nov 2020 15:39:58 +0000 (16:39 +0100)]
FIX8 auth3 check against call->conn->transport_max_recv_frag
Stefan Metzmacher [Fri, 13 Nov 2020 01:47:51 +0000 (02:47 +0100)]
FIX8 librpc/rpc/dcesrv better fault codes dcesrv_auth_prepare_auth3
Stefan Metzmacher [Fri, 13 Nov 2020 10:29:30 +0000 (11:29 +0100)]
FIX7 sq2 fix default_auth_level_connect auth_invalid => FAULT_ACCESS_DENIED
Stefan Metzmacher [Fri, 13 Nov 2020 09:55:43 +0000 (10:55 +0100)]
FIX7 fix default_auth_level_connect auth_invalid => FAULT_ACCESS_DENIED
Stefan Metzmacher [Tue, 17 Nov 2020 09:05:41 +0000 (10:05 +0100)]
TEST5 test_no_auth_ctx_request
Stefan Metzmacher [Thu, 12 Nov 2020 15:41:53 +0000 (16:41 +0100)]
TEST3 LATER python/samba/tests/dcerpc/raw_testcase.py get_invalid_creds
Stefan Metzmacher [Tue, 17 Nov 2020 16:44:51 +0000 (17:44 +0100)]
TEST7 fix comment in test_spnego_change_auth_type1
Stefan Metzmacher [Wed, 11 Nov 2020 16:03:29 +0000 (17:03 +0100)]
gensec:spnego: ignore trailing bytes in SPNEGO_SERVER_START state - selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Wed, 11 Nov 2020 16:03:29 +0000 (17:03 +0100)]
gensec:spnego: ignore trailing bytes in SPNEGO_SERVER_START state
This matches Windows (at least Server 2012_R2).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 17 Feb 2021 23:40:56 +0000 (00:40 +0100)]
gensec:ntlmssp: only allow messages up to 2888 bytes - selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Thu, 12 Nov 2020 09:00:07 +0000 (10:00 +0100)]
gensec:ntlmssp: only allow messages up to 2888 bytes
This matches Windows (at least Server 2012_R2).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 12 Nov 2020 15:41:21 +0000 (16:41 +0100)]
dcesrv_core: alter_context logon failures should result in DCERPC_FAULT_ACCESS_DENIED test_spnego_change_auth_type1 selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Thu, 12 Nov 2020 15:41:21 +0000 (16:41 +0100)]
dcesrv_core: alter_context logon failures should result in DCERPC_FAULT_ACCESS_DENIED
We should use DCERPC_FAULT_ACCESS_DENIED as default for
gensec status results of e.g. NT_STATUS_LOGON_FAILURE or
NT_STATUS_INVALID_PARAMTER.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 12 Nov 2020 15:41:05 +0000 (16:41 +0100)]
dcesrv_core: a failure from gensec_update results in NAK_REASON_INVALID_CHECKSUM selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Thu, 12 Nov 2020 15:41:05 +0000 (16:41 +0100)]
dcesrv_core: a failure from gensec_update results in NAK_REASON_INVALID_CHECKSUM
We already report that for gensec_start_mech_by_authtype() failures,
but we also need to do that for any invalid authentication.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 11 Nov 2020 16:07:54 +0000 (17:07 +0100)]
dcerpc_util: let dcerpc_pull_auth_trailer() ignore data_and_pad for bind, alter, auth3 selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Wed, 11 Nov 2020 16:07:54 +0000 (17:07 +0100)]
dcerpc_util: let dcerpc_pull_auth_trailer() ignore data_and_pad for bind, alter, auth3
Sometimes Windows sends 3 presentation contexts (NDR32, NDR64,
BindTimeFeatureNegotiation) in the first BIND of an association.
Binding an additional connection to the association seems to
reuse the BIND buffer and just changes the num_contexts field from
3 to 2 and leaves the BindTimeFeatureNegotiation context as padding
in places.
Note, the auth_pad_length field is send as 0 in that case,
which means we need to ignore it completely, as well as any
padding before the auth header.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 11 Nov 2020 16:59:45 +0000 (17:59 +0100)]
dcerpc_util: let dcerpc_pull_auth_trailer() expose the reject reason selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Wed, 11 Nov 2020 16:59:45 +0000 (17:59 +0100)]
dcerpc_util: let dcerpc_pull_auth_trailer() expose the reject reason
If dcerpc_pull_auth_trailer() returns NT_STATUS_RPC_PROTOCOL_ERROR
it will return the BIND reject code in auth->auth_context_id.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 11 Nov 2020 16:05:21 +0000 (17:05 +0100)]
dcerpc_util: let dcerpc_pull_auth_trailer() check that auth_offset is 4 bytes aligned selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Wed, 11 Nov 2020 16:05:21 +0000 (17:05 +0100)]
dcerpc_util: let dcerpc_pull_auth_trailer() check that auth_offset is 4 bytes aligned
That what Windows (at least 2012_R2) also asserts.
It also makes sure that ndr_pull_dcerpc_auth() will
start with ndr->offset = 0 and don't tries to eat
possible padding.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 12 Nov 2020 10:10:46 +0000 (11:10 +0100)]
TEST2 TODO test_schannel_invalid_bind selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Thu, 12 Nov 2020 10:10:46 +0000 (11:10 +0100)]
TEST2 TODO test_schannel_invalid_bind
Stefan Metzmacher [Thu, 12 Nov 2020 16:22:19 +0000 (17:22 +0100)]
TEST1b test_spnego_connect_bind_auth_align[4|2] selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Thu, 12 Nov 2020 16:22:19 +0000 (17:22 +0100)]
TEST1b test_spnego_connect_bind_auth_align[4|2]
Stefan Metzmacher [Wed, 11 Nov 2020 00:19:23 +0000 (01:19 +0100)]
TEST1 python/samba/tests/dcerpc/raw_protocol.py selftest/knownfail.d/dcerpc-auth-pad
Stefan Metzmacher [Wed, 11 Nov 2020 00:19:23 +0000 (01:19 +0100)]
TEST1 python/samba/tests/dcerpc/raw_protocol.py
Stefan Metzmacher [Thu, 12 Nov 2020 15:38:32 +0000 (16:38 +0100)]
dcesrv_core: introduce dcesrv_connection->transport_max_recv_frag
The max fragment size depends on the transport.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 16 Nov 2020 14:01:49 +0000 (15:01 +0100)]
tests/dcerpc/raw_protocol: run test_neg_xmit_ffff_ffff over tcp and smb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 16 Nov 2020 15:58:35 +0000 (16:58 +0100)]
dcesrv_core: add more verbose debugging for missing association groups
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 11 Nov 2020 15:49:25 +0000 (16:49 +0100)]
RawDCERPCTest: add some more auth_length related asserts
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 9 Nov 2020 13:00:43 +0000 (14:00 +0100)]
RawDCERPCTest: split prepare_pdu() and send_pdu_blob() out of send_pdu()
This will make it possible to alter pdus before sending them to the
server.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 12 Nov 2020 09:34:38 +0000 (10:34 +0100)]
s4:librpc: provide py_schannel bindings
This will be used in the dcerpc.raw_protocol test.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 20 Oct 2021 18:27:12 +0000 (20:27 +0200)]
debug fault
Stefan Metzmacher [Wed, 20 Oct 2021 19:10:28 +0000 (21:10 +0200)]
Revert "debug fault"
This reverts commit
b9cc9004f5d95ac29504b1e4dafe01c6be7c56ee.
Stefan Metzmacher [Wed, 20 Oct 2021 18:27:12 +0000 (20:27 +0200)]
debug fault
Stefan Metzmacher [Mon, 8 Jan 2024 15:42:35 +0000 (16:42 +0100)]
Revert "TODO smb2_tcon: add some share flags options (Default:off)"
This reverts commit
2b748b2f8ffad1ad624da48dc822b093571cc919.
Stefan Metzmacher [Thu, 8 Feb 2024 15:39:17 +0000 (16:39 +0100)]
Revert "TODO: s3:smb2_negprot: announce persistent handle support (default: no)"
This reverts commit
1343f1122636dcd9493324df6be9d066a665bc24.
Stefan Metzmacher [Thu, 26 Jul 2012 00:49:16 +0000 (02:49 +0200)]
TODO: s3:smb2_negprot: announce persistent handle support (default: no)
add "smbd:announce persistent handles" option (default: false)
Stefan Metzmacher [Tue, 31 Jul 2012 06:55:20 +0000 (08:55 +0200)]
TODO smb2_tcon: add some share flags options (Default:off)
Stefan Metzmacher [Wed, 22 Nov 2023 10:18:24 +0000 (11:18 +0100)]
Revert "LATER??? ctdb: simplify struct ctdb_connection"
This reverts commit
e164baa2bc28d13c2e0ff54ef3cfc1cfeda705a2.
Stefan Metzmacher [Wed, 22 Nov 2023 09:29:38 +0000 (10:29 +0100)]
LATER??? ctdb: simplify struct ctdb_connection
The strange unions where 'src' also means 'server'
and 'dst' also means 'client' is really strange and the
reverse of what someone would expect from a typical tcp
connection.
TODO: ctdb_killtcp.c looks strange...
Stefan Metzmacher [Thu, 11 Jan 2024 15:18:18 +0000 (16:18 +0100)]
TODO async source4/librpc/rpc/pyrpc.c
Stefan Metzmacher [Fri, 15 Dec 2023 13:49:37 +0000 (14:49 +0100)]
TODO source3/utils/net_witness.c wipe-stale-registrations
Stefan Metzmacher [Mon, 15 Jan 2024 21:50:52 +0000 (22:50 +0100)]
Revert "HACK python/samba/tests/blackbox/rpcd_witness_samba_only.py only net witness tests"
This reverts commit
902b320c0d04977602e736c235ca2656ac19e7de.
Stefan Metzmacher [Mon, 15 Jan 2024 21:49:55 +0000 (22:49 +0100)]
HACK python/samba/tests/blackbox/rpcd_witness_samba_only.py only net witness tests
Stefan Metzmacher [Fri, 19 Jan 2024 16:20:11 +0000 (17:20 +0100)]
LATER? NEEDED? net witness ip-notify"
Stefan Metzmacher [Fri, 19 Jan 2024 16:20:11 +0000 (17:20 +0100)]
LATER? NEEDED? source3/rpc_server/witness/srv_witness_nt.c RPCD_WITNESS_REGISTRATION_UPDATE_IP_NOTIFY
Stefan Metzmacher [Fri, 19 Jan 2024 16:20:11 +0000 (17:20 +0100)]
LATER? NEEDED? source3/librpc/idl/rpcd_witness.idl add RPCD_WITNESS_REGISTRATION_UPDATE_IP_NOTIFY
Stefan Metzmacher [Mon, 22 Jan 2024 16:39:58 +0000 (17:39 +0100)]
Revert "HACK python/samba/tests/blackbox/rpcd_witness_samba_only.py only net witness tests"
This reverts commit
fb8dcb4bcf0770e90bb13b20a57f86b9341ca742.
Stefan Metzmacher [Mon, 15 Jan 2024 21:49:55 +0000 (22:49 +0100)]
HACK python/samba/tests/blackbox/rpcd_witness_samba_only.py only net witness tests
Stefan Metzmacher [Thu, 8 Feb 2024 15:31:04 +0000 (16:31 +0100)]
sq docs-xml/smbdotconf/protocol/smb3sharecaps.xml
Stefan Metzmacher [Thu, 8 Feb 2024 15:13:01 +0000 (16:13 +0100)]
sq smb2_tcon: only announce SMB3 related share capabilities if SMB3 is used
Stefan Metzmacher [Thu, 8 Feb 2024 14:43:39 +0000 (15:43 +0100)]
docs-xml: document "smb3 share cap:{CONTINUOUS AVAILABILITY,SCALE OUT,CLUSTER,ASYMMETRIC}"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15577
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 8 Feb 2024 14:31:10 +0000 (15:31 +0100)]
smb2_tcon: only announce SMB3 related share capabilities if SMB3 is used
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15577
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 8 Feb 2024 14:15:28 +0000 (15:15 +0100)]
smb2_tcon: only announce SMB2_SHARE_CAP_CLUSTER if rpcd_witness can run
rpcd_witness needs ncacn_ip_tcp support and that's only
available if samba-dcerpcd is not started on demand.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15577
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 8 Feb 2024 13:25:05 +0000 (14:25 +0100)]
docs-xml: add details for 'net witness'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15577
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 8 Feb 2024 14:07:42 +0000 (15:07 +0100)]
s3:utils: fix help string for 'net witness force-response'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15577
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Fri, 2 Feb 2024 12:54:20 +0000 (13:54 +0100)]
ctdb/events: add 47.samba-dcerpcd.script
If someone wants to enable the witness service
samba-dcerpcd needs to be started as standalone service
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15577
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Fri, 2 Feb 2024 12:54:20 +0000 (13:54 +0100)]
ctdb/events: use 'service "$CTDB_SERVICE_NMB" status' in 48.netbios.script
We can easily monitor if the service is running at all,
that better than no monitoring at all...
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15577
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Jo Sutton [Fri, 12 Jan 2024 00:28:55 +0000 (13:28 +1300)]
selftest: Fix code spelling
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 8 03:51:51 UTC 2024 on atb-devel-224
Jo Sutton [Thu, 11 Jan 2024 22:39:11 +0000 (11:39 +1300)]
s4:dsdb: Fix code formatting
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Jo Sutton [Thu, 11 Jan 2024 21:43:39 +0000 (10:43 +1300)]
s4:dsdb: Avoid buffer overflow in samdb_result_hashes()
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Jo Sutton [Thu, 11 Jan 2024 21:42:51 +0000 (10:42 +1300)]
s4:dsdb: Mark hash returned by samdb_result_hash() as secret
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Jo Sutton [Thu, 11 Jan 2024 02:05:22 +0000 (15:05 +1300)]
s4:dsdb: Correct reference to source file
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Jo Sutton [Thu, 11 Jan 2024 02:05:07 +0000 (15:05 +1300)]
s4:dsdb: Remove trailing whitespace
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Jo Sutton [Mon, 8 Jan 2024 02:05:11 +0000 (15:05 +1300)]
s4:dsdb: Correct NDR push error message
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
git.samba.org / metze / samba / wip.git / log