Wayne Davison [Tue, 31 Oct 2006 19:21:57 +0000 (19:21 +0000)]
Need to include netinet/tcp.h to get TCP_NODELAY defined.
Wayne Davison [Sat, 28 Oct 2006 21:22:26 +0000 (21:22 +0000)]
Mention the addition of the fake-super.diff patch.
Wayne Davison [Fri, 27 Oct 2006 17:51:21 +0000 (17:51 +0000)]
Don't put backslashes before the dashes in " -- ".
Wayne Davison [Fri, 27 Oct 2006 17:29:09 +0000 (17:29 +0000)]
Mention the fix for bug #4079.
Wayne Davison [Thu, 26 Oct 2006 19:19:23 +0000 (19:19 +0000)]
Mention WIFEXITED() change.
Wayne Davison [Thu, 26 Oct 2006 17:22:15 +0000 (17:22 +0000)]
Mention Mac OS X xattr work.
Wayne Davison [Thu, 26 Oct 2006 17:06:41 +0000 (17:06 +0000)]
Preparing for release of 2.6.9pre3
Wayne Davison [Tue, 24 Oct 2006 16:17:31 +0000 (16:17 +0000)]
Run tweak_manpage_dashes on the man pages we generate.
Wayne Davison [Tue, 24 Oct 2006 15:09:57 +0000 (15:09 +0000)]
Undo temporary changes used for build-farm testing of ACL patch.
Wayne Davison [Tue, 24 Oct 2006 03:31:30 +0000 (03:31 +0000)]
Added a define for WIFEXITED() that is used if one is missing.
Wayne Davison [Tue, 24 Oct 2006 00:56:46 +0000 (00:56 +0000)]
Document the --no-motd option.
Wayne Davison [Tue, 24 Oct 2006 00:36:46 +0000 (00:36 +0000)]
Document the --no-motd option, with a caveat on how it can also
hide the module listing.
Wayne Davison [Tue, 24 Oct 2006 00:36:42 +0000 (00:36 +0000)]
Obey the new --no-motd option.
Wayne Davison [Tue, 24 Oct 2006 00:36:38 +0000 (00:36 +0000)]
Added the --no-motd option to silence just the text output at the
start of a daemon transfer.
Wayne Davison [Tue, 24 Oct 2006 00:33:32 +0000 (00:33 +0000)]
Post-process manpages with the tweak_manpage_dashes perl script.
Wayne Davison [Tue, 24 Oct 2006 00:24:56 +0000 (00:24 +0000)]
Run patch with -t so that it doesn't ask any questions.
Wayne Davison [Tue, 24 Oct 2006 00:09:18 +0000 (00:09 +0000)]
A perl script that does appropriate backslash escaping of '-' chars
in manpages.
Wayne Davison [Sun, 22 Oct 2006 22:36:36 +0000 (22:36 +0000)]
- Fixed an error-handling path in try_dests_reg().
- Added a comment.
Wayne Davison [Sun, 22 Oct 2006 07:29:21 +0000 (07:29 +0000)]
Use "test" instead of "[ ... ]" for better portability.
Wayne Davison [Sun, 22 Oct 2006 07:18:21 +0000 (07:18 +0000)]
Added missing cleanup of empty ACL files.
Wayne Davison [Sun, 22 Oct 2006 04:26:59 +0000 (04:26 +0000)]
Change the unpatch code for NetBSD.
Wayne Davison [Sun, 22 Oct 2006 03:17:45 +0000 (03:17 +0000)]
Temporary changes to have the build-farm configure and build
the ACL version of rsync (patched in via patches/acls.diff).
Wayne Davison [Wed, 18 Oct 2006 05:20:05 +0000 (05:20 +0000)]
Mention the fix that lets a push now override the partial-dir exclude.
Wayne Davison [Wed, 18 Oct 2006 05:15:35 +0000 (05:15 +0000)]
The server should not be adding an assumed filter rule based on the
partial-dir setting (since the client is sending us the rules).
Wayne Davison [Wed, 18 Oct 2006 05:14:10 +0000 (05:14 +0000)]
Added a risk filter for the partial-dir since we use --delete-after.
Wayne Davison [Wed, 18 Oct 2006 04:46:26 +0000 (04:46 +0000)]
Stop disabling the RSYNC_PARTIAL_DIR environment variable now that
there is a newer rsync on samba.org.
Wayne Davison [Tue, 17 Oct 2006 18:49:04 +0000 (18:49 +0000)]
Make sure the new link_dest_used value gets zeroed on init.
Wayne Davison [Mon, 16 Oct 2006 18:11:24 +0000 (18:11 +0000)]
- Fixed a compile problem ("len" not defined) in inet_ntop4().
- Replaced sprintf() with snprintf() in inet_ntop6().
Wayne Davison [Sun, 15 Oct 2006 21:44:15 +0000 (21:44 +0000)]
- Die if we can't edit the release date into NEWS or OLDNEWS.
- Don't remove any *pre*diff* files until the final release.
Wayne Davison [Sun, 15 Oct 2006 15:57:27 +0000 (15:57 +0000)]
Improved a comment.
Wayne Davison [Sun, 15 Oct 2006 15:49:31 +0000 (15:49 +0000)]
Improved a couple existing items.
Wayne Davison [Sun, 15 Oct 2006 15:43:26 +0000 (15:43 +0000)]
Use the new case_N.h file to make sure that our cleanup_step case
statements never get out of sequence when the code changes.
Wayne Davison [Sun, 15 Oct 2006 15:42:01 +0000 (15:42 +0000)]
A helper file for cleanup.c.
Wayne Davison [Sun, 15 Oct 2006 05:04:59 +0000 (05:04 +0000)]
Now that samba.org has a modern rsync, we can go back to using
hard-links on the moved files and use rsync to effect the hard-
links on the remote system (which will make a future transfer
more efficient in the absense of --detect-renamed).
Wayne Davison [Sat, 14 Oct 2006 20:35:17 +0000 (20:35 +0000)]
Preparing for release of 2.6.9pre2
Wayne Davison [Sat, 14 Oct 2006 20:31:33 +0000 (20:31 +0000)]
Use the MAX_RENAMES_DIGITS define in the relevant snprintf().
Wayne Davison [Sat, 14 Oct 2006 20:30:43 +0000 (20:30 +0000)]
Improved the description of the code-checker work..
Wayne Davison [Sat, 14 Oct 2006 20:01:22 +0000 (20:01 +0000)]
Updated the news about the exit_cleanup() improvement.
Wayne Davison [Sat, 14 Oct 2006 19:58:52 +0000 (19:58 +0000)]
Improved the _exit_cleanup() function to handle potential recursions
back to the function via the calls that it is making. The new code
treats each recursion back into the function as an opportunity to
take up where we left off (skipping whatever step just failed).
Wayne Davison [Sat, 14 Oct 2006 18:51:21 +0000 (18:51 +0000)]
Got rid of EXIT_OR_RETURN() macro again -- switching to a better
recursion-prevention heuristic in _exit_cleanup().
Wayne Davison [Sat, 14 Oct 2006 02:29:29 +0000 (02:29 +0000)]
The cleanup code that handles moving the temp file to the partial
file needed to check that cleanup_fname was not NULL to prevent
any possibility of a recursion starting into that code again.
Wayne Davison [Sat, 14 Oct 2006 02:02:47 +0000 (02:02 +0000)]
Mention the latest fixes and internal changes.
Wayne Davison [Sat, 14 Oct 2006 01:17:36 +0000 (01:17 +0000)]
Got rid of the recent paranoid length check because it didn't help
to silence a code-checker warning.
Wayne Davison [Sat, 14 Oct 2006 01:15:16 +0000 (01:15 +0000)]
Restore build order back to normal.
Wayne Davison [Fri, 13 Oct 2006 23:46:32 +0000 (23:46 +0000)]
Changed sprintf() calls to snprintf().
Wayne Davison [Fri, 13 Oct 2006 23:42:52 +0000 (23:42 +0000)]
Turned an sprintf() call into snprintf().
Wayne Davison [Fri, 13 Oct 2006 23:38:14 +0000 (23:38 +0000)]
- Changed some sprintf() calls to snprintf() calls.
- Changed two last strcpy() calls to strlcpy() calls.
Wayne Davison [Fri, 13 Oct 2006 23:35:53 +0000 (23:35 +0000)]
Changed sprintf() calls to snprintf() calls.
Wayne Davison [Fri, 13 Oct 2006 23:17:37 +0000 (23:17 +0000)]
Changed strcpy() calls into memcpy() calls.
Wayne Davison [Fri, 13 Oct 2006 23:17:33 +0000 (23:17 +0000)]
Changed strcpy() calls into strlcpy() calls, just to be extra safe.
Wayne Davison [Fri, 13 Oct 2006 23:17:30 +0000 (23:17 +0000)]
Added a paranoid length check.
Wayne Davison [Fri, 13 Oct 2006 23:17:27 +0000 (23:17 +0000)]
- Changed strcpy() calls into strlcpy() calls, just to be extra safe.
- Added a default: exit_cleanup() case to a switch.
- Made the check_name() function take a buffer size arg.
Wayne Davison [Fri, 13 Oct 2006 17:07:13 +0000 (17:07 +0000)]
- Use precompiler conditionals in to_wire_mode() and from_write_mode()
to get rid of code that is not needed on the current system.
- Silence a code-checker warning in send_file_entry().
- Silence a code-checker warning in make_file().
- Fixed a bug in f_name_cmp() that could compare an empty filename
incorrectly (which might only happen if we transformed a dot-dir
into an empty name). (Thanks, code checker!)
Wayne Davison [Fri, 13 Oct 2006 17:02:39 +0000 (17:02 +0000)]
More temporary name juggling to get all code analyzed.
Wayne Davison [Fri, 13 Oct 2006 14:28:56 +0000 (14:28 +0000)]
Changed one more exit_cleanup() call into EXIT_OR_RETURN().
Wayne Davison [Fri, 13 Oct 2006 14:17:22 +0000 (14:17 +0000)]
Temporarily reorder the OBJS line so that the IBM code checker
can analyze some of the other programs (since it runs out of
time analyzing them all).
Wayne Davison [Fri, 13 Oct 2006 07:48:35 +0000 (07:48 +0000)]
Use new FNONE value when setting/comparing enum logcode vars.
Wayne Davison [Fri, 13 Oct 2006 07:38:21 +0000 (07:38 +0000)]
- Use the new FNONE enum instead of a literal 0 value.
Wayne Davison [Fri, 13 Oct 2006 07:38:18 +0000 (07:38 +0000)]
If in_exit_cleanup is set, some of our functions return instead of
calling exit_cleanup() (which is a safer way to avoid an infinite
loop when the exit code uses the log functions than allowing the
_exit_cleanup() function to return back into our code).
Wayne Davison [Fri, 13 Oct 2006 07:38:15 +0000 (07:38 +0000)]
- When exiting, set the flag "in_exit_cleanup".
- Mark _exit_cleanup() with NORETURN.
- Don't ever return from _exit_cleanup().
Wayne Davison [Fri, 13 Oct 2006 07:38:11 +0000 (07:38 +0000)]
Mark out_of_memory() and overflow_exit() with NORETURN.
Wayne Davison [Fri, 13 Oct 2006 07:38:05 +0000 (07:38 +0000)]
- Added FNONE to the "enum logcode" values.
- Added a NORETURN define to mark a function that never returns.
Wayne Davison [Fri, 13 Oct 2006 07:18:29 +0000 (07:18 +0000)]
Silence some IBM checker warnings and made a slight optimization
to get_tmpname().
Wayne Davison [Fri, 13 Oct 2006 06:50:56 +0000 (06:50 +0000)]
Simplified the function-finding regex, and made it more versatile
(so we don't need to keep adding variable-type strings).
Wayne Davison [Fri, 13 Oct 2006 06:49:44 +0000 (06:49 +0000)]
Indented the function comments with "* ".
Wayne Davison [Fri, 13 Oct 2006 06:27:59 +0000 (06:27 +0000)]
Don't use a bool directly in an int comparison.
Wayne Davison [Fri, 13 Oct 2006 06:26:02 +0000 (06:26 +0000)]
Function fcntl() only takes 2 args when using F_GETFL.
Wayne Davison [Fri, 13 Oct 2006 06:24:24 +0000 (06:24 +0000)]
Cast pat_len to an int when using it as a field width.
Wayne Davison [Fri, 13 Oct 2006 04:59:53 +0000 (04:59 +0000)]
Some OSes can't chmod -t for a file, so I changed the logic of our
to to substitute a chmod that will work everywhere.
Wayne Davison [Fri, 13 Oct 2006 01:37:44 +0000 (01:37 +0000)]
- Clarified the "dont compress" option.
- Cleaned up some trailing whitespace.
Wayne Davison [Fri, 13 Oct 2006 01:24:57 +0000 (01:24 +0000)]
Updated the man pages to work with version 2.x of yodl.
Wayne Davison [Fri, 13 Oct 2006 01:22:48 +0000 (01:22 +0000)]
Fixed an infinite loop in parse_rule() when a filter rule is too
longer for MAXPATHLEN. Also fixed a couple spots nearby that were
erroneously treating pointer "cp" as a '\0'-terminated string.
Wayne Davison [Thu, 12 Oct 2006 03:45:53 +0000 (03:45 +0000)]
Preparing for release of 2.6.9pre1
Wayne Davison [Thu, 12 Oct 2006 03:44:44 +0000 (03:44 +0000)]
Added a line for 2.6.9.
Wayne Davison [Thu, 12 Oct 2006 03:32:18 +0000 (03:32 +0000)]
Make sure we tweak the right RSYNC_VERSION line in configure.
Wayne Davison [Thu, 12 Oct 2006 03:01:18 +0000 (03:01 +0000)]
Removed the changes in symlink handling in non-chroot daemon mode as
they were not yet safe (I'll consider similar changes for the next
release).
Wayne Davison [Thu, 12 Oct 2006 03:01:12 +0000 (03:01 +0000)]
Got rid of changes that aren't going to make it into 2.6.9.
Wayne Davison [Thu, 12 Oct 2006 03:01:01 +0000 (03:01 +0000)]
Changed the indent for one else ... if section.
Wayne Davison [Thu, 12 Oct 2006 02:14:47 +0000 (02:14 +0000)]
Some minor improvements to parse_merge_name().
Wayne Davison [Wed, 11 Oct 2006 00:51:50 +0000 (00:51 +0000)]
Renumbered tests after adding one in the middle.
Wayne Davison [Wed, 11 Oct 2006 00:04:48 +0000 (00:04 +0000)]
Handle the itemizing of of the "." dir when it is newly created.
Wayne Davison [Wed, 11 Oct 2006 00:04:44 +0000 (00:04 +0000)]
If new_root_dir is set, itemize the output of the "." dir as a
directory-creation event.
Wayne Davison [Wed, 11 Oct 2006 00:04:41 +0000 (00:04 +0000)]
Added a new variable, new_root_dir, that is set if we created the
destination directory.
Wayne Davison [Tue, 10 Oct 2006 23:44:59 +0000 (23:44 +0000)]
Changed the fix_basis_dirs() function to only remove a single ../
prefix from each --*-dest option's path.
Wayne Davison [Mon, 9 Oct 2006 03:06:50 +0000 (03:06 +0000)]
Made some of the --link-dest tests use a relative destination
directory, and made one of those do a --dry-run test before
the regular test.
Wayne Davison [Mon, 9 Oct 2006 03:05:19 +0000 (03:05 +0000)]
- If a finished link came from a link-dest dir and --dry-run is in
effect, we now stat the link-dest file instead of the non-existent
destination file.
- Use int32 for the index variables.
Wayne Davison [Mon, 9 Oct 2006 02:59:23 +0000 (02:59 +0000)]
If the combination of --dry-run, --link-dest, and -H finds a matching
file in on of the extra basis dirs, make a note of which basis dir
we would have used in the hard-link with the destination file.
Wayne Davison [Mon, 9 Oct 2006 02:57:04 +0000 (02:57 +0000)]
Added link_dest_used unsigned short to struct hlink and made the
other values explicitly 32-bit so that the total size can't be
larger than the other struct we're in a union with.
Wayne Davison [Mon, 9 Oct 2006 00:55:04 +0000 (00:55 +0000)]
Another tweak to the --chmod summary.
Wayne Davison [Sun, 8 Oct 2006 22:17:39 +0000 (22:17 +0000)]
Mention the latest bug fix.
Wayne Davison [Sun, 8 Oct 2006 22:02:13 +0000 (22:02 +0000)]
Make the daemon's "incoming chmod" tweaks happen last, as documented.
Wayne Davison [Sun, 8 Oct 2006 22:00:31 +0000 (22:00 +0000)]
Clarify the short description of --chmod.
Wayne Davison [Sun, 8 Oct 2006 20:57:01 +0000 (20:57 +0000)]
Call push_dir() with its new boolean arg.
Wayne Davison [Sun, 8 Oct 2006 20:56:56 +0000 (20:56 +0000)]
- Call push_dir() with its new boolean arg, including the spot in
get_local_name() where we need push_dir() to skip the chdir() because
the destination dir does no yet exist and --dry-run was specified.
- Added fix_basis_dirs(), which will combine the dest-dir with each non-
absolute basis_dir arg to make sure that they end up being relative to
the right dir when --dry-run was specified and the dest dir does not
yet exist.
Wayne Davison [Sun, 8 Oct 2006 20:56:52 +0000 (20:56 +0000)]
Made the push_dir() function take an option to skip the actual chdir()
call. Used when the dest-dir doesn't exist and --dry-run was specified.
Wayne Davison [Sat, 7 Oct 2006 14:54:56 +0000 (14:54 +0000)]
Moved some of the variable setup from "make check" into the
runtest.sh script.
Wayne Davison [Sat, 7 Oct 2006 14:54:14 +0000 (14:54 +0000)]
Moved some variable setup here from the Makefile and made it
possible to specify extra rsync options for the test.
Wayne Davison [Sat, 7 Oct 2006 14:39:01 +0000 (14:39 +0000)]
Changed the -o to -a in the "if".
Wayne Davison [Sat, 7 Oct 2006 14:19:00 +0000 (14:19 +0000)]
A bug-fix for die_on_unsafe_path() when the path doesn't exist.
Wayne Davison [Sat, 30 Sep 2006 22:11:20 +0000 (22:11 +0000)]
Added exception-checking to a couple select() calls, as suggested
by Hugh Daschbach.