Jeremy Allison [Fri, 5 Jan 2007 17:42:54 +0000 (17:42 +0000)]
r20558: Refactor rmdir_internals to use early termination rather
than lots of indented code. Change recursive_rmdir()
to return the smbd standards of True on success, False
on fail (it was doing the reverse, which was very confusing).
Jeremy.
(This used to be commit
27dc5bebda7ffbdcb2371638f6132063a953fba2)
Volker Lendecke [Fri, 5 Jan 2007 14:52:10 +0000 (14:52 +0000)]
r20546: Fix some IBM checker errors
(This used to be commit
8f67efd582655e03fea746eee499f3cab6cbdb4d)
Volker Lendecke [Fri, 5 Jan 2007 13:13:15 +0000 (13:13 +0000)]
r20544: Change copy_file() to return NTSTATUS. This is in preparation of turning
close_file() to NTSTATUS as well.
I'm not sure I got all the error codes right, but as I've never come across a
smb_copy() call in all my Samba work, I'm leaving it at that. If I'm
absolutely bored, I will write a thorough torture test.
As far as I can see, Samba4 even does not have a libcli implementation for
it... :-)
Volker
(This used to be commit
5ebdf02ba166df69e210e6f70c01a44e6205ecc1)
Volker Lendecke [Fri, 5 Jan 2007 11:31:28 +0000 (11:31 +0000)]
r20542: Make close_remove_share_mode retun NTSTATUS. Not that anybody cares yet...
(This used to be commit
c8995771531caa4ec9bcaef2c29b11ee7d8e49e6)
Volker Lendecke [Fri, 5 Jan 2007 11:18:59 +0000 (11:18 +0000)]
r20541: Fix some obvious glitches in wait_for_aio_completion. Hmmm. It seems
reply_close() at its heart is going to be an async call :-)
Volker
(This used to be commit
36f60407ae9b430dc5d7f67dd3e7ed8b1dbc93a8)
Günther Deschner [Thu, 4 Jan 2007 23:41:16 +0000 (23:41 +0000)]
r20536: In the offline PAM session close case the attempt to delete a
non-existing krb5 credential cache should not generate an error.
Guenther
(This used to be commit
11c6f573af5c1d3387e60f3fc44b00e28cd87813)
Jeremy Allison [Thu, 4 Jan 2007 23:25:04 +0000 (23:25 +0000)]
r20535: Fix make install to work when root doesn't have
write access into the source tree (like when your
directory is nfs mounted for example....).
Jeremy.
(This used to be commit
7dcb61d1b2d08270a8c718328a26ef4866a1c500)
Jeremy Allison [Thu, 4 Jan 2007 22:01:36 +0000 (22:01 +0000)]
r20532: From Volker...
"smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow.
Merge to 3.0.24?"
Yep (with slight optimization).
Jeremy.
(This used to be commit
dcc7bca1adbc69f348d46291ec2cbfaf5d8486bc)
Jeremy Allison [Thu, 4 Jan 2007 20:46:13 +0000 (20:46 +0000)]
r20530: Don't want this call to get inadvertently re-added :-).
Jeremy.
(This used to be commit
68c4fbcf3397d6c43a3e5809b20a23116b1f8a31)
Volker Lendecke [Thu, 4 Jan 2007 16:26:15 +0000 (16:26 +0000)]
r20525: Closing a dir with del-on-close set requires the same as files: Don't actually
unlink/rmdir if another process still has it open.
Jeremy, this is a potential merger to 3.0.24.
Volker
(This used to be commit
8e1e896b02da99b5a48883c5f37fe146ad0fb5ce)
Volker Lendecke [Thu, 4 Jan 2007 15:12:22 +0000 (15:12 +0000)]
r20524: Simplify logic of close_remove_share_mode().
Volker
(This used to be commit
ade90dbf0c2cbd2cc49a6357f3dd220ea82fd215)
Günther Deschner [Wed, 3 Jan 2007 16:05:00 +0000 (16:05 +0000)]
r20512: Fix typo.
Guenther
(This used to be commit
36bd5cb21bdaf35c7dae47f8b8e93822b3f6188c)
Volker Lendecke [Wed, 3 Jan 2007 12:01:17 +0000 (12:01 +0000)]
r20507: smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow.
Merge to 3.0.24?
Volker
(This used to be commit
f2563ac98f8ec7af8083d2b62186753acba7a9dd)
Volker Lendecke [Wed, 3 Jan 2007 09:30:55 +0000 (09:30 +0000)]
r20503: And one more 64-bit warning
(This used to be commit
7bcde1069e38d70808d78c408f16821a0bfadcdd)
Volker Lendecke [Wed, 3 Jan 2007 09:04:06 +0000 (09:04 +0000)]
r20502: Activate RAW-RENAME, my Linux box passes this
(This used to be commit
56c8d2cfed273655b2c79b3a2c613a7253e05221)
Volker Lendecke [Wed, 3 Jan 2007 08:55:22 +0000 (08:55 +0000)]
r20501: Check in config.h fix from Michael Adam <ma@sernet.de>
(This used to be commit
d10dd47fb8908a4372aa6932e40b23189784522c)
James Peach [Wed, 3 Jan 2007 06:55:12 +0000 (06:55 +0000)]
r20500: Fix compiler warnings.
(This used to be commit
9a790ee1fcfdaab1c9ee0884694832bd81f512bb)
Volker Lendecke [Wed, 3 Jan 2007 06:53:13 +0000 (06:53 +0000)]
r20499: Activate RAW-OPEN in the build farm
(This used to be commit
a0d5de61a10321ee2edd832dcda611230d796dd6)
Volker Lendecke [Wed, 3 Jan 2007 06:39:18 +0000 (06:39 +0000)]
r20498: Two 64-bit warnings
(This used to be commit
382827ebac61646ec31fe1d56ccde2ea337e8f9e)
Volker Lendecke [Wed, 3 Jan 2007 06:19:11 +0000 (06:19 +0000)]
r20496: Some changes to make Samba3 the RAW-OPEN test. Checking in to both 3_0 and
3_0_24 because I was explicitly asked to, although this needs close
review. Jeremy, I'm sure you will check this thoroughly :-)
In reply_open_and_X the separate "size" variable kills the calculation of the
SPARSE flag returned to the client in the attrib field. In getpathinfo we do
it correctly, and RAW-OPEN (correctly) complains about the difference.
Add the "set the write time" to mknew and create.
For trans2open we were missing the "ofun == 0" ->
NT_STATUS_OBJECT_NAME_COLLISION case, and we dropped the status returned in
favor of ACCESS_DENIED once too many.
Last change is a fix to trans2open: We were returning the attributes given by
the client, not the attributes of the new file.
Volker
(This used to be commit
84e6889632c7f98a7cb37036b0acdf538d50d16c)
Gerald Carter [Tue, 2 Jan 2007 22:14:26 +0000 (22:14 +0000)]
r20489: Missed patch ofthe forest_name patch for lookupname
(This used to be commit
25c4ebb55f425816e033491138f1216125de6edb)
Gerald Carter [Tue, 2 Jan 2007 21:48:47 +0000 (21:48 +0000)]
r20488: When joined to a child domain in a multi-domain/single domain tree,
the child domain cannot always resolve SIDs in sibling domains.
Windows tries to contact a DC in its own domain and then the root
domain in the forest. This async changes makes winbindd's name2sid()
call do the same.
(This used to be commit
7b2bf0e5a6b8d4119657c7a34aa53c9a0c1d5723)
Gerald Carter [Tue, 2 Jan 2007 21:45:12 +0000 (21:45 +0000)]
r20487: Remove the unused dn2ad_canonical() call
(This used to be commit
86e6ae6a9fe2a6fdaeeb503653a312662c7f50e9)
Gerald Carter [Tue, 2 Jan 2007 21:29:09 +0000 (21:29 +0000)]
r20486: Always upper case the "host/<sAMAccoutnName>" entry in the keytab file
so apps will know which one to look for,
(This used to be commit
d4a5dc3ad5f56a5f741424ecc4fffa0ef39bdc67)
Gerald Carter [Tue, 2 Jan 2007 21:20:40 +0000 (21:20 +0000)]
r20485: Add select with a 10 second timeout when reading DSN update responses.
(This used to be commit
cb6c6a49e257d60318101c897e8d2b86de08a846)
Volker Lendecke [Tue, 2 Jan 2007 16:40:41 +0000 (16:40 +0000)]
r20482: Make us survive and activate RAW-CLOSE
(This used to be commit
471c6e6a2142afbca36163bcdbb5b6fb4e7ac774)
Volker Lendecke [Tue, 2 Jan 2007 15:07:27 +0000 (15:07 +0000)]
r20479: Both remaining calls of can_delete called it with check_is_at_open==False,
remove that parameter.
Volker
(This used to be commit
e51b7648703f3a85b840501dd4199600a5a7e44f)
Volker Lendecke [Tue, 2 Jan 2007 15:01:43 +0000 (15:01 +0000)]
r20478: Make us survive & activate RAW-UNLINK
(This used to be commit
4f0f917b344743e16e8bacf4e72529a2890590fe)
Volker Lendecke [Tue, 2 Jan 2007 12:10:46 +0000 (12:10 +0000)]
r20470: Jeremy, another one to check:
The only error path of can_delete() that we're interested in ntcreate&x is the
one of can_delete_file_in_directory(), so call that directly.
The only other one where we might get a NT_STATUS_ACCESS_DENIED is from the
lstat in can_delete, but this is covered later in the open_directory and
open_file_ntcreate calls. open_directory does a stat() in the open case which
also covers the (potential) symlink, and open_file_ntcreate does the open(2)
itself, so this should also work.
This makes can_delete() static to reply.c.
Volker
(This used to be commit
d289037fdbc8bd3e0723784888946d5b39ffadef)
Volker Lendecke [Tue, 2 Jan 2007 11:16:27 +0000 (11:16 +0000)]
r20465: Get rid of a redundant !NT_STATUS_IS_OK(status)
(This used to be commit
ff173995cfeac216ab26faef6553be8f7f439347)
Volker Lendecke [Mon, 1 Jan 2007 21:37:02 +0000 (21:37 +0000)]
r20454: Get rid of a bogus variable that was only assigned but never read.
Jeremy, please check this.
Thanks,
Volker
(This used to be commit
2becbb9e5f7d1b04962178e6f0c97c3ccf2b0f88)
Volker Lendecke [Mon, 1 Jan 2007 18:11:32 +0000 (18:11 +0000)]
r20451: Survive the first of the filter-tests (mkdir).
Add lots of TODOs :-)
Volker
(This used to be commit
0e953884a15873b0962ab1ab064d6b3a436726c0)
Stefan Metzmacher [Mon, 1 Jan 2007 17:29:20 +0000 (17:29 +0000)]
r20448: Happy New Year!
metze
(This used to be commit
3260d2116358fc64c40d2cbe8bffed4f3e387323)
Volker Lendecke [Sun, 31 Dec 2006 18:10:47 +0000 (18:10 +0000)]
r20443: Fix a compiler warning
(This used to be commit
19781d71fc5a8146109395cd53c04cf13cc48652)
Volker Lendecke [Sun, 31 Dec 2006 17:52:24 +0000 (17:52 +0000)]
r20442: Slight rewrite of the change notify infrastructure. This now survives the
first of the raw-notify subtests, the one-level test_notify_dir without any
flags around yet.
The tricky part was getting the data structures right, I hope the next tests
don't let that fall over.
fsp->notify is now by default NULL, meaning that nobody has issued a
changenotify call. This means nobody is interested in changes for this
directory.
If that has happened, notify_change_buf collects the changes if no current
request is outstanding, and it collects the requests if no change has happened
since the last request.
Happy New Year, somewhere on this planet it's already 2007 :-)
Volker
P.S: Jeremy, there's a question for you in smbd/files.c line 367.
(This used to be commit
ce0ad24988075465addcac0b9afc872e909135af)
Volker Lendecke [Sun, 31 Dec 2006 10:17:40 +0000 (10:17 +0000)]
r20434: Revert an accidential commit
(This used to be commit
fe122b07fa1712c15067ed385d4408206e9beef4)
Volker Lendecke [Sun, 31 Dec 2006 10:16:03 +0000 (10:16 +0000)]
r20433: Work in progress: Survive more of RAW-NOTIFY.
call_nt_transact_notify_change() is now sync if there are changes around.
A notify_message does a direct reply from within the message, so
process_pending_change_notify_queue is not needed anymore for samba-generated
events. Next step is to restructure the kernel-mechanisms to generate
messages.
Volker
(This used to be commit
c813f71d0036ec52c99a97e60fe33ee47d0635fa)
Volker Lendecke [Sun, 31 Dec 2006 10:08:52 +0000 (10:08 +0000)]
r20432: Apply some const
(This used to be commit
22163fee595251d4ea92279d88a1e8525188c620)
James Peach [Sun, 31 Dec 2006 06:53:11 +0000 (06:53 +0000)]
r20429: Restructure the libuuid API tests to handle the case where libuuid
is (effectively) in libc. Convert AC_LIBTESTFUNC to use the mystically
undocumented m4_ifval, which fixes some quoting problems when
providing shell code for the if-true and if-false branches.
(This used to be commit
5e1fbcc403c471ecaaa37e8cd54b719b65dd7495)
James Peach [Sun, 31 Dec 2006 06:50:44 +0000 (06:50 +0000)]
r20428: Rename dns_open. This conflicts with the dns_open symbol in
libSystem on Mac OS X.
(This used to be commit
2117904f18869fca0d4770883cf2de5fb00c4f85)
James Peach [Sun, 31 Dec 2006 06:45:24 +0000 (06:45 +0000)]
r20427: Rename dnp_open. This conflicts with the dns_open symbol in
libSystem on Mac OS X.
(This used to be commit
585ee7f31d2fb169e9dc37fd786faa8049be5e52)
Volker Lendecke [Sat, 30 Dec 2006 17:54:22 +0000 (17:54 +0000)]
r20424: No, we do not have to do that here :-)
(This used to be commit
49a463a97a4f800977ed3a657714e7f3b17bbf21)
Jeremy Allison [Sat, 30 Dec 2006 03:02:59 +0000 (03:02 +0000)]
r20412: Placeholder to remind me to write a torture test
for this error code.
Jeremy.
(This used to be commit
71b868611671a6c9275fce153794a0ccc150551f)
Jeremy Allison [Fri, 29 Dec 2006 20:39:53 +0000 (20:39 +0000)]
r20411: Fix originally from SATOH Fumiyasu (slightly
modified). Ensure "hide unXXX" parameters don't
hide MSDFS links. Bug #3319.
Jeremy.
(This used to be commit
e5466fffc286a99fafe0fcfbf70e903e33baa7f9)
Andrew Bartlett [Fri, 29 Dec 2006 09:18:06 +0000 (09:18 +0000)]
r20403: Cleaning out my Samba 3.0 tree:
As discussed with jerry at the CIFS conf: overriding the
administrator's wishes from the krb5.conf has only every given me
segfaults. We suggest leaving this up to the defaults from the
libraries anyway.
Andrew Bartlett
(This used to be commit
0b72c04906b1c25e80b217a8f34fd3a8e756b9ca)
Andrew Bartlett [Fri, 29 Dec 2006 08:25:51 +0000 (08:25 +0000)]
r20402: Fix spelling: samba bug #4292 debian #402392
(This used to be commit
e43aa4e03d8d2d3ffa3a0383b0b0835dd1a51cda)
Volker Lendecke [Thu, 28 Dec 2006 21:50:31 +0000 (21:50 +0000)]
r20394: This is a *VERY* early start of my work on notify.
Checking in because Jeremy was bugging me. Potentially this becomes quite
intrusive, I'm not sure if I should open a temporary branch for this.
Jeremy, Jerry, do you think 3_0 is the right place for this?
Volker
(This used to be commit
bcf5c751cbe203c00814642e26440cf88f300bce)
Volker Lendecke [Thu, 28 Dec 2006 21:34:31 +0000 (21:34 +0000)]
r20393: Debug level 1 is a bit excessive here
(This used to be commit
48798b5e57fcb2ee7debfe9d5178adef37907f92)
Stefan Metzmacher [Thu, 28 Dec 2006 19:04:32 +0000 (19:04 +0000)]
r20389: this needs to be after AC_LIBREPLACE_BROKEN_CHECKS :-)
metze
(This used to be commit
e5333d5628a585ff00b78d50a0a22b0cf98aa9ff)
Stefan Metzmacher [Thu, 28 Dec 2006 18:57:21 +0000 (18:57 +0000)]
r20388: add the library that contains dlopen to the global LIBS as it was before
metze
(This used to be commit
b2feeee7485f0a1006b38e5abee05c2583923242)
Stefan Metzmacher [Thu, 28 Dec 2006 18:09:32 +0000 (18:09 +0000)]
r20386: remove unneeded dlopen related configure checks and includes
this is done by libreplace...
this hopefully fixes the build on HPUX 11.00
metze
(This used to be commit
eed50e104794d855b204cfea52626f47b6fa3f52)
Stefan Metzmacher [Thu, 28 Dec 2006 17:17:16 +0000 (17:17 +0000)]
r20385: merge from samba4:
only try to find dlfcn.h if the dlopen symbol was found,
it hopefully fixes systems where dlfcn.h but no library with dlopen
metze
(This used to be commit
b303e929d1ac6f1d931d0b92bdecdf292e1598cd)
Jeremy Allison [Thu, 28 Dec 2006 00:24:34 +0000 (00:24 +0000)]
r20372: Make NTrename the same as SMBmv w.r.t. wildcards.
Jeremy.
(This used to be commit
b8d5faac69f3a0c2620a34f9026b4018ebd48bb8)
Jeremy Allison [Thu, 28 Dec 2006 00:10:55 +0000 (00:10 +0000)]
r20371: In renames (via SMBmv) both src and dest can contain
wcards. I had forgotten this and had refused to allow
dest to contain wcards. We now pass all the normal
Samba4 smbtorture RAW-RENAME tests.
Jeremy
(This used to be commit
4183c1b49fd5a6107aa87249b7be236af092ed8b)
Jeremy Allison [Thu, 28 Dec 2006 00:01:12 +0000 (00:01 +0000)]
r20370: Now we've gone to the trouble of getting an NT status
from open_file_ntcreate make sure we return it on rename
error.
Jeremy.
(This used to be commit
633f02fb860223585f388e64c1a2d770db52d4f0)
Jeremy Allison [Wed, 27 Dec 2006 23:52:47 +0000 (23:52 +0000)]
r20368: Fix valgrind report of uninitialized memory
being returned (false positive). Up debug
level on "open_directory" message.
Jeremy.
(This used to be commit
71a8b8863f8bdcce082c5971d6489a2da3ff4b2c)
Jeremy Allison [Wed, 27 Dec 2006 20:45:12 +0000 (20:45 +0000)]
r20363: Fix any possible valgrind errors in srvstr_get_XX or srvstr_pull_XX
by ensuring we pass in a valid src_len (or zero when appropriate).
Volker is correct in that this is a *horrible* interface and he is
now free to generally clean it up everywhere :-). Go for it Volker !
Jeremy.
(This used to be commit
cd991fb839994dd29dc790b655f5597fa1e12843)
Jeremy Allison [Wed, 27 Dec 2006 18:51:09 +0000 (18:51 +0000)]
r20362: Fix valgrind issues where we may read params
before checking length. Found by Volker.
Jeremy.
(This used to be commit
683c5fce6896236a60145f6d3970566503c39163)
Jeremy Allison [Wed, 27 Dec 2006 18:36:00 +0000 (18:36 +0000)]
r20361: Prevent strnlen_w reading beyond max. Valgrind
found by Volker.
Jeremy
(This used to be commit
08d551163c9563bd02acd437bc1a1595e7939cee)
Volker Lendecke [Wed, 27 Dec 2006 10:57:59 +0000 (10:57 +0000)]
r20356: Consolidate the calls to parent_dirname() per open to one.
This involved passing the dirname as argument to a few routines instead of
calling parent_dirname() deep down.
Volker
(This used to be commit
7977fd78652897bb7d4db1c21c5749043428f911)
Volker Lendecke [Wed, 27 Dec 2006 10:26:32 +0000 (10:26 +0000)]
r20355: Fix some C++ warnings
(This used to be commit
f103c301b18f2eeb5203634cb6b50fa79f57a93b)
Volker Lendecke [Sun, 24 Dec 2006 17:09:08 +0000 (17:09 +0000)]
r20345: Simplify call_nt_transact_create by using tmp_talloc_ctx()
(This used to be commit
df6362baa0928616c6934950fb9c1264cb27106e)
Volker Lendecke [Sun, 24 Dec 2006 16:37:22 +0000 (16:37 +0000)]
r20344: Move the calls to inherit_access_acls and change_owner_to_parent together.
Jeremy, I'm 100% sure you watch me closely here, I count on you :-)
Volker
(This used to be commit
02f85265f21607c950639da33bc8fe5d5ffd3cf9)
Volker Lendecke [Sun, 24 Dec 2006 15:29:09 +0000 (15:29 +0000)]
r20343: Split change_owner_to_parent fd-based (for file opens) and a name-based (for
directory opens) routines.
Volker
(This used to be commit
4ca921d9aa90bc68d21d40ccf4b1ca0b1d2cbcb1)
Volker Lendecke [Sun, 24 Dec 2006 15:11:03 +0000 (15:11 +0000)]
r20342: Move the lstat into mkdir_internal, for the FILE_OPEN case in open_directory
we want to follow symlinks.
Volker
(This used to be commit
c20bdd219d16abcc60d67f4a21b4fcd661473835)
Volker Lendecke [Sun, 24 Dec 2006 14:29:19 +0000 (14:29 +0000)]
r20340: Join vfs_MkDir to its only caller
(This used to be commit
cce911780fc52ea56dccde1879b0891cdf9ea320)
Volker Lendecke [Sun, 24 Dec 2006 11:45:55 +0000 (11:45 +0000)]
r20339: Make mkdir_internal static to open.c
(This used to be commit
6dd0886b49969d0edfe16861f19d35275217b2af)
Volker Lendecke [Sun, 24 Dec 2006 11:13:32 +0000 (11:13 +0000)]
r20338: Restructure open_directory a bit. This gets rid of a race condition regarding
error messages: We relied upon a stat that a directory did not exist to later
on then do the mkdir or not. This does the mkdir directly and copes with a
potential error.
The second one is more important: It's possible with Samba 3 to do a
ntcreate&x with NTCREATEX_OPTIONS_DIRECTORY and we happily do a NT_STATUS_OK.
Also move up the use_nt_status() logic a bit. I think this does not belong
into the core routines, the smb server as such should take care of it.
Jeremy, do you think this should go to 3.0.24?
I'll update samba4torture when the build farm has picked up this checkin.
Volker
(This used to be commit
472fb11f4968d30cedc9851215c63acd3132f3db)
Volker Lendecke [Sat, 23 Dec 2006 19:35:36 +0000 (19:35 +0000)]
r20336: Fix some memleaks in trans2open and simplify trans2mkdir a bit: We now have
tmp_talloc_ctx().
Volker
(This used to be commit
165d28f03a82a1a07d0f86c0d5de4a785ea5c7f0)
Volker Lendecke [Sat, 23 Dec 2006 18:55:08 +0000 (18:55 +0000)]
r20335: Port oplock return logic from ntcreate&x to NT_TRANSACT_CREATE. Fixes parts of
raw-open.
Volker
(This used to be commit
e4e766c092e19f78a593c08f22ea1d7521be18e7)
Volker Lendecke [Sat, 23 Dec 2006 18:01:34 +0000 (18:01 +0000)]
r20334: Activate RAW-MKDIR
(This used to be commit
8f76914e01f73149f549ebd6d8f9e549772dbb84)
Volker Lendecke [Sat, 23 Dec 2006 16:47:50 +0000 (16:47 +0000)]
r20333: Fix a couple of Coverity errors in one run, this was a potential NULL dereference
(This used to be commit
f9edfffeb5aa1fe0700c17cd1c8141c906080188)
Jeremy Allison [Sat, 23 Dec 2006 02:26:18 +0000 (02:26 +0000)]
r20330: And here's the fix for the parent winbindd crashing
after it's child died unexpectedly whilst the parent
was waiting for a reply. We need to clean up the request
we're not going to service, plus we still need to call
the continuation function with a "False" flag so it
can clean things up. Still testing this, but I think
I'm right.
Jeremy
(This used to be commit
9b04ac0c8104d626697978697d4d8bae791a7edd)
Jeremy Allison [Sat, 23 Dec 2006 00:17:15 +0000 (00:17 +0000)]
r20329: Fix a winbindd crash bug. If someone pulls
the network cable out of the machine *exactly*
after the init_dc_connect() call in cm_connect_sam()
or cm_connect_lsa() call succeeded but before any
of the other calls fail, and they have debug level
10 set in the log, then we'd crash due to dereferencing
a now NULL pointer (conn->cli gets set to NULL when
the init_dc_connect() call called from cm_get_schannel_dcinfo()
fails). Yes, before you ask this *did* happen on a
customer site :-).
Jeremy.
(This used to be commit
a0278a0cb062500ba97e237d02f55855b68719ec)
Volker Lendecke [Thu, 21 Dec 2006 22:35:10 +0000 (22:35 +0000)]
r20313: Make trans2_mkdir also go through open_directory for all the fancy inherit_acl
stuff & friends.
Survives raw-mkdir. I'll activate that tomorrow when all build farm machines
have picked up the changed samba4 torture test.
Volker
(This used to be commit
37e7a3f35f48f5689591c75d41d32c43d3b9b853)
Volker Lendecke [Thu, 21 Dec 2006 22:30:21 +0000 (22:30 +0000)]
r20312: Fix a memleak
(This used to be commit
20d3bc3549ef89a6405e186b87b50027d2321ac0)
Volker Lendecke [Thu, 21 Dec 2006 21:30:11 +0000 (21:30 +0000)]
r20310: We've checked for EA's and support for them further up already.
Volker
(This used to be commit
9c00ce0bbc809903b5516ef9ea62db13233ea2d4)
Günther Deschner [Thu, 21 Dec 2006 13:31:23 +0000 (13:31 +0000)]
r20304: Smaller fixes for pam_winbind:
* fail on invalid credential flags in pam_sm_setcred
* parse config file for pam_sm_acct_mgmt and pam_sm_open_session
Guenther
(This used to be commit
2a428ac814d03880de63656ea97827126ccfec5c)
Jeremy Allison [Thu, 21 Dec 2006 00:43:21 +0000 (00:43 +0000)]
r20296: If we're going to overwrite krb5.conf
only do it for our primary domain.
Jeremy.
(This used to be commit
61d31ce0089fe906d052c971321ce99fede0e240)
Simo Sorce [Wed, 20 Dec 2006 19:05:07 +0000 (19:05 +0000)]
r20290: Remove unused call
(This used to be commit
4920265c31e073cbc0fdbfbe42dc8e47dbadca54)
Simo Sorce [Wed, 20 Dec 2006 17:56:26 +0000 (17:56 +0000)]
r20289: IDMAP is part of winbind but not the main process.
Make sure we route all request to remote DCs via the main process
so that IDMAP can correctly reuse DC connections and use the
async interface.
This fixes also idmap_nss so that it is able to resolve local
group names (requires patch on the samba dc earlier committed
to SAMBA_3_0 to make it resolve both the mapped and the unmapped
name).
Simo.
(This used to be commit
4297510f22c3fd60afd062e3c5eb142be2122b16)
Gerald Carter [Wed, 20 Dec 2006 16:57:10 +0000 (16:57 +0000)]
r20287: Allow a NULL sid when setting up the list of trusted domains.
(This used to be commit
ccea7155bc8c22816f2622e604e0ef76109487f1)
Günther Deschner [Wed, 20 Dec 2006 14:23:41 +0000 (14:23 +0000)]
r20279: Fix winbind segfault in winbindd_getsidaliases.
Jeremy: sidstr formerly could be NULL (when num_aliases was 0), since we
strdup here it needs to exist.
Guenther
(This used to be commit
29396a1bd8ebd6d951f35941b13c9c61593ae6d3)
Günther Deschner [Wed, 20 Dec 2006 10:54:09 +0000 (10:54 +0000)]
r20273: Map KRB5_KDCREP_SKEW to NT_STATUS_TIME_DIFFERENCE_AT_DC.
This gives much nicer error messages when failing to join due to clock
skew.
Guenther
(This used to be commit
5c5a7611029ff1b630c53d4660578e188acf97f5)
Volker Lendecke [Wed, 20 Dec 2006 07:38:58 +0000 (07:38 +0000)]
r20271: Fix the build
(This used to be commit
c703d2ae1f891d35115bb6da0399387a9db2d917)
Jeremy Allison [Wed, 20 Dec 2006 04:50:46 +0000 (04:50 +0000)]
r20270: Even with the dual daemon mode the parent winbindd
still needs to contact the DC's for non async requests
like enumerate users/groups etc. Now that online
DC detection is tied to async events we must enable
the processing of events in the main loop of winbindd.
Finally got rid of the last hard coded domain->initialized = 1
code in init_child_recv() - now all domain->initialized = True
gets done only in the connection manager code when either
we're online and have spoken to the DC or are offline and
we know we can't talk to the DC.
Jeremy.
(This used to be commit
b3c98057fbad182f6c05c5daec6cd258dd491064)
Herb Lewis [Wed, 20 Dec 2006 01:10:04 +0000 (01:10 +0000)]
r20269: merge -r20264:20267 from SAMBA_3_0_24
more no previous prototype warnings
(This used to be commit
41be182f78762372ae13759ede5d2bd40a71d7f5)
Herb Lewis [Wed, 20 Dec 2006 01:07:21 +0000 (01:07 +0000)]
r20268: merge -r 20261:20263 from samba_3_0_24
get rid of previous prototype warnings
(This used to be commit
90265c83ff1c7f11672694ff005d8ecc5d4a867f)
Volker Lendecke [Tue, 19 Dec 2006 22:13:10 +0000 (22:13 +0000)]
r20264: Two lines above this we just checked if (fsp->is_directory) ...
(This used to be commit
88ab54b3b7ec6c0ac1958fca435880e29eeefd69)
Herb Lewis [Tue, 19 Dec 2006 20:16:52 +0000 (20:16 +0000)]
r20261: merge 20260 from samba_3_0_24
clean up a bunch of no previous prototype warnings
(This used to be commit
c60687db112405262adf26dbf267804b04074e67)
Volker Lendecke [Tue, 19 Dec 2006 18:08:51 +0000 (18:08 +0000)]
r20257: Hey, change_owner_to_parent is now static :-)
(This used to be commit
4090bc4bca77edafcafa52ecb7dc75ead2779cb5)
Volker Lendecke [Tue, 19 Dec 2006 18:02:24 +0000 (18:02 +0000)]
r20255: Activate BASE-SAMBA3ERROR in the build farm
(This used to be commit
7e0005c14b6852be756dbdacd1412077f2cf57f5)
Günther Deschner [Tue, 19 Dec 2006 17:35:47 +0000 (17:35 +0000)]
r20254: The pam_chauthtok needs to go through the async interface as well.
This fixes pam password changes in the online case.
Guenther
(This used to be commit
2d2de1ac27180756df095c586211fe2e7694b94e)
Volker Lendecke [Tue, 19 Dec 2006 16:36:54 +0000 (16:36 +0000)]
r20253: Reduce some code duplication, make reply_mkdir go through the same code paths
ncreate does. This is a bit slower (about 10-20%), because it goes touches the
share mode db, but I think not having to call change_owner_to_parent and
friends in fewer places outweighs this. And, mkdir is not the way current
Windows boxes create directories, they do it via the ncreate call.
Volker
(This used to be commit
ddae494fbe36e4a74776f71c212b00cce61fbf81)
Simo Sorce [Tue, 19 Dec 2006 14:01:05 +0000 (14:01 +0000)]
r20252: Revert back to const, but I have a fleble feeling we should go the ther way.
(This used to be commit
2048d491507cef1ac87da4fd2fedc458aae5a97d)
Jeremy Allison [Tue, 19 Dec 2006 00:48:39 +0000 (00:48 +0000)]
r20250: If we've come from being globally offline we
don't have a check online event handler set.
We need to add one once we're been asked to
go back online as this is the only way to actually
go into the online state. Doh ! :-).
Jeremy.
(This used to be commit
5d36c4e0313c2d735242dfdd57343372be59c6e1)
Günther Deschner [Mon, 18 Dec 2006 22:10:09 +0000 (22:10 +0000)]
r20249: Fail when parsing invalid options in _pam_parse.
Guenther
(This used to be commit
f6c9421abdf5731e894cd2ccc1b7431a3c368bbf)
Herb Lewis [Mon, 18 Dec 2006 22:01:39 +0000 (22:01 +0000)]
r20248: merge 20247 from samba_3_0_24
get rid of warning: value computed is not used
(This used to be commit
ebe16589cb6c45524b90abe5f9be5e4affa1598e)
Herb Lewis [Mon, 18 Dec 2006 20:37:26 +0000 (20:37 +0000)]
r20245: merge 20244 from samba_3_0_24
get rid of more nested extern declarations warnings
(This used to be commit
e9df051f5201843e3428ddbed7a719553c2e799a)
Simo Sorce [Mon, 18 Dec 2006 20:05:50 +0000 (20:05 +0000)]
r20243: Make lookup_name resolve both the mapped and the real unix group name
(This used to be commit
7167e7b26ac6a742cc82f4edacfc8579f80338d9)