Jeremy Allison [Wed, 29 Dec 2010 02:11:33 +0000 (18:11 -0800)]
Fix bug #7892 - open_file_fchmod() leaves a stale lock.
Volker Lendecke [Tue, 21 Dec 2010 20:55:01 +0000 (21:55 +0100)]
s3: Use smbsock_any_connect in winbind
The last 8 patches address bug #7881 (winbind flaky against w2k8).
Volker Lendecke [Tue, 21 Dec 2010 17:52:53 +0000 (18:52 +0100)]
s3: Retry *SMBSERVER in nb_connect
Volker Lendecke [Mon, 13 Dec 2010 16:17:51 +0000 (17:17 +0100)]
s3: Add smbsock_any_connect
Volker Lendecke [Sun, 12 Dec 2010 17:55:06 +0000 (18:55 +0100)]
s3: Add an async smbsock_connect
This connects to 445 and after 5 milliseconds also to 139. It treats a netbios
session setup failure as equivalent as a TCP connect failure. So if 139 is
faster but fails the nb session setup, the 445 still has the chance to succeed.
Volker Lendecke [Wed, 22 Dec 2010 14:21:27 +0000 (15:21 +0100)]
v3-4-test: Pull in tevent_req_poll_ntstatus from master
Volker Lendecke [Sun, 12 Dec 2010 17:54:31 +0000 (18:54 +0100)]
s3: Add async cli_session_request
This does not do the redirects, but I think that might be obsolete anyway
Volker Lendecke [Wed, 22 Dec 2010 14:15:47 +0000 (15:15 +0100)]
v3-4-test: Pull in read_smb_send from master
Volker Lendecke [Sun, 12 Dec 2010 17:53:49 +0000 (18:53 +0100)]
s3: Add some const to name_mangle()
Volker Lendecke [Wed, 17 Nov 2010 15:56:28 +0000 (08:56 -0700)]
s3: Make winbind recover from a signing error
When winbind sees a signing error on the smb connection to a DC (for whatever
reason, our bug, network glitch, etc) it should recover properly. The "old"
code in clientgen.c just closed the socket in this case. This is the right
thing to do, this connection is spoiled anyway. The new, async code did not do
this so far, which led to the code in winbindd_cm.c not detect that we need to
reconnect.
Fix bug #7800 (winbind does not recover from smb signing errors).
Volker Lendecke [Sat, 2 Oct 2010 15:07:00 +0000 (17:07 +0200)]
s3: Stop using the write cache after an oplock break
Fix bug #7715 (Setting Samba Write Cache Size Can Cause File Corruption).
(cherry picked from commit
9f8292e5f765dff586bfbb261b54da4d4b27a837)
Karolin Seeger [Wed, 15 Sep 2010 18:55:30 +0000 (20:55 +0200)]
WHATSNEW: Prepare 3.4.9 release notes.
Karolin
Jeremy Allison [Thu, 9 Sep 2010 13:48:23 +0000 (15:48 +0200)]
Fix bug #7669.
Fix bug #7669 (buffer overflow in sid_parse() in Samba3 and dom_sid_parse in
Samba4).
CVE-2010-3069:
===========
Description
===========
All current released versions of Samba are vulnerable to
a buffer overrun vulnerability. The sid_parse() function
(and related dom_sid_parse() function in the source4 code)
do not correctly check their input lengths when reading a
binary representation of a Windows SID (Security ID). This
allows a malicious client to send a sid that can overflow
the stack variable that is being used to store the SID in the
Samba smbd server.
A connection to a file share is needed to exploit this
vulnerability, either authenticated or unauthenticated
(guest connection).
(cherry picked from commit
df20a300758bc12286820e31fcf573bdfc2147bc)
Jeremy Allison [Mon, 23 Aug 2010 23:30:53 +0000 (16:30 -0700)]
Fix bug 7636 - winbind internal error, backtrace.
Jeremy.
Jim McDonough [Mon, 23 Aug 2010 09:14:47 +0000 (11:14 +0200)]
s3-printing: fix BUG 7280 - auto printers not loading with registry config
Jeremy Allison [Tue, 27 Jul 2010 08:54:01 +0000 (01:54 -0700)]
Fix bug 7590 - offline login fails because winbind deletes cache on every startup.
Sync lib/tdb_validate.c with the change in current master.
Change tdb_validate_open() to always use O_RDWR instead of O_RDONLY,
as (from the bug report): "db_check() will always return failure for a read-only database.
Silently, without any log output, when _tdb_lockall() fails."
Jeremy.
(cherry picked from commit
39cb903463d8a3fcabd9e148112bf5cf81744130)
Stefan Metzmacher [Mon, 9 Aug 2010 09:26:03 +0000 (11:26 +0200)]
rerun: make samba3-idl
metze
Stefan Metzmacher [Mon, 9 Aug 2010 09:14:52 +0000 (11:14 +0200)]
pidl: Samba3/ClientNDR - Correctly copy arrays, if r.out.size < r.in.size.
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
(similar to commit
33d1879d5b50e2d98c1bb13b835e7cfb178e3336)
(similar to commit
d1e92cd2944983ecabd0511ff7c8221c1033a3a8)
Fixes bug #7607.
Jeremy Allison [Thu, 12 Aug 2010 21:24:01 +0000 (14:24 -0700)]
Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code.
In the file rpc_server.c, function _winreg_QueryValue()
uint8_t *outbuf
Should be :
uint8_t *outbuf = NULL;
As it is later freed by
if (free_buf) SAFE_FREE(outbuf);
in some cases, this frees the unintialized outbuf, which causes a coredump.
(cherry picked from commit
84fd910c347ddfad6f01edbe7f6e25546c8382ee)
(cherry picked from commit
80e65236158d6f1690bf9f153c0eb12d81d56b8a)
Günther Deschner [Mon, 9 Aug 2010 12:31:24 +0000 (14:31 +0200)]
s3-winbind: Fix Bug #7568: Make sure cm_connect_lsa_tcp does not reset the secure channel.
This is an important fix as the following could and is happening:
* winbind authenticates a user via schannel secured netlogon samlogonex call,
current secure channel cred state is stored in winbind state, winbind
sucessfully decrypts session key from the info3
* winbind sets up a new schannel ncacn_ip_tcp lsa pipe (and thereby resets the
secure channel on the dc)
* subsequent samlogonex calls use the new secure channel creds on the dc to
encrypt info3 session key, while winbind tries to use old schannel creds for
decryption
Guenther
(cherry picked from commit
be396411a4e1f3a174f8a44b6c062d834135e70a)
Jeremy Allison [Tue, 27 Jul 2010 06:47:14 +0000 (08:47 +0200)]
s3-libsmb: Fix bug #7577.
SPNEGO auth fails when contacting Win7 system using Microsoft Live Sign-in
Assistant.
Andrew Tridgell [Thu, 10 Dec 2009 00:22:20 +0000 (11:22 +1100)]
librpc: split out a separate GUID_from_ndr_blob() function
This will simplify many of the places that deal with NDR formatted
GUIDs
(cherry picked from commit
effff544265c63c95cf630d426b630bfe4d25aec)
This patch is part of a fix for bug #7538 (Backport fixes for
GUID_from_data_blob).
(cherry picked from commit
e8ed2b596627e8704e3384d5997020059b47144a)
Volker Lendecke [Sun, 4 Jul 2010 08:01:42 +0000 (10:01 +0200)]
s3: Fix bug 7336: Enable idmap_passdb module build as shared
(cherry picked from commit
8c0fbc410798512b7a4b7db73bcb24cde6fa7849)
(cherry picked from commit
b4803af11525823ea508d0ca4e58402d55901194)
Andreas Schneider [Mon, 28 Jun 2010 19:00:30 +0000 (21:00 +0200)]
s3-librpc: Fixed GUID_from_data_blob() with length of 32.
If we hit the case that the blob length is 32. The code goes to the end
of the function and generates a GUID with garbage.
So try to convert the blob to the GUID and return.
Fix bug #7538 (Backport fixes for GUID_from_data_blob).
(cherry picked from commit
3c4353d2aa15db278bb87c949cce2deb3a5072ca)
Günther Deschner [Thu, 1 Jul 2010 11:58:56 +0000 (13:58 +0200)]
s3-printing: Fix Bug #7541, %D in "printer admin" causing smbd crash.
Guenther
Karolin Seeger [Mon, 21 Jun 2010 08:30:25 +0000 (10:30 +0200)]
s3-docs: Add missing whitespace.
Karolin
(cherry picked from commit
2352538362977e456e8d05783f2732ff650cea41)
(cherry picked from commit
9d9a9a0f79ad6fa894f72a4678f59fb40c9fce94)
(cherry picked from commit
fb5b75d26b882c48ac073b6425dfce15873c243e)
Günther Deschner [Wed, 16 Jun 2010 15:08:36 +0000 (17:08 +0200)]
s3-docs: Fix some of ntlm_auth ntlm-server-1 protocol documentation.
Guenther
(cherry picked from commit
cfb67b1a169350a8316532eb5d53de4a3f2bacb3)
(cherry picked from commit
b3ccbcb83650cea627ad97e920d3f73659ffa6a0)
Volker Lendecke [Thu, 10 Jun 2010 13:40:14 +0000 (15:40 +0200)]
s3: Fix EnumDomainAliases when no aliases are in LDAP
We used to return NT_STATUS_ACCESS_DENIED, now we just return 0 entries, just
like W2k8 does.
usrmgr.exe was pretty unhappy with the NT_STATUS_ACCESS_DENIED
(cherry picked from commit
f66cc827096c53d4d16b8c850c83a3b5664e9725)
Fix bug #7262 (Unable to maintain users' groups via UsrMgr).
(cherry picked from commit
1439a1d7ff406dd5dce885100349751151c14bf6)
Michael Adam [Thu, 10 Jun 2010 09:56:15 +0000 (11:56 +0200)]
s3:pdb_ldap: fix bug 7507 - init_sam_from_ldap stores group in sid2uid cache
(cherry picked from commit
ba809ecb8ab217e4376bf75d2300e146b62b88eb)
(cherry picked from commit
cc740fb5eb56a0875703753d4a116d2fe33ec186)
Günther Deschner [Tue, 8 Jun 2010 09:25:00 +0000 (11:25 +0200)]
s3-netdomjoin-gui: Fix Bug #7500. Fix 'not a string literal' warning in netdomjoin-gui.
Patch from Buchan Milne <bgmilne@mandriva.org>.
Thanks!
Guenther
(cherry picked from commit
575b1018c65312e9eab562cf4851524cf2f8f24a)
(cherry picked from commit
1419c154d67b8ffaf0d6e2e3ba103121ab3736f5)
Günther Deschner [Fri, 14 May 2010 22:34:35 +0000 (00:34 +0200)]
s3-kerberos: temporary fix for ipv6 in print_kdc_line().
Currently no krb5 lib supports "kdc = ipv6 address" at all, so for now just fill
in just the kdc_name if we have it and let the krb5 lib figure out the
appropriate ipv6 address
ipv6 gurus, please check.
Guenther
(cherry picked from commit
dd5a4e23f8c24564d3fd21bb8d01172321087362)
The last 3 patches fix bug #7341 (winbind not working over IPv6).
Günther Deschner [Fri, 14 May 2010 21:23:34 +0000 (23:23 +0200)]
s3-kerberos: pass down kdc_name to create_local_private_krb5_conf_for_domain().
Guenther
(cherry picked from commit
e3bdff3d67b46277ee59685218bd90f3788b487d)
Günther Deschner [Fri, 14 May 2010 21:21:47 +0000 (23:21 +0200)]
s3-winbind: make the getpeername() checks in cm_prepare_connection IPv6 aware.
Note that this failure was hard to track, as winbind did only log a super helpful
"cm_prepare_connection: Success" debug message.
IPv6 gurus, please check
Successfully tested in two independent IPv6 networks now.
Guenther
(cherry picked from commit
14ac2bb36ee22be6133ca1d069dc5de6c1891f47)
Andreas Schneider [Wed, 12 May 2010 16:36:30 +0000 (18:36 +0200)]
s3-spoolss: Added EN ISO 216, A0 and A1 to builtin forms.
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
0953087f82ddbd580e9807e0e8d780e78686c03c)
Fix bug #7423 (Large Formats at printing not available).
Karolin Seeger [Wed, 12 May 2010 09:24:57 +0000 (11:24 +0200)]
s3-docs: Move -D option to the right paragraph in man winbindd.
Fix bug #7260 (Command line option documentation in wrong place in winbindd man
page.). Thanks to Ged Haywood <samba@jubileegroup.co.uk> for reporting!
Karolin
(cherry picked from commit
da5c49d727150eea7d2a4b83da1a02ac1f26e77c)
(cherry picked from commit
b737434fbf60c250166f10cf196af8030b388bdb)
Olaf Flebbe [Tue, 11 May 2010 09:30:04 +0000 (11:30 +0200)]
work around AIX6.1 name space pollution rename mod_name to module_name
Fix bug #7421 (samba 3.4.7 does not compile on AIX 6.1).
Günther Deschner [Thu, 18 Feb 2010 11:40:00 +0000 (12:40 +0100)]
s3-spoolss: Fix _spoolss_EnumPrinters servername handling.
Guenther
(cherry picked from commit
b3c2b2260a503079b9abf22f6b35b56c61c2b372)
The last two patches address bug #7418 ("net rpc printer list" command is
inoperative).
(cherry picked from commit
df5f448fe371a1227a507cedc2642fa1a4b77e65)
Günther Deschner [Thu, 18 Feb 2010 01:03:53 +0000 (02:03 +0100)]
s3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer!
Guenther
(cherry picked from commit
8ce66fba03f782c0b9948a9835bb488cfa74acf9)
(cherry picked from commit
cb6fcb9b16b36fcdc68bef382dbd7ecf89521d4e)
Günther Deschner [Sat, 8 May 2010 00:16:37 +0000 (02:16 +0200)]
s3-net: Fix Bug #7417. 'net rpc user password' can set the wrong password.
Guenther
(cherry picked from commit
7887d99a60387e93ce5ce4a3bfe9117939d1e4c8)
Karolin Seeger [Tue, 11 May 2010 12:40:39 +0000 (14:40 +0200)]
WHATSNEW: Start release notes for Samba 3.4.9.
Karolin
Karolin Seeger [Tue, 11 May 2010 12:38:38 +0000 (14:38 +0200)]
VERSION: Bump version up to 3.4.9.
Karolin
Karolin Seeger [Mon, 10 May 2010 12:55:44 +0000 (14:55 +0200)]
WHATSNEW: Update changes since 3.4.7.
Karolin
Günther Deschner [Wed, 16 Dec 2009 09:33:13 +0000 (10:33 +0100)]
s3-spoolss: fix rpcclient after setprinter IDL fixes.
Guenther
(cherry picked from commit
31cf2b086a9275955b0480b4b9035dc12671761d)
Günther Deschner [Wed, 16 Dec 2009 09:32:35 +0000 (10:32 +0100)]
spoolss: more mork on SetPrinterInfo() levels.
Guenther
(cherry picked from commit
be95cb6f8357334af08d1502910a429328b85bc5)
Günther Deschner [Mon, 3 May 2010 13:54:14 +0000 (15:54 +0200)]
s3-rpcclient: Fix Bug #7277. rpcclient was sending invalid data, causing cupsaddsmb to fail.
Guenther
(cherry picked from commit
9cc10e6a5742f09261f01a2c0b3a94b7b772e573)
Jim McDonough [Wed, 21 Apr 2010 18:53:51 +0000 (20:53 +0200)]
s3-net_conf: Display an error on net conf import failures.
When something goes wrong, such as a typo in a parameter
name, we'll now display the failure instead of just returning
with -1 and no message.
Fix bug #7378 ("net conf import" fails silently on parameter typo).
Derrell Lipman [Tue, 13 Apr 2010 18:32:14 +0000 (20:32 +0200)]
s3-libsmbclient: Fix incomplete description of function return values in libsmbclient.h.
Fix bug #7345.
(cherry picked from commit
ce565b0498608714e2c4f7c9f9373dddcbfba568)
Stefan Metzmacher [Thu, 1 Apr 2010 07:29:38 +0000 (09:29 +0200)]
s3:winbindd: make sure we don't try rpc requests against unaccessable domains
This makes sure we don't crash while trying to dereference domain->conn.cli->foo
while trying to establish a rpc connection to the server.
This fixes bug #7316.
metze
(cherry picked from commit
d930904b997d310aeff781bde1e7e3ce47dde8a1)
(cherry picked from commit
01b60b113869f526dcf3bb478d70df21dbb207c8)
Karolin Seeger [Fri, 16 Apr 2010 07:23:30 +0000 (09:23 +0200)]
s3-docs: Improve "winbind nss info" section in man smb.conf.
Karolin
(cherry picked from commit
20fc769179377bf037f4d5efe1afbaf77d4c9292)
(cherry picked from commit
fb1b0901ec93afe998145bb7a7549bbdb13c712c)
Jeremy Allison [Fri, 26 Mar 2010 01:22:16 +0000 (18:22 -0700)]
Fix bug #7288 - SMB job IDs in CUPS job names wrong.
Based on a patch from Michael Karcher <samba@mkarcher.dialup.fu-berlin.de>.
I think this is the correct fix. It causes cups_job_submit to use
print_parse_jobid(), which I've moved into printing/lpq_parse.c (to allow the
link to work).
It turns out the old print_parse_jobid() was *broken*, in that the pjob
filename was set as an absolute path - not relative to the sharename (due to it
not going through the VFS calls).
This meant that the original code doing a strncmp on the first part of the
filename would always fail - it starts with a "/", not the relative pathname of
PRINT_SPOOL_PREFIX ("smbprn.").
This fix could fix some other mysterious printing bugs - probably the ones
Guenther noticed where job control fails on non-cups backends.
Contains
c79ca41baf15b4ef7eb287d343b17a53ba41e852 and
92332fb2368c641db1552d1f2a2f7b3deaa11519 from master.
Jeremy.
(cherry picked from commit
12936bfeb36ae867b52fe48d0f6d3d17d5c8b110)
Volker Lendecke [Tue, 13 Apr 2010 10:09:21 +0000 (12:09 +0200)]
libwbclient: Re-Fix a bug that was fixed with
e5741e27c4c
> r21878: Fix a bug with smbd serving a windows terminal server: If winbind
> decides smbd to be idle it might happen that smbd needs to do a winbind
> operation (for example sid2name) as non-root. This then fails to get the
> privileged pipe. When later on on the same connection another authentication
> request comes in, we try to do the CRAP auth via the non-privileged pipe.
>
> This adds a winbindd_priv_request_response() request that kills the existing
> winbind pipe connection if it's not privileged.
The fix for this was lost during the conversion to libwbclient.
Thanks to Ira Cooper <samba@ira.wakeful.net> for pointing this out!
Volker
Stefan Metzmacher [Thu, 8 Apr 2010 10:45:54 +0000 (12:45 +0200)]
s3:winbindd: make "smbcontrol winbindd validate-cache" reliable again
commit
73577205cf81644e7fe853eaf3e6459f7f443096
(s3:winbindd: fix problems with SIGCHLD handling (bug #7317))
broke this.
metze
(cherry picked from commit
eb9b7d0363669574de8ec380089407890f15eac2)
Stefan Metzmacher [Thu, 1 Apr 2010 16:10:47 +0000 (18:10 +0200)]
s3:winbindd: remove unused variables
metze
(cherry picked from commit
e18ddb6036f5e0a2211e89a7c9b5514c30a653cf)
(cherry picked from commit
c64c867c307d32b8ec17d6e079395e0e9b604f00)
Stefan Metzmacher [Thu, 1 Apr 2010 14:23:06 +0000 (16:23 +0200)]
s3:winbindd: fix problems with SIGCHLD handling (bug #7317)
The main problem is that we call CatchChild() within the
parent winbindd, which overwrites the signal handler
that was registered by winbindd_setup_sig_chld_handler().
That means winbindd_sig_chld_handler() and winbind_child_died()
are never triggered when a winbindd domain child dies.
As a result will get "broken pipe" for all requests to that domain.
To reduce the risk of similar bugs in future we call
CatchChild() in winbindd_reinit_after_fork() now.
We also use a full winbindd_reinit_after_fork() in the
cache validation child now instead instead of just resetting
the SIGCHLD handler by hand. This will also fix possible
tdb problems on systems without pread/pwrite and disabled mmap
as we now correctly reopen the tdb handle for the child.
metze
(cherry picked from commit
73577205cf81644e7fe853eaf3e6459f7f443096)
(cherry picked from commit
e0ece652956292cc67383535a0fa174b5015d91e)
Stefan Metzmacher [Mon, 29 Mar 2010 20:03:55 +0000 (22:03 +0200)]
s3:winbindd: correctly retry if the netlogon pipe gets disconnected during a logon call
This fixes hopefully the last part of bug #7295.
metze
(cherry picked from commit
4c6cde99c0751a073120d8bc36d40922d8027344)
(cherry picked from commit
482518fcafb18bda1f084ebf1906a2ad02436b80)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 12:45:19 +0000 (14:45 +0200)]
s3:winbindd_reconnect: don't only reconnect on NT_STATUS_UNSUCCESSFUL
metze
(cherry picked from commit
6bd5a2a3739938f95fce23ab2da652c9b5a48111)
(cherry picked from commit
169628fcb656ba5987a99bd50c7f588b731eae51)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 25 Mar 2010 14:25:47 +0000 (15:25 +0100)]
s3:winbindd_cm: invalidate connection if cm_connect_netlogon() fails
metze
(cherry picked from commit
94a4bcd2f0c0464e192556679c6636639cb307ea)
(cherry picked from commit
c046ae8428fb62ff2749689e7c738f1a2e8f8251)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 25 Mar 2010 14:17:07 +0000 (15:17 +0100)]
s3:winbindd: consistently use TALLOC_FREE(conn->foo_pipe) is we create a new connection
metze
(cherry picked from commit
4f391fedac7111683d13f2d79fee7c0dbc27f86e)
(cherry picked from commit
c462e54142c00fdd81c2847d16a75119b1cc89fc)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 12:42:04 +0000 (14:42 +0200)]
s3:winbindd_cm: use rpccli_is_connected() helper function
metze
(cherry picked from commit
d980c06a994d032a833adc8d56d2f2c037f8fdaf)
(cherry picked from commit
aa7d54ed04585a183a88363406ed7f3244b24d85)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 25 Mar 2010 14:14:02 +0000 (15:14 +0100)]
s3:winbindd_cm: use cli_state_is_connected() helper function
metze
(cherry picked from commit
408a3eb35a0e61b5d66a3b48ebbd1a6796672d0f)
(cherry picked from commit
00a93190d2cae31cd2213b810ea348c055670399)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Sun, 28 Mar 2010 17:34:34 +0000 (19:34 +0200)]
s3:rpc_client: return at least 10 sec as old timeout in rpccli_set_timeout() instead of 0
metze
(cherry picked from commit
3e70da3f470eeb122f95477fb48d89939f501b3e)
(cherry picked from commit
60861fba533027b6c9a0ff704b95dcf631ea3ca3)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 12:31:17 +0000 (14:31 +0200)]
s3:rpc_client: add set_timeout hook to rpc_cli_transport
metze
(cherry picked from commit
99664ad15460530b6fb44957b6c57823f09884bf)
(cherry picked from commit
89164eb8363ffc0b951256578be48d37ddba46b1)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 12:26:29 +0000 (14:26 +0200)]
s3:rpc_client: add rpccli_is_connected()
metze
(cherry picked from commit
4f41b53487ac9bc96c7960e8edab464558656373)
(similar to commit
958b49323968740e2cbf69dc2a0a5dd57d5bcf87)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 29 Mar 2010 12:58:19 +0000 (14:58 +0200)]
s3:rpc_client: don't mix layers and keep a reference to cli_state in the caller
We should not rely on the backend to have a reference to the cli_state.
This will make it possible for the backend to set its cli_state reference
to NULL, when the transport is dead.
metze
(cherry picked from commit
dc09b12681ea0e6d4c2b0f1c99dfeb1f23019c65)
(cherry picked from commit
1e2e47da82aeb249dce431541738a62cb139aebb)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 10:23:39 +0000 (12:23 +0200)]
s3:rpc_transport_np: use cli_state_is_connected() helper
metze
(cherry picked from commit
b862351da8624df893ec77e020a456c1d23c58ed)
(cherry picked from commit
8c2f4426ce178ac33748cfba01532ec2fd205710)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 25 Mar 2010 12:20:56 +0000 (13:20 +0100)]
s3:libsmb: add cli_state_is_connected() function
metze
(cherry picked from commit
d7bf30ef92031ffddcde3680b38e602510bcae24)
(cherry picked from commit
589f73924273e8a9b54669f42a92381661dcb33f)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 29 Mar 2010 16:23:40 +0000 (18:23 +0200)]
s3:libsmb: don't let cli_shutdown() segfault with a NULL cli_state
metze
(similar to commit
47e10ab9a85960c78af807b66b99bcd139713644)
(cherry picked from commit
957c0d4a5ee67ac70e576155a0f2f6f84cdb1596)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 10:22:54 +0000 (12:22 +0200)]
s3:rpc_transport_np: handle trans rdata like the output of a normal read
Inspired by bug #7159.
metze
(cherry picked from commit
911287285cc4c8485b75edfad3c1ece901a69b0b)
(cherry picked from commit
e2739a2bf37e654c37cbea6e510f63a7ce4adfea)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 12:14:53 +0000 (14:14 +0200)]
s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response.
Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit
36493bf2f6634b84c57107bcb86bcbf3e82e80fc)
(similar to commit
b58b359881c91ec382cfa1d6ba3007b8354b29cb)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 12:06:39 +0000 (14:06 +0200)]
Fix broken pipe handling
Metze is right: If we have *any* error at the socket level, we just can
not continue.
Also, apply some defensive programming: With this async stuff someone else
might already have closed the socket.
(cherry picked from commit
f140bf2e6578e45b8603d4a6c5feef9a3b735804)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 12:04:33 +0000 (14:04 +0200)]
s3:rpc_client: close the socket when pipe is broken
Signed-off-by: Bo Yang <boyang@samba.org>
(similar to commit
aa70e44cd0576e5280e24cf35000369a47dd958f)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 09:53:33 +0000 (11:53 +0200)]
s3: fix crash in winbindd (similar to commit
f8cc0e88fbbb082ead023e0cb437b1e12cf35459)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Karolin Seeger [Tue, 13 Apr 2010 18:06:14 +0000 (20:06 +0200)]
s3-docs: Fix typo in man idmap_ad.
Karolin
(cherry picked from commit
6389fac6db2f54d148222009b5e209cef5c6bdd7)
(cherry picked from commit
39dbf73a6fb4ad45eac259124b70042994d4f215)
Björn Jacke [Wed, 6 Jan 2010 23:41:50 +0000 (00:41 +0100)]
s3:lib/time: remove TIME_T_MIN/MAX defines
we already get them from lib/util/time.h
(cherry picked from commit
f5729dbb6e720cb6076ea053f1ad0680259e6b39)
The last two patches address bug #7352 (TIME_T_MAX defines inconsistent).
Björn Jacke [Wed, 6 Jan 2010 23:40:09 +0000 (00:40 +0100)]
lib/util: move TIME_T_MIN/MAX defines into header file (cherry picked from commit
571ee54b791b93ad46e09ed563ef4a5582dcf0c8)
Karolin Seeger [Mon, 12 Apr 2010 07:10:21 +0000 (09:10 +0200)]
WHATSNEW: Start release notes for Samba 3.4.8.
Karolin
Jeremy Allison [Fri, 19 Feb 2010 22:24:17 +0000 (14:24 -0800)]
Second part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns.
If server returns zero on a NP read. Report pipe broken.
Prevents client from looping if it thinks there should be
more data.
Jeremy.
(cherry picked from commit
0055e33dbed0e81548464d01bcf864255bab3159)
(cherry picked from commit
f5ca9f84e9b511c2ba7a4280b1997daa441f9877)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 6 Apr 2010 10:20:02 +0000 (12:20 +0200)]
First part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns.
Ensure that subreq is *always* talloc_free'd in the _done
function, as it has an event timeout attached. If the
read requests look longer than the cli->timeout, then
the timeout fn is called with already freed data.
Jeremy.
(cherry picked from commit
ad77ae1d5870e06f8587ecf634e0b6bdcbb950d7)
(similar to commit
6e5b6b5acb30869eb63b25ed1406014101a5e89d)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 5 Apr 2010 22:16:22 +0000 (15:16 -0700)]
s3: Fix bug 7326 -- can't write with vfs_full_audit active
Bo Yang [Tue, 9 Feb 2010 09:02:20 +0000 (17:02 +0800)]
s3: signals are processed twice in child.
Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit
8c8bb51de1ac2baa46ac0736fae12c034288e5d4)
Fix bug #7206 (duplicate signal handler, signals are processed twice in child
process).
Jeremy Allison [Wed, 31 Mar 2010 05:24:19 +0000 (22:24 -0700)]
Fix bug 7310 - DOS attribute inconsistency with MS Office
On rename we need to set the archive bit on the renamed file.
Jeremy
Jeremy Allison [Mon, 29 Mar 2010 21:24:18 +0000 (14:24 -0700)]
Fix bug 7307 - man net usershare mistake
Fix bad usage message, reported by headset001@yahoo.com.
Jeremy.
(cherry picked from commit
e14a6fbf8c9e4d16b2727e48c708ceccfd157e59)
(cherry picked from commit
9620f5fbe64910d86cae51345156a1a4dd71e231)
Jeremy Allison [Fri, 26 Mar 2010 00:09:23 +0000 (17:09 -0700)]
Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.
Ensure we don't dereference an array with an index of -1.
Jeremy.
(cherry picked from commit
e4127ab299e654777c43d983b2e0a158baa7d79a)
Kai Blin [Fri, 26 Mar 2010 21:28:43 +0000 (14:28 -0700)]
s3 ntlm_auth: Don't malloc data that will be talloc_free()d
This fixes bug #7290
Thanks to Mohan <mohann@silver-peak.com> for the bug report.
Michael Karcher [Thu, 25 Mar 2010 00:33:21 +0000 (17:33 -0700)]
Fix bug #7269 - Job management commands don't work for CUPS queues.
Samba needs to retrieve pjob->sysjob from the CUPS response (as
is done in the iprint backend).
(cherry picked from commit
1790e88f0f9c4fae90dcb53101f70c97ba6a6a5d)
Jeremy Allison [Thu, 18 Mar 2010 10:21:15 +0000 (11:21 +0100)]
s3-printing: Fix "printer admin" functionality.
Fix bug #7255 ("printer admin" parameter does not work as expected).
(cherry picked from commit
0d6d068bc4f76c2816f969fcce6013e1945794d4)
(cherry picked from commit
e74ced9f90ade37fa7bd179a91803f775c77e25b)
Günther Deschner [Tue, 16 Mar 2010 09:30:04 +0000 (10:30 +0100)]
s3-spoolss: Fix value-needed calculation in_spoolss_EnumPrinterData().
Guenther
Fix bug #7256 (incorrect value-needed calculation in
_spoolss_EnumPrinterData()).
(cherry picked from commit
400801c2314c5effd5165e77cdefc833dee1b6b2)
Volker Lendecke [Sun, 14 Mar 2010 20:18:34 +0000 (21:18 +0100)]
s3: Fix an uninitialized variable read
Found by Laurent Gaffie <laurent.gaffie@gmail.com>
Thanks for that,
Volker
Fix bug #7254 (An uninitialized variable read could cause an smbd crash).
(cherry picked from commit
9280051bfba337458722fb157f3082f93cbd9f2b)
Michael Adam [Mon, 8 Mar 2010 22:37:21 +0000 (23:37 +0100)]
s3:release-scripts: fix create-tarball to treat vendor patch level correctly
(cherry picked from commit
b845025daf2da85eb1af6cbfa7878cf59a32f2a6)
(cherry picked from commit
95c6a5a782caa77bc8bbe75de6ca249bc255507e)
Günther Deschner [Tue, 9 Mar 2010 13:08:57 +0000 (14:08 +0100)]
s3: re-run make samba3-idl.
Guenther
The last 16 patches address bug #6727 (Printer issues on 3.4.x).
Günther Deschner [Mon, 7 Dec 2009 10:28:56 +0000 (11:28 +0100)]
s3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx.
Guenther
(cherry picked from commit
ef9d6580efc55ee040458b7cd76ebdc2e1276e98)
Günther Deschner [Thu, 4 Mar 2010 16:58:49 +0000 (17:58 +0100)]
s3-libads: fix get_remote_printer_publishing_data after spoolss_EnumPrinterDataEx IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:47:10 +0000 (16:47 +0100)]
s3-rpcclient: fix rpcclient after spoolss_EnumPrinterDataEx IDL change.
Guenther
(cherry picked from commit
becbb624eb90b84ff20b128de1aee5f5acfc3dbc)
Günther Deschner [Thu, 4 Mar 2010 15:46:53 +0000 (16:46 +0100)]
s3-net: fix net after spoolss_EnumPrinterDataEx IDL change.
Guenther
(cherry picked from commit
a99ac4f236d9a93d4ca8bd874cbab89b155c644a)
Günther Deschner [Thu, 4 Mar 2010 15:47:33 +0000 (16:47 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx after idl
Guenther
(cherry picked from commit
55326549852a3ab1114a8cb1536578ae02183eb8)
Günther Deschner [Thu, 4 Mar 2010 15:40:31 +0000 (16:40 +0100)]
spoolss: fix spoolss_EnumPrinterDataEx IDL.
Guenther
(cherry picked from commit
4df1047e8398a9af4df94c7e245d993d1f60ef5f)
Günther Deschner [Thu, 4 Mar 2010 14:46:28 +0000 (15:46 +0100)]
s3-rpcclient: fix rpcclient after spoolss_GetPrinterData{Ex} IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:39:59 +0000 (15:39 +0100)]
s3-spoolss: fix _spoolss_GetPrinterDataEx after IDL change.
Guenther
(cherry picked from commit
fbb6d00eed6bca960aa53a5967a2dea426cacfe2)
Günther Deschner [Fri, 4 Dec 2009 23:52:28 +0000 (00:52 +0100)]
s3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx.
Guenther
Günther Deschner [Tue, 9 Mar 2010 12:20:10 +0000 (13:20 +0100)]
spoolss: rollback GetPrinterData{Ex} IDL.
Guenther