Matthias Dieter Wallnöfer [Wed, 25 Nov 2009 08:15:39 +0000 (09:15 +0100)]
util/util_strlist - add a call "const_str_list" for making "unconst" lists "const"
Endi S. Dewata [Tue, 24 Nov 2009 07:00:45 +0000 (01:00 -0600)]
s4:kdc - Merged kdc_tcp_accept() and kpasswdd_tcp_accept().
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Endi S. Dewata [Tue, 24 Nov 2009 04:28:11 +0000 (22:28 -0600)]
s4:kdc - Merged kdc_add_kdc_socket() and kdc_add_kpasswd_socket().
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Endi S. Dewata [Fri, 20 Nov 2009 20:57:11 +0000 (14:57 -0600)]
s4 - Create default modules directory.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Endi S. Dewata [Fri, 20 Nov 2009 14:47:40 +0000 (08:47 -0600)]
s4:kdc - Disable KDC port when it's set to 0.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Tue, 1 Dec 2009 05:12:53 +0000 (16:12 +1100)]
Merge commit 'origin/master' into abartlet-devel
Andrew Bartlett [Tue, 1 Dec 2009 05:06:59 +0000 (16:06 +1100)]
On our way to Samba4 alpha10!
Andrew Bartlett [Tue, 1 Dec 2009 03:43:55 +0000 (14:43 +1100)]
Fix build of Samba4 from tarball generated by mkrelease.sh
Revert "Remove RFC's from the release tarballs to make the lives of the Debian"
This reverts commit
eda7f35bc891ca4a7505ec054a2b4591c6edfb38.
These files are essential to the Samba4 build.
Andrew Bartlett
Andrew Bartlett [Tue, 1 Dec 2009 02:03:17 +0000 (13:03 +1100)]
Improve upgrade instructions
Andrew Tridgell [Mon, 30 Nov 2009 11:49:39 +0000 (22:49 +1100)]
s4-ldb: the '1' form of extended_dn search is easier to read
The '1' form gives GUIDs and SIDs in the ascii form as normally used
for display.
Andrew Bartlett [Tue, 1 Dec 2009 01:27:09 +0000 (12:27 +1100)]
This is alpha9
Andrew Bartlett [Mon, 30 Nov 2009 22:04:21 +0000 (09:04 +1100)]
s4:setup Adjust upgradeprovision blackbox test now we don't have --targetdir
Matthieu Patou [Sun, 29 Nov 2009 16:44:08 +0000 (19:44 +0300)]
s4: Remove targetdir as it can cause some trouble and can be replaced by an adapted -s smb.conf
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Sun, 29 Nov 2009 13:26:31 +0000 (16:26 +0300)]
s4: Handle the case in secrets.ldb without name attribute
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Sat, 28 Nov 2009 23:28:26 +0000 (02:28 +0300)]
s4: don't forget to update defaultSecurityDescriptor
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 27 Nov 2009 17:50:04 +0000 (20:50 +0300)]
s4: load the domain level of the current provision and create a provision with the same domain level
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Mon, 30 Nov 2009 07:39:58 +0000 (18:39 +1100)]
s4:ldap.py Add test of namingContext behaviour after tridge found a bug
Tridge found that the partitions.c module was being initialised twice,
and setting the partitions into the rootDSE twice.
Andrew Bartlett
Andrew Bartlett [Mon, 30 Nov 2009 03:46:03 +0000 (14:46 +1100)]
s4:WHATSNEW Nadezhda's acl module handles modifies
Jeremy Allison [Tue, 1 Dec 2009 00:56:35 +0000 (16:56 -0800)]
Fix DEBUG 0 -> DEBUG 10 (left over code).
Fix opendir status return if access denied.
Jeremy.
Jeremy Allison [Tue, 1 Dec 2009 00:50:34 +0000 (16:50 -0800)]
Fix bug 6938 : No hook exists to check creation rights when using acl_xattr module
Fix ACL modules to test for permissions on open/mkdir/opendir.
Ensure that underlying ACLs are returned for directories/files with
no Windows xattr or tdb acls stored.
Jeremy.
Günther Deschner [Tue, 1 Dec 2009 00:22:44 +0000 (01:22 +0100)]
s3-build: taise tdb version when building against system libtdb library.
Try to fix the build on "buildsamba02". At least fixes the build on fedora12
with libtdb-devel-1.1.5-2.fc12.x86_64 installed.
Volker, please check.
Guenther
Michael Adam [Mon, 30 Nov 2009 23:53:03 +0000 (00:53 +0100)]
s3:add split_tokens, a cmdline tool to test next_token_talloc()
Michael
Michael Adam [Fri, 20 Nov 2009 17:25:27 +0000 (18:25 +0100)]
s3:fix linking of the t_str* test programs
Michael
Michael Adam [Fri, 20 Nov 2009 17:24:53 +0000 (18:24 +0100)]
s3:fix linking of libbigballofmud (on my box at least)
Michael
Michael Adam [Fri, 20 Nov 2009 16:48:18 +0000 (17:48 +0100)]
s3:torture: make t_stringoverflow.c compile at least (pstring is long gone)
I don't know whether these t_* programs are used at all any more, but this
one was using pstrcpy...
Michael
Jeremy Allison [Mon, 30 Nov 2009 23:53:04 +0000 (15:53 -0800)]
Restructure the connect function code to always call
down to NEXT-> before initializing. This allows us to
do cleanup (by calling DISCONNECT) if initialization
fails. Also fix vfs_acl_xattr which was failing to
call the NEXT connect function.
Jeremy.
Günther Deschner [Mon, 30 Nov 2009 23:24:16 +0000 (00:24 +0100)]
drsuapi: fix build warning of NDR size calculation of drsuapi_DsReplicaObjectIdentifier3Binary.
The generated size actually does not include the size of the binary itself.
Guenther
Günther Deschner [Mon, 30 Nov 2009 17:10:59 +0000 (18:10 +0100)]
s3-spoolss: fix fstrings in convert_devicemode() function.
Guenther
Volker Lendecke [Mon, 30 Nov 2009 20:48:33 +0000 (21:48 +0100)]
Fix bug 6546: Avoid accessing buf[-1] if NUL byte comes from fgets
Karolin Seeger [Mon, 30 Nov 2009 13:53:23 +0000 (14:53 +0100)]
s3:docs: Fix typo in man mount.cifs.
Fix bug #6844 (wrong credential file format in mount.cifs manpage).
Thanks to the Debian Samba package maintainers for reporting!
Karolin
Karolin Seeger [Mon, 30 Nov 2009 12:34:34 +0000 (13:34 +0100)]
s3:docs: Document "aio write behind".
Part of a fix for bug #6890 (Some smb.conf parameters are undocumented).
Karolin
Karolin Seeger [Mon, 30 Nov 2009 11:29:27 +0000 (12:29 +0100)]
s3:docs: Document "ldap page size".
Part of a fix for bug #6890 (Some smb.conf parameters are undocumented).
Karolin
Bo Yang [Mon, 30 Nov 2009 09:30:25 +0000 (17:30 +0800)]
s3: Fix crash in free_file_list().
Signed-off-by: Bo Yang <boyang@samba.org>
Karolin Seeger [Mon, 30 Nov 2009 10:40:06 +0000 (11:40 +0100)]
s3:docs: Document "enable core files".
Part of a fix for bug #6890 (Some smb.conf parameters are undocumented).
Karolin
Fernando J V da Silva [Fri, 27 Nov 2009 14:25:18 +0000 (12:25 -0200)]
s4-drs: Test situations for runtime constructed parentGUID
Includes the following verifications for the constructed parentGUID:
- Checks if it returns nothing when there is no parent object
- Ensures that attributes mentioned after the parentGUID
are returned correctly (this avoid a bug pointed out by Tridge
during sync constructed parentGUID development)
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Fernando J V da Silva [Wed, 25 Nov 2009 20:01:55 +0000 (17:01 -0300)]
s4-drs: Using dsdb_msg_add_guid() utility function
Uses the dsdb_msg_add_guid() to add any kind of GUID attribute
to a ldb_message in several places of samba4 code.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Karolin Seeger [Mon, 30 Nov 2009 10:04:50 +0000 (11:04 +0100)]
s3:docs: Document "cache directory" and "state directory".
Part of a fix for bug #6890 (Some smb.conf parameters are undocumented).
Karolin
Volker Lendecke [Sun, 29 Nov 2009 22:31:45 +0000 (23:31 +0100)]
s3: Fix bug 6288
Crístian Deives [Mon, 30 Nov 2009 09:12:24 +0000 (20:12 +1100)]
s4-drs: add deletion of old connections
the nTDSConnection objects that are not needed anymore will be deleted.
the function kccsrv_delete_connection wasn't tested yet.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Crístian Deives [Mon, 23 Nov 2009 17:47:51 +0000 (15:47 -0200)]
s4-ldb: changed ldb_msg_add_dn() to ldb_msg_add_linearized_dn()
this makes the usage clearer
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Crístian Deives [Mon, 30 Nov 2009 09:11:27 +0000 (20:11 +1100)]
s4-drs: Create connection obejct (nTDSConnection)
create nTDSConnection objects to match the list of servers
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Tridgell [Mon, 30 Nov 2009 06:47:56 +0000 (17:47 +1100)]
s4-ldb: check for -ve value for page size
This comes from a tip from Howard Chu. Apparently some clients
will send a -ve page size value.
Andrew Tridgell [Mon, 30 Nov 2009 05:48:31 +0000 (16:48 +1100)]
s4-dsdb: don't call ldb_next_init() twice in objectclass module
Volker Lendecke [Sun, 29 Nov 2009 22:42:44 +0000 (23:42 +0100)]
s3: Fix a "not handled in switch" warning
Volker Lendecke [Sun, 29 Nov 2009 21:57:19 +0000 (22:57 +0100)]
s3: Fix an uninitialized variable reference
Volker Lendecke [Sun, 29 Nov 2009 21:23:22 +0000 (22:23 +0100)]
s3: Fix some nonempty blank lines
Volker Lendecke [Sun, 29 Nov 2009 15:05:36 +0000 (16:05 +0100)]
s3: Add a regression test for bug 6898
Volker Lendecke [Sun, 29 Nov 2009 15:04:21 +0000 (16:04 +0100)]
s3: Factor out torture_setup_unix_extensions
Matthias Dieter Wallnöfer [Sun, 29 Nov 2009 13:55:20 +0000 (14:55 +0100)]
lib/registry/util.c - Reorder the registry datatypes of the conversion functions
This is absolutely cosmetic and makes the code easier to comprehend.
Matthias Dieter Wallnöfer [Sun, 29 Nov 2009 13:42:31 +0000 (14:42 +0100)]
Revert "s4:registry/util - Don't include the trailing '\0' in the internal data format but add it on the back-conversion to a string"
This reverts commit
7d400715e9af2056690c03a1a2f45c7f343fa313.
"convert_string_talloc_convenience" does always add the NULL termination. Didn't
know that. Thanks Jelmer for pointing out!
Volker Lendecke [Fri, 27 Nov 2009 14:44:50 +0000 (15:44 +0100)]
s3: Restore "fake directory create times" as a share parameter
Volker Lendecke [Fri, 27 Nov 2009 14:10:23 +0000 (15:10 +0100)]
s3: "copy_reg" only looks at mode, uid, gid, atime and mtime (no birthtime)
Volker Lendecke [Fri, 27 Nov 2009 13:58:46 +0000 (14:58 +0100)]
s3: Pass up fake_dir_create_times from atalk_build_paths
The callers only look at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:19:30 +0000 (13:19 +0100)]
s3: Move directory_exist_stat to testparm.c, it only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:17:05 +0000 (13:17 +0100)]
s3: Pass fake_dir_create_times down to file_exist_stat, none of the callers look at the mtime
Volker Lendecke [Fri, 27 Nov 2009 12:12:40 +0000 (13:12 +0100)]
s3: "startsmbfilepwent" only looks at the inode -- is that enough?
Volker Lendecke [Fri, 27 Nov 2009 12:11:17 +0000 (13:11 +0100)]
s3: "get_file_size" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:10:48 +0000 (13:10 +0100)]
s3: "socket_exist" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:08:51 +0000 (13:08 +0100)]
s3: "sys_path_to_bdev" only looks at the devicenumber
Volker Lendecke [Fri, 27 Nov 2009 12:07:54 +0000 (13:07 +0100)]
s3: "check_log_size" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:07:12 +0000 (13:07 +0100)]
s3: "regf_hbin_allocate" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:06:44 +0000 (13:06 +0100)]
s3: "read_block" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:06:14 +0000 (13:06 +0100)]
s3: "write_block" does not use the sbuf at all
Volker Lendecke [Fri, 27 Nov 2009 12:05:16 +0000 (13:05 +0100)]
s3: "net_conf_addshare" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:04:38 +0000 (13:04 +0100)]
s3: "net_usershare_add" only looks at the mode, device and inode
Volker Lendecke [Fri, 27 Nov 2009 12:04:18 +0000 (13:04 +0100)]
s3: "net_usershare_add" only looks at the device and inode
Volker Lendecke [Fri, 27 Nov 2009 12:03:09 +0000 (13:03 +0100)]
s3: "net_usershare_add" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:02:26 +0000 (13:02 +0100)]
s3: "count_num_usershares" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:01:46 +0000 (13:01 +0100)]
s3: "info_fn" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:00:51 +0000 (13:00 +0100)]
s3: "get_share_list" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:00:10 +0000 (13:00 +0100)]
s3: "cgi_download" only looks at the mode and size
Volker Lendecke [Fri, 27 Nov 2009 11:59:11 +0000 (12:59 +0100)]
s3: "print_job_end" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 11:58:26 +0000 (12:58 +0100)]
s3: "check_magic" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 11:57:43 +0000 (12:57 +0100)]
s3: "disk_quotas" only looks at the devicenumber
Volker Lendecke [Fri, 27 Nov 2009 11:53:48 +0000 (12:53 +0100)]
s3: "load_usershare_shares" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 11:53:23 +0000 (12:53 +0100)]
s3: "load_usershare_service" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 11:52:31 +0000 (12:52 +0100)]
s3: "usershare_exists" only looks at the mode and mtime
Volker Lendecke [Fri, 27 Nov 2009 11:51:56 +0000 (12:51 +0100)]
s3: "process_usershare_file" only looks at the dev, ino, mode and size
Volker Lendecke [Fri, 27 Nov 2009 11:51:04 +0000 (12:51 +0100)]
s3: "process_usershare_file" only looks at the mode and size
Volker Lendecke [Fri, 27 Nov 2009 11:49:42 +0000 (12:49 +0100)]
s3: "parse_usershare_file" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 11:48:33 +0000 (12:48 +0100)]
s3: "tar_parseargs" only looks at the mtime
Volker Lendecke [Fri, 27 Nov 2009 11:47:57 +0000 (12:47 +0100)]
s3: "dotareof" only looks at the file type
Volker Lendecke [Fri, 27 Nov 2009 11:44:33 +0000 (12:44 +0100)]
s3: client "newer" does not look at the create timestamp
Volker Lendecke [Fri, 27 Nov 2009 11:42:39 +0000 (12:42 +0100)]
s3: Pass the "fake dir create times" parameter to sys_*stat
Step 0 to restore it as a per-share paramter
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 18:23:08 +0000 (19:23 +0100)]
s4:upgrade_from_s3 - Move it back to "setup"
Suggested by Jelmer
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 16:03:57 +0000 (17:03 +0100)]
s4:setup/provision - Rework
- Revert change in "ask" - was previously correct
- Readd accidentally removed checks for non-null realm and domainname
- On interactive mode perform only one "ask" call per question
- Inform the user about the unset administrator password
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 17:48:47 +0000 (18:48 +0100)]
s4:upgrade.py - remove my copyright
First I wanted to add also other changes but then I didn't introduce them.
Therefore remove my copyright again.
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 15:59:18 +0000 (16:59 +0100)]
s4:upgrade.py - readd accidentally removed empty lines
Jelmer pointed out that this is against the PEP8 norm
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 14:28:45 +0000 (15:28 +0100)]
s4:samba3.py/upgrade.py: Revert
This reverts commit
2175c0ed0649d545ea833d50e8d33fbee9051c35.
This reverts commit
6c3e2417a0639cd7c367de93615c422cf5217456.
This reverts commit
dbb8989e05ac3189a5eca11fa40d572388ea02fc.
This reverts commit
82adfa39b75aa628c88f828278c6ac09335d1a49.
This reverts commit
f299efa8f05c6a5b739222bdf75690a4591d3650.
After a small discussion with Jelmer we agreed that this isn't the right way
to fix the problem. We should wait for a real patch rather to rely on temporal
hacks.
Andrew Tridgell [Sat, 28 Nov 2009 06:35:36 +0000 (17:35 +1100)]
s4-ldb: make it much easier to use common ldb controls
Andrew Tridgell [Sat, 28 Nov 2009 02:27:06 +0000 (13:27 +1100)]
s4-drs: cope with bogus empty attributes from w2k8-r2
w2k8-r2 sometimes sends empty attributes with completely bogus attrid
values in a DRS replication response. This allows us to continue with
the vampire operation despite these broken elements.
Matthieu Patou [Fri, 27 Nov 2009 14:37:14 +0000 (17:37 +0300)]
s4: fix SD update and password change in upgrade script
- reserve a new Samba OID for recalculate SD control
- fix the update SD function
- fix handling of kvno in the update_machine_account_password function
- fix handling of handles in RPC winreg server
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 07:48:30 +0000 (08:48 +0100)]
s4:WINREG RPC server - add another "talloc_unlink" in "DeleteKey"
Also here we waste memory - therefore free the pointless handle after the delete.
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 09:24:09 +0000 (10:24 +0100)]
s4:WINREG RPC server - Reintroduce the free operation on "CloseKey"
Better use "talloc_unlink" here Since we could have more than one reference.
Günther Deschner [Fri, 27 Nov 2009 22:14:27 +0000 (23:14 +0100)]
s4-smbtorture: more and stricter tests for printer and data keys in RPC-SPOOLSS.
Guenther
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:39:52 +0000 (22:39 +0100)]
s4:provision.py - remove hardcoded SIDs and RIDs
After rework of the SDDL modules this is possible. In future: Never hardcode
them anymore! Always use the abbreviations.
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:37:52 +0000 (22:37 +0100)]
s4:security/sddl - rework of the security descriptor abbreviations
- Reoder them
- Add some new ones (needed for the security descriptor in the provision script)
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:36:59 +0000 (22:36 +0100)]
security.idl - Add some more wellknown SIDs/RIDs
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 20:14:44 +0000 (21:14 +0100)]
s4:registry/util - Don't include the trailing '\0' in the internal data format but add it on the back-conversion to a string
As far as I know the registry library saves all data (including) strings without
the null termination. So do it also here in a similar way.
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 19:26:17 +0000 (20:26 +0100)]
s4:net utility - add a notice for the "help" operation and format it's output of the command list better