From: Volker Lendecke <vl@samba.org>
Date: Wed, 5 Sep 2012 13:24:46 +0000 (+0200)
Subject: s3: Slightly simplify is_stat_open
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=c034ff7b1516f827ab4538613ec98daa170d9f25;p=mat%2Fsamba.git

s3: Slightly simplify is_stat_open

The "access_bits" clause is redundant. is_stat_open says that exactly
at least one of the stat_open_bits must be set and none else.

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Sep 25 20:05:06 CEST 2012 on sn-devel-104
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index eff78d4533..34d552620d 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -1071,9 +1071,8 @@ bool is_stat_open(uint32 access_mask)
 		 FILE_READ_ATTRIBUTES|
 		 FILE_WRITE_ATTRIBUTES);
 
-	return (access_mask &&
-		((access_mask & ~stat_open_bits) == 0) &&
-		((access_mask & stat_open_bits) != 0));
+	return (((access_mask &  stat_open_bits) != 0) &&
+		((access_mask & ~stat_open_bits) == 0));
 }
 
 /****************************************************************************