From: Gary Lockyer Date: Tue, 7 May 2019 04:30:22 +0000 (+1200) Subject: s4 lib socket: Ensure address string owned by parent struct X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=ae9fb93393bcadbc71328335e481e4381ecb65bf;p=metze%2Fsamba%2Fwip.git s4 lib socket: Ensure address string owned by parent struct The local address string was not owned by it's parent structure, which caused a use after free error in continue_ip_open_socket source4/librpc/rpc/dcerpc_sock.c:267 BUG: https://bugzilla.samba.org/show_bug.cgi?id=13929 Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed May 8 20:03:42 UTC 2019 on sn-devel-184 --- diff --git a/source4/lib/socket/socket_ip.c b/source4/lib/socket/socket_ip.c index fd109a3eacdc..2aba491e06cc 100644 --- a/source4/lib/socket/socket_ip.c +++ b/source4/lib/socket/socket_ip.c @@ -999,7 +999,7 @@ static struct socket_address *ipv6_tcp_get_my_addr(struct socket_context *sock, return NULL; } - local->addr = talloc_strdup(mem_ctx, addrstring); + local->addr = talloc_strdup(local, addrstring); if (!local->addr) { talloc_free(local); return NULL;