From: Bill Meier <wmeier@newsguy.com>
Date: Thu, 6 Dec 2012 23:11:54 +0000 (-0000)
Subject: Revert SVN #46429 again (for now);
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=9384bedb1355df6db7bf1a8cef38903f2895b340;p=metze%2Fwireshark%2Fwip.git

Revert SVN #46429 again (for now);

It appears that the compiler on
the OSX-10.5-x86 buildbot must be pretty old.

All the other *nix buildbot compilers do not
check the dummy param names used in the definition
of 'xxx' below to see if they are shadowing
anything.

void foo(tvbuff_t tvb, ...) {
  'void (*xxx)(tvbuff_t tvb, ....) = NULL;'
  ...
}

I do seem to remember reading that gcc once
had this issue but was fixed eventually.


svn path=/trunk/; revision=46430
---

diff --git a/configure.ac b/configure.ac
index 5d927031f2..1f528d7fd4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -411,6 +411,10 @@ AC_ARG_ENABLE(extra-gcc-checks,
 		AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wmissing-prototypes)
 		AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wmissing-declarations)
 		#
+		# epan/dissectors/packet-afs.c blocks this one for now.
+		#
+		AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wshadow)
+		#
 		# More cleanup needed for this on LP64.
 		#
 		AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wshorten-64-to-32)
@@ -426,7 +430,6 @@ AC_WIRESHARK_GCC_CFLAGS_CHECK(-Warray-bounds)
 AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wcast-align)
 AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wformat-security)
 AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wold-style-definition, C)
-AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wshadow, C)                           ## OK for C++ ??
 AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wno-error=unused-but-set-variable)    ##  for now
 #
 # Use the faster pre gcc 4.5 floating point precision if available;