From: Matthias Dieter Wallnöfer <mdw@samba.org>
Date: Sat, 12 Jun 2010 15:50:52 +0000 (+0200)
Subject: s4:dcesrv_samr_GetGroupsForUser - return error code if a SID wasn't found
X-Git-Tag: samba-3.6.0pre1~1119
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=731b4469cb3b074a39b21fee220517af3df26a68;p=samba.git

s4:dcesrv_samr_GetGroupsForUser - return error code if a SID wasn't found

This shouldn't happen since SIDs are mandatory for security objects
---

diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c
index c11caee877c..9aab2b8b438 100644
--- a/source4/rpc_server/samr/dcesrv_samr.c
+++ b/source4/rpc_server/samr/dcesrv_samr.c
@@ -3418,8 +3418,7 @@ static NTSTATUS dcesrv_samr_GetGroupsForUser(struct dcesrv_call_state *dce_call,
 
 		group_sid = samdb_result_dom_sid(mem_ctx, res[i], "objectSid");
 		if (group_sid == NULL) {
-			DEBUG(0, ("Couldn't find objectSid attrib\n"));
-			continue;
+			return NT_STATUS_INTERNAL_DB_CORRUPTION;
 		}
 
 		array->rids[i + 1].rid =