From: Andreas Schneider <asn@samba.org>
Date: Thu, 31 Aug 2023 09:23:03 +0000 (+0200)
Subject: s3:libnetapi: Use dcerpc_lsa_open_policy_fallback() in localgroup.c
X-Git-Tag: talloc-2.4.2~598
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=4f7c395cd3d5cab9969a7778d0a5c3bca30d3db2;p=samba.git

s3:libnetapi: Use dcerpc_lsa_open_policy_fallback() in localgroup.c

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/lib/netapi/localgroup.c b/source3/lib/netapi/localgroup.c
index 5d6ad174fb1..a63fca4366a 100644
--- a/source3/lib/netapi/localgroup.c
+++ b/source3/lib/netapi/localgroup.c
@@ -968,6 +968,12 @@ static NTSTATUS libnetapi_lsa_lookup_names3(TALLOC_CTX *mem_ctx,
 
 	struct lsa_String names;
 	uint32_t num_names = 1;
+	union lsa_revision_info out_revision_info = {
+		.info1 = {
+			.revision = 0,
+		},
+	};
+	uint32_t out_version = 0;
 
 	if (!sid || !name) {
 		return NT_STATUS_INVALID_PARAMETER;
@@ -977,13 +983,21 @@ static NTSTATUS libnetapi_lsa_lookup_names3(TALLOC_CTX *mem_ctx,
 
 	init_lsa_String(&names, name);
 
-	status = rpccli_lsa_open_policy2(lsa_pipe, mem_ctx,
-					 false,
-					 SEC_STD_READ_CONTROL |
-					 LSA_POLICY_VIEW_LOCAL_INFORMATION |
-					 LSA_POLICY_LOOKUP_NAMES,
-					 &lsa_handle);
-	NT_STATUS_NOT_OK_RETURN(status);
+	status = dcerpc_lsa_open_policy_fallback(
+		b,
+		mem_ctx,
+		lsa_pipe->srv_name_slash,
+		false,
+		SEC_STD_READ_CONTROL |
+		LSA_POLICY_VIEW_LOCAL_INFORMATION |
+		LSA_POLICY_LOOKUP_NAMES,
+		&out_version,
+		&out_revision_info,
+		&lsa_handle,
+		&result);
+	if (any_nt_status_not_ok(status, result, &status)) {
+		return status;
+	}
 
 	status = dcerpc_lsa_LookupNames3(b, mem_ctx,
 					 &lsa_handle,